[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047739#comment-15047739 ] Hadoop QA commented on HBASE-14869: --- {color:red}-1 overall{color}. Test results: ht

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-08 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047261#comment-15047261 ] Andrew Purtell commented on HBASE-14869: +1 > Better request latency histograms

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-08 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047239#comment-15047239 ] Lars Hofhansl commented on HBASE-14869: --- There's one last change I think we should

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-08 Thread Vikas Vishwakarma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046758#comment-15046758 ] Vikas Vishwakarma commented on HBASE-14869: --- I deployed it to a cluster and did

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045388#comment-15045388 ] Andrew Purtell commented on HBASE-14869: Hey [~lhofhansl], want to commit this?

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045376#comment-15045376 ] Andrew Purtell commented on HBASE-14869: Then if there are no objections or furth

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-04 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041714#comment-15041714 ] Andrew Purtell commented on HBASE-14869: Ok, no further concerns here > Better r

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-03 Thread Vikas Vishwakarma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15040776#comment-15040776 ] Vikas Vishwakarma commented on HBASE-14869: --- For the metrics I am using _SizeRa

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-03 Thread Vikas Vishwakarma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15040770#comment-15040770 ] Vikas Vishwakarma commented on HBASE-14869: --- [~lhofhansl] I looked at splunk wh

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-03 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039738#comment-15039738 ] Lars Hofhansl commented on HBASE-14869: --- Cool. Metric name's the only open issue. I

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-03 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039719#comment-15039719 ] Andrew Purtell commented on HBASE-14869: Thanks Vikas. It would be a shame if we

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-03 Thread Vikas Vishwakarma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039678#comment-15039678 ] Vikas Vishwakarma commented on HBASE-14869: --- [~apurtell] thanks for the review.

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-03 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038333#comment-15038333 ] Andrew Purtell commented on HBASE-14869: The latest patches look lgtm. Are we su

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038186#comment-15038186 ] Hadoop QA commented on HBASE-14869: --- {color:red}-1 overall{color}. {color:gre

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-03 Thread Vikas Vishwakarma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037746#comment-15037746 ] Vikas Vishwakarma commented on HBASE-14869: --- the core test failure does not loo

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-02 Thread Vikas Vishwakarma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035567#comment-15035567 ] Vikas Vishwakarma commented on HBASE-14869: --- will check and fix these. > Bette

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035506#comment-15035506 ] Hadoop QA commented on HBASE-14869: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-12-01 Thread Vikas Vishwakarma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035248#comment-15035248 ] Vikas Vishwakarma commented on HBASE-14869: --- Attached patch for main branch als

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-30 Thread Vikas Vishwakarma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031581#comment-15031581 ] Vikas Vishwakarma commented on HBASE-14869: --- added the patch 14869-v4-0.98.txt

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-29 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031322#comment-15031322 ] Lars Hofhansl commented on HBASE-14869: --- -v3 looks good to me. I wonder whether it'

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-29 Thread Vikas Vishwakarma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031292#comment-15031292 ] Vikas Vishwakarma commented on HBASE-14869: --- [~lhofhansl] please review the att

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-28 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030687#comment-15030687 ] Lars Hofhansl commented on HBASE-14869: --- Why not subclass MutableHistogram? Would s

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-28 Thread Vikas Vishwakarma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030429#comment-15030429 ] Vikas Vishwakarma commented on HBASE-14869: --- [~lhofhansl] please review the att

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030186#comment-15030186 ] Lars Hofhansl commented on HBASE-14869: --- [~vik.karma] offered to finish this up. Th

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-25 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028244#comment-15028244 ] Lars Hofhansl commented on HBASE-14869: --- Hmm... Looking at all the metrics, I also

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026291#comment-15026291 ] Lars Hofhansl commented on HBASE-14869: --- Could also not report ranges without a hit

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-23 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022263#comment-15022263 ] Dave Latham commented on HBASE-14869: - We have 1 cluster where we keep everything in

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-22 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021615#comment-15021615 ] Yu Li commented on HBASE-14869: --- FWIW, 0-10ms/10-100ms/100-500ms/500-1000ms/>1000ms might b

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021532#comment-15021532 ] Lars Hofhansl commented on HBASE-14869: --- So what are good default latency bands? Wh

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-22 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021477#comment-15021477 ] Yu Li commented on HBASE-14869: --- Yes, found the totalCallTime metrics introduced by HBASE-8

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021078#comment-15021078 ] Lars Hofhansl commented on HBASE-14869: --- I think we have histograms for all these (

[jira] [Commented] (HBASE-14869) Better request latency histograms

2015-11-22 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020953#comment-15020953 ] Yu Li commented on HBASE-14869: --- {quote} It would be better to record the number of request