[GitHub] nifi issue #3165: NIFI-5318 Implement NiFi test harness

2018-12-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3165 @peter-gergely-horvath Tried your latest change and still get these results: ``` [INFO] --- [INFO] Running

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-12-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3105 Merged, thanks @zenfenan ---

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r241047229 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,369

[GitHub] nifi pull request #3214: NIFI-5890 Added a unit test that proves that 1.9 fi...

2018-12-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3214#discussion_r240980560 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #3214: NIFI-5890 Added a unit test that proves that 1.9 fi...

2018-12-11 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/3214 NIFI-5890 Added a unit test that proves that 1.9 fixes a bug in the d… …ate conversion behavior in 1.8. Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r240660225 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,291 @@ +nifi

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r240659974 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,369

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r240587144 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-api-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,226 @@ +nifi

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r240587170 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-api-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,226 @@ +nifi

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r240584516 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-api-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,266

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r240587016 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-api-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,226 @@ +nifi

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-12-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r240586483 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-api-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,226 @@ +nifi

[GitHub] nifi issue #3203: NIFI-5871 ignore UUID attribute when copying flow file att...

2018-12-05 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3203 AFAIK, there is no reason why uuid should be inherited by a flowfile even in a parent-child scenario since the child is a new flowfile branched off. ---

[GitHub] nifi issue #3203: NIFI-5871 ignore UUID attribute when copying flow file att...

2018-12-05 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3203 Approval still stands. Will wait to see what Travis does. ---

[GitHub] nifi pull request #3203: NIFI-5871 ignore UUID attribute when copying flow f...

2018-12-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3203#discussion_r239160879 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java --- @@ -496,7 +496,10 @@ public MockFlowFile putAllAttributes(FlowFile

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-12-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3105 @zenfenan you still working this? ---

[GitHub] nifi pull request #3165: NIFI-5318 Implement NiFi test harness

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3165#discussion_r236045789 --- Diff: nifi-testharness/src/test/resources/sample_technology_rss.xml --- @@ -0,0 +1,28 @@ + + --- End diff -- Yes, it absolutely

[GitHub] nifi issue #3165: NIFI-5318 Implement NiFi test harness

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3165 Will try to get back into it soon. BTW, thanks for putting it all back onto a branch. ---

[GitHub] nifi issue #3038: [NIFI-5646] Dockerfile.alpine: Added.

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3038 @apiri What do you think? > An alternative would be to put the Dockerfiles into subdirectories if the above is a limitation in the plugin. I think an alpine build would be a n

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r236041495 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r236041589 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r236041556 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r236041500 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r236041536 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r236041568 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r236041602 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3105 You also need to verify the LICENSE as well. ---

[GitHub] nifi pull request #3105: NIFI-5621: Added Cassandra connection provider serv...

2018-11-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3105#discussion_r236041517 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-services-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,327 @@ +nifi

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-11-23 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3105 @zenfenan I have a table with uuid primary key. How do I set a value for an insert in our processors for that field type (if you don't know can you recommend a schema for testing)? ---

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-11-23 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3105 Reviewing... ---

[GitHub] nifi issue #3167: NIFI-5812: Marked Database processors as 'PrimaryNodeOnly'

2018-11-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3167 @zenfenan If you're too busy, I can make that change and merge. ---

[GitHub] nifi pull request #3167: NIFI-5812: Marked Database processors as 'PrimaryNo...

2018-11-20 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3167#discussion_r234999192 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java

[GitHub] nifi pull request #3011: NIFI-5333 Added GetMongoRecord.

2018-11-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3011#discussion_r234461028 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongoRecord.java --- @@ -0,0

[GitHub] nifi pull request #3011: NIFI-5333 Added GetMongoRecord.

2018-11-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3011#discussion_r234457340 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongoRecord.java --- @@ -0,0

[GitHub] nifi issue #3011: NIFI-5333 Added GetMongoRecord.

2018-11-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3011 Thanks @zenfenan. Could you and/or @mattyb149 take a look at 4975 as well sometime? That's the GridFS support. Would really like to give NiFi the ability to work natively with that. ---

[GitHub] nifi pull request #3011: NIFI-5333 Added GetMongoRecord.

2018-11-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3011#discussion_r232453403 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/pom.xml --- @@ -101,6 +101,7 @@ org.apache.nifi

[GitHub] nifi pull request #2861: NIFI-5248 Added new Elasticsearch json and record p...

2018-10-30 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2861#discussion_r229396964 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi issue #2861: NIFI-5248 Added new Elasticsearch json and record processo...

2018-10-30 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2861 @mattyb149 review changes are in. ---

[GitHub] nifi issue #3041: NIFI-5224 Added SolrClientService.

2018-10-30 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3041 @mattyb149 changes made. ---

[GitHub] nifi pull request #2861: NIFI-5248 Added new Elasticsearch json and record p...

2018-10-30 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2861#discussion_r229264742 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2872: NIFI-5318 Implement NiFi test harness: initial comm...

2018-10-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2872#discussion_r228689270 --- Diff: nifi-testharness/src/test/java/org/apache/nifi/testharness/samples/Constants.java --- @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request #3041: NIFI-5224 Added SolrClientService.

2018-10-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3041#discussion_r228537197 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/pom.xml --- @@ -147,6 +147,12 @@ 2.2.1 test

[GitHub] nifi pull request #2872: NIFI-5318 Implement NiFi test harness: initial comm...

2018-10-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2872#discussion_r228511342 --- Diff: nifi-testharness/src/test/java/org/apache/nifi/testharness/samples/Constants.java --- @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request #3041: NIFI-5224 Added SolrClientService.

2018-10-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3041#discussion_r228507330 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrProcessor.java --- @@ -176,70 +172,11

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-10-25 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3105 Easiest way to do the L&N for your NAR here is this: `mvn dependency:tree | grep -i compile` Provided and test dependencies aren't part of the NAR, so only focus on compile. ---

[GitHub] nifi issue #2872: NIFI-5318 Implement NiFi test harness: initial commit of n...

2018-10-21 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2872 > Hi @MikeThomsen sorry for the delay, I have been just very busy. Thanks. I've got a lot on my plate as well, but will try to find some time early this week to review. ---

[GitHub] nifi issue #3079: NIFI-5706 : Added ConvertAvroToParquet processor

2018-10-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3079 From Jira: > PutParquet support is limited to HDFS. It's actually not. You can write it to the local file system by supplying a Hadoop configuration that tells it to

[GitHub] nifi issue #2861: NIFI-5248 Added new Elasticsearch json and record processo...

2018-10-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2861 @mattyb149 anything? ---

[GitHub] nifi pull request #3025: NIFI-5605 Added UpdateCassandra.

2018-10-15 Thread MikeThomsen
Github user MikeThomsen closed the pull request at: https://github.com/apache/nifi/pull/3025 ---

[GitHub] nifi issue #3025: NIFI-5605 Added UpdateCassandra.

2018-10-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3025 Going to close this because I think the consensus is that it should be folded into an existing processor. ---

[GitHub] nifi issue #2856: NIFI-4811 Added two missing entries to the nifi-redis-serv...

2018-10-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2856 @joewitt we should be good to go now. ---

[GitHub] nifi issue #3049: NIFI-5664 Support List in DataTypeUtils#toArray

2018-10-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3049 Cool. FYI, the long term goal is to make controller services the exclusive source of configurations for configurations. That's because a single `MongoClient` is really a connection pool a

[GitHub] nifi issue #3049: NIFI-5664 Support List in DataTypeUtils#toArray

2018-10-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3049 @snagacarl since this was for the Mongo lookup service, wanted to make sure that you're aware that in 1.8 there will be a slight breaking change. The "configuration" controller

[GitHub] nifi issue #3049: NIFI-5664 Support List in DataTypeUtils#toArray

2018-10-09 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3049 I'll try to review tonight. Been pretty sick. Thanks for the updates @snagacarl ---

[GitHub] nifi pull request #3049: NIFI-5664 Support ArrayList in DataTypeUtils#toArra...

2018-10-06 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3049#discussion_r223181352 --- Diff: nifi-commons/nifi-record/src/test/java/org/apache/nifi/serialization/record/TestDataTypeUtils.java --- @@ -168,6 +168,21 @@ public void

[GitHub] nifi pull request #3049: NIFI-5664 Support ArrayList in DataTypeUtils#toArra...

2018-10-06 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3049#discussion_r223181320 --- Diff: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java --- @@ -339,6 +339,11 @@ public static

[GitHub] nifi pull request #3049: NIFI-5664 Support ArrayList in DataTypeUtils#toArra...

2018-10-06 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3049#discussion_r223181332 --- Diff: nifi-commons/nifi-record/src/test/java/org/apache/nifi/serialization/record/TestDataTypeUtils.java --- @@ -168,6 +168,21 @@ public void

[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-05 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2956 @mans2singh before we continue, do you mind joining in [this discussion](http://apache-nifi-developer-list.39713.n7.nabble.com/Graph-database-support-w-NiFi-tp18680p19706.html) that I reopened on

[GitHub] nifi issue #3025: NIFI-5605 Added UpdateCassandra.

2018-10-04 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3025 @zenfenan do you have any opinion on where to put this functionality? ---

[GitHub] nifi issue #3045: Support/nifi 1.7.x

2018-10-04 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3045 @swatinarvekar if you need support, please subscribe to [one of the mailing lists](http://nifi.apache.org/mailing_lists.html). If this is an attempted code submission, let us know what you&#x

[GitHub] nifi issue #2420: NIFI-4731

2018-10-04 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2420 > May I ask what is currently blocking it? @nologic appears to have not addressed all of the review feedback. @joewitt I can rebase and address the author tags. If the tests

[GitHub] nifi issue #2546: NIFI-4975 Add GridFS processors

2018-10-03 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2546 @zenfenan @mattyb149 any chance we could get a review going for this before 1.8? ---

[GitHub] nifi issue #3041: NIFI-5224 Added SolrClientService.

2018-10-03 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3041 Thanks, @bbende I'll look into those. ---

[GitHub] nifi issue #3015: NIFI-5254 [WIP] Updated to Groovy 2.5.2

2018-10-03 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3015 @mattyb149 @joewitt Removed the following as compile dependencies because I can't see any valid use for them in our scripting scenarios: * groovy-cli* * groovy-groovydoc * g

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-03 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r66870 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-03 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r65949 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi issue #3011: NIFI-5333 Added GetMongoRecord.

2018-10-03 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3011 @zenfenan any chance we can get a review underway? ---

[GitHub] nifi issue #3015: NIFI-5254 [WIP] Updated to Groovy 2.5.2

2018-10-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3015 @mattyb149 @joewitt while I'm doing L&N validation on their dependencies, I can also cut out some of the fat by dropping Groovy modules like the CLI one that have no bearing on NiFi

[GitHub] nifi issue #3015: NIFI-5254 [WIP] Updated to Groovy 2.5.2

2018-10-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3015 Thanks, that's what I thought, but need a second opinion because we gotta cross our `T`s and dot our `I`s on this stuff. Will fix. ---

[GitHub] nifi issue #2861: NIFI-5248 Added new Elasticsearch json and record processo...

2018-10-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2861 @mattyb149 should be good to go now. Found the bug and pushed a fix that worked locally. ---

[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2956 > @MikeThomsen - Regarding your graph output questions - It looks correct but can you please let me know what are the commands/files that were ingested for above output ? I'l

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r221723913 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi issue #2861: NIFI-5248 Added new Elasticsearch json and record processo...

2018-10-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2861 One of the lookup integration tests is failing. I need to figure out why. ---

[GitHub] nifi issue #3042: NIFI-5650: Added Xerces to scripting bundle for Jython 2.7...

2018-10-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3042 Merged. ---

[GitHub] nifi issue #3042: NIFI-5650: Added Xerces to scripting bundle for Jython 2.7...

2018-10-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3042 @mattyb149 I'll merge when Travis is done and at least one build passes. ---

[GitHub] nifi pull request #3042: NIFI-5650: Added Xerces to scripting bundle for Jyt...

2018-10-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/3042#discussion_r221630928 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-nar/src/main/resources/META-INF/NOTICE --- @@ -73,6 +73,20 @@ The following binary

[GitHub] nifi pull request #3041: NIFI-5224 Added SolrClientService.

2018-10-01 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/3041 NIFI-5224 Added SolrClientService. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-29 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r221426131 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-29 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r221425925 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi issue #2872: NIFI-5318 Implement NiFi test harness: initial commit of n...

2018-09-25 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2872 @peter-gergely-horvath ok. I'm pretty sure that the surefire plugin can be disabled in the POM, but manually activated, so we'll need to look at that because those tests should be r

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-24 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r219939777 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi issue #3025: NIFI-5605 Added UpdateCassandra.

2018-09-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3025 @zenfenan this is geared toward delete/update operations. ---

[GitHub] nifi pull request #3025: NIFI-5605 Added UpdateCassandra.

2018-09-24 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/3025 NIFI-5605 Added UpdateCassandra. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi issue #3011: NIFI-5333 Added GetMongoRecord.

2018-09-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3011 @zenfenan @mattyb149 it's back. ---

[GitHub] nifi issue #3014: NIFI-5614: Update commons-dbcp to commons-dbcp2 for DBCPCo...

2018-09-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3014 Checked against postgres 10.5 and worked fine. Merging. Thanks @mattyb149 ---

[GitHub] nifi issue #3014: NIFI-5614: Update commons-dbcp to commons-dbcp2 for DBCPCo...

2018-09-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3014 Reviewing... ---

[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2956 @mans2singh you're going to need to do a rebase off of master. ---

[GitHub] nifi issue #3015: NIFI-5254 [WIP] Updated to Groovy 2.5.2

2018-09-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3015 @joewitt In 2.5.0 they removed the groovy-all fat jar in favor of doing a pom import that brings in all of the individual groovy components. Should I change the `NOTICE` to say "groovy-al

[GitHub] nifi pull request #3015: NIFI-5254 [WIP] Updated to Groovy 2.5.2

2018-09-19 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/3015 NIFI-5254 [WIP] Updated to Groovy 2.5.2 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi issue #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-09-19 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2820 @PrashanthVenkatesan if any of the builds passed, don't worry about it. It's the same test, just localized to different locale settings. ---

[GitHub] nifi pull request #3011: NIFI-5333 Added GetMongoRecord.

2018-09-19 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/3011 NIFI-5333 Added GetMongoRecord. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2813 NP. ---

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2813 I don't think it's compatible with your use case. What I built, based on how I read the ticket, was a processor that uses a Confluent library to generate random data based on an Avro

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2813 Also, the space issue is becoming a serious concern for our binary distributions. So now things that aren't really important for core have to be weighed against that consideration if you

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2813 @JPercivall Here you go: http://apache-nifi-developer-list.39713.n7.nabble.com/Should-I-withdraw-this-PR-td19475.html I'm fine with reopening this if you want to

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r218569285 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-utils/src/main/java/org/apache/nifi/processors/network/parser/Netflowv5Parser.java

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r218567833 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r218566840 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/pom.xml --- @@ -0,0 +1,67 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi issue #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2992 Merged. Thanks for the contribution. ---

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r218401785 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java --- @@ -0,0

  1   2   3   4   5   6   7   8   9   10   >