[GitHub] nifi issue #2883: NIFI-5415 Renamed ListenSyslogGroovyTest to ITListenSyslog...

2018-07-13 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2883 +1 LGTM, ran with and without the change, verified the test was still being run as a unit test without the change, and doesn't run as a unit test with the change. Thanks for the fix! Merging to

[GitHub] nifi issue #2883: NIFI-5415 Renamed ListenSyslogGroovyTest to ITListenSyslog...

2018-07-12 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2883 @joewitt please review -- not sure why the test was failing originally but for some reason it still ran for me when performing just unit tests. ---

[GitHub] nifi issue #2883: NIFI-5415 Renamed ListenSyslogGroovyTest to ITListenSyslog...

2018-07-12 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2883 I am opening a PR for this for actual review before it goes into `master`, but I included it in the 1.7.1 release