[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread david-streamlio
Github user david-streamlio commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235123524 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java ---

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread david-streamlio
Github user david-streamlio commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235123261 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarProducerProcessor.java

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235108402 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsarRecord.java --- @@

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235107847 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsar.java --- @@ -0,0

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread david-streamlio
Github user david-streamlio commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235107594 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java ---

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread david-streamlio
Github user david-streamlio commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235107339 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/cache/LRUCache.java --- @@ -0,0

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235106784 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarProducerProcessor.java ---

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235102894 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/pom.xml --- @@ -0,0 +1,84 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235102831 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/pom.xml --- @@ -0,0 +1,84 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235102049 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235101491 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-20 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3178#discussion_r235099937 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/cache/LRUCache.java --- @@ -0,0 +1,86 @@

[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors

2018-11-19 Thread david-streamlio
GitHub user david-streamlio opened a pull request: https://github.com/apache/nifi/pull/3178 NIFI-4914: Add Apache Pulsar processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the