[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668849#comment-16668849 ] Ted Yu commented on RATIS-377: -- bq. How could this be possible? May I know how the contents

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-29 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668147#comment-16668147 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- > It seems if HEADER_BYTES_CLONE is

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667827#comment-16667827 ] Ted Yu commented on RATIS-377: -- In SegmentedRaftLogFormat : {code} private static void as

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667813#comment-16667813 ] Ted Yu commented on RATIS-377: -- In LogSegment#loadSegment : {code} if (entryCount == 0) {

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Jitendra Nath Pandey (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1766#comment-1766 ] Jitendra Nath Pandey commented on RATIS-377: +1 for the latest patch. > Toler

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1755#comment-1755 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- In the original code, we do preallo

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Jitendra Nath Pandey (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1598#comment-1598 ] Jitendra Nath Pandey commented on RATIS-377: {code:java} if (SegmentedRaftLogF

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1415#comment-1415 ] Hadoop QA commented on RATIS-377: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1406#comment-1406 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- r377_20181028c.patch: adds multiple

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1369#comment-1369 ] Hadoop QA commented on RATIS-377: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1357#comment-1357 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- r377_20181028b.patch: It should be

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1340#comment-1340 ] Hadoop QA commented on RATIS-377: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1328#comment-1328 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- r377_20181028.patch: addresses [~jn

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1327#comment-1327 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- Oops, I forgot that isTerminator is

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-28 Thread Jitendra Nath Pandey (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1307#comment-1307 ] Jitendra Nath Pandey commented on RATIS-377: Thanks for the patch [~szetszwo],

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1254#comment-1254 ] Hadoop QA commented on RATIS-377: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-27 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1245#comment-1245 ] Tsz Wo Nicholas Sze commented on RATIS-377: --- r377_20181027b.patch: fixes a bug.

[jira] [Commented] (RATIS-377) Tolerate partially written log header

2018-10-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1200#comment-1200 ] Hadoop QA commented on RATIS-377: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||