Re: RFR: [15] JDK-8237492 Reorganize impl of doclet options

2020-01-23 Thread Kumar Srinivasan
Hi Jon, Sorry for the late arrival, I did not do a deep dive, however this caught my eye. I realize you must have used the IDE to refactor, in any case, in the lines you have changed there are these old constructs: src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Abstr

Re: RFR: [15] JDK-8237492 Reorganize impl of doclet options

2020-01-23 Thread Jonathan Gibbons
Kumar, Thanks for the feedback; I'll incorporate this change.  (I'm currently waiting on a minor CSR approval). -- Jon On 01/23/2020 09:47 AM, Kumar Srinivasan wrote: Hi Jon, Sorry for the late arrival,  I did not do a deep dive,  however  this caught my eye. I realize you must have used

RFR: JDK-8237803 Reorganize impl of tool options

2020-01-23 Thread Jonathan Gibbons
Although the underlying problems are different, the general goal of this cleanup is similar in nature to that of the recent cleanup for doclet options. In this case, the effect is not as widespread ... just 6 source files affected, no tests ... but the changes to the main affected class are m