[GitHub] [kafka] hzh0425 opened a new pull request, #13133: MINOR: Fix some typos in remote.metadata.storage

2023-01-19 Thread GitBox
hzh0425 opened a new pull request, #13133: URL: https://github.com/apache/kafka/pull/13133 Fix some typos in storage module / remote.metadata.storage ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI b

[jira] [Resolved] (KAFKA-14367) Introduce `GroupCoordinator` interface

2023-01-19 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14367. - Fix Version/s: 3.5.0 Resolution: Fixed > Introduce `GroupCoordinator` interface > ---

[GitHub] [kafka] dajac merged pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

2023-01-19 Thread GitBox
dajac merged PR #13112: URL: https://github.com/apache/kafka/pull/13112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-14642) TopicBased RemoteLogMetadataManager can't support reassign user-partitions

2023-01-19 Thread hzh0425 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hzh0425 updated KAFKA-14642: Priority: Blocker (was: Major) > TopicBased RemoteLogMetadataManager can't support reassign user-partitio

[GitHub] [kafka] showuon commented on a diff in pull request #13099: KAFKA-14604: avoid SASL session expiration time overflowed when calculation

2023-01-19 Thread GitBox
showuon commented on code in PR #13099: URL: https://github.com/apache/kafka/pull/13099#discussion_r1082162567 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String oldSuffix, String ne

[jira] [Created] (KAFKA-14643) TopicBased RemoteLogMetadataManager can't support reassign user-partitions

2023-01-19 Thread hzh0425 (Jira)
hzh0425 created KAFKA-14643: --- Summary: TopicBased RemoteLogMetadataManager can't support reassign user-partitions Key: KAFKA-14643 URL: https://issues.apache.org/jira/browse/KAFKA-14643 Project: Kafka

[jira] [Commented] (KAFKA-14642) TopicBased RemoteLogMetadataManager can't support reassign user-partitions

2023-01-19 Thread hzh0425 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679014#comment-17679014 ] hzh0425 commented on KAFKA-14642: - Hi, [~satishd] [~junrao] [~Hangleton] , Could you pls

[jira] [Created] (KAFKA-14642) TopicBased RemoteLogMetadataManager can't support reassign user-partitions

2023-01-19 Thread hzh0425 (Jira)
hzh0425 created KAFKA-14642: --- Summary: TopicBased RemoteLogMetadataManager can't support reassign user-partitions Key: KAFKA-14642 URL: https://issues.apache.org/jira/browse/KAFKA-14642 Project: Kafka

[GitHub] [kafka] yufeiyan1220 commented on pull request #13125: KAFKA-14626: Kafka Consumer Coordinator does not cleanup all metrics after shutdown

2023-01-19 Thread GitBox
yufeiyan1220 commented on PR #13125: URL: https://github.com/apache/kafka/pull/13125#issuecomment-1397979098 > Seems like we aren't particularly consistent at removing these metrics and sensors, fetcher would be another example. Mind making the clean up more comprehensive? Never mind

[GitHub] [kafka] philipnee commented on pull request #13125: KAFKA-14626: Kafka Consumer Coordinator does not cleanup all metrics after shutdown

2023-01-19 Thread GitBox
philipnee commented on PR #13125: URL: https://github.com/apache/kafka/pull/13125#issuecomment-1397952270 Seems like we aren't particularly consistent at removing these metrics and sensors, fetcher would be another example. Mind making the clean up more comprehensive? -- This is an auto

[jira] [Commented] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-01-19 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678981#comment-17678981 ] A. Sophie Blee-Goldman commented on KAFKA-14639: There's definitely some

[GitHub] [kafka] ableegoldman opened a new pull request, #13132: MINOR: fix warnings in Streams javadocs

2023-01-19 Thread GitBox
ableegoldman opened a new pull request, #13132: URL: https://github.com/apache/kafka/pull/13132 While working on the 3.4 release I noticed we've built up an embarrassingly long list of warnings within the Streams javadocs. It's unavoidable for some links to break as the source code changes,

[jira] [Resolved] (KAFKA-14638) Documentation for transaction.timeout.ms should be more precise

2023-01-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-14638. - Fix Version/s: 3.5.0 Resolution: Fixed > Documentation for transaction.timeout.ms

[GitHub] [kafka] mjsax merged pull request #13129: KAFKA-14638: Elaborate when transaction.timeout.ms resets

2023-01-19 Thread GitBox
mjsax merged PR #13129: URL: https://github.com/apache/kafka/pull/13129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] yufeiyan1220 commented on pull request #13125: KAFKA-14626: Kafka Consumer Coordinator does not cleanup all metrics after shutdown

2023-01-19 Thread GitBox
yufeiyan1220 commented on PR #13125: URL: https://github.com/apache/kafka/pull/13125#issuecomment-1397837046 > Thanks for the PR and the issue @yufeiyan1220 - I wonder if the clean up is necessary, as the metrics will be closed upon the client closing. Willing to hear what others say.

[GitHub] [kafka] Gerrrr commented on pull request #13129: KAFKA-14638: Elaborate when transaction.timeout.ms resets

2023-01-19 Thread GitBox
Ge commented on PR #13129: URL: https://github.com/apache/kafka/pull/13129#issuecomment-1397815859 @hachikuji @jolshan I don't have Kafka committer privileges. Can you please commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-7744) Type in java

2023-01-19 Thread Yaroslav (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678943#comment-17678943 ] Yaroslav commented on KAFKA-7744: - Hi, This was already fixed by KAFKA-6157 for 1.0.1 ve

[jira] [Created] (KAFKA-14641) Cleanup CommitNeeded after EOS-V1 is removed

2023-01-19 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-14641: - Summary: Cleanup CommitNeeded after EOS-V1 is removed Key: KAFKA-14641 URL: https://issues.apache.org/jira/browse/KAFKA-14641 Project: Kafka Issue Type: Im

[jira] [Updated] (KAFKA-14641) Cleanup CommitNeeded after EOS-V1 is removed

2023-01-19 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-14641: -- Component/s: streams > Cleanup CommitNeeded after EOS-V1 is removed >

[jira] [Created] (KAFKA-14640) Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

2023-01-19 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-14640: -- Summary: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests Key: KAFKA-14640 URL: https://issues.apache.org/jira/browse/KAFKA-14640 Projec

[jira] [Assigned] (KAFKA-14640) Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

2023-01-19 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-14640: -- Assignee: Justine Olshan > Update AddPartitionsToTxn protocol to batch and handle ver

[GitHub] [kafka] Gerrrr commented on a diff in pull request #13129: KAFKA-14638: Elaborate when transaction.timeout.ms resets

2023-01-19 Thread GitBox
Ge commented on code in PR #13129: URL: https://github.com/apache/kafka/pull/13129#discussion_r1081881848 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -318,7 +318,8 @@ public class ProducerConfig extends AbstractConfig { /** t

[jira] [Assigned] (KAFKA-10586) Full support for distributed mode in dedicated MirrorMaker 2.0 clusters

2023-01-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-10586: - Assignee: Chris Egerton (was: Viktor Somogyi-Vass) > Full support for distributed mode

[GitHub] [kafka] hachikuji commented on a diff in pull request #13129: KAFKA-14638: Elaborate when transaction.timeout.ms resets

2023-01-19 Thread GitBox
hachikuji commented on code in PR #13129: URL: https://github.com/apache/kafka/pull/13129#discussion_r1081878202 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -318,7 +318,8 @@ public class ProducerConfig extends AbstractConfig { /**

[GitHub] [kafka] Gerrrr commented on a diff in pull request #13129: KAFKA-14638: Elaborate when transaction.timeout.ms resets

2023-01-19 Thread GitBox
Ge commented on code in PR #13129: URL: https://github.com/apache/kafka/pull/13129#discussion_r1081848092 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -319,6 +319,7 @@ public class ProducerConfig extends AbstractConfig { /** tra

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

2023-01-19 Thread GitBox
dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1081788435 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -557,25 +557,25 @@ private[group] class GroupCoordinatorAdapter( } override de

[GitHub] [kafka] jolshan commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

2023-01-19 Thread GitBox
jolshan commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1081688123 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -557,25 +557,25 @@ private[group] class GroupCoordinatorAdapter( } override

[GitHub] [kafka] jolshan commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

2023-01-19 Thread GitBox
jolshan commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1081688123 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -557,25 +557,25 @@ private[group] class GroupCoordinatorAdapter( } override

[GitHub] [kafka] jolshan commented on a diff in pull request #13129: KAFKA-14638: Elaborate when transaction.timeout.ms resets

2023-01-19 Thread GitBox
jolshan commented on code in PR #13129: URL: https://github.com/apache/kafka/pull/13129#discussion_r1081661935 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -319,6 +319,7 @@ public class ProducerConfig extends AbstractConfig { /** tr

[jira] (KAFKA-14638) Documentation for transaction.timeout.ms should be more precise

2023-01-19 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14638 ] Justine Olshan deleted comment on KAFKA-14638: was (Author: jolshan): This is a bit tricky – the timer updates when the producer contacts the transaction coordinator for the transaction.

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-01-19 Thread GitBox
jeffkbkim commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1081656322 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json: ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-01-19 Thread GitBox
jeffkbkim commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1081655338 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json: ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Resolved] (KAFKA-14637) Upgrade to 3.4 from old versions (< 0.10) are failing due to incompatible meta.properties check

2023-01-19 Thread Akhilesh Chaganti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhilesh Chaganti resolved KAFKA-14637. --- Fix Version/s: 3.4.0 Resolution: Fixed > Upgrade to 3.4 from old versions (<

[jira] [Commented] (KAFKA-14638) Documentation for transaction.timeout.ms should be more precise

2023-01-19 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678840#comment-17678840 ] Justine Olshan commented on KAFKA-14638: This is a bit tricky – the timer update

[GitHub] [kafka] hachikuji commented on a diff in pull request #13129: KAFKA-14638: Elaborate when transaction.timeout.ms resets

2023-01-19 Thread GitBox
hachikuji commented on code in PR #13129: URL: https://github.com/apache/kafka/pull/13129#discussion_r1081629522 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -319,6 +319,7 @@ public class ProducerConfig extends AbstractConfig { /**

[GitHub] [kafka] hachikuji commented on a diff in pull request #13129: KAFKA-14638: Elaborate when transaction.timeout.ms resets

2023-01-19 Thread GitBox
hachikuji commented on code in PR #13129: URL: https://github.com/apache/kafka/pull/13129#discussion_r1081629522 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -319,6 +319,7 @@ public class ProducerConfig extends AbstractConfig { /**

[jira] [Updated] (KAFKA-14638) Documentation for transaction.timeout.ms should be more precise

2023-01-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14638: Issue Type: Improvement (was: Bug) > Documentation for transaction.timeout.ms should be m

[jira] [Updated] (KAFKA-14638) Documentation for transaction.timeout.ms should be more precise

2023-01-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14638: Component/s: docs > Documentation for transaction.timeout.ms should be more precise >

[GitHub] [kafka] cadonna merged pull request #12821: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in streams tests

2023-01-19 Thread GitBox
cadonna merged PR #12821: URL: https://github.com/apache/kafka/pull/12821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12821: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in streams tests

2023-01-19 Thread GitBox
cadonna commented on PR #12821: URL: https://github.com/apache/kafka/pull/12821#issuecomment-1397370205 Build failures are unrelated: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.clients.consumer.KafkaConsumerTest.testReturnRecordsDuringRebalance() Build / JDK 11 and Scala 2

[GitHub] [kafka] kirktrue commented on a diff in pull request #13119: KAFKA-14623: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

2023-01-19 Thread GitBox
kirktrue commented on code in PR #13119: URL: https://github.com/apache/kafka/pull/13119#discussion_r1081589480 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetriever.java: ## @@ -240,6 +240,9 @@ static String handleOutpu

[GitHub] [kafka] dajac commented on pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

2023-01-19 Thread GitBox
dajac commented on PR #13112: URL: https://github.com/apache/kafka/pull/13112#issuecomment-1397338100 @jolshan Updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

2023-01-19 Thread GitBox
dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1081583343 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java: ## @@ -215,4 +223,86 @@ CompletableFuture deleteOffsets( OffsetDelet

[GitHub] [kafka] kirktrue commented on a diff in pull request #13119: KAFKA-14623: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

2023-01-19 Thread GitBox
kirktrue commented on code in PR #13119: URL: https://github.com/apache/kafka/pull/13119#discussion_r1081575409 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetriever.java: ## @@ -240,6 +240,9 @@ static String handleOutpu

[GitHub] [kafka] kirktrue commented on a diff in pull request #13119: KAFKA-14623: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

2023-01-19 Thread GitBox
kirktrue commented on code in PR #13119: URL: https://github.com/apache/kafka/pull/13119#discussion_r1081575409 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetriever.java: ## @@ -240,6 +240,9 @@ static String handleOutpu

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

2023-01-19 Thread GitBox
dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1081571516 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -3448,7 +3445,7 @@ class KafkaApisTest { val expectedJoinGroupResponse = new JoinGroupResponseDat

[GitHub] [kafka] dajac commented on a diff in pull request #13112: KAFKA-14367; Add internal APIs to the new `GroupCoordinator` interface

2023-01-19 Thread GitBox
dajac commented on code in PR #13112: URL: https://github.com/apache/kafka/pull/13112#discussion_r1081571061 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -511,4 +532,53 @@ class GroupCoordinatorAdapter( future } + + override def

[GitHub] [kafka] fvaleri commented on pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-19 Thread GitBox
fvaleri commented on PR #13131: URL: https://github.com/apache/kafka/pull/13131#issuecomment-1397311675 Take a look at `DumpLogSegments` to see how `CommandDefaultOptions` is used. It is much better than building the option list at the start of the `main/execute` method. -- This is an au

[jira] [Commented] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

2023-01-19 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678799#comment-17678799 ] Terry Beard commented on KAFKA-14565: - [~ChrisEgerton]  I've updated the ticket to i

[jira] [Updated] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

2023-01-19 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: The Consumer and Producer interceptor interfaces and their corresponding Kafka Consu

[GitHub] [kafka] bbejeck commented on pull request #8431: MINOR: Rename description of flatMapValues transformation

2023-01-19 Thread GitBox
bbejeck commented on PR #8431: URL: https://github.com/apache/kafka/pull/8431#issuecomment-1397212359 cherry-picked to 3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Commented] (KAFKA-14636) Compression optimization: Use zstd dictionary based (de)compression

2023-01-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678790#comment-17678790 ] Ismael Juma commented on KAFKA-14636: - KAFKA-7632 and KAFKA-13361 are somewhat relat

[GitHub] [kafka] mumrah merged pull request #13130: Fix upgrade compatibility issue from older versions to 3.4

2023-01-19 Thread GitBox
mumrah merged PR #13130: URL: https://github.com/apache/kafka/pull/13130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] bbejeck commented on pull request #8431: MINOR: Rename description of flatMapValues transformation

2023-01-19 Thread GitBox
bbejeck commented on PR #8431: URL: https://github.com/apache/kafka/pull/8431#issuecomment-1397198456 Hi @maseiler, can you do the same PR for the [3.3 version of the streams developer guide](https://github.com/apache/kafka-site/blob/asf-site/33/streams/developer-guide/dsl-api.html)?

[GitHub] [kafka] bbejeck commented on pull request #8431: MINOR: Rename description of flatMapValues transformation

2023-01-19 Thread GitBox
bbejeck commented on PR #8431: URL: https://github.com/apache/kafka/pull/8431#issuecomment-1397167523 Thanks for the contribution @maseiler ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [kafka] bbejeck commented on pull request #8431: MINOR: Rename description of flatMapValues transformation

2023-01-19 Thread GitBox
bbejeck commented on PR #8431: URL: https://github.com/apache/kafka/pull/8431#issuecomment-1397166959 Merged #8431 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] bbejeck merged pull request #8431: MINOR: Rename description of flatMapValues transformation

2023-01-19 Thread GitBox
bbejeck merged PR #8431: URL: https://github.com/apache/kafka/pull/8431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] maseiler commented on pull request #8431: MINOR: Rename description of flatMapValues transformation

2023-01-19 Thread GitBox
maseiler commented on PR #8431: URL: https://github.com/apache/kafka/pull/8431#issuecomment-1397133912 @mjsax, I solved the merge conflict and rebased it on the latest version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Assigned] (KAFKA-14636) Compression optimization: Use zstd dictionary based (de)compression

2023-01-19 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-14636: - Assignee: Christo Lolov > Compression optimization: Use zstd dictionary based (de)compr

[jira] [Updated] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

2023-01-19 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: The Consumer and Producer interceptor interfaces and their corresponding Kafka Consu

[jira] [Updated] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

2023-01-19 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: The Consumer and Producer interceptor interfaces and their corresponding Kafka Consu

[GitHub] [kafka] clolov commented on a diff in pull request #12821: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in streams tests

2023-01-19 Thread GitBox
clolov commented on code in PR #12821: URL: https://github.com/apache/kafka/pull/12821#discussion_r1081305288 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java: ## @@ -187,151 +137,107 @@ public void testCloseStateManagerThrowsExcep

[jira] [Updated] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

2023-01-19 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: The Consumer and Producer interceptor interfaces and their corresponding Kafka Consu

[jira] [Updated] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

2023-01-19 Thread Terry Beard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: The Consumer and Producer interceptor interfaces and their corresponding Kafka Consu

[GitHub] [kafka] cadonna merged pull request #12818: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2023-01-19 Thread GitBox
cadonna merged PR #12818: URL: https://github.com/apache/kafka/pull/12818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12818: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2023-01-19 Thread GitBox
cadonna commented on PR #12818: URL: https://github.com/apache/kafka/pull/12818#issuecomment-1397015212 Build failures are unrelated: ``` Build / JDK 11 and Scala 2.13 / kafka.controller.ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir() Build / JDK 8 and

[jira] [Assigned] (KAFKA-14582) Move JmxTool to tools

2023-01-19 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-14582: --- Assignee: Federico Valeri > Move JmxTool to tools > - > >

[jira] [Assigned] (KAFKA-14577) Move ConsoleProducer to tools

2023-01-19 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-14577: --- Assignee: (was: Federico Valeri) > Move ConsoleProducer to tools >

[jira] [Assigned] (KAFKA-14577) Move ConsoleProducer to tools

2023-01-19 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-14577: --- Assignee: Federico Valeri > Move ConsoleProducer to tools > ---

[GitHub] [kafka] fvaleri commented on a diff in pull request #13127: Kafka 14586: Moving StreamResetter to tools

2023-01-19 Thread GitBox
fvaleri commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1081230571 ## build.gradle: ## @@ -1757,6 +1757,7 @@ project(':tools') { archivesBaseName = "kafka-tools" dependencies { +implementation project(':core') Review Comme

[GitHub] [kafka] fvaleri commented on pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-19 Thread GitBox
fvaleri commented on PR #13131: URL: https://github.com/apache/kafka/pull/13131#issuecomment-1396923697 @clolov @vamossagar12 @tinaselenge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] fvaleri commented on pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-19 Thread GitBox
fvaleri commented on PR #13131: URL: https://github.com/apache/kafka/pull/13131#issuecomment-1396922639 @mimaison @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] fvaleri opened a new pull request, #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-19 Thread GitBox
fvaleri opened a new pull request, #13131: URL: https://github.com/apache/kafka/pull/13131 These classes are required by most commands, so they must be migrated first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] cadonna commented on a diff in pull request #12821: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in streams tests

2023-01-19 Thread GitBox
cadonna commented on code in PR #12821: URL: https://github.com/apache/kafka/pull/12821#discussion_r1081170724 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java: ## @@ -187,151 +137,107 @@ public void testCloseStateManagerThrowsExce

[jira] [Updated] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-01-19 Thread Bojan Blagojevic (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bojan Blagojevic updated KAFKA-14639: - Description: I have an application that runs 6 consumers in parallel. I am getting some

[jira] [Created] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-01-19 Thread Bojan Blagojevic (Jira)
Bojan Blagojevic created KAFKA-14639: Summary: Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle Key: KAFKA-14639 URL: https://issues.apache.org/jira/browse/KAFKA-14639

[GitHub] [kafka] yashmayya commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2023-01-19 Thread GitBox
yashmayya commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1081145849 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -712,8 +733,16 @@ KafkaBasedLog setupAndCreateKafkaBasedLog(Str

[GitHub] [kafka] clolov commented on a diff in pull request #12821: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in streams tests

2023-01-19 Thread GitBox
clolov commented on code in PR #12821: URL: https://github.com/apache/kafka/pull/12821#discussion_r1081139070 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java: ## @@ -187,151 +137,107 @@ public void testCloseStateManagerThrowsExcep

[GitHub] [kafka] fvaleri commented on a diff in pull request #13127: Kafka 14586: Moving StreamResetter to tools

2023-01-19 Thread GitBox
fvaleri commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1081057443 ## build.gradle: ## @@ -1757,6 +1757,7 @@ project(':tools') { archivesBaseName = "kafka-tools" dependencies { +implementation project(':core') Review Comme

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13127: Kafka 14586: Moving StreamResetter to tools

2023-01-19 Thread GitBox
vamossagar12 commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1081021244 ## build.gradle: ## @@ -1757,6 +1757,7 @@ project(':tools') { archivesBaseName = "kafka-tools" dependencies { +implementation project(':core') Review

[GitHub] [kafka] cadonna commented on a diff in pull request #13127: Kafka 14586: Moving StreamResetter to tools

2023-01-19 Thread GitBox
cadonna commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1081015656 ## build.gradle: ## @@ -1757,6 +1757,7 @@ project(':tools') { archivesBaseName = "kafka-tools" dependencies { +implementation project(':core') Review Comme

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13127: Kafka 14586: Moving StreamResetter to tools

2023-01-19 Thread GitBox
vamossagar12 commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1081010418 ## build.gradle: ## @@ -1757,6 +1757,7 @@ project(':tools') { archivesBaseName = "kafka-tools" dependencies { +implementation project(':core') Review

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13127: Kafka 14586: Moving StreamResetter to tools

2023-01-19 Thread GitBox
vamossagar12 commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1081009344 ## build.gradle: ## @@ -1757,6 +1757,7 @@ project(':tools') { archivesBaseName = "kafka-tools" dependencies { +implementation project(':core') Review

[GitHub] [kafka] clolov commented on a diff in pull request #13127: Kafka 14586: Moving StreamResetter to tools

2023-01-19 Thread GitBox
clolov commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1081007952 ## build.gradle: ## @@ -1757,6 +1757,7 @@ project(':tools') { archivesBaseName = "kafka-tools" dependencies { +implementation project(':core') Review Commen

[GitHub] [kafka] cadonna commented on a diff in pull request #13127: Kafka 14586: Moving StreamResetter to tools

2023-01-19 Thread GitBox
cadonna commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1081000404 ## build.gradle: ## @@ -1757,6 +1757,7 @@ project(':tools') { archivesBaseName = "kafka-tools" dependencies { +implementation project(':core') Review Comme

[GitHub] [kafka] cadonna commented on a diff in pull request #12821: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in streams tests

2023-01-19 Thread GitBox
cadonna commented on code in PR #12821: URL: https://github.com/apache/kafka/pull/12821#discussion_r1080946697 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java: ## @@ -187,151 +137,107 @@ public void testCloseStateManagerThrowsExce

[GitHub] [kafka] cadonna commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2023-01-19 Thread GitBox
cadonna commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1396582822 @shekhar-rajak Do you have any updates for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above