[jira] [Resolved] (KAFKA-16305) Optimisation in SslTransportLayer:handshakeUnwrap stalls TLS handshake

2024-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16305. Fix Version/s: 3.7.1 Resolution: Fixed push https://github.com/apache/kafka/commit

[jira] [Reopened] (KAFKA-16305) Optimisation in SslTransportLayer:handshakeUnwrap stalls TLS handshake

2024-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reopened KAFKA-16305: reopen for backport to 3.7 > Optimisation in SslTransportLayer:handshakeUnwrap stalls TLS han

[jira] [Commented] (KAFKA-16471) SslTransportLayer may leak SSLEngine resources

2024-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834229#comment-17834229 ] Chia-Ping Tsai commented on KAFKA-16471: {quote} perhaps we backport KAFKA-16305

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553289186 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1866,9 +1810,6 @@ public void shouldReturnOffsetsForRepartitionTopicsF

Re: [PR] KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records [kafka]

2024-04-05 Thread via GitHub
vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-2039360963 Hey Chris, sorry for the long delay on this. I finally got a chance to verify the code that you provided and it makes sense. I agree that so far I was only thinking about either havi

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553287165 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1798,8 +1746,6 @@ public void shouldCloseStateManagerEvenDuringFailure

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553284545 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -514,8 +496,6 @@ public void shouldTransitToRestoringThenRunningAfterCr

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553245804 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -365,11 +356,10 @@ public void shouldResetOffsetsToLastCommittedForSpec

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553235267 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1568,10 +1548,8 @@ public void shouldNotShareHeadersBetweenPunctuateIt

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553224333 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -309,49 +300,49 @@ public void shouldThrowLockExceptionIfFailedToLockSt

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553225208 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -309,49 +300,49 @@ public void shouldThrowLockExceptionIfFailedToLockSt

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-05 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553223975 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -309,49 +300,49 @@ public void shouldThrowLockExceptionIfFailedToLockSt

Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on PR #15666: URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039276618 sorry :( the correct PR is #15663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub
nizhikov commented on PR #15666: URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039274380 @chia7712 Can you, please, double check PR number? It sees #15664 not related to my changes -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on PR #15666: URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039262579 @nizhikov thanks for this patch. let's wait for #15664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Commented] (KAFKA-16471) SslTransportLayer may leak SSLEngine resources

2024-04-05 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834200#comment-17834200 ] Gaurav Narula commented on KAFKA-16471: --- [~chia7712] I'm not well versed with the

Re: [PR] Test PR without the circular dependency code [kafka]

2024-04-05 Thread via GitHub
vamossagar12 commented on PR #15653: URL: https://github.com/apache/kafka/pull/15653#issuecomment-2039212910 The purpose of this PR was to validate a certain behaviour with circular dependency (explained [here](https://github.com/apache/kafka/pull/15642#discussion_r1551420344)) and as conf

Re: [PR] Test PR without the circular dependency code [kafka]

2024-04-05 Thread via GitHub
vamossagar12 closed pull request #15653: Test PR without the circular dependency code URL: https://github.com/apache/kafka/pull/15653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] KAFKA-16039: RecordHeaders supports the addAll method [kafka]

2024-04-05 Thread via GitHub
vamossagar12 commented on PR #15034: URL: https://github.com/apache/kafka/pull/15034#issuecomment-2039191732 The instructions for signing up are [here](https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-GettingStarted). -- This is an au

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-05 Thread via GitHub
nizhikov commented on code in PR #15645: URL: https://github.com/apache/kafka/pull/15645#discussion_r1553114805 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-05 Thread via GitHub
nizhikov commented on code in PR #15645: URL: https://github.com/apache/kafka/pull/15645#discussion_r1553114426 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[PR] MINOR: Default test name added to core [kafka]

2024-04-05 Thread via GitHub
nizhikov opened a new pull request, #15667: URL: https://github.com/apache/kafka/pull/15667 This PR adds junit-platform.properties to core and removes outdated constant from scala code. *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integ

[PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub
nizhikov opened a new pull request, #15666: URL: https://github.com/apache/kafka/pull/15666 This PR adds `junit-platform.properties` to `tools` and removes outdated constant from java code. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementatio

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-05 Thread via GitHub
nizhikov commented on code in PR #15645: URL: https://github.com/apache/kafka/pull/15645#discussion_r1553060780 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16472: Fix integration tests in Java with parameter name [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on PR #15663: URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039097741 > I think the class file size increasing is indeed a direct drawback after adding -parameter option because we'll include all the parameters into .class files. I'd like to know if there'

<    1   2