jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r482810291
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java
##
@@ -136,34 +174,64 @@
*
* This iterator must be cl
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r482160859
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java
##
@@ -136,34 +174,64 @@
*
* This iterator must be cl
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r482160020
##
File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java
##
@@ -150,13 +185,25 @@
* @return an iterator over windowed key-valu
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r482127067
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/SegmentIterator.java
##
@@ -67,14 +70,22 @@ public Bytes peekNextKey() {
pub
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r481931127
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java
##
@@ -117,12 +118,20 @@ public void openExisting(final Pro
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r481930378
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractMergedSortedCacheStoreIterator.java
##
@@ -192,4 +192,3 @@ public void cl
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r481920572
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java
##
@@ -33,11 +33,11 @@
/**
* Get the value of key from
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r478349804
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java
##
@@ -287,17 +308,43 @@ public void shouldFetc
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r478340031
##
File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java
##
@@ -119,15 +118,16 @@
*
* This iterator must be closed afte
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r477436882
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
##
@@ -416,26 +552,43 @@ private long currentSegmentLastT
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r476796186
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryWindowStore.java
##
@@ -163,7 +164,17 @@ public void put(final Bytes key,
jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r475910689
##
File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java
##
@@ -119,15 +118,16 @@
*
* This iterator must be closed afte
12 matches
Mail list logo