junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1300372620
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -696,11 +704,327 @@ public void run() {
}
}
+public void handleLogSta
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1299221576
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -696,11 +704,327 @@ public void run() {
}
}
+public void handleLogSta
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1298640349
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -696,11 +704,327 @@ public void run() {
}
}
+public void handleLogSta
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1297576757
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -2173,6 +2230,14 @@ object UnifiedLog extends Logging {
}
}
+ private[log] def localRetentionMs(confi
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1296221075
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1390,7 +1424,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
private def deleteOldSegments(predic
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1293851913
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -698,11 +707,329 @@ public void run() {
}
}
+public void handleLogSta
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1293823449
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -2202,19 +2262,24 @@ case class RetentionMsBreach(log: UnifiedLog) extends
SegmentDeletionReason {
}
}
-c
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1291690729
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1390,7 +1424,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
private def deleteOldSegments(predic
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1287764297
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -956,6 +981,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}
+ private def maybeIncreme
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1222183119
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -945,4 +1176,27 @@ public void close() {
}
}
+private static class RetentionSizeD
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1203191600
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -522,7 +522,12 @@ class BrokerServer(
}
Some(new RemoteLogManager(remoteLogManagerConfig, c
11 matches
Mail list logo