This revision was automatically updated to reflect the committed changes.
Closed by commit R240:4275cfc3f75d: Bindings: Check if bindings can be
generated for a specific python version (authored by bruns).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
arojas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D14915
To: bruns, #frameworks, arojas
Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
bruns updated this revision to Diff 40471.
bruns edited the summary of this revision.
bruns edited the test plan for this revision.
bruns added a comment.
Also check for sip.h in the default paths (e.g. /usr/include/)
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://p
bruns planned changes to this revision.
bruns added a comment.
sure ...
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D14915
To: bruns, #frameworks
Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
arojas added a comment.
sip.h is python version agnostic, and in fact we install it under
/usr/include. Would it be possible to also check this path?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D14915
To: bruns, #frameworks
Cc: arojas, kde-frameworks-
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
The generated C++ sources include , so it must be available