astippich abandoned this revision.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D25518
To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, s
astippich updated this revision to Diff 77956.
astippich added a comment.
- adapt to changes
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25518?vs=73098&id=77956
BRANCH
taglibBinaryExtraction
REVISION DETAIL
https://phabricator.kde.org/D25518
astippich updated this revision to Diff 73098.
astippich added a comment.
- adapt to changes
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25518?vs=70724&id=73098
BRANCH
taglibBinaryExtraction
REVISION DETAIL
https://phabricator.kde.org/D25518
astippich added a dependent revision: D25679: Implement writing of front cover
in taglibwriter.
REPOSITORY
R286 KFileMetaData
BRANCH
taglibBinaryExtraction
REVISION DETAIL
https://phabricator.kde.org/D25518
To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikha
astippich updated this revision to Diff 70724.
astippich added a comment.
- rebase
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25518?vs=70285&id=70724
BRANCH
taglibBinaryExtraction
REVISION DETAIL
https://phabricator.kde.org/D25518
AFFECTED
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
taglibBinaryExtraction
REVISION DETAIL
https://phabricator.kde.org/D25518
To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs,
astippich added dependencies: D25517: Add an option to extract binary data and
add front cover property, D25516: Remove unrequired private declarations for
taglibextractor.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D25518
To: astippich, #baloo, bruns, mgalli
astippich added a comment.
This is probably how it should have been implemented from the beginning, and
not how I did it in the embeddedimagedata class, which duplicates a lot of code
and requires additional file operations.
Baloo can continue to work as is due to the new flags.
Taglib wr
astippich created this revision.
astippich added reviewers: Baloo, bruns, mgallien, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
Add the possibility to extract the front cover
i