Re: [kdesrc-build] /: Use kde-runtime/frameworks instead of kde-runtime/master

On Wednesday 05 March 2014 17:04:10 Àlex Fiestas wrote: > Git commit ae5798e3ce2368c0561424537f77ad34d56eb61a by Àlex Fiestas. > Committed on 05/03/2014 at 17:00. > Pushed by afiestas into branch 'master'. > > Use kde-runtime/frameworks instead of kde-runtime/master > > M +7-1kf5-workspa

Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/ --- Review request for Build System and KDE Frameworks. Repository: kde4suppo

Re: Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/#review52236 --- Ship it! - Aleix Pol Gonzalez On March 6, 2014, 10:11 a.m.,

Re: Review Request 116616: Remove unused find-modules back to the attic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116616/#review52241 --- This review has been submitted with commit 8c3773f920185fe49d

Re: Review Request 116616: Remove unused find-modules back to the attic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116616/ --- (Updated March 6, 2014, 11:50 a.m.) Status -- This change has been m

Re: Review Request 116096: Re-enable autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116096/ --- (Updated March 6, 2014, 11:53 a.m.) Status -- This change has been m

Re: Review Request 116096: Re-enable autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116096/#review52242 --- This review has been submitted with commit e9d5da5d908cf76888

Jenkins build became unstable: kitemmodels_master_qt5 #25

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116090: Use $ instead of get_target_property(... LOCATION)

> On Feb. 27, 2014, 10:54 a.m., Alex Merry wrote: > > The problem with doing this in support code is that it is not strictly > > source compatible. An example this would break is if you want to embed the > > value of QT_QMAKE_EXECUTABLE into a C++ executable using something like > > add_defini

Re: Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/#review52246 --- Ship it! Ship It! - Alex Merry On March 6, 2014, 10:11 a.m

Re: KSpeech

Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: > Took a quick read through that just now and it looks pretty promising > from what I saw. I guess I don't know my way around gerrit very well > because I couldn't see a place to comment on the code like > reviewboard. > Really the only difference

Re: Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/ --- (Updated March 6, 2014, 4:30 p.m.) Status -- This change has been di

Re: Review Request 116090: Use $ instead of get_target_property(... LOCATION)

> On Feb. 27, 2014, 10:54 a.m., Alex Merry wrote: > > The problem with doing this in support code is that it is not strictly > > source compatible. An example this would break is if you want to embed the > > value of QT_QMAKE_EXECUTABLE into a C++ executable using something like > > add_defini

Review Request 116639: Do not read LOCATION property of desktoptojson

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116639/ --- Review request for Build System and KDE Frameworks. Repository: kservice

Re: Review Request 116591: Use dedicated NET::Properties and NET::Properties2 in NETWinInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116591/#review52274 --- Ship it! Looks good to me. - Aurélien Gâteau On March 4, 2

Re: Review Request 116568: Fixes to PIC image format handler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/#review52275 --- A few methods have mismatched params in their header comments.

Re: KSpeech

On Thu, Mar 6, 2014 at 6:43 AM, Frederik Gladhorn wrote: > Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: >> Took a quick read through that just now and it looks pretty promising >> from what I saw. I guess I don't know my way around gerrit very well >> because I couldn't see a place to commen

Re: Review Request 116610: Use flag types in NETRootInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116610/#review52277 --- Ship it! Looks good. One question though, wasn't it possible

Re: Review Request 116610: Use flag types in NETRootInfo

> On March 6, 2014, 5:22 p.m., Aurélien Gâteau wrote: > > Looks good. > > > > One question though, wasn't it possible to merge properties or properties2? > > I lack extensive knowledge of this domain, but it looks odd from an API > > point of view. that would be a large SC break which might n

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: qt5 polkit-qt-1 and kdesrc-build

On Sat, 01 Mar 2014 16:42:31 +0100, David Faure wrote: On Wednesday 26 February 2014 22:25:01 Milian Wolff wrote: module-set repository kde-projects branch qt5 use-modules polkit-qt-1 cmake-options -DCMAKE_BUILD_TYPE:STRING=debug end module-set Considering that all other peopl

Re: KSpeech

On Thursday 06 March 2014 17:13:19 Jeremy Whiting wrote: > On Thu, Mar 6, 2014 at 6:43 AM, Frederik Gladhorn wrote: > > Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: > >> 3. user configurability (As a user I can't set up which voice I > >> would like all speech-using applications to use) > >

Re: Review Request 116604: Allow directories with . as output for meinproc

> On March 5, 2014, 3:36 p.m., Burkhard Lück wrote: > > src/meinproc.cpp, lines 170-179 > > > > > > How does this affect this code in KHelpcenter: > > > > kde-runtime/khelpcenter/glossary.cpp:149:KPr

Re: Review Request 116639: Do not read LOCATION property of desktoptojson

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116639/#review52312 --- Ship it! Ship It! - Alex Merry On March 6, 2014, 3:42 p.m.

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/ --- (Updated March 6, 2014, 10:56 p.m.) Review request for Build System, Extr

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review52316 --- Looks like a good manual. - Stephen Kelly On March 6, 2014,

Jenkins build became unstable: ktexteditor_master_qt5 #236

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116646: Improve FindWayland.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116646/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

KDNSSD

OK, so it looks like the immediate plan with KDNSSD is to rename "kdnssd" to "zeroconf-ioslave" and "kdnssd-framework" to "kdnssd". I guess this involves filing sysadmin tickets. What else do we (I) need to deal with, given that kdnssd, which will be renamed to zeroconf-ioslave, is part of the KD

Re: KDNSSD

On 07/03/14 00:52, Alex Merry wrote: > OK, so it looks like the immediate plan with KDNSSD is to rename > "kdnssd" to "zeroconf-ioslave" and "kdnssd-framework" to "kdnssd". I > guess this involves filing sysadmin tickets. > > What else do we (I) need to deal with, given that kdnssd, which will be

Re: KDNSSD

Hello, On Friday 07 March 2014 00:54:59 Alex Merry wrote: > On 07/03/14 00:52, Alex Merry wrote: > > OK, so it looks like the immediate plan with KDNSSD is to rename > > "kdnssd" to "zeroconf-ioslave" and "kdnssd-framework" to "kdnssd". I > > guess this involves filing sysadmin tickets. > > > >