Wayne,
Ah, dropped the wxT.
I have fixed it in the attached patch.
Thanks,
On Tue, Dec 12, 2017 at 3:36 AM, Wayne Stambaugh
wrote:
> Oliver,
>
> I see you noticed that I added a place holder for library devs. I was
> going to ask you for a list of contributors but I like you solution
> bette
Hey Jeff,
The preferred method is for you to use git and committing your changes
to your local repo (all commits in git are local) then using `git
format-patch` to submit your patches. Using `git format-patch`
eliminates the need for busy lead developers from having to enter your
author informati
Hi Jeff,
Thanks for your patches!
You've already done the right thing - KiCad uses a somewhat
old-fashioned flow so submitting patches directly like that is the norm.
I'll just take a little while for them to be reviewed.
If you have patches that add features rather than fixing bugs, you can
sub
Hi guys and gals,
I’ve logged a few bugs that affect me and developed fixes for some of them[1].
After decades of svn and then a few years of retirement I don’t trust my git
skills so I added the fixes as patches. What’s the process for getting them
reviewed and committed?
Thanks,
Jeff.
[1]
Oliver,
I see you noticed that I added a place holder for library devs. I was
going to ask you for a list of contributors but I like you solution
better. That being said, there is a problem with your patch on windows
(see attached image).
Cheers,
Wayne
On 12/11/2017 9:02 AM, Oliver Walters wr
And if they are both an option, should bus-to-bus junctions have this same
behavior or joining two buses with different labels?
On Mon, Dec 11, 2017 at 8:12 AM, Maciej Sumiński
wrote:
> It poses a question then: are the bus-to-bus entries ever used?
>
> Regards,
> Orson
>
> On 12/10/2017 08:12 P
It poses a question then: are the bus-to-bus entries ever used?
Regards,
Orson
On 12/10/2017 08:12 PM, Seth Hillbrand wrote:
> Jon-
>
> Thanks for catching this discrepancy. I had written the logic such that
> busses connect to other busses by a bus-to-bus entry. But clearly, that is
> histori
I tested the patch on Linux and it works as advertised. Well done, we
need the same thing for GAL too.
Cheers,
Orson
On 12/06/2017 07:05 PM, Seth Hillbrand wrote:
> The attached patch fixes https://bugs.launchpad.net/kicad/+bug/1154020
>
> The current double-click handler in draw_panel gets ov
Hi,
Attached patches improve 3d-viewer on macOS a bit.
Patches (1)+(2) add Retina support to 3d-viewer just like it was already there
for GAL canvas.
I pulled out all the ugly #ifdef stuff into a new base class, so now all Retina
related code for GAL and 3d-viewer is in one class.
I put it into
Hi Bernhard,
If you have time and interest, would you test my zone filling, does it work
in mac. It may help to find out progress freezing.
https://github.com/heikkipu/kicad-devel
Regards
Heikki
On Mon, Dec 11, 2017 at 11:25 AM, Bernhard Stegmaier <
stegma...@sw-systems.de> wrote:
> Hi Tom,
Hi,
With interest, I try to improve my parallel zone filling. And new records
are:
Olinuxino A64 board.
My parallel zone filling with new connectivity algo 4s.
My parallel zone filling with old connectivity algo 6s.
Current master 13s.
WRS board.
My parallel zone filling with new connectivity al
Dear Kicad developers,
when looking at the polygons generated by converting all copper layers
to polygons, I found some very small segments. I further investigated
these segments and the reason was that zones are inflated by adding
segments with rounded ends to their boundary. The rounded ends are
I applied this workaround for OSX builds. It is better not to have a
progress dialog rather than freeze on zone refill. It is a temporary
change until we get the hardware where we can debug the problem properly.
Regards,
Orson
On 12/09/2017 03:56 AM, Tomasz Wlostowski wrote:
> On 09/12/17 01:33,
Great, I pushed your patch to the master branch. Thank you for your
contribution.
The line:
+if(isFillEnabled){
should look like:
+if( isFillEnabled )
+{
As I said, nothing I could not fix myself. I realize switching between
projects with different code formatting is not easy, but perh
Hi Tom,
Sorry for the delay… no, doesn’t fix it.
Just hangs in the progress dialog at zero progress/time, no way to close it.
Regards,
Bernhard
> On 9. Dec 2017, at 20:13, Tomasz Wlostowski wrote:
>
> On 09/12/17 18:30, Seth Hillbrand wrote:
>> Tom-
>>
>> I can confirm that this fixes the is
On 12/11/2017 10:11 AM, Maciej Sumiński wrote:
>
> There is a minor code formatting violation, that I will fix. I suppose
> that unfilled polygons have not been used so far, therefore the issue
> could not be observed. If you use them, can you confirm the behavior is
> coherent with the cairo back
Andreas,
There is a minor code formatting violation, that I will fix. I suppose
that unfilled polygons have not been used so far, therefore the issue
could not be observed. If you use them, can you confirm the behavior is
coherent with the cairo backend?
Cheers,
Orson
On 12/08/2017 12:53 PM, And
Hi Andreas,
Good catch, it must have been like this since the GAL origin. I have
applied your patch to the master branch. Thank you!
Cheers,
Orson
On 12/10/2017 11:08 PM, Andreas Buhr wrote:
> Dear Kicad developers,
>
> The "operator BOX2I() const" of EDA_RECT produced wrong boxes, usually
> m
For the record, the patch has been already pushed. Thank you Jon!
Regards,
Orson
On 12/09/2017 07:37 PM, Jon Evans wrote:
> A minor fix due to how wxWidgets parses menu items.
>
> Fixes: https://bugs.launchpad.net/kicad/+bug/1737303
>
> -Jon
>
>
>
> __
Hi Jon,
Thank you for the patch, I have pushed it to the master branch.
Regards,
Orson
On 12/09/2017 08:18 PM, Jon Evans wrote:
> Hi all,
>
> This is a "band-aid" patch for this bug:
> https://bugs.launchpad.net/kicad/+bug/1734377
>
> When flip board view is active, item bounding boxes are not
20 matches
Mail list logo