https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
CC||cbran...@cdalibrary.org
--- Co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #260 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #259)
> Is that expected that Holds allowed (total) isn't taken into account?
> my $lowestvalue = min( $maxreserves, $remaining_holds_for_r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #120366|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #120367|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #120365|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #255 from David Cook ---
(In reply to David Cook from comment #254)
> Going to set this back to "Needs Signoff" so it's clearer that someone other
> than me should test it.
But FYI it is passing the QA tools:
root@kohad
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--- Comment #254
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #253 from David Cook ---
Slightly updated test plan. Everything is working well in koha-testing-docker.
Test plan:
0) git bz apply 15565
1) restart_all
2) Set the maxreserves system preference to 3 (from 50)
3) Set the f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
Attachment #117133|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
Attachment #117132|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
Attachment #117131|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #249 from David Cook ---
(In reply to Martha Fuerst from comment #248)
> I've tried testing this using the Bywater sandboxes, but I can't get the
> pop-up to show up with the current test plan (step 6). When I set
> maxre
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #248 from Martha Fuerst ---
I've tried testing this using the Bywater sandboxes, but I can't get the pop-up
to show up with the current test plan (step 6). When I set maxreserves to 3, I
still don't get an alert when tryi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #247 from David Cook ---
If someone else signs this off, I could potentially QA it...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #246 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
Attachment #117130|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
Attachment #117129|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
Attachment #117128|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #242 from Aleisha Amohia ---
Created attachment 117130
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117130&action=edit
Bug 15565: Place multiple holds on one record on OPAC
Test plan:
1) Apply patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #241 from Aleisha Amohia ---
Created attachment 117129
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117129&action=edit
Bug 15565: Place multiple holds on one record on staff client
Test plan:
1) Appl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #87979|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
Patch comp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #239 from David Cook ---
(In reply to Aleisha Amohia from comment #237)
> I have a bit of time now, tackling this again. I'll try and fix the patches
> so they are easier to work with.
Awesome! Feel free to ping me when
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Martha Fuerst changed:
What|Removed |Added
CC||mfue...@hmcpl.org
--- Comme
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Status|Patch doesn't apply |ASSIGNED
--- Comment #237
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #236 from David Cook ---
Thanks, Jonathan. I haven't looked at it yet, but I'm hoping I'll get the time
to do so at some point.
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Niamh Walker-Headon changed:
What|Removed |Added
CC||niamh.walkerhea...@hse
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #235 from Jonathan Druart
---
Patches applied correctly for me:
% git log --before="2019-04-16" --oneline|head -n1
7e218b81e6 Bug 21953: (follow-up) Fix test count
% git checkout -b bug_15565 7e218b81e6
% yes|git bz ap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #234 from David Cook ---
(Apologies if my above comments came across as rude or disrespectful. I'm not
trying to criticize anyone. I'm just really keen to move forward, as I have a
library that really wants multiple holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #233 from David Cook ---
On the plus side, rebasing actually exposed a bug in master! So yay!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #232 from David Cook ---
I've put in some effort into rebasing these patches (and skipping many of
them), but there's so many different changes that it's difficult to keep it all
straight and the existing test plans are c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #231 from David Cook ---
(In reply to Aleisha Amohia from comment #230)
> I don't have time to get to this right now and probably won't for a while,
> but it is on my list.
I'm happy to collaborate on it as it's increase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #230 from Aleisha Amohia ---
I don't have time to get to this right now and probably won't for a while, but
it is on my list.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #229 from David Cook ---
We can trust that commit 1b5635bebd75c418fdda68036e1e91f857cb1e4d was probably
made and applied on May 30 2019 as it includes the release notes for 19.05.00.
Aleisha posted a comment about patche
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #228 from David Cook ---
It's actually quite interesting...
I just tried `git log --before="2019-04-16"`, which looks good at a glance, but
it doesn't include f668fecec3771b633068f89dcead2312471f9425. Yet,
f668fecec3771b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #227 from David Cook ---
(In reply to Jonathan Druart from comment #226)
> (In reply to David Cook from comment #225)
> > Aleisha, even if you don't squash them, could you let me know the parent
> > commit for these patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #226 from Jonathan Druart
---
(In reply to David Cook from comment #225)
> Aleisha, even if you don't squash them, could you let me know the parent
> commit for these patches from your last rebase?
See https://gist.gith
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #225 from David Cook ---
Trying to find a base to merge these into easily so I can squash them and it's
tough. 18.11, 19.05, 19.11... I never knew that Koha's holds code was changed
so frequently.
Aleisha, even if you d
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #224 from David Cook ---
(In reply to David Cook from comment #223)
> Would it be possible to get squash these patches? I think rebasing 13
> patches where the first one is failing is going to be not a very pleasurable
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #223 from David Cook ---
Would it be possible to get squash these patches? I think rebasing 13 patches
where the first one is failing is going to be not a very pleasurable task.
It looks like these are the files changed:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Jason Robb changed:
What|Removed |Added
CC||jr...@sekls.org
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Katrin Fischer changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84551|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84553|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84552|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84550|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84549|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84544|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84543|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84547|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84546|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84548|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84545|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84542|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #84541|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #207 from Aleisha Amohia ---
Created attachment 84553
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84553&action=edit
Bug 15565: (follow-up) fixing typo that breaks placing a hold
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #206 from Aleisha Amohia ---
Patches have been rebased. Working on improving the code and including
design/layout changes that were requested by Brimbank.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83381|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83380|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83339|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83340|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83338|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83334|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83335|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83336|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #8|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83332|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83337|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Attachment #83331|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #193 from Alex Buckley ---
Aleisha is going to manage/work on the upstreaming of the patches on this bug
report, as I am unlikely to have enough time to do this for the next while.
--
You are receiving this mail because
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Aleisha Amohia changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Alex Buckley changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment #1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #191 from Alex Buckley ---
Created attachment 83381
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83381&action=edit
Bug 15565: (follow-up) Place multiple holds from opac-search.pl
Previously before th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #190 from Alex Buckley ---
Created attachment 83380
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83380&action=edit
Bug 15565: (follow-up) Changes to maximum hold allowed logic
Implemented changes to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Alex Buckley changed:
What|Removed |Added
Attachment #83378|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Alex Buckley changed:
What|Removed |Added
Attachment #83342|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #189 from Alex Buckley ---
Created attachment 83378
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83378&action=edit
Bug 15565: (follow-up) Place multiple holds from opac-search.pl
Previously before th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #188 from Alex Buckley ---
Created attachment 83342
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83342&action=edit
Bug 15565: (follow-up) Changes to maximum hold allowed logic
Implemented changes to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #187 from Alex Buckley ---
Created attachment 83341
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83341&action=edit
Bug 15565: (follow-up) Moved function form C4/Reserves to Koha/Biblio
Also updated t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Alex Buckley changed:
What|Removed |Added
Attachment #83341|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #185 from Alex Buckley ---
Created attachment 83339
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83339&action=edit
Bug 15565: (follow-up) Removed leftover debug code and added missing filters
Sponsor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #186 from Alex Buckley ---
Created attachment 83340
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83340&action=edit
Bug 15565: (QA follow-up) Fix some last filters
Signed-off-by: Katrin Fischer
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #183 from Alex Buckley ---
Created attachment 83337
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83337&action=edit
Bug 15565: Changed the retrieval of selected hold pickup branch in
opac-reserve.pl
P
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #184 from Alex Buckley ---
Created attachment 83338
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83338&action=edit
Bug 15565: Allow up to (and including) maxreserves number of OPAC item
levelholds
Th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #182 from Alex Buckley ---
Created attachment 83336
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83336&action=edit
Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC
This co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #180 from Alex Buckley ---
Created attachment 83334
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83334&action=edit
Bug 15565: Alert librarian that maximum holds per record is reached
Signed-off-by: D
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #181 from Alex Buckley ---
Created attachment 83335
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83335&action=edit
Bug 15565: Remove use of GetBiblionumberFromItemnumber
Signed-off-by: Benjamin Rokse
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #178 from Alex Buckley ---
Created attachment 83332
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83332&action=edit
Bug 15565: Use item's biblionumber only on item-level request
Signed-off-by: Séverin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #179 from Alex Buckley ---
Created attachment 8
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8&action=edit
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off
Signed-of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Alex Buckley changed:
What|Removed |Added
Attachment #81570|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #177 from Alex Buckley ---
Created attachment 83331
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83331&action=edit
Bug 15565: Place multiple holds at once for the same record on staff and OPAC.
Test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Alex Buckley changed:
What|Removed |Added
Attachment #82205|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Alex Buckley changed:
What|Removed |Added
Attachment #82207|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
Alex Buckley changed:
What|Removed |Added
Attachment #82206|0 |1
is obsolete|
1 - 100 of 359 matches
Mail list logo