Kevin Wolf wrote:
Anthony Liguori schrieb:
I guess the main block code is not as defensive as I thought it was. This patch
uses qemu_memalign to allocate the buffers for IO so that you don't get errors
when using O_DIRECT.
Actually, the block code should be able to deal with
Anthony Liguori schrieb:
Kevin Wolf wrote:
Anthony Liguori schrieb:
I guess the main block code is not as defensive as I thought it was.
This patch
uses qemu_memalign to allocate the buffers for IO so that you don't
get errors
when using O_DIRECT.
Actually, the block code should
Kevin Wolf wrote:
Anthony Liguori schrieb:
Kevin Wolf wrote:
Anthony Liguori schrieb:
I guess the main block code is not as defensive as I thought it was.
This patch
uses qemu_memalign to allocate the buffers for IO so that you don't
get errors
when using O_DIRECT.
Anthony Liguori schrieb:
Kevin Wolf wrote:
Anthony Liguori schrieb:
Yes, if it fails, the EINVAL is no surprise. I meant what code path it
was using. Obviously we missed something in our patch and I'd like to
fix that. Did the error occur on raw images or something like qcow2?
It's
Le mercredi 25 juin 2008 à 16:15 +0200, Kevin Wolf a écrit :
Anthony Liguori schrieb:
Kevin Wolf wrote:
Anthony Liguori schrieb:
I guess the main block code is not as defensive as I thought it was.
This patch
uses qemu_memalign to allocate the buffers for IO so that you don't
get
Kevin Wolf wrote:
Anthony Liguori schrieb:
Kevin Wolf wrote:
Anthony Liguori schrieb:
Yes, if it fails, the EINVAL is no surprise. I meant what code path it
was using. Obviously we missed something in our patch and I'd like to
fix that. Did the error occur on raw images or something
Anthony Liguori schrieb:
Kevin Wolf wrote:
Anthony Liguori schrieb:
Kevin Wolf wrote:
Anthony Liguori schrieb:
Yes, if it fails, the EINVAL is no surprise. I meant what code path it
was using. Obviously we missed something in our patch and I'd like to
fix that. Did the error
Kevin Wolf wrote:
Anthony Liguori schrieb:
Kevin Wolf wrote:
Anthony Liguori schrieb:
Kevin Wolf wrote:
Anthony Liguori schrieb:
Yes, if it fails, the EINVAL is no surprise. I meant what code path it
was using. Obviously we missed something in our patch and
I guess the main block code is not as defensive as I thought it was. This patch
uses qemu_memalign to allocate the buffers for IO so that you don't get errors
when using O_DIRECT.
It applies on top of my previous patch to introduce copies in virtio-blk.
Signed-off-by: Anthony Liguori [EMAIL