[kvm-devel] [PATCH] [POWERPC KVM] Kconfig fixes

2008-04-17 Thread Hollis Blanchard
1 file changed, 5 insertions(+), 6 deletions(-) arch/powerpc/kvm/Kconfig | 11 +-- Don't allow building as a module (asm-offsets dependencies). Also, automatically select KVM_BOOKE_HOST until we better separate the guest and host layers. Signed-off-by: Hollis Blanchard &l

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 1/5]Add some trace markers and exposeinterfaces in kernel for tracing

2008-04-17 Thread Hollis Blanchard
could have kvmtrace itself insert the metadata, so there would be no chance of it being overwritten in the kernel buffers. The header could be written in tip_open_output(), and update fs_size accordingly. Do you have any suggestions for the format of the metadata? I'm not sure how it should fit

[kvm-devel] [PATCH] [QEMU POWERPC] FPRs no longer live in kvm_vcpu

2008-04-18 Thread Hollis Blanchard
Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> diff --git a/qemu/qemu-kvm-powerpc.c b/qemu/qemu-kvm-powerpc.c --- a/qemu/qemu-kvm-powerpc.c +++ b/qemu/qemu-kvm-powerpc.c @@ -72,7 +72,6 @@ for (i = 0;i < 32; i++){ regs.gpr[i] = env->gpr[i]; -regs.fpr[i]

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 1/5]Add some trace markers and exposeinterfaces in kernel for tracing

2008-04-21 Thread Hollis Blanchard
On Sunday 20 April 2008 00:38:32 Liu, Eric E wrote: > Christian Ehrhardt wrote: > > Liu, Eric E wrote: > >> Hollis Blanchard wrote: > >>> On Wednesday 16 April 2008 01:45:34 Liu, Eric E wrote: [...] > >>> Actually... we could have kvmtrace itself inser

Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.

2008-04-22 Thread Hollis Blanchard
ed it. Ultimately, this just takes us from a cross-architecture endianness definition to a per-architecture definition. Anyways, we've already fallen into this situation with the virtio ring data itself, so we'r

Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.

2008-04-22 Thread Hollis Blanchard
e may still regret not doing *everything* little-endian, but this doesn't > make it worse. Hmm, why *don't* we just do everything LE, including the ring? -- Hollis Blanchard IBM Linux Technology Center - Th

Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.

2008-04-22 Thread Hollis Blanchard
On Tuesday 22 April 2008 16:05:38 Rusty Russell wrote: > On Wednesday 23 April 2008 06:29:14 Hollis Blanchard wrote: > > On Tuesday 22 April 2008 09:31:35 Rusty Russell wrote: > > > We may still regret not doing *everything* little-endian, but this > > > doesn't

Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.

2008-04-22 Thread Hollis Blanchard
On Tuesday 22 April 2008 17:13:01 Anthony Liguori wrote: > Hollis Blanchard wrote: > > On Tuesday 22 April 2008 16:05:38 Rusty Russell wrote: > > > >> On Wednesday 23 April 2008 06:29:14 Hollis Blanchard wrote: > >> > >>> On Tuesd

Re: [kvm-devel] [RFC PATCH] virtio: change config to guest endian.

2008-04-22 Thread Hollis Blanchard
On Tuesday 22 April 2008 17:13:01 Anthony Liguori wrote: > Hollis Blanchard wrote: > > On Tuesday 22 April 2008 16:05:38 Rusty Russell wrote: > > > >> On Wednesday 23 April 2008 06:29:14 Hollis Blanchard wrote: > >> > >>> On Tuesd

Re: [kvm-devel] [kvm-ppc-devel] Moving kvm lists to kernel.org?

2008-04-24 Thread Hollis Blanchard
andle the last 1% of spam that sneaks through the automated filters. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's excitin

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 2 of 3] Add PowerPC KVM guest wait handling support

2008-04-25 Thread Hollis Blanchard
leteness, you should add the same test to the rfi emulation, which could (theoretically) also set MSR[WE]. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 3 of 3] Add premption handlers & properly wake sleeping guest

2008-04-25 Thread Hollis Blanchard
we muck with the TLB behind the host's back, and that is only in the run path. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 3] Fix guest eating 100% cpu when guest is idle on PowerPC

2008-04-25 Thread Hollis Blanchard
how much CPU *does* an idling guest consume? By the way, you don't explicitly *unset* MSR[WE]. I think this works implicitly because of the way we deliver interrupts; could you add a comment explaining that? -- Hollis Blanchard IBM Linux Technolog

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 2 of 3] Add function dt_cell_multi to hw/device_tree.c

2008-04-29 Thread Hollis Blanchard
set; > +   int ret; Could you please be more careful with your whitespace? -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year

[kvm-devel] Fwd: [kvm-ppc-devel] [PATCH] kvmppc: deliver INTERRUPT_FP_UNAVAIL to the guest

2008-04-29 Thread Hollis Blanchard
Acked-by: Hollis Blanchard <[EMAIL PROTECTED]> Avi, please apply for 2.6.26. -- Hollis Blanchard IBM Linux Technology Center --- Begin Message --- From: Christian Ehrhardt <[EMAIL PROTECTED]> This patch adds the delivery of INTERRUPT_FP_UNAVAIL exceptions to the guest. It's

Re: [kvm-devel] [PATCH] Handle vma regions with no backing page (v2)

2008-04-29 Thread Hollis Blanchard
you don't have mmio, but at least this > shouldn't interfere. OK, so the idea is to mmap /sys/bus/pci/.../region within the guest RAM area, and just include it within the normal guest RAM memslot? How will the IOMMU be programmed? Wouldn't you still need to register a

Re: [kvm-devel] [PATCH] Handle vma regions with no backing page (v2)

2008-04-30 Thread Hollis Blanchard
rrect? I think Andrea's answered this, but for the record: I believe ioremap() will get you struct pages on PPC, but they don't automatically exist. -- Hollis Blanchard IBM Linux Technology Center - This SF.net

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Fix kvm-userspace configure script so that cc=gcc

2008-04-30 Thread Hollis Blanchard
t; --- a/configure > +++ b/configure > @@ -2,7 +2,7 @@ > > prefix=/usr/local > kerneldir=/lib/modules/$(uname -r)/build > -cc=cc > +cc=gcc > ld=ld > objcopy=objcopy > want_module=1 To clarify: there is no such thing as "${cross_prefix}cc", so the configur

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Update kernel/Makefile and remove x86 only entries

2008-04-30 Thread Hollis Blanchard
mx.c \ > > + svm.c \ > > + x86.c \ > > + irq.h > > +endif > >   > >   > > hack-files-x86 = ... > hack-files-ppc = ... > > hack-files = $(hack-files-$(ARCH_DIR))

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 2] [RESEND] [PowerPC] Fix setting memory for bamboo board model

2008-05-05 Thread Hollis Blanchard
e so that it can be something other then the hard coded memory size of 144MB. > > Signed-off-by: Jerone Young <[EMAIL PROTECTED]> Acked-by: Hollis Blanchard <[EMAIL PROTECTED]> Avi, please apply to kvm-userspace; thanks. -- Hollis Blanchard

Re: [kvm-devel] [RFC] Reworking KVM_DEBUG_GUEST

2008-05-14 Thread Hollis Blanchard
it, GDB will fall back to overwriting the instructions in memory. Does the Qemu GDB stub advertise breakpoint support? If not, the only support needed in KVM would be to send all debug interrupts to qemu, and allow qemu to send them back down for in-guest breakpoints. -- Hollis Blanchard

Re: [kvm-devel] [RFC] Reworking KVM_DEBUG_GUEST

2008-05-14 Thread Hollis Blanchard
On Wednesday 14 May 2008 14:10:06 Jan Kiszka wrote: > Hollis Blanchard wrote: > > On Wednesday 14 May 2008 10:28:51 Jan Kiszka wrote: > >> So gdb on power relies only on those few hw-breakpoints? With x86 you > >> can perfectly run gdb (with soft BPs) in parallel with

Re: [kvm-devel] [RFC] Reworking KVM_DEBUG_GUEST

2008-05-14 Thread Hollis Blanchard
this case will set a hardware breakpoint. The alternative is to write an int3 into guest memory. - The stub doesn't care how the hardware registers were configured. All it needs to know is a) that a breakpoint was hit, and b) at what addres

Re: [kvm-devel] [kvm-ppc-devel] [RFC] Reworking KVM_DEBUG_GUEST

2008-05-14 Thread Hollis Blanchard
On Wednesday 14 May 2008 16:06:00 Hollis Blanchard wrote: > In > fact, in the case of soft breakpoints, KVM doesn't even know where all the > set breakpoints are. Side note: I'm retract this sentence: I wrote it before I sketched out the pseudocode, and forgot to remove

Re: [kvm-devel] [kvm-ppc-devel] [RFC] Reworking KVM_DEBUG_GUEST

2008-05-14 Thread Hollis Blanchard
On Wednesday 14 May 2008 16:11:39 Hollis Blanchard wrote: > On Wednesday 14 May 2008 16:06:00 Hollis Blanchard wrote: > > In > > fact, in the case of soft breakpoints, KVM doesn't even know where all the > > set breakpoints are. > > Side note: I'm retra

Re: [kvm-devel] kvm trace support for ppc

2008-05-14 Thread Hollis Blanchard
st records" handling was about. Given that it won't be lost, it would be OK for the kernel to export the header, and in that case I guess you would want it to be the same size as the other records. I'm not sure how I feel about that from a layering point of view, but at least it wou

Re: [kvm-devel] [kvm-ppc-devel] RFC: MMIO endianness flag

2008-01-15 Thread Hollis Blanchard
On Tue, 2008-01-15 at 16:57 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > >> btw, isn't passthrough better handled through the tlb? i.e. actually > >> let the guest access the specially-configured memory? You can have qemu > >> mmap /dev/mem and

[kvm-devel] [PATCH 2 of 2] Use CONFIG_PREEMPT_NOTIFIERS around struct preempt_notifier

2008-01-15 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1200434370 21600 # Node ID 9878c9cec5f831ff5e9b97539aabc5fa3d934501 # Parent 931a81e1002110be0e8bf5b335bf199d43534c2c This allows kvm_host.h to be #included even when struct preempt_notifier is undefined. Signed-

[kvm-devel] [PATCH 0 of 2] A couple ifdefs

2008-01-15 Thread Hollis Blanchard
These small ifdefs are necessary for integration of the PowerPC port. 3 files changed, 9 insertions(+) arch/x86/kvm/Kconfig |5 + include/linux/kvm_host.h |2 ++ virt/kvm/kvm_main.c |2 ++ - This SF.net

[kvm-devel] [PATCH 2 of 6] Register a debug MMIO handler, and implement putc() and exit() with it

2008-01-15 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1200436754 21600 # Node ID f058f7e0e9e2f47beb19114a4ee3c7c44ac03aa0 # Parent c6e8bf3f9f7c9705a0ad29f44fa148fe80a365ff The return code from exit() will propagate all the way out to shell, which will enable some aut

[kvm-devel] [PATCH 4 of 6] Use "$(CC)" instead of "gcc" to find libgcc

2008-01-15 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1200436754 21600 # Node ID 59aa1c2e71c23b6fe1fb072c81163807da817d5b # Parent 05365f8559d584fb1e935a9a64b5fa4f7e894d1f This allows for cross-compiling. Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- 1

[kvm-devel] [PATCH 5 of 6] Create libcflat for PowerPC

2008-01-15 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1200436754 21600 # Node ID d4c0de7599e4a4ae107044aa4f4c95dc50f9ce6a # Parent 59aa1c2e71c23b6fe1fb072c81163807da817d5b This duplicates some test/x86/lib/ files into test/lib/ until someone ports x86 to use the common

[kvm-devel] [PATCH 3 of 6] Move FLATLIBS to config-x86-common.mak

2008-01-15 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1200436754 21600 # Node ID 05365f8559d584fb1e935a9a64b5fa4f7e894d1f # Parent f058f7e0e9e2f47beb19114a4ee3c7c44ac03aa0 This allows other architectures to build test executables in other ways. Signed-off-by: Hollis Bla

[kvm-devel] [PATCH 1 of 6] Move IO handling code to a separate file

2008-01-15 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1200436754 21600 # Node ID c6e8bf3f9f7c9705a0ad29f44fa148fe80a365ff # Parent f22e390c06b78ffbcec4738112309f66267e3582 This will allow other architectures to share it, since main.c is x86-only. Signed-off-by: Hollis Bla

[kvm-devel] [PATCH 6 of 6] Reorganize PowerPC makefiles and add an "exit" test that uses libcflat

2008-01-15 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1200437012 21600 # Node ID 75481de4f07eab17035fb24f14417be2ee62ac10 # Parent d4c0de7599e4a4ae107044aa4f4c95dc50f9ce6a Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- 3 files changed, 92 insertions(+),

Re: [kvm-devel] [PATCH 2 of 2] Use CONFIG_PREEMPT_NOTIFIERS around struct preempt_notifier

2008-01-16 Thread Hollis Blanchard
On Wed, 2008-01-16 at 10:08 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > > # HG changeset patch > > # User Hollis Blanchard <[EMAIL PROTECTED]> > > # Date 1200434370 21600 > > # Node ID 9878c9cec5f831ff5e9b97539aabc5fa3d934501 > > # Parent 931a81e100

[kvm-devel] [PATCH 0 of 6] Enhance PowerPC unit tests

2008-01-18 Thread Hollis Blanchard
These patches create libcflat for PowerPC and allow testcases to communicate with kvmctl via MMIO. They culminate in a C testcase that returns an error code through kvmctl to the shell. The x86 Makefiles looked hairy enough that I didn't want to mess with them, but it should be fairly easy to conv

[kvm-devel] [PATCH 1 of 2] Define and use CONFIG_KVM_HAS_PIO so that we don't need pio_data in kvm_arch_vcpu

2008-01-18 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1200434310 21600 # Node ID 7fa5947a2da8c0c7424ebdcfaebcae624d6cf015 # Parent ee0c227fe3f6632f4b1b5fde3f7e05c8ea0a4378 Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> Signed-off-by: Christian Ehrhardt <[

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 7] PowerPC Embedded KVM qemu enablement patches

2008-01-28 Thread Hollis Blanchard
that's what our KVM code supports. Bamboo is a 440EP reference board, so the Bamboo setup will be useless to qemu until they get 440 support. That said, there are only 2 places that we make KVM-specific calls in this code, and those can easily be protected with "kvm_allowed" che

[kvm-devel] [PATCH] Use CONFIG_PREEMPT_NOTIFIERS around struct preempt_notifier

2008-01-28 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1201563731 21600 # Node ID 6a2f4869cf5da00fa0ccacc9188ea493459ce4cb # Parent a6dd6b5a597903a069cb9711f73ea1b5c4f0b764 This allows kvm_host.h to be #included even when struct preempt_notifier is undefined. This is nee

Re: [kvm-devel] [PATCH] Remove unoptimal code from qemu dcr handles for powerpc

2008-01-29 Thread Hollis Blanchard
-off-by: Jerone Young <[EMAIL PROTECTED]> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Micr

Re: [kvm-devel] [PATCH] Cleanup extern declerations for now removed vcpu_env in Qemu

2008-01-29 Thread Hollis Blanchard
erations for now removed vcpu_env in Qemu > > This patch removes extern decleration for vcpu_env that was recently > removed for PowerPC & IA64 in KVM. > > Signed-off-by: Jerone Young <[EMAIL PROTECTED]> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Clean up KVM/QEMU interaction

2008-01-29 Thread Hollis Blanchard
s is badly needed IMHO. Qemu seems to conform to the broken window theory... -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Use CONFIG_PREEMPT_NOTIFIERS around struct preempt_notifier

2008-01-29 Thread Hollis Blanchard
On Tue, 2008-01-29 at 18:22 -0500, Chris Lalancette wrote: > Hollis Blanchard wrote: > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -67,7 +67,9 @@ void kvm_io_b

Re: [kvm-devel] [PATCH] Use CONFIG_PREEMPT_NOTIFIERS around struct preempt_notifier

2008-01-29 Thread Hollis Blanchard
On Tue, 2008-01-29 at 18:22 -0500, Chris Lalancette wrote: > Hollis Blanchard wrote: > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -67,7 +67,9 @@ void kvm_io_b

Re: [kvm-devel] [kvm-ppc-devel] [RFC PATCH] KVM for PowerPC: simpler TLB handling, better page management

2008-02-01 Thread Hollis Blanchard
On Fri, 2008-02-01 at 13:07 -0600, Nathan Lynch wrote: > Hollis Blanchard wrote: > > --- a/arch/powerpc/kernel/asm-offsets.c > > +++ b/arch/powerpc/kernel/asm-offsets.c > > @@ -22,6 +22,7 @@ > > #include > > #include > > #include > > +#in

Re: [kvm-devel] [PATCH] Make non-x86 arch partially support make sync.

2008-02-04 Thread Hollis Blanchard
$(call unifdef, include/linux/kvm_para.h) Why are these headers not common? > $(call unifdef, include/asm-x86/kvm.h) > @@ -48,6 +60,7 @@ sync: > $(call hack, svm.c) > $(call hack, x86.c) > $(call hack, irq.h) > +endif > for i in $$(find tmp

[kvm-devel] [PATCH 2 of 3] Export kvm_vm_ioctl_create_vcpu() to be called from architecture modules

2008-02-04 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1202189666 21600 # Node ID 7dd50dab9096c8e0125792e3f48083c3f47fceab # Parent bede9476e203f5bf59d21cc3cd71a30de2ce2c44 Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- 2 files changed, 3 insertions(+)

[kvm-devel] [PATCH 0 of 3] RFC: creating a particular vcpu type

2008-02-04 Thread Hollis Blanchard
These patches allow PowerPC to create vcpus of a particular type. Since we are actually emulating the core's supervisor mode, we can choose to emulate any type of core. However, since the core chosen will change the size of the vcpu structure (among other things), we need to know it at vcpu creatio

[kvm-devel] [PATCH 1 of 3] Pass an opaque parameter through kvm_vm_ioctl_vcpu_create() to kvm_arch_vcpu_create()

2008-02-04 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1202189664 21600 # Node ID bede9476e203f5bf59d21cc3cd71a30de2ce2c44 # Parent dfb0e1d58b57dfdf76b3111565815599bd38b92d Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> --- 4 files changed, 9 insertions(+),

[kvm-devel] [PATCH 3 of 3] [POWERPC] Implement an ioctl that creates a vcpu of a particular type

2008-02-04 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1202189668 21600 # Node ID e6e0239e8df55c6af4e0b2959350215aaa119254 # Parent 7dd50dab9096c8e0125792e3f48083c3f47fceab The ioctl accepts a core name as input and calls kvm_vm_ioctl_create_vcpu() with the corresponding

Re: [kvm-devel] [PATCH 3 of 3] [POWERPC] Implement an ioctl that creates a vcpu of a particular type

2008-02-05 Thread Hollis Blanchard
On Tue, 2008-02-05 at 13:52 +0100, Christian Ehrhardt wrote: > Hollis Blanchard wrote: > > The ioctl accepts a core name as input and calls kvm_vm_ioctl_create_vcpu() > > with the corresponding "guest operations" structure. That structure, which > > will be extende

Re: [kvm-devel] [PATCH 0 of 3] RFC: creating a particular vcpu type

2008-02-05 Thread Hollis Blanchard
but a VM needs to reflect hardware layout, and people do it in hardware (again, not running a single system image). "VCPU type" is a VCPU property, and I think the design should reflect that, and as you can see from the patch it's not at all difficult to do. -- Hollis Blanchard IBM Li

Re: [kvm-devel] [PATCH 0 of 3] RFC: creating a particular vcpu type

2008-02-05 Thread Hollis Blanchard
On Tue, 2008-02-05 at 12:05 -0600, Anthony Liguori wrote: > > Hollis Blanchard wrote: > > If it's the "ioctl" in the function name you object to, that's > easily > > changed. > > > > It's not the name, it's what you'

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add print for PowerPC qemu for failed DCR read/writes

2008-02-06 Thread Hollis Blanchard
Yeah, rate-limiting makes sense. Maybe we could take it one step further and only print the warning the first time a particular unemulated DCR is accessed. I also agree about the captalization. :) -- Hollis Blanchard IBM Linux Technology Center On Wed, 2008-02-06 at 12:25 +0100, Christian

[kvm-devel] upstream PowerPC qemu breakage

2008-02-11 Thread Hollis Blanchard
and I'm afraid that isn't feasible. I guess merging with qemu while it's in a period of massive change wasn't the most opportune moment. Were there some device model changes you were eager to pick up? --

Re: [kvm-devel] upstream PowerPC qemu breakage

2008-02-12 Thread Hollis Blanchard
On Tue, 2008-02-12 at 12:45 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > > Long term, one option is to try to define a new qemu target that > > completely bypasses the code generation parts of qemu. Anthony did that > > for x86 once, but there are at least a couple

Re: [kvm-devel] [PATCH] Make non-x86 arch partially support makesync.

2008-02-12 Thread Hollis Blanchard
On Tue, 2008-02-12 at 22:06 +0800, Zhang, Xiantao wrote: > Hollis Blanchard wrote: > > On Fri, 2008-02-01 at 17:34 +0800, Zhang, Xiantao wrote: > >> From: Xiantao Zhang <[EMAIL PROTECTED]> > >> Date: Fri, 1 Feb 2008 17:18:03 +0800 > >> Subject: [PATCH] Mak

[kvm-devel] KVM's signal masking

2008-02-14 Thread Hollis Blanchard
allow the signals simply to be delivered? -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/v

Re: [kvm-devel] [kvm-ppc-devel] upstream PowerPC qemu breakage

2008-02-15 Thread Hollis Blanchard
On Wed, 2008-02-13 at 08:58 +0200, Avi Kivity wrote: > It'll need to be built against your kernel tree; please provide a URL. curl http://penguinppc.org/~hollisb/kvm/kvm-powerpc.mbox | git-am -- Hollis Blanchard IBM Linux Technolog

Re: [kvm-devel] [patch 3/5] KVM: hypercall batching

2008-02-17 Thread Hollis Blanchard
(ret) > + result = ret; > + addr += sizeof(mc); > + } > + if (result < 0) > + return -KVM_EINVAL; > + return result; > +} ... but here you're assuming that 'queue' is physically contiguous, which is not ne

Re: [kvm-devel] [kvm-ppc-devel] upstream PowerPC qemu breakage

2008-02-18 Thread Hollis Blanchard
On Sat, 2008-02-16 at 10:47 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > > On Wed, 2008-02-13 at 08:58 +0200, Avi Kivity wrote: > > > >> It'll need to be built against your kernel tree; please provide a URL. > >> > > > > curl h

Re: [kvm-devel] [kvm-ppc-devel] upstream PowerPC qemu breakage

2008-02-18 Thread Hollis Blanchard
On Mon, 2008-02-18 at 22:22 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > >> Unfortunately I wasn't able to get an F8 ppc rescue cd ISO to boot with > >> qemu 0.9.0. Can you point me to a working combination? > >> > > > > It's dif

Re: [kvm-devel] [PATCH] Using kzalloc to avoid allocating kvm_regs from kernel stack

2008-02-25 Thread Hollis Blanchard
On Mon, 2008-02-25 at 10:38 -0600, Hollis Blanchard wrote: > On Mon, 2008-02-25 at 17:34 +0800, Zhang, Xiantao wrote: > > From: Xiantao Zhang <[EMAIL PROTECTED]> > > Date: Mon, 25 Feb 2008 17:11:43 +0800 > > Subject: [PATCH] kvm: Using kzalloc to avoid allocating kvm

Re: [kvm-devel] [PATCH] Using kzalloc to avoid allocating kvm_regs from kernel stack

2008-02-25 Thread Hollis Blanchard
r = kvm_arch_vcpu_ioctl_set_regs(vcpu, &kvm_regs); > + r = kvm_arch_vcpu_ioctl_set_regs(vcpu, kvm_regs); > if (r) > goto out; > r = 0; Where is this freed? -- Hollis Blanchard IBM Linux Technology Center --

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Fix PowerPC Qemu CPU initilization when using target-ppc/fake-exec.c

2008-02-26 Thread Hollis Blanchard
Acked-by: Hollis Blanchard <[EMAIL PROTECTED]> Avi, please apply. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008

Re: [kvm-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Hollis Blanchard
a libfdt.rpm simply doesn't make sense, and the code is intended to be copied into any codebase that needs it. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all ch

Re: [kvm-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Hollis Blanchard
On Wed, 2008-02-27 at 17:48 +0100, Alexander Graf wrote: > On Feb 27, 2008, at 5:34 PM, Avi Kivity wrote: > > > Hollis Blanchard wrote: > >> It is a centrally co-ordinated effort, but it is not a package a > >> distro > >> would carry. It is code

Re: [kvm-devel] [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Hollis Blanchard
On Wed, 2008-02-27 at 20:18 +0100, Alexander Graf wrote: > On Feb 27, 2008, at 7:56 PM, Hollis Blanchard wrote: > > > On Wed, 2008-02-27 at 17:48 +0100, Alexander Graf wrote: > >> On Feb 27, 2008, at 5:34 PM, Avi Kivity wrote: > >> > >>> Hollis Bl

Re: [kvm-devel] [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Hollis Blanchard
On Wed, 2008-02-27 at 21:25 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > > I think it's obvious that Linux and uboot will never use this. Unless > > someone steps up to continue PowerPC Xen development, neither will Xen. > > So you've now narrowed down the u

Re: [kvm-devel] [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Hollis Blanchard
On Wed, 2008-02-27 at 22:20 +0100, Alexander Graf wrote: > On Feb 27, 2008, at 9:22 PM, Hollis Blanchard wrote: > > > > So again, we the potential users are qemu and dtc. > > Just while reading this I thought "Hey cool, dtc is packaged in most > distributions any

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Fix qemu PPC breakage in monitor.c

2008-02-27 Thread Hollis Blanchard
rm_printf("invalid status: %s\n", status); > return; > } > +#if defined(TARGET_I386) || defined(TARGET_X86_64) > qemu_system_cpu_hot_add(value, state); > +#endif > } > > static void do_info_jit(void) This should be submitted to qemu-devel too, no?

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add --disable-cpu-emulation to qemu help screen

2008-02-27 Thread Hollis Blanchard
t; --sparc_cpu=VBuild qemu for Sparc architecture v7, v8, > v8plus, v8plusa, v9" > +echo " --no-cpu-emulation disables use of qemu cpu emulation code" > echo "" > echo "NOTE: The object files are built at the place wher

Re: [kvm-devel] [PATCH 3/6] kvm: qemu: Add option for enable/disable in kernel PIT

2008-03-11 Thread Hollis Blanchard
This patch breaks all non-x86 architectures, since common code now calls functions defined only in libkvm-x86.c . -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all chall

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model

2008-03-12 Thread Hollis Blanchard
reg[i] = size ram -= size break if ram: print "warning: %d left over" % ram print reg -- Hollis Blanchard IBM Linux Technology Center - Thi

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 1 of 7] Add libfdt to KVM userspace

2008-03-12 Thread Hollis Blanchard
S = $(LIBFDT_SRCS:%.c=%.o) > + > +$(LIBFDT_objdir)/$(LIBFDT_LIB): $(addprefix $(LIBFDT_objdir)/,$(LIBFDT_OBJS)) > + Why are you duplicating Makefile.libfdt instead of including it? -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 3 of 7] Create new load_uboot() & gunzip support to uboot loader in Qemu

2008-03-12 Thread Hollis Blanchard
e the function to load_uimage(). Pass NULL for whatever you rename "la" to, just like "is_linux" is handled already. -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored b

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 4 of 7] Add PPC 440EP bamboo board device tree source & binary into qemu

2008-03-12 Thread Hollis Blanchard
*/ > + 0800 0 0 0 &UIC0 1c 8 > + > + /* IDSEL 2 */ > + 1000 0 0 0 &UIC0 1b 8 > + > + /* IDSEL 3 */ > +

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 5 of 7] Add dynamic device tree manipulation & change uboot loader for PPC bamboo board model

2008-03-12 Thread Hollis Blanchard
t offset; > + offset = get_offset_of_node(fdt, "/cpus/[EMAIL PROTECTED]"); > + set_dt_prop_cell(fdt, offset, "timebase-frequency", > + timebase); > + > +} > + > +void set_dt_initrd_start_prop(void *fdt, uint32_t start_

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 7] PowerPC kvm-userspace patches

2008-03-12 Thread Hollis Blanchard
now! > >But these changes should go in anyway. I don't believe our initrd troubles have anything to do with qemu, so I wouldn't worry about that here. -- Hollis Blanchard IBM Linux Technology Center

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 4 of 7] Add PPC 440EP bamboo board device tree source & binary into qemu

2008-03-14 Thread Hollis Blanchard
There is no zImage, so those comments do not make sense. "Filled in by loader" would be more accurate. You left MAL0 and EMAC0 commented out; please remove them. You left PCI0 uncommented; please comment it out until qemu actually emulates the PCI controller. -- Hollis Blanchard

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model

2008-03-14 Thread Hollis Blanchard
* why? see sdram_bcr() > + * > + * Max of 512MB > + */ > + ram_bases[0] = 0x0; > + ram_sizes[0] = ram_sticks[0]; > + ram_bases[1] = 0x0; > + ram_sizes[1] = ram_sticks[1]; Why keep a separate ram_sticks[] array? Just operate directly on ram_sizes[]

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 0 of 7] [v2] PowerPC kvm-userspace patches

2008-03-14 Thread Hollis Blanchard
On Fri, 2008-03-14 at 12:09 -0500, Jerone Young wrote: > This set address issues disscussed by Hollis on the first go around. > As well as some minor fixes. Btw, please also update the description for patches 3 and 5 to rename "load_uboot_l". -- Hollis Blanchard IBM Linux T

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model

2008-03-18 Thread Hollis Blanchard
; > - > - printf("Ram size of domain is %d bytes\n", (int)ram_size); > + if (tmp_ram_size) { > + printf("WARNING: %i MB left over memory is ram\n", > + bytes_to_mb((int)tmp_ram_size)); > + ram_size -= tmp_ram_si

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 3 of 7] Create new load_uimage() & gunzip support to uboot loader in Qemu

2008-03-18 Thread Hollis Blanchard
tmp_loaded_image_size); > +} > + > +if (loaded_image_size != NULL) > +*loaded_image_size = tmp_loaded_image_size; > + > +if ( load_address != NULL) > + *load_address = hdr->ih

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 2 of 7] Add libfdt support to qemu

2008-03-18 Thread Hollis Blanchard
ot; > +echo "Make sure to have the libfdt libs and headers installed." > +echo > + exit 1 > + fi > +fi What is the problem here? Should you describe it in the patch description? Did you mean to fix this before committing? -- Hollis Blanchard IBM Linu

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 5 of 7] Add dynamic device tree manipulation & change uboot loader for PPC bamboo board model

2008-03-18 Thread Hollis Blanchard
t char *initrd_filename, > const char *cpu_model) > { > + char buf[1024]; You previously said you had removed 'buf' and replaced it with dynamic allocation, but I don't see that here. > target_phys_addr_t ram_bases[2], ram_sizes[2]; >

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 2 of 7] Add libfdt support to qemu

2008-03-18 Thread Hollis Blanchard
OK, if that's acceptable to the qemu folks, could you put that in the patch description? -- Hollis Blanchard IBM Linux Technology Center On Tue, 2008-03-18 at 16:22 -0500, Jerone Young wrote: > So this is the code Anthony asked for for probing libfdt. The problem is > that if you do

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 5 of 7] Add dynamic device tree manipulation & change uboot loader for PPC bamboo board model

2008-03-18 Thread Hollis Blanchard
I can only assume that you will actually make the corrections that you didn't respond to in this mail. On Tue, 2008-03-18 at 16:35 -0500, Jerone Young wrote: > On Tue, 2008-03-18 at 16:25 -0500, Hollis Blanchard wrote: > > > > > +#define DT_PROC_INTERFACE_

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 3 of 7] Create new load_uimage() & gunzip support to uboot loader in Qemu

2008-03-18 Thread Hollis Blanchard
On Tue, 2008-03-18 at 16:46 -0500, Jerone Young wrote: > On Tue, 2008-03-18 at 16:14 -0500, Hollis Blanchard wrote: > > On Tue, 2008-03-18 at 15:06 -0500, Jerone Young wrote: > > > +tmp_loaded_image_size = hdr->ih_size; > > > + > > >

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Fix undefined refrence of qemu_system_device_hot_add for non x86 archs

2008-03-19 Thread Hollis Blanchard
s[] = { > "add drive to PCI storage > controller" }, > { "pci_add", "iss", device_hot_add, "bus nic|storage > [[vlan=n][,macaddr=addr][,model=type]] [file=file][,if=type][,bus=nr]...", > "hot-ad

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model

2008-03-19 Thread Hollis Blanchard
On Wed, 2008-03-19 at 09:45 -0500, Jerone Young wrote: > Add ability to specify ram on command line for bamboo board model I get the following output with this patch: ... Ram size passed is: 144 MB WARNING: -368 MB left over memory is ram ... -- Hollis Blanch

Re: [kvm-devel] [kvm-ppc-devel] [PATCH 5 of 7] Add dynamic device tree manipulation & change uboot loader for PPC bamboo board model

2008-03-19 Thread Hollis Blanchard
of `dt_string' discards qualifiers from pointer target type ../hw/ppc440_bamboo.c:31: warning: 'buf' might be used uninitialized in this function -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sp

Re: [kvm-devel] [RFC/PATCH 05/15] KVM_MAX_VCPUS

2008-03-20 Thread Hollis Blanchard
include > > +#ifdef CONFIG_S390 > +#define KVM_MAX_VCPUS 64 > +#else > #define KVM_MAX_VCPUS 16 > +#endif > #define KVM_MEMORY_SLOTS 32 > /* memory slots that does not exposed to userspace */ > #define KVM_PRIVATE_MEM_SLOTS 4 > Why don't we just define this

Re: [kvm-devel] buliding and testing PowerPC KVM

2008-03-21 Thread Hollis Blanchard
253DDF2%2526CTP%253DEVK,00.html). In the future we should be able to run 440 guests on e.g. POWER5 hosts, but we've already got our hands full without that. -- Hollis Blanchard IBM Linux Technology Center - This SF.net e

Re: [kvm-devel] [PATCH][QEMU] Use a separate device for in-kernel PIT

2008-03-21 Thread Hollis Blanchard
qemu build breakage hitting PowerPC around struct kvm_pit_state, so that's another vote in favor... -- Hollis Blanchard IBM Linux Technology Center - This SF.net email is sponsored by: Microsoft Defy all challenges. Micro

Re: [kvm-devel] [PATCH] Move kvm_get_pit to libkvm.c common code

2008-03-21 Thread Hollis Blanchard
I'm a fan of this approach, but kvm-userspace is eroding my idealism.) The qemu breakage is fixed by Anthony's PIT patch that creates i8254-kvm.c. Don't compile kvm_*_pit() on architectures whose currently supported platforms do not contain a PIT. Signed-off-by: Hollis Blanchard &l

Re: [kvm-devel] buliding and testing PowerPC KVM

2008-03-25 Thread Hollis Blanchard
On Tue, 2008-03-25 at 18:56 +0200, Avi Kivity wrote: > Hollis Blanchard wrote: > > On Fri, 2008-03-21 at 13:02 +0200, Avi Kivity wrote: > > > >> Other than that, and the few minor comments that popped up, this > >> (very > >> nice) patchset will be ver

[kvm-devel] virtio-net working on PowerPC KVM

2008-03-28 Thread Hollis Blanchard
formance rather than debugging mysterious crashes... ;) With this milestone reached, in the near future I intend to start sending patches to Avi and linuxppc-dev for review, hopefully for inclusion in 2.6.26. However, I do want to see if we can improve the performance a little bit first... --

Re: [kvm-devel] booting from virtio-blk

2008-04-01 Thread Hollis Blanchard
On Tue, 2008-04-01 at 09:46 -0500, Anthony Liguori wrote: > Hollis Blanchard wrote: > > On Tue, 2008-04-01 at 14:08 +0200, Christian Ehrhardt wrote: > >> bash-3.00# cat /proc/partitions > >> major minor #blocks name > >> [...] > >> 254

  1   2   3   >