Re: [LEDE-DEV] getver.sh regression

2016-07-13 Thread Álvaro Fernández Rojas
Hi Jonas, It works correctly for me. Álvaro. El 13/7/16 a las 12:14, Jonas Gorski escribió: > On 13 July 2016 at 11:52, Álvaro Fernández Rojas wrote: >> That one is working fine after a small fix: >> https://gist.github.com/Noltari/0c395c57b94598bdf96e6a292c7b5888 >> (You're missing one "|"). >

Re: [LEDE-DEV] getver.sh regression

2016-07-13 Thread Jonas Gorski
On 13 July 2016 at 11:52, Álvaro Fernández Rojas wrote: > That one is working fine after a small fix: > https://gist.github.com/Noltari/0c395c57b94598bdf96e6a292c7b5888 > (You're missing one "|"). That's what I get for manually fixing up an older WIP patch ;p. I added another commit on top, drop

Re: [LEDE-DEV] getver.sh regression

2016-07-13 Thread Álvaro Fernández Rojas
That one is working fine after a small fix: https://gist.github.com/Noltari/0c395c57b94598bdf96e6a292c7b5888 (You're missing one "|"). El 13/7/16 a las 11:45, Jonas Gorski escribió: > On 13 July 2016 at 11:16, Álvaro Fernández Rojas wrote: >> Appart from that, if there's no remote named origin it

Re: [LEDE-DEV] getver.sh regression

2016-07-13 Thread Jonas Gorski
On 13 July 2016 at 11:16, Álvaro Fernández Rojas wrote: > Appart from that, if there's no remote named origin it will also spam some > errors about having no reference to origin/master. > My current setup includes lede, staging and github remotes, so there's no > origin remote at all. Can you g

Re: [LEDE-DEV] getver.sh regression

2016-07-13 Thread Jonas Gorski
On 13 July 2016 at 11:13, John Crispin wrote: > > > On 13/07/2016 11:11, Jonas Gorski wrote: >> Hi John, >> >> On 13 July 2016 at 09:39, John Crispin wrote: >>> Hi Jonas, >>> Hi Felix, >>> >>> your recent changes to getver.sh are causing a regression when not >>> building inside trunk but inside

Re: [LEDE-DEV] getver.sh regression

2016-07-13 Thread Álvaro Fernández Rojas
Appart from that, if there's no remote named origin it will also spam some errors about having no reference to origin/master. My current setup includes lede, staging and github remotes, so there's no origin remote at all. El 13/7/16 a las 9:39, John Crispin escribió: > Hi Jonas, > Hi Felix, > >

Re: [LEDE-DEV] getver.sh regression

2016-07-13 Thread John Crispin
On 13/07/2016 11:11, Jonas Gorski wrote: > Hi John, > > On 13 July 2016 at 09:39, John Crispin wrote: >> Hi Jonas, >> Hi Felix, >> >> your recent changes to getver.sh are causing a regression when not >> building inside trunk but inside a staging tree >> >> blogic@debian:/lede/staging$ ./script

Re: [LEDE-DEV] getver.sh regression

2016-07-13 Thread Jonas Gorski
Hi John, On 13 July 2016 at 09:39, John Crispin wrote: > Hi Jonas, > Hi Felix, > > your recent changes to getver.sh are causing a regression when not > building inside trunk but inside a staging tree > > blogic@debian:/lede/staging$ ./scripts/getver.sh > warning: refname 'origin/master' is ambigu

[LEDE-DEV] getver.sh regression

2016-07-13 Thread John Crispin
Hi Jonas, Hi Felix, your recent changes to getver.sh are causing a regression when not building inside trunk but inside a staging tree blogic@debian:/lede/staging$ ./scripts/getver.sh warning: refname 'origin/master' is ambiguous. r411+546 blogic@debian:/lede/staging$ git branch * master origin