Re: Revert "tdf#106283: Registry settings are not read properly on Windows"

2017-03-07 Thread Zolnai Tamás
Hi Stephan, >> 2. About your idea how to fix it in windows registry handler code. >> I hope I understand your words well. So you suggest to have a third >> entry for Windows registry keys which specifies the type. For the >> first thought it was a good idea, as you sad it would be easy to >>

Re: Revert "tdf#106283: Registry settings are not read properly on Windows"

2017-03-07 Thread Stephan Bergmann
On 03/07/2017 02:36 PM, Zolnai Tamás wrote: 1. From the users perspective (XCU user). What I see is that user can specify a property in an XCU file without a type if this proprty is not a member of an extensible group. This bug I'm trying to fix affects only that rare case when this property is

Re: Revert "tdf#106283: Registry settings are not read properly on Windows"

2017-03-07 Thread Zolnai Tamás
Hi Stephan, So I think this conversation is heading somewhere. So two things I have in my minds. 1. From the users perspective (XCU user). What I see is that user can specify a property in an XCU file without a type if this proprty is not a member of an extensible group. This bug I'm trying to

Re: Revert "tdf#106283: Registry settings are not read properly on Windows"

2017-03-07 Thread Stephan Bergmann
On 03/07/2017 10:00 AM, Zolnai Tamás wrote: So coming back to , I'm not too excited about that hack. It's a quick-fix to work around one specific shortcoming of the naive Windows registry mapping, but in a way that would require that hack to stay for

Re: Revert "tdf#106283: Registry settings are not read properly on Windows"

2017-03-07 Thread Zolnai Tamás
Hi Stephan, > So coming back to , I'm not too > excited about that hack. It's a quick-fix to work around one specific > shortcoming of the naive Windows registry mapping, but in a way that would > require that hack to stay for backwards-compatibility

Re: Revert "tdf#106283: Registry settings are not read properly on Windows"

2017-03-07 Thread Stephan Bergmann
On 03/06/2017 09:43 PM, Tamas Zolnai wrote: Anyway, you must be right with that it's not a good idea to change the staticType_, so I added an other fix which does not affect staticType_, but uses a typeHint only for parsing a specific value from XCU file. Can you review this change please? I

Re: Revert "tdf#106283: Registry settings are not read properly on Windows"

2017-03-06 Thread Tamas Zolnai
, please. It's not all clear. > > Your commit message was: > "Revert "tdf#106283: Registry settings are not read properly on Windows" > This reverts commit 8cfda7206139b3017346c435591c77c9741ba8ee. The problem in > that issue is that the configmgr/source/winreg.cxx code gener

Re: Revert "tdf#106283: Registry settings are not read properly on Windows"

2017-03-06 Thread Tamas Zolnai
Hi Stephan, I saw you reverted my change about config manager. Can you help me understanding your comments, please. It's not all clear. Your commit message was: "Revert "tdf#106283: Registry settings are not read properly on Windows" This reverts commit 8cfda7206139b3017346c4355