Re: [libvirt] [PATCH v2] Pull DBus event code out into common area

2012-04-12 Thread Eric Blake
On 04/12/2012 02:07 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The policy kit and HAL node device drivers both require a > DBus connection. The HAL device code further requires that > the DBus connection is integrated with the event loop and > provides such glue logic itself.

Re: [libvirt] [PATCH] xend_internal: Use domain/status for shutdown check

2012-04-12 Thread Eric Blake
On 04/12/2012 03:50 PM, Cole Robinson wrote: > On 04/12/2012 09:42 AM, Stefan Bader wrote: >> As promised this version does keep the domid < 0 check in >> order to be clearly keeping the old behavior. >> >> -Stefan >> >> >From 18d398d98dc0dc2d9148ffb8673c651248d1bca5 Mon Sep 17 00:00:00 2001 >> Fro

Re: [libvirt] [PATCH] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-12 Thread Cole Robinson
On 04/12/2012 09:42 AM, Stefan Bader wrote: > This is a re-send as there was some positive feedback but the > patch itself made it into the repo. > > -Stefan > >>From a3198c5c1ae8908818f6c0f0df4237dbe5ddeec7 Mon Sep 17 00:00:00 2001 > From: Stefan Bader > Date: Thu, 12 Apr 2012 15:32:41 +0200 >

Re: [libvirt] [PATCH] xend_internal: Use domain/status for shutdown check

2012-04-12 Thread Cole Robinson
On 04/12/2012 09:42 AM, Stefan Bader wrote: > As promised this version does keep the domid < 0 check in > order to be clearly keeping the old behavior. > > -Stefan > >>From 18d398d98dc0dc2d9148ffb8673c651248d1bca5 Mon Sep 17 00:00:00 2001 > From: Stefan Bader > Date: Thu, 12 Apr 2012 09:59:56 +0

Re: [libvirt] [Guidelines Change] Changes to the Packaging Guidelines

2012-04-12 Thread Eric Blake
things we should be thinking about: On 04/12/2012 02:57 PM, Tom Callaway wrote: > Here is the latest set of changes to the Fedora Packaging Guidelines: > > --- > > Packages which have SysV initscripts that contain 'non-standard service > commands' (commands besides start, stop, reload, restart,

[libvirt] [libvirt-glib] Getter/setter for disk source's startupPolicy attribute

2012-04-12 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26 + libvirt-gconfig/libvirt-gconfig-domain-disk.h |9 libvirt-gconfig/libvirt-gconfig.sym |5 +++- libvirt-gconfig/tests/test-domain-create.c|2 + 4 fi

[libvirt] [PATCH v2] Pull DBus event code out into common area

2012-04-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The policy kit and HAL node device drivers both require a DBus connection. The HAL device code further requires that the DBus connection is integrated with the event loop and provides such glue logic itself. The forthcoming FirewallD integration also requires a dbus co

Re: [libvirt] [PATCH] Pull DBus event code out into common area

2012-04-12 Thread Daniel P. Berrange
On Thu, Apr 12, 2012 at 02:05:44PM -0600, Eric Blake wrote: > Did you forget to squash this into a prior patch? The commit message > mentions a new file virdbus.h that I don't see here, and since I don't > have virdbus.c, this patch won't apply. Urgh, yes. Squashed & resent Daniel -- |: http://

Re: [libvirt] [PATCH] Pull DBus event code out into common area

2012-04-12 Thread Eric Blake
On 04/12/2012 01:14 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The policy kit and HAL node device drivers both require a > DBus connection. The HAL device code further requires that > the DBus connection is integrated with the event loop and > provides such glue logic itself.

[libvirt] [PATCH] blockjob: add virsh blockjob --wait

2012-04-12 Thread Eric Blake
I'm tired of shell-scripting to wait for completion of a block pull, when virsh can be taught to do the same. I couldn't quite reuse vshWatchJob, as this is not a case of a long-running command where a second thread must be used to probe job status (at least, not unless I make virsh start doing bl

[libvirt] [PATCH] Pull DBus event code out into common area

2012-04-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The policy kit and HAL node device drivers both require a DBus connection. The HAL device code further requires that the DBus connection is integrated with the event loop and provides such glue logic itself. The forthcoming FirewallD integration also requires a dbus co

Re: [libvirt] Sys-Virt and libvirt, question

2012-04-12 Thread Daniel P. Berrange
On Thu, Apr 12, 2012 at 10:16:39AM -0700, Jason Helfman wrote: > Hi, > > I was wondering if Sys-Virt needs to coincide with an update to libvirt? > > A fellow committer at FreeBSD is running the latest Sys-Virt against the > latest libvirt and is getting this error: > http://meatwad.mouf.net/tb/e

Re: [libvirt] [PATCH] qemu, util fix netlink callback registration for migration

2012-04-12 Thread Laine Stump
On 03/29/2012 07:15 AM, D. Herrendoerfer wrote: > From: "D. Herrendoerfer" > > This patch adds a netlink callback when migrating a VEPA enabled > virtual machine. > It fixes a Bug where a VM would not request a port association when > it was cleared by lldpad. > This patch requires the latest git

[libvirt] Sys-Virt and libvirt, question

2012-04-12 Thread Jason Helfman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I was wondering if Sys-Virt needs to coincide with an update to libvirt? A fellow committer at FreeBSD is running the latest Sys-Virt against the latest libvirt and is getting this error: http://meatwad.mouf.net/tb/errors/9-STABLE-amd64-FreeBSD

Re: [libvirt] [test-API PATCH 0/4]Add feature to check case file before running

2012-04-12 Thread Guannan Ren
On 04/12/2012 09:43 PM, Guannan Ren wrote: On 04/12/2012 07:53 PM, Peter Krempa wrote: I don't think pushing this series without a review was a good idea. You actualy broke all of the tests in the repos/ as you didn't do the modifications to the parameter checking algorithm in a way that didn'

Re: [libvirt] [test-API PATCH 2/4] cfgcheck: new class implement testcase config file checking

2012-04-12 Thread Guannan Ren
On 04/12/2012 07:38 PM, Martin Kletzander wrote: On 04/11/2012 04:04 PM, Guannan Ren wrote: casecfgcheck.py --- casecfgcheck.py | 66 +++ 1 files changed, 66 insertions(+), 0 deletions(-) create mode 100644 casecfgcheck.py diff --g

Re: [libvirt] "virsh list" hangs

2012-04-12 Thread Alex Jia
Here is a similar issues, please see Jiri's comment: https://bugzilla.redhat.com/show_bug.cgi?id=797835#c5 Regards, Alex - Original Message - From: "Michal Privoznik" To: "Qian Zhang" Cc: libvir-list@redhat.com Sent: Thursday, April 12, 2012 8:49:21 PM Subject: Re: [libvirt] "virsh lis

[libvirt] [PATCH v2] qemu_agent: Report error class at least

2012-04-12 Thread Michal Privoznik
Currently, qemu GA is not providing 'desc' field for errors like we are used to from qemu monitor. Therefore, we fall back to this general 'unknown error' string. However, GA is reporting 'class' which is not perfect, but much more helpful than generic error string. Thus we should fall back to clas

[libvirt] [PATCH] xend_internal: Use domain/status for shutdown check

2012-04-12 Thread Stefan Bader
As promised this version does keep the domid < 0 check in order to be clearly keeping the old behavior. -Stefan >From 18d398d98dc0dc2d9148ffb8673c651248d1bca5 Mon Sep 17 00:00:00 2001 From: Stefan Bader Date: Thu, 12 Apr 2012 09:59:56 + Subject: [PATCH] xend_internal: Use domain/status for s

[libvirt] [PATCH] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-12 Thread Stefan Bader
This is a re-send as there was some positive feedback but the patch itself made it into the repo. -Stefan >From a3198c5c1ae8908818f6c0f0df4237dbe5ddeec7 Mon Sep 17 00:00:00 2001 From: Stefan Bader Date: Thu, 12 Apr 2012 15:32:41 +0200 Subject: [PATCH] libvirt: xen: do not use ioemu type for any

Re: [libvirt] [test-API PATCH 0/4]Add feature to check case file before running

2012-04-12 Thread Guannan Ren
On 04/12/2012 07:53 PM, Peter Krempa wrote: I don't think pushing this series without a review was a good idea. You actualy broke all of the tests in the repos/ as you didn't do the modifications to the parameter checking algorithm in a way that didn't require modification of the tests, neither

Re: [libvirt] [PATCH] qemu_agent: Report error class at least

2012-04-12 Thread Michal Privoznik
On 12.04.2012 14:14, Daniel P. Berrange wrote: > On Thu, Apr 12, 2012 at 02:06:21PM +0200, Michal Privoznik wrote: >> Currently, qemu GA is not providing 'desc' field for errors like >> we are used to from qemu monitor. Therefore, we fall back to this >> general 'unknown error' string. However, GA

Re: [libvirt] [PATCH] qemuOpenFile: Don't force chown on NFS

2012-04-12 Thread Michal Privoznik
On 12.04.2012 13:16, Laine Stump wrote: > On 04/11/2012 04:21 PM, Laine Stump wrote: >> ACK to the idea, but NACK to the exact placement of the fix. > > > On further examination (and actually doing a couple tests), I withdraw > my NACK on the placement. I had mixed up usage of qemuOpenFile and >

Re: [libvirt] "virsh list" hangs

2012-04-12 Thread Michal Privoznik
On 12.04.2012 10:40, Qian Zhang wrote: > Hi, > > I am using RHEL 6.2 64bit, and the libvirt shipped in it is > "libvirt-0.9.4-23.el6.x86_64". I found sometimes the command "virsh > list" hangs forever, and same issue for virt-manager which is always > in "Connecting" status. But after restarting t

Re: [libvirt] [libvirt-glib] Explicitly link conn-test against libvirt-gconfig libvirt-glib

2012-04-12 Thread Guido Günther
On Wed, Apr 11, 2012 at 01:41:20PM +0100, Daniel P. Berrange wrote: > On Wed, Apr 11, 2012 at 01:54:27PM +0200, Guido Günther wrote: > > On Tue, Apr 10, 2012 at 09:36:57PM +0100, Daniel P. Berrange wrote: > > > On Tue, Apr 10, 2012 at 10:29:59PM +0200, Guido Günther wrote: > > > > otherwise the bui

[libvirt] "virsh list" hangs

2012-04-12 Thread Qian Zhang
Hi, I am using RHEL 6.2 64bit, and the libvirt shipped in it is "libvirt-0.9.4-23.el6.x86_64". I found sometimes the command "virsh list" hangs forever, and same issue for virt-manager which is always in "Connecting" status. But after restarting the libvirtd service, this issue is gone. Is this a

Re: [libvirt] [PATCH] qemu_agent: Report error class at least

2012-04-12 Thread Daniel P. Berrange
On Thu, Apr 12, 2012 at 02:06:21PM +0200, Michal Privoznik wrote: > Currently, qemu GA is not providing 'desc' field for errors like > we are used to from qemu monitor. Therefore, we fall back to this > general 'unknown error' string. However, GA is reporting 'class' which > is not perfect, but muc

[libvirt] [PATCH] qemu_agent: Report error class at least

2012-04-12 Thread Michal Privoznik
Currently, qemu GA is not providing 'desc' field for errors like we are used to from qemu monitor. Therefore, we fall back to this general 'unknown error' string. However, GA is reporting 'class' which is not perfect, but much more helpful than generic error string. Thus we should fall back to clas

Re: [libvirt] [test-API PATCH 0/4]Add feature to check case file before running

2012-04-12 Thread Peter Krempa
I don't think pushing this series without a review was a good idea. You actualy broke all of the tests in the repos/ as you didn't do the modifications to the parameter checking algorithm in a way that didn't require modification of the tests, neither did you change the tests to cope with the n

Re: [libvirt] [test-API PATCH 2/4] cfgcheck: new class implement testcase config file checking

2012-04-12 Thread Martin Kletzander
On 04/11/2012 04:04 PM, Guannan Ren wrote: > casecfgcheck.py > --- > casecfgcheck.py | 66 > +++ > 1 files changed, 66 insertions(+), 0 deletions(-) > create mode 100644 casecfgcheck.py > > diff --git a/casecfgcheck.py b/casecfgcheck.py

Re: [libvirt] [test-API PATCH 1/4] filter: new class for filter or extract data

2012-04-12 Thread Martin Kletzander
On 04/11/2012 04:04 PM, Guannan Ren wrote: > activityfilter.py > --- > activityfilter.py | 74 > + > 1 files changed, 74 insertions(+), 0 deletions(-) > create mode 100644 activityfilter.py > > diff --git a/activityfilter.py b/activityfi

Re: [libvirt] [PATCH] qemuOpenFile: Don't force chown on NFS

2012-04-12 Thread Laine Stump
On 04/11/2012 04:21 PM, Laine Stump wrote: > ACK to the idea, but NACK to the exact placement of the fix. On further examination (and actually doing a couple tests), I withdraw my NACK on the placement. I had mixed up usage of qemuOpenFile and virFileOpen in my memory - qemuOpenFile already hardl

Re: [libvirt] [libvirt-gconfig PATCHv2 01/14] Add GVirConfigDomainController skeleton

2012-04-12 Thread Christophe Fergeau
On Thu, Apr 12, 2012 at 12:06:52PM +0200, Guido Günther wrote: > On Wed, Apr 11, 2012 at 03:48:09PM +0200, Christophe Fergeau wrote: > [..snip..] > > --- a/libvirt-gconfig/libvirt-gconfig.sym > > +++ b/libvirt-gconfig/libvirt-gconfig.sym > > @@ -69,6 +69,8 @@ LIBVIRT_GCONFIG_0.0.4 { > > gvir_c

Re: [libvirt] [libvirt-gconfig PATCHv2 01/14] Add GVirConfigDomainController skeleton

2012-04-12 Thread Guido Günther
On Wed, Apr 11, 2012 at 03:48:09PM +0200, Christophe Fergeau wrote: [..snip..] > --- a/libvirt-gconfig/libvirt-gconfig.sym > +++ b/libvirt-gconfig/libvirt-gconfig.sym > @@ -69,6 +69,8 @@ LIBVIRT_GCONFIG_0.0.4 { > gvir_config_domain_console_set_target_type; > gvir_config_domain_console_

Re: [libvirt] [libvirt-glib] Getter/setter for disk source's startupPolicy attribute

2012-04-12 Thread Guido Günther
On Thu, Apr 12, 2012 at 05:54:25AM +0300, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26 > + > libvirt-gconfig/libvirt-gconfig-domain-disk.h |9 > libvirt-gconfig/libvirt-gconfig.s

Re: [libvirt] [PATCHv2] daemon: Plug memory leaks

2012-04-12 Thread Alex Jia
On 04/12/2012 05:12 PM, Daniel P. Berrange wrote: On Thu, Apr 12, 2012 at 05:12:12PM +0800, Alex Jia wrote: * daemon/libvirtd-config.c (daemonConfigFree): fix memory leaks. How to reproduce? % make&& make -C tests check TESTS=libvirtdconftest % cd tests&& valgrind -v --leak-check=full ./libv

Re: [libvirt] [PATCHv2] daemon: Plug memory leaks

2012-04-12 Thread Daniel P. Berrange
On Thu, Apr 12, 2012 at 05:12:12PM +0800, Alex Jia wrote: > * daemon/libvirtd-config.c (daemonConfigFree): fix memory leaks. > > How to reproduce? > > % make && make -C tests check TESTS=libvirtdconftest > % cd tests && valgrind -v --leak-check=full ./libvirtdconftest > > actual result: > > ==1

[libvirt] [PATCHv2] daemon: Plug memory leaks

2012-04-12 Thread Alex Jia
* daemon/libvirtd-config.c (daemonConfigFree): fix memory leaks. How to reproduce? % make && make -C tests check TESTS=libvirtdconftest % cd tests && valgrind -v --leak-check=full ./libvirtdconftest actual result: ==11008== 185 bytes in 5 blocks are definitely lost in loss record 3 of 5 ==11008

Re: [libvirt] [PATCH] daemon: Plug memory leaks

2012-04-12 Thread Alex Jia
On 04/12/2012 04:37 PM, Daniel P. Berrange wrote: On Thu, Apr 12, 2012 at 03:24:08PM +0800, Alex Jia wrote: Detected by valgrind. Leaks are introduced in commit 6e6e9be. * daemon/libvirtd-config.c (macro GET_CONF_STR): fix memory leaks. How to reproduce? % make&& make -C tests check TESTS=li

Re: [libvirt] [libvirt-glib] Getter/setter for disk source's startupPolicy attribute

2012-04-12 Thread Christophe Fergeau
Hey, On Thu, Apr 12, 2012 at 05:54:25AM +0300, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26 > + > libvirt-gconfig/libvirt-gconfig-domain-disk.h |9 > libvirt-gconfig/libvirt-gco

Re: [libvirt] [PATCH] daemon: Plug memory leaks

2012-04-12 Thread Daniel P. Berrange
On Thu, Apr 12, 2012 at 03:24:08PM +0800, Alex Jia wrote: > Detected by valgrind. Leaks are introduced in commit 6e6e9be. > > * daemon/libvirtd-config.c (macro GET_CONF_STR): fix memory leaks. > > How to reproduce? > > % make && make -C tests check TESTS=libvirtdconftest > % cd tests && valgrind

Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers

2012-04-12 Thread Christophe Fergeau
On Wed, Apr 11, 2012 at 06:51:48PM +0200, Marc-André Lureau wrote: > On Wed, Apr 11, 2012 at 6:19 PM, Daniel P. Berrange > wrote: > > The concept of 'default usb controllers' seems very policy based > > to me & different hypervisors will have different views of this. > > This is a helper, it is

Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers

2012-04-12 Thread Christophe Fergeau
On Wed, Apr 11, 2012 at 05:19:33PM +0100, Daniel P. Berrange wrote: > The concept of 'default usb controllers' seems very policy based > to me & different hypervisors will have different views of this. With respect to hypervisors, since the function has a GVirConfigDomain parameter, we could use i

[libvirt] [PATCH] daemon: Plug memory leaks

2012-04-12 Thread Alex Jia
Detected by valgrind. Leaks are introduced in commit 6e6e9be. * daemon/libvirtd-config.c (macro GET_CONF_STR): fix memory leaks. How to reproduce? % make && make -C tests check TESTS=libvirtdconftest % cd tests && valgrind -v --leak-check=full ./libvirtdconftest actual result: ==11008== 185 by