Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-04-05 Thread Guannan Ren
On 04/04/2012 11:09 PM, Laine Stump wrote: On 03/29/2012 08:14 AM, Martin Kletzander wrote: So here are the things I would like to do definitely (the optional things follow later on): - fix hard-coded options into real options (e.g. commit 65449e) Forgive me if I'm suggesting things that alre

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-04-04 Thread Laine Stump
On 03/29/2012 08:14 AM, Martin Kletzander wrote: > So here are the things I would like to do definitely (the optional > things follow later on): > - fix hard-coded options into real options (e.g. commit 65449e) Forgive me if I'm suggesting things that already exist - I haven't had time to go thro

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-04-02 Thread Martin Kletzander
On 04/01/2012 04:30 PM, Guannan Ren wrote: > On 03/29/2012 10:20 PM, Guannan Ren wrote: >> On 03/29/2012 08:14 PM, Martin Kletzander wrote: [...] >Hi Martin > > Could you have a review on the code. > Anything require changes, you could sent patch based

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-04-01 Thread Guannan Ren
On 03/29/2012 10:20 PM, Guannan Ren wrote: On 03/29/2012 08:14 PM, Martin Kletzander wrote: - fix hard-coded options into real options (e.g. commit 65449e) - fix some env_* and util* code (functions duplicated with different behavior) - fix or remove harmful and pointless code (at this po

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-30 Thread Guannan Ren
On 03/30/2012 05:33 PM, Martin Kletzander wrote: To answer two of your questions at once, I'll show you an example of what I had in mind (BTW: one of the current disadvantages is also the fact that each indentation level _must_ be 4 spaces, otherwise you'll get an error). Please be aware that th

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-30 Thread Martin Kletzander
On 03/29/2012 04:20 PM, Guannan Ren wrote: > On 03/29/2012 08:14 PM, Martin Kletzander wrote: >> >> - fix hard-coded options into real options (e.g. commit 65449e) >> - fix some env_* and util* code (functions duplicated with different >> behavior) >> - fix or remove harmful and pointless cod

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-30 Thread Martin Kletzander
On 03/29/2012 03:42 PM, Osier Yang wrote: > On 2012年03月29日 20:14, Martin Kletzander wrote: >> Hi everyone, >> >> following our minutes, I'd like to start a discussion on what should be >> done with libvirt-test-API so we can say it's stable and usable. >> >> I would like to stress out that everythi

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-29 Thread Guannan Ren
On 03/29/2012 08:14 PM, Martin Kletzander wrote: - fix hard-coded options into real options (e.g. commit 65449e) - fix some env_* and util* code (functions duplicated with different behavior) - fix or remove harmful and pointless code (at this point, when creating domain on remote machine,

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-29 Thread Osier Yang
On 2012年03月29日 20:14, Martin Kletzander wrote: Hi everyone, following our minutes, I'd like to start a discussion on what should be done with libvirt-test-API so we can say it's stable and usable. I would like to stress out that everything mentioned here is just an opinion and I don't mean to t

Re: [libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-29 Thread Peter Krempa
On 03/29/2012 02:14 PM, Martin Kletzander wrote: Hi everyone, following our minutes, I'd like to start a discussion on what should be done with libvirt-test-API so we can say it's stable and usable. I would like to stress out that everything mentioned here is just an opinion and I don't mean to

[libvirt] [test-API] RFC: Stabilization of libvirt-test-API

2012-03-29 Thread Martin Kletzander
Hi everyone, following our minutes, I'd like to start a discussion on what should be done with libvirt-test-API so we can say it's stable and usable. I would like to stress out that everything mentioned here is just an opinion and I don't mean to talk down to someone as it may have seemed earlier