Currently we are parsing all the possible cpus to get the
nodeinfo. This fix will perform a check for present cpus
before parsing.
Signed-off-by: Kothapally Madhu Pavan
---
src/nodeinfo.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index
disks.
This patch series prevents libvirt from launching ppc64[le] -based 'pseries'
VMs with floppy devices.
---
Kothapally Madhu Pavan (2):
Caps: Disable floppy disk for PowerPC Vm
Avoid starting a PowerPC VM with floppy disk
src/conf/domain_conf.c | 19 +++
PowerPC pseries based VMs do not support a floppy disk controller.
This prohibits libvirt from creating qemu command with floppy device.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_command.c | 47 +--
1 file changed, 45 insertions(+), 2
PowerPC pseries based VMs do not support a floppy disk controller.
This prohibits libvirt from adding floppy disk for a PowerPC pseries VM.
Signed-off-by: Kothapally Madhu Pavan
---
src/conf/domain_conf.c | 19 +++
src/qemu/qemu_capabilities.c | 15 +++
2
PowerPC pseries based VMs do not support a floppy disk controller.
This prohibits libvirt from adding floppy disk for a PowerPC pseries VM.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_capabilities.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git
PowerPC pseries based VMs do not support a floppy disk controller.
This prohibits libvirt from creating qemu command with floppy device.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_command.c |8
1 file changed, 8 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src
PowerPC pseries based VMs do not support a floppy disk controller.
This test case fails if libvirt allows a floppy disk on pseries VMs.
Signed-off-by: Kothapally Madhu Pavan
---
.../qemuxml2argv-disk-floppy-pseries.args |6 +++
.../qemuxml2argv-disk-floppy-pseries.xml
disks.
This patch series prevents libvirt from launching ppc64[le] -based 'pseries'
VMs with floppy devices.
This version of patch attempts to fulfill the coments of Andrea Bolognani
and Jan Tomko on previous version of patch.
---
Kothapally Madhu Pavan (3):
Caps: Disable floppy d
When the hostdev managed=true, the VFIO devices are reattached
to the host driver before coming to qemuTeardownHostdevCgroup().
So, the /dev/vfio/ path would not exist. We ignore the
EACCES error here.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_cgroup.c |2 +-
1 file changed, 1
Virsh capabilities will list offline cpus as online when
libvirt is compiled with numactl option disabled. This
fix will list correct set of online cpus.
Signed-off-by: Kothapally Madhu Pavan
---
src/nodeinfo.c | 36
1 file changed, 24 insertions(+), 12
Virsh capabilities will list offline cpus as online when
libvirt is compiled with numactl option disabled. This
fix will list correct set of online cpus.
---
src/nodeinfo.c | 43 +++
1 file changed, 43 insertions(+)
diff --git a/src/nodeinfo.c b/src/nodei
Currently we are parsing all the possible cpus to get the
nodeinfo. This fix will perform a check for present cpus
before parsing.
Signed-off-by: Kothapally Madhu Pavan
---
src/nodeinfo.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index
Currently we are parsing all the possible cpus to get the
nodeinfo. This fix will perform a check for present cpus
before parsing.
Signed-off-by: Kothapally Madhu Pavan
---
src/nodeinfo.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index
found".
Signed-off-by: Kothapally Madhu Pavan
---
src/conf/domain_conf.c |4
src/conf/domain_conf.h |3 +++
src/libxl/libxl_driver.c | 12 ++--
src/lxc/lxc_driver.c |7 ---
src/qemu/qemu_driver.c |2 ++
src/uml/uml_driver.c |6 --
As POWER9 model is not available in cpu_map.xml virsh capabilities
donot display the cpu model and vendor details. This patch
provides those details
---
src/cpu/cpu_map.xml |5 +
1 file changed, 5 insertions(+)
diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
index 7d5540a..29b5b59
priv and qemuCaps variables are not used anymore.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_driver.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 1c4873e..4721356 100644
--- a/src/qemu/qemu_driver.c
+++ b
ain-name state-file-xml
or you can simply use:
virsh managedsave-edit domain-name
It is always better when we get more.
Kothapally Madhu Pavan (7):
lib: Add API to dump xml configuration of managed save state domain
lib: Add API to edit domain's managed save state xml configuration
qe
Similar to domainSaveImageDefineXML this commit adds domainManagedSaveDefineXML
API which allows to edit domain's managed save state xml configuration.
Signed-off-by: Kothapally Madhu Pavan
---
include/libvirt/libvirt-domain.h | 4 +++
src/driver-hypervisor.h | 6 +
src/li
Add a simple virsh command handler which makes use of the new API.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c | 72
tools/virsh.pod | 21 +++
2 files changed, 93 insertions(+)
diff --git a/tools/virsh
Add a simple virsh command handler which makes use of the new API.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c | 56
tools/virsh.pod | 6 ++
2 files changed, 62 insertions(+)
diff --git a/tools/virsh-domain.c b
Similar to domainSaveImageGetXMLDesc this commit adds
domainManagedSaveGetXMLDesc
API which allows to get the xml of managed save state domain.
This allows to edit the managed save state domain xml.
Signed-off-by: Kothapally Madhu Pavan
---
include/libvirt/libvirt-domain.h | 2 ++
src/driver
This commit adds qemu driver implementation to edit xml
configuration of managed save state file of a domain.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_driver.c | 38 ++
1 file changed, 38 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src
This commit adds qemu driver implementaion to get xml description
for managed save state domain.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_driver.c | 40
1 file changed, 40 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu
Add a simple virsh command handler which makes use of the new API.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c | 79
tools/virsh.pod | 14 ++
2 files changed, 93 insertions(+)
diff --git a/tools/virsh-domain.c
Similar to domainSaveImageGetXMLDesc this commit adds
domainManagedSaveGetXMLDesc
API which allows to get the xml of managed save state domain.
Signed-off-by: Kothapally Madhu Pavan
---
include/libvirt/libvirt-domain.h | 2 ++
src/driver-hypervisor.h | 5
src/libvirt-domain.c
This commit adds qemu driver implementation to get xml description
for managed save state domain.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_driver.c | 46 ++
1 file changed, 46 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src
Add a simple virsh command handler which makes use of the new API.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c | 56
tools/virsh.pod | 6 ++
2 files changed, 62 insertions(+)
diff --git a/tools/virsh-domain.c b
Add a simple virsh command handler which makes use of the new API.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c | 79
tools/virsh.pod | 14 ++
2 files changed, 93 insertions(+)
diff --git a/tools/virsh-domain.c
Similar to domainSaveImageDefineXML this commit adds domainManagedSaveDefineXML
API which allows to edit domain's managed save state xml configuration.
Signed-off-by: Kothapally Madhu Pavan
---
include/libvirt/libvirt-domain.h | 4 +++
src/driver-hypervisor.h | 6 +
src/li
This commit adds qemu driver implementation to edit xml
configuration of managed save state file of a domain.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_driver.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/src/qemu/qemu_driver.c b
Add a simple virsh command handler which makes use of the new API.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c | 72
tools/virsh.pod | 21 +++
2 files changed, 93 insertions(+)
diff --git a/tools/virsh
er pointer in qemuDomainManagedSaveDefineXML.
- check whether the managed save state file exists and report a
error if it doesn't.
Kothapally Madhu Pavan (7):
lib: Add API to dump xml configuration of managed save state domain
lib: Add API to edit domain's managed save state xml configur
QEMU fails to launch a sPAPR guest with clock sources other that RTC.
Internally qemu only uses RTC timer for hwclock. This patch reports
the right error message instead of qemu erroring out when any other
timer other than RTC is used.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu
QEMU fails to launch a sPAPR guest with clock sources other that RTC.
Internally qemu only uses RTC timer for hwclock. This patch reports
the right error message instead of qemu erroring out when any other
timer other than RTC is used.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu
Unlike postcopy migration there is no --live flag check for
postcopy-after-precopy.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index de2a22c..798a1ff 100644
--- a/tools
--postcopy-after-precopy is just an aditional flag for
postcopy migration.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c |6 +++---
tools/virsh.pod |4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
Move qemuFreeKeywords into qemu_parse_command.c as
qemuKeywordsFree and call it rather than inline code
in multiple places.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_monitor_json.c | 15 ++---
src/qemu/qemu_parse_command.c | 52
$memory-device attached in Step2.
This patch is attempting to solve this issue.
Signed-off-by: Kothapally Madhu Pavan
---
src/conf/snapshot_conf.c | 1 +
src/conf/snapshot_conf.h | 1 +
src/qemu/qemu_driver.c | 23 +++
3 files changed, 25 insertions(+)
diff --git a/src/conf
Now, snapshot-dumpxml will display inactive XML configuration of snapshot
along with active XML configuration. When --active-only flag is used the
inactive XML configuration will not be displayed.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-snapshot.c | 7 +++
tools/virsh.pod
stent
configuration in domain after restoring the snapshot.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-snapshot.c | 7 +++
tools/virsh.pod| 8 +++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
index 4b0a18d..48
-by: Kothapally Madhu Pavan
---
src/conf/snapshot_conf.c | 13 +
src/conf/snapshot_conf.h | 1 +
src/qemu/qemu_driver.c | 10 ++
3 files changed, 24 insertions(+)
diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index f0e852c..bfe3d6c 100644
--- a/src/conf
This patch will allow user to edit the inactive XML snapshot
configuration when it is available in the snapshot.
Signed-off-by: Kothapally Madhu Pavan
---
include/libvirt/libvirt-domain.h | 1 +
src/conf/domain_conf.c | 6 --
src/conf/domain_conf.h | 2 ++
src/conf
snapshot.
Kothapally Madhu Pavan (7):
qemu: Store inactive domain configuration in snapshot
qemu: Use active and inactive snapshot configuration on restore
conf: Allow editing inactive snapshot configuration
virsh: Dump inactive XML configuration of snapshot using
snapshot-dumpxml
virsh
configuration of snapshot as both
active and inactive XML configurations of the restoring domain.
Signed-off-by: Kothapally Madhu Pavan
---
include/libvirt/libvirt-domain-snapshot.h | 10 +++---
src/qemu/qemu_driver.c| 20 +++-
2 files changed, 26 insertions(+), 4
of the snapshot is used as both the active and inactive
XML configuration of the domain after restore.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-snapshot.c | 6 ++
tools/virsh.pod| 9 -
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/tools/virsh
format.
Signed-off-by: Kothapally Madhu Pavan
---
docs/schemas/domainsnapshot.rng| 19 +
.../full_domain_withinactive.xml | 83 ++
tests/domainsnapshotxml2xmltest.c | 1 +
3 files changed, 103 insertions(+)
create
domain validation part to be consistent with the
original intent.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_process.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 184440d..f0d42b8 100644
--- a/src/qemu
hpet and kvm.pit clock timers are specific to x86 architecture and
are not to be used by unsuported architectures. Similarly sPAPR
guests only allow RTC timer. This patchset will restrict the usage
of unsupported clock timers.
Kothapally Madhu Pavan (2):
qemu: Restrict usage of hpet and kvm.pit
hpet and kvm.pit clock timers are specific to x86 architecture and
are not suppose to be used in other architectures. This patch restricts
the usage of hpet and kvm.pit timers in unsupported architectures.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_domain.c | 16
1
QEMU fails to launch a sPAPR guest with clock sources other that RTC.
Internally qemu only uses RTC timer for hwclock. This patch reports
the right error message instead of qemu erroring out when any other
timer other than RTC is used.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu
Similar to domainSaveImageDefineXML this commit adds domainManagedSaveDefineXML
API which allows to edit domain's managed save state xml configuration.
Signed-off-by: Kothapally Madhu Pavan
---
include/libvirt/libvirt-domain.h | 4 +++
src/driver-hypervisor.h | 6 +
src/li
Add a simple virsh command handler which makes use of the new API.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c | 72
tools/virsh.pod | 21 +++
2 files changed, 93 insertions(+)
diff --git a/tools/virsh
This commit adds qemu driver implementation to edit xml
configuration of managed save state file of a domain.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_driver.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/src/qemu/qemu_driver.c b
Changes since v1:
- qemu implementation called directly rather than going through
driver pointer in qemuDomainManagedSaveDefineXML.
- check whether the managed save state file exists and report a
error if it doesn't.
Kothapally Madhu Pavan (7):
lib: Add API to dump xml configuration of
Add a simple virsh command handler which makes use of the new API.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c | 56
tools/virsh.pod | 6 ++
2 files changed, 62 insertions(+)
diff --git a/tools/virsh-domain.c b
Similar to domainSaveImageGetXMLDesc this commit adds
domainManagedSaveGetXMLDesc
API which allows to get the xml of managed save state domain.
Signed-off-by: Kothapally Madhu Pavan
---
include/libvirt/libvirt-domain.h | 2 ++
src/driver-hypervisor.h | 5
src/libvirt-domain.c
This commit adds qemu driver implementation to get xml description
for managed save state domain.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_driver.c | 46 ++
1 file changed, 46 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src
Add a simple virsh command handler which makes use of the new API.
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c | 79
tools/virsh.pod | 14 ++
2 files changed, 93 insertions(+)
diff --git a/tools/virsh-domain.c
This patchset will fix docs/news.xml template structure which is broken by
commit b7e779c1a51793 and add support for managedsave-define, managedsave-edit
and managedsave-dumpxml commands.
Kothapally Madhu Pavan (3):
doc: Fix docs/news.xml template structure
doc: Document managedsave-define
Signed-off-by: Kothapally Madhu Pavan
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 119c478..fd64094 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -37,6 +37,15 @@
+ qemu: Add managedsave
Signed-off-by: Kothapally Madhu Pavan
---
docs/news.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/news.xml b/docs/news.xml
index 05152b8..088966d 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,8 +35,8
Signed-off-by: Kothapally Madhu Pavan
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 088966d..119c478 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -37,6 +37,16 @@
+ qemu: Add managedsave
This patch documents support for managedsave-dumpxml,
managedsave-define and managedsave-edit commands.
Signed-off-by: Kothapally Madhu Pavan
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 088966d..1f4eb3e 100644
--- a/docs
Signed-off-by: Kothapally Madhu Pavan
---
docs/news.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/news.xml b/docs/news.xml
index 05152b8..088966d 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,8 +35,8
This patchset will fix docs/news.xml template structure which is broken by
commit b7e779c1a51793 and add support for managedsave-define, managedsave-edit
and managedsave-dumpxml commands.
Kothapally Madhu Pavan (2):
docs: Fix docs/news.xml template structure
docs: Document managedsave-edit
Free DBusMessage pointer in virPolkitCheckAuth
Signed-off-by: Kothapally Madhu Pavan
---
src/util/virpolkit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c
index c735ca9..4559431 100644
--- a/src/util/virpolkit.c
+++ b/src/util/virpolkit.c
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_parse_command.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c
index 37e1149..7c409b0 100644
--- a/src/qemu/qemu_parse_command.c
+++ b/src/qemu
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_parse_command.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c
index 7c409b0..d5745ce 100644
--- a/src/qemu/qemu_parse_command.c
+++ b/src/qemu/qemu_parse_command.c
Existing qemuParseCommandLineMem() will parse "-m 4G" format string.
This patch allows it to parse "-m size=8126464k,slots=32,maxmem=33554432k"
format along with existing format.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_
Existing qemuParseCommandLineMem() will parse "-m 4G" format string.
This patch allows it to parse "-m size=8126464k,slots=32,maxmem=33554432k"
format along with existing format. And adds a testcase to validate the changes.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/
Existing qemuParseCommandLineMem() will parse "-m 4G" format string.
This patch allows it to parse "-m size=8126464k,slots=32,maxmem=33554432k"
format along with existing format. And adds a testcase to validate the changes.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/
Correcting the error reporting method by using vshError
instead of virReportError
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 050e7fb..c9fabf2 100644
Correcting the error reporting method by using VSH_REQUIRE_OPTION
instead of virReportError
Signed-off-by: Kothapally Madhu Pavan
---
tools/virsh-domain.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 050e7fb
Signed-off-by: Kothapally Madhu Pavan
---
src/conf/domain_event.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
index 63ae9e1..f1249ad 100644
--- a/src/conf/domain_event.c
+++ b/src/conf/domain_event.c
@@ -1839,7 +1839,7
found".
This patch allows to match DetachDeviec xml using PCI address
when mac address is not specified.
Signed-off-by: Kothapally Madhu Pavan
---
src/conf/domain_conf.c | 116 +-
src/conf/domain_conf.h |6 ++
src/libxl/libxl_driver.c |
75 matches
Mail list logo