Re: [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers

2015-07-22 Thread Srinivas Kandagatla
Thanks Stefan, On 21/07/15 17:25, Stefan Wahren wrote: + >+ addr = of_get_property(cell_np, "reg", &len); >+ if (!addr || (len < 2 * sizeof(int))) { I'm not sure, but shouldn't be sizeof(u32) more portable? yes it makes sense, I will change it. >[...] >+ >+ addr = of_get_property(cell_np, "b

Re: [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers

2015-07-21 Thread Stefan Wahren
Hi Srinivas, > Srinivas Kandagatla hat am 20. Juli 2015 um > 16:43 geschrieben: > > > This patch adds just consumers part of the framework just to enable easy > review. > > Up until now, nvmem drivers were stored in drivers/misc, where they all > had to duplicate pretty much the same code to regi

[PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers

2015-07-20 Thread Srinivas Kandagatla
This patch adds just consumers part of the framework just to enable easy review. Up until now, nvmem drivers were stored in drivers/misc, where they all had to duplicate pretty much the same code to register a sysfs file, allow in-kernel users to access the content of the devices they were driving