Hi,
we've accumulated some fixes during the last week, some of them were in
the works for a longer time but there are some newer ones too. Most of
the fixes have a reproducer and fix user visible problems, also
candidates for stable kernels. They IMHO qualify for a late rc, though I
did not expect
On Sun, May 20, 2018 at 8:21 AM David Sterba wrote:
> They IMHO qualify for a late rc, though I did not expect that many.
Especially with the tree-log.c changes being fairly big, I took a look, and
I have to say that I appreciate (a) the warning in the pull request and (b)
the extensive log mess
On 05/19/2018 07:02 PM, Qu Wenruo wrote:
On 2018年05月20日 07:40, Steve Leung wrote:
On 05/17/2018 11:49 PM, Qu Wenruo wrote:
On 2018年05月18日 13:23, Steve Leung wrote:
Hi list,
I've got 3-device raid1 btrfs filesystem that's throwing up some
"corrupt leaf" errors in dmesg. This is a uniquified
Jens - this series does the rest of the conversions that Christoph wanted, and
drops bioset_create().
Only lightly tested, but the changes are pretty mechanical. Based on your
for-next tree.
It's also in the for-jens branch at https://evilpiepirate.org/git/bcachefs.git
Kent Overstreet (12):
bl
Signed-off-by: Kent Overstreet
---
fs/block_dev.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 7ec920e270..b550ae280f 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -272,7 +272,7 @@ struct blkdev_dio {
struct bio
All users have been converted to bioset_init()
Signed-off-by: Kent Overstreet
---
block/bio.c | 61 ++---
include/linux/bio.h | 6 ++---
2 files changed, 15 insertions(+), 52 deletions(-)
diff --git a/block/bio.c b/block/bio.c
index 0a4df92cd6..5
Signed-off-by: Kent Overstreet
---
fs/btrfs/extent_io.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index e99b329002..56d32bb462 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -26,7 +2
Signed-off-by: Kent Overstreet
---
fs/xfs/xfs_aops.c | 2 +-
fs/xfs/xfs_aops.h | 2 +-
fs/xfs/xfs_super.c | 11 +--
3 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 0ab824f574..102463543d 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs
Signed-off-by: Kent Overstreet
---
drivers/target/target_core_iblock.c | 14 ++
drivers/target/target_core_iblock.h | 2 +-
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/target/target_core_iblock.c
b/drivers/target/target_core_iblock.c
index 44cacd001a..ce13
Signed-off-by: Kent Overstreet
---
drivers/md/md-faulty.c| 2 +-
drivers/md/md-linear.c| 2 +-
drivers/md/md-multipath.c | 17 -
drivers/md/md-multipath.h | 2 +-
drivers/md/md.c | 61 +--
drivers/md/md.h | 4 +--
drivers/md/raid
Signed-off-by: Kent Overstreet
---
drivers/md/dm-bio-prison-v1.c | 13 ---
drivers/md/dm-bio-prison-v2.c | 13 ---
drivers/md/dm-cache-target.c | 25 ++---
drivers/md/dm-core.h | 4 +-
drivers/md/dm-crypt.c | 60 ++---
Signed-off-by: Kent Overstreet
---
drivers/block/drbd/drbd_bitmap.c | 4 +-
drivers/block/drbd/drbd_int.h | 10 ++---
drivers/block/drbd/drbd_main.c | 71 +++---
drivers/block/drbd/drbd_receiver.c | 6 +--
drivers/block/drbd/drbd_req.c | 4 +-
drivers/bl
Signed-off-by: Kent Overstreet
---
drivers/block/pktcdvd.c | 50 -
include/linux/pktcdvd.h | 2 +-
2 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index d8aff7f325..69875f5580 100644
--- a/
Signed-off-by: Kent Overstreet
---
drivers/md/bcache/bcache.h | 10 +-
drivers/md/bcache/bset.c| 13 -
drivers/md/bcache/bset.h| 2 +-
drivers/md/bcache/btree.c | 4 ++--
drivers/md/bcache/io.c | 4 ++--
drivers/md/bcache/request.c | 18 +-
d
Signed-off-by: Kent Overstreet
---
drivers/lightnvm/pblk-core.c | 30 ++---
drivers/lightnvm/pblk-init.c | 72
drivers/lightnvm/pblk-read.c | 4 +-
drivers/lightnvm/pblk-recovery.c | 2 +-
drivers/lightnvm/pblk-write.c| 8 ++--
drivers/l
Signed-off-by: Kent Overstreet
---
block/blk-core.c | 7 ---
block/blk-merge.c | 8 +++
block/blk-sysfs.c | 3 +--
block/bounce.c | 47 ++
drivers/md/dm.c| 2 +-
include/linux/bio.h| 5 +
include/linux/bl
On Fri, May 18, 2018 at 08:53:30AM -0700, Christoph Hellwig wrote:
> On Fri, May 18, 2018 at 06:13:06AM -0700, Matthew Wilcox wrote:
> > > Historically, the only problematic case has been direct IO, and people
> > > have been willing to say "well, if you mix buffered and direct IO you
> > > get wha
On Sun, May 20 2018, Kent Overstreet wrote:
> Jens - this series does the rest of the conversions that Christoph wanted, and
> drops bioset_create().
>
> Only lightly tested, but the changes are pretty mechanical. Based on your
> for-next tree.
>
> It's also in the for-jens branch at https://evilp
Signed-off-by: Kent Overstreet
---
Resend, including Shaohua Li:
drivers/md/md-faulty.c| 2 +-
drivers/md/md-linear.c| 2 +-
drivers/md/md-multipath.c | 17 -
drivers/md/md-multipath.h | 2 +-
drivers/md/md.c | 61 +--
drivers/md/md.h
Thanks - sending it to him
On Sun, May 20, 2018 at 7:08 PM, NeilBrown wrote:
> On Sun, May 20 2018, Kent Overstreet wrote:
>
>> Jens - this series does the rest of the conversions that Christoph wanted,
>> and
>> drops bioset_create().
>>
>> Only lightly tested, but the changes are pretty mechan
Add unprivileged ioctl BTRFS_IOC_GET_SUBVOL_ROOTREF which
returns ROOT_REF information of the subvolume containing this inode
except the subvolume name (this is because to prevent potential name
leak). The subvolume name will be gained by user version of ino_lookup
ioctl (BTRFS_IOC_INO_LOOKUP_USER)
Add unprivileged version of ino_lookup ioctl BTRFS_IOC_INO_LOOKUP_USER
to allow normal users to call "btrfs subvolume list/show" etc. in
combination with BTRFS_IOC_GET_SUBVOL_INFO/BTRFS_IOC_GET_SUBVOL_ROOTREF.
This can be used like BTRFS_IOC_INO_LOOKUP but the argument is
different. This is becau
Add new unprivileged ioctl BTRFS_IOC_GET_SUBVOL_INFO which returns
the information of subvolume containing this inode.
(i.e. returns the information in ROOT_ITEM and ROOT_BACKREF.)
Reviewed-by: Gu Jinxiang
Tested-by: Gu Jinxiang
Signed-off-by: Tomohiro Misono
---
v5 -> v6
- Use brfs_read_f
changelog:
v6 -> v7
- Rebase to current misc-next again
- Fix 1st patch where otime is wrongly set instead of ctime
- Add reviewed-by/tested-by tag
v5 -> v6
- Update 1st patch by using btrfs_fs_root_no_name()
- Return -EUCLEAN when btrfs_next_leaf/next_item() should not fail
- Add Revie
On 2018年05月21日 04:43, Steve Leung wrote:
> On 05/19/2018 07:02 PM, Qu Wenruo wrote:
>>
>>
>> On 2018年05月20日 07:40, Steve Leung wrote:
>>> On 05/17/2018 11:49 PM, Qu Wenruo wrote:
On 2018年05月18日 13:23, Steve Leung wrote:
> Hi list,
>
> I've got 3-device raid1 btrfs filesystem that
On 2018/5/21 6:25 AM, Kent Overstreet wrote:
> Signed-off-by: Kent Overstreet
Hi Kent,
This change looks good to me,
Reviewed-by: Coly Li
Thanks.
Coly Li
> ---
> drivers/md/bcache/bcache.h | 10 +-
> drivers/md/bcache/bset.c| 13 -
> drivers/md/bcache/bset.h|
btrfs_read_fs_root_no_name() may return ERR_PTR(-ENOENT) or
ERR_PTR(-ENOMEM) and therefore search_ioctl() and
btrfs_search_path_in_tree() should use PTR_ERR() instead of -ENOENT,
which all other callers of btrfs_read_fs_root_no_name() does.
Signed-off-by: Tomohiro Misono
---
fs/btrfs/ioctl.c | 4
On 2018年05月21日 12:57, Misono Tomohiro wrote:
> btrfs_read_fs_root_no_name() may return ERR_PTR(-ENOENT) or
> ERR_PTR(-ENOMEM) and therefore search_ioctl() and
> btrfs_search_path_in_tree() should use PTR_ERR() instead of -ENOENT,
> which all other callers of btrfs_read_fs_root_no_name() does.
>
Although it's not that complex, but such comment could still save
several minutes for newer reader/reviewer.
Signed-off-by: Qu Wenruo
---
fs/btrfs/lzo.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/fs/btrfs/lzo.c b/fs/btrfs/lzo.c
index 0667ea07f766..d0c6789ff78f 1
This patchset can be fetched from github:
https://github.com/adam900710/linux/tree/lzo_corruption
Which is based on v4.17-rc5.
James Harvey reported pretty strange kernel misbehavior where after
reading certain btrfs compressed data, kernel crash with unrelated
calltrace.
(https://bugzilla.kernel.
Since compression.h is using SZ_* macros, and if some user only includes
compression.h without linux/sizes.h, it will cause compile error.
One example is lzo.c, if it uses BTRFS_MAX_COMPRESSED, it would cause
compile error.
Fix it by adding linux/sizes.h in compression.h
Signed-off-by: Qu Wenruo
James Harvey reported that some corrupted compressed extent data can
lead to various kernel memory corruption.
Such corrupted extent data belongs to inode with NODATASUM flags, thus
data csum won't help us detecting such bug.
If lucky enough, kasan could catch it like:
===
Unlike regular lzo compressed extent, inline extent doesn't have Header
and only has one Segment.
And further more, inlined extent always has csum in its leaf header,
it's less possible to have corrupted data.
Anyway, still add extra segment header length check.
Signed-off-by: Qu Wenruo
---
fs/
On 05/17/2018 07:59 PM, David Sterba wrote:
On Wed, May 16, 2018 at 10:51:27AM +0800, Anand Jain wrote:
Balance args info is an important information to be reviewed for the
system audit. So this patch adds it to the kernel log.
Example:
-> btrfs bal start -dprofiles='raid1|single',convert=ra
On 05/17/2018 08:06 PM, David Sterba wrote:
On Wed, May 16, 2018 at 10:51:28AM +0800, Anand Jain wrote:
Add a kernel log when the balance ends, either for cancel or completed
or if it is paused.
Missing S-O-B.
oops. Fixed in v3.
---
v1->v2: Moved from 2/3 to 3/3
fs/btrfs/volumes.c |
Improve on describe_relocation() add a common helper function to describe
the block groups.
Signed-off-by: Anand Jain
---
v3: Born.
fs/btrfs/relocation.c | 30 +++---
fs/btrfs/volumes.c| 44
fs/btrfs/volumes.h| 1 +
3
Balance arg info is an important information to be reviewed for the
system audit. So this patch adds them to the kernel log.
Example:
-> btrfs bal start -dprofiles='raid1|single',convert=raid5
-mprofiles='raid1|single',convert=raid5 /btrfs
kernel: BTRFS info (device sdb): balance: start
data|m
Add a kernel log when the balance ends, either for cancel or completed
or if it is paused.
Signed-off-by: Anand Jain
---
v2->v3: nothing.
v1->v2: Moved from 2/3 to 3/3
fs/btrfs/volumes.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index d2e
Based on misc-next.
v2->v3:
Inspried by describe_relocation(), improves it, makes it a helper
function and use it to log the balance operations.
Kernel logs are very important for the forensic investigations of the
issues, these patchs make balance logs easy to review.
Anand Jain (3):
btrf
39 matches
Mail list logo