[PATCH] crypto: inside-secure - Fix corruption on not fully coherent systems

2020-09-07 Thread Pascal van Leeuwen
aligned boundary. Also ensuring that the last cacheline of the last buffer is not shared (by overallocating). This was tested by the customer to solve their coherence problems. It was also tested by me on a VCU118 board w/ EIP-197c and Macchiatobin. Signed-off-by: Pascal van Leeuwen --- drivers

[PATCH] crypto: inside-secure - Prevent missing of processing errors

2020-09-08 Thread Pascal van Leeuwen
want to prevent it from being a possibility at all. So initialize all error bits to error state, so that reading stale status information will always result in errors. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel_ring.c | 9 + 1 file changed, 5 insertions

[PATCH] crypto: inside-secure - Add support for EIP197 with output classifier

2020-09-11 Thread Pascal van Leeuwen
(using what is formally a debug feature). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 44 ++--- drivers/crypto/inside-secure/safexcel.h | 13 ++ 2 files changed, 54 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/inside

[PATCH 2/4] crypto: inside-secure - Added AES-CFB support

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for AES in 128 bit cipher feedback mode (AES-CFB). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 2 ++ drivers/crypto/inside-secure/safexcel_cipher.c | 36

[PATCH 3/3] crypto: inside-secure - Added support for the AES-CMAC ahash

2019-09-04 Thread Pascal van Leeuwen
This patch adds support for the AES-CMAC authentication algorithm. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h | 1 + drivers/crypto/inside-secure/safexcel_hash.c | 99 3

[PATCH 1/3] crypto: inside-secure - Added support for the AES CBCMAC ahash

2019-09-04 Thread Pascal van Leeuwen
This patch adds support for the AES-CBCMAC authentication algorithm. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h | 1 + drivers/crypto/inside-secure/safexcel_hash.c | 235

[PATCH 0/3] crypto: inside-secure - Add support for the CBCMAC

2019-09-04 Thread Pascal van Leeuwen
This patchset adds support for the (AES) CBCMAC family of authentication algorithms: AES-CBCMAC, AES-XCBCMAC and AES-MAC It has been verified with a Xilinx PCIE FPGA board as well as the Marvell Armada A8K based Macchiatobin development board. Pascal van Leeuwen (3): crypto: inside-secure

[PATCH 2/3] crypto: inside-secure - Added support for the AES XCBC ahash

2019-09-04 Thread Pascal van Leeuwen
This patch adds support for the AES XCBC authentication algorithm Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h | 1 + drivers/crypto/inside-secure/safexcel_hash.c | 136 ++- 3

RE: [PATCH v2 -next] crypto: inside-secure - Fix build error without CONFIG_PCI

2019-09-04 Thread Pascal Van Leeuwen
afexcel_configure(priv); > > - if (IS_ENABLED(CONFIG_PCI) && priv->version == EIP197_DEVBRD) { > +#ifdef CONFIG_PCI > + if (priv->version == EIP197_DEVBRD) { > /* >* Request MSI vectors for global + 1 per ring - >

RE: [PATCH v2 -next] crypto: inside-secure - Fix build error without CONFIG_PCI

2019-09-04 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, September 4, 2019 2:11 PM > To: Pascal Van Leeuwen > Cc: YueHaibing ; antoine.ten...@bootlin.com; > herb...@gondor.apana.org.au; da...@davemloft.net; > pvanleeu...@insidesecure.com; linux- > cry...@vg

RE: [PATCH v2 -next] crypto: inside-secure - Fix build error without CONFIG_PCI

2019-09-04 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, September 4, 2019 2:27 PM > To: Pascal Van Leeuwen > Cc: YueHaibing ; antoine.ten...@bootlin.com; > herb...@gondor.apana.org.au; da...@davemloft.net; > pvanleeu...@insidesecure.com; linux- > cry...@vg

RE: [PATCH v2 -next] crypto: inside-secure - Fix build error without CONFIG_PCI

2019-09-04 Thread Pascal Van Leeuwen
So, with that patch you ONLY get a warning on that unused int rc, right? I do understand that one, that should have been inside an #ifdef as well. Everybody happy if I just fix that and leave the rest as is? Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix

[PATCH] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-05 Thread Pascal van Leeuwen
This patch fixes an unused variable warning from the compiler when the driver is being compiled without PCI support in the kernel. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/inside-secure

RE: [PATCH] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-05 Thread Pascal Van Leeuwen
> -Original Message- > From: Herbert Xu > Sent: Thursday, September 5, 2019 3:04 PM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > da...@davemloft.net; > Pascal Van Leeuwen > Subject: Re: [PATCH] crypto: inside-secu

RE: [PATCH] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-05 Thread Pascal Van Leeuwen
> -Original Message- > From: Herbert Xu > Sent: Thursday, September 5, 2019 3:59 PM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; linux-crypto@vger.kernel.org; > antoine.ten...@bootlin.com; da...@davemloft.net > Subject: Re: [PATCH] crypto: inside-secure

[PATCHv2] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-06 Thread Pascal van Leeuwen
x27;s just for development boards anyway, so in case both are done we want the platform error or no error at all if that passes - also fixes some indentation issue in the affected code Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 22 +++--- 1

RE: [PATCHv2] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-06 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf > Of Herbert Xu > Sent: Friday, September 6, 2019 2:19 PM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > da...@davemloft.net; > Pascal

RE: [PATCHv2] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-06 Thread Pascal Van Leeuwen
> -Original Message- > From: Herbert Xu > Sent: Friday, September 6, 2019 3:05 PM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; linux-crypto@vger.kernel.org; > antoine.ten...@bootlin.com; da...@davemloft.net; Bjorn Helgaas > > Subject: Re: [PATCHv2] cry

[PATCH 0/6] crypto: inside-secure - Add supp. for non-Marvell HW

2019-09-06 Thread Pascal van Leeuwen
the Xilinx VCU118 devboard. Pascal van Leeuwen (6): crypto: inside-secure - Add EIP97/EIP197 and endianness detection crypto: inside-secure: Corrected configuration of EIP96_TOKEN_CTRL crypto: inside-secure - Enable extended algorithms on newer HW crypto: inside-secure - Base CD fetchcount on

[PATCH 2/6] crypto: inside-secure: Corrected configuration of EIP96_TOKEN_CTRL

2019-09-06 Thread Pascal van Leeuwen
This patch corrects the configuration of the EIP197_PE_EIP96_TOKEN_CTRL register. Previous value was wrong and potentially dangerous. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 4 ++-- drivers/crypto/inside-secure/safexcel.h | 4 ++-- 2 files changed, 4

[PATCH 6/6] crypto: inside-secure - Probe transform record cache RAM sizes

2019-09-06 Thread Pascal van Leeuwen
/D variants. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 229 ++-- drivers/crypto/inside-secure/safexcel.h | 21 +-- 2 files changed, 200 insertions(+), 50 deletions(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers

[PATCH 4/6] crypto: inside-secure - Base CD fetchcount on actual CD FIFO size

2019-09-06 Thread Pascal van Leeuwen
: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 47 ++--- drivers/crypto/inside-secure/safexcel.h | 11 2 files changed, 48 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure

[PATCH 5/6] crypto: inside-secure - Base RD fetchcount on actual RD FIFO size

2019-09-06 Thread Pascal van Leeuwen
van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 37 +++-- drivers/crypto/inside-secure/safexcel.h | 15 - 2 files changed, 40 insertions(+), 12 deletions(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure

[PATCH 3/6] crypto: inside-secure - Enable extended algorithms on newer HW

2019-09-06 Thread Pascal van Leeuwen
This patch enables algorithms that did not fit the original 32 bit FUNCTION_EN register anymore via the FUNCTION2_EN extension reg. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 2 ++ drivers/crypto/inside-secure/safexcel.h | 1 + 2 files changed, 3 insertions

[PATCH 1/6] crypto: inside-secure - Add EIP97/EIP197 and endianness detection

2019-09-06 Thread Pascal van Leeuwen
also adds automatic host xs endianness detection & correction. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 154 ++-- drivers/crypto/inside-secure/safexcel.h | 26 +- 2 files changed, 130 insertions(+), 50 deletions(-) dif

RE: [PATCH 1/2] crypto: inside-secure - fix uninitialized-variable warning

2019-09-06 Thread Pascal Van Leeuwen
> -Original Message- > From: Arnd Bergmann > Sent: Friday, September 6, 2019 5:22 PM > To: Herbert Xu ; David S. Miller > ; > Antoine Tenart > Cc: Arnd Bergmann ; Pascal Van Leeuwen > ; Ard > Biesheuvel ; Kees Cook ; > linux- > cry...@vger.kernel.

[PATCHv3] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-06 Thread Pascal van Leeuwen
ing a -EINVAL error - only unregister PCI or OF if it was previously successfully registered Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 35 ++--- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/drivers/crypto/inside-s

RE: [PATCH 1/2] crypto: inside-secure - fix uninitialized-variable warning

2019-09-06 Thread Pascal Van Leeuwen
> -Original Message- > From: Arnd Bergmann > Sent: Friday, September 6, 2019 8:40 PM > To: Pascal Van Leeuwen > Cc: Herbert Xu ; David S. Miller > ; Antoine > Tenart ; Ard Biesheuvel > ; Kees Cook > ; linux-crypto@vger.kernel.org; > linux-ker...@vger.kern

RE: [PATCH 0/3] crypto: inside-secure - Add support for the CBCMAC

2019-09-09 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf > Of Herbert Xu > Sent: Monday, September 9, 2019 9:38 AM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > da...@davemloft.net; > Pascal

RE: [PATCH 0/3] crypto: inside-secure - Add support for the CBCMAC

2019-09-09 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf > Of Pascal Van Leeuwen > Sent: Monday, September 9, 2019 12:38 PM > To: Herbert Xu ; Pascal van Leeuwen > > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > da...@

[PATCH] crypto: inside-secure - Added support for CRC32

2019-09-09 Thread Pascal van Leeuwen
This patch adds support for the CRC32 "hash" algorithm Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h | 2 + drivers/crypto/inside-secure/safexcel_hash.c | 115 +-

[PATCH 0/3] crypto: inside-secure - Add support for the CBCMAC

2019-09-09 Thread Pascal van Leeuwen
This patchset adds support for the (AES) CBCMAC family of authentication algorithms: AES-CBCMAC, AES-XCBCMAC and AES-MAC It has been verified with a Xilinx PCIE FPGA board as well as the Marvell Armada A8K based Macchiatobin development board. Pascal van Leeuwen (3): crypto: inside-secure

[PATCH 2/3] crypto: inside-secure - Added support for the AES XCBC ahash

2019-09-09 Thread Pascal van Leeuwen
This patch adds support for the AES XCBC authentication algorithm Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h | 1 + drivers/crypto/inside-secure/safexcel_hash.c | 136 ++- 3

[PATCH 3/3] crypto: inside-secure - Added support for the AES-CMAC ahash

2019-09-09 Thread Pascal van Leeuwen
This patch adds support for the AES-CMAC authentication algorithm. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h | 1 + drivers/crypto/inside-secure/safexcel_hash.c | 99 3

[PATCH 1/3] crypto: inside-secure - Added support for the AES CBCMAC ahash

2019-09-09 Thread Pascal van Leeuwen
This patch adds support for the AES-CBCMAC authentication algorithm. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h | 1 + drivers/crypto/inside-secure/safexcel_hash.c | 235

RE: [PATCH 0/3] crypto: inside-secure - Add support for the CBCMAC

2019-09-09 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf > Of Herbert Xu > Sent: Monday, September 9, 2019 1:35 PM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; linux-crypto@vger.kernel.org; > antoine.ten...@bootlin.com; da...@davemloft.n

Interesting crypto manager behavior

2019-09-10 Thread Pascal Van Leeuwen
thout actually referencing hard cra_driver_name's ...) Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: Interesting crypto manager behavior

2019-09-10 Thread Pascal Van Leeuwen
> -Original Message- > From: Herbert Xu > Sent: Tuesday, September 10, 2019 2:59 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; Eric Biggers > Subject: Re: Interesting crypto manager behavior > > On Tue, Sep 10, 2019 at 12:50:04PM +,

RE: Interesting crypto manager behavior

2019-09-10 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf > Of Pascal Van Leeuwen > Sent: Tuesday, September 10, 2019 3:10 PM > To: Herbert Xu > Cc: linux-crypto@vger.kernel.org; Eric Biggers > Subject: RE: Interesting

[PATCH 0/2] crypto: inside-secure: Add support for the Chacha20 skcipher and the Chacha20-Poly1305 AEAD suites

2019-09-10 Thread Pascal van Leeuwen
applies on top of the earlier submitted "Add support for the CBCMAC" series. Pascal van Leeuwen (2): crypto: inside-secure - Added support for the CHACHA20 skcipher crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD drivers/crypto/inside-secure/safexcel.c| 3

[PATCH 2/2] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD

2019-09-10 Thread Pascal van Leeuwen
This patch adds support for the Chacha20-Poly1305 cipher suite. It adds both the basic rfc7539(chacha20,poly1305) as well as the rfc7539esp(chacha20,poly1305) variant for IPsec ESP acceleration. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 2

[PATCH 1/2] crypto: inside-secure - Added support for the CHACHA20 skcipher

2019-09-10 Thread Pascal van Leeuwen
Added support for the CHACHA20 skcipher algorithm. Tested on an eip197c-iesb configuration in the Xilinx VCU118 devboard, passes all testmgr vectors plus the extra fuzzing tests. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside

RE: [PATCH 1/2] crypto: inside-secure - Added support for the CHACHA20 skcipher

2019-09-10 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Tuesday, September 10, 2019 7:33 PM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > herb...@gondor.apana.org.au; > da...@davemloft.net; Pascal Van Leeuwen > Subject

[PATCH 2/3] crypto: inside-secure - Added support for HMAC-SM3 ahash

2019-09-11 Thread Pascal van Leeuwen
Added support for the hmac(sm3) ahash authentication algorithm Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h | 1 + drivers/crypto/inside-secure/safexcel_hash.c | 70 3 files

[PATCH 1/3] crypto: inside-secure - Added support for basic SM3 ahash

2019-09-11 Thread Pascal van Leeuwen
Added support for the SM3 ahash algorithm Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h | 2 + drivers/crypto/inside-secure/safexcel_hash.c | 59 3 files changed, 62

[PATCH 0/3] crypto: inside-secure - Add support for (HMAC) SM3

2019-09-11 Thread Pascal van Leeuwen
on top of the earlier submitted "Add support for the Chacha20 kcipher and the Chacha20-Poly..." series. Pascal van Leeuwen (3): crypto: inside-secure - Added support for basic SM3 ahash crypto: inside-secure - Added support for HMAC-SM3 ahash crypto: testmgr - Added testvectors fo

[PATCH 3/3] crypto: testmgr - Added testvectors for the hmac(sm3) ahash

2019-09-11 Thread Pascal van Leeuwen
Added testvectors for the hmac(sm3) ahash authentication algorithm Signed-off-by: Pascal van Leeuwen --- crypto/testmgr.c | 6 ++ crypto/testmgr.h | 56 2 files changed, 62 insertions(+) diff --git a/crypto/testmgr.c b/crypto

[PATCH 1/7] crypto: inside-secure - Add support for the ecb(sm4) skcipher

2019-09-11 Thread Pascal van Leeuwen
This patch adds support for SM4 in ECB mode, i.e. skcipher ecb(sm4). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 2 + drivers/crypto/inside-secure/safexcel_cipher.c | 90

[PATCH 0/7] crypto: inside-secure - Add support for SM4 ciphers

2019-09-11 Thread Pascal van Leeuwen
, including the crypto extra tests. Note that this patchset applies on top of the earlier submitted "Add support for (HMAC) SM3" series. Pascal van Leeuwen (7): crypto: inside-secure - Add support for the ecb(sm4) skcipher crypto: inside-secure - Add support for the cbc(sm4) skcipher cryp

[PATCH 7/7] crypto: testmgr - Added testvectors for the rfc3686(ctr(sm4)) skcipher

2019-09-11 Thread Pascal van Leeuwen
Added testvectors for the rfc3686(ctr(sm4)) skcipher algorithm Signed-off-by: Pascal van Leeuwen --- crypto/testmgr.c | 6 ++ crypto/testmgr.h | 29 + 2 files changed, 35 insertions(+) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index fbc19bc..90a9f08

[PATCH 6/7] crypto: inside-secure - Add support for the rfc3685(ctr(sm4)) skcipher

2019-09-11 Thread Pascal van Leeuwen
This patch adds support for SM4 in (32 bit) CTR mode, i.e. skcipher rfc3686(ctr(sm4)). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c | 51

[PATCH 3/7] crypto: inside-secure - Add support for the ofb(sm4) skcipher

2019-09-11 Thread Pascal van Leeuwen
This patch adds support for SM4 in OFB mode, i.e. skcipher ofb(sm4). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c | 36

[PATCH 2/7] crypto: inside-secure - Add support for the cbc(sm4) skcipher

2019-09-11 Thread Pascal van Leeuwen
This patch adds support for SM4 in CBC mode, i.e. skcipher cbc(sm4). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c | 36

[PATCH 5/7] crypto: inside-secure - Add support for the cfb(sm4) skcipher

2019-09-11 Thread Pascal van Leeuwen
This patch adds support for SM4 in CFB mode, i.e. skcipher cfb(sm4). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c | 36

[PATCH 4/7] crypto: testmgr - Added testvectors for the ofb(sm4) & cfb(sm4) skciphers

2019-09-11 Thread Pascal van Leeuwen
Added testvectors for the ofb(sm4) and cfb(sm4) skcipher algorithms Signed-off-by: Pascal van Leeuwen --- crypto/testmgr.c | 12 +++ crypto/testmgr.h | 98 2 files changed, 110 insertions(+) diff --git a/crypto/testmgr.c b/crypto

RE: [PATCH 1/2] crypto: inside-secure - Added support for the CHACHA20 skcipher

2019-09-11 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Wednesday, September 11, 2019 5:21 PM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re:

RE: [PATCH 2/2] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD

2019-09-11 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Wednesday, September 11, 2019 5:30 PM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > herb...@gondor.apana.org.au; da...@davemloft.net; Pascal Van Leeuwen > > Subject

RE: [PATCH 1/3] crypto: inside-secure - Added support for basic SM3 ahash

2019-09-11 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Wednesday, September 11, 2019 5:41 PM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > herb...@gondor.apana.org.au; da...@davemloft.net; Pascal Van Leeuwen > > Subject

RE: [PATCH 2/2] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD

2019-09-11 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Wednesday, September 11, 2019 5:45 PM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re:

RE: [PATCH 4/7] crypto: testmgr - Added testvectors for the ofb(sm4) & cfb(sm4) skciphers

2019-09-11 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Wednesday, September 11, 2019 6:06 PM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > herb...@gondor.apana.org.au; > da...@davemloft.net; Pascal Van Leeuwen > Subject

[PATCHv2 0/2] rypto: inside-secure: Add support for the Chacha20 skcipher and the Chacha20-Poly1305 AEAD suites

2019-09-12 Thread Pascal van Leeuwen
applies on top of the earlier submitted "Add support for the CBCMAC" series. changes since v1: - incorporated feedback by Antoine Tenart, see individual patches for details Pascal van Leeuwen (2): crypto: inside-secure - Added support for the CHACHA20 skcipher crypto: inside-secure - A

[PATCHv2 2/2] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD

2019-09-12 Thread Pascal van Leeuwen
missing \ in an (intended) newline marker in an error message - moved selector out to standalone if for readability - added explicit memzero for AEAD fallback chacha key Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 2 + drivers/crypto/inside-secure

[PATCHv2 1/2] crypto: inside-secure - Added support for the CHACHA20 skcipher

2019-09-12 Thread Pascal van Leeuwen
Added support for the CHACHA20 skcipher algorithm. Tested on an eip197c-iesb configuration in the Xilinx VCU118 devboard, passes all testmgr vectors plus the extra fuzzing tests. changes since v1: - changed switch statement entry from default to explicit+empty default Signed-off-by: Pascal van

[PATCHv2 1/3] crypto: inside-secure - Added support for basic SM3 ahash

2019-09-12 Thread Pascal van Leeuwen
Added support for the SM3 ahash algorithm changes since v1: - moved definition of CONTEXT_CONTROL_CRYPTO_ALG_SM3 (0x7) up above 0xf Acked-by: Antoine Tenart Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h

[PATCHv2 3/3] crypto: testmgr - Added testvectors for the hmac(sm3) ahash

2019-09-12 Thread Pascal van Leeuwen
Added testvectors for the hmac(sm3) ahash authentication algorithm changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- crypto/testmgr.c | 6 ++ crypto/testmgr.h | 56 2 files changed, 62 insertions(+) diff --git a

[PATCHv2 2/3] crypto: inside-secure - Added support for HMAC-SM3 ahash

2019-09-12 Thread Pascal van Leeuwen
Added support for the hmac(sm3) ahash authentication algorithm changes since v1: - added Acked-by tag below, no changes to the source Acked-by: Antoine Tenart Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto/inside-secure/safexcel.h

[PATCHv2 0/3] crypto: inside-secure - Add support for (HMAC) SM3

2019-09-12 Thread Pascal van Leeuwen
on top of the earlier submitted "Add support for the Chacha20 kcipher and the Chacha20-Poly..." series. changes since v1: - incorporated feedback by Antoine Tenart, see individual patches for details Pascal van Leeuwen (3): crypto: inside-secure - Added support for basic SM3 ahas

testmgr: HMAC-SHA3-224/256 test vector issue

2019-09-13 Thread Pascal Van Leeuwen
while the largest key used (supposedly "Larger Than Block-Size" according to the plaintext) is actually 131 bytes. Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: [PATCHv3] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-13 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf > Of Herbert Xu > Sent: Friday, September 13, 2019 11:21 AM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > da...@davemloft.net; > Pascal

[PATCHv4] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n

2019-09-13 Thread Pascal van Leeuwen
fails Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 40 - 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index e12a2a3..5abe8b6 1

[PATCHv2 4/7] crypto: testmgr - Added testvectors for the ofb(sm4) & cfb(sm4) skciphers

2019-09-13 Thread Pascal van Leeuwen
Added testvectors for the ofb(sm4) and cfb(sm4) skcipher algorithms changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- crypto/testmgr.c | 12 +++ crypto/testmgr.h | 98 2 files changed, 110 insertions(+) diff --git a

[PATCHv2 1/7] crypto: inside-secure - Add support for the ecb(sm4) skcipher

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for SM4 in ECB mode, i.e. skcipher ecb(sm4). changes since v1: - make SAFEXCEL_SM4 case entry explit, using the proper SM4_BLOCK_SIZE instead of "borrowing" the AES code which "coincidentally" works Signed-off-by: Pascal van Leeuwen --- drivers/

[PATCHv2 2/7] crypto: inside-secure - Add support for the cbc(sm4) skcipher

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for SM4 in CBC mode, i.e. skcipher cbc(sm4). changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c

[PATCHv2 3/7] crypto: inside-secure - Add support for the ofb(sm4) skcipher

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for SM4 in OFB mode, i.e. skcipher ofb(sm4). changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c

[PATCHv2 6/7] crypto: inside-secure - Add support for the rfc3685(ctr(sm4)) skcipher

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for SM4 in (32 bit) CTR mode, i.e. skcipher rfc3686(ctr(sm4)). changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure

[PATCHv2 0/7] crypto: inside-secure - Add support for SM4 ciphers

2019-09-13 Thread Pascal van Leeuwen
, including the crypto extra tests. Note that this patchset applies on top of the earlier submitted "Add support for (HMAC) SM3" series. changes since v1: - rebased on top of v2 of "Added support for the CHACHA20 skcipher", fixing an issue that caused SM4 to no longer function P

[PATCHv2 5/7] crypto: inside-secure - Add support for the cfb(sm4) skcipher

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for SM4 in CFB mode, i.e. skcipher cfb(sm4). changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c

[PATCHv2 7/7] crypto: testmgr - Added testvectors for the rfc3686(ctr(sm4)) skcipher

2019-09-13 Thread Pascal van Leeuwen
Added testvectors for the rfc3686(ctr(sm4)) skcipher algorithm changes since v1: - nothing Signed-off-by: Pascal van Leeuwen --- crypto/testmgr.c | 6 ++ crypto/testmgr.h | 29 + 2 files changed, 35 insertions(+) diff --git a/crypto/testmgr.c b/crypto

[PATCH 1/2] crypto: inside-secure - Add SHA3 family of basic hash algorithms

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for sha3-224, sha3-256, sha3-384 and sha3-512 basic hashes. The patch has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development board, including the testmgr extra tests. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure

[PATCH 0/2] crypto: inside-secure - Add (HMAC) SHA3 support

2019-09-13 Thread Pascal van Leeuwen
This patchset adds support for all flavours of sha3-xxx and hmac(sha3-xxx) ahash algorithms. The patchset has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development board, including the testmgr extra tests. Pascal van Leeuwen (2): crypto: inside-secure - Add SHA3

[PATCH 2/2] crypto: inside-secure - Add HMAC-SHA3 family of authentication algorithms

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for hmac(sha3-224), hmac(sha3-256), hmac(sha3-384) and hmac(sha3-512) authentication algorithms. The patch has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development board, including the testmgr extra tests. Signed-off-by: Pascal van Leeuwen

[PATCH 2/3] crypto: inside-secure - Added support for authenc HMAC-SHA2/3DES-CBC

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the authenc(hmac(sha224),cbc(des3_ede)), authenc(hmac(sha256),cbc(des3_ede)), authenc(hmac(sha384),cbc(des3_ede)) and authenc(hmac(sha512),cbc(des3_ede)) aead's Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 4 + dr

[PATCH 3/3] crypto: inside-secure - Added support for authenc HMAC-SHA2/DES-CBC

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the authenc(hmac(sha224),cbc(des)), authenc(hmac(sha256),cbc(des)), authenc(hmac(sha384),cbc(des)) and authenc(hmac(sha512),cbc(des)) aead's Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 4 + drivers/crypto/inside-s

[PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the authenc(hmac(sha1),cbc(des)) aead Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 1 + drivers/crypto/inside-secure/safexcel_cipher.c | 45 ++ 3

[PATCH 0/3] crypto: inside-secure - Added more authenc w/ (3)DES

2019-09-13 Thread Pascal van Leeuwen
This patchset adds the remaining authencs with DES or 3DES currently supported with vectors by testmgr. The patchset has been tested with the eip197c_iewxkbc configuration on the Xilinx VCU118 development boardi as well as on the Macchiatobin board, including the testmgr extra tests. Pascal van

RE: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC

2019-09-13 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, September 13, 2019 5:27 PM > To: Pascal van Leeuwen > Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE > ; > Antoine Tenart ; Herbert Xu > ; > David S. Miller ; Pascal Van Leeuwen > >

[PATCHv3 0/3] crypto: inside-secure - Add support for (HMAC) SM3

2019-09-13 Thread Pascal van Leeuwen
on top of the earlier submitted "Add support for the Chacha20 kcipher and the Chacha20-Poly..." series. changes since v1: - incorporated feedback by Antoine Tenart, see individual patches for details changes since v2: - allow compilation if CONFIG_CRYPTO_SM3 is not set Pascal van

[PATCHv3 2/3] crypto: inside-secure - Added support for HMAC-SM3 ahash

2019-09-13 Thread Pascal van Leeuwen
Added support for the hmac(sm3) ahash authentication algorithm changes since v1: - added Acked-by tag below, no changes to the source changes since v2: - nothing Acked-by: Antoine Tenart Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 1 + drivers/crypto

[PATCHv3 3/3] crypto: testmgr - Added testvectors for the hmac(sm3) ahash

2019-09-13 Thread Pascal van Leeuwen
Added testvectors for the hmac(sm3) ahash authentication algorithm changes since v1 & v2: -nothing Signed-off-by: Pascal van Leeuwen --- crypto/testmgr.c | 6 ++ crypto/testmgr.h | 56 2 files changed, 62 insertions(+) diff --g

[PATCHv3 1/3] crypto: inside-secure - Added support for basic SM3 ahash

2019-09-13 Thread Pascal van Leeuwen
Added support for the SM3 ahash algorithm changes since v1: - moved definition of CONTEXT_CONTROL_CRYPTO_ALG_SM3 (0x7) up above 0xf changes since v2: - allow compilation if CONFIG_CRYPTO_SM3 is not set Acked-by: Antoine Tenart Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside

RE: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC

2019-09-13 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, September 13, 2019 6:24 PM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; open list:HARDWARE RANDOM > NUMBER > GENERATOR CORE ; Antoine Tenart > ; Herbert Xu ; David > S. Miller > >

[PATCHv2 1/3] crypto: inside-secure - Added support for the CHACHA20 skcipher

2019-09-13 Thread Pascal van Leeuwen
Added support for the CHACHA20 skcipher algorithm. Tested on an eip197c-iesb configuration in the Xilinx VCU118 devboard, passes all testmgr vectors plus the extra fuzzing tests. changes since v1: - rebased on top of DES changes done to cryptodev/master Signed-off-by: Pascal van Leeuwen

[PATCHv2 0/3] crypto: inside-secure: Add support for the Chacha20 skcipher and the Chacha20-Poly1305 AEAD suites

2019-09-13 Thread Pascal van Leeuwen
applies on top of the earlier submitted "Add support for the CBCMAC" series. changes since v1: - rebased on top of DES library changes done on cryptodev/master - fixed crypto/Kconfig so that generic fallback is compiled as well Pascal van Leeuwen (3): crypto: inside-secure - Added suppo

[PATCHv2 3/3] crypto: Kconfig - Add CRYPTO_CHACHA20POLY1305 to CRYPTO_DEV_SAFEXCEL

2019-09-13 Thread Pascal van Leeuwen
Due to the addition of Chacha20-Poly1305 support to the inside-secure driver, it now depends on CRYPTO_CHACHA20POLY1305. Added reference. changes since v1: - added missing dependency to crypto/Kconfig Signed-off-by: Pascal van Leeuwen --- drivers/crypto/Kconfig | 3 ++- 1 file changed, 2

[PATCHv2 2/3] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD

2019-09-13 Thread Pascal van Leeuwen
This patch adds support for the Chacha20-Poly1305 cipher suite. It adds both the basic rfc7539(chacha20,poly1305) as well as the rfc7539esp(chacha20,poly1305) variant for IPsec ESP acceleration. changes since v1: - rebased on top of DES changes done to cryptodev/master Signed-off-by: Pascal van

[PATCHv3 3/3] crypto: Kconfig - Add CRYPTO_CHACHA20POLY1305 to CRYPTO_DEV_SAFEXCEL

2019-09-13 Thread Pascal van Leeuwen
Due to the addition of Chacha20-Poly1305 support to the inside-secure driver, it now depends on CRYPTO_CHACHA20POLY1305. Added reference. changes since v1: - added missing dependency to crypto/Kconfig changes since v2: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/Kconfig | 3

[PATCHv3 1/3] crypto: inside-secure - Added support for the CHACHA20 skcipher

2019-09-13 Thread Pascal van Leeuwen
generic fallback is compiled as well changes since v2: - made switch entry SAFEXCEL_AES explit and added empty default, as requested by Antoine Tenart. Also needed to make SM4 patches apply. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers

[PATCHv3 0/3] crypto: inside-secure: Add support for the Chacha20 skcipher and the Chacha20-Poly1305 AEAD suites

2019-09-13 Thread Pascal van Leeuwen
dded empty default, as requested by Antoine Tenart. Also needed to make SM4 patches apply. Pascal van Leeuwen (3): crypto: inside-secure - Added support for the CHACHA20 skcipher crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD crypto: Kconfig - Add CRYPTO_CHACHA20P

[PATCHv3 2/3] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD

2019-09-13 Thread Pascal van Leeuwen
/Kconfig so that generic fallback is compiled as well changes since v2: - nothing Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 2 + drivers/crypto/inside-secure/safexcel.h| 8 + drivers/crypto/inside-secure/safexcel_cipher.c | 276

[PATCH] crypto: inside-secure - Add SM4 based authenc AEAD ciphersuites

2019-09-13 Thread Pascal van Leeuwen
abovementioned modified testmgr This patch applies on top of "Add support for SM4 ciphers" and needs to be applied before "Add (HMAC) SHA3 support". Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 4 + drivers/crypto/inside-secure/saf

  1   2   3   4   >