[PATCH linux dev-4.10 2/6] ARM: dts: aspeed: peci: Add Aspeed PECI

2018-01-09 Thread Jae Hyun Yoo
This commit adds Aspeed PECI node into aspeed-g4 and aspeed-g5. Signed-off-by: Jae Hyun Yoo --- arch/arm/boot/dts/aspeed-g4.dtsi | 14 ++ arch/arm/boot/dts/aspeed-g5.dtsi | 14 ++ 2 files changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm

[PATCH linux dev-4.10 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

2018-01-09 Thread Jae Hyun Yoo
This commit adds driver implementation for a generic PECI hwmon. Signed-off-by: Jae Hyun Yoo --- drivers/hwmon/Kconfig | 6 + drivers/hwmon/Makefile | 1 + drivers/hwmon/peci-hwmon.c | 953 + 3 files changed, 960 insertions(+) create

[PATCH linux dev-4.10 4/6] Documentation: dt-bindings: Add a generic PECI hwmon

2018-01-09 Thread Jae Hyun Yoo
This commit add a dt-bindings document for a generic PECI hwmon driver. Signed-off-by: Jae Hyun Yoo --- .../devicetree/bindings/hwmon/peci-hwmon.txt | 33 ++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/peci-hwmon.txt

[PATCH linux dev-4.10 1/6] Documentation: dt-bindings: Add Aspeed PECI

2018-01-09 Thread Jae Hyun Yoo
This commit adds a dt-bindings document for Aspeed PECI. Signed-off-by: Jae Hyun Yoo --- .../devicetree/bindings/misc/aspeed-peci.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/aspeed-peci.txt diff --git a

[PATCH linux dev-4.10 5/6] Documentation: hwmon: Add a generic PECI hwmon

2018-01-09 Thread Jae Hyun Yoo
From: Jae Hyun Yoo This commit add a document for a generic PECI hwmon driver. Signed-off-by: Jae Hyun Yoo --- Documentation/hwmon/peci-hwmon | 74 ++ 1 file changed, 74 insertions(+) create mode 100644 Documentation/hwmon/peci-hwmon diff --git a

[PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-09 Thread Jae Hyun Yoo
From: Jae Hyun Yoo Hello, This patch set provides support for PECI of AST2400/2500 which can give us PECI functionalities such as temperature monitoring, platform manageability, processor diagnostics and failure analysis. Also provides generic peci.h and peci_ioctl.h headers to provide

[PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-09 Thread Jae Hyun Yoo
This commit adds driver implementation for Aspeed PECI. Also adds generic peci.h and peci_ioctl.h files to provide compatibility to peci drivers that can be implemented later e.g. Nuvoton's BMC SoC family. Signed-off-by: Jae Hyun Yoo --- drivers/misc/Kconfig|9 + drivers

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Jae Hyun Yoo
On 1/10/2018 2:17 AM, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae Hyun Yoo wrote: From: Jae Hyun Yoo Hello, This patch set provides support for PECI of AST2400/2500 which can give us PECI functionalities such as temperature monitoring, platform manageability, processor

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Jae Hyun Yoo
On 1/10/2018 11:17 AM, Greg KH wrote: On Wed, Jan 10, 2018 at 11:14:34AM -0800, Jae Hyun Yoo wrote: On 1/10/2018 2:17 AM, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae Hyun Yoo wrote: From: Jae Hyun Yoo Hello, This patch set provides support for PECI of AST2400/2500 which

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-10 Thread Jae Hyun Yoo
On 1/10/2018 2:18 AM, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for Aspeed PECI. Also adds generic peci.h and peci_ioctl.h files to provide compatibility to peci drivers that can be implemented later e.g. Nuvoton'

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-10 Thread Jae Hyun Yoo
On 1/10/2018 2:20 AM, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: +#pragma pack(push, 1) +struct peci_xfer_msg { + unsigned char client_addr; + unsigned char tx_len; + unsigned char rx_len; + unsigned char tx_buf[MAX_BUFFER_SIZE

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Jae Hyun Yoo
On 1/10/2018 12:27 PM, Greg KH wrote: On Wed, Jan 10, 2018 at 11:30:05AM -0800, Jae Hyun Yoo wrote: On 1/10/2018 11:17 AM, Greg KH wrote: On Wed, Jan 10, 2018 at 11:14:34AM -0800, Jae Hyun Yoo wrote: On 1/10/2018 2:17 AM, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae Hyun Yoo

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-10 Thread Jae Hyun Yoo
On 1/10/2018 3:55 AM, Arnd Bergmann wrote: On Tue, Jan 9, 2018 at 11:31 PM, Jae Hyun Yoo wrote: This commit adds driver implementation for Aspeed PECI. Also adds generic peci.h and peci_ioctl.h files to provide compatibility to peci drivers that can be implemented later e.g. Nuvoton's BM

Re: [PATCH linux dev-4.10 4/6] Documentation: dt-bindings: Add a generic PECI hwmon

2018-01-10 Thread Jae Hyun Yoo
On 1/10/2018 4:20 AM, Arnd Bergmann wrote: On Tue, Jan 9, 2018 at 11:31 PM, Jae Hyun Yoo wrote: This commit add a dt-bindings document for a generic PECI hwmon driver. Signed-off-by: Jae Hyun Yoo --- .../devicetree/bindings/hwmon/peci-hwmon.txt | 33 ++ 1 file

Re: [PATCH linux dev-4.10 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

2018-01-10 Thread Jae Hyun Yoo
On 1/10/2018 4:29 AM, Arnd Bergmann wrote: On Tue, Jan 9, 2018 at 11:31 PM, Jae Hyun Yoo wrote: This commit adds driver implementation for a generic PECI hwmon. Signed-off-by: Jae Hyun Yoo +static int xfer_peci_msg(int cmd, void *pmsg) +{ + int rc; + + mutex_lock

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

2018-01-11 Thread Jae Hyun Yoo
On 1/10/2018 1:47 PM, Guenter Roeck wrote: On Tue, Jan 09, 2018 at 02:31:26PM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for a generic PECI hwmon. Signed-off-by: Jae Hyun Yoo --- drivers/hwmon/Kconfig | 6 + drivers/hwmon/Makefile | 1 + drivers/hwmon

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-11 Thread Jae Hyun Yoo
On 1/11/2018 12:56 AM, Benjamin Herrenschmidt wrote: On Thu, 2018-01-11 at 08:30 +0100, Greg KH wrote: 4.13? Why that kernel? It too is obsolete and insecure and unsupported. Haha, it's n-1. come on :-) What keeps you all from just always tracking the latest tree from Linus? What is in yo

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-11 Thread Jae Hyun Yoo
On 1/11/2018 1:02 AM, Benjamin Herrenschmidt wrote: On Wed, 2018-01-10 at 11:18 +0100, Greg KH wrote: On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for Aspeed PECI. Also adds generic peci.h and peci_ioctl.h files to provide compatibility

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-11 Thread Jae Hyun Yoo
On 1/11/2018 1:06 AM, Benjamin Herrenschmidt wrote: On Tue, 2018-01-09 at 14:31 -0800, Jae Hyun Yoo wrote: +struct peci_rd_ia_msr_msg { + unsigned char target; + unsigned char thread_id; + unsigned short address; + unsigned long value; +}; Those types are representing

Re: [PATCH linux dev-4.10 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

2018-01-11 Thread Jae Hyun Yoo
On 1/11/2018 5:22 AM, Arnd Bergmann wrote: On Thu, Jan 11, 2018 at 12:45 AM, Jae Hyun Yoo wrote: On 1/10/2018 4:29 AM, Arnd Bergmann wrote: On Tue, Jan 9, 2018 at 11:31 PM, Jae Hyun Yoo wrote: This commit adds driver implementation for a generic PECI hwmon. Signed-off-by: Jae Hyun Yoo

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

2018-01-11 Thread Jae Hyun Yoo
On 1/11/2018 1:40 PM, Guenter Roeck wrote: On Thu, Jan 11, 2018 at 11:47:01AM -0800, Jae Hyun Yoo wrote: On 1/10/2018 1:47 PM, Guenter Roeck wrote: On Tue, Jan 09, 2018 at 02:31:26PM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for a generic PECI hwmon. Signed-off-by

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

2018-01-11 Thread Jae Hyun Yoo
On 1/11/2018 2:18 PM, Andrew Lunn wrote: +static const struct of_device_id peci_of_table[] = { + { .compatible = "peci-hwmon", }, This does not look like a reference to some piece of hardware. This driver provides generic PECI hwmon function to which controller has PECI HW such as Aspe

Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon

2018-01-11 Thread Jae Hyun Yoo
On 1/11/2018 3:53 PM, Andrew Lunn wrote: On Thu, Jan 11, 2018 at 03:14:37PM -0800, Jae Hyun Yoo wrote: On 1/11/2018 2:18 PM, Andrew Lunn wrote: +static const struct of_device_id peci_of_table[] = { + { .compatible = "peci-hwmon", }, This does not look like a reference to som

[PATCH v2 4/8] [PATCH 4/8] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2018-02-21 Thread Jae Hyun Yoo
This commit adds PECI adapter driver implementation for Aspeed AST24xx/AST25xx. Signed-off-by: Jae Hyun Yoo --- drivers/peci/Kconfig | 19 ++ drivers/peci/Makefile | 3 + drivers/peci/peci-aspeed.c | 510 + 3 files changed, 532

[PATCH v2 5/8] [PATCH [5/8] Documentation: dt-bindings: Add a document for PECI hwmon client driver

2018-02-21 Thread Jae Hyun Yoo
This commit adds a dt-bindings document for a generic PECI hwmon client driver. Signed-off-by: Jae Hyun Yoo --- .../devicetree/bindings/hwmon/peci-hwmon.txt | 27 ++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/peci

[PATCH v2 0/8] PECI device driver introduction

2018-02-21 Thread Jae Hyun Yoo
a function into hwmon driver to simplify update delay checking. - Added a function into hwmon driver to convert 10.6 to millidegree. - Dropped non-standard attributes in hwmon driver. - Fixed OF table for hwmon to make it indicate as a PECI client of Intel CPU target. - Added a maintainer of

[PATCH v2 8/8] [PATCH 8/8] Add a maintainer for the PECI subsystem

2018-02-21 Thread Jae Hyun Yoo
This commit adds a maintainer information for the PECI subsystem. Signed-off-by: Jae Hyun Yoo --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 93a12af4f180..f9c302cbb76b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10830,6 +10830,15

[PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

2018-02-21 Thread Jae Hyun Yoo
This commit adds a generic PECI hwmon client driver implementation. Signed-off-by: Jae Hyun Yoo --- drivers/hwmon/Kconfig | 10 + drivers/hwmon/Makefile | 1 + drivers/hwmon/peci-hwmon.c | 928 + 3 files changed, 939 insertions(+) create

[PATCH v2 6/8] [PATCH 6/8] Documentation: hwmon: Add a document for PECI hwmon client driver

2018-02-21 Thread Jae Hyun Yoo
This commit adds a hwmon document for a generic PECI hwmon client driver. Signed-off-by: Jae Hyun Yoo --- Documentation/hwmon/peci-hwmon | 73 ++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/hwmon/peci-hwmon diff --git a

[PATCH v2 3/8] [PATCH 3/8] ARM: dts: aspeed: peci: Add PECI node

2018-02-21 Thread Jae Hyun Yoo
This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. Signed-off-by: Jae Hyun Yoo --- arch/arm/boot/dts/aspeed-g4.dtsi | 25 + arch/arm/boot/dts/aspeed-g5.dtsi | 25 + 2 files changed, 50 insertions(+) diff --git

[PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-02-21 Thread Jae Hyun Yoo
This commit adds a dt-bindings document of PECI adapter driver for Aspeed AST24xx/25xx SoCs. Signed-off-by: Jae Hyun Yoo --- .../devicetree/bindings/peci/peci-aspeed.txt | 73 ++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-21 Thread Jae Hyun Yoo
This commit adds driver implementation for PECI bus into linux driver framework. Signed-off-by: Jae Hyun Yoo --- drivers/Kconfig |2 + drivers/Makefile|1 + drivers/peci/Kconfig| 20 + drivers/peci/Makefile |6 + drivers/peci

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-21 Thread Jae Hyun Yoo
Hi Andrew, Thanks for sharing your time to review it. Please check my answers inline. On 2/21/2018 9:04 AM, Andrew Lunn wrote: +static int peci_locked_xfer(struct peci_adapter *adapter, + struct peci_xfer_msg *msg, + bool do_retry, +

Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-02-21 Thread Jae Hyun Yoo
On 2/21/2018 9:13 AM, Andrew Lunn wrote: On Wed, Feb 21, 2018 at 08:16:00AM -0800, Jae Hyun Yoo wrote: This commit adds a dt-bindings document of PECI adapter driver for Aspeed AST24xx/25xx SoCs. Hi Jae It would be good to separate this into two. One binding document for a generic adaptor

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-21 Thread Jae Hyun Yoo
On 2/21/2018 9:58 AM, Greg KH wrote: On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus into linux driver framework. Signed-off-by: Jae Hyun Yoo --- Why is there no other Intel developers willing to review and sign off on this

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

2018-02-21 Thread Jae Hyun Yoo
Hi Guenter, Thanks for sharing your time to review this code. Please check my answers inline. On 2/21/2018 10:26 AM, Guenter Roeck wrote: On Wed, Feb 21, 2018 at 08:16:05AM -0800, Jae Hyun Yoo wrote: This commit adds a generic PECI hwmon client driver implementation. Signed-off-by: Jae

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-21 Thread Jae Hyun Yoo
On 2/21/2018 1:51 PM, Andrew Lunn wrote: Is there a real need to do transfers in atomic context, or with interrupts disabled? Actually, no. Generally, this function will be called in sleep-able context so this code is for an exceptional case handling. I'll rewrite this code like below:

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

2018-02-21 Thread Jae Hyun Yoo
On 2/21/2018 1:48 PM, Guenter Roeck wrote: On Wed, Feb 21, 2018 at 01:24:48PM -0800, Jae Hyun Yoo wrote: Hi Guenter, Thanks for sharing your time to review this code. Please check my answers inline. On 2/21/2018 10:26 AM, Guenter Roeck wrote: On Wed, Feb 21, 2018 at 08:16:05AM -0800, Jae

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

2018-02-21 Thread Jae Hyun Yoo
On 2/21/2018 4:37 PM, Andrew Lunn wrote: But even with this change, it still needs to use delayed creation because BMC side kernel doesn't know how many DIMMs are populated on a remote server before the remote server completes its memory training and testing in BIOS, but it needs to check the rem

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-22 Thread Jae Hyun Yoo
On 2/21/2018 10:54 PM, Greg KH wrote: On Wed, Feb 21, 2018 at 12:42:30PM -0800, Jae Hyun Yoo wrote: On 2/21/2018 9:58 AM, Greg KH wrote: On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus into linux driver framework. Signed-off

Re: [RFC PATCH] drivers/peci: peci_match_id() can be static

2018-02-22 Thread Jae Hyun Yoo
On 2/21/2018 11:01 PM, kbuild test robot wrote: Fixes: 99f5d2b99ecd ("drivers/peci: Add support for PECI bus driver core") Signed-off-by: Fengguang Wu --- peci-core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/peci/peci-core.c b/drivers/peci/peci-core.

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

2018-02-24 Thread Jae Hyun Yoo
On 2/23/2018 4:00 PM, Miguel Ojeda wrote: On Thu, Feb 22, 2018 at 2:29 AM, Jae Hyun Yoo wrote: On 2/21/2018 4:37 PM, Andrew Lunn wrote: But even with this change, it still needs to use delayed creation because BMC side kernel doesn't know how many DIMMs are populated on a remote s

Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-03-06 Thread Jae Hyun Yoo
Hi Pavel, Thanks for sharing your time on reviewing it. Please see my answers inline. -Jae On 3/6/2018 4:40 AM, Pavel Machek wrote: Hi! Signed-off-by: Jae Hyun Yoo --- .../devicetree/bindings/peci/peci-aspeed.txt | 73 ++ 1 file changed, 73 insertions

Re: [PATCH v2 0/8] PECI device driver introduction

2018-03-06 Thread Jae Hyun Yoo
Hi Pavel, Please see my answer inline. On 3/6/2018 4:40 AM, Pavel Machek wrote: Hi! Introduction of the Platform Environment Control Interface (PECI) bus device driver. PECI is a one-wire bus interface that provides a communication channel between Intel processor and chipset components to ext

Re: [PATCH v2 6/8] [PATCH 6/8] Documentation: hwmon: Add a document for PECI hwmon client driver

2018-03-06 Thread Jae Hyun Yoo
Hi Randy, On 3/6/2018 12:28 PM, Randy Dunlap wrote: Hi, On 02/21/2018 08:16 AM, Jae Hyun Yoo wrote: +temp_labelProvides DDR DIMM temperature if this label indicates + 'DIMM #'. +temp_inputProvides current temperature of the DDR DIM

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-03-07 Thread Jae Hyun Yoo
Hi Julia, Thanks for sharing your time on reviewing it. Please see my inline answers. Jae On 3/6/2018 7:19 PM, Julia Cartwright wrote: On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus into linux driver framework. Signed-off-by

Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-03-09 Thread Jae Hyun Yoo
Hi Milton, Thanks for sharing your time to review this patch. Please see my answer inline. Jae On 3/9/2018 3:41 PM, Milton Miller II wrote: About 03/07/2018 04:12PM in some time zone, Pavel Machek wrote: Subject: Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

2018-03-13 Thread Jae Hyun Yoo
8 05:16 PM, Jae Hyun Yoo wrote: This commit adds a generic PECI hwmon client driver implementation. Signed-off-by: Jae Hyun Yoo ---   drivers/hwmon/Kconfig  |  10 +   drivers/hwmon/Makefile |   1 +   drivers/hwmon/peci-hwmon.c | 928 +   3 fil

[PATCH v3 10/10] Add a maintainer for the PECI subsystem

2018-04-10 Thread Jae Hyun Yoo
This commit adds a maintainer information for the PECI subsystem. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin Herrenschmidt Cc

[PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

2018-04-10 Thread Jae Hyun Yoo
This commit adds PECI cputemp and dimmtemp hwmon drivers. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin Herrenschmidt Cc

[PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-10 Thread Jae Hyun Yoo
This commit adds dt-bindings documents for PECI cputemp and dimmtemp client drivers. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin

[PATCH v3 06/10] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2018-04-10 Thread Jae Hyun Yoo
This commit adds PECI adapter driver implementation for Aspeed AST24xx/AST25xx. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin

[PATCH v3 08/10] Documentation: hwmon: Add documents for PECI hwmon client drivers

2018-04-10 Thread Jae Hyun Yoo
This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin

[PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-04-10 Thread Jae Hyun Yoo
This commit adds a dt-bindings document of PECI adapter driver for Aspeed AST24xx/25xx SoCs. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc

[PATCH v3 05/10] ARM: dts: aspeed: peci: Add PECI node

2018-04-10 Thread Jae Hyun Yoo
This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc

[PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core

2018-04-10 Thread Jae Hyun Yoo
This commit adds driver implementation for PECI bus core into linux driver framework. Signed-off-by: Jae Hyun Yoo Signed-off-by: Fengguang Wu Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko

[PATCH v3 02/10] Documentations: ioctl: Add ioctl numbers for PECI subsystem

2018-04-10 Thread Jae Hyun Yoo
This commit Updates ioctl-number.txt to reflect ioctl numbers being used by the PECI subsystem. Signed-off-by: Jae Hyun Yoo Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin Herrenschmidt Cc: Fengguang Wu Cc: Greg KH Cc: Guenter Roeck Cc

[PATCH v3 00/10] PECI device driver introduction

2018-04-10 Thread Jae Hyun Yoo
10.6 to millidegree. * Dropped non-standard attributes in hwmon driver. * Fixed OF table for hwmon to make it indicate as a PECI client of Intel CPU target. * Added a maintainer of PECI subsystem into MAINTAINERS document. Fengguang Wu (1): drivers/peci: Add support for PECI bus driver core

[PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers

2018-04-10 Thread Jae Hyun Yoo
This commit adds documents of generic PECI bus, adapter and client drivers. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Cc: Alan Cox Cc: Andrew Jeffery Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

2018-04-11 Thread Jae Hyun Yoo
Hi Guenter, Thanks a lot for sharing your time. Please see my inline answers. On 4/10/2018 3:28 PM, Guenter Roeck wrote: On Tue, Apr 10, 2018 at 11:32:11AM -0700, Jae Hyun Yoo wrote: This commit adds PECI cputemp and dimmtemp hwmon drivers. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue

Re: [PATCH v3 06/10] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2018-04-11 Thread Jae Hyun Yoo
Hello Joel, Thanks for sharing your time. Please see my answers inline. On 4/11/2018 4:51 AM, Joel Stanley wrote: Hello Jae, On 11 April 2018 at 04:02, Jae Hyun Yoo wrote: This commit adds PECI adapter driver implementation for Aspeed AST24xx/AST25xx. The driver is looking good! It looks

Re: [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers

2018-04-11 Thread Jae Hyun Yoo
Hi Joel, On 4/11/2018 4:52 AM, Joel Stanley wrote: Hi Jae, On 11 April 2018 at 04:02, Jae Hyun Yoo wrote: This commit adds documents of generic PECI bus, adapter and client drivers. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-04-11 Thread Jae Hyun Yoo
Hi Joel, On 4/11/2018 4:52 AM, Joel Stanley wrote: On 11 April 2018 at 04:02, Jae Hyun Yoo wrote: This commit adds a dt-bindings document of PECI adapter driver for Aspeed We try to capitalise ASPEED. Got it. Will capitalize all Aspeed words. AST24xx/25xx SoCs. --- .../devicetree

Re: [PATCH v3 05/10] ARM: dts: aspeed: peci: Add PECI node

2018-04-11 Thread Jae Hyun Yoo
On 4/11/2018 4:52 AM, Joel Stanley wrote: On 11 April 2018 at 04:02, Jae Hyun Yoo wrote: This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. The patches to the device trees get merged by the ASPEED maintainer (me). Once you have the bindings reviewed you

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

2018-04-11 Thread Jae Hyun Yoo
On 4/11/2018 5:34 PM, Guenter Roeck wrote: On 04/11/2018 02:59 PM, Jae Hyun Yoo wrote: Hi Guenter, Thanks a lot for sharing your time. Please see my inline answers. On 4/10/2018 3:28 PM, Guenter Roeck wrote: On Tue, Apr 10, 2018 at 11:32:11AM -0700, Jae Hyun Yoo wrote: This commit adds PECI

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

2018-04-12 Thread Jae Hyun Yoo
On 4/11/2018 8:40 PM, Guenter Roeck wrote: On 04/11/2018 07:51 PM, Jae Hyun Yoo wrote: On 4/11/2018 5:34 PM, Guenter Roeck wrote: On 04/11/2018 02:59 PM, Jae Hyun Yoo wrote: Hi Guenter, Thanks a lot for sharing your time. Please see my inline answers. On 4/10/2018 3:28 PM, Guenter Roeck

Re: [PATCH v3 09/10] drivers/hwmon: Add PECI hwmon client drivers

2018-04-12 Thread Jae Hyun Yoo
On 4/12/2018 10:37 AM, Guenter Roeck wrote: On Thu, Apr 12, 2018 at 10:09:51AM -0700, Jae Hyun Yoo wrote: [ ... ] +static int find_core_index(struct peci_cputemp *priv, int channel) +{ +    int core_channel = channel - DEFAULT_CHANNEL_NUMS; +    int idx, found = 0; + +    for (idx = 0; idx

[PATCH v9 12/12] Add maintainers for the PECI subsystem

2018-12-18 Thread Jae Hyun Yoo
This commit adds maintainer information for the PECI subsystem. Cc: David S. Miller Cc: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: Linus Walleij Cc: Randy Dunlap Cc: Jason M Biils Signed-off-by: Jae Hyun Yoo --- MAINTAINERS | 22 ++ 1 file

[PATCH v9 10/12] hwmon: Add PECI cputemp driver

2018-12-18 Thread Jae Hyun Yoo
This commit adds PECI cputemp hwmon driver. Cc: Guenter Roeck Cc: Jean Delvare Cc: Alan Cox Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Jason M Biils Cc: Joel Stanley Cc: Miguel Ojeda Cc: Andrew Lunn Cc: Stef van Os Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang

[PATCH v9 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2018-12-18 Thread Jae Hyun Yoo
This commit adds PECI client MFD driver. Cc: Lee Jones Cc: Randy Dunlap Cc: Rob Herring Cc: Andrew Jeffery Cc: James Feist Cc: Jason M Biils Cc: Joel Stanley Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo --- drivers/mfd/Kconfig | 14 +++ drivers/mfd/Makefile

[PATCH v9 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers

2018-12-18 Thread Jae Hyun Yoo
This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Cc: Guenter Roeck Cc: Jean Delvare Cc: Jonathan Corbet Cc: Jason M Biils Cc: Randy Dunlap Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Acked-by: Guenter

[PATCH v9 11/12] hwmon: Add PECI dimmtemp driver

2018-12-18 Thread Jae Hyun Yoo
This commit adds PECI dimmtemp hwmon driver. Cc: Guenter Roeck Cc: Jean Delvare Cc: Alan Cox Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Jason M Biils Cc: Joel Stanley Cc: Miguel Ojeda Cc: Andrew Lunn Cc: Stef van Os Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue

[PATCH v9 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2018-12-18 Thread Jae Hyun Yoo
This commit adds PECI adapter driver implementation for Aspeed AST24xx/AST25xx SoCs. Cc: Joel Stanley Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Greg Kroah-Hartman Cc: Robin Murphy Cc: Ryan Chen Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by

[PATCH v9 05/12] ARM: dts: aspeed: peci: Add PECI node

2018-12-18 Thread Jae Hyun Yoo
This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. Cc: Rob Herring Cc: Mark Rutland Cc: Joel Stanley Cc: Andrew Jeffery Cc: Jason M Biils Cc: Ryan Chen Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon

[PATCH v9 07/12] dt-bindings: mfd: Add a document for PECI client MFD

2018-12-18 Thread Jae Hyun Yoo
This commit adds a dt-bindings document for PECI client MFD. Cc: Lee Jones Cc: Rob Herring Cc: Mark Rutland Cc: Andrew Jeffery Cc: James Feist Cc: Jason M Biils Cc: Joel Stanley Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo Reviewed-by: Rob Herring --- .../bindings/mfd/intel-peci

[PATCH v9 04/12] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs

2018-12-18 Thread Jae Hyun Yoo
Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Reviewed-by: Rob Herring --- .../devicetree/bindings/peci/peci-aspeed.txt | 55 +++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/peci

[PATCH v9 03/12] peci: Add support for PECI bus driver core

2018-12-18 Thread Jae Hyun Yoo
a Cc: David Kershner Cc: Johan Hovold Cc: Uwe Kleine-Konig Cc: Viresh Kumar Cc: Randy Dunlap Cc: Cyrille Pitchen Cc: Juergen Gross Cc: Alan Cox Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin Herrenschmidt Cc: Fengguang Wu Cc: Jason M Biils Cc: Julia Cartwright Sign

[PATCH v9 01/12] dt-bindings: Add a document of PECI subsystem

2018-12-18 Thread Jae Hyun Yoo
This commit adds a document of generic PECI bus, adapter and client driver. Cc: Rob Herring Cc: Mark Rutland Cc: Andrew Jeffery Cc: Joel Stanley Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Reviewed-by: Rob Herring

[PATCH v9 00/12] PECI device driver introduction

2018-12-18 Thread Jae Hyun Yoo
standard attributes in hwmon driver. - Fixed OF table for hwmon to make it indicate as a PECI client of Intel CPU target. - Added a maintainer of PECI subsystem into MAINTAINERS document. Jae Hyun Yoo (12): dt-bindings: Add a document of PECI subsystem Documentation: ioctl: Add ioctl number

[PATCH v9 02/12] Documentation: ioctl: Add ioctl numbers for PECI subsystem

2018-12-18 Thread Jae Hyun Yoo
: Bryant G. Ly Cc: Arnd Bergmann Cc: James Feist Cc: Jason M Biils Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo --- Documentation/ioctl/ioctl-number.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/ioctl/ioctl-number.txt b/Documentation/ioctl/ioctl-number.txt index

Re: [PATCH v9 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2019-01-02 Thread Jae Hyun Yoo
Hi Lee, On 12/21/2018 6:46 AM, Lee Jones wrote: On Tue, 18 Dec 2018, Jae Hyun Yoo wrote: This commit adds PECI client MFD driver. +config MFD_INTEL_PECI_CLIENT + bool "Intel PECI client" + depends on (PECI || COMPILE_TEST) + select MFD_CORE + help +

Re: [PATCH v9 07/12] dt-bindings: mfd: Add a document for PECI client MFD

2019-01-02 Thread Jae Hyun Yoo
Hi Lee, On 12/21/2018 6:47 AM, Lee Jones wrote: On Tue, 18 Dec 2018, Jae Hyun Yoo wrote: This commit adds a dt-bindings document for PECI client MFD. +* Intel PECI client bindings +PECI (Platform Environment Control Interface) is a one-wire bus interface that +provides a communication

[PATCH v10 01/12] dt-bindings: Add a document of PECI subsystem

2019-01-07 Thread Jae Hyun Yoo
This commit adds a document of generic PECI bus, adapter and client driver. Cc: Rob Herring Cc: Mark Rutland Cc: Andrew Jeffery Cc: Joel Stanley Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Reviewed-by: Rob Herring

[PATCH v10 04/12] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs

2019-01-07 Thread Jae Hyun Yoo
Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Reviewed-by: Rob Herring --- .../devicetree/bindings/peci/peci-aspeed.txt | 55 +++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/peci

[PATCH v10 11/12] hwmon: Add PECI dimmtemp driver

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI dimmtemp hwmon driver. Cc: Guenter Roeck Cc: Jean Delvare Cc: Alan Cox Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Jason M Biils Cc: Joel Stanley Cc: Miguel Ojeda Cc: Andrew Lunn Cc: Stef van Os Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue

[PATCH v10 07/12] dt-bindings: mfd: Add a document for PECI client driver

2019-01-07 Thread Jae Hyun Yoo
This commit adds a dt-bindings document for PECI client driver. Cc: Lee Jones Cc: Rob Herring Cc: Mark Rutland Cc: Andrew Jeffery Cc: James Feist Cc: Jason M Biils Cc: Joel Stanley Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo Reviewed-by: Rob Herring --- .../bindings/mfd/intel-peci

[PATCH v10 10/12] hwmon: Add PECI cputemp driver

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI cputemp hwmon driver. Cc: Guenter Roeck Cc: Jean Delvare Cc: Alan Cox Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Jason M Biils Cc: Joel Stanley Cc: Miguel Ojeda Cc: Andrew Lunn Cc: Stef van Os Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang

[PATCH v10 12/12] Add maintainers for the PECI subsystem

2019-01-07 Thread Jae Hyun Yoo
This commit adds maintainer information for the PECI subsystem. Cc: David S. Miller Cc: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: Linus Walleij Cc: Randy Dunlap Cc: Jason M Biils Signed-off-by: Jae Hyun Yoo --- MAINTAINERS | 22 ++ 1 file

[PATCH v10 08/12] mfd: intel-peci-client: Add PECI client driver

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI client driver. Cc: Lee Jones Cc: Randy Dunlap Cc: Rob Herring Cc: Andrew Jeffery Cc: James Feist Cc: Jason M Biils Cc: Joel Stanley Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo --- drivers/mfd/Kconfig | 14 +++ drivers/mfd/Makefile

[PATCH v10 00/12] PECI device driver introduction

2019-01-07 Thread Jae Hyun Yoo
te as a PECI client of Intel CPU target. - Added a maintainer of PECI subsystem into MAINTAINERS document. Jae Hyun Yoo (12): dt-bindings: Add a document of PECI subsystem Documentation: ioctl: Add ioctl numbers for PECI subsystem peci: Add support for PECI bus driver core dt-bindings: Add

[PATCH v10 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers

2019-01-07 Thread Jae Hyun Yoo
This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Cc: Guenter Roeck Cc: Jean Delvare Cc: Jonathan Corbet Cc: Jason M Biils Cc: Randy Dunlap Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Acked-by: Guenter

[PATCH v10 05/12] ARM: dts: aspeed: peci: Add PECI node

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. Cc: Rob Herring Cc: Mark Rutland Cc: Joel Stanley Cc: Andrew Jeffery Cc: Jason M Biils Cc: Ryan Chen Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon

[PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI adapter driver implementation for Aspeed AST24xx/AST25xx SoCs. Cc: Joel Stanley Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Greg Kroah-Hartman Cc: Robin Murphy Cc: Ryan Chen Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by

[PATCH v10 02/12] Documentation: ioctl: Add ioctl numbers for PECI subsystem

2019-01-07 Thread Jae Hyun Yoo
: Bryant G. Ly Cc: Arnd Bergmann Cc: James Feist Cc: Jason M Biils Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo --- Documentation/ioctl/ioctl-number.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/ioctl/ioctl-number.txt b/Documentation/ioctl/ioctl-number.txt index

[PATCH v10 03/12] peci: Add support for PECI bus driver core

2019-01-07 Thread Jae Hyun Yoo
a Cc: David Kershner Cc: Johan Hovold Cc: Uwe Kleine-Konig Cc: Viresh Kumar Cc: Randy Dunlap Cc: Cyrille Pitchen Cc: Juergen Gross Cc: Alan Cox Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin Herrenschmidt Cc: Fengguang Wu Cc: Jason M Biils Cc: Julia Cartwright Sign

Re: [PATCH v10 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers

2019-01-14 Thread Jae Hyun Yoo
On 1/14/2019 3:43 AM, Joel Stanley wrote: On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Cc: Guenter Roeck Cc: Jean Delvare Cc: Jonathan Corbet Cc: Jason M Biils Cc: Randy Dunlap Signed-off-by: Jae Hyun Yoo

Re: [PATCH v10 08/12] mfd: intel-peci-client: Add PECI client driver

2019-01-14 Thread Jae Hyun Yoo
On 1/14/2019 3:42 AM, Joel Stanley wrote: On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: This commit adds PECI client driver. It looks like it's a PECI driver for the three CPU families, and it implements cpu and dimm temp, with sideband functions deferred to the future. If you add

Re: [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers

2018-04-16 Thread Jae Hyun Yoo
Hi Rob, Thanks for sharing your time. Please see my answers inline. On 4/16/2018 10:59 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:03AM -0700, Jae Hyun Yoo wrote: This commit adds documents of generic PECI bus, adapter and client drivers. "dt-bindings: ..." for the subj

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-04-16 Thread Jae Hyun Yoo
On 4/16/2018 11:10 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: This commit adds a dt-bindings document of PECI adapter driver for Aspeed AST24xx/25xx SoCs. Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by

Re: [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers

2018-04-16 Thread Jae Hyun Yoo
On 4/16/2018 11:14 AM, Rob Herring wrote: On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote: This commit adds dt-bindings documents for PECI cputemp and dimmtemp client drivers. "dt-bindings: hwmon: ..." for the subject. I'll change the subject. Signed-off-b

  1   2   >