.wjay3iym-...@intel.com/
Signed-off-by: Yangtao Li
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Signed-off-by: Lu Hongfei
Signed-off-by: Yangtao Li
Jaegeuk, it may be late, feel free to add:
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs
On 2023/6/13 14:59, Yangtao Li wrote:
Expend fallocate command to support more flags.
Signed-off-by: Yangtao Li
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net
On 2023/6/13 14:51, Yunlei He wrote:
This patch count mmap write io more accurately and remove
redundant PageUptodate judgement in f2fs_vm_page_mkwrite.
Yunlei,
What about separating this patch:
- remove unneeded uptodate check/set.
- fix incorrect PageMappedToDisk check and goto logic.
On 2023/6/13 12:14, Yangtao Li wrote:
On 2023/6/12 22:38, Chao Yu wrote:
On 2023/6/9 21:15, Yangtao Li wrote:
It is observed that when in user compression mode
(compress_extension=*),
even though the file is not compressed, the file is still forced to use
buffer io, which makes the AndroBench
On 2023/6/14 17:27, Chunhai Guo wrote:
Hi Jaegeuk,
Could you please help to confirm if this patch has been merged? I cannot
see the patch in the dev-test or dev branch.
Thanks.
On 2023/5/24 10:42, 郭纯海 wrote:
find_fsync_inode() detect the looped node chain by comparing the loop
counter with
On 2023/6/12 11:01, Sheng Yong wrote:
This patch adds f2fs_ioc_get_compress_blocks() to provide a common
f2fs_get_compress_blocks().
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel
On 2023/6/12 11:01, Sheng Yong wrote:
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2023/6/12 11:01, Sheng Yong wrote:
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
is
valid.
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
or f2fs so that noop_direct_IO can eventually be removed.
Signed-off-by: Christoph Hellwig
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2023/6/13 4:16, Jaegeuk Kim wrote:
On 05/31, Chao Yu wrote:
There are several issues in sanity_check_inode():
- The code looks not clean, it checks extra_attr related condition
dispersively.
- It missed to check i_extra_isize w/ lower boundary
- It missed to check feature dependency
On 2023/6/12 23:36, Jaegeuk Kim wrote:
On 06/12, Chao Yu wrote:
On 2023/6/7 4:36, Jaegeuk Kim wrote:
Let's compress tmp files for the given extension list.
Could you please check below commit? IIRC, it was introduce to avoid compressing
file which has unpredictable tmp file, e.g. foo.sox
On 2023/6/12 23:17, Jaegeuk Kim wrote:
ZSTD does not support compress_level=0.
The commit d7ffafc99c42 ("f2fs: add sanity compress level check for compressed
file")
started to complain this.
Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Y
On 2023/6/9 21:15, Yangtao Li wrote:
It is observed that when in user compression mode (compress_extension=*),
even though the file is not compressed, the file is still forced to use
buffer io, which makes the AndroBench sequential read and write drop
significantly. In fact, when the file is not
On 2023/6/8 0:29, Jaegeuk Kim wrote:
ZSTD does not support compress_level=0.
IIUC, it looks the range is [0, ZSTD_MAX_CLEVEL], 0 equals to default
(ZSTD_CLEVEL_DEFAULT).
zstd_compress.c
/* row */
if (compressionLevel == 0) row = ZSTD_CLEVEL_DEFAULT; /* 0 == default */
else if
4a67d9b07ac8dce7f1034e0d887f2f4ee00fe118
Author: Chao Yu
Date: Tue May 18 17:54:58 2021 +0800
f2fs: compress: fix to disallow temp extension
This patch restricts to configure compress extension as format of:
[filename + '.' + extension]
rather than:
[filename + '.' + extension
f2fs_dentry_hash() may return -ENOMEM due to malloc() failure, however
caller won't check validaty of return value, result assign or check
wrong hash value, fix to call assert() for such case.
Signed-off-by: Chao Yu
---
lib/libf2fs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
On 2023/6/7 1:39, Daeho Jeong wrote:
From: Daeho Jeong
Do not check F2FS_ZONED_HM for the whole device. We need to do this for
each area of devices.
Signed-off-by: Daeho Jeong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
On 2023/6/6 19:13, Yangtao Li wrote:
On 2023/6/6 14:43, Chao Yu wrote:
On 2023/5/31 22:40, Yangtao Li wrote:
This adds the async buffered write support to f2fs,
the following is the relevant test data.
Yangtao,
Could you please provide detailed test command?
Use fio to test
On 2023/6/7 22:56, Yangtao Li wrote:
Expend fallocate command to support more flags.
Signed-off-by: Yangtao Li
---
tools/f2fs_io/f2fs_io.c | 39 +--
1 file changed, 33 insertions(+), 6 deletions(-)
diff --git a/tools/f2fs_io/f2fs_io.c
On 2023/5/31 22:40, Yangtao Li wrote:
This adds the async buffered write support to f2fs,
the following is the relevant test data.
Yangtao,
Could you please provide detailed test command?
Thanks,
iodepth | 1| 2| 4| 8| 16 |
before(M/s) | 1012 | 1133 | 894 | 981 |
,
Applied with a minor motification based on yours. :)
The version in dev-test branch looks good to me.
Reviewed-by: Chao Yu
Thanks,
Match other file-systems and enable it. The read performance has been
greatly improved under io_uring:
167M/s -> 234M/s, Increase ratio by 40%
Test w
Jaegeuk,
Any comments on this patch?
On 2023/5/29 18:47, Chao Yu wrote:
Compression option in inode should not be changed after they have
been used, however, it may happen in below race case:
Thread AThread B
- f2fs_ioc_set_compress_option
- check
freeze_super() can fail, it needs to check its return value and do
error handling in f2fs_resize_fs().
Fixes: 04f0b2eaa3b3 ("f2fs: ioctl for removing a range from F2FS")
Fixes: b4b10061ef98 ("f2fs: refactor resize_fs to avoid meta updates in
progress")
Signed-off-by: Chao Y
This patch adds F2FS_QUOTA_DEFAULT_FL to include two default flags:
F2FS_NOATIME_FL and F2FS_IMMUTABLE_FL, and use it to clean up codes.
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 2 ++
fs/f2fs/super.c | 6 +++---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/f2fs.h b
dentry exists: err(-ENOENT) with new(ERR) --> dentry, err=ERR
Signed-off-by: Wu Bo
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2023/6/1 1:52, Daeho Jeong wrote:
From: Daeho Jeong
Remove power-of-two limitation for zoned device, since zoned devices
don't have it.
Signed-off-by: Daeho Jeong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs
On 2023/6/5 14:08, Maxim Korotkov wrote:
In error handling cases, exiting a function without releasing memory
Signed-off-by: Maxim Korotkov
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
On 2023/6/2 18:26, Maxim Korotkov wrote:
The input pointer "parent" was used unsafely
before checking against NULL
Found by RASU JSC with Svace static analyzer
Fixes: 603f8f9d3(sload.f2fs: support loading files into partition directly)
Reviewed-by: Chao Yu
Signed-off-by: Maxi
On 2023/6/2 18:24, Maxim Korotkov wrote:
In error handling cases, the function exited without releasing memory
Signed-off-by: Maxim Korotkov
---
changelog: fixed code review remarks
fsck/dir.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/fsck/dir.c
On 2023/6/2 18:24, Maxim Korotkov wrote:
In error handling cases, the function exited without releasing memory
Signed-off-by: Maxim Korotkov
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
On 2023/5/31 15:22, Maxim Korotkov wrote:
In error handling cases, exiting a function without releasing memory
Added tags to clean up resources and return error code
Found by RASU JSC
Signed-off-by: Maxim Korotkov
---
fsck/dir.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
On 2023/5/31 14:51, Maxim Korotkov wrote:
The input pointer "parent" was used unsafely
before checking against NULL
Found by RASU JSC with Svace static analyzer
Fixes: 603f8f9d3(sload.f2fs: support loading files into partition directly)
Signed-off-by: Maxim Korotkov
---
fsck/dir.c | 14
On 2023/6/2 12:48, beomsu kim wrote:
When evaluating in f2fs, it takes much time to obtain waf data.
This patch helps to obtain waf data without calcluation.
Signed-off-by: Beomsu Kim
---
fs/f2fs/iostat.c | 16
1 file changed, 16 insertions(+)
diff --git a/fs/f2fs/iostat.c
ive
Calling filemap_fdatawrite() and filemap_fdatawait() to keep all data
clean before quota file setup.
Signed-off-by: Chao Yu
---
v2:
- avoid compile warning reported by l...@intel.com.
fs/f2fs/super.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/supe
This patch supports a new sub-command 'gc_range' in f2fs_io to trigger
gc to move blocks in specified range via F2FS_IOC_GARBAGE_COLLECT_RANGE
ioctl.
Signed-off-by: Chao Yu
---
man/f2fs_io.8 | 3 +++
tools/f2fs_io/f2fs_io.c | 35 +++
2 files changed
On 2023/5/29 9:35, Sheng Yong wrote:
This patch adds get_attr and set_attr to access inode's extra
attributes.
It needs to update f2fs_io(8) manual as well?
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
-by: Sheng Yong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2023/5/31 7:03, Jaegeuk Kim wrote:
On 05/29, Chao Yu wrote:
This patch does below changes:
- clean up check condition
- add sanity check for i_extra_isize w/ lower boundary
- add sanity check for feature dependency
- check i_extra_isize only if f2fs_has_extra_attr() is true
Could you
on extra_attr feature.
- It's not necessary to check i_extra_isize due to it will only
be assigned to non-zero value if f2fs_has_extra_attr() is true
in do_read_inode().
Fix them all in this patch.
Signed-off-by: Chao Yu
---
v2:
- describe current problem in commit message
fs/f2fs/f2fs.h | 2 +
fs
On 2023/5/31 7:47, Jaegeuk Kim wrote:
On 05/27, Chao Yu wrote:
Introduce alloc_next_free_block() to wrap below openned codes:
blkaddr = get_sb(main_blkaddr) +
c.cur_seg[curseg_type] * c.blks_per_seg +
c.curseg_offset[curseg_type
and change return value's type of IS_INODE() from int to bool.
Signed-off-by: Chao Yu
---
v2:
- remove unnecessary le32_to_cpu()
- change return value's type of IS_INODE()
fsck/fsck.c | 7 +++
fsck/mount.c | 4 ++--
fsck/node.h | 4 ++--
3 files changed, 7 insertions(+), 8 deletions
On 2023/5/31 7:32, Jaegeuk Kim wrote:
On 05/30, Wu Bo wrote:
The NULL return of 'd_splice_alias' dosen't mean error. Thus the
successful case will also return NULL, which makes the tracepoint always
print 'err=-ENOENT'.
Signed-off-by: Wu Bo
---
fs/f2fs/namei.c | 5 +++--
1 file changed, 3
On 2023/5/31 6:58, Jaegeuk Kim wrote:
On 05/28, Chao Yu wrote:
and use le32_to_cpu() in IS_INODE().
Signed-off-by: Chao Yu
---
fsck/fsck.c | 7 +++
fsck/mount.c | 4 ++--
fsck/node.h | 3 ++-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/fsck/fsck.c b/fsck/fsck.c
On 2023/5/30 9:21, Wu Bo wrote:
The NULL return of 'd_splice_alias' dosen't mean error. Thus the
successful case will also return NULL, which makes the tracepoint always
print 'err=-ENOENT'.
Signed-off-by: Wu Bo
Reviewed-by: Chao Yu
Thanks
On 2023/5/24 19:41, Qi Han wrote:
Allow to compress mmap files in commit e3c548323d32 ("f2fs: let's
allow compression for mmap files"). However, we cannot set the
compress option to the mmap file. To keep the same concept in both
compress_modes, f2fs_ioc_set_compress_option should also allow it.
by covering f2fs_file_mmap() w/ inode lock,
meanwhile add mmap file check condition in f2fs_may_compress() as well.
Fixes: e1e8debec656 ("f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl")
Signed-off-by: Chao Yu
---
v2:
- add mmap file check condition in f2fs_may_compress()
fs/f2fs/f2fs.h | 3 ++
This patch does below changes:
- clean up check condition
- add sanity check for i_extra_isize w/ lower boundary
- add sanity check for feature dependency
- check i_extra_isize only if f2fs_has_extra_attr() is true
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 2 +
fs/f2fs/inode.c | 108
by covering f2fs_file_mmap() w/ inode lock.
Fixes: e1e8debec656 ("f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl")
Signed-off-by: Chao Yu
---
fs/f2fs/file.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 7b097ab2f5e4..68
efficient.
Signed-off-by: Chunhai Guo
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2023/5/29 12:13, Wu Bo wrote:
On Sat, May 27, 2023 at 09:01:41AM +0800, Chao Yu wrote:
On 2023/5/27 1:21, Jaegeuk Kim wrote:
On 05/24, Wu Bo wrote:
The NULL return of 'd_splice_alias' dosen't mean error.
Signed-off-by: Wu Bo
---
fs/f2fs/namei.c | 2 +-
1 file changed, 1 insertion
and use le32_to_cpu() in IS_INODE().
Signed-off-by: Chao Yu
---
fsck/fsck.c | 7 +++
fsck/mount.c | 4 ++--
fsck/node.h | 3 ++-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/fsck/fsck.c b/fsck/fsck.c
index e6ad71d..a4db2a3 100644
--- a/fsck/fsck.c
+++ b/fsck/fsck.c
For cp error case, there will be dirty meta/node pages remained after
f2fs_write_checkpoint() in f2fs_put_super(), drop them explicitly, and
do sanity check on reference count of dirty pages and inflight IOs.
Signed-off-by: Chao Yu
---
fs/f2fs/super.c | 18 --
1 file changed, 16
ive
Calling filemap_fdatawrite() and filemap_fdatawait() to keep all data
clean before quota file setup.
Signed-off-by: Chao Yu
---
fs/f2fs/super.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index d1bce753f0d2..0bfa98d05
On 2023/5/27 1:21, Jaegeuk Kim wrote:
On 05/24, Wu Bo wrote:
The NULL return of 'd_splice_alias' dosen't mean error.
Signed-off-by: Wu Bo
---
fs/f2fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index
On 2023/5/26 17:08, Chunhai Guo wrote:
find_fsync_dnodes() detect the looped node chain by comparing the loop
counter with free blocks. While it may take tens of seconds to quit when
the free blocks are large enough. We can use Floyd's cycle detection
algorithm to make the detection more
On 2023/5/27 1:05, Jaegeuk Kim wrote:
On 05/25, Chao Yu wrote:
We should set noatime bit for quota files, since no one cares about
atime of quota file, and we should set immutalbe bit as well, due to
nobody should write to the file through exported interfaces.
Meanwhile this patch use
ode->i_flags update.
Signed-off-by: Chao Yu
---
v3:
- simply check condition suggested by Jaegeuk.
fs/f2fs/super.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 51812f459581..8eb17cc73941 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -
On 2023/5/27 0:25, Jaegeuk Kim wrote:
On 05/26, Chao Yu wrote:
Signed-off-by: Chao Yu
---
fsck/mount.c | 56 +--
include/f2fs_fs.h | 42 +--
2 files changed, 41 insertions(+), 57 deletions(-)
diff --git
/ alloc_next_free_block()--- first
[PATCH v3 4/4] mkfs.f2fs: refactor format flow for cleanup
[PATCH v4 1/2] f2fs-tools: fix to le32 type variable correctly
[PATCH v4 2/2] f2fs-tools: reuse feature_table to clean up print_sb_state()
--- last
Thanks,
On 05/26, Chao Yu wrote:
During formatting
reuse feature_table in print_sb_state() for cleanup.
Signed-off-by: Chao Yu
---
v4:
- use MAX_NR_FEATURE instead of constant
fsck/mount.c | 56 +--
include/f2fs_fs.h | 54 +++--
2 files changed, 52
iable
sb->feature |= cpu_to_le32(F2FS_FEATURE_ENCRYPT);
Signed-off-by: Chao Yu
---
v4:
- rebase the code
fsck/dir.c | 4 +--
fsck/fsck.c | 21 ++-
fsck/main.c | 6 ++--
fsck/mount.c| 78 +
, f2fs_write_check_point_pack() can write back cached metadata
into CP area directly.
Signed-off-by: Chao Yu
---
v3:
- remove trailing whitespace
include/f2fs_fs.h | 235
mkfs/f2fs_format.c | 447 ++---
2 files changed, 336 insertions
blkaddr in each log.
Signed-off-by: Chao Yu
---
v3:
- rebase the code
include/f2fs_fs.h | 2 +
mkfs/f2fs_format.c | 101 +++--
2 files changed, 45 insertions(+), 58 deletions(-)
diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h
index 8475645..05d27ba
On 2023/5/27 0:14, Jaegeuk Kim wrote:
Is this v9? Why does it have any history anymore?
This patch is for kernel module, previous v8 is for peripheral tools.
Thanks,
On 05/24, Chunhai Guo wrote:
find_fsync_dnodes() detect the looped node chain by comparing the loop
counter with free
reuse feature_table in print_sb_state() for cleanup.
Signed-off-by: Chao Yu
---
v3:
- fix a bug in feature_map()
fsck/mount.c | 56 +--
include/f2fs_fs.h | 52 +--
2 files changed, 50 insertions(+), 58
reuse feature_table in print_sb_state() for cleanup.
Signed-off-by: Chao Yu
---
v2:
- add commit message.
fsck/mount.c | 56 +--
include/f2fs_fs.h | 42 +--
2 files changed, 41 insertions(+), 57 deletions(-)
diff
iable
sb->feature |= cpu_to_le32(F2FS_FEATURE_ENCRYPT);
Signed-off-by: Chao Yu
---
fsck/dir.c | 4 +--
fsck/fsck.c | 21 ++-
fsck/main.c | 6 ++--
fsck/mount.c| 78 +
fsck/node.c |
Signed-off-by: Chao Yu
---
fsck/mount.c | 56 +--
include/f2fs_fs.h | 42 +--
2 files changed, 41 insertions(+), 57 deletions(-)
diff --git a/fsck/mount.c b/fsck/mount.c
index 70e8b46..60ad493 100644
--- a/fsck
On 2023/5/24 16:33, Chunhai Guo wrote:
find_fsync_dnodes() detect the looped node chain by comparing the loop
counter with free blocks. While it may take tens of seconds to quit when
the free blocks are large enough. We can use Floyd's cycle detection
algorithm to make the detection more
On 2023/5/24 9:40, Jaegeuk Kim wrote:
On 05/18, Chao Yu wrote:
On 2023/5/18 9:36, Jaegeuk Kim wrote:
On 05/17, Chao Yu wrote:
Introduce alloc_next_free_block() to wrap below openned codes:
blkaddr = get_sb(main_blkaddr) +
c.cur_seg[curseg_type
, f2fs_write_check_point_pack() can write back cached metadata
into CP area directly.
Signed-off-by: Chao Yu
---
v2:
- use NR_CURSEG_TYPE in struct f2fs_configuration
include/f2fs_fs.h | 235
mkfs/f2fs_format.c | 449 ++---
2 files
ode->i_flags update.
Signed-off-by: Chao Yu
---
v2:
- fix to detect i_flags status correctly.
fs/f2fs/super.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 51812f459581..1cf84c993d7c 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -
failed
[ 35.856106] fsck.f2fs: fsck.f2fs terminated by exit(255)
Signed-off-by: Chunhai Guo
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux
On 2023/5/24 9:40, Jaegeuk Kim wrote:
On 05/18, Chao Yu wrote:
On 2023/5/18 9:36, Jaegeuk Kim wrote:
On 05/17, Chao Yu wrote:
Introduce alloc_next_free_block() to wrap below openned codes:
blkaddr = get_sb(main_blkaddr) +
c.cur_seg[curseg_type
.
This patch enables submit reset zone command asynchornously. It helps
decrease average latency of write IOs in high utilization scenario by
faster checkpointing.
Signed-off-by: Daejun Park
Except the change log, it looks good to me.
Reviewed-by: C
(argv[2]) * F2FS_BLKSIZE;
Signed-off-by: zangyangyang1
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
cc: Jens Axboe
cc: Jaegeuk Kim
cc: Chao Yu
cc: linux-f2fs-devel@lists.sourceforge.net
cc: linux-fsde...@vger.kernel.org
cc: linux-bl...@vger.kernel.org
cc: linux...@kvack.org
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux
failed
[ 35.856106] fsck.f2fs: fsck.f2fs terminated by exit(255)
Signed-off-by: Chunhai Guo
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux
Use sbi->log_sectors_per_block to clean up below calculated one:
unsigned int log_sectors_per_block = sbi->log_blocksize - SECTOR_SHIFT;
Signed-off-by: Chao Yu
---
fs/f2fs/segment.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/fs/f2fs/seg
On 2023/5/22 18:34, Chunhai Guo wrote:
find_fsync_inode() detect the looped node chain by comparing the loop
counter with free blocks. While it may take tens of seconds to quit when
the free blocks are large enough. We can use Floyd's cycle detection
algorithm to make the detection more
On 2023/5/23 15:24, zangyangyang1 wrote:
When using fiemap to obtain the block address of files
larger than 2GB ((2147483647+1) bytes), an integer
multiplication overflow error will occur.
This issue is caused by the following code:
start = atoi(argv[1]) * F2FS_BLKSIZE;
length =
son.cn
Tested-by: butt3rflyh4ck
Signed-off-by: Chao Yu
---
v2:
- update commit message a bit
- add Tested-by tag
fs/f2fs/f2fs.h | 2 +-
fs/f2fs/file.c | 2 +-
fs/f2fs/gc.c | 21 ++---
3 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs
83b...@syzkaller.appspotmail.com
Closes:
https://lore.kernel.org/linux-f2fs-devel/20230522124203.3838360-1-c...@kernel.org
Signed-off-by: Chao Yu
---
fs/f2fs/super.c | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
in
On 2023/5/22 22:20, butt3rflyh4ck wrote:
I have tested the patch, it works fine.
Thank you, I'd like to add below tag in the patch if you don't mind.
Tested-by: butt3rflyh4ck
Thanks,
Regards,
butt3rflyh4ck.
On Mon, May 22, 2023 at 8:44 PM Chao Yu wrote:
On 2023/5/22 11:58
.
Thanks,
Maybe it could be an indication on whether it works properly or not?
Thanks,
On Thu, May 18, 2023 at 4:53 PM Chao Yu wrote:
On 2023/4/21 1:26, Juhyung Park wrote:
Hi Chao,
On Fri, Apr 21, 2023 at 1:19 AM Chao Yu wrote:
Hi JuHyung,
Sorry for delay reply.
On 2023/4/11 1:03
19, 2023 at 11:24 PM Chao Yu wrote:
Hi,
Thanks for the report, it will be helpful if you can provide a
reproducer.
On 2023/5/19 15:13, butt3rflyh4ck wrote:
Hi, there is a null-ptr-deref bug in f2fs_write_end_io in
fs/f2fs/data.c, I reproduce it in the latest kernel too.
#Quick description
cn
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 2 +-
fs/f2fs/file.c | 2 +-
fs/f2fs/gc.c | 21 ++---
3 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index a4bff3b5b887..e3ef321d4fbb 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs
Hi,
Thanks for the report, it will be helpful if you can provide a
reproducer.
On 2023/5/19 15:13, butt3rflyh4ck wrote:
Hi, there is a null-ptr-deref bug in f2fs_write_end_io in
fs/f2fs/data.c, I reproduce it in the latest kernel too.
#Quick description
When a thread always calls
failed
[ 35.856106] fsck.f2fs: fsck.f2fs terminated by exit(255)
Signed-off-by: Chunhai Guo
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux
__le32 type variable should be converted w/ le32_to_cpu() before access.
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 7f6c51a6b930..a4bff3b5b887 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs
And use IS_INODE() to clean up codes.
Signed-off-by: Chao Yu
---
fsck/fsck.c | 7 +++
fsck/mount.c | 4 ++--
fsck/node.h | 3 ++-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/fsck/fsck.c b/fsck/fsck.c
index d03f1da..ac4cd98 100644
--- a/fsck/fsck.c
+++ b/fsck/fsck.c
On 2023/5/18 17:10, Chao Yu wrote:
On 2023/5/18 12:11, Chunhai Guo wrote:
find_fsync_inode() detect the looped node chain by comparing the loop
counter with free blocks. While it may take tens of seconds to quit when
the free blocks are large enough. We can use Floyd's cycle detection
algorithm
On 2023/5/18 12:11, Chunhai Guo wrote:
find_fsync_inode() detect the looped node chain by comparing the loop
counter with free blocks. While it may take tens of seconds to quit when
the free blocks are large enough. We can use Floyd's cycle detection
algorithm to make the detection more
bD_t2K6U=t...@mail.gmail.com
Original patch was developed by Weichao Guo, I refactor it a bit and
rebase the code.
Signed-off-by: Weichao Guo
Signed-off-by: Chao Yu
---
v2:
- fix typo
- disable IO aware for perf/lifetime mode
- check bggc mode in get_max_age()
Documentation/filesystems/f2f
On 2023/4/21 1:26, Juhyung Park wrote:
Hi Chao,
On Fri, Apr 21, 2023 at 1:19 AM Chao Yu wrote:
Hi JuHyung,
Sorry for delay reply.
On 2023/4/11 1:03, Juhyung Park wrote:
Hi Chao,
On Tue, Apr 11, 2023 at 12:44 AM Chao Yu wrote:
Hi Juhyung,
On 2023/4/4 15:36, Juhyung Park wrote:
Hi
I refactor it a bit and
rebase the code.
Signed-off-by: Weichao Guo
Signed-off-by: Chao Yu
---
Documentation/filesystems/f2fs.rst | 7 ++-
fs/f2fs/f2fs.h | 4 ++
fs/f2fs/gc.c | 92 +-
fs/f2fs/gc.h | 23 ++
On 2023/5/18 9:21, Jaegeuk Kim wrote:
Applied the below comments. Thanks.
Reviewed-by: Chao Yu
Thanks,
On 05/17, Chao Yu wrote:
On 2023/5/5 23:50, Jaegeuk Kim wrote:
From: Daeho Jeong
To keep six open zone constraints, make them not to be open over six
open zones.
Signed-off
In IRQ context, it wakes up workqueue to record errors into on-disk
superblock fields rather than in-memory fields.
Fixes: 1aa161e43106 ("f2fs: fix scheduling while atomic in decompression path")
Fixes: 95fa90c9e5a7 ("f2fs: support recording errors into superblock")
Signed-off
601 - 700 of 6698 matches
Mail list logo
