Re: [PATCH] staging: speakup: separate 80+ chars lines.

2018-04-18 Thread Willy Tarreau
On Thu, Apr 19, 2018 at 03:47:10AM -0300, Andrew Jye Shih Chuang wrote: > Increase readability of code following the Kernel coding style by breaking > long lines and thus eliminating the checkpatch.pl warning. > > Signed-off-by: Andrew Jye Shih Chuang > --- > drivers/staging/speakup/main.c | 15

Re: [console_unlock] BUG: KASAN: use-after-scope in console_unlock+0x9cd/0xd10

2018-04-18 Thread Fengguang Wu
On Thu, Apr 19, 2018 at 03:20:50PM +0900, Sergey Senozhatsky wrote: On (04/19/18 08:04), Dmitry Vyukov wrote: [..] We could also make them mutually exclusive in config to prevent people from hitting these false positives again and again. Let's do it. Ard and Kees agreed on making them mutually

Re: [string_selftest_init] watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [swapper/0:1]

2018-04-18 Thread Fengguang Wu
On Thu, Apr 19, 2018 at 08:22:24AM +0200, Geert Uytterhoeven wrote: Hi Fengguang, On Thu, Apr 19, 2018 at 4:50 AM, Fengguang Wu wrote: FYI this happens in mainline kernel 4.17.0-rc1. It dates back to v4.14-rc1 , perhaps since the test was introduced. It occurs in 1 out of 1 boots. I guess t

Re: [PATCH v6 01/11] ARM: sunxi: smp: Move assembly code into a file

2018-04-18 Thread Mylène Josserand
Hello Chen-Yu, On Wed, 18 Apr 2018 18:05:03 +0800 Chen-Yu Tsai wrote: > On Wed, Apr 18, 2018 at 4:45 PM, Maxime Ripard > wrote: > > On Tue, Apr 17, 2018 at 07:25:15PM +0800, Chen-Yu Tsai wrote: > >> On Tue, Apr 17, 2018 at 7:17 PM, Maxime Ripard > >> wrote: > >> > On Tue, Apr 17, 2018 at 1

[PATCH] parisc: time: Convert read_persistent_clock() to read_persistent_clock64()

2018-04-18 Thread Baolin Wang
The read_persistent_clock() uses a timespec, which is not year 2038 safe on 32bit systems. On parisc architecture, we have implemented generic RTC drivers that can be used to compensate the system suspend time, but the RTC time can not represent the nanosecond resolution, so this patch just convert

Re: [dummy_stm_init] swapper/0: page allocation failure: order:9, mode:0x14040c0(GFP_KERNEL|__GFP_COMP), nodemask=(null)

2018-04-18 Thread Michal Hocko
On Thu 19-04-18 10:36:39, Wu Fengguang wrote: > Hi Alexander, > > FYI this happens in mainline kernel 4.17.0-rc1. > It dates back to at least v4.15. > > It occurs in 4 out of 4 boots. Here KVM has 1G memory. > > This high order allocation caused lots of noises in our boot testing. > We could dis

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread yuankuiz
On 2018-04-19 01:16 PM, Julia Lawall wrote: On Wed, 18 Apr 2018, Joe Perches wrote: On Thu, 2018-04-19 at 06:40 +0200, Julia Lawall wrote: > > On Wed, 18 Apr 2018, Joe Perches wrote: > > > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > > Hi julia, > > > > > > On 2018-04-1

[PATCH] staging: speakup: separate 80+ chars lines.

2018-04-18 Thread Andrew Jye Shih Chuang
Increase readability of code following the Kernel coding style by breaking long lines and thus eliminating the checkpatch.pl warning. Signed-off-by: Andrew Jye Shih Chuang --- drivers/staging/speakup/main.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/driv

Re: kernel BUG at /home/blee/project/race-fuzzer/kernels/kernel_v4.16-rc3/net/packet/af_packet.c:LINE!

2018-04-18 Thread DaeRyong Jeong
Hello. We have analyzed the cause of the crash, kernel BUG at net/packet/af_packet.c:LINE!, which is found by RaceFuzzer (a modified version of Syzkaller) in v4.16-rc7. Since struct packet_sock's member variables, running, has_vnet_hdr, origdev and auxdata are declared as bitfields, accessing thes

Re: [i915] WARNING: CPU: 2 PID: 183 at drivers/gpu/drm/i915/intel_display.c:14584 intel_modeset_init+0x3be/0x1060

2018-04-18 Thread Maarten Lankhorst
Hey, Op 19-04-18 om 04:52 schreef Fengguang Wu: > Hello, > > FYI this happens in mainline kernel and at least dates back to v4.13 . > > [ 75.245840] > [ 75.247783] /opt/deb/gawk_1%3a4.1.4+dfsg-1_amd64.deb > [ 75.247785] > [ 75.248145] [ cut here ] > [ 75.248446] C

Re: [PATCH v6 11/11] ARM: shmobile: Convert file to use cntvoff

2018-04-18 Thread Mylène Josserand
Hello Simon, On Wed, 18 Apr 2018 15:48:55 +0200 Simon Horman wrote: > On Wed, Apr 18, 2018 at 12:03:27PM +0200, Mylène Josserand wrote: > > Hello, > > > > On Wed, 18 Apr 2018 11:36:27 +0200 > > Geert Uytterhoeven wrote: > > > > > Hi Mylène, > > > > > > On Mon, Apr 16, 2018 at 11:50 PM, Myl

Re: [PATCH] mm:memcg: add __GFP_NOWARN in __memcg_schedule_kmem_cache_create

2018-04-18 Thread Michal Hocko
On Wed 18-04-18 11:58:00, David Rientjes wrote: > On Wed, 18 Apr 2018, Michal Hocko wrote: > > > > Okay, no problem. However, I don't feel we need ratelimit at this moment. > > > We can do when we got real report. Let's add just one line warning. > > > However, I have no talent to write a poem to

Re: [PATCH 4.16 00/68] 4.16.3-stable review

2018-04-18 Thread Greg Kroah-Hartman
On Wed, Apr 18, 2018 at 08:41:44AM -0700, Guenter Roeck wrote: > On Tue, Apr 17, 2018 at 05:57:13PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.16.3 release. > > There are 68 patches in this series, all will be posted as a response > > to this one. I

Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off

2018-04-18 Thread Greg Kroah-Hartman
On Wed, Apr 18, 2018 at 05:54:21PM +, Nadav Amit wrote: > Oleksandr Natalenko wrote: > > > Hello. > > > > On Fri, Mar 23, 2018 at 9:42 AM, Oleksandr Natalenko > > wrote: > >>> Actually, rechecking the bug description, I might have rushed. The bug > >>> that > >>> I encountered is related t

Re: [PATCH] x86/mm: vmemmap and vmalloc base addressess are usngined longs

2018-04-18 Thread Jiri Kosina
On Mon, 16 Apr 2018, Kirill A. Shutemov wrote: > > > > Commits 9b46a051e4 ("x86/mm: Initialize vmemmap_base at boot-time") and > > > > a7412546d8 ("x86/mm: Adjust vmalloc base and size at boot-time") lost > > > > the > > > > type information for __VMALLOC_BASE_L4, __VMALLOC_BASE_L5, > > > > __

Re: [patch v2] mm, oom: fix concurrent munlock and oom reaper unmap

2018-04-18 Thread Michal Hocko
On Wed 18-04-18 12:14:29, David Rientjes wrote: > On Wed, 18 Apr 2018, Michal Hocko wrote: > > > > Since exit_mmap() is done without the protection of mm->mmap_sem, it is > > > possible for the oom reaper to concurrently operate on an mm until > > > MMF_OOM_SKIP is set. > > > > > > This allows mu

Re: [PATCH 3/7] bus: add bus driver for accessing Allwinner A64 DE2

2018-04-18 Thread Jagan Teki
On Sat, Apr 14, 2018 at 4:16 PM, Jagan Teki wrote: > On Sat, Apr 14, 2018 at 4:00 PM, Chen-Yu Tsai wrote: >> On Sat, Apr 14, 2018 at 6:25 PM, Jagan Teki >> wrote: >>> On Fri, Mar 16, 2018 at 11:23 PM, Icenowy Zheng wrote: The "Display Engine 2.0" (usually called DE2) on the Allwinner A64

Re: WARNING in refcount_dec

2018-04-18 Thread DaeRyong Jeong
Hello. We have analyzed the cause of the crash in v4.16-rc3, WARNING in refcount_dec, which is found by RaceFuzzer (a modified version of Syzkaller). Since struct packet_sock's member variables, running, has_vnet_hdr, origdev and auxdata are declared as bitfields, accessing these variables can rac

[GIT PULL] s390 patches for 4.17-rc2

2018-04-18 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: After the common code kexec patches went in via Andrew we can now push the architecture parts to implement the kexec-file-load sy

Re: [string_selftest_init] watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [swapper/0:1]

2018-04-18 Thread Geert Uytterhoeven
Hi Fengguang, On Thu, Apr 19, 2018 at 4:50 AM, Fengguang Wu wrote: > FYI this happens in mainline kernel 4.17.0-rc1. > It dates back to v4.14-rc1 , perhaps since the test was introduced. > > It occurs in 1 out of 1 boots. I guess the test just takes too long, causing a panic if BOOTPARAM_HUNG_TA

[PATCH] m68k: Remove read_persistent_clock()

2018-04-18 Thread Baolin Wang
The read_persistent_clock() uses a timespec, which is not year 2038 safe on 32bit systems. Moreover on m68k architecture, we have implemented generic RTC drivers that can be used to compensate the system suspend time. So we can remove the obsolete read_persistent_clock(). Signed-off-by: Baolin Wan

Re: [console_unlock] BUG: KASAN: use-after-scope in console_unlock+0x9cd/0xd10

2018-04-18 Thread Sergey Senozhatsky
On (04/19/18 08:04), Dmitry Vyukov wrote: [..] > We could also make them mutually exclusive in config to prevent people > from hitting these false positives again and again. Let's do it. Ard and Kees agreed on making them mutually exclusive [1][2]. Dmitry, could send out a patch? [1] lkml.kernel

Re: [PATCH 2/2] perf/core: fix bad use of igrab in kernel/event/core.c

2018-04-18 Thread Alexander Shishkin
On Tue, Apr 17, 2018 at 11:29:07PM -0700, Song Liu wrote: > As Miklos reported and suggested: > > This pattern repeats two times in trace_uprobe.c and in > kernel/events/core.c as well: > > ret = kern_path(filename, LOOKUP_FOLLOW, &path); > if (ret) > goto fail_address_p

Re: [PATCH v5 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

2018-04-18 Thread Stephen Boyd
Quoting Lina Iyer (2018-04-05 09:18:31) > Active state requests are sent immediately to the mailbox controller, Drive by note, mailbox went away from this code so grep 'mailbox' or 'mbox' on these patches should come up with zero hits. > while sleep and wake state requests are cached in this driv

[PATCH] clocksource: imx-tpm: correct -ETIME return condition check

2018-04-18 Thread Anson Huang
The additional brakets added to tpm_set_next_event's return value computation causes (int) forced type conversion NOT taking effect, and the incorrect value return will cause various system timer issue, like RCU stall etc.. This patch removes the additional brakets to make sure tpm_set_next_event

Re: [PATCH v2] prctl: fix compat handling for prctl

2018-04-18 Thread Libin (Huawei)
在 2018/4/19 10:25, Andy Lutomirski 写道: On Apr 18, 2018, at 9:06 PM, Li Bin wrote: The member auxv in prctl_mm_map structure which be shared with userspace is pointer type, but the kernel supporting COMPAT didn't handle it. This patch fix the compat handling for prctl syscall. I would propos

Re: [PATCH v2 2/2] regulator: add QCOM RPMh regulator driver

2018-04-18 Thread Stephen Boyd
Quoting David Collins (2018-04-18 16:30:26) > On 04/17/2018 01:02 PM, Doug Anderson wrote: > > On Fri, Apr 13, 2018 at 7:50 PM, David Collins > > wrote: > >> +#define RPMH_REGULATOR_DISABLE 0x0 > >> +#define RPMH_REGULATOR_ENABLE 0x1 > > > > In the last version S

Re: [console_unlock] BUG: KASAN: use-after-scope in console_unlock+0x9cd/0xd10

2018-04-18 Thread Dmitry Vyukov
On Thu, Apr 19, 2018 at 4:17 AM, Fengguang Wu wrote: > Hello, > > FYI this happens in mainline kernel 4.17.0-rc1. > It at least dates back to v4.15-rc1 . > > The regression was reported before > > https://lkml.org/lkml/2017/11/30/33 > > Where the last message from Dmitry mentions that use

Re: [PATCH v2 0/3] perf: Fixes for callchain ip handling on powerpc

2018-04-18 Thread Ravi Bangoria
On 04/18/2018 04:28 PM, Sandipan Das wrote: > The first patch fixes the callchain ip filtering mechanism for powerpc > from skipping entries in case the LR value is still valid and yet to > be written to the stack frame. This was previously posted as an RFC > here: https://lkml.org/lkml/2018/4/4/

Re: [PATCH v2] fs, elf: don't complain MAP_FIXED_NOREPLACE unless -EEXIST error.

2018-04-18 Thread Michal Hocko
On Wed 18-04-18 23:07:12, Tetsuo Handa wrote: > >From 3f396857d23d4bf1fac4d4332316b5ba0af6d2f9 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Wed, 18 Apr 2018 23:00:53 +0900 > Subject: [PATCH v2] fs, elf: don't complain MAP_FIXED_NOREPLACE unless > -EEXIST error. > > Commit 4ed28639519c7b

Re: WARNING: stack going in the wrong direction? ip=__schedule+0x489/0x830

2018-04-18 Thread Fengguang Wu
On Thu, Apr 19, 2018 at 01:49:41PM +0800, Fengguang Wu wrote: Hello, FYI this warning dates back to v4.16-rc5 . It's rather rare and often happen together with other errors. Sorry, that should be 0day didn't catch this particular WARNING. So it just occasionally show up in the context of ot

Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver

2018-04-18 Thread Stephen Boyd
Quoting David Collins (2018-03-22 18:30:06) > On 03/21/2018 12:07 PM, Stephen Boyd wrote: > > Quoting David Collins (2018-03-16 18:09:10) > >> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > >> index 097f617..e0ecd0a 100644 > >> --- a/drivers/regulator/Kconfig > >> +++ b/driver

Re: [RFC v4 3/4] irqflags: Avoid unnecessary calls to trace_ if you can

2018-04-18 Thread Namhyung Kim
On Wed, Apr 18, 2018 at 06:02:50PM +0900, Masami Hiramatsu wrote: > On Mon, 16 Apr 2018 21:07:47 -0700 > Joel Fernandes wrote: > > > With TRACE_IRQFLAGS, we call trace_ API too many times. We don't need > > to if local_irq_restore or local_irq_save didn't actually do anything. > > > > This gives

Re: cpu stopper threads and load balancing leads to deadlock

2018-04-18 Thread Mike Galbraith
On Wed, 2018-04-18 at 07:47 +0200, Mike Galbraith wrote: > On Tue, 2018-04-17 at 15:21 +0100, Matt Fleming wrote: > > Hi guys, > > > > We've seen a bug in one of our SLE kernels where the cpu stopper > > thread ("migration/15") is entering idle balance. This then triggers > > active load balance.

Re: 4.15.17 regression: bisected: timeout during microcode update

2018-04-18 Thread Vitezslav Samel
On Wed, Apr 18, 2018 at 06:53:30AM -0700, Raj, Ashok wrote: > On Wed, Apr 18, 2018 at 02:22:12PM +0200, Borislav Petkov wrote: > > On Wed, Apr 18, 2018 at 02:08:40PM +0200, Vitezslav Samel wrote: > > > I switched to firmware-in-kernel early loading and that works OK. > > firmware-in-kernel means y

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Leo Yan
On Wed, Apr 18, 2018 at 10:21:25PM -0700, Alexei Starovoitov wrote: > On Thu, Apr 19, 2018 at 01:12:49PM +0800, Leo Yan wrote: > > On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > > > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > > > The code defines macro 'PAGE_

[PATCH v2 net 1/3] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
When sending control commands, virtio net sets up several buffers for DMA. The buffers are all part of the net device which means it's actually allocated by kvmalloc so it's in theory (on extreme memory pressure) possible to get a vmalloc'ed buffer which on some platforms means we can't DMA there.

[PATCH v2 net 2/3] virtio_net: fix adding vids on big-endian

2018-04-18 Thread Michael S. Tsirkin
Programming vids (adding or removing them) still passes guest-endian values in the DMA buffer. That's wrong if guest is big-endian and when virtio 1 is enabled. Note: this is on top of a previous patch: virtio_net: split out ctrl buffer Fixes: 9465a7a6f ("virtio_net: enable v1.0 support")

[PATCH v2 net 0/3] virtio: ctrl buffer fixes

2018-04-18 Thread Michael S. Tsirkin
Here are a couple of fixes related to the virtio control buffer. Lightly tested on x86 only. Michael S. Tsirkin (3): virtio_net: split out ctrl buffer virtio_net: fix adding vids on big-endian virtio_net: sparse annotation fix drivers/net/virtio_net.c | 68 +++--

[PATCH v2 net 3/3] virtio_net: sparse annotation fix

2018-04-18 Thread Michael S. Tsirkin
offloads is a buffer in virtio format, should use the __virtio64 tag. Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index f84fe04..c5b11f2 100644 --- a/drivers

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Alexei Starovoitov
On Thu, Apr 19, 2018 at 01:12:49PM +0800, Leo Yan wrote: > On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > > > address is in kernel space or not

Re: [PATCH net] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
On Thu, Apr 19, 2018 at 08:01:49AM +0300, Michael S. Tsirkin wrote: > When sending control commands, virtio net sets up several buffers for > DMA. The buffers are all part of the net device which means it's > actually allocated by kvmalloc so in theory (on extreme memory pressure) > it's possible t

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Julia Lawall
On Wed, 18 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-19 at 06:40 +0200, Julia Lawall wrote: > > > > On Wed, 18 Apr 2018, Joe Perches wrote: > > > > > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > > > Hi julia, > > > > > > > > On 2018-04-15 05:19 AM, Julia Lawall wrot

Smatch check for Spectre stuff

2018-04-18 Thread Dan Carpenter
Several people have asked me to write this and I think one person was maybe working on writing it themselves... The point of this check is to find place which might be vulnerable to the Spectre vulnerability. In the kernel we have the array_index_nospec() macro which turns off speculation. There

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Leo Yan
On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > > address is in kernel space or not. But different architecture has > > different 'PAGE_OFFSET' so

Re: [PATCH] powerpc: Allow selection of CONFIG_LD_DEAD_CODE_DATA_ELIMINATION

2018-04-18 Thread Nicholas Piggin
On Wed, 18 Apr 2018 15:11:24 +0200 Christophe LEROY wrote: > Le 18/04/2018 à 10:36, Mathieu Malaterre a écrit : > > Christophe, > > > > On Wed, Apr 18, 2018 at 8:34 AM, Christophe LEROY > > wrote: > >> > >> > >> Le 17/04/2018 à 19:10, Mathieu Malaterre a écrit : > >>> > >>> On Tue, Apr 17,

[PATCH] net: qrtr: Expose tunneling endpoint to user space

2018-04-18 Thread Bjorn Andersson
This implements a misc character device named "qrtr-tun" for the purpose of allowing user space applications to implement endpoints in the qrtr network. This allows more advanced (and dynamic) testing of the qrtr code as well as opens up the ability of tunneling qrtr over a network or USB link. S

[PATCH net] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
When sending control commands, virtio net sets up several buffers for DMA. The buffers are all part of the net device which means it's actually allocated by kvmalloc so in theory (on extreme memory pressure) it's possible to get a vmalloc'ed buffer which on some platforms means we can't DMA there.

Re: [PATCH] soc: Unconditionally include qcom Makefile

2018-04-18 Thread Bjorn Andersson
On Wed 18 Apr 16:28 PDT 2018, Evan Green wrote: > From: Guenter Roeck > > Incoming Qualcomm changes for GENI, i2c [1], and cmd-db [2] are enabled > with COMPILE_TEST in drivers/soc/qcom. For this to work, the Makefile > in that directory has to be included unconditionally, rather than only > if

RE: [PATCH v2] storvsc: Set up correct queue depth values for IDE devices

2018-04-18 Thread Long Li
> Subject: Re: [PATCH v2] storvsc: Set up correct queue depth values for IDE > devices > > > Long, > > > Can you take a look at the following patch? > > >> > + max_sub_channels = > >> > +(num_cpus - 1) / storvsc_vcpus_per_sub_channel; > > What happens if num_cpus = 1? If num_c

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Joe Perches
On Thu, 2018-04-19 at 06:40 +0200, Julia Lawall wrote: > > On Wed, 18 Apr 2018, Joe Perches wrote: > > > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > > Hi julia, > > > > > > On 2018-04-15 05:19 AM, Julia Lawall wrote: > > > > On Wed, 11 Apr 2018, Joe Perches wrote: > > >

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Alexei Starovoitov
On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > address is in kernel space or not. But different architecture has > different 'PAGE_OFFSET' so this program cannot be used for all > platforms. > > This commit changes to

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Julia Lawall
On Wed, 18 Apr 2018, Joe Perches wrote: > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > Hi julia, > > > > On 2018-04-15 05:19 AM, Julia Lawall wrote: > > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > > > > > On Thu, 2018-04-12 at 08:22 +0200, Julia Lawall wrote: > > > >

Re: issues with suspend on Dell XPS 13 2-in-1

2018-04-18 Thread Pandruvada, Srinivas
On Wed, 2018-04-18 at 21:01 +, mario.limoncie...@dell.com wrote: > > > > > [...] > > > Srinivas, > > > > > > Do you know why Runtime PM is defaulting to disabled for all of > > > these > > > devices?  Is that a default kernel policy problem or a distro > > > policy > > > problem? > > > > T

linux-next: Tree for Apr 19

2018-04-18 Thread Stephen Rothwell
Hi all, Changes since 20180418: New tree: modules-fixes I have added a patch to the arm-current tree to fix build problems discovered overnight. The sound-asoc tree lost its build failure. Non-merge commits (relative to Linus' tree): 1055 1121 files changed, 36028 insertions(+),

Re: [PATCH v2 2/3] ASoC: amd: dma driver changes for BT I2S instance

2018-04-18 Thread Mukunda,Vijendar
On Thursday 19 April 2018 05:57 AM, Daniel Kurtz wrote: Hi Vijendar, On Wed, Apr 18, 2018 at 5:02 AM Vijendar Mukunda wrote: With in ACP, There are three I2S controllers can be configured/enabled ( I2S SP, I2S MICSP, I2S BT). Default enabled I2S controller instance is I2S SP. This patch pro

Re: [PATCH 01/12] iscsi_tcp: don't set a bounce limit

2018-04-18 Thread Martin K. Petersen
Christoph, > The default already is to never bounce, so the call is a no-op. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 02/12] storsvc: don't set a bounce limit

2018-04-18 Thread Martin K. Petersen
Christoph, > The default already is to never bounce, so the call is a no-op. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: tg3 crashes under high load, when using 100Mbits

2018-04-18 Thread Siva Reddy Kallam
On Sat, Apr 14, 2018 at 9:17 PM, Kai-Heng Feng wrote: > Hi Satish, > >> On 2018Mar21, at 00:57, Kai-Heng Feng wrote: >> >> Satish Baddipadige wrote: >> >>> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam >>> wrote: On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam wrote: > O

Re: [PATCH 2/2] cpufreq: brcmstb-avs-cpufreq: prefer SCMI cpufreq if supported

2018-04-18 Thread Viresh Kumar
On 18-04-18, 08:56, Markus Mayer wrote: > From: Jim Quinlan > > If the SCMI cpufreq driver is supported, we bail, so that the new > approach can be used. > > Signed-off-by: Jim Quinlan > Signed-off-by: Markus Mayer > --- > drivers/cpufreq/brcmstb-avs-cpufreq.c | 16 > 1 file

Re: [PATCH 1/2] cpufreq: brcmstb-avs-cpufreq: remove development debug support

2018-04-18 Thread Viresh Kumar
On 18-04-18, 08:56, Markus Mayer wrote: > From: Markus Mayer > > This debug code was helpful while developing the driver, but it isn't > being used for anything anymore. > > Signed-off-by: Markus Mayer > --- > drivers/cpufreq/Kconfig.arm | 10 -- > drivers/cpufreq/brcmstb-avs-cpufre

Re: [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code

2018-04-18 Thread Keerthy
On Thursday 12 April 2018 10:14 PM, santosh.shilim...@oracle.com wrote: > On 4/11/18 9:53 PM, Keerthy wrote: >> From: Dave Gerlach >> >> After an RTC+DDR cycle we lose sram context so emif pm functions present >> in sram are lost. We can check if the first byte of the original >> code in DDR con

Re: [PATCH v11 0/4] set VSESR_EL2 by user space and support NOTIFY_SEI notification

2018-04-18 Thread gengdongjiu
James, > >> I do not know when it is merge-window. About the apply version, it does not >> have limited. > > 'git fetch' Linus' tree and look at the tags. 'v4.16' lost its '-rc' suffixes, > and there isn't a 'v4.17-rc1' yet, so we are still in the merge window. > > Linus sends a message to LKM

Re: [PATCH] scsi: mptfc: fix spelling mistake in macro names

2018-04-18 Thread Martin K. Petersen
Colin, > Rename macros MPI_FCPORTPAGE0_SUPPORT_SPEED_UKNOWN and > MPI_FCPORTPAGE0_CURRENT_SPEED_UKNOWN to add in missing N in UNKNOWN Applied to 4.18/scsi-queue. Thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] clk: aspeed: Support second reset register

2018-04-18 Thread Andrew Jeffery
On Thu, 19 Apr 2018, at 12:22, Joel Stanley wrote: > The ast2500 has an additional reset register that contains resets not > present in the ast2400. This enables support for this register, and adds > the one reset line that is controlled by it. > > Signed-off-by: Joel Stanley The duplication is

[PATCH 2/2] blkcg: init root blkcg_gq under lock

2018-04-18 Thread Jiang Biao
The initializing of q->root_blkg is currently outside of queue lock and rcu, so the blkg may be destroied before the initializing, which may cause dangling/null references. On the other side, the destroys of blkg are protected by queue lock or rcu. Put the initializing inside the queue lock and rcu

[PATCH 1/2] blkcg: small fix on comment in blkcg_init_queue

2018-04-18 Thread Jiang Biao
The comment before blkg_create() in blkcg_init_queue() was moved from blkcg_activate_policy() by commit ec13b1d6f0a0457312e615, but it does not suit for the new context. Signed-off-by: Jiang Biao Signed-off-by: Wen Yang CC: Tejun Heo CC: Jens Axboe --- block/blk-cgroup.c | 6 +- 1 file ch

[PATCH] net: hns: Avoid action name truncation

2018-04-18 Thread dann frazier
When longer interface names are used, the action names exposed in /proc/interrupts and /proc/irq/* maybe truncated. For example, when using the predictable name algorithm in systemd on a HiSilicon D05, I see: ubuntu@d05-3:~$ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //' enahisic2i0-tx0

Re: [PATCH] net: don't use kvzalloc for DMA memory

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 01:38:43PM -0700, Eric Dumazet wrote: > > > On 04/18/2018 10:55 AM, Michael S. Tsirkin wrote: > > > Imagine you want to pass some data to card. > > Natural thing is to just put it in a variable and start DMA. > > However DMA API disallows stack access nowdays, > > so it's

Re: [PATCH v1 2/4] dt-bindings: clock: mediatek: add g3dsys bindings

2018-04-18 Thread Sean Wang
On Wed, 2018-04-18 at 20:18 -0700, Stephen Boyd wrote: > Quoting sean.w...@mediatek.com (2018-04-18 03:24:54) > > From: Sean Wang > > > > Add bindings to g3dsys providing necessary clock and reset control to > > Mali-450. > > > > Signed-off-by: Sean Wang > > --- > > .../bindings/arm/mediatek/m

Re: [PATCH -next] user_namespace: Replace gotos with return statements

2018-04-18 Thread Eric W. Biederman
Marcos Paulo de Souza writes: > Found while inspecting the code that handles the setgroups procfs > file. What perchance might be the advantage of introducing multiple exits into proc_setgroups_write? I strongly suspect that if you look at the generated code it will be worse after your patch.

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-18 Thread Herbert Xu
On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > > @@ -1362,7 +1373,17 @@ static int test_comp(struct crypto_comp *tfm, > goto out; > } > > - if (dlen != ctemplate[i].outlen) { > + ilen = dlen; > + dlen = COMP_B

Re: [PATCH v2] storvsc: Set up correct queue depth values for IDE devices

2018-04-18 Thread Martin K. Petersen
Long, > Can you take a look at the following patch? >> > + max_sub_channels = >> > + (num_cpus - 1) / storvsc_vcpus_per_sub_channel; What happens if num_cpus = 1? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/2] crypto: ccree: enable support for hardware keys

2018-04-18 Thread Herbert Xu
On Mon, Apr 09, 2018 at 11:42:31AM +0300, Gilad Ben-Yossef wrote: > > Please look again. The stub version of cc_is_hw_key() doing that is being > replaced in this patch. The point is that the existing mechanism was unused before and this is new code. So you can't really point to the stubbed-out f

Re: KASAN: slab-out-of-bounds Write in tcp_v6_syn_recv_sock

2018-04-18 Thread Eric Biggers
On Tue, Jan 02, 2018 at 03:58:01PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 61233580f1f33c50e159c50e24d80ffd2ba2e06b > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console ou

Re: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

2018-04-18 Thread Herbert Xu
On Thu, Apr 19, 2018 at 12:54:16AM +, Dey, Megha wrote: > > Yeah I think I misunderstood. I think what you mean is to remove mcryptd.c > completely and avoid the extra layer of indirection to call the underlying > algorithm, instead call it directly, correct? > > So currently we have 3 algor

RE: [PATCH V2 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

2018-04-18 Thread Anson Huang
Anson Huang Best Regards! > -Original Message- > From: Stephen Boyd [mailto:sb...@kernel.org] > Sent: Thursday, April 19, 2018 11:18 AM > To: Anson Huang ; Shawn Guo > > Cc: mark.rutl...@arm.com; devicet...@vger.kernel.org; > mturque...@baylibre.com; linux-...@vger.kernel.org; li...@ar

Re: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

2018-04-18 Thread Herbert Xu
On Thu, Apr 19, 2018 at 08:56:28AM +1000, NeilBrown wrote: > > I don't want to do that - I just want the documentation to be correct > (or at least, not be blatantly incorrect). The function does not sleep, > and is safe to call with spin locks held. > Do we need to spell out when it can be called

Re: [PATCH v1 2/4] dt-bindings: clock: mediatek: add g3dsys bindings

2018-04-18 Thread Stephen Boyd
Quoting sean.w...@mediatek.com (2018-04-18 03:24:54) > From: Sean Wang > > Add bindings to g3dsys providing necessary clock and reset control to > Mali-450. > > Signed-off-by: Sean Wang > --- > .../bindings/arm/mediatek/mediatek,g3dsys.txt | 30 > ++ Why isn't this un

Re: [PATCH V2 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

2018-04-18 Thread Stephen Boyd
Quoting Shawn Guo (2018-04-17 07:22:05) > On Mon, Mar 19, 2018 at 10:30:45AM +0800, Anson Huang wrote: > > On i.MX6SX SabreAuto board, there is external 24MHz clock > > source for analog clock2, add this clock source to clock tree. > > > > Signed-off-by: Anson Huang > > --- > > changes since V1:

Re: [PATCH] IB/core: Make ib_mad_client_id atomic

2018-04-18 Thread Yanjun Zhu
On 2018/4/18 22:24, Håkon Bugge wrote: Two kernel threads may get the same value for agent.hi_tid, if the agents are registered for different ports. As of now, this works, as the agent list is per port. It is however confusing and not future robust. Hence, making it atomic. Signed-off-by: Håk

Re: [PATCH] perf tools: set kernel end address properly

2018-04-18 Thread Namhyung Kim
On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > diff --git a/tools/perf/arch/arm64/util/sym-handling.c > b/tools/perf/arch/arm64/util/sym-handling.c > index 0051b1ee8450..5c4a2e208bbc 100644 > --- a/tools/perf/arch/arm64/util/sym-handling.c > +++ b/tools/perf/arch/arm64/util/sym-ha

[PATCH] clk: aspeed: Support second reset register

2018-04-18 Thread Joel Stanley
The ast2500 has an additional reset register that contains resets not present in the ast2400. This enables support for this register, and adds the one reset line that is controlled by it. Signed-off-by: Joel Stanley --- drivers/clk/clk-aspeed.c | 44 +++- incl

[PATCH -next] user_namespace: Replace gotos with return statements

2018-04-18 Thread Marcos Paulo de Souza
Found while inspecting the code that handles the setgroups procfs file. Signed-off-by: Marcos Paulo de Souza --- Tested locally setting up a new userns, and setting setgroups as deny and allow, worked as before. kernel/user_namespace.c | 20 +++- 1 file changed, 7 insertions(+),

Re: [PATCH] perf tools: set kernel end address properly

2018-04-18 Thread Namhyung Kim
On Wed, Apr 18, 2018 at 07:37:59PM -0500, Kim Phillips wrote: > On Tue, 17 Apr 2018 11:27:26 +0900 > Namhyung Kim wrote: > > On Mon, Apr 16, 2018 at 05:48:11PM -0500, Kim Phillips wrote: > > > > a perf/urgent from last week (commit 918965d4897) + this patch: > > > > > > > > $ sudo ./perf test -vv

Re: PATCH V4 0/5 nvme-pci: fixes on nvme_timeout and nvme_dev_disable

2018-04-18 Thread Ming Lei
On Thu, Apr 19, 2018 at 09:51:16AM +0800, jianchao.wang wrote: > Hi Ming > > Thanks for your kindly response. > > On 04/18/2018 11:40 PM, Ming Lei wrote: > >> Regarding to this patchset, it is mainly to fix the dependency between > >> nvme_timeout and nvme_dev_disable, as your can see: > >> nvme_

d17a1d97dc ("x86/mm/kasan: don't use vmemmap_populate() to initialize shadow"): [ 0.001000] BUG: KASAN: use-after-scope in console_unlock

2018-04-18 Thread Fengguang Wu
On Thu, Apr 19, 2018 at 10:17:57AM +0800, Fengguang Wu wrote: >Hello, > >FYI this happens in mainline kernel 4.17.0-rc1. >It at least dates back to v4.15-rc1 . > >The regression was reported before > > https://lkml.org/lkml/2017/11/30/33 > >Where the last message from Dmitry mentions that u

Re: [PATCH v2] prctl: fix compat handling for prctl

2018-04-18 Thread Andy Lutomirski
> On Apr 18, 2018, at 9:06 PM, Li Bin wrote: > > The member auxv in prctl_mm_map structure which be shared with > userspace is pointer type, but the kernel supporting COMPAT didn't > handle it. This patch fix the compat handling for prctl syscall. I would propose an alternative fix: change the ty

Re: [RFC PATCH ghak32 V2 12/13] audit: NETFILTER_PKT: record each container ID associated with a netNS

2018-04-18 Thread Paul Moore
On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > Add container ID auxiliary record(s) to NETFILTER_PKT event standalone > records. Iterate through all potential container IDs associated with a > network namespace. > > Signed-off-by: Richard Guy Briggs > --- > kernel/audit.c

Re: [PATCH] blkcg: not hold blkcg lock when deactivating policy.

2018-04-18 Thread Jens Axboe
On 4/18/18 6:54 PM, jiang.bi...@zte.com.cn wrote: by chance, did you check whether this may cause problems with bfq, being the latter not protected by the queue lock as cfq? >>> Checked the bfq code, bfq seems never used blkcg lock derectly, and >>> update of blkg in the common code is pr

Re: [RESEND PATCH] x86/boot/KASLR: Extend movable_node option for KASLR

2018-04-18 Thread Dou Liyang
Hi Ingo, Any comments about that? Now, When users want to support node hotplug with KASLR, they use 'mem=' to restrict the boot-up memory to the first node memory size. If we want to boot up some hotpluggable node, their memory can't be shown. IMO, only few machines can support physical NUMA No

[PATCH v2 3/5] dmaengine: sprd: Move DMA request mode and interrupt type into head file

2018-04-18 Thread Baolin Wang
From: Eric Long This patch will move the Spreadtrum DMA request mode and interrupt type into one head file for user to configure. Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- Changes since v1: - No updates. --- drivers/dma/sprd-dma.c | 52 +--

[PATCH v2 4/5] dmaengine: sprd: Add Spreadtrum DMA configuration

2018-04-18 Thread Baolin Wang
From: Eric Long This patch adds one 'struct sprd_dma_config' structure to save Spreadtrum DMA configuration for each DMA channel. Meanwhile we also did some optimization for sprd_dma_config() and sprd_dma_prep_dma_memcpy() to prepare to configure DMA from users. Signed-off-by: Eric Long Signed-

[PATCH v2 2/5] dmaengine: sprd: Define the DMA data width type

2018-04-18 Thread Baolin Wang
Define the DMA data width type to make code more readable. Signed-off-by: Baolin Wang --- Changes since v1: - No updates. --- drivers/dma/sprd-dma.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index dcfa417

[PATCH v2 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces

2018-04-18 Thread Baolin Wang
From: Eric Long This patch adds the 'device_config' and 'device_prep_slave_sg' interfaces for users to configure DMA. Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- Changes since v1: - The request mode and interrupt type will be passed from flags. - Add sprd_dma_get_step() to get sr

[PATCH v2 1/5] dmaengine: sprd: Define the DMA transfer step type

2018-04-18 Thread Baolin Wang
From: Eric Long Define the DMA transfer step type to make code more readable. Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- Changes since v1: - Convert enum structure to macros definition for DMA step type. --- drivers/dma/sprd-dma.c | 19 +-- 1 file changed, 13 i

Re: c9e97a1997 BUG: kernel reboot-without-warning in early-boot stage, last printk: early console in setup code

2018-04-18 Thread Pavel Tatashin
Thank you, I am studying the problem. Pavel On Wed, Apr 18, 2018 at 9:31 PM, Fengguang Wu wrote: > On Wed, Apr 18, 2018 at 06:38:25PM -0500, Dennis Zhou wrote: >>Hi, >> >>On Wed, Apr 18, 2018 at 09:55:53PM +0800, Fengguang Wu wrote: >>> >>> Hello, >>> >>> FYI here is a slightly different boot er

Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-04-18 Thread Yang, Shunyong
Hi, Gary, On Wed, 2018-04-18 at 16:51 -0400, Hook, Gary wrote: > On 4/18/2018 4:16 PM, Mehta, Sohil wrote: > > > > On Wed, 2018-04-18 at 08:31 +, Yang, Shunyong wrote: > > > > > > Maybe the original design is to call debugfs_initialized() before > > > calling debugfs_create_xxx()? > > I am u

Re: PATCH V4 0/5 nvme-pci: fixes on nvme_timeout and nvme_dev_disable

2018-04-18 Thread jianchao.wang
Hi Ming Thanks for your kindly response. On 04/18/2018 11:40 PM, Ming Lei wrote: >> Regarding to this patchset, it is mainly to fix the dependency between >> nvme_timeout and nvme_dev_disable, as your can see: >> nvme_timeout will invoke nvme_dev_disable, and nvme_dev_disable have to >> depend on

Re: [PATCH 1/6] rhashtable: remove outdated comments about grow_decision etc

2018-04-18 Thread David Miller
From: NeilBrown Date: Thu, 19 Apr 2018 09:09:05 +1000 > On Wed, Apr 18 2018, Herbert Xu wrote: > >> On Wed, Apr 18, 2018 at 04:47:01PM +1000, NeilBrown wrote: >>> grow_decision and shink_decision no longer exist, so remove >>> the remaining references to them. >>> >>> Signed-off-by: NeilBrown

  1   2   3   4   5   6   7   8   9   >