Re: [PATCH] android: binder: no outgoing transaction when thread todo has transaction

2018-08-13 Thread Martijn Coenen
Sherry, this was found by syzkaller, right? In that case, can you add the tag so the issue gets closed automatically when this gets merged? On Tue, Aug 14, 2018 at 2:28 AM, Sherry Yang wrote: > When a process dies, failed reply is sent to the sender of any transaction > queued on a dead thread'

Re: [PATCH] drivers/thermal/tegra: fix a doule free devce node

2018-08-13 Thread zhong jiang
On 2018/8/14 14:39, Daniel Lezcano wrote: > On 09/08/2018 15:40, zhong jiang wrote: >> Device node iterators will get the return node. Meawhile, It is >> also put the previous device node. An explicit put will cause >> a double put. > What about: > > Subject: drivers/thermal/tegra: Fix a double fre

[PATCH] Use default .cfg file name for RTL8723BS devices with id of OBDA8723

2018-08-13 Thread Ian W MORRISON
For RTL8723BS devices the current config file name is a composite of both the config name (rtl8723bs) and a postfix of the device-id. Given the majority of RTL8723BS devices use a device-id of OBDA8723 this simplifies the config file name to use "rtl8723bs_config.bin" as a default of for these dev

[PATCH 1/2] kconfig: report recursive dependency involving 'imply'

2018-08-13 Thread Masahiro Yamada
Currently, Kconfig does not report anything about the recursive dependency where 'imply' keywords are involved. [Test Code] config A bool "a" config B bool "b" imply A depends on A In the code above, Kconfig cannot calculate the symbol values correctl

[PATCH 2/2] kconfig: improve the recursive dependency report

2018-08-13 Thread Masahiro Yamada
This commit improves the warning messages of the recursive dependency. Currently, sym->dir_dep.expr is not checked. Hence, any dependency in property visibility is regarded as the dependency of the symbol. [Test Code 1] config A bool "a" depends on B config B b

Re: [PATCH] drivers/thermal/tegra: fix a doule free devce node

2018-08-13 Thread Daniel Lezcano
On 09/08/2018 15:40, zhong jiang wrote: > Device node iterators will get the return node. Meawhile, It is > also put the previous device node. An explicit put will cause > a double put. What about: Subject: drivers/thermal/tegra: Fix a double free on the device node "The function 'for_each_child

Re: [PATCH] mmc: Move the mmc driver init earlier

2018-08-13 Thread Feng Tang
Hi Greg, Ulf Could you help to review this? many thanks! - Feng On Thu, Aug 02, 2018 at 05:15:39PM +0800, Feng Tang wrote: > Hi Ulf, > > On Tue, Jun 12, 2018 at 12:29:50PM +0200, Ulf Hansson wrote: > > On 12 June 2018 at 10:42, Feng Tang wrote: > > > Hi Ulf, > > > > > > Thanks for the review.

Re: [PATCH v2] mm: migration: fix migration of huge PMD shared pages

2018-08-13 Thread Greg KH
On Mon, Aug 13, 2018 at 05:30:58PM -0700, Mike Kravetz wrote: > The page migration code employs try_to_unmap() to try and unmap the > source page. This is accomplished by using rmap_walk to find all > vmas where the page is mapped. This search stops when page mapcount > is zero. For shared PMD h

Re: [f2fs-dev] [PATCH v3] f2fs: fix performance issue observed with multi-thread sequential read

2018-08-13 Thread Chao Yu
On 2018/8/14 12:04, Jaegeuk Kim wrote: > On 08/14, Chao Yu wrote: >> On 2018/8/14 4:11, Jaegeuk Kim wrote: >>> On 08/13, Chao Yu wrote: Hi Jaegeuk, On 2018/8/11 2:56, Jaegeuk Kim wrote: > This reverts the commit - "b93f771 - f2fs: remove writepages lock" > to fix the drop in

[PATCH 0/2] add the Amlogic Meson PCIe controller driver.

2018-08-13 Thread Hanjie Lin
The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare PCI core. This patchset add the driver and dt-bindings of the controller. Yue Wang (2): dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller PCI: meson: add the Amlogic Meson PCIe controller dr

[PATCH 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller

2018-08-13 Thread Hanjie Lin
From: Yue Wang The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare PCI core. This patch adds documentation for the DT bindings in Meson PCIe controller. Signed-off-by: Yue Wang Signed-off-by: Hanjie Lin --- .../devicetree/bindings/pci/amlogic,meson-pcie.txt | 57 +++

[PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe controller driver

2018-08-13 Thread Hanjie Lin
From: Yue Wang The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare PCI core. This patch adds the driver support for Meson PCIe controller. Signed-off-by: Yue Wang Signed-off-by: Hanjie Lin --- drivers/pci/controller/dwc/Kconfig | 12 + drivers/pci/controller/dwc/Ma

Re: [PATCH] perf tools: Fix check-headers.sh AND list path of execution

2018-08-13 Thread Alexander Kapshuk
On Mon, Aug 13, 2018 at 9:58 PM Arnaldo Carvalho de Melo wrote: > Thanks, applied the three patches to acme/perf/core. > > - Arnaldo Thanks.

[PATCH 0/2] add the Amlogic Meson PCIe phy driver.

2018-08-13 Thread Hanjie Lin
This patcheset add the driver and dt-bindings for the Meson-PCIE-PHY controller. Yue Wang (2): dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe Phy controller PCI: meson: add the Amlogic Meson PCIe phy driver .../bindings/phy/amlogic,meson-pcie-phy.txt| 31 d

[PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe phy driver

2018-08-13 Thread Hanjie Lin
From: Yue Wang The Meson-PCIE-PHY controller supports the 5-Gbps data rate of the PCI Express Gen 2 specification and is backwardcompatible with the 2.5-Gbps Gen 1.1 specification with only inferred idle detection supported on AMLOGIC SoCs. Signed-off-by: Yue Wang Signed-off-by: Hanjie Lin ---

[PATCH 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe Phy controller

2018-08-13 Thread Hanjie Lin
From: Yue Wang The Meson-PCIE-PHY controller supports the 5-Gbps data rate of the PCI Express Gen 2 specification and is backwardcompatible with the 2.5-Gbps Gen 1.1 specification with only inferred idle detection supported on AMLOGIC SoCs. Signed-off-by: Hanjie Lin Signed-off-by: Yue Wang ---

RE: [RESEND PATCH] tee: add kernel internal client interface

2018-08-13 Thread Zengtao (B)
Hi jens: Actually, we have already used the kernel client api in our product(poplar board). Thank you for the upstream. Tested-by: Zeng Tao Regards Zengtao >-Original Message- >From: Jens Wiklander [mailto:jens.wiklan...@linaro.org] >Sent: Monday, July 09, 2018 2:16 PM >To: linux-ker

[PATCH RFC] Documentation/scheduler/sched-stats.txt: correct jiffies to ns

2018-08-13 Thread Weiping Zhang
The unit of run_daly and rq_cpu_time is ns instead of jiffies. Signed-off-by: Weiping Zhang --- Documentation/scheduler/sched-stats.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/scheduler/sched-stats.txt b/Documentation/scheduler/sched-stats.txt inde

Re: [PATCH] remoteproc/davinci: Mark error recovery as disabled

2018-08-13 Thread Sekhar Nori
Hi Bjorn, On Tuesday 14 August 2018 12:22 AM, Bjorn Andersson wrote: > On Mon 13 Aug 08:11 PDT 2018, Suman Anna wrote: > >> Hi Bjorn, >> >> On 07/23/2018 06:27 PM, Suman Anna wrote: >>> The Davinci remoteproc driver does not support error recovery at >>> present, so mark the corresponding remotep

Re: [PATCH v1 10/10] MAINTAINERS: Add entry for Qualcomm TSENS thermal drivers

2018-08-13 Thread Rajendra Nayak
On 8/9/2018 6:02 PM, Amit Kucheria wrote: Create an entry for the TSENS drivers and mark them as maintained Signed-off-by: Amit Kucheria Thanks Amit for signing up to maintain this driver. Acked-by: Rajendra Nayak --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --g

Re: [PATCH v3 07/17] x86/pci: add Hygon PCI vendor and northbridge support

2018-08-13 Thread Pu Wen
On 2018/8/14 6:14, Bjorn Helgaas wrote: On Sat, Aug 11, 2018 at 09:27:42PM +0800, Pu Wen wrote: diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 2950223..d0e98a9 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -511,6 +511,8 @@ #define PCI_DEVICE_ID_AMI

Re: [PATCH 6/9] platform: goldfish: pipe: Fail compilation if structs are too large

2018-08-13 Thread Joe Perches
On Mon, 2018-08-13 at 20:47 -0700, Roman Kiryanov wrote: > Hi, > > thank you for reviewing my patches. I decided to put BUILD_BUG_ON > close to places where it is important that these structs fit into a > memory page to give some context. And you make the reader figure out what type dev->buffers

Re: [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-13 Thread Ravi Bangoria
Hi Song, On 08/13/2018 10:42 PM, Song Liu wrote: > On Mon, Aug 13, 2018 at 6:17 AM, Oleg Nesterov wrote: >> On 08/13, Ravi Bangoria wrote: >>> But damn, process creation (exec) is trivial. We could add a new uprobe_exec() hook and avoid delayed_uprobe_install() in uprobe_mmap(). >

Re: [PATCH 2/2] rtc:rtc-ds1347: Use PTR_ERR_OR_ZERO to replace the open code

2018-08-13 Thread Baruch Siach
Hi zhong, On Mon, Aug 13, 2018 at 07:31:25PM +0800, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang Acked-by: Baruch Siach Thanks, baruch > --- > drivers/rtc/rtc-

Re: [PATCH 2/2] f2fs: tune discard speed with storage usage rate

2018-08-13 Thread Jaegeuk Kim
On 08/10, Chao Yu wrote: > Previously, discard speed was fixed mostly, and in high usage rate > device, we will speed up issuing discard, but it doesn't make sense > that in a non-full filesystem, we still issue discard with slow speed. Could you please elaborate the problem in more detail? The sp

Re: [PATCH 1/2] rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code

2018-08-13 Thread Baruch Siach
Hi zhong, On Mon, Aug 13, 2018 at 07:31:24PM +0800, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang Acked-by: Baruch Siach Thanks, baruch > --- > drivers/rtc/rtc-

[PATCH 3/5] fs/locks: allow a lock request to block other requests.

2018-08-13 Thread NeilBrown
Currently, a lock can block pending requests, but all pending requests are equal. If lots of pending requests are mutually exclusive, this means they will all be woken up and all but one will fail. This can hurt performance. So we will allow pending requests to block other requests. Only the fir

[PATCH 5/5] fs/locks: create a tree of dependent requests.

2018-08-13 Thread NeilBrown
When we find an existing lock which conflicts with a request, and the request wants to wait, we currently add the request to a list. When the lock is removed, the whole list is woken. This can cause the thundering-herd problem. To reduce the problem, we make use of the (new) fact that a pending re

[PATCH 4/5] fs/locks: change all *_conflict() functions to return bool.

2018-08-13 Thread NeilBrown
posix_locks_conflict() and flock_locks_conflict() both return int. leases_conflict() returns bool. This inconsistency will cause problems for the next patch if not fixed. So change posix_locks_conflict() and flock_locks_conflict() to return bool. Also change the locks_conflict() helper. And conv

[PATCH 0/5 v2] locks: avoid thundering-herd wake-ups

2018-08-13 Thread NeilBrown
V2, which added wake_non_conflicts() was more broken than V1 - as Bruce explained there is no transitivity in the blocking relation between locks. So this series takes a simpler approach. It still attached waiters between other waiters as necessary to ensure that: - a waiter is blocked by it's

[PATCH 2/5] fs/locks: split out __locks_wake_up_blocks().

2018-08-13 Thread NeilBrown
This functionality will be useful in future patches, so split it out from locks_wake_up_blocks(). Signed-off-by: NeilBrown --- fs/locks.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 322491e70e41..de0b9276f23d 1

[PATCH 1/5] fs/locks: rename some lists and pointers.

2018-08-13 Thread NeilBrown
struct file lock contains an 'fl_next' pointer which is used to point to the lock that this request is blocked waiting for. So rename it to fl_blocker. The fl_blocked list_head in an active lock is the head of a list of blocked requests. In a request it is a node in that list. These are two dist

Re: [PATCH 6/9] platform: goldfish: pipe: Fail compilation if structs are too large

2018-08-13 Thread Roman Kiryanov
Hi, thank you for reviewing my patches. I decided to put BUILD_BUG_ON close to places where it is important that these structs fit into a memory page to give some context. Regards, Roman. On Mon, Aug 13, 2018 at 6:48 PM Joe Perches wrote: > > On Mon, 2018-08-13 at 16:38 -0700, r...@google.com wr

Re: [PATCH 8/9] platform: goldfish: pipe: Replace pr_ with dev_ for logging

2018-08-13 Thread kbuild test robot
Hi Roman, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18 next-20180813] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [1/2] dt-bindings: phy: Add stingray usb phy documentation

2018-08-13 Thread Srinath Mannam
Hi JC, On Tue, Aug 14, 2018 at 7:24 AM, Jayachandran C wrote: > Hi Srinath, Ray, > > On Fri, Jul 07, 2017 at 06:37:04PM +0530, Srinath Mannam wrote: >> Add DT binding document for stingray usb phy driver. >> >> Signed-off-by: Srinath Mannam >> Reviewed-by: Ray Jui >> Acked-by: Rob Herring > >

Re: [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function

2018-08-13 Thread Masahiro Yamada
2018-08-14 2:20 GMT+09:00 Sam Ravnborg : > On Tue, Aug 14, 2018 at 01:48:38AM +0900, Masahiro Yamada wrote: >> This function is unused since commit 104daea149c4 ("kconfig: reference >> environment variables directly and remove 'option env='"). >> >> Signed-off-by: Masahiro Yamada > > Both patches

Re: [PATCH] kconfig: fix the rule of mainmenu_stmt symbol

2018-08-13 Thread Masahiro Yamada
2018-08-09 15:47 GMT+09:00 Masahiro Yamada : > The rule of mainmenu_stmt does not have debug print of zconf_lineno(), > but if it had, it would print a wrong line number for the same reason > as commit b2d00d7c61c8 ("kconfig: fix line numbers for if-entries in > menu tree"). > > The mainmenu_stmt d

Re: linux-next: Signed-off-by missing for commit in the kbuild tree

2018-08-13 Thread Masahiro Yamada
Stephen, 2018-08-14 6:33 GMT+09:00 Stephen Rothwell : > Hi Masahiro, > > Commit > > bd714f5f14e0 ("Coccinelle: doubletest: reduce side effect false positives") > > is missing a Signed-off-by from its committer. Thanks for catching this. I will fix it. > -- > Cheers, > Stephen Rothwell --

Re: [PATCH] Support mksh as /bin/sh.

2018-08-13 Thread Masahiro Yamada
2018-08-14 7:32 GMT+09:00 Kees Cook : > On Mon, Aug 13, 2018 at 3:14 AM, wrote: >> From: Arkadiusz Miśkiewicz >> >> mksh needs space between ! and ( to work properly. Otherwise this >> happens: >> >> + make oldconfig >> scripts/kconfig/conf --oldconfig Kconfig >> ./scripts/clang-version.sh[18]:

Re: [PATCH v2 2/4] dt-bindings: soc: amlogic: add meson-canvas documentation

2018-08-13 Thread Maxime Jourdan
2018-08-13 21:07 GMT+02:00 Rob Herring : > On Wed, Aug 08, 2018 at 12:00:09AM +0200, Maxime Jourdan wrote: >> DT bindings doc for amlogic,meson-canvas >> >> Signed-off-by: Maxime Jourdan >> --- >> .../soc/amlogic/amlogic,meson-canvas.txt | 36 +++ >> 1 file changed, 36 insert

Re: [PATCH] gcc-plugins: require GCC

2018-08-13 Thread Masahiro Yamada
2018-08-14 6:29 GMT+09:00 Stefan Agner : > On 13.08.2018 22:18, Kees Cook wrote: >> On Mon, Aug 13, 2018 at 1:10 PM, Kees Cook wrote: >>> On Mon, Aug 13, 2018 at 12:38 AM, Masahiro Yamada >>> wrote: 2018-08-11 18:48 GMT+09:00 Stefan Agner : > Unsurprisingly GCC plugins require GCC as a c

Re: [PATCH] md/bcache: Remove NULL check.

2018-08-13 Thread Sean Fu
On Mon, Aug 13, 2018 at 06:00:11PM +0800, Coly Li wrote: > On 2018/8/13 5:38 PM, Sean Fu wrote: > > Remove unnessesary NULL check before kmem_cache_destroy() in > > drivers/md/bcache/request.c > > > > Signed-off-by: Sean Fu > > Hi Sean, > > A same change is posted in my previous checkpatch fixe

[PATCH] arm/mach-at91/pm: Do not double put the device node

2018-08-13 Thread zhong jiang
Device node iterators put the previous value of the index variable, so an explicit put causes a double put. I detect the issue with the help of Coccinelle. Signed-off-by: zhong jiang --- arch/arm/mach-at91/pm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/arm/mac

Re: [PATCH 1/3] arm64: implement ftrace with regs

2018-08-13 Thread Steven Rostedt
On Mon, 13 Aug 2018 11:54:06 +0100 Julien Thierry wrote: > > --- a/arch/arm64/Makefile > > +++ b/arch/arm64/Makefile > > @@ -78,6 +78,15 @@ ifeq ($(CONFIG_ARM64_MODULE_PLTS),y) > > KBUILD_LDFLAGS_MODULE += -T $(srctree)/arch/arm64/kernel/module.lds > > endif > > > > +ifdef CONFIG_DYNAM

Re: [1/2] dt-bindings: phy: Add stingray usb phy documentation

2018-08-13 Thread Jayachandran C
Hi Srinath, Ray, On Fri, Jul 07, 2017 at 06:37:04PM +0530, Srinath Mannam wrote: > Add DT binding document for stingray usb phy driver. > > Signed-off-by: Srinath Mannam > Reviewed-by: Ray Jui > Acked-by: Rob Herring The Broadcom Vulcan chip (now Cavium ThunderX2) uses the same USB PHY from w

Re: [PATCH 6/9] platform: goldfish: pipe: Fail compilation if structs are too large

2018-08-13 Thread Joe Perches
On Mon, 2018-08-13 at 16:38 -0700, r...@google.com wrote: > From: Roman Kiryanov > > Since the driver provides no workaround prevent in cases if structs do > no fit into a memory page, it is better to fail complation to find about > the issue earlt instead of returning errors at runtime. Minor e

Re: [PATCH 1/2] perf tools: Make check-headers.sh check based on kernel dir

2018-08-13 Thread Michael Ellerman
Jiri Olsa writes: > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh > index ea48aa6f8d19..9d466e853aec 100755 > --- a/tools/perf/check-headers.sh > +++ b/tools/perf/check-headers.sh > @@ -88,6 +88,8 @@ check () { > # differences. > test -d ../../include || exit 0 > > +pu

Re: [PATCH 1/9] platform: goldfish: pipe: Fix comments to fit 80 columns

2018-08-13 Thread Joe Perches
On Mon, 2018-08-13 at 16:38 -0700, r...@google.com wrote: > From: Roman Kiryanov > > Some comment lines are longer than 80 symbols. [] > diff --git a/drivers/platform/goldfish/goldfish_pipe.c > b/drivers/platform/goldfish/goldfish_pipe.c [] > @@ -84,7 +84,10 @@ enum PipePollFlags { > PIPE_

Re: [PATCH 8/9] platform: goldfish: pipe: Replace pr_ with dev_ for logging

2018-08-13 Thread Joe Perches
On Mon, 2018-08-13 at 16:38 -0700, r...@google.com wrote: > dev_ is preferred if struct device is available. [] > diff --git a/drivers/platform/goldfish/goldfish_pipe.c > b/drivers/platform/goldfish/goldfish_pipe.c [] > @@ -384,6 +384,7 @@ static ssize_t goldfish_pipe_read_write(struct file *filp,

[PATCH] get_maintainer: Allow option --mpath to read all files in

2018-08-13 Thread Joe Perches
There is an external use case for multiple private MAINTAINER style files in a separate directory. Allow it. --mpath has a default of "./MAINTAINERS". The value entered can be either a file or a directory. The behaviors are now: --mpath Read only the specific file as file --mpath

Re: [PATCH] zsmalloc: fix linking bug in init_zspage

2018-08-13 Thread Sergey Senozhatsky
Hi Minchan, On (08/14/18 09:24), Minchan Kim wrote: > > Any thoughts? > > If we want a refactoring, I'm not against but description said it tiggered > BUG_ON on zs_map_object rarely. That means it should be stable material > and need more description to understand. Please be more specific with > s

Re: [PATCH] fsi: ast: select GENERIC_ALLOCATOR

2018-08-13 Thread Benjamin Herrenschmidt
On Tue, 2018-08-14 at 00:37 +0200, Arnd Bergmann wrote: > In randconfig builds without CONFIG_GENERIC_ALLOCATOR, this driver > fails to link: > > ERROR: "gen_pool_alloc_algo" [drivers/fsi/fsi-master-ast-cf.ko] undefined! > ERROR: "gen_pool_fixed_alloc" [drivers/fsi/fsi-master-ast-cf.ko] undefined!

[PATCH v2] mm: migration: fix migration of huge PMD shared pages

2018-08-13 Thread Mike Kravetz
The page migration code employs try_to_unmap() to try and unmap the source page. This is accomplished by using rmap_walk to find all vmas where the page is mapped. This search stops when page mapcount is zero. For shared PMD huge pages, the page map count is always 1 no matter the number of mapp

[PATCH] android: binder: no outgoing transaction when thread todo has transaction

2018-08-13 Thread Sherry Yang
When a process dies, failed reply is sent to the sender of any transaction queued on a dead thread's todo list. The sender asserts that the received failed reply corresponds to the head of the transaction stack. This assert can fail if the dead thread is allowed to send outgoing transactions when t

Re: [PATCH] zsmalloc: fix linking bug in init_zspage

2018-08-13 Thread Minchan Kim
Hi Sergey, On Mon, Aug 13, 2018 at 07:55:36PM +0900, Sergey Senozhatsky wrote: > On (08/13/18 15:05), Minchan Kim wrote: > > > From: zhouxianrong > > > > > > The last partial object in last subpage of zspage should not be linked > > > in allocation list. Otherwise it could trigger BUG_ON explici

Re: [PATCH v8 1/6] Uprobes: Simplify uprobe_register() body

2018-08-13 Thread Steven Rostedt
On Mon, 13 Aug 2018 01:56:12 -0700 Srikar Dronamraju wrote: > * Ravi Bangoria [2018-08-09 09:48:51]: > > > Simplify uprobe_register() function body and let __uprobe_register() > > handle everything. Also move dependency functions around to fix build > > failures. > > > > One nit: > s/to fix

Re: [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-13 Thread Steven Rostedt
On Mon, 13 Aug 2018 20:01:41 -0400 Steven Rostedt wrote: > On Fri, 10 Aug 2018 23:14:01 -0700 > Song Liu wrote: > > > On Fri, Aug 10, 2018 at 12:58 PM, Steven Rostedt > > wrote: > > > On Thu, 9 Aug 2018 16:38:28 +0200 > > > Oleg Nesterov wrote: > > > > > >> I need to read this (hopeful

Re: [RFC] vruntime updated incorrectly when rt_mutex boots prio?

2018-08-13 Thread Steve Muckle
On 08/07/2018 10:40 AM, 'Todd Kjos' via kernel-team wrote: This issue was discovered on a 4.9-based android device, but the relevant mainline code appears to be the same. The symptom is that over time the some workloads become sluggish resulting in missed frames or sluggishness. It appears to be

Re: [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-13 Thread Steven Rostedt
On Mon, 13 Aug 2018 13:50:19 +0200 Oleg Nesterov wrote: > On 08/13, Ravi Bangoria wrote: > > > > On 08/11/2018 01:27 PM, Song Liu wrote: > > >> + > > >> +static void delayed_uprobe_delete(struct delayed_uprobe *du) > > >> +{ > > >> + if (!du) > > >> + return; > > > Do we r

Re: [PATCH] mm, slub: restore the original intention of prefetch_freepointer()

2018-08-13 Thread Kees Cook
On Thu, Aug 9, 2018 at 1:52 AM, Vlastimil Babka wrote: > In SLUB, prefetch_freepointer() is used when allocating an object from cache's > freelist, to make sure the next object in the list is cache-hot, since it's > probable it will be allocated soon. > > Commit 2482ddec670f ("mm: add SLUB free li

Re: [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-13 Thread Steven Rostedt
On Fri, 10 Aug 2018 23:14:01 -0700 Song Liu wrote: > On Fri, Aug 10, 2018 at 12:58 PM, Steven Rostedt wrote: > > On Thu, 9 Aug 2018 16:38:28 +0200 > > Oleg Nesterov wrote: > > > >> I need to read this (hopefully final) version carefully. I'll try to do > >> this before next Monday. > >> > >

Re: [PATCH] bitfield: avoid gcc-8 -Wint-in-bool-context warning

2018-08-13 Thread Masahiro Yamada
2018-08-14 7:09 GMT+09:00 Arnd Bergmann : > Passing an enum into FIELD_GET() produces a long but harmless warning on > newer compilers: > > from include/linux/linkage.h:7, > from include/linux/kernel.h:7, > from include/linux/skbuff.h:17, >

Re: [PATCH v2 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-08-13 Thread Doug Anderson
Hi, On Wed, Jul 25, 2018 at 3:28 PM, Stephen Boyd wrote: > The interrupt controller hardware in this pin controller has two status > enable bits. The first "normal" status enable bit enables or disables > the summary interrupt line being raised when a gpio interrupt triggers > and the "raw" statu

[PATCH 9/9] platform: goldfish: pipe: Add a blank line to separate struct members

2018-08-13 Thread rkir
From: Roman Kiryanov To improve readability and to be consistent with other struct members. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/gol

[PATCH 4/9] platform: goldfish: pipe: Separate the host interface to a separate header

2018-08-13 Thread rkir
From: Roman Kiryanov These are several enums that must kept in sync with the host side. This change explicitly separates them into a dedicated header file. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 69 +-- .../platform/goldfish/goldfish_pipe_qem

[PATCH 5/9] platform: goldfish: pipe: Update the comment for GFP_ATOMIC

2018-08-13 Thread rkir
From: Roman Kiryanov Provide an explanation why GFP_ATOMIC is needed to prevent changing it to other values. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pi

[PATCH 7/9] platform: goldfish: pipe: Replace an array of 1 with a variable

2018-08-13 Thread rkir
From: Roman Kiryanov There is no reason to have an array of 1. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 28 +++ 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform

[PATCH 6/9] platform: goldfish: pipe: Fail compilation if structs are too large

2018-08-13 Thread rkir
From: Roman Kiryanov Since the driver provides no workaround prevent in cases if structs do no fit into a memory page, it is better to fail complation to find about the issue earlt instead of returning errors at runtime. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe

[PATCH 8/9] platform: goldfish: pipe: Replace pr_ with dev_ for logging

2018-08-13 Thread rkir
From: Roman Kiryanov dev_ is preferred if struct device is available. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/gold

[PATCH 2/9] platform: goldfish: pipe: Update license

2018-08-13 Thread rkir
From: Roman Kiryanov goldfish_pipe is distributed under GPL v2. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe

[PATCH 1/9] platform: goldfish: pipe: Fix comments to fit 80 columns

2018-08-13 Thread rkir
From: Roman Kiryanov Some comment lines are longer than 80 symbols. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish

[PATCH 3/9] platform: goldfish: pipe: Fix checkpatch warning

2018-08-13 Thread rkir
From: Roman Kiryanov Function's opening brace has to be at the beginning of the next line. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/plat

Re: [PATCH] perf/x86/amd/uncore: Set ThreadMask and SliceMask for L3 Cache perf events

2018-08-13 Thread kbuild test robot
Hi Janakarajan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/perf/core] [also build test WARNING on v4.18 next-20180813] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH] mm: migration: fix migration of huge PMD shared pages

2018-08-13 Thread Mike Kravetz
On 08/13/2018 03:58 AM, Kirill A. Shutemov wrote: > On Sun, Aug 12, 2018 at 08:41:08PM -0700, Mike Kravetz wrote: >> The page migration code employs try_to_unmap() to try and unmap the >> source page. This is accomplished by using rmap_walk to find all >> vmas where the page is mapped. This searc

Re: [LKP] ca90800a91 [ 3.251519] WARNING: CPU: 0 PID: 1 at mm/page_alloc.c:4061 __alloc_pages_nodemask

2018-08-13 Thread Kees Cook
Hi, This is the expected output when running the lib/test_overflow.c tests. Thanks, -Kees On Sun, Aug 12, 2018 at 5:13 PM, kernel test robot wrote: > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/tor

Re: [PATCH] ARM: dts: imx7ulp: update pinfunc header file

2018-08-13 Thread Rob Herring
On Tue, Jul 31, 2018 at 06:10:35AM +0800, Anson Huang wrote: > The i.MX7ULP B0 chip has some pin changes for USB and VIU > module, update pinfunc header file accordingly. > > Signed-off-by: Anson Huang > --- > arch/arm/boot/dts/imx7ulp-pinfunc.h | 16 +++- > 1 file changed, 15 insert

Re: [PATCH] cpumask: provide a dummy cpumask_next_wrap

2018-08-13 Thread David Miller
From: Arnd Bergmann Date: Mon, 13 Aug 2018 23:55:16 +0200 > The virtio_net driver has become the first one to call cpumask_next_wrap() > even if CONFIG_SMP is disabled, leading to a build error: > > drivers/net/virtio_net.c: In function 'virtnet_set_affinity': > drivers/net/virtio_net.c:1916:10:

Re: [GIT PULL] security subsystem: general update for v4.19

2018-08-13 Thread James Morris
On Tue, 14 Aug 2018, James Morris wrote: > I'll followup with updates for Smack and TPM once this is merged. As well as an update for the Integrity subsystem. -- James Morris

[GIT PULL] security subsystem: general update for v4.19

2018-08-13 Thread James Morris
Please pull these general updates for v4.19. Summary: - kstrdup() return value fix from Eric Biggers - Add new security_load_data hook to differentiate security checking of kernel-loaded binaries in the case of there being no associated file descriptor, from Mimi Zohar. - Add ability to IMA t

Re: [PATCH] mailbox: mediatek: add module license

2018-08-13 Thread Randy Dunlap
On 08/13/2018 02:44 PM, Arnd Bergmann wrote: > The missing license tag in the new driver causes a compile-time warning, > and may result in the module being unusable if it calls EXPORT_SYMBOL_GPL() > functions: > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/mailbox/mtk-cmdq-mailbox.o

[PATCH] fsi: ast: select GENERIC_ALLOCATOR

2018-08-13 Thread Arnd Bergmann
In randconfig builds without CONFIG_GENERIC_ALLOCATOR, this driver fails to link: ERROR: "gen_pool_alloc_algo" [drivers/fsi/fsi-master-ast-cf.ko] undefined! ERROR: "gen_pool_fixed_alloc" [drivers/fsi/fsi-master-ast-cf.ko] undefined! ERROR: "of_gen_pool_get" [drivers/fsi/fsi-master-ast-cf.ko] undef

Re: [PATCH] perf/x86: Add __ro_after_init annotations

2018-08-13 Thread Kees Cook
On Fri, Aug 10, 2018 at 8:43 AM, Zubin Mithra wrote: > x86_pmu_{format,events,attr,caps}_group is written to in > init_hw_perf_events and not modified after. This makes them suitable > candidates for annotating as __ro_after_init. > > Signed-off-by: Zubin Mithra Reviewed-by: Kees Cook -Kees >

[PATCH v2] ASoC: wm9712: fix replace codec to component

2018-08-13 Thread Marcel Ziswiler
From: Marcel Ziswiler Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component") "wm9712-codec" got renamed to "wm9712-component", however, this change never got propagated down to the actual board/platform drivers. E.g. on Colibri T20 this lead to the following spew upon boot with so

Re: [PATCH] bluetooth: hci_h5: avoid unused variable warnings

2018-08-13 Thread Kees Cook
On Mon, Aug 13, 2018 at 3:04 PM, Arnd Bergmann wrote: > When CONFIG_BT_HCIUART_RTL is disabled, the hci_h5 driver produces a build > warning because of an incorrect set of #ifdef guards: > > drivers/bluetooth/hci_h5.c:920:22: error: 'rtl_vnd' defined but not used > [-Werror=unused-variable] > > R

[PATCH v3 6/7] mtd: rawnand: ams-delta: Simplify pointer resolution on read/write

2018-08-13 Thread Janusz Krzysztofik
Simplify data read/write sub-functions by making them accept private structure pointer instead of resolving it again from mtd_info. Signed-off-by: Janusz Krzysztofik Reviewed-by: Boris Brezillon --- drivers/mtd/nand/raw/ams-delta.c | 30 +++--- 1 file changed, 15 inserti

[PATCH v3 3/7] ARM: OMAP1: ams-delta: Provide GPIO lookup table for NAND data port

2018-08-13 Thread Janusz Krzysztofik
Data port used by Amstrad Delta NAND driver is actually an OMAP MPUIO device, already under control of gpio-omap driver. The NAND driver gets access to the port by ioremapping it and performs read/write operations. That is done without any proteciton from other users legally manipulating the port

[PATCH v3 4/7] mtd: rawnand: ams-delta: request data port GPIO resource

2018-08-13 Thread Janusz Krzysztofik
Data port used by the driver is actually an OMAP MPUIO device, already under control of gpio-omap driver. For that reason we used to not request the memory region of the port as that would fail because the region is already busy. Despite that, we are still accessing the port by just ioremapping i

[PATCH v3 7/7] mtd: rawnand: ams-delta: use GPIO API for data I/O

2018-08-13 Thread Janusz Krzysztofik
Don't readw()/writew() data directly from/to GPIO port which is under control of gpio-omap driver, use GPIO API instead. Degrade of performance on Amstrad Delta is significant, can be recognized as a regression, that's why I'm still submitting this patch as RFC. The driver should work with any 8+

[PATCH v3 2/7] mtd: rawnand: ams-delta: Use private structure

2018-08-13 Thread Janusz Krzysztofik
Introduce a driver private structure and allocate it on device probe. Use it for storing nand_chip structure, GPIO descriptors prevoiusly stored in static variables as well as io_base pointer previously passed as nand controller data or platform driver data. Subsequent patches may populate the str

[PATCH v3 0/7] mtd: rawnand: ams-delta: Use GPIO API for data I/O

2018-08-13 Thread Janusz Krzysztofik
Implement the idea suggested by Artem Bityutskiy and Tony Lindgren, described in commit b027274d2e3a ("mtd: ams-delta: fix request_mem_region() failure"). Use pure GPIO API as suggested by Boris Brezillon. Janusz Krzysztofik (7): mtd: rawnand: ams-delta: show parent device in sysfs

[PATCH v3 5/7] mtd: rawnand: ams-delta: Set port direction when needed

2018-08-13 Thread Janusz Krzysztofik
In its current shape, the driver sets data port direction before each byte read/write operation, even during multi-byte transfers. Improve performance of the driver by setting the port direction only when needed. This optimisation will become particularly important as soon as planned conversion o

[PATCH v3 1/7] mtd: rawnand: ams-delta: show parent device in sysfs

2018-08-13 Thread Janusz Krzysztofik
Fix a bug where parent device symlinks aren't shown in sysfs. While at it, make use of the default owner set by mtdcore. Signed-off-by: Janusz Krzysztofik Reviewed-by: Boris Brezillon --- drivers/mtd/nand/raw/ams-delta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

Re: [PATCH] Support mksh as /bin/sh.

2018-08-13 Thread Kees Cook
On Mon, Aug 13, 2018 at 3:14 AM, wrote: > From: Arkadiusz Miśkiewicz > > mksh needs space between ! and ( to work properly. Otherwise this > happens: > > + make oldconfig > scripts/kconfig/conf --oldconfig Kconfig > ./scripts/clang-version.sh[18]: COPYING: not found > printf: ‘__clang_major__’:

Re: [PATCH v3 07/17] x86/pci: add Hygon PCI vendor and northbridge support

2018-08-13 Thread Bjorn Helgaas
On Sat, Aug 11, 2018 at 09:27:42PM +0800, Pu Wen wrote: > As Hygon register its PCI Vendor ID as a new one "0x1d94", so add a new > definition PCI_VENDOR_ID_HYGON in include/linux/pci_ids.h. > > Also Hygon PCI Device ID(0x1450/0x1463/0x1464) for Host bridge is added > to amd_nb.c. And it need to d

[PATCH] bitfield: avoid gcc-8 -Wint-in-bool-context warning

2018-08-13 Thread Arnd Bergmann
Passing an enum into FIELD_GET() produces a long but harmless warning on newer compilers: from include/linux/linkage.h:7, from include/linux/kernel.h:7, from include/linux/skbuff.h:17, from include/linux/if_ether.h:23,

Re: [PATCH] cpumask: provide a dummy cpumask_next_wrap

2018-08-13 Thread Arnd Bergmann
On Tue, Aug 14, 2018 at 12:02 AM Caleb Raitto wrote: > > On Mon, Aug 13, 2018 at 2:55 PM Arnd Bergmann wrote: > > > > The virtio_net driver has become the first one to call cpumask_next_wrap() > > even if CONFIG_SMP is disabled, leading to a build error: > > > > drivers/net/virtio_net.c: In funct

[PATCH] bluetooth: hci_h5: avoid unused variable warnings

2018-08-13 Thread Arnd Bergmann
When CONFIG_BT_HCIUART_RTL is disabled, the hci_h5 driver produces a build warning because of an incorrect set of #ifdef guards: drivers/bluetooth/hci_h5.c:920:22: error: 'rtl_vnd' defined but not used [-Werror=unused-variable] Replacing the #ifdef with an IS_ENABLED() check shuts up the error a

Re: [PATCH] cpumask: provide a dummy cpumask_next_wrap

2018-08-13 Thread Caleb Raitto
On Mon, Aug 13, 2018 at 2:55 PM Arnd Bergmann wrote: > > The virtio_net driver has become the first one to call cpumask_next_wrap() > even if CONFIG_SMP is disabled, leading to a build error: > > drivers/net/virtio_net.c: In function 'virtnet_set_affinity': > drivers/net/virtio_net.c:1916:10: erro

[PATCH] cpumask: provide a dummy cpumask_next_wrap

2018-08-13 Thread Arnd Bergmann
The virtio_net driver has become the first one to call cpumask_next_wrap() even if CONFIG_SMP is disabled, leading to a build error: drivers/net/virtio_net.c: In function 'virtnet_set_affinity': drivers/net/virtio_net.c:1916:10: error: implicit declaration of function 'cpumask_next_wrap'; did you

[PATCH v9 03/22] s390/zcrypt: Show load of cards and queues in sysfs

2018-08-13 Thread Tony Krowiak
From: Harald Freudenberger Show the current load value of cards and queues in sysfs. The load value for each card and queue is maintained by the zcrypt device driver for dispatching and load balancing requests over the available devices. This patch provides the load value to userspace via a new

  1   2   3   4   >