Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-05 Thread Joe Perches
On Tue, 2018-11-06 at 08:49 +0100, Rafael J. Wysocki wrote: > On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > > > > Signed-off-by: Bo YU > > First off, IMO, you should not change the existing code just in order > to make checkpatch

Re: [PATCH] driver core: fix comments for device_block_probing()

2018-11-05 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 8:41 AM Randy Dunlap wrote: > > From: Randy Dunlap > > Correct function name and spelling/typo for device_block_probing() > in drivers/base/dd.c. > > Signed-off-by: Randy Dunlap > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" Reviewed-by: Rafael J. Wysocki > --- >

Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-05 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > > Signed-off-by: Bo YU First off, IMO, you should not change the existing code just in order to make checkpatch happy about it. That alone is not a good enough reason for modifying it

Re: [PATCH] z3fold: fix wrong handling of headless pages

2018-11-05 Thread Vitaly Wool
Hi Jongseok, Den fre 6 juli 2018 kl 07:11 skrev Jongseok Kim : > > During the processing of headless pages in z3fold_reclaim_page(), > there was a problem that the zhdr pointed to another page > or a page was already released in z3fold_free(). So, the wrong page > is encoded in headless, or test_b

Re: [Patch v4 17/18] x86/speculation: Update SPEC_CTRL MSRs of remote CPUs

2018-11-05 Thread Thomas Gleixner
Tim, On Mon, 5 Nov 2018, Tim Chen wrote: > > Aside of the condition being pointless in that case, that issues an IPI > > whether the task is running or not. So this allows a task to issue tons of > > async IPIs disturbing others by toggling the control. > > I'm not crazy about sending IPIs too.

[PATCH v2] mm: Create the new vm_fault_t type

2018-11-05 Thread Souptick Joarder
Page fault handlers are supposed to return VM_FAULT codes, but some drivers/file systems mistakenly return error numbers. Now that all drivers/file systems have been converted to use the vm_fault_t return type, change the type definition to no longer be compatible with 'int'. By making it an unsign

[PATCH] MAINTAINERS: add maintainer for C-SKY drivers

2018-11-05 Thread Guo Ren
There are two intc drivers and two clocksource drivers, also include related dt-bindings' documentations. Signed-off-by: Guo Ren --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f485597..fb7286a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH v3] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-05 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface in olpc_dcon_xo_1.c. --- Changes in v3: - Resolve a few compilation errors. Changes in v2: - Resolve a few compilation errors. - Add a level of indirection to read and write gpios. Signed-off-by: Nishad Kamdar --- d

[PATCH] driver core: fix comments for device_block_probing()

2018-11-05 Thread Randy Dunlap
From: Randy Dunlap Correct function name and spelling/typo for device_block_probing() in drivers/base/dd.c. Signed-off-by: Randy Dunlap Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" --- drivers/base/dd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- lnx-420-rc1.orig/driv

Re: [PATCH AUTOSEL 4.19 118/146] MD: fix invalid stored role for a disk

2018-11-05 Thread Jack Wang
Sasha Levin 于2018年11月1日周四 上午12:45写道: > > From: Shaohua Li > > [ Upstream commit d595567dc4f0c1d90685ec1e2e296e2cad2643ac ] > > If we change the number of array's device after device is removed from array, > then add the device back to array, we can see that device is added as active > role instea

Re: [PATCH v2 00/17] thermal: enable+check sensor after its setup is finished

2018-11-05 Thread Zhang Rui
Hi, Bartlomiej, On 一, 2018-11-05 at 17:35 +0100, Bartlomiej Zolnierkiewicz wrote: > On 11/05/2018 04:04 AM, Zhang Rui wrote: > > > > Hi, Bartlomiej, > Hi Rui, > > > > > Interesting, I'm about to bring this issue to Linux Plumber > > Conference > > this year for discussion, and I'm also proposin

Re: BUG: aio/direct-io data corruption in 4.7

2018-11-05 Thread Jack Wang
Gregory Shapiro 于2018年11月5日周一 下午4:19写道: > > Hello, my name is Gregory Shapiro and I am a newbie on this list. > I recently encountered data corruption as I got a kernel to > acknowledge write ("io_getevents" system call with a correct number of > bytes) but undergoing write to disk failed. > After

Re: linux-next: build warning after merge of the gpio tree

2018-11-05 Thread Uwe Kleine-König
Hi Linus, On Tue, Nov 06, 2018 at 12:15:02PM +1100, Stephen Rothwell wrote: > After merging the gpio tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/gpio/gpiolib.c:1514:12: warning: 'devm_gpio_chip_match' defined but > not used [-Wunused-function] >

[PATCH] arch/arm64 : fix error in dump_backtrace

2018-11-05 Thread Zhaoyang Huang
From: Zhaoyang Huang In some cases, the instruction of "bl foo1" will be the last one of the foo2[1], which will cause the lr be the first instruction of the adjacent foo3[2]. Hence, the backtrace will show the weird result as bellow[3]. The patch will fix it by miner 4 of the lr when dump_backtr

[PATCH v2 2/2] nvme: add quirk to not call disable function when suspending

2018-11-05 Thread AceLan Kao
Call nvme_dev_disable() function leads to the power consumption goes up to 2.2 Watt during suspend-to-idle, and from SK hynix FE, they suggest us to use its own APST feature to do the power management during s2idle. After D3 is diabled and nvme_dev_disable() is not called while suspending, the powe

[PATCH v2 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-05 Thread AceLan Kao
It leads to the power consumption raises to 2.2W during s2idle, while it consumes less than 1W during long idle if put SK hynix nvme to D3 and then enter s2idle. >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its own APST feature to do the power management. To leverage its APST feat

Re: [PATCH 2/2] nvme: add quirk to not call disable function when suspending

2018-11-05 Thread Christoph Hellwig
On Tue, Nov 06, 2018 at 10:04:02AM +0800, AceLan Kao wrote: > Call nvme_dev_disable() function leads to the power consumption goes > up to 2.2 Watt during suspend-to-idle, and from SK hynix FE, they > suggest us to use its own APST feature to do the power management during > s2idle. > After D3 is d

Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-05 Thread Christoph Hellwig
On Tue, Nov 06, 2018 at 10:04:01AM +0800, AceLan Kao wrote: > It leads to the power consumption raises to 2.2W during s2idle, while > it consumes less than 1W during long idle if put SK hynix nvme to D3 > and then enter s2idle. > >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its ow

Re: [RFC 0/2] RISC-V: A proposal to add vendor-specific code

2018-11-05 Thread Christoph Hellwig
On Mon, Nov 05, 2018 at 02:51:33PM +0100, Arnd Bergmann wrote: > With the stricter policy you suggest, we'd loose the ability to support > some extensions that might be common: > > - an extension for user space that adds new registers that must be > saved and restored on a task switch, e.g. FPU,

Re: [RFC 0/2] RISC-V: A proposal to add vendor-specific code

2018-11-05 Thread Christoph Hellwig
On Mon, Nov 05, 2018 at 09:39:29PM +0200, Nick Kossifidis wrote: > a) By directly modifying your custom CSRs, it means that we will need > compiler support in order to compile a kernel with your code in it. This > will break CI systems and will introduce various issues on testing and > reviewing yo

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Michal Simek
On 05. 11. 18 21:43, Borislav Petkov wrote: > On Mon, Nov 05, 2018 at 12:38:05PM -0800, Olof Johansson wrote: >> Yeah, that's the way we've been trying to do for various subsystems >> and it's been working pretty well. Of course, if there's need to >> coordinate more closely for something in the fu

RE: [PATCH 5/6] pci: layerscape: Add the EP mode support.

2018-11-05 Thread Xiaowei Bao
Hi Kishon, -Original Message- From: Kishon Vijay Abraham I Sent: 2018年11月6日 14:07 To: Xiaowei Bao ; bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo Li ; lorenzo.pieral...@arm.com; a...@arndb.de; gre...@linuxfoundation.org; M.h. Lian ; Mingkai Hu

[PATCH v1 02/11] clk: mediatek: add new member to mtk_pll_data

2018-11-05 Thread Weiyi Lu
From: Owen Chen 1. pcwibits: The integer bits of pcw for plls is extend to 8 bits, add a variable to indicate this change and backward-compatible. 2. fmin: The pll freqency lower-bound is vary from 1GMhz to 1.5Ghz, add a variable to indicate platform-dependent. Signed-off-by: Owen Chen

[PATCH v1 03/11] clk: mediatek: Disable tuner_en before change PLL rate

2018-11-05 Thread Weiyi Lu
From: Owen Chen PLLs with tuner_en bit, such as APLL1, need to disable tuner_en before apply new frequency settings, or the new frequency settings (pcw) will not be applied. The tuner_en bit will be disabled during changing PLL rate and be restored after new settings applied. Signed-off-by: Owen

[PATCH v1 07/11] clk: mediatek: Add flags support for mtk_gate data

2018-11-05 Thread Weiyi Lu
On some Mediatek platforms, there are critical clocks of clock gate type. To register clock gate with flags CLK_IS_CRITICAL, we need to add the flags field in mtk_gate data and register APIs. Signed-off-by: Weiyi Lu --- drivers/clk/mediatek/clk-gate.c | 5 +++-- drivers/clk/mediatek/clk-gate.h |

[PATCH v1 11/11] soc: mediatek: Add MT8183 scpsys support

2018-11-05 Thread Weiyi Lu
Add scpsys driver for MT8183 Signed-off-by: Weiyi Lu --- drivers/soc/mediatek/mtk-scpsys.c | 226 ++ 1 file changed, 226 insertions(+) diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c index 80be2e05e4e0..57b9f04a69de 100644 --- a/dr

[PATCH v1 01/11] clk: mediatek: add new clkmux register API

2018-11-05 Thread Weiyi Lu
From: Owen Chen On both MT8183 & MT6765, there add "set/clr" register for each clkmux setting, and one update register to trigger value change. It is designed to prevent read-modify-write racing issue. The sw design need to add a new API to handle this hw change with a new mtk_clk_mux/mtk_mux str

[PATCH v1 08/11] clk: mediatek: Add MT8183 clock support

2018-11-05 Thread Weiyi Lu
Add MT8183 clock support, include topckgen, apmixedsys, infracfg, mcucfg and subsystem clocks. Signed-off-by: Weiyi Lu --- drivers/clk/mediatek/Kconfig | 75 ++ drivers/clk/mediatek/Makefile | 12 + drivers/clk/mediatek/clk-mt8183-audio.c| 112 ++ drivers/clk/

[PATCH v1 09/11] dt-bindings: soc: fix typo of MT8173 power dt-bindings

2018-11-05 Thread Weiyi Lu
fix incorrect IC name that will affect the MT8183 power dt-bindings Signed-off-by: Weiyi Lu --- include/dt-bindings/power/mt8173-power.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/dt-bindings/power/mt8173-power.h b/include/dt-bindings/power/mt8173-power.h

[PATCH v1 06/11] clk: mediatek: Add dt-bindings for MT8183 clocks

2018-11-05 Thread Weiyi Lu
Add MT8183 clock dt-bindings, include topckgen, apmixedsys, infracfg, mcucfg and subsystem clocks. Signed-off-by: Weiyi Lu Reviewed-by: Rob Herring --- include/dt-bindings/clock/mt8183-clk.h | 421 + 1 file changed, 421 insertions(+) create mode 100644 include/dt-bindin

[PATCH v1 05/11] dt-bindings: ARM: Mediatek: Document bindings for MT8183

2018-11-05 Thread Weiyi Lu
This patch adds the binding documentation for apmixedsys, audiosys, camsys, imgsys, infracfg, mcucfg, mfgcfg, mmsys, topckgen, vdecsys, vencsys and ipu for Mediatek MT8183. Signed-off-by: Weiyi Lu Reviewed-by: Rob Herring --- .../arm/mediatek/mediatek,apmixedsys.txt | 1 + .../bindings/ar

[PATCH v1 00/11] Mediatek MT8183 clock and scpsys support

2018-11-05 Thread Weiyi Lu
This series is based on v4.20-rc1 and most of changes are extracted from series below (clock/scpsys common changes for both MT8183 & MT6765) https://patchwork.kernel.org/patch/10528495/ (clock support of MT8183) https://patchwork.kernel.org/patch/10549891/ The whole series is composed of clock com

[PATCH v1 00/11] Mediatek MT8183 clock and scpsys support

2018-11-05 Thread Weiyi Lu
This series is based on v4.20-rc1 and most of changes are extracted from series below (clock/scpsys common changes for both MT8183 & MT6765) https://patchwork.kernel.org/patch/10528495/ (clock support of MT8183) https://patchwork.kernel.org/patch/10549891/ The whole series is composed of clock com

[PATCH v1 04/11] soc: mediatek: add new flow for mtcmos power.

2018-11-05 Thread Weiyi Lu
From: Owen Chen Both MT8183 & MT6765 add more bus protect node than previous project, therefore we add two more register for setup bus protect, which reside at INFRA_CFG & SMI_COMMON. With the following change 1. bus protect need not only infracfg but smi_common registers involved to setup. T

[PATCH v1 10/11] dt-bindings: soc: Add MT8183 power dt-bindings

2018-11-05 Thread Weiyi Lu
Add power dt-bindings for MT8183. Signed-off-by: Weiyi Lu --- .../bindings/soc/mediatek/scpsys.txt | 14 ++ include/dt-bindings/power/mt8183-power.h | 26 +++ 2 files changed, 40 insertions(+) create mode 100644 include/dt-bindings/power/mt8183-power.h dif

Re: [PATCH 4.14 069/143] ARM: tegra: Fix ULPI regression on Tegra20

2018-11-05 Thread Sasha Levin
On Mon, Nov 05, 2018 at 02:05:49PM +, Marcel Ziswiler wrote: On Fri, 2018-11-02 at 22:02 -0400, Sasha Levin wrote: On Fri, Nov 02, 2018 at 07:56:57PM +, Sudip Mukherjee wrote: > Hi Greg, > > On Fri, Nov 2, 2018 at 6:53 PM Greg Kroah-Hartman > wrote: > > > > 4.14-stable review patch. If

Re: [REGRESSION] OCTEON MMC driver failure with v4.19

2018-11-05 Thread Christoph Hellwig
On Tue, Nov 06, 2018 at 12:06:32AM +0200, Aaro Koskinen wrote: > With the below change, the MMC card probe seems to with v4.19. But it > feels a bit hackish, don't you think... Is there some obvious simple > fix that I'm missing? Any comments? Please just use dma_coerce_mask_and_coherent in the pl

Re: [PATCH] mm: Create the new vm_fault_t type

2018-11-05 Thread Souptick Joarder
On Tue, Nov 6, 2018 at 11:51 AM Mike Rapoport wrote: > > On Mon, Nov 05, 2018 at 07:23:55PM +0530, Souptick Joarder wrote: > > On Mon, Nov 5, 2018 at 2:43 PM Mike Rapoport wrote: > > > > > > On Mon, Nov 05, 2018 at 11:14:17AM +0530, Souptick Joarder wrote: > > > > Hi Matthew, > > > > > > > > On S

Re: [PATCH] ext4: remove code duplication in free_ind_block()

2018-11-05 Thread Vasily Averin
btw I have few related questions: 1) extend_credit_for_blkdel() can return error but its return code is not checked, neither here nor in all other places. Could somebody clarify, is it normal? 2) there is similar function free_ext_idx(). After internal failures it calls extend_credit_for_blkde

Re: [PATCH] mm: Create the new vm_fault_t type

2018-11-05 Thread Mike Rapoport
On Mon, Nov 05, 2018 at 07:23:55PM +0530, Souptick Joarder wrote: > On Mon, Nov 5, 2018 at 2:43 PM Mike Rapoport wrote: > > > > On Mon, Nov 05, 2018 at 11:14:17AM +0530, Souptick Joarder wrote: > > > Hi Matthew, > > > > > > On Sun, Nov 4, 2018 at 2:06 PM Mike Rapoport wrote: > > > > > > > > On Sa

[PATCH] ext4: remove code duplication in free_ind_block()

2018-11-05 Thread Vasily Averin
free_ind_block(), free_dind_blocks() and free_tind_blocks() are replaced by a single recursive function. Signed-off-by: Vasily Averin --- fs/ext4/migrate.c | 115 +- 1 file changed, 32 insertions(+), 83 deletions(-) diff --git a/fs/ext4/migrate.c b/fs

Re: [PATCH v3 08/16] tpm: move tpm_validate_commmand() to tpm2-space.c

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 05:36:03PM -0500, Stefan Berger wrote: > On 11/4/18 8:45 PM, Jarkko Sakkinen wrote: > > Move tpm_validate_command() to tpm2-space.c and make it part of the > > tpm2_prepare_space() flow. Make cc resolution as part of the TPM space > > functionality in order to detach it from

[PATCH 3/3] drm/msm: Optimize adreno_show_object()

2018-11-05 Thread Sharat Masetty
When the userspace tries to read the crashstate dump, the read side implementation in the driver currently ascii85 encodes all the binary buffers and it does this each time the read system call is called. A userspace tool like cat typically does a page by page read and the number of read calls depe

Re: [PATCH v3 07/16] tpm: access command header through struct in tpm_try_transmit()

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 05:26:30PM -0500, Stefan Berger wrote: > On 11/4/18 8:45 PM, Jarkko Sakkinen wrote: > > Instead of accessing fields of the command header through offsets to > > the raw buffer, it is a better idea to use the header struct pointer > > that is already used elsewhere in the fun

[PATCH v6 2/2] mm/page_alloc: remove software prefetching in __free_pages_core

2018-11-05 Thread Arun KS
They not only increase the code footprint, they actually make things slower rather than faster. Remove them as contemporary hardware doesn't need any hint. Suggested-by: Dan Williams Signed-off-by: Arun KS --- mm/page_alloc.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --gi

[PATCH v6 1/2] memory_hotplug: Free pages as higher order

2018-11-05 Thread Arun KS
When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less than 1 ms, hence improving the hot add latency by 60%. Modify external providers of o

Re: [PATCH v3 06/16] tpm: clean up tpm_try_transmit() error handling flow

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 05:20:33PM -0500, Stefan Berger wrote: > > +out_locality: > > + if (has_locality) > > + tpm_relinquish_locality(chip, flags); > > Safer to also put has_locality = false here ? Not really sure why? /Jarkko

[PATCH v2 2/2] KVM: x86: expose MOVDIR64B CPU feature into VM.

2018-11-05 Thread Liu Jingqi
MOVDIR64B moves 64-bytes as direct-store with 64-bytes write atomicity. Direct store is implemented by using write combining (WC) for writing data directly into memory without caching the data. Availability of the MOVDIR64B instruction is indicated by the presence of the CPUID feature flag MOVDIR6

[PATCH v2 0/2] KVM: x86: expose direct stores instructions into VM.

2018-11-05 Thread Liu Jingqi
Direct stores instructions MOVDIRI and MOVDIR64B will be available in Tremont and other future x86 processors, and need to be exposed to guest VM. The release document ref below link: https://software.intel.com/sites/default/files/managed/c5/15/\ architecture-instruction-set-extensions-programming

[PATCH v2 1/2] KVM: x86: expose MOVDIRI CPU feature into VM.

2018-11-05 Thread Liu Jingqi
MOVDIRI moves doubleword or quadword from register to memory through direct store which is implemented by using write combining (WC) for writing data directly into memory without caching the data. Availability of the MOVDIRI instruction is indicated by the presence of the CPUID feature flag MOVDIR

Re: [PATCH v3 05/16] tpm: print tpm2_commit_space() error inside tpm2_commit_space()

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 05:04:46PM -0500, Stefan Berger wrote: > On 11/4/18 8:45 PM, Jarkko Sakkinen wrote: > > The error logging for tpm2_commit_space() is in a wrong place. This > > commit moves it inside that function. > > > > Signed-off-by: Jarkko Sakkinen > > --- > > drivers/char/tpm/tpm2-

Re: [PATCH v3 04/16] tpm: call tpm2_flush_space() on error in tpm_try_transmit()

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 05:01:46PM -0500, Stefan Berger wrote: > On 11/4/18 8:45 PM, Jarkko Sakkinen wrote: > > Always call tpm2_flush_space() on failure in tpm_try_transmit() so that > > the volatile memory of the TPM gets cleared. If /dev/tpm0 does not have > > sufficient permissions (usually it

Re: [PATCH v3 03/16] tpm: return 0 from pcrs_show() when tpm1_pcr_read() fails

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 04:54:52PM -0500, Stefan Berger wrote: > On 11/4/18 8:45 PM, Jarkko Sakkinen wrote: > > Do not print partial list of PCRs when tpm1_pcr_read() fails but instead > > return 0 from pcrs_show(). This is consistent behavior with other sysfs > > functions. > > > > Signed-off-by:

Re: [PATCH v3 01/16] tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 04:48:13PM -0500, Stefan Berger wrote: > > int tpm_send(struct tpm_chip *chip, void *cmd, size_t buflen) > > { > > + struct tpm_buf buf; > > int rc; > > > > chip = tpm_find_get_ops(chip); > > if (!chip) > > return -ENODEV; > > > > - rc = tpm

[PATCH] arm64: dts: qcom: sdm845-mtp: Mark protected gcc clocks

2018-11-05 Thread Bjorn Andersson
As of v4.20-rc1 probing the GCC driver on a SDM845 device with the standard security implementation causes an access violation and an immediate system restart. Use the protected-clocks property to mark the offending clocks protected for the MTP, in order to allow it to boot. Cc: Stephen Boyd Sign

[PATCH] sched: Fix the ifdef block in add_nr_running()

2018-11-05 Thread Viresh Kumar
There is no point in keeping the conditional statement of the if block outside of the ifdef block, while all of its body is contained within the ifdef block. Move the conditional statement as well under the ifdef block. Signed-off-by: Viresh Kumar --- kernel/sched/sched.h | 4 ++-- 1 file change

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-05 Thread Arun KS
Any comments? Regards, Arun On 2018-10-26 16:30, Arun KS wrote: This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) on tip of linux-mmotm. And memory hotplug tested on arm64, but

Re: [PATCH] mm, slab: remove unnecessary unlikely()

2018-11-05 Thread Dmitry Vyukov
On Mon, Nov 5, 2018 at 11:18 AM, Vlastimil Babka wrote: > +CC Dmitry > > On 11/4/18 1:50 PM, Yangtao Li wrote: >> WARN_ON() already contains an unlikely(), so it's not necessary to use >> unlikely. >> >> Signed-off-by: Yangtao Li > > Acked-by: Vlastimil Babka > > Maybe also change it back to WAR

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-11-05 Thread Stephen Boyd
Quoting Lina Iyer (2018-11-01 10:16:30) > On Wed, Oct 31 2018 at 18:13 -0600, Stephen Boyd wrote: > > > >Right. Let's scrap the plan to do the wakeup based mask/unmask in both > >chips. It won't work because of the edge trigger type. > > > >The difference I see is that this patch does the irq "forw

[PATCH] clocksource/drivers/timer-imx-tpm: convert the driver to timer-of

2018-11-05 Thread Anson Huang
Convert the driver to use the timer_of helpers. This allows to handle timer base, clock and irq using common timer_of driver and it simplifies the code. Signed-off-by: Anson Huang --- drivers/clocksource/timer-imx-tpm.c | 136 +++- 1 file changed, 55 insertions(+)

[RESEND PATCH 1/7] dmaengine: sprd: Remove direction usage from struct dma_slave_config

2018-11-05 Thread Baolin Wang
The direction field of struct dma_slave_config was marked deprecated, thus remove the usage. Signed-off-by: Baolin Wang --- drivers/dma/sprd-dma.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 38d4e4f..c226dc93 100644 --- a/drivers

[RESEND PATCH 3/7] dmaengine: sprd: Fix the last link-list configuration

2018-11-05 Thread Baolin Wang
From: Eric Long We will pass sglen as 0 configure the last link-list configuration when filling the descriptor, which will cause the incorrect link-list configuration. Thus we should check if the sglen is 0 to configure the correct link-list configuration. Signed-off-by: Eric Long Signed-off-by

[RESEND PATCH 2/7] dmaengine: sprd: Get transfer residue depending on the transfer direction

2018-11-05 Thread Baolin Wang
From: Eric Long Add one field to save the transfer direction for struct sprd_dma_desc, which is used to get correct transfer residue depending on the transfer direction. [Baolin Wang adds one field to present the transfer direction] Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- driv

[RESEND PATCH 6/7] dmaengine: sprd: Support DMA 2-stage transfer mode

2018-11-05 Thread Baolin Wang
From: Eric Long The Spreadtrum DMA controller supports channel 2-stage tansfer mode, that means we can request 2 dma channels, one for source channel, and another one for destination channel. Once the source channel's transaction is done, it will trigger the destination channel's transaction auto

[RESEND PATCH 7/7] dmaengine: sprd: Add me as one of the module authors

2018-11-05 Thread Baolin Wang
From: Eric Long Add me as one of the module authors. Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- drivers/dma/sprd-dma.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 50d6569..e2f0167 100644 --- a/drivers/dma/sprd-dma.c

[RESEND PATCH 0/7] Add some fixes and new feature for SPRD DMA

2018-11-05 Thread Baolin Wang
This patchset removes the direction usage from struct dma_slave_config, and add one new field to save the direction. It also fixes some issues for link-list transfer. Moreover this patchset adds new 2-stage transfer support for our DMA. Baolin Wang (1): dmaengine: sprd: Remove direction usage fr

[RESEND PATCH 4/7] dmaengine: sprd: Set cur_desc as NULL when free or terminate one dma channel

2018-11-05 Thread Baolin Wang
From: Eric Long It will be failed to start one new transfer if the channel started one none interrupt transfer before, since we will only set the schan->cur_desc as NULL depending on the transfer interrupt now. Thus we should set schan->cur_desc as NULL when free or terminate one dma channel to a

[RESEND PATCH 5/7] dmaengine: sprd: Support DMA link-list cyclic callback

2018-11-05 Thread Baolin Wang
From: Eric Long The Spreadtrum DMA link-list mode is always one cyclic transfer, so we should clear the SPRD_DMA_LLIST_END flag for the link-list configuration. Moreover add cyclic callback support for the cyclic transfer. Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- drivers/dma/sp

Re: [PATCH RFC] hist lookups

2018-11-05 Thread David Miller
Jiri, Because you now run queued_events__queue() lockless with that condvar trick, it is possible for top->qe.in to be seen as one past the data[] array, this is because the rotate_queues() code goes: if (++top->qe.in > &top->qe.data[1]) top->qe.in = &top->qe.data[0]; S

Re: [PATCH 1/2] ARM: copypage-fa: add kto and kfrom to input operands list

2018-11-05 Thread Nicolas Pitre
On Tue, 6 Nov 2018, Stefan Agner wrote: > On 16.10.2018 22:43, Nicolas Pitre wrote: > > Subject: [PATCH] ARM: remove naked function usage > > > > Convert page copy functions not to rely on the naked function attribute. > > > > This attribute is known to confuse some gcc versions when function >

Re: [PATCH 8/8] pstore/ram: Correctly calculate usable PRZ bytes

2018-11-05 Thread Joel Fernandes
On Mon, Nov 05, 2018 at 09:04:13AM -0800, Kees Cook wrote: > On Sun, Nov 4, 2018 at 8:42 PM, Joel Fernandes wrote: > > Dumping the magic bytes of the non decompressable .enc.z files, I get this > > which shows a valid zlib compressed header: > > > > Something like: > > 48 89 85 54 4d 6f 1a 31 > >

[PATCH] kbuild: deb-pkg: fix too low build version number

2018-11-05 Thread Masahiro Yamada
Since commit b41d920acff8 ("kbuild: deb-pkg: split generating packaging and build"), the build version of the kernel contained in a deb package is too low by 1. Prior to the bad commit, the kernel was built first, then the number in .version file was read out, and written into the debian control f

Re: [PATCH RFC] hist lookups

2018-11-05 Thread David Miller
From: David Miller Date: Mon, 05 Nov 2018 19:45:42 -0800 (PST) > Build fix for sparc below, I'm playing with this now. I get various assertion failures and crashes during make -j128 kernel builds on my sparc64 box: perf: Segmentation fault backtrace /lib/s

[Patch v4] genirq/matrix: Choose CPU for managed IRQs based on how many of them are allocated

2018-11-05 Thread Long Li
From: Long Li On a large system with multiple devices of the same class (e.g. NVMe disks, using managed IRQs), the kernel tends to concentrate their IRQs on several CPUs. The issue is that when NVMe calls irq_matrix_alloc_managed(), the assigned CPU tends to be the first several CPUs in the cpum

Re: [PATCH RFC] hist lookups

2018-11-05 Thread David Miller
From: Jiri Olsa Date: Mon, 5 Nov 2018 21:34:47 +0100 > I pushed it in perf/fixes branch in: > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git Build fix for sparc below, I'm playing with this now. perf: Use PRIu64 for printing top lost events count. Signed-off-by: David S. Miller

[PATCH v3 4/4] dmaengine: imx-sdma: use GFP_NOWAIT for dma descriptor allocations

2018-11-05 Thread Robin Gong
From: Lucas Stach DMA buffer descriptors aren't allocated from atomic context, so they can use the less heavyweigth GFP_NOWAIT. Signed-off-by: Lucas Stach Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/imx-s

[PATCH v3 2/4] Revert "dmaengine: imx-sdma: alloclate bd memory from dma pool"

2018-11-05 Thread Robin Gong
From: Lucas Stach This reverts commit fe5b85c656bc. The SDMA engine needs the descriptors to be contiguous in memory. As the dma pool API is only able to provide a single descriptor per alloc invocation there is no guarantee that multiple descriptors satisfy this requirement. Also the code in que

[PATCH v3 3/4] dmaengine: imx-sdma: implement channel termination via worker

2018-11-05 Thread Robin Gong
From: Lucas Stach The dmaengine documentation states that device_terminate_all may be asynchronous and need not wait for the active transfers to stop. This allows us to move most of the functionality currently implemented in the sdma channel termination function to run in a worker, outside of an

[PATCH v3 0/4] Correct dma pool for imx-sdma

2018-11-05 Thread Robin Gong
This patch set to correct dma pool used in the commit fe5b85c656bc ("dmaengine: imx-sdma: alloclate bd memory from dma pool") because all bds should be contiguous in memory in multi bds case for sdma, but dma pool can't statify it and cause transfer failure then.Thank Lucas for the making things on

[PATCH v3 1/4] Revert "dmaengine: imx-sdma: Use GFP_NOWAIT for dma allocations"

2018-11-05 Thread Robin Gong
From: Lucas Stach This reverts commit c1199875d327, as this depends on another commit that is going to be reverted. Signed-off-by: Lucas Stach Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/

[PATCH] dma: coh901318: Fix a double-lock bug

2018-11-05 Thread Jia-Ju Bai
The function coh901318_alloc_chan_resources() calls spin_lock_irqsave() before calling coh901318_config(). But coh901318_config() calls spin_lock_irqsave() again in its definition, which may cause a double-lock bug. Because coh901318_config() is only called by coh901318_alloc_chan_resources(), th

Re: [PATCH - resend] VFS: use synchronize_rcu_expedited() in namespace_unlock()

2018-11-05 Thread NeilBrown
On Fri, Oct 05 2018, NeilBrown wrote: > The synchronize_rcu() in namespace_unlock() is called every time > a filesystem is unmounted. If a great many filesystems are mounted, > this can cause a noticable slow-down in, for example, system shutdown. > > The sequence: > mkdir -p /tmp/Mtest/{0..500

linux-next: Tree for Nov 6

2018-11-05 Thread Stephen Rothwell
Hi all, Changes since 20181105: New trees: risc-v-pjw, sifive, i3c-fixes, i3c The drm-msm tree gained a conflict against the drm-misc tree. The tip tree gained a build failure for which I applied a fix patch. Non-merge commits (relative to Linus' tree): 825 1082 files changed,

Re: [PATCH 2/2] nvme: add quirk to not call disable function when suspending

2018-11-05 Thread AceLan Kao
Right, should replace it with SK_HYNIX. I'll prepare v2 patch for that. Sinan Kaya 於 2018年11月6日 週二 上午10:24寫道: > > On 11/5/2018 6:04 PM, AceLan Kao wrote: > > + { PCI_DEVICE(0x1c5c, 0x1527), /* Sk Hynix */ > > + .driver_data = NVME_QUIRK_NO_DISABLE, }, > > Now that you added PCI_V

Re: [RFC PATCH v4 00/13] ktask: multithread CPU-intensive kernel work

2018-11-05 Thread Zi Yan
On 5 Nov 2018, at 21:20, Daniel Jordan wrote: > Hi Zi, > > On Mon, Nov 05, 2018 at 01:49:14PM -0500, Zi Yan wrote: >> On 5 Nov 2018, at 11:55, Daniel Jordan wrote: >> >> Do you think if it makes sense to use ktask for huge page migration (the data >> copy part)? > > It certainly could. > >> I did

Re: [PATCH 4/6] mm: introduce page->dma_pinned_flags, _count

2018-11-05 Thread Dave Chinner
On Mon, Nov 05, 2018 at 04:26:04PM -0800, John Hubbard wrote: > On 11/5/18 1:54 AM, Jan Kara wrote: > > Hmm, have you tried larger buffer sizes? Because synchronous 8k IO isn't > > going to max-out NVME iops by far. Can I suggest you install fio [1] (it > > has the advantage that it is pretty much

Re: [RFC PATCH v4 06/13] vfio: parallelize vfio_pin_map_dma

2018-11-05 Thread Daniel Jordan
On Mon, Nov 05, 2018 at 02:51:41PM -0700, Alex Williamson wrote: > On Mon, 5 Nov 2018 11:55:51 -0500 > Daniel Jordan wrote: > > +static int vfio_pin_map_dma_chunk(unsigned long start_vaddr, > > + unsigned long end_vaddr, > > + struct vfio_pi

[PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-05 Thread Bo YU
Fix warning form checkpatch, use pr_warn replace KERN_WARNING Signed-off-by: Bo YU --- changes in v2: According to Joe's suggestion,drop newline from msg, otherwise it can be unterminated with newline. --- lib/kobject_uevent.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) di

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-05 Thread Daniel Jordan
On Mon, Nov 05, 2018 at 01:19:50PM -0800, Randy Dunlap wrote: > On 11/5/18 8:55 AM, Daniel Jordan wrote: > > Hi, > > > +Resource Limits > > +=== > > + > > +ktask has resource limits on the number of work items it sends to > > workqueue. > >

Re: [RFC PATCH v4 02/13] ktask: multithread CPU-intensive kernel work

2018-11-05 Thread Daniel Jordan
On Mon, Nov 05, 2018 at 12:51:33PM -0800, Randy Dunlap wrote: > On 11/5/18 8:55 AM, Daniel Jordan wrote: > > diff --git a/init/Kconfig b/init/Kconfig > > index 41583f468cb4..ed82f76ed0b7 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -346,6 +346,17 @@ config AUDIT_TREE > > depends

Re: [PATCH 2/2] nvme: add quirk to not call disable function when suspending

2018-11-05 Thread Sinan Kaya
On 11/5/2018 6:04 PM, AceLan Kao wrote: + { PCI_DEVICE(0x1c5c, 0x1527), /* Sk Hynix */ + .driver_data = NVME_QUIRK_NO_DISABLE, }, Now that you added PCI_VENDOR_ID_SK_HYNIX to pci_ids.h, you could use PCI_VENDOR_ID_SK_HYNIX above instead of 0x1c5c.

Re: [RFC PATCH v4 00/13] ktask: multithread CPU-intensive kernel work

2018-11-05 Thread Daniel Jordan
Hi Zi, On Mon, Nov 05, 2018 at 01:49:14PM -0500, Zi Yan wrote: > On 5 Nov 2018, at 11:55, Daniel Jordan wrote: > > Do you think if it makes sense to use ktask for huge page migration (the data > copy part)? It certainly could. > I did some experiments back in 2016[1], which showed that migrating

[PATCH 1/2] pci: prevent sk hynix nvme from entering D3

2018-11-05 Thread AceLan Kao
It leads to the power consumption raises to 2.2W during s2idle, while it consumes less than 1W during long idle if put SK hynix nvme to D3 and then enter s2idle. >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its own APST feature to do the power management. To leverage its APST feat

[PATCH 2/2] nvme: add quirk to not call disable function when suspending

2018-11-05 Thread AceLan Kao
Call nvme_dev_disable() function leads to the power consumption goes up to 2.2 Watt during suspend-to-idle, and from SK hynix FE, they suggest us to use its own APST feature to do the power management during s2idle. After D3 is diabled and nvme_dev_disable() is not called while suspending, the powe

Re: [LKP] [tools/bpf] f6f3bac08f: stderr.failed_to_prepare_for_bpf

2018-11-05 Thread Yonghong Song
I cannot reproduce in my local fc28 system with the attached steps. The netlink_dumper.c file, could you confirm whether the following header files are missing form you rhel-7.2 host? #include #include I suspect you probably miss linux/tc_act/tc_bpf.h. But could you confirm it? If this is

Re: [PATCH 04/12] gfs2: properly initial file_lock used for unlock.

2018-11-05 Thread NeilBrown
On Mon, Nov 05 2018, Jeff Layton wrote: > On Mon, 2018-11-05 at 12:30 +1100, NeilBrown wrote: >> Rather than assuming all-zeros is sufficient, use the available API to >> initialize the file_lock structure use for unlock. >> VFS-level changes will soon make it important that the >> list_heads in f

Re: [PATCH v2] bit_spinlock: introduce smp_cond_load_relaxed

2018-11-05 Thread Gao Xiang
Hi Will, On 2018/11/6 6:49, Will Deacon wrote: > Hi Gao, > > On Tue, Oct 30, 2018 at 02:04:41PM +0800, Gao Xiang wrote: >> It is better to use wrapped smp_cond_load_relaxed >> instead of open-coded busy waiting for bit_spinlock. >> >> Signed-off-by: Gao Xiang >> --- >> >> change log v2: >> - fi

RE: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-05 Thread Anson Huang
Hi, Daniel Best Regards! Anson Huang > -Original Message- > From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] > Sent: 2018年11月5日 21:35 > To: Anson Huang ; t...@linutronix.de; > linux-kernel@vger.kernel.org > Cc: dl-linux-imx > Subject: Re: [PATCH V2 2/2] clocksource: imx-gpt: add n

Re: [PATCH] hugetlbfs: fix kernel BUG at fs/hugetlbfs/inode.c:444!

2018-11-05 Thread Naoya Horiguchi
On Mon, Nov 05, 2018 at 01:23:15PM -0800, Mike Kravetz wrote: > This bug has been experienced several times by Oracle DB team. > The BUG is in the routine remove_inode_hugepages() as follows: > /* >* If page is mapped, it was faulted in after being >* unmapped in caller. Unma

Re: [PATCH] PCI: Add HXT vendor ID and ACS quirk

2018-11-05 Thread Yang, Shunyong
Hi, Sinan, On 2018/11/6 7:12, Sinan Kaya wrote: > On 11/4/2018 7:15 PM, Shunyong Yang wrote: >> Add the HXT vendor ID to pci_ids.h and use it in quirks. As the >> design of HXT SD4800 ACS feature is the same as QCOM QDF2xxx, >> pci_quirk_qcom_rp_acs() is reused for SD4800 quirk. >> >> Cc: Joey Zhe

  1   2   3   4   5   6   7   8   >