RE: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() to avoid error message

2019-10-09 Thread Andy Duan
From: Anson Huang Sent: Wednesday, October 9, 2019 6:16 PM > Failed to get irq using name is NOT fatal as driver will use index to get irq > instead, use platform_get_irq_byname_optional() instead of > platform_get_irq_byname() to avoid below error message during > probe: > > [0.819312] fec 3

RE: [PATCH 2/2] net: fec_ptp: Use platform_get_irq_xxx_optional() to avoid error message

2019-10-09 Thread Andy Duan
From: Anson Huang Sent: Wednesday, October 9, 2019 6:16 PM > Use platform_get_irq_byname_optional() and platform_get_irq_optional() > instead of platform_get_irq_byname() and platform_get_irq() for optional > IRQs to avoid below error message during probe: > > [0.795803] fec 30be.ethernet

Re: [PATCH v2 03/22] mtd: spi-nor: cadence-quadspi: Fix cqspi_command_read() definition

2019-10-09 Thread Boris Brezillon
On Tue, 24 Sep 2019 07:45:58 + wrote: > From: Tudor Ambarus > > n_tx was never used, drop it. Replace 'const u8 *txbuf' with 'u8 opcode', > to comply with the SPI NOR int (*read_reg)() method. The 'const' > qualifier has no meaning for parameters passed by value, drop it. > Going furher, th

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-09 Thread Ludovic Desroches
On Wed, Oct 09, 2019 at 04:01:47PM +0200, Alexandre Belloni wrote: > > On 09/10/2019 15:55:00+0200, Ludovic Desroches wrote: > > On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > > > External E-Mail > > > > > > > > > Implement i2c bus recovery when slaves devices might hold SDA lo

Re: [PATCH] cpufreq: Avoid cpufreq_suspend() deadlock on system shutdown

2019-10-09 Thread Viresh Kumar
On 09-10-19, 01:29, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > It is incorrect to set the cpufreq syscore shutdown callback pointer > to cpufreq_suspend(), because that function cannot be run in the > syscore stage of system shutdown for two reasons: (a) it may attempt > to carry out

Re: [PATCH v2 02/22] mtd: spi-nor: Introduce 'struct spi_nor_controller_ops'

2019-10-09 Thread Boris Brezillon
On Tue, 24 Sep 2019 07:45:53 + wrote: > From: Tudor Ambarus > > Move all SPI NOR controller driver specific ops in a dedicated > structure. 'struct spi_nor' becomes lighter. > > Use size_t for lengths in 'int (*write_reg)()' and 'int (*read_reg)()'. > Rename wite/read_buf to buf, the name

Re: Potential NULL pointer deference in RDMA

2019-10-09 Thread Leon Romanovsky
On Wed, Oct 09, 2019 at 09:44:58PM -0700, Yizhuo Zhai wrote: > Hi All: > drivers/infiniband/sw/rxe/rxe_verbs.c: > The function to_rdev() could return NULL, but no caller in this file > checks the return value but directly dereference them, which seems > potentially unsafe. Callers include rxe_query

Re: [PATCH v2 01/22] mtd: spi-nor: hisi-sfc: Drop nor->erase NULL assignment

2019-10-09 Thread Boris Brezillon
On Tue, 24 Sep 2019 07:45:50 + wrote: > From: Tudor Ambarus > > The pointer to 'struct spi_nor' is kzalloc'ed above in the code. > > Signed-off-by: Tudor Ambarus Reviewed-by: Boris Brezillon > --- > drivers/mtd/spi-nor/hisi-sfc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH] cpufreq/cpufreq_governor: Fix memory leak in cpufreq_dbs_governor_init

2019-10-09 Thread Viresh Kumar
On 09-10-19, 18:26, Navid Emamdoost wrote: > In the implementation of cpufreq_dbs_governor_init(), dbs_data is > allocated and later is assigned to governor_data. But before that > assignment, if gov->init() fails this allocation is not released. > dbs_data should be released in case if gov->init()

Re: [PATCH v1 0/2] perf stat: Support --all-kernel and --all-user

2019-10-09 Thread Jin, Yao
On 10/1/2019 10:17 AM, Andi Kleen wrote: I think it's useful. Makes it easy to do kernel/user break downs. perf record should support the same. Don't we have this already with: [root@quaco ~]# perf stat -e cycles:u,instructions:u,cycles:k,instructions:k -a -- sleep 1 This only works for

Re: [PATCH v6 06/12] arm/efi: EFI soft reservation to memblock

2019-10-09 Thread Ard Biesheuvel
On Thu, 10 Oct 2019 at 01:19, Dan Williams wrote: > > UEFI 2.8 defines an EFI_MEMORY_SP attribute bit to augment the > interpretation of the EFI Memory Types as "reserved for a specific > purpose". > > The proposed Linux behavior for specific purpose memory is that it is > reserved for direct-acce

[PATCH] x86/kvm: Fix -Wmissing-prototypes warnings

2019-10-09 Thread Yi Wang
We get two warning when build kernel with W=1: arch/x86/kernel/kvm.c:872:6: warning: no previous prototype for ‘arch_haltpoll_enable’ [-Wmissing-prototypes] arch/x86/kernel/kvm.c:885:6: warning: no previous prototype for ‘arch_haltpoll_disable’ [-Wmissing-prototypes] Including the missing head f

Re: [PATCH v17 01/14] bitops: Introduce the for_each_set_clump8 macro

2019-10-09 Thread Geert Uytterhoeven
Hi Andy, On Thu, Oct 10, 2019 at 7:49 AM Andy Shevchenko wrote: > On Thu, Oct 10, 2019 at 5:31 AM Masahiro Yamada > wrote: > > On Thu, Oct 10, 2019 at 3:54 AM Geert Uytterhoeven > > wrote: > > > On Wed, Oct 9, 2019 at 7:09 PM Andy Shevchenko > > > wrote: > > > > On Thu, Oct 10, 2019 at 01:28:

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2019-10-09 Thread Jonas Bonn
Hi Paolo, On 09/10/2019 21:14, Paolo Abeni wrote: On Wed, 2019-10-09 at 08:46 +0200, Jonas Bonn wrote: Hi, The lockless pfifo_fast qdisc has an issue with packets getting stuck in the queue. What appears to happen is: i) Thread 1 holds the 'seqlock' on the qdisc and dequeues packets. ii) T

Re: [PATCH v4 0/5] Powerpc/Watchpoint: Few important fixes

2019-10-09 Thread Ravi Bangoria
On 10/10/19 10:14 AM, Ravi Bangoria wrote: @Christophe, Is patch5 works for you on 8xx? Getting the following : root@vgoip:~# ./ptrace-hwbreak test: ptrace-hwbreak tags: git_version:v5.4-rc2-710-gf0082e173fe4-dirty PTRACE_SET_DEBUGREG, WO, len: 1: Ok PTRACE_SET_DEBUGREG, WO, len: 2: Ok P

Re: Maybe a bug in kernel/irq/chip.c unmask_irq(), device IRQ masked unexpectedly. (re-formated the mail body, sorry)

2019-10-09 Thread Yi Zheng
Hi My patch is canceled. I have tested that simple adjustment, the device IRQ masked unexpectedly. It seems that it is more easily to occur with that patch. So, the root cause is not found yet.

[PATCH bpf-next 2/2] bpf/stackmap: fix A-A deadlock in bpf_get_stack()

2019-10-09 Thread Song Liu
bpf stackmap with build-id lookup (BPF_F_STACK_BUILD_ID) can trigger A-A deadlock on rq_lock(): rcu: INFO: rcu_sched detected stalls on CPUs/tasks: [...] Call Trace: try_to_wake_up+0x1ad/0x590 wake_up_q+0x54/0x80 rwsem_wake+0x8a/0xb0 bpf_get_stack+0x13c/0x150 bpf_prog_fbdaf42eded9fe46_on_even

[PATCH bpf-next 0/2] bpf/stackmap: fix A-A deadlock in bpf_get_stack()

2019-10-09 Thread Song Liu
bpf stackmap with build-id lookup (BPF_F_STACK_BUILD_ID) can trigger A-A deadlock on rq_lock(): rcu: INFO: rcu_sched detected stalls on CPUs/tasks: [...] Call Trace: try_to_wake_up+0x1ad/0x590 wake_up_q+0x54/0x80 rwsem_wake+0x8a/0xb0 bpf_get_stack+0x13c/0x150 bpf_prog_fbdaf42eded9fe46_on_even

[PATCH bpf-next 1/2] sched: introduce this_rq_is_locked()

2019-10-09 Thread Song Liu
this_rq_is_locked() is introduced to check whether current CPU is holding rq_lock(). This will be used in bpf/stackmap.c to decide whether is safe to call up_read(), which may call rq_lock() for the same CPU. Fixes: commit 615755a77b24 ("bpf: extend stackmap to save binary_build_id+offset instead

Compliments

2019-10-09 Thread Holo Lambert
Dear, Do you have any project or an on going project which requires funding? I have an investor with a huge capital who is ready to invest up to Ten million US dollars upwards. So I am looking for a trustworthy and reliable partner with a project investment that can generate a healthy returns on

Re: [PATCH v4 3/9] mm: pagewalk: Don't split transhuge pmds when a pmd_entry is present

2019-10-09 Thread VMware
On 10/10/19 4:07 AM, Linus Torvalds wrote: On Wed, Oct 9, 2019 at 6:10 PM Thomas Hellström (VMware) wrote: Your original patch does exactly the same! Oh, no. You misread my original patch. Look again. The logic in my original patch was very different. It said that - *if* we have a pmd_ent

[PATCH] wdt: bd70528: Trivial function documentation fix

2019-10-09 Thread Matti Vaittinen
The function documentation for the exported ROHM BD70528 WDG control functions used old argument names. Fix the names. Signed-off-by: Matti Vaittinen --- drivers/watchdog/bd70528_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/bd70528_wdt.c b/drive

linux-next: Tree for Oct 10

2019-10-09 Thread Stephen Rothwell
Hi all, Changes since 20191009: The samsung-krzk tree gained a conflict against Linus' tree. The tip tree gained a conflict and semantic conflicts against the drm tree. Non-merge commits (relative to Linus' tree): 3318 3518 files changed, 112430 insertions(+), 57856

Re: [PATCH 07/11] vhost: convert vhost_umem_interval_tree to half closed intervals

2019-10-09 Thread Jason Wang
On 2019/10/4 上午4:18, Davidlohr Bueso wrote: The vhost_umem interval tree really wants [a, b) intervals, not fully closed as currently. As such convert it to use the new interval_tree_gen.h, and also rename the 'last' endpoint in the node to 'end', which both a more suitable name for the half cl

Re: [PATCH v17 01/14] bitops: Introduce the for_each_set_clump8 macro

2019-10-09 Thread Andy Shevchenko
On Thu, Oct 10, 2019 at 5:31 AM Masahiro Yamada wrote: > On Thu, Oct 10, 2019 at 3:54 AM Geert Uytterhoeven > wrote: > > On Wed, Oct 9, 2019 at 7:09 PM Andy Shevchenko > > wrote: > > > On Thu, Oct 10, 2019 at 01:28:08AM +0900, Masahiro Yamada wrote: > > > > On Thu, Oct 10, 2019 at 12:27 AM Will

Re: Potential NULL pointer deference in spi

2019-10-09 Thread Eric Dumazet
On 10/9/19 10:37 PM, Yizhuo Zhai wrote: > Hi All: > > drivers/spi/spi.c: > > The function to_spi_device() could return NULL, but some callers > in this file does not check the return value while directly dereference > it, which seems potentially unsafe. > > Such callers include spidev_release

Re: [PATCH 2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled

2019-10-09 Thread Andy Shevchenko
On Thu, Oct 10, 2019 at 8:37 AM Andy Shevchenko wrote: > On Wed, Oct 9, 2019 at 11:05 PM Stuart Hayes wrote: > > +static void pcie_wait_for_presence(struct pci_dev *pdev) > > +{ > > + int timeout = 1250; > > + bool pds; Also this is redundant. Just use the following outside the loo

Re: [PATCH 2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled

2019-10-09 Thread Andy Shevchenko
On Wed, Oct 9, 2019 at 11:05 PM Stuart Hayes wrote: > > From: Alexandru Gagniuc > > When inband presence is disabled, PDS may come up at any time, or not > at all. PDS being low may indicate that the card is still mating, and > we could expect contact bounce to bring down the link as well. > > It

Potential NULL pointer deference in spi

2019-10-09 Thread Yizhuo Zhai
Hi All: drivers/spi/spi.c: The function to_spi_device() could return NULL, but some callers in this file does not check the return value while directly dereference it, which seems potentially unsafe. Such callers include spidev_release(), spi_dev_check(), driver_override_store(), etc. -- Kin

[PATCH v4 1/2] powerpc/irq: bring back ksp_limit management in C functions.

2019-10-09 Thread Christophe Leroy
Commit cbc9565ee826 ("powerpc: Remove ksp_limit on ppc64") moved PPC32 ksp_limit handling in assembly functions call_do_softirq() and call_do_irq() as they are different for PPC32 and PPC64. In preparation of replacing these functions by inline assembly, partialy revert that commit to bring back k

[PATCH v4 2/2] powerpc/irq: inline call_do_irq() and call_do_softirq()

2019-10-09 Thread Christophe Leroy
call_do_irq() and call_do_softirq() are quite similar on PPC32 and PPC64 and are simple enough to be worth inlining. Inlining them avoids an mflr/mtlr pair plus a save/reload on stack. This is inspired from S390 arch. Several other arches do more or less the same. The way sparc arch does seems od

Re: [Outreachy kernel] [PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each

2019-10-09 Thread Julia Lawall
On Wed, 9 Oct 2019, Joe Perches wrote: > On Wed, 2019-10-09 at 22:48 +0200, Julia Lawall wrote: > > On Wed, 9 Oct 2019, Jules Irenge wrote: > > > Fix multiple assignments warning " check > > > issued by checkpatch.pl tool: > > > "CHECK: multiple assignments should be avoided". > [] > > > diff

Potential NULL pointer deference inata: sata_rcar

2019-10-09 Thread Yizhuo Zhai
Hi All: In function sata_rcar_bmdma_fill_sg, macro for_each_sg uses sg_next(), which could return NULL as "sg", however, there's no check before dereferencing it (in sg_dma_address()), which is potentially unsafe. -- Kind Regards, Yizhuo Zhai Computer Science, Graduate Student University of Cal

Re: [PATCH v2 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-09 Thread Andreas Kemnade
Hi Jonathan, On Mon, 7 Oct 2019 00:38:48 +0200 Jonathan Neuschäfer wrote: > Thanks for CCing me on this patchset. Nice to see more e-book reader > related work! > btw. seems that we have a common target, since our ebook readers both have a tps65185. It seems to be a good idea to comment things

Re: string.h: Mark 34 functions with __must_check

2019-10-09 Thread Andy Shevchenko
On Wed, Oct 9, 2019 at 11:11 PM Markus Elfring wrote: > > > I'm curious. How many warnings showed up when you applied this patch? > > I suggest to take another look at six places in a specific source file > (for example). > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/li

Re: [PATCH] USB: core: Fix potental Null Pointer dereference

2019-10-09 Thread Greg Kroah-Hartman
On Wed, Oct 09, 2019 at 06:02:02PM -0700, Yizhuo wrote: > Inside function usb_device_is_owned(), usb_hub_to_struct_hub() > could return NULL but there's no check before its dereference, > which is potentially unsafe. > > Signed-off-by: Yizhuo > --- > drivers/usb/core/hub.c | 2 +- > 1 file chang

Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk()

2019-10-09 Thread Sergey Senozhatsky
On (10/09/19 16:26), Michal Hocko wrote: > On Wed 09-10-19 15:56:32, Peter Oberparleiter wrote: > [...] > > A generic solution would be preferable from my point of view though, > > because otherwise each console driver owner would need to ensure that any > > lock taken in their console.write implem

Re: [PATCH v1 0/2] spi: cadence-qspi: Add cadence-qspi support for Intel LGM SoC

2019-10-09 Thread Ramuthevar, Vadivel MuruganX
Hi Vignesh, On 10/10/2019 12:18 PM, Vignesh Raghavendra wrote: On 10/10/19 7:04 AM, Ramuthevar, Vadivel MuruganX wrote: HI Vignesh, On 17/9/2019 12:50 AM, Vignesh Raghavendra wrote: Hi, On 16/09/19 1:08 PM, Ramuthevar,Vadivel MuruganX wrote: patch 1: Add YAML for cadence-qspi devicetree cd

Re: [PATCH] rpmsg: glink: Remove channel decouple from rpdev release

2019-10-09 Thread Stephen Boyd
Quoting Chris Lew (2019-10-08 18:33:45) > If a channel is being rapidly restarted and the kobj release worker is > busy, there is a chance the the rpdev_release function will run after > the channel struct itself has been released. > > There should not be a need to decouple the channel from rpdev

Re: [PATCH] mm/kmemleak: skip late_init if not skip disable

2019-10-09 Thread Murphy Zhou
Hi, On Wed, Oct 9, 2019 at 12:51 AM Catalin Marinas wrote: > > Hi Murphy, > > On Sun, Sep 29, 2019 at 05:56:59PM +0800, Murphy Zhou wrote: > > Now if DEFAULT_OFF set to y, kmemleak_init will start the cleanup_work > > workqueue. Then late_init call will set kmemleak_initialized to 1, the > > clea

Potential NULL pointer deference in iwlwifi: mvm

2019-10-09 Thread Yizhuo Zhai
Hi All: drivers/net/wireless/intel/iwlwifi/mvm/power.c: The function iwl_mvm_vif_from_mac80211() could return NULL, but some callers in this file does not check the return value while directly dereference it, which seems potentially unsafe. Such callers include iwl_mvm_update_d0i3_power_mode(), i

Potential NULL pointer deference in mm/memcontrol.c

2019-10-09 Thread Yizhuo Zhai
Hi All: mm/memcontrol.c: The function mem_cgroup_from_css() could return NULL, but some callers in this file checks the return value but directly dereference it, which seems potentially unsafe. Such callers include mem_cgroup_hierarchy_read(), mem_cgroup_hierarchy_write(), mem_cgroup_read_u64(), me

[PATCH v2 4/4] staging: rtl8723bs: Remove unnecessary blank lines

2019-10-09 Thread Wambui Karuga
Remove multiple blank lines in drivers/staging/rtl8723bs/core/rtw_mlme.c. Issues reported by checkpatch.pl as: CHECK: Please don't use multiple blank lines Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 47 --- 1 file changed, 47 deletions(-) di

[PATCH v2 3/4] staging: rtl8723bs: Remove comparisons to booleans in conditionals.

2019-10-09 Thread Wambui Karuga
Remove comparisons to true and false in multiple if statements in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723

[PATCH v2 2/4] staging: rtl8723bs: Remove unnecessary braces for single statements

2019-10-09 Thread Wambui Karuga
Clean up multiple unnecessary braces around single statement blocks in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: WARNING: braces {} are not necessary for single statement blocks or WARNING: braces {} are not necessary for any arm of this statement Signed-off-by

[PATCH v2 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals

2019-10-09 Thread Wambui Karuga
Remove most comparisons to NULL in conditionals in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: CHECK: Comparison to NULL could be written Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 46 +++ 1 file changed, 23

[PATCH v2 0/4] staging: rtl8723bs: Style clean-up in rtw_mlme.c

2019-10-09 Thread Wambui Karuga
This patchset addresses multiple style and formatting issues reported by checkpatch.pl in drivers/staging/rtl8723bs/core/rtw_mlme.c PATCH v2 of the series corrects the "patchest" mispelling in the original cover letter and provides a clearer subject line. Wambui Karuga (4): staging: rtl8723bs:

Potential NULL pointer deference in RDMA

2019-10-09 Thread Yizhuo Zhai
Hi All: drivers/infiniband/sw/rxe/rxe_verbs.c: The function to_rdev() could return NULL, but no caller in this file checks the return value but directly dereference them, which seems potentially unsafe. Callers include rxe_query_device(), rxe_query_port(), rxe_query_pkey(), etc. -- Kind Regards,

Re: [PATCH v4 0/5] Powerpc/Watchpoint: Few important fixes

2019-10-09 Thread Ravi Bangoria
@Christophe, Is patch5 works for you on 8xx? Getting the following : root@vgoip:~# ./ptrace-hwbreak test: ptrace-hwbreak tags: git_version:v5.4-rc2-710-gf0082e173fe4-dirty PTRACE_SET_DEBUGREG, WO, len: 1: Ok PTRACE_SET_DEBUGREG, WO, len: 2: Ok PTRACE_SET_DEBUGREG, WO, len: 4: Ok PTRACE_SET_

[PATCH] staging: octeon: Fix incorrect type in assignment

2019-10-09 Thread Wambui Karuga
Fix the following warning generated by sparse in drivers/staging/octeon/ethernet-tx.c: drivers/staging/octeon/ethernet-tx.c:563:50: warning: incorrect type in assignment (different base types) drivers/staging/octeon/ethernet-tx.c:563:50:expected unsigned short [usertype] hw_chksum drivers/st

[PATCH] staging: sm750fb: Potential uninitialized field in "pll"

2019-10-09 Thread Yizhuo
Inside function set_chip_clock(), struct pll is supposed to be initialized in sm750_calc_pll_value(), if condition "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled, then some field of pll will not be initialized but used in function sm750_format_pll_reg(), which is potentially unsaf

Re: [PATCH v1 1/2] pinctrl: Add pinmux & GPIO controller driver for new SoC

2019-10-09 Thread Tanwar, Rahul
Hi Linus, Thanks for taking time out to review. On 5/10/2019 4:28 AM, Linus Walleij wrote: >> +config PINCTRL_EQUILIBRIUM >> + tristate "Generic pinctrl and GPIO driver for Intel Lightning >> Mountain SoC" >> + select PINMUX >> + select PINCONF >> + select GPIOLIB >> +

[git pull] dcache_readdir() fixes

2019-10-09 Thread Al Viro
The couple of patches you'd been OK with; no hlist conversion yet, and cursors are still in the list of children. The following changes since commit 4d856f72c10ecb060868ed10ff1b1453943fc6c8: Linux 5.3 (2019-09-15 14:19:32 -0700) are available in the git repository at: git://git.kern

Re: [PATCH v1 0/2] spi: cadence-qspi: Add cadence-qspi support for Intel LGM SoC

2019-10-09 Thread Vignesh Raghavendra
On 10/10/19 7:04 AM, Ramuthevar, Vadivel MuruganX wrote: > HI Vignesh, > > On 17/9/2019 12:50 AM, Vignesh Raghavendra wrote: >> Hi, >> >> On 16/09/19 1:08 PM, Ramuthevar,Vadivel MuruganX wrote: >>> patch 1: Add YAML for cadence-qspi devicetree cdocumentation. >>> patch 2: cadence-qspi controlle

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SC7180

2019-10-09 Thread Stephen Boyd
Quoting Taniya Das (2019-10-09 02:19:39) > Hi Stephen, > > On 10/5/2019 4:50 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2019-10-04 10:39:31) > >> > >> Could you please confirm if you are referring to update the below? > > > > I wasn't suggesting that explicitly but sure. Something like this

Re: [PATCH] net: stmmac: Remove break after a return

2019-10-09 Thread Jakub Kicinski
On Wed, 9 Oct 2019 22:29:00 +0800, Tiezhu Yang wrote: > Since break is not useful after a return, remove it. > > Fixes: 3b57de958e2a ("net: stmmac: Support devicetree configs for mcast and > ucast filter entries") > Signed-off-by: Tiezhu Yang Applied, thanks

Re: [PATCH] rcu: avoid data-race in rcu_gp_fqs_check_wake()

2019-10-09 Thread Eric Dumazet
On Wed, Oct 9, 2019 at 8:18 PM Paul E. McKenney wrote: > Again, good catch, applied for review and testing, thank you! > > I added another READ_ONCE() to dump_blkd_tasks(), which is not exercised > unless you get an RCU CPU stall warning or some such. The updated patch > is below, please let me

Re: [PATCH] net/ethernet: xgmac don't set .driver twice

2019-10-09 Thread Jakub Kicinski
On Wed, 9 Oct 2019 14:26:27 +0100, Ben Dooks wrote: > Cleanup the .driver setup to just do it once, to avoid > the following sparse warning: > > drivers/net/ethernet/calxeda/xgmac.c:1914:10: warning: Initializer entry > defined twice > drivers/net/ethernet/calxeda/xgmac.c:1920:10: also defined

[PATCH] sock_get_timeout: drop unnecessary return variable

2019-10-09 Thread Vito Caputo
Remove pointless use of size return variable by directly returning sizes. Signed-off-by: Vito Caputo --- net/core/sock.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/core/sock.c b/net/core/sock.c index fac2b4d80de5..e01ff0d3be95 100644 --- a/net/core/sock.c ++

Re: [PATCH v2 0/2] Avoid regmap debugfs collisions in qcom llcc driver

2019-10-09 Thread Bjorn Andersson
On Wed 09 Oct 10:59 PDT 2019, Evan Green wrote: > On Wed, Oct 9, 2019 at 10:46 AM Bjorn Andersson > wrote: > > > > On Wed 09 Oct 09:01 PDT 2019, Evan Green wrote: > > > > > On Tue, Oct 8, 2019 at 6:58 PM Stephen Boyd wrote: > > > > > > > > Quoting Bjorn Andersson (2019-10-08 16:55:04) > > > > >

Re: [PATCH -next] userfaultfd: remove set but not used variable 'h'

2019-10-09 Thread Wei Yang
On Wed, Oct 09, 2019 at 08:42:46PM -0700, Mike Kravetz wrote: >On 10/9/19 8:30 PM, Wei Yang wrote: >> On Wed, Oct 09, 2019 at 07:25:18PM -0700, Mike Kravetz wrote: >>> On 10/9/19 6:23 PM, Wei Yang wrote: On Wed, Oct 09, 2019 at 05:45:57PM -0700, Mike Kravetz wrote: > On 10/9/19 5:27 AM, Yu

[PATCH] af_unix: __unix_find_socket_byname() cleanup

2019-10-09 Thread Vito Caputo
Remove pointless return variable dance. Appears vestigial from when the function did locking as seen in unix_find_socket_byinode(), but locking is handled in unix_find_socket_byname() for __unix_find_socket_byname(). Signed-off-by: Vito Caputo --- net/unix/af_unix.c | 6 ++ 1 file changed,

Re: [PATCH -next] userfaultfd: remove set but not used variable 'h'

2019-10-09 Thread Mike Kravetz
On 10/9/19 8:30 PM, Wei Yang wrote: > On Wed, Oct 09, 2019 at 07:25:18PM -0700, Mike Kravetz wrote: >> On 10/9/19 6:23 PM, Wei Yang wrote: >>> On Wed, Oct 09, 2019 at 05:45:57PM -0700, Mike Kravetz wrote: On 10/9/19 5:27 AM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning

[PATCH 4/4] staging: rtl8723bs: Remove unnecessary blank lines

2019-10-09 Thread Wambui Karuga
Remove multiple blank lines in drivers/staging/rtl8723bs/core/rtw_mlme.c. Issues reported by checkpatch.pl as: CHECK: Please don't use multiple blank lines Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 47 --- 1 file changed, 47 deletions(-) di

[PATCH 2/4] staging: rtl8723bs: Remove unnecessary braces for single statements

2019-10-09 Thread Wambui Karuga
Clean up multiple unnecessary braces around single statement blocks in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: WARNING: braces {} are not necessary for single statement blocks or WARNING: braces {} are not necessary for any arm of this statement Signed-off-by

[PATCH 3/4] staging: rtl8723bs: Remove comparisons to booleans in conditionals.

2019-10-09 Thread Wambui Karuga
Remove comparisons to true and false in multiple if statements in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723

[PATCH 0/4] Fix style and formatting issues in rtw_mlme.c

2019-10-09 Thread Wambui Karuga
This patchest addresses multiple style and formatting issues in the file drivers/staging/rtl8723bs/core/rtw_mlme.c. These issues are all reported by checkpatch.pl Wambui Karuga (4): staging: rtl8723bs: Remove comparisons to NULL in conditionals staging: rtl8723bs: Remove unnecessary braces for

[PATCH 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals

2019-10-09 Thread Wambui Karuga
Remove most comparisons to NULL in conditionals in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: CHECK: Comparison to NULL could be written Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 46 +++ 1 file changed, 23

Re: [PATCH] scsi: fix kconfig dependency warning related to 53C700_LE_ON_BE

2019-10-09 Thread Martin K. Petersen
Thomas, > Add the missing depends SCSI_SNI_53C710 to 53C700_LE_ON_BE to fix it. Applied to 5.4/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: sni_53c710 fix compilation error

2019-10-09 Thread Martin K. Petersen
Thomas, > Drop out memory dev_printk() with wring device pointer argument. Applied to 5.4/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/3] dt-bindings: power: add Amlogic secure power domains bindings

2019-10-09 Thread Jianxin Pan
Hi Rob, Thanks for your review. I'm sorry to reply so late, for I've been on vacation in the last week. On 2019/10/2 6:09, Rob Herring wrote: > On Thu, Sep 19, 2019 at 08:11:02AM -0400, Jianxin Pan wrote: >> Add the bindings for the Amlogic Secure power domains, controlling the >> secure power d

Re: [PATCH -next] userfaultfd: remove set but not used variable 'h'

2019-10-09 Thread Wei Yang
On Wed, Oct 09, 2019 at 07:25:18PM -0700, Mike Kravetz wrote: >On 10/9/19 6:23 PM, Wei Yang wrote: >> On Wed, Oct 09, 2019 at 05:45:57PM -0700, Mike Kravetz wrote: >>> On 10/9/19 5:27 AM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: mm/userfaultfd.c: In function '

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-09 Thread Candle Sun
On Thu, Oct 10, 2019 at 2:00 AM Jiri Kosina wrote: > > On Wed, 9 Oct 2019, Nicolas Saenz Julienne wrote: > > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > > index 3eaee2c..3394222 100644 > > > --- a/drivers/hid/hid-core.c > > > +++ b/drivers/hid/hid-core.c > > > @@ -35,6 +35

Re: [PATCH] rcu: avoid data-race in rcu_gp_fqs_check_wake()

2019-10-09 Thread Paul E. McKenney
On Wed, Oct 09, 2019 at 02:21:54PM -0700, Eric Dumazet wrote: > rcu_gp_fqs_check_wake() uses rcu_preempt_blocked_readers_cgp() > to read ->gp_tasks while otehr cpus might write over this field. > > We need READ_ONCE()/WRITE_ONCE() pairs to avoid compiler > tricks and KCSAN splats like the followin

Re: "reuse mergeable anon_vma as parent when fork" causes a crash on s390

2019-10-09 Thread Wei Yang
On Thu, Oct 10, 2019 at 10:36:01AM +0800, Wei Yang wrote: >Hi, Qian, Shakeel > >Thanks for testing. > >Sounds I missed some case to handle. anon_vma_clone() now would be called in >vma_adjust, which is a different case when it is introduced. > Well, I have to correct my statement. The reason is we

[PATCH] KPC2000: kpc2000_spi.c: Fix style issues (Unecessary parenthesis)

2019-10-09 Thread Chandra Annamaneni
Resolved: CHECK: Unnecessary parentheses around table[i] Signed-off-by: Chandra Annamaneni --- drivers/staging/kpc2000/kpc2000_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c index 2082d86..e

[PATCH] KPC2000: kpc2000_spi.c: Fix style issues (misaligned brace)

2019-10-09 Thread Chandra Annamaneni
Resolved: ERROR: else should follow close brace '}' Signed-off-by: Chandra Annamaneni --- drivers/staging/kpc2000/kpc2000_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c index ccf88b8..2082

[PATCH] KPC2000: kpc2000_spi.c: Fix style issues (alignment)

2019-10-09 Thread Chandra Annamaneni
Resolved: "CHECK: Alignment should match open parenthesis" from checkpatch.pl Signed-off-by: Chandra Annamaneni --- drivers/staging/kpc2000/kpc2000_spi.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kp

[PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)

2019-10-09 Thread Chandra Annamaneni
Resoved: "WARNING: line over 80 characters" from checkpatch.pl Signed-off-by: Chandra Annamaneni --- drivers/staging/kpc2000/kpc2000_spi.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/k

[PATCH] KPC2000: kpc2000_spi.c: Fix style issues (missing blank line)

2019-10-09 Thread Chandra Annamaneni
Resolved: "CHECK: Please use a blank line after.." from checkpatch.pl Signed-off-by: Chandra Annamaneni --- drivers/staging/kpc2000/kpc2000_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c index ef78b6d..0d51

Re: [PATCH] rcu: Fix data-race due to atomic_t copy-by-value

2019-10-09 Thread Paul E. McKenney
On Wed, Oct 09, 2019 at 05:57:43PM +0200, Marco Elver wrote: > This fixes a data-race where `atomic_t dynticks` is copied by value. The > copy is performed non-atomically, resulting in a data-race if `dynticks` > is updated concurrently. > > This data-race was found with KCSAN: > =

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-09 Thread Candle Sun
On Thu, Oct 10, 2019 at 1:01 AM Nicolas Saenz Julienne wrote: > > On Wed, 2019-10-09 at 20:53 +0800, Candle Sun wrote: > > From: Candle Sun > > > > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation > > to Main item") adds support for Usage Page item after Usage ID items > >

[PATCH v3 2/2] mfd: intel-lpss: use devm_ioremap_uc for MMIO

2019-10-09 Thread Tuowen Zhao
Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci in MTRR. This will cause the system to hang during boot. If possible, this bug could be corrected with a firmware update. This patch use devm_ioremap_uc to overwrite/ignore the MTRR settings by forcing the use of strongly uncac

[PATCH v3 1/2] lib: devres: add a helper function for ioremap_uc

2019-10-09 Thread Tuowen Zhao
Implement a resource managed strongly uncachable ioremap function. Tested-by: AceLan Kao Signed-off-by: Tuowen Zhao Acked-by: Mika Westerberg Acked-by: Andy Shevchenko --- Changes from previous version: * Split the patch in 2 * Use GPL export for devm_ioremap_uc * Add entry to devres do

[git pull] a couple of mount fixes

2019-10-09 Thread Al Viro
A couple of regressions from work.mount series. The following changes since commit a3bc18a48e2e678efe62f1f9989902f9cd19e0ff: jffs2: Fix mounting under new mount API (2019-09-26 10:26:55 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/viro

[PATCH] kvm/x86 : Replace BUG_ON(1) with BUG()

2019-10-09 Thread richard.p...@oppo.com
Signed-off-by: Peng Hao ---  arch/x86/kvm/vmx/nested.c | 3 +--  1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c index e76eb4f..d0e6c40 100644 --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -4945,8 +4945,7 @@ sta

Re: [PATCH] devfreq: exynos-bus: workaround dev_pm_opp_set_rate() errors on Exynos5422/5800 SoCs

2019-10-09 Thread Chanwoo Choi
On 2019년 10월 08일 22:49, k.koniec...@partner.samsung.com wrote: > Commit 4294a779bd8d ("PM / devfreq: exynos-bus: Convert to use > dev_pm_opp_set_rate()") introduced errors: > exynos-bus: new bus device registered: soc:bus_wcore ( 84000 KHz ~ 40 KHz) > exynos-bus: new bus device registered: soc:

Re: [PATCH RFC] perf_event: Add support for LSM and SELinux checks

2019-10-09 Thread James Morris
On Wed, 9 Oct 2019, Casey Schaufler wrote: > On 10/9/2019 3:14 PM, James Morris wrote: > > On Wed, 9 Oct 2019, Casey Schaufler wrote: > > > >> Please consider making the perf_alloc security blob maintained > >> by the infrastructure rather than the individual modules. This > >> will save it having

Re: [RESEND,PATCH] net: stmmac: dwmac-mediatek: fix wrong delay value issue when resume back

2019-10-09 Thread Jakub Kicinski
On Wed, 9 Oct 2019 15:33:48 +0800, Biao Huang wrote: > mac_delay value will be divided by 550/170 in mt2712_delay_ps2stage(), > which is invoked at the beginning of mt2712_set_delay(), and the value > should be restored at the end of mt2712_set_delay(). > Or, mac_delay will be divided again when in

[PATCH v7] gpio/mpc8xxx: change irq handler from chained to normal

2019-10-09 Thread Hui Song
From: Song Hui More than one gpio controllers can share one interrupt, change the driver to request shared irq. While this will work, it will mess up userspace accounting of the number of interrupts per second in tools such as vmstat. The reason is that for every GPIO interrupt, /proc/interrupt

Re: [PATCH v3 5/6] x86/ftrace: Use text_poke()

2019-10-09 Thread Steven Rostedt
On Tue, 8 Oct 2019 10:43:35 -0400 Steven Rostedt wrote: > BTW, I'd really like to take this patch series through my tree. That > way I can really hammer it, as well as I have code that will be built > on top of it. I did a bit of hammering and found two bugs. One I sent a patch to fix (adding a

Re: [PATCH tip/core/rcu 4/9] drivers/scsi: Replace rcu_swap_protected() with rcu_replace()

2019-10-09 Thread Martin K. Petersen
Paul, > I do not intend to actually remove rcu_swap_protected() until 5.6 for > exactly this sort of thing. My plan is to take another pass through > the tree after 5.5 comes out, and these will be caught at that time. > > Does that work for you? Yep, that's great. Thanks! -- Martin K. Peter

[PATCH] ftrace/module: Allow ftrace to make only loaded module text read-write

2019-10-09 Thread Steven Rostedt
From: Steven Rostedt (VMware) In the process of using text_poke_bp() for ftrace on x86, when performing the following action: # rmmod snd_hda_codec_hdmi # echo function > /sys/kernel/tracing/current_tracer # modprobe snd_hda_codec_hdmi It triggered this: BUG: unable to handle page fault fo

Re: "reuse mergeable anon_vma as parent when fork" causes a crash on s390

2019-10-09 Thread Wei Yang
Hi, Qian, Shakeel Thanks for testing. Sounds I missed some case to handle. anon_vma_clone() now would be called in vma_adjust, which is a different case when it is introduced. BTW, do you have the specific test case? So that I could verify my change. The kernel build test doesn't trigger this.

Re: [PATCH] scsi: ch: add include guard to chio.h

2019-10-09 Thread Martin K. Petersen
Masahiro, >> Fine with me. Is it going through your tree or should I pick it up? > > Could you please apply it to your tree? Applied to 5.5/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: fix a potential NULL pointer dereference

2019-10-09 Thread Martin K. Petersen
Allen, > alloc_workqueue is not checked for errors and as a result, > a potential NULL dereference could occur. Applied to 5.4/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v17 01/14] bitops: Introduce the for_each_set_clump8 macro

2019-10-09 Thread Masahiro Yamada
On Thu, Oct 10, 2019 at 3:54 AM Geert Uytterhoeven wrote: > > Hi Andy, > > On Wed, Oct 9, 2019 at 7:09 PM Andy Shevchenko > wrote: > > On Thu, Oct 10, 2019 at 01:28:08AM +0900, Masahiro Yamada wrote: > > > On Thu, Oct 10, 2019 at 12:27 AM William Breathitt Gray > > > wrote: > > > > > > > > This

Re: [PATCH -next] userfaultfd: remove set but not used variable 'h'

2019-10-09 Thread Mike Kravetz
On 10/9/19 6:23 PM, Wei Yang wrote: > On Wed, Oct 09, 2019 at 05:45:57PM -0700, Mike Kravetz wrote: >> On 10/9/19 5:27 AM, YueHaibing wrote: >>> Fixes gcc '-Wunused-but-set-variable' warning: >>> >>> mm/userfaultfd.c: In function '__mcopy_atomic_hugetlb': >>> mm/userfaultfd.c:217:17: warning: >>>

Re: [Patch v4 2/2] linux/bits.h: Add compile time sanity check of GENMASK inputs

2019-10-09 Thread Masahiro Yamada
On Thu, Oct 10, 2019 at 6:45 AM Rikard Falkeborn wrote: > > GENMASK() and GENMASK_ULL() are supposed to be called with the high bit > as the first argument and the low bit as the second argument. Mixing > them will return a mask with zero bits set. > > Recent commits show getting this wrong is not

Re: [PATCH net-next] act_mirred: Fix mirred_init_module error handling

2019-10-09 Thread Jakub Kicinski
On Wed, 9 Oct 2019 11:10:52 +0800, YueHaibing wrote: > If tcf_register_action failed, mirred_device_notifier > should be unregistered. > > Fixes: 3b87956ea645 ("net sched: fix race in mirred device removal") > Signed-off-by: YueHaibing Why does the subject say net-next, looks like the bug was in

  1   2   3   4   5   6   7   8   9   10   >