This patch adds the SC2731 PMIC switch charger support.
Signed-off-by: Baolin Wang
Reviewed-by: Krzysztof Kozlowski
---
Changes from v2:
- Add reviewed tag from Krzysztof.
- Change current unit to uA instead of mA.
Changes from v1:
- Remove some redundant head files.
- Add one mutex to
This patch adds the binding documentation for Spreadtrum SC2731 charger
device.
Signed-off-by: Baolin Wang
Reviewed-by: Krzysztof Kozlowski
---
Changes from v2:
- Add reviewed tag from Krzysztof.
Changes from v1:
- Add parent node.
- Add some battery standard properties.
---
.../bindings
The devm_ioremap_resource() will valid the resources, thus remove the
unnecessary resource validation in the driver.
Signed-off-by: Baolin Wang
Acked-by: Chunyan Zhang
---
Changes from v1:
- Add acked tag from Chunyan.
---
drivers/tty/serial/sprd_serial.c | 7 ++-
1 file changed, 2
The register offset value should be 'unsigned int' type.
Moreover, prefer 'unsigned int' to bare use of 'unsigned'.
Signed-off-by: Baolin Wang
Acked-by: Chunyan Zhang
---
Changes from v1:
- Add acked tag from Chunyan.
---
drivers/tty/serial/sprd_serial.c |
Define readable macros instead of magic number to make code more readable.
Signed-off-by: Baolin Wang
Acked-by: Chunyan Zhang
---
Changes from v1:
- Add acked tag from Chunyan.
---
drivers/tty/serial/sprd_serial.c | 25 +
1 file changed, 17 insertions(+), 8 deletions
Remove the unused reg_backup structure.
Signed-off-by: Baolin Wang
Acked-by: Chunyan Zhang
---
Changes from v1:
- Add acked tag from Chunyan.
---
drivers/tty/serial/sprd_serial.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty
Make the macros' definition and code have the same correct indentation.
Signed-off-by: Baolin Wang
Acked-by: Chunyan Zhang
---
Changes from v1:
- Add acked tag from Chunyan.
---
drivers/tty/serial/sprd_serial.c | 46 +++-
1 file changed, 22 inser
+
>> + return 0;
>> +}
>> +
>> +static int sc27xx_fgu_probe(struct platform_device *pdev)
>> +{
>> + struct device_node *np = pdev->dev.of_node;
>> + struct power_supply_config fgu_cfg = { };
>> + struct sc27xx_fgu_data *data;
>> + int ret, irq;
>> +
>> + data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
>> + if (!data)
>> + return -ENOMEM;
>> +
>> + data->regmap = dev_get_regmap(pdev->dev.parent, NULL);
>> + if (!data->regmap) {
>> + dev_err(&pdev->dev, "failed to get regmap\n");
>> + return -ENODEV;
>> + }
>> +
>> + mutex_init(&data->lock);
>> + data->dev = &pdev->dev;
>> + data->bat_present = true;
>> +
>> + ret = sc27xx_fgu_parse_dt(data, np);
>> + if (ret)
>> + return ret;
>> +
>> + fgu_cfg.drv_data = data;
>> + fgu_cfg.of_node = np;
>> + data->battery = devm_power_supply_register(&pdev->dev,
>> &sc27xx_fgu_desc,
>> +&fgu_cfg);
>> + if (IS_ERR(data->battery)) {
>> + dev_err(&pdev->dev, "failed to register power supply\n");
>> + return PTR_ERR(data->battery);
>> + }
>> +
>> + ret = sc27xx_fgu_hw_init(data);
>> + if (ret) {
>> + dev_err(&pdev->dev, "failed to initialize fgu hardware\n");
>> + return ret;
>> + }
>> +
>> + ret = devm_add_action(&pdev->dev, sc27xx_fgu_disable, data);
>> + if (ret) {
>> + sc27xx_fgu_disable(data);
>> + dev_err(&pdev->dev, "failed to add fgu disable action\n");
>> + return ret;
>> + }
>> +
>> + irq = gpiod_to_irq(data->gpiod);
>> + if (irq < 0) {
>> + dev_err(&pdev->dev, "failed to translate GPIO to IRQ\n");
>> + return irq;
>> + }
>> +
>> + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
>> + sc27xx_fgu_bat_detection,
>> + IRQF_ONESHOT | IRQF_TRIGGER_RISING |
>> + IRQF_TRIGGER_FALLING,
>> + pdev->name, data);
>> + if (ret) {
>> + dev_err(&pdev->dev, "failed to request IRQ\n");
>> + return ret;
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +static const struct of_device_id sc27xx_fgu_of_match[] = {
>> + { .compatible = "sprd,sc2731-fgu", },
>> + { }
>> +};
>> +
>> +static struct platform_driver sc27xx_fgu_driver = {
>> + .probe = sc27xx_fgu_probe,
>> + .driver = {
>> + .name = "sc27xx-fgu",
>> + .of_match_table = sc27xx_fgu_of_match,
>> + }
>> +};
>> +
>> +module_platform_driver(sc27xx_fgu_driver);
>> +
>> +MODULE_DESCRIPTION("Spreadtrum SC27XX PMICs Fual Gauge Unit Driver");
>> +MODULE_LICENSE("GPL v2");
>> --
>> 1.7.9.5
>>
--
Baolin Wang
Best Regards
Hi Sebastian,
On 16 September 2018 at 21:57, Sebastian Reichel
wrote:
> Hi,
>
> On Wed, Sep 12, 2018 at 03:29:38PM +0800, Baolin Wang wrote:
>> This patch adds the binding documentation for Spreadtrum SC27XX series PMICs
>> fuel gauge unit device, which is used to calculate
Hi Sebastian,
On 16 September 2018 at 18:17, Sebastian Reichel
wrote:
> Hi Baolin,
>
> On Mon, Sep 03, 2018 at 04:55:46PM +0800, Baolin Wang wrote:
>> This patch adds the SC2731 PMIC switch charger support.
>>
>> Signed-off-by: Baolin Wang
>> ---
>
> The p
This patch adds the Spreadtrum SC27XX serial PMICs fuel gauge support,
which is used to calculate the battery capacity.
Original-by: Yuanjiang Yu
Signed-off-by: Baolin Wang
---
drivers/power/supply/Kconfig |7 +
drivers/power/supply/Makefile|1 +
drivers/power
This patch adds the binding documentation for Spreadtrum SC27XX series PMICs
fuel gauge unit device, which is used to calculate the battery capacity.
Signed-off-by: Baolin Wang
---
.../devicetree/bindings/power/supply/sc27xx-fg.txt | 55
1 file changed, 55 insertions
Hi,
On 4 September 2018 at 14:52, Chunyan Zhang wrote:
> On 11 August 2018 at 09:34, Baolin Wang wrote:
>> Remove the unused reg_backup structure.
>>
>> Signed-off-by: Baolin Wang
>
> Acked-by: Chunyan Zhang
Thanks Chunyan.
Greg, could you apply this patch set i
can write 'hw_pattern' file to enable the hardware
pattern for some LED controllers which can autonomously control
brightness over time, according to some preprogrammed hardware
patterns.
Signed-off-by: Raphael Teysseyre
Signed-off-by: Baolin Wang
---
Changes from v11:
- Change -1 means
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
Acked-by: Pavel Machek
---
Changes from v11:
- None.
Changes from v10:
- Add duration alignment function suggested by Jacek.
- Add
gt; show negative numbers or one string "infinite"?
>
> I'd say just -1 is infinite, anything else is error.
>
> And yes, reading it should just display -1.
OK. Thanks.
--
Baolin Wang
Best Regards
On 9 September 2018 at 04:19, Jacek Anaszewski
wrote:
> Hi Bjorn,
>
> On 09/08/2018 07:02 AM, Bjorn Andersson wrote:
>> On Tue 04 Sep 04:01 PDT 2018, Baolin Wang wrote:
>>
>>> diff --git a/Documentation/ABI/testing/sysfs-class-led-trigger-pattern
>>> b/Do
can write 'hw_pattern' file to enable the hardware
pattern for some LED controllers which can autonomously control
brightness over time, according to some preprogrammed hardware
patterns.
Signed-off-by: Raphael Teysseyre
Signed-off-by: Baolin Wang
---
Changes from v10:
- Change 'int&#x
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
Acked-by: Pavel Machek
---
Changes from v10:
- Add duration alignment function suggested by Jacek.
- Add acked tag from Pavel.
Changes
"0 rise_duration brightness high_duration brightness
> fall_duration 0 low_duration".
>
> Right?
Hmmm, for SC27XX led, there is no need to set brightness for rise and
fall stage.
>
> With that fixed:
>
> Acked-by: Pavel Machek
Thanks.
--
Baolin Wang
Best Regards
06/2018 04:37 AM, Baolin Wang wrote:
>> This patch implements the 'pattern_set'and 'pattern_clear'
>> interfaces to support SC27XX LED breathing mode.
>>
>> Signed-off-by: Baolin Wang
>> ---
>> Changes from v9:
>> - Optimize
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
---
Changes from v9:
- Optimize the ABI documentation file.
- Update the brightness value in hardware pattern mode.
Changes from v8:
On 6 September 2018 at 09:43, Baolin Wang wrote:
> Hi Jacek,
>
> On 6 September 2018 at 03:14, Jacek Anaszewski
> wrote:
>> Hi Baolin,
>>
>> Thanks for the v9.
>>
>> On 09/05/2018 09:20 AM, Baolin Wang wrote:
>>> This patch implements the
Hi Jacek,
On 6 September 2018 at 03:14, Jacek Anaszewski
wrote:
> Hi Baolin,
>
> Thanks for the v9.
>
> On 09/05/2018 09:20 AM, Baolin Wang wrote:
>> This patch implements the 'pattern_set'and 'pattern_clear'
>> interfaces to support SC27XX LED b
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
---
Changes from v8:
- Optimize the ABI documentation file.
Changes from v7:
- Add its own ABI documentation file.
Changes from v6:
- No
On 5 September 2018 at 10:43, Baolin Wang wrote:
> Hi Jacek,
>
> On 5 September 2018 at 04:19, Jacek Anaszewski
> wrote:
>> Hi Baolin,
>>
>> On 09/04/2018 01:01 PM, Baolin Wang wrote:
>>> This patch implements the 'pattern_set'and 'pattern
Hi Jacek,
On 5 September 2018 at 04:19, Jacek Anaszewski
wrote:
> Hi Baolin,
>
> On 09/04/2018 01:01 PM, Baolin Wang wrote:
>> This patch implements the 'pattern_set'and 'pattern_clear'
>> interfaces to support SC27XX LED breathing mode.
>>
>&g
can write 'hw_pattern' file to enable the hardware
pattern for some LED controllers which can autonomously control
brightness over time, according to some preprogrammed hardware
patterns.
Signed-off-by: Raphael Teysseyre
Signed-off-by: Baolin Wang
---
Changes from v7:
- Move the SC27
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
---
Changes from v7:
- Add its own ABI documentation file.
Changes from v6:
- None.
Changes from v5:
- None.
Changes from v4:
- No
Hi,
On 11 August 2018 at 09:34, Baolin Wang wrote:
> Remove the unused reg_backup structure.
>
> Signed-off-by: Baolin Wang
> ---
Do you have any comments for this patch set? Thanks.
--
Baolin Wang
Best Regards
gt; LED synchronization.)
>
> (And yes, one of the LED chip has pattern engine that can compute
> prime numbers on its own. I don't expect to support
> _that_. Fortunately, nobody but me is likely to want that pattern, so
> we are still okay :-)
Thanks for your explanation here. So I think I should keep the same
logics in next version.
--
Baolin Wang
Best Regards
Hi Jacek,
On 4 September 2018 at 02:58, Jacek Anaszewski
wrote:
> Hi Baolin,
>
> Thank you for the update.
>
> Please find my remarks below.
>
> On 08/31/2018 09:52 AM, Baolin Wang wrote:
>> This patch adds one new led trigger that LED device can configure
>> the
This patch adds the binding documentation for Spreadtrum SC2731 charger
device.
Signed-off-by: Baolin Wang
---
Changes from v1:
- Add parent node.
- Add some battery standard properties.
---
.../bindings/power/supply/sc2731_charger.txt | 40
1 file changed, 40
This patch adds the SC2731 PMIC switch charger support.
Signed-off-by: Baolin Wang
---
Changes from v1:
- Remove some redundant head files.
- Add one mutex to make sure getting the charger status is correct.
- Fix some coding style issues.
- Use standard DT properties.
---
drivers/power
Hi Jonathan,
On 2 September 2018 at 16:51, Jonathan Cameron wrote:
> On Wed, 29 Aug 2018 14:04:04 +0800
> Baolin Wang wrote:
>
>> The headset device will use channel 20 of ADC controller to detect events,
>> but it needs the raw ADC data to do conversion according to its ow
On 29 August 2018 at 19:33, Jan Kundrát wrote:
> On čtvrtek 16. srpna 2018 14:54:49 CEST, Baolin Wang wrote:
>>
>> + * @word_delay: clock cycles to inter word delay after each word size
>> + * (set by bits_per_word) transmission.
>
>
> I need a similar func
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
---
Changes from v6:
- None.
Changes from v5:
- None.
Changes from v4:
- None.
Changes from v3:
- None.
Changes from v2:
- No
can write 'hw_pattern' file to enable the hardware
pattern for some LED controllers which can autonomously control
brightness over time, according to some preprogrammed hardware
patterns.
Signed-off-by: Raphael Teysseyre
Signed-off-by: Baolin Wang
---
Changes from v6:
- Improve commit mess
Hi Sebastian,
On 31 August 2018 at 05:27, Sebastian Reichel wrote:
> Hi,
>
> On Thu, Aug 30, 2018 at 11:08:59AM +0800, Baolin Wang wrote:
>> >> +static int sc2731_charger_hw_init(struct sc2731_charger_info *info)
>> >> +{
>> >> + int ret;
&
Hi Jacek,
On 31 August 2018 at 03:55, Jacek Anaszewski wrote:
> Hi Baolin,
>
> On 08/30/2018 09:40 AM, Baolin Wang wrote:
>> Some LED controllers have support for autonomously controlling
>> brightness over time, according to some preprogrammed pattern or
>> func
Some LED controllers have support for autonomously controlling
brightness over time, according to some preprogrammed pattern or
function.
This patch adds pattern trigger that LED device can configure the
pattern and trigger it.
Signed-off-by: Raphael Teysseyre
Signed-off-by: Baolin Wang
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
---
Changes from v5:
- None.
Changes from v4:
- None.
Changes from v3:
- None.
Changes from v2:
- None.
Changes from v1:
- Remove p
Hi Jacek,
On 30 August 2018 at 11:26, Baolin Wang wrote:
> Hi Jacek,
>
> On 30 August 2018 at 03:15, Jacek Anaszewski
> wrote:
>> Hi Baolin,
>>
>> On 08/29/2018 11:48 AM, Baolin Wang wrote:
>>> Hi Jacek,
>>>
>>> On 29 August 2018 at 04:2
Hi Jacek,
On 30 August 2018 at 03:15, Jacek Anaszewski wrote:
> Hi Baolin,
>
> On 08/29/2018 11:48 AM, Baolin Wang wrote:
>> Hi Jacek,
>>
>> On 29 August 2018 at 04:25, Jacek Anaszewski
>> wrote:
>>> On 08/25/2018 09:51 AM, Baolin Wang wrote:
>>
Hi Krzysztof,
On 29 August 2018 at 22:36, Krzysztof Kozlowski wrote:
> I'll try one more time... but without HTML from Gmail. Previous mail
> bounced from lists.
>
> On Tue, 28 Aug 2018 at 11:04, Baolin Wang wrote:
>>
>> This patch adds the SC2731 PMIC switch char
Hi Krzysztof,
On 29 August 2018 at 22:08, Krzysztof Kozlowski wrote:
> On Tue, 28 Aug 2018 at 11:04, Baolin Wang wrote:
>>
>> This patch adds the binding documentation for Spreadtrum SC2731 charger
>> device.
>>
>> Signed-off-by: Baolin Wang
>
Hi Jacek,
On 29 August 2018 at 04:25, Jacek Anaszewski wrote:
> On 08/25/2018 09:51 AM, Baolin Wang wrote:
>> On 25 August 2018 at 04:44, Jacek Anaszewski
>> wrote:
>>> On 08/24/2018 10:12 PM, Pavel Machek wrote:
>>>> On Fri 2018-08-24 21:49:50, Ja
.
Signed-off-by: Baolin Wang
---
Changes from v1:
- None.
---
drivers/iio/adc/sc27xx_adc.c | 80 --
1 file changed, 45 insertions(+), 35 deletions(-)
diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c
index 2b60efe..153c311 100644
--- a
This patch adds support to read calibration values from the eFuse
controller to calibrate the ADC channel scales, which can make ADC
sample data more accurate.
Signed-off-by: Baolin Wang
---
Changes from v1:
- Use nvmem_cell_read() instead of nvmem_cell_read_u32().
---
.../bindings/iio/adc
^~
>
> (and many more)
>
> Caused by commit
>
> e7d973a31c24 ("spi: sprd: Add SPI driver for Spreadtrum SC9860")
>
> I have used the spi tree from next-20180828 for today.
You missed one patch (spi: Introduce one new field to set word delay),
could you ap
From: Eric Long
The Spreadtrum DMA can support the link-list transaction mode, which means
DMA controller can do transaction one by one automatically once we linked
these transaction by link-list register.
Signed-off-by: Eric Long
Signed-off-by: Baolin Wang
---
Changes since v1:
- Remove
This patch adds the SC2731 PMIC switch charger support.
Signed-off-by: Baolin Wang
---
drivers/power/supply/Kconfig |7 +
drivers/power/supply/Makefile |1 +
drivers/power/supply/sc2731_charger.c | 451 +
3 files changed, 459 insertions
This patch adds the binding documentation for Spreadtrum SC2731 charger
device.
Signed-off-by: Baolin Wang
---
.../bindings/power/supply/sc2731_charger.txt | 14 ++
1 file changed, 14 insertions(+)
create mode 100644
Documentation/devicetree/bindings/power/supply
Hi Jonathan,
On 25 August 2018 at 16:43, Jonathan Cameron wrote:
> On Fri, 24 Aug 2018 17:53:16 +0800
> Baolin Wang wrote:
>
>> This patch adds support to read calibration values from the eFuse
>> controller to calibrate the ADC channel scales, which can make ADC
>>
Hi Jonathan,
On 25 August 2018 at 16:38, Jonathan Cameron wrote:
> On Fri, 24 Aug 2018 17:53:15 +0800
> Baolin Wang wrote:
>
>> The headset device will use channel 20 of ADC controller to detect events,
>> but it needs the raw ADC data to do conversion according to its ow
tern_clear(led_cdev);
- else
- del_timer_sync(&data->timer);
+ del_timer_sync(&data->timer);
led_set_brightness(led_cdev, LED_OFF);
kfree(data);
led_cdev->activated = false;
diff --git a/include/linux/leds.h b/include/linux/leds.h
index 74fc2c6..04f3eaf 100644
--- a/include/linux/leds.h
+++ b/include/linux/leds.h
@@ -93,6 +93,8 @@ struct led_classdev {
struct led_pattern *pattern, int len,
unsigned int repeat);
int (*pattern_clear)(struct led_classdev *led_cdev);
+ int (*pattern_convert)(struct led_classdev *led_cdev,
+ struct led_pattern *pattern, int *len);
struct device *dev;
const struct attribute_group**groups;
--
Baolin Wang
Best Regards
This patch adds support to read calibration values from the eFuse
controller to calibrate the ADC channel scales, which can make ADC
sample data more accurate.
Signed-off-by: Baolin Wang
---
.../bindings/iio/adc/sprd,sc27xx-adc.txt |4 ++
drivers/iio/adc/sc27xx_adc.c
.
Signed-off-by: Baolin Wang
---
drivers/iio/adc/sc27xx_adc.c | 80 --
1 file changed, 45 insertions(+), 35 deletions(-)
diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c
index 2b60efe..153c311 100644
--- a/drivers/iio/adc/sc27xx_adc.c
Hi Vinod,
On 9 August 2018 at 15:05, Baolin Wang wrote:
> From: Eric Long
>
> The Spreadtrum DMA can support the link-list transaction mode, which means
> DMA controller can do transaction one by one automatically once we linked
> these transaction by link-list register.
>
>
From: Lanqing Liu
This patch adds the binding documentation for Spreadtrum SPI
controller device.
Signed-off-by: Lanqing Liu
Signed-off-by: Baolin Wang
---
Changes from v1:
- Remove the sprd,spi-interval property.
---
Documentation/devicetree/bindings/spi/spi-sprd.txt | 26
From: Lanqing Liu
This patch adds the SPI controller driver for Spreadtrum SC9860 platform.
Signed-off-by: Lanqing Liu
Signed-off-by: Baolin Wang
---
Changes from v1:
- Enable the auto_runtime_pm of SPI core.
- Remove the sprd_spi_setup() function.
- Move the hardware SPI hardware
word delay time.
Signed-off-by: Baolin Wang
---
Changes from v1:
- New patch in v2.
---
include/linux/spi/spi.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index a64235e..d698f9d 100644
--- a/include/linux/spi/spi.h
+++ b/include
Hi Rob,
On 15 August 2018 at 04:27, Rob Herring wrote:
> On Thu, Aug 09, 2018 at 11:03:11AM +0800, Baolin Wang wrote:
>> Hi Trent,
>>
>> On 9 August 2018 at 02:57, Trent Piepho wrote:
>> > On Wed, 2018-08-08 at 11:54 +0100, Mark Brown wrote:
>> >>
Hi Rob,
On 15 August 2018 at 04:21, Rob Herring wrote:
> On Tue, Aug 07, 2018 at 06:43:37PM +0800, Baolin Wang wrote:
>> From: Lanqing Liu
>>
>> This patch adds the binding documentation for Spreadtrum SPI
>> controller device.
>>
>> Signed-off-by: Lan
Hi Jacek,
On 11 August 2018 at 02:10, Jacek Anaszewski wrote:
> Hi Baolin,
>
> On 08/10/2018 05:26 PM, Baolin Wang wrote:
>> Hi Jacek,
>>
>> On 9 August 2018 at 21:21, Jacek Anaszewski
>> wrote:
>>> Hi Baolin,
>>>
>>> On 08/09/2018
The devm_ioremap_resource() will valid the resources, thus remove the
unnecessary resource validation in the driver.
Signed-off-by: Baolin Wang
---
drivers/tty/serial/sprd_serial.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/sprd_serial.c b
Define readable macros instead of magic number to make code more readable.
Signed-off-by: Baolin Wang
---
drivers/tty/serial/sprd_serial.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial
Make the macros' definition and code have the same correct indentation.
Signed-off-by: Baolin Wang
---
drivers/tty/serial/sprd_serial.c | 46 +++-
1 file changed, 22 insertions(+), 24 deletions(-)
diff --git a/drivers/tty/serial/sprd_serial.c b/driver
Remove the unused reg_backup structure.
Signed-off-by: Baolin Wang
---
drivers/tty/serial/sprd_serial.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c
index 828f114..1b0e3fb 100644
--- a/drivers/tty/serial
The register offset value should be 'unsigned int' type.
Moreover, prefer 'unsigned int' to bare use of 'unsigned'.
Signed-off-by: Baolin Wang
---
drivers/tty/serial/sprd_serial.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/driv
Hi Jacek,
On 9 August 2018 at 21:21, Jacek Anaszewski wrote:
> Hi Baolin,
>
> On 08/09/2018 07:48 AM, Baolin Wang wrote:
> [...]
>>>>>> +static int pattern_trig_start_pattern(struct pattern_trig_data *data,
>>>>>> +
From: Eric Long
The Spreadtrum DMA can support the link-list transaction mode, which means
DMA controller can do transaction one by one automatically once we linked
these transaction by link-list register.
Signed-off-by: Eric Long
Signed-off-by: Baolin Wang
---
Changes since v1:
- Remove
Hi Jacek,
On 9 August 2018 at 05:28, Jacek Anaszewski wrote:
> Hi Baolin,
>
> On 08/08/2018 08:01 AM, Baolin Wang wrote:
>> Hi Jacek,
>>
>> On 8 August 2018 at 05:54, Jacek Anaszewski
>> wrote:
>>> Hi Baolin,
>>>
>>> Thank you f
Hi Vinod,
(Comments from Eric Long)
On 9 August 2018 at 10:32, Vinod wrote:
> On 26-07-18, 16:00, Baolin Wang wrote:
>> From: Eric Long
>>
>> The Spreadtrum DMA can support the link-list transaction mode, which means
>> DMA controller can do transaction one by one a
Hi Trent,
On 9 August 2018 at 03:08, Trent Piepho wrote:
> On Wed, 2018-08-08 at 11:19 +0800, Baolin Wang wrote:
>> On 8 August 2018 at 01:10, Trent Piepho wrote:
>> > On Tue, 2018-08-07 at 18:43 +0800, Baolin Wang wrote:
>> > >
>> > > +static u32 spr
Hi Trent,
On 9 August 2018 at 02:57, Trent Piepho wrote:
> On Wed, 2018-08-08 at 11:54 +0100, Mark Brown wrote:
>> On Wed, Aug 08, 2018 at 06:35:28PM +0800, Baolin Wang wrote:
>> > On 8 August 2018 at 17:50, Mark Brown wrote:
>> > > Right, I don't think we ad
On 8 August 2018 at 18:54, Mark Brown wrote:
> On Wed, Aug 08, 2018 at 06:35:28PM +0800, Baolin Wang wrote:
>> On 8 August 2018 at 17:50, Mark Brown wrote:
>
>> > Right, I don't think we added this yet (if we did I can't see it). I'd
>> > add a n
On 8 August 2018 at 17:50, Mark Brown wrote:
> On Wed, Aug 08, 2018 at 10:26:42AM +0800, Baolin Wang wrote:
>
>> Sorry for confusing. Let me try to explain it explicitly.
>> We can set the word size (bits_per_word) for each transmission, for
>> our SPI controller
On 8 August 2018 at 17:31, Mark Brown wrote:
> On Wed, Aug 08, 2018 at 10:45:33AM +0800, Baolin Wang wrote:
>> On 7 August 2018 at 22:24, Mark Brown wrote:
>> > On Tue, Aug 07, 2018 at 06:43:38PM +0800, Baolin Wang wrote:
>
>> >> + bits_per_word = bits_per_w
dification, please take a look below.
Sure.
>
> On 08/06/2018 02:05 PM, Baolin Wang wrote:
>> Some LED controllers have support for autonomously controlling
>> brightness over time, according to some preprogrammed pattern or
>> function.
>>
>> This patch
Hi Trent,
On 8 August 2018 at 01:10, Trent Piepho wrote:
> On Tue, 2018-08-07 at 18:43 +0800, Baolin Wang wrote:
>>
>> +static u32 sprd_spi_transfer_max_timeout(struct sprd_spi *ss,
>> + struct spi_transfer *t)
>> +{
>> +
Hi Mark,
On 7 August 2018 at 22:24, Mark Brown wrote:
> On Tue, Aug 07, 2018 at 06:43:38PM +0800, Baolin Wang wrote:
>> From: Lanqing Liu
>>
>> This patch adds the SPI controller driver for Spreadtrum SC9860 platform.
>
> This all looks pretty clean, a few comments
Hi Mark,
On 7 August 2018 at 21:41, Mark Brown wrote:
> On Tue, Aug 07, 2018 at 06:43:37PM +0800, Baolin Wang wrote:
>
>> +Optional properties:
>> +- sprd,spi-interval: Specify the intervals of two SPI frames, which can be
>> + converted to the delay clock cycles =
From: Lanqing Liu
This patch adds the SPI controller driver for Spreadtrum SC9860 platform.
Signed-off-by: Lanqing Liu
Signed-off-by: Baolin Wang
---
drivers/spi/Kconfig|6 +
drivers/spi/Makefile |1 +
drivers/spi/spi-sprd.c | 771
From: Lanqing Liu
This patch adds the binding documentation for Spreadtrum SPI
controller device.
Signed-off-by: Lanqing Liu
Signed-off-by: Baolin Wang
---
Documentation/devicetree/bindings/spi/spi-sprd.txt | 31
1 file changed, 31 insertions(+)
create mode 100644
Some LED controllers have support for autonomously controlling
brightness over time, according to some preprogrammed pattern or
function.
This patch adds pattern trigger that LED device can configure the
pattern and trigger it.
Signed-off-by: Raphael Teysseyre
Signed-off-by: Baolin Wang
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
---
Changes from v4:
- None.
Changes from v3:
- None.
Changes from v2:
- None.
Changes from v1:
- Remove pattern_get interface.
--
Hi Jacek,
On 6 August 2018 at 19:41, Jacek Anaszewski wrote:
> Hi Baolin,
>
> On 08/06/2018 03:53 AM, Baolin Wang wrote:
>> Hi Jacek,
> [...]
>>>> +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern
>>>> @@ -0,0 +1,21 @@
>>>> +Wh
On 6 August 2018 at 16:06, Pavel Machek wrote:
> On Mon 2018-08-06 15:33:12, Baolin Wang wrote:
>> Hi Pavel,
>>
>> On 6 August 2018 at 15:09, Pavel Machek wrote:
>> > Hi!
>> >
>> >> > In current implementation this file on read returns the
uggest do this. So I will keep
>> the original description?
>
> If that is accepted, the code should return originally written number.
But I think it is more reasonable if user can know how many
repetitions were left. So for your hardware case, can we add
pattern_get() interface back to get the repetition number?
--
Baolin Wang
Best Regards
Hi Jacek,
On 6 August 2018 at 00:10, Jacek Anaszewski wrote:
> Hi Baolin,
>
> Thank you for the fix.
>
> I've found few more details to improve, please take a look
> at my comments below.
>
> On 08/05/2018 06:04 AM, Baolin Wang wrote:
>> Some LED contro
Some LED controllers have support for autonomously controlling
brightness over time, according to some preprogrammed pattern or
function.
This patch adds pattern trigger that LED device can configure the
pattern and trigger it.
Signed-off-by: Raphael Teysseyre
Signed-off-by: Baolin Wang
Hi Jacek,
On 5 August 2018 at 05:41, Jacek Anaszewski wrote:
> Hi Baolin,
>
> Thank you for the new version of the patch set.
Thanks for your quick response.
>
> On 08/04/2018 06:51 PM, Baolin Wang wrote:
>> Some LED controllers have support for autonomously controlling
&g
Hi Jacek,
On 3 August 2018 at 19:59, Jacek Anaszewski wrote:
> Hi Baolin,
>
> On 08/03/2018 10:05 AM, Baolin Wang wrote:
>> Hi Jacek,
>>
>> On 3 August 2018 at 05:21, Jacek Anaszewski
>> wrote:
>>> Hi Baolin,
>>>
>>> Thank you for a
Some LED controllers have support for autonomously controlling
brightness over time, according to some preprogrammed pattern or
function.
This patch adds pattern trigger that LED device can configure the
pattern and trigger it.
Signed-off-by: Raphael Teysseyre
Signed-off-by: Baolin Wang
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
---
Changes from v2:
- None.
Changes from v1:
- Remove pattern_get interface.
---
drivers/leds/led
tiny optimization request in pattern_trig_activate().
>
> On 08/01/2018 11:01 AM, Baolin Wang wrote:
>> Some LED controllers have support for autonomously controlling
>> brightness over time, according to some preprogrammed pattern or
>> function.
>>
>> This patch adds pattern tr
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
---
changes from v1:
- Remove pattern_get interface.
---
drivers/leds/leds-sc27xx-bltc.c | 94 +++
Some LED controllers have support for autonomously controlling
brightness over time, according to some preprogrammed pattern or
function.
This patch adds pattern trigger that LED device can configure the
pattern and trigger it.
Signed-off-by: Raphael Teysseyre
Signed-off-by: Baolin Wang
Hi Jacek,
On 31 July 2018 at 18:53, Jacek Anaszewski wrote:
> Hi Baolin,
>
> Thank you for the patch set. I have one note regarding the way how
> trigger specific sysfs attributes are created/removed, please refer
> to my comment in the code below.
>
> On 07/30/2018 02:29
701 - 800 of 1499 matches
Mail list logo
