Re: [PATCH] mod_devicetable.h: reduce sizeof(struct of_device_id) by 80 bytes

2019-05-02 Thread Jeff Mahoney
the structure definitions in the headers. -Jeff -- Jeff Mahoney SUSE Labs

Re: [RFC] [PATCH 0/5] procfs: reduce duplication by using symlinks

2019-03-23 Thread Jeff Mahoney
On 3/23/19 11:56 AM, Eric W. Biederman wrote: > Jeff Mahoney writes: > >> On 4/24/18 10:14 AM, Eric W. Biederman wrote: >>> je...@suse.com writes: >>> >>>> From: Jeff Mahoney >>>> >>>> Hi all - >>>> >>>>

Re: [RFC] [PATCH 0/5] procfs: reduce duplication by using symlinks

2019-03-21 Thread Jeff Mahoney
On 4/24/18 10:14 AM, Eric W. Biederman wrote: > je...@suse.com writes: > >> From: Jeff Mahoney >> >> Hi all - >> >> I recently encountered a customer issue where, on a machine with many TiB >> of memory and a few hundred cores, after a task with a few

Re: [PATCH] reiserfs: remove workaround code for GCC 3.x

2018-10-19 Thread Jeff Mahoney
pointer out of the available stack space, corrupting kernel space, > -# and causing a panic. Since this behavior only affects ppc32, this ifeq > -# will work around it. If any other architecture displays this behavior, > -# add it here. > -ccflags-$(CONFIG_PPC32) := $(call cc-ifve

Re: [PATCH] reiserfs: fix broken xattr handling (heap corruption, bad retval)

2018-08-13 Thread Jeff Mahoney
>>> mailinglist, so I guess it probably has to go through either Al Viro's >>> or akpm's tree? Looks like akpm signed off on the last commits in >>> reiserfs... >> >> I think Andrew's tree makes the most sense for this, > > Yeah, Andrew has alread

Re: [PATCH] reiserfs: fix broken xattr handling (heap corruption, bad retval)

2018-08-13 Thread Jeff Mahoney
ption doesn't happen anymore. > > Credit for making me clean this code up a bit goes to Al Viro, who pointed > out that the ->actor calling convention is suboptimal and should be > changed. > > Fixes: 48b32a3553a5 ("reiserfs: use generic xattr handlers") > C

Re: [RFC][PATCH 0/76] vfs: 'views' for filesystems with more than one root

2018-05-08 Thread Jeff Mahoney
since the underlying file system would still be active underneath it. Under the hood, things like relocation don't even look at what subvolume owns a particular extent until it must. So it could be coordinating thousands of superblocks to do what a single lock does now and for what benefit? >> It's far more efficient then to pull those fields we need for a >> subvolume namespace into their own structure. > > I'm not convinced yet - it still feels like it's the wrong layer to > be solving the multiple namespace per superblock problem It needs to be between the inode and the superblock. If there are multiple user-visible namespaces, each will still get the same underlying file system namespace. -Jeff -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: [RFC] [PATCH 0/5] procfs: reduce duplication by using symlinks

2018-04-26 Thread Jeff Mahoney
On 4/24/18 10:14 AM, Eric W. Biederman wrote: > je...@suse.com writes: > >> From: Jeff Mahoney >> >> Hi all - >> >> I recently encountered a customer issue where, on a machine with many TiB >> of memory and a few hundred cores, after a task with a few

Re: [RFC] [PATCH 0/5] procfs: reduce duplication by using symlinks

2018-04-25 Thread Jeff Mahoney
symlink rather than the dir. proc_pid_files_revalidate only needs to check if the tasks share files since it won't be called if it's not a symlink. Thanks for the review, -Jeff -- Jeff Mahoney SUSE Labs

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-06 Thread Jeff Mahoney
va_list ap; > int i; > > va_start(ap, dummy); > for (i = 0; i < 5; ++i) { > vprintf("%d\n", ap); > printf("%d\n", va_arg(ap, int)); > } > va_end(ap); > } > > int main(int argc, char *argv[]) > { > f("bla", 1, 2, 3, 4, 5, 6, 7, 8, 9, 10); > return 0; > } > > Compiling for native (x86-64), this produces $(seq 10). But with -m32, > one gets 1,1,2,2,3,3,4,4,5,5. > > Assuming reiserfs (at least its debugging infrastructure) isn't broken > on a bunch of architectures, I'm obviously missing something > fundamental. Please enlighten me. > > Rasmus > -- Jeff Mahoney SUSE Labs

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-04 Thread Jeff Mahoney
gt; "%/file0".) >> > > Well, that is a valid filename and we should support it... > > Isn't the bug in journal_init_dev()? Yep. That's exactly it. Acked-by: Jeff Mahoney Thanks, -Jeff > --- a/fs/reiserfs/journal.c~a > +++ a/fs/reiserfs/jo

Re: [PATCH 4/9] build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c to build

2018-03-15 Thread Jeff Mahoney
t all. It needs and this fix works because Luis added it to the HAVE_GDBM_H stanza. 3) AC_PACKAGE_WANT_NDBM used to check for but it was a check for IRIX and the caller was removed ages ago. It wouldn't matter if it were called anyway since libndbm is an IRIX library. Linux, IIRC, has never

Re: [RFC v3 0/2] vfs / btrfs: add support for ustat()

2017-08-23 Thread Jeff Mahoney
e btrfs report the proper anon dev_t in stat and > everything will just work. We do. We did then too. But what doesn't work is a user doing stat() and then using the dev_t to call ustat(). -Jeff -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: [PATCH 3/5] btrfs: Use common error handling code in btrfs_update_root()

2017-08-21 Thread Jeff Mahoney
root(struct btrfs_trans_handle *trans, > struct btrfs_root > out: > btrfs_free_path(path); > return ret; > +abort_transaction: > + btrfs_abort_transaction(trans, ret); > + goto out; > } > > int btrfs_insert_root(struct btrfs_trans_handle *trans, struct btrfs_root > *root, > -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: [PATCH 4/5] btrfs: Use common error handling code in update_ref_path()

2017-08-21 Thread Jeff Mahoney
->name_len); > if (ret < 0) { > +free_path: > fs_path_free(new_path); > return ret; > } > -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: [PATCH 2/5] btrfs: Use common error handling code in __btrfs_free_extent()

2017-08-21 Thread Jeff Mahoney
} > > ret = add_to_free_space_tree(trans, info, bytenr, num_bytes); > - if (ret) { > - btrfs_abort_transaction(trans, ret); > - goto out; > - } > + if (ret) > + goto abort_transaction;

Re: [PATCH 5/5] btrfs: Use common error handling code in btrfs_mark_extent_written()

2017-08-21 Thread Jeff Mahoney
root, path, del_slot, del_nr); > - if (ret < 0) { > - btrfs_abort_transaction(trans, ret); > - goto out; > - } > + if (ret < 0) > + goto abort_transaction; > } > out: > btrfs_free_path(path); > return 0; > +e_inval: > + ret = -EINVAL; > +abort_transaction: > + btrfs_abort_transaction(trans, ret); > + goto out; > } > > /* > -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: Linux 4.13: Reported regressions as of Sunday, 2017-08-06

2017-08-10 Thread Jeff Mahoney
c/28785f70ef We're not ignoring it. It's that this part of allocation seems to be a collection of bugs that approximate a correct result, and we're addressing them individually. This patch by itself is correct but uncovered a couple of underlying issues. -Jeff -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/1] - Fix reiserfs WARNING in dquot_writeback_dquots

2017-06-22 Thread Jeff Mahoney
lready be holding it is incorrect. There may be other threads executing with s->s_umount held as writers and this patch means that this would execute concurrently, which is incorrect. > dquot_writeback_dquots(s, -1); > reiserfs_write_lock(s); > if (!journal_begin(&

Re: __link_block_group uses GFP_KERNEL

2017-03-24 Thread Jeff Mahoney
o we'll need to defer the kobject_add until we can use GFP_KERNEL. -Jeff -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: [PATCH] uapi: fix linux/btrfs.h userspace compilation error

2017-02-15 Thread Jeff Mahoney
"in progress"; > default: > - return NULL; > + return 0; > } > } > > Hi Dmitry - Just remove the whole routine. It's not called from anywhere and is replicated in the userspace headers for btrfsprogs. -Jeff -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: [Regression 4.7-rc1] btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl

2017-02-06 Thread Jeff Mahoney
how it could happen. I got a minute to look at this today. It doesn't fallback to the normal ioctl handler. Since we have ->unlocked_ioctl defined, it checks the hard-coded compat tables and then fails with -ENOTTY. Fortunately, the fix is simple. The default stanza of that switch statement in btrfs_compat_ioctl needs to be removed. Then it just works. I'll post a fix momentarily. -Jeff -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

[PATCH] Docbook: re-remove 80211.xml from Makefile

2016-12-29 Thread Jeff Mahoney
get build failures for docs: make[2]: *** No rule to make target 'Documentation/DocBook/80211.xml', needed by 'Documentation/DocBook/80211.9'. Stop. This patch re-removes the 80211 rule. Fixes: 726d661fea3 (Merge remote-tracking branch 'sound/topic/restize-docs'

Re: [PATCH] btrfs: fix dereference on inode->i_sb before inode null check

2016-12-16 Thread Jeff Mahoney
trfs_inode_ref *iref; > @@ -241,6 +241,7 @@ static int btrfs_get_name(struct dentry *parent, char > *name, > if (!S_ISDIR(dir->i_mode)) > return -EINVAL; > > + fs_info = btrfs_sb(inode->i_sb); > ino = btrfs_ino(inode); > > path = btrfs_alloc_path(); > -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: [PATCH] Revert "Btrfs: don't delay inode ref updates during log, replay"

2016-12-02 Thread Jeff Mahoney
Whoops, the [PATCH] line should've specified more clearly: This only applies to linux-stable, 3.12.y. Sorry for any confusion. -Jeff On 12/2/16 10:21 PM, Jeff Mahoney wrote: > This reverts commit 644d10716875b24388680925d6c7502420987bfe. > > The original patch for mainline, 6f89

[PATCH] Revert "Btrfs: don't delay inode ref updates during log, replay"

2016-12-02 Thread Jeff Mahoney
did backport 67de11769bd, when it is not. Signed-off-by: Jeff Mahoney --- fs/btrfs/delayed-inode.c | 8 1 file changed, 8 deletions(-) diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c index 34f33e1..269ac79 100644 --- a/fs/btrfs/delayed-inode.c +++ b/fs/btrfs/delayed-in

Re: Fs: Btrfs - Fix possible ERR_PTR() dereferencing.

2016-09-20 Thread Jeff Mahoney
; > - if (IS_ERR(sa)) { > - ret = PTR_ERR(sa); > - sa = NULL; > - goto out; > - } > + if (IS_ERR(sa)) > + return PTR_ERR(sa); > > ret = _btrfs_ioctl_set_received_subvol(file, sa); > > -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-10 Thread Jeff Mahoney
On 9/10/16 11:58 AM, Sean Fu wrote: > On Thu, Sep 08, 2016 at 11:25:48PM -0400, Jeff Mahoney wrote: >> On 9/8/16 11:08 PM, Sean Fu wrote: >>> On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: >>>> On 9/6/16 5:58 AM, David Sterba wrote: >>>>

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-08 Thread Jeff Mahoney
On 9/8/16 11:08 PM, Sean Fu wrote: > On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: >> On 9/6/16 5:58 AM, David Sterba wrote: >>> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: >>>>>> Since root is only used to get fs_i

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-06 Thread Jeff Mahoney
On 9/6/16 5:58 AM, David Sterba wrote: > On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: >>>> Since root is only used to get fs_info->chunk_root, why not use fs_info >>>> directly? >>> >>> Weird. Exactly this was a part of my fs_i

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-05 Thread Jeff Mahoney
On 9/5/16 11:05 PM, Jeff Mahoney wrote: > On 9/5/16 3:56 AM, Qu Wenruo wrote: >> >> >> At 09/05/2016 09:19 AM, Zhao Lei wrote: >>> Hi, Sean Fu >>> >>>> From: Sean Fu [mailto:fxinr...@gmail.com] >>>> Sent: Sunday, September 04, 2016

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-05 Thread Jeff Mahoney
path = btrfs_alloc_path(); >>> if (!path) >>> return -ENOMEM; >>> -- >>> 2.6.2 >>> >> >> >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64

2016-04-10 Thread Jeff Mahoney
g redoing the lloop > driver anyways. Just need to find the cycles. I guess my memory was flakey and I was recalling the first comments in LU-4000. The updated version should be ok. -Jeff >> -- >> Jeff Mahoney >> (apologies for the top post -- from my mobile) >&g

Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64

2016-04-10 Thread Jeff Mahoney
This patch was shown not to work. I just haven't removed it from opensuse yet. -Jeff -- Jeff Mahoney (apologies for the top post -- from my mobile) > On Apr 10, 2016, at 9:13 AM, James Simmons wrote: > > From: Jeff Mahoney > > On ppc64 with 64k pages, we get a bu

Re: [PATCHv3 02/13] scripts/gdb: Provide kernel list item generators

2016-03-07 Thread Jeff Mahoney
On 3/3/16 6:40 AM, Kieran Bingham wrote: > Facilitate linked-list items by providing a generator to return > the dereferenced, and type-cast objects from a kernel linked list > > CC: Jeff Mahoney > > Signed-off-by: Kieran Bingham > --- > Changes since v1: > *

Re: [PATCH] btrfs: zero out delayed node upon allocation

2015-10-25 Thread Jeff Mahoney
On Oct 25, 2015, at 3:50 PM, Alexandru Moise <00moses.alexande...@gmail.com> wrote: >>> This allows us to trim out half of btrfs_init_delayed_node() which >>> is now reduntant. >> >> It's redundant if kmem_cache_zalloc is used, but you haven't >> documented that doing so is now required. For a

Re: [PATCH] btrfs: zero out delayed node upon allocation

2015-10-25 Thread Jeff Mahoney
; } > > static inline int btrfs_is_continuous_delayed_item( @@ -132,7 > +126,7 @@ again: if (node) return node; > > - node = kmem_cache_alloc(delayed_node_cache, GFP_NOFS); +node = > kmem_cache_zalloc(delayed_node_cac

Re: [GIT PULL] Ext3 removal, quota & udf fixes

2015-09-01 Thread Jeff Mahoney
n explicit stink about > that quite a while ago. But I'm satisfied; we do use > CONFIG_EXT4_USE_FOR_EXT23 in RHEL7, and we wouldn't do that if it > might change disk format behind our users' backs. As a "me too" datapoint, we do the same thing with SLE12.

Re: [PATCH] reiserfs: fix __RASSERT format string

2015-03-17 Thread Jeff Mahoney
;reiserfs: rework > reiserfs_panic") removed a "reiserfs[%i]" prefix. > > This bug is only triggered when using CONFIG_REISERFS_CHECK, > otherwise __RASSERT is never used. > > Signed-off-by: Nicolas Iooss Acked-by: Jeff Mahoney > Fixes: c3a9c2109f84 ("reiserfs: rew

Re: reiserfs: inconsistent format in __RASSERT

2015-03-16 Thread Jeff Mahoney
reiserfs_error. Unfortunately, it also enables some heavy checks that make the file system very slow. Thanks for looking into this. It looks like it's been broken for a while. I suppose the only saving grace is that it would crash in a path that crashes on p

Re: [PATCH] reiserfs: fix several reiserfs_warning calls

2015-03-08 Thread Jeff Mahoney
the old > interface. Update them. > > This bug was initially found by adding __printf(4, 5) attribute to > __reiserfs_warning and using "gcc -Wformat=2" when building the > kernel. > > Fixes: 45b03d5e8e67 ("reiserfs: rework reiserfs_warning") > Signed-of

[PATCH] vdso: don't require 64-bit math in standalone test

2014-10-24 Thread Jeff Mahoney
lding this by default, so it's failing the kernel build entirely. Switching the declaration from uint64_t to time_t does the right thing and handles the x32 case automatically. Signed-off-by: Jeff Mahoney --- Documentation/vDSO/vdso_standalone_test_x86.c |2 +- 1 file changed, 1 insertion

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 12:13 PM, Ming Lei wrote: > On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei > wrote: >> On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney >> wrote: >>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >>> >&

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 9:53 AM, Jeff Moyer wrote: > Jeff Mahoney writes: > >> Commit 05f1dd53152173 (block: add queue flag for disabling SG >> merging) uses bi_vcnt to assign bio->bi_phys_segments if sg >> merging is disabled. When

[PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-08 Thread Jeff Mahoney
ally reported at http://bugzilla.opensuse.org/show_bug.cgi?id=888259 Reported-by: Stephen Kulow Signed-off-by: Jeff Mahoney --- block/bio.c |1 + 1 file changed, 1 insertion(+) --- a/block/bio.c +++ b/block/bio.c @@ -564,6 +564,7 @@ void __bio_clone_fast(struct bio *bio, s bio-&g

Re: linux-3.16.2 queue (3.16.1+)

2014-09-10 Thread Jeff Mahoney
;>>>>> >>>>>>> please consider adding the following 2 patches to >>>>>>> 3.16.2: >>>>>>> >>>>>>> Jan Kara (1): reiserfs: Fix use after free in journal >>>>>>> teardown >&

Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select

2014-08-22 Thread Jeff Mahoney
On Fri Aug 22 19:34:12 2014, Randy Dunlap wrote: > On 08/22/14 10:04, Jeff Mahoney wrote: >> On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote: >>> We should not select SPI bus when sub-driver auto-select is >>> selected. That option is meant for auto-selecting all pos

Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select

2014-08-22 Thread Jeff Mahoney
ncies itself. > > I2C and I2C_MUX are still selected here for a reason described on > commit 347f7a3763601d7b466898d1f10080b7083ac4a3 > > Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a > > Reported-by: Jeff Mahoney > Signed-off-by: Antti Palosaari > --- > driver

Re: Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?

2014-08-22 Thread Jeff Mahoney
On Fri Aug 22 11:17:22 2014, Antti Palosaari wrote: > Moikka! > > On 08/22/2014 06:00 PM, Jeff Mahoney wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Hi Antti - >> >> Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus

Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?

2014-08-22 Thread Jeff Mahoney
AUTOSELECT? - -Jeff - -- Jeff Mahoney SUSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.19 (Darwin) iQIcBAEBAgAGBQJT91smAAoJEB57S2MheeWytcQP/jVJNWUWQ414XaltxVyAF8XT kyCCEXl/MslN8W36p6oMC6TX7KaXjQQSFVUltyt/UgcezuqhkU8nBUETEgLVou1n 1uF120zBu3gy3Hr+dG/3Awsdqb1UbrUrNM2LRL6sU5GIqYSdTxE

[PATCH] rtsx_usb: export device table

2014-08-08 Thread Jeff Mahoney
The rtsx_usb driver contains the table for the devices it supports but doesn't export it. As a result, no alias is generated and it doesn't get loaded automatically. Via https://bugzilla.novell.com/show_bug.cgi?id=890096 Reported-by: Marcel Witte Signed-off-by: Jeff Mahoney --- d

Re: [GIT PULL] Reiserfs & ext3 changes for 3.16-rc1

2014-06-09 Thread Jeff Mahoney
c buffer w/o a lock. I must've forgotten a 'quilt add' when adding that chunk to the newer patch. I'll review what else, if anything, might've changed but for now, that should be be s/format_bh(tb->S_new[i])/tb->S_new[i]/. - -Jeff - -- Jeff Mahoney SUSE Labs -

[PATCH] s390: add slab.h for kzalloc/kfree

2014-04-27 Thread Jeff Mahoney
Signed-off-by: Jeff Mahoney --- arch/s390/appldata/appldata_mem.c |1 + 1 file changed, 1 insertion(+) --- a/arch/s390/appldata/appldata_mem.c +++ b/arch/s390/appldata/appldata_mem.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include "appldata.h" --

Re: btrfs: lock inversion between delayed_node->mutex and found->groups_sem

2014-03-26 Thread Jeff Mahoney
x110 > [] do_try_to_free_pages+0x24d/0x410 > [] try_to_free_pages+0xe4/0x190 > [] __alloc_pages_nodemask+0x68b/0xa60 > [] ? cache_alloc_refill+0x3ce/0x7b0 > [] cache_alloc_refill+0x40c/0x7b0 > [] ? copy_process+0x13e/0x1910 > [] kmem_cache_alloc+0x1ef/0x200 &

Re: [PATCH 1/1] fs/reiserfs/super.c: add __init to init_inodecache

2014-03-25 Thread Jeff Mahoney
On 3/21/14, 12:16 PM, Fabian Frederick wrote: > init_inodecache is only called by __init init_reiserfs_fs. > > Signed-off-by: Fabian Frederick Acked-by: Jeff Mahoney > --- > fs/reiserfs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [PATCH 20/21] fs: Move prototype declaration to header file reiserfs.h from super.c

2014-02-09 Thread Jeff Mahoney
ng: no previous prototype for > ‘show_alloc_options’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett Acked-by: Jeff Mahoney > --- > fs/reiserfs/reiserfs.h |1 + > fs/reiserfs/super.c|1 - > 2 files changed, 1 insertion

Re: [BUG 3.13.0-rc6] reiserfs possible circular locking dependency

2014-01-15 Thread Jeff Mahoney
On 1/3/14, 5:04 PM, Jeff Mahoney wrote: > On 1/3/14, 2:46 PM, Linus Torvalds wrote: >> On Fri, Jan 3, 2014 at 11:16 AM, Knut Petersen >> wrote: >>> Rebooting after a power failure on an openSuSE 13.1 system >>> with kernel 3.13.0-rc6 triggered the attached lockde

Re: [PATCH] kobject: provide kobject_put_wait to fix module unload race

2014-01-04 Thread Jeff Mahoney
On 1/4/14, 1:06 PM, Mikulas Patocka wrote: > Hi > > I noticed that Jeff Mahoney added a new structure kobj_completion, defined > in include/linux/kobj_completion.h to the kernel 3.13-rc1 in the patch > eee031649707db3c9920d9498f8d03819b74fc23. In the current upstream kernel, &

Re: [BUG 3.13.0-rc6] reiserfs possible circular locking dependency

2014-01-03 Thread Jeff Mahoney
t path. There can be other users of the file system but it would be a recursive acquire so we wouldn't actually deadlock there. I'll work something up over the weekend or on Monday. -Jeff -- Jeff Mahoney SUSE Labs signature.asc Description: OpenPGP digital signature

[PATCH] nouveau: Fix race with fence signaling

2013-10-22 Thread Jeff Mahoney
: Ben Skeggs Signed-off-by: Jeff Mahoney --- drivers/gpu/drm/nouveau/nouveau_fence.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) --- a/drivers/gpu/drm/nouveau/nouveau_fence.c +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c @@ -180,12 +180,11 @@ nouveau_fence_wait_u

Re: [PATCH] kobject: export kobj_sysfs_ops

2013-10-22 Thread Jeff Mahoney
On 10/22/13 2:03 AM, Greg KH wrote: > On Mon, Oct 21, 2013 at 05:22:44PM -0400, Jeff Mahoney wrote: >> struct kobj_attribute implements the baseline attribute functionality >> that can be used all over the place. We should export the ops associated >> with it. I have a ser

[PATCH] kobject: export kobj_sysfs_ops

2013-10-21 Thread Jeff Mahoney
struct kobj_attribute implements the baseline attribute functionality that can be used all over the place. We should export the ops associated with it. I have a series of patches on the linux-btrfs list that depend on using kobj_sysfs_ops rather than re-implement them. Signed-off-by: Jeff Mahoney

Re: [PATCH] blktrace: fix race with open trace files and directory removal

2013-09-27 Thread Jeff Mahoney
On 9/27/13 2:56 PM, Jeff Moyer wrote: > Jeff Mahoney writes: > >> On 9/27/13 2:43 PM, Jeff Moyer wrote: >>> Jeff Mahoney writes: >>> >>>> There's a bug in the blktrace client where it will stop and tear down >>>> all of the tracing ins

Re: [PATCH] blktrace: fix race with open trace files and directory removal

2013-09-27 Thread Jeff Mahoney
On 9/27/13 2:43 PM, Jeff Moyer wrote: > Jeff Mahoney writes: > >> There's a bug in the blktrace client where it will stop and tear down >> all of the tracing instances for devices it's opened whether it >> successfully completed the setup or not. >> >&

[PATCH] blktrace: fix race with open trace files and directory removal

2013-09-24 Thread Jeff Mahoney
d the situation on older kernels as well. Signed-off-by: Jeff Mahoney --- include/linux/blktrace_api.h |2 ++ kernel/trace/blktrace.c | 37 + 2 files changed, 35 insertions(+), 4 deletions(-) --- a/include/linux/blktrace_api.h 2013-09-24 22:3

Re: [PATCH] kobject: introduce kobj_completion

2013-09-11 Thread Jeff Mahoney
On 9/11/13 1:15 PM, Greg KH wrote: > On Wed, Sep 11, 2013 at 01:00:30PM -0400, Jeff Mahoney wrote: >> A common way to handle kobject lifetimes in embedded in objects with >> different lifetime rules is to pair the kobject with a struct completion. >> >> This introduces

Re: [PATCH] kobject: introduce kobj_completion

2013-09-11 Thread Jeff Mahoney
On 9/11/13 1:28 PM, Al Viro wrote: > On Wed, Sep 11, 2013 at 01:00:30PM -0400, Jeff Mahoney wrote: >> A common way to handle kobject lifetimes in embedded in objects with >> different lifetime rules is to pair the kobject with a struct completion. >> >> This introduces

[PATCH] kobject: introduce kobj_completion

2013-09-11 Thread Jeff Mahoney
, and put-and-wait. Signed-off-by: Jeff Mahoney --- include/linux/kobj_completion.h | 18 ++ lib/kobject.c | 50 2 files changed, 68 insertions(+) --- /dev/null 1970-01-01 00:00:00.0 + +++ b/include/linux

[PATCH] Documentation: Fix bad merge with tmpfile documentation

2013-07-16 Thread Jeff Mahoney
Commit 48bde8d3 (Document ->tmpfile()) had a bad merge in vfs.txt, where it put the new tmpfile prototype in the middle of the atomic_open prototype. Signed-off-by: Jeff Mahoney --- Documentation/filesystems/vfs.txt |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --

[PATCH] powerpc: add missing include to book3s_xics.c

2013-06-05 Thread Jeff Mahoney
This fixes the following build failure: arch/powerpc/kvm/book3s_xics.c:812: error: implicit declaration of function 'get_tb' Signed-off-by: Jeff Mahoney --- arch/powerpc/kvm/book3s_xics.c |1 + 1 file changed, 1 insertion(+) --- a/arch/powerpc/kvm/book3s_xics.c +++ b/arch/p

Re: [PATCH] build some drivers only when compile-testing

2013-05-22 Thread Jeff Mahoney
this > is going to help with. I'm not convinced adding a || COMPILE_TEST option to every driver that may be arch specific is the best way to go either. Perhaps adding a new Kconfig verb called "archdepends on" or something that will evaluate as true if COMPILE_TEST is enabled

Re: [RFC] setxattr bugs

2013-02-04 Thread Jeff Mahoney
r callers of ->setxattr() never > pass NULL data or 0 size, so it's irrelevant for them). Would fix > both jfs and reiserfs weirdness > > Objections? - -- Jeff Mahoney SUSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http

[PATCH] ptp: PTP_1588_CLOCK_PCH depends on x86

2013-01-30 Thread Jeff Mahoney
The EG20T PCH is only compatible with Intel Atom processors so it should depend on x86. Cc: Richard Cochran Signed-off-by: Jeff Mahoney --- drivers/ptp/Kconfig |1 + 1 file changed, 1 insertion(+) --- a/drivers/ptp/Kconfig +++ b/drivers/ptp/Kconfig @@ -72,6 +72,7 @@ config DP83640_PHY

Re: [PATCH] staging/sb105x: remove asm/segment.h dependency

2013-01-07 Thread Jeff Mahoney
mtpt->port.iotype = UPIO_PORT; mtpt->port.ops = &multi_pops; -Jeff > Thanks, > > -- Steve > > > On Mon, 2013-01-07 at 17:20 -0500, Jeff Mahoney wrote: >> sb105x doesn't seem to actually need (builds on x86 >> without it) and ppc/p

[PATCH] staging/sb105x: remove asm/segment.h dependency

2013-01-07 Thread Jeff Mahoney
enough with the tty/serial system to patch that aspect of it. CC: Steven Rostedt Signed-off-by: Jeff Mahoney --- drivers/staging/sb105x/sb_pci_mp.h |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/sb105x/sb_pci_mp.h +++ b/drivers/staging/sb105x/sb_pci_mp.h @@ -19,7 +19,6 @@

[PATCH] x86/kbuild: archscripts depends on scripts_basic

2012-09-20 Thread Jeff Mahoney
6520fe55 (x86, realmode: 16-bit real-mode code support for relocs), which added the archscripts dependency to archprepare. This patch adds the scripts_basic dependency to the x86 archscripts. Signed-off-by: Jeff Mahoney --- arch/x86/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH[ Makefile: Fix scripts_basic / archscripts build order

2012-09-20 Thread Jeff Mahoney
root cause. 'make archscripts' alone still fails. I'll send a replacement that addresses that dependency issue directly. - -Jeff > On 09/19/2012 10:38 AM, Jeff Mahoney wrote: >> The SUSE kernel packages are built by doing the following: >> >> make silentoldonfig make

[PATCH[ Makefile: Fix scripts_basic / archscripts build order

2012-09-19 Thread Jeff Mahoney
6-bit real-mode code support for relocs), which added the archscripts dependency to archprepare. Signed-off-by: Jeff Mahoney --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/Makefile +++ b/Makefile @@ -835,7 +835,7 @@ prepare1: prepare2 include/lin

[PATCH] chipidea: Allow user to select PCI/IMX options

2012-08-27 Thread Jeff Mahoney
This patch adds _PCI and _IMX config options to allow the user to select whether to build the modules. Signed-off-by: Jeff Mahoney --- drivers/usb/chipidea/Kconfig | 11 +++ drivers/usb/chipidea/Makefile | 11 ++- 2 files changed, 13 insertions(+), 9 deletions(-) --- a/driver

Re: [PATCH] exynos-rng: Depend on ARCH_EXYNOS

2012-08-27 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 8/27/12 5:37 PM, Mark Brown wrote: > On Mon, Aug 27, 2012 at 05:25:59PM -0400, Jeff Mahoney wrote: >> On 8/27/12 5:18 PM, Stephen Boyd wrote: > >>> Hmm the point of making it not depend on ARCH_EXYNOS was so >>>

Re: [PATCH] exynos-rng: Depend on ARCH_EXYNOS

2012-08-27 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 8/27/12 5:18 PM, Stephen Boyd wrote: > On 8/27/2012 2:02 PM, Jeff Mahoney wrote: >> The exynos-rng device is only found on Samsung EXYNOS devices but >> has dependencies that allow it to be built on other >> architectures. Thi

[PATCH] exynos-rng: Depend on ARCH_EXYNOS

2012-08-27 Thread Jeff Mahoney
The exynos-rng device is only found on Samsung EXYNOS devices but has dependencies that allow it to be built on other architectures. This can result in build failures on powerpc due to a missing clk_devm_get. This patch makes it depend on ARCH_EXYNOS. Signed-off-by: Jeff Mahoney --- drivers

Re: [PATCH] clk.h: Fix shim ifdef guard (HAVE_CLK -> COMMON_CLK)

2012-08-27 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 8/27/12 2:52 PM, Russell King wrote: > On Mon, Aug 27, 2012 at 11:28:15AM -0400, Jeff Mahoney wrote: >> Commit 93abe8e4 (clk: add non HAVE_CLK routines) added shims for >> the clk code but HAVE_CLK isn't enough. It's po

Re: [PATCH] clk.h: Fix shim ifdef guard (HAVE_CLK -> COMMON_CLK)

2012-08-27 Thread Jeff Mahoney
Ugh. Ignore this one. I tested a build but just started getting build failures on different configs. I'll look into why later this afternoon. -Jeff -- Jeff Mahoney (apologies for the top post -- from my mobile) On Aug 27, 2012, at 11:27 AM, "Jeff Mahoney" wrote: > Commit

[PATCH] clk.h: Fix shim ifdef guard (HAVE_CLK -> COMMON_CLK)

2012-08-27 Thread Jeff Mahoney
ard to use COMMON_CLK, which actually guards the code. Signed-off-by: Jeff Mahoney --- include/linux/clk.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -120,7 +120,7 @@ static inline void clk_unprepare(struct } #endif

[PATCH] printk: Fix calculation of length used to discard records

2012-08-10 Thread Jeff Mahoney
sed as 0. This patch properly accounts for it and fixes the overflow. CC: sta...@kernel.org Signed-off-by: Jeff Mahoney --- kernel/printk.c |2 ++ 1 file changed, 2 insertions(+) --- a/kernel/printk.c +++ b/kernel/printk.c @@ -1034,6 +1034,7 @@ static int syslog_print_all(char __user

Re: R.I.P. pdflush

2012-08-02 Thread Jeff Mahoney
we end up with an ABBA case there. I'll work up a fix. - -Jeff - -- Jeff Mahoney SUSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJQGvDMAAoJEB57

Re: [PATCH v3 3/5] st: get rid of scsi_tapes array

2012-07-12 Thread Jeff Mahoney
nk doesn't work, the tape symlink isn't created, and we end up with lsscsi not listing tape device nodes. I'll work up a fix. - -Jeff > On 07/02/2012 05:16 PM, Lee Duncan wrote: >> >> On 07/01/2012 01:57 AM, Kai Makisara wrote: >>> On Mon, 21 May 2012, Le

Re: possible circular locking in reiserfs_removexattr

2008-02-22 Thread Jeff Mahoney
gt; [] kmem_cache_free+0x53/0x5a > [] trace_hardirqs_on+0xdd/0xfd > [] __user_walk_fd+0x37/0x3f > [] sys_lremovexattr+0x2b/0x3c > [] sysenter_past_esp+0x9a/0xa5 > [] trace_hardirqs_on+0xdd/0xfd > [] sysenter_past_esp+0x9a/0xa5 > [] sysenter_past_esp+0x5f/0xa5 >

Re: kernel BUG at kernel/power/snapshot.c:464!

2008-02-08 Thread Jeff Mahoney
x46/0xc3 [] ? system_call_after_swapgs+0x7b/0x80 Code: 00 3d 4f 80 e9 74 8f 1b 00 90 90 48 8b 47 10 49 89 d0 48 3b 70 08 72 06 48 3b 70 10 72 21 48 8b 07 eb 0c 48 8b 00 48 85 c0 75 04 <0f> 0b eb fe 48 3b 70 08 72 ee 48 3b 70 10 73 e8 48 89 47 10 48 RIP [] memory_bm_find_bit+0x20/0x78 RSP -

kernel BUG at kernel/power/snapshot.c:464!

2008-02-08 Thread Jeff Mahoney
- ---[ end trace c6de0b8a8d80da39 ]--- - -- Jeff Mahoney SUSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFHrKd+LPWxlyuTD7IRArWBAJ9+wGj8l2g/NU3B09YTwtM3+8dYIACdGeAt 3F2Cs30J2dCqRXFYe95StO8= =j1b

Re: [PATCH] mmap: restore -ENODEV on missing f_op->mmap

2007-10-30 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Linus Torvalds wrote: > > On Tue, 30 Oct 2007, Jeff Mahoney wrote: >> Personally, I think this is probably a case of LTP codifying existing >> behavior rather than testing the for the specification. If that's the case >

Re: [PATCH] mmap: restore -ENODEV on missing f_op->mmap

2007-10-30 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Randy Dunlap wrote: > On Tue, 30 Oct 2007 15:45:56 -0700 (PDT) Linus Torvalds wrote: > >> >> On Tue, 30 Oct 2007, Jeff Mahoney wrote: >>> Personally, I think this is probably a case of LTP codifying existing >>>

[PATCH] mmap: restore -ENODEV on missing f_op->mmap

2007-10-30 Thread Jeff Mahoney
rsonally, I think this is probably a case of LTP codifying existing behavior rather than testing the for the specification. If that's the case and nobody really cares about the change in behavior, I'm fine letting this drop. Signed-off-by: Jeff Mahoney <[EMAIL PROTECTED]>

Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs

2007-10-17 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Christoph Hellwig wrote: > On Mon, Oct 15, 2007 at 02:31:03PM -0400, Jeff Mahoney wrote: >> Here's a patch I worked up the other night that kills off struct file >> completely from the xattr code. I've tested it locally. &

Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs

2007-10-15 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Laurent Riffard wrote: > Le 15.10.2007 20:31, Jeff Mahoney a écrit : >> Christoph Hellwig wrote: >>> On Mon, Oct 15, 2007 at 12:34:58AM +0200, Laurent Riffard wrote: >>>> reiserfs_delete_xattrs >>>> reise

Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs

2007-10-15 Thread Jeff Mahoney
reiserfs_readdir() to enumerate the xattr directories. I do have patches in my queue to convert the xattrs to use reiserfs_readdir(), but I guess I'll just have to rework those. This is pretty close to the patch by Dave Hansen for -mm, but I didn't notice it until after I wrote th

Re: reiserfs fs/reiserfs/bitmap.c:1287

2007-08-08 Thread Jeff Mahoney
to handle > 8TiB file systems on the reiserfs-devel mailing list and hope to finalize them this week. If your file system isn't larger than 8 TiB, then we'll have to do a bit more hunting. - -Jeff - -- Jeff Mahoney SUSE Labs -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.4-svn0 (GNU

Re: reiserfs fs/reiserfs/bitmap.c:1287

2007-08-08 Thread Jeff Mahoney
7] [] > reiserfs_file_write+0x359/0x4bc > Aug 8 14:05:43 develop kernel: [1121369.444778] [] > autoremove_wake_function+0x0/0x33 > Aug 8 14:05:43 develop kernel: [1121369.444897] [] > __do_softirq+0x35/0x73 > Aug 8 14:05:43 develop kernel: [1121369.445012] [] > vfs_write+0x8b/0x10

Re: reiserfs fs/reiserfs/bitmap.c:1287

2007-07-12 Thread Jeff Mahoney
s] > [] reiserfs_new_inode+0xb8/0x826 [reiserfs] > [] do_journal_begin_r+0x73/0x28d [reiserfs] > [] d_splice_alias+0xdd/0xe3 > [] journal_begin+0x99/0xd0 [reiserfs] > [] reiserfs_mkdir+0x183/0x2c2 [reiserfs] > [] reiserfs_permission+0x0/0x1e [reiserfs] > [] vfs_mkdir+0xbd/0x125

  1   2   >