Re: [RESEND RFC PATCH 0/2] Expose the PIO_ISR register on SAMA5D3

2015-12-09 Thread Ludovic Desroches
Hi Peter, On Tue, Dec 08, 2015 at 04:20:06AM +0100, Peter Rosin wrote: > From: Peter Rosin > > Hi! > > I have a signal connected to a gpio pin which is the output of > a comparator. By changing the level of one of the inputs to the > comparator, I can detect the envelope of the other input to >

Re: [PATCH 1/1] dmaengine: at_xdmac: fix at_xdmac_prep_dma_memcpy()

2015-12-07 Thread Ludovic Desroches
t; new value. > > Signed-off-by: Cyrille Pitchen Thanks. Acked-by: Ludovic Desroches Fixes: e1f7c9eee70 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Cc: sta...@vger.kernel.org #4.1 and later (minor conflict due to the introduction of at_x

Re: [PATCH v2 1/4] i2c: at91: add upport for the HOLD field

2015-12-03 Thread Ludovic Desroches
Sorry forget this one, I have sent an old version. On Thu, Dec 03, 2015 at 10:53:51AM +0100, Ludovic Desroches wrote: > The hold field allows to configure the data hold time which can be set > with the help of the generic binding 'i2c-sda-hold-time-ns'. This > feature has b

[PATCH v2 4/4] ARM: at91/dt: sama5d2 Xplained: pmic needs a specific sda hold time

2015-12-03 Thread Ludovic Desroches
Data have to be held longer for the PMIC device. The ACT8945A datasheet claims that minimum SDA data hold time is about 300 ns. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91

[PATCH v2 3/4] ARM: at91/dt: sama5d4: update i2c compatible string

2015-12-03 Thread Ludovic Desroches
A new compatible string has been introduced: atmel,sama5d4-i2c. It allows to use the i2c-sda-hold-time-ns property if needed. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d4.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/sama5d4

[PATCH v2 1/4] i2c: at91: add upport for the HOLD field

2015-12-03 Thread Ludovic Desroches
The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-a

[PATCH v2 2/4] i2c: at91: update bindings documention

2015-12-03 Thread Ludovic Desroches
The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c. Signed-off-by: Ludovic Desroches Acked-by: Rob Herring --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c

[PATCH v2 1/4] i2c: at91: add support for the HOLD field

2015-12-03 Thread Ludovic Desroches
The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-a

[PATCH v2 0/4] i2c: at91: add support for SDA HOLD

2015-12-03 Thread Ludovic Desroches
Changes: - from v1: - fix typos, - change MAX_HOLD macro to follow Nicolas' advice, - make it clear that sama5d2 also support i2c-sda-hold-time-ns. Ludovic Desroches (4): i2c: at91: add support for the HOLD field i2c: at91: update bindings documention ARM: at91/dt: sama5d4: updat

[PATCH] dmaengine: at_xdmac: fix bad behavior in interleaved mode

2015-12-02 Thread Ludovic Desroches
From: Sylvain ETIENNE When performing interleaved transfers with numf > 1, an extra line is copied. The mbr.bc field is incremented once too often. The length of the block is (BLEN+1) microblocks. Signed-off-by: Sylvain ETIENNE Signed-off-by: Ludovic Desroches Fixes: 4e5385784e69 ("d

[PATCH 4/4] ARM: at91/dt: sama5d2 Xplained: pmic needs a specific sda hold time

2015-12-02 Thread Ludovic Desroches
Data have to been hold longer for the PMIC device. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts index ad6de73

[PATCH 3/4] ARM: at91/dt: sama5d4: update i2c compatible string

2015-12-02 Thread Ludovic Desroches
A new compatible string has been introduced: atmel,sama5d4-i2c. It allows to use the i2c-sda-hold-time-ns property if needed. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d4.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/sama5d4

[PATCH 2/4] i2c: at91: update bindings documention

2015-12-02 Thread Ludovic Desroches
The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c. Signed-off-by: Ludovic Desroches --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b

[PATCH 1/4] i2c: at91: add upport for the HOLD field

2015-12-02 Thread Ludovic Desroches
The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-a

Re: [PATCH] ARM: at91/dt: add always-on to 1.8V regulator

2015-12-02 Thread Ludovic Desroches
or definitions doesn't suit our > controller > for this 1.8V purpose. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts

[PATCH] pinctrl: at91-pio4: fix memleak after using dt map

2015-12-01 Thread Ludovic Desroches
configs is allocated by pinconf_generic_parse_dt_config(), pinctrl_utils_add_map_configs() duplicates configs so it can and has to be freed to prevent memory leaks. Signed-off-by: Ludovic Desroches Reported-by: Yingjoe Chen --- drivers/pinctrl/pinctrl-at91-pio4.c | 15 +-- 1 file

[PATCH] ARM: at91: fix pinctrl driver selection

2015-12-01 Thread Ludovic Desroches
Move the selection of the pinctrl driver to SoC family level since we have two pinctrl drivers. It is useless to select one which is not compatible with the SoC. Signed-off-by: Ludovic Desroches --- This patch is an improvement of this one (already acked by Linus and Nicolas): https://lkml.org

Re: [PATCH] pinctrl: update document for pinconf_generic_parse_dt_config

2015-12-01 Thread Ludovic Desroches
On Tue, Dec 01, 2015 at 11:12:16AM +0100, Linus Walleij wrote: > On Wed, Nov 25, 2015 at 1:13 PM, Yingjoe Chen > wrote: > > > The returned configs from pinconf_generic_parse_dt_config() is > > duplicated from original. Make it clear it must be freed when no > > longer necessary. > > > > Signed-o

Re: [PATCH 1/3] i2c: at91: add setting HOLD field of TWIHS_CWGR via DT

2015-11-30 Thread Ludovic Desroches
On Mon, Nov 30, 2015 at 04:13:20PM +0100, Wolfram Sang wrote: > On Tue, Nov 24, 2015 at 02:47:40PM +0100, Ludovic Desroches wrote: > > From: Wenyou Yang > > > > Add the HOLD field management. Some i2c devices need a longer data hold > > time than the one given in the i

Re: [PATCH] mmc: sdhci-of-at91: controller is suspended too early

2015-11-27 Thread Ludovic Desroches
On Fri, Nov 27, 2015 at 03:11:58PM +0100, Ulf Hansson wrote: > On 26 November 2015 at 17:41, Ludovic Desroches > wrote: > > When calling sdhci_add_host(), the controller is already suspended. It > > causes to read 0 in registers. > > Increment the device's

[PATCH] mmc: sdhci-of-at91: controller is suspended too early

2015-11-26 Thread Ludovic Desroches
When calling sdhci_add_host(), the controller is already suspended. It causes to read 0 in registers. Increment the device's usage counter before calling sdhci_add_host(), decrement it after and put it in suspend if it is possible. Signed-off-by: Ludovic Desroches Fixes: "mmc: sdhci-of

Re: [PATCH v2] mmc: sdhci at91: add PM support

2015-11-26 Thread Ludovic Desroches
On Thu, Nov 26, 2015 at 05:24:40PM +0100, Ulf Hansson wrote: > On 26 November 2015 at 17:07, Ludovic Desroches > wrote: > > On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > >> On 10 November 2015 at 11:36, Ludovic Desroches > >> wrote: > &g

Re: [PATCH v2] mmc: sdhci at91: add PM support

2015-11-26 Thread Ludovic Desroches
On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 11:36, Ludovic Desroches > wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > [...] > > static int sdhci_at91_prob

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ludovic Desroches
On Tue, Nov 24, 2015 at 02:56:21PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 14:12, Ludovic Desroches > wrote: > > On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > >> On 24 November 2015 at 10:23, Ludovic Desroches > >> wrote: > >>

[PATCH 2/3] i2c: at91: add DT property "atmel,twd-hold-cycles" to binding

2015-11-24 Thread Ludovic Desroches
From: Wenyou Yang Add a DT property "atmel,twd-hold-cycles" to specify the HOLD filed of TWIHS_CWGR register to increase the TWD hold time. Signed-off-by: Wenyou Yang Signed-off-by: Ludovic Desroches --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 1 file

[PATCH 3/3] ARM: dts: at91: specify DT property "atmel,twd-hold-cycles"

2015-11-24 Thread Ludovic Desroches
From: Wenyou Yang Specify the device tree property "atmel,twd-hold-cycles" to 25 to adapt to the PMIC ACT8945A. Signed-off-by: Wenyou Yang --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm

[PATCH 1/3] i2c: at91: add setting HOLD field of TWIHS_CWGR via DT

2015-11-24 Thread Ludovic Desroches
enyou Yang Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 10835d1..b3595ea 100644 --- a/drivers/i2c/busses/i2c-at91.c +++ b/d

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ludovic Desroches
On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 10:23, Ludovic Desroches > wrote: > > Hi Ulf, > > > > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > >> On Mon, Nov 09, 2015 at 05

[PATCH] dmaengine: at_xdmac: fix false condition for memset_sg transfers

2015-11-24 Thread Ludovic Desroches
The code was not in agreement with the comments. Signed-off-by: Ludovic Desroches Cc: sta...@vger.kernel.org # 4.3 and later --- drivers/dma/at_xdmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 7f039de..3b68471

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-24 Thread Ludovic Desroches
Hi Ulf, On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: [...] > > Now, this discussion was interesting, but I forgot what problem you > > actually where trying to solve? :-) > > There is th

[PATCH 3/3] mmc: atmel-mci: atmci_convert_chksize depends on controller version

2015-11-23 Thread Ludovic Desroches
The atmci_convert_chksize() function is no more valid for controller version 0x600 due to the introduction of '2 data' chunk size. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/atmel-mci.c | 43 +++ 1 file changed, 27 insertions(+), 16

[PATCH 2/3] MAINTAINERS: remove atmel-mci-regs.h file

2015-11-23 Thread Ludovic Desroches
Remove atmel-mci-regs.h file since it has been merged in atmel-mci.c. Signed-off-by: Ludovic Desroches --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b2ab9fc..1df3df3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1904,7 +1904,6 @@ ATMEL AT91

[PATCH 1/3] mmc: atmel-mci: move atmel-mci-regs.h content in atmel-mci.c

2015-11-23 Thread Ludovic Desroches
atmel-mci-regs.h is only included in atmel-mci.c so move its content in the driver and do some cleanup in these definitions to remove checkpatch errors. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/atmel-mci-regs.h | 171 -- drivers/mmc/host/atmel

[PATCH 2/2] dmaengine: at_xdmac: fix spurious flag status for mem2mem transfers

2015-11-23 Thread Ludovic Desroches
highest perid value for mem2mem transfers since it doesn't match the perid of other devices. Signed-off-by: Ludovic Desroches --- drivers/dma/at_xdmac.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c

[PATCH 1/2] dmaengine: at_xdmac: fix macro typo

2015-11-23 Thread Ludovic Desroches
Fix typo in a macro which was not used until now. It explains why there is no error at compilation time. Signed-off-by: Ludovic Desroches Fixes: e1f7c9eee707 "dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver" Cc: sta...@vger.kernel.org # 3.19 and later --- d

Re: [PATCH v2] pinctrl: at91-pio4: use %pr format string for resource

2015-11-19 Thread Ludovic Desroches
->start); > > This changes the format string to use the special "%pr" format > string that prints a resource, and changes the arguments so we > the resource structure directly. > > Signed-off-by: Arnd Bergmann Acked-by: Ludovic Desroches Thanks. > --- > v2: don&#

Re: [PATCH v2 4/7] ARM: at91/dt: sama5d2: add pio controller node

2015-11-17 Thread Ludovic Desroches
; On Wed, Sep 16, 2015 at 8:37 AM, Ludovic Desroches > >>> wrote: > >>> > >>>> Add pio4 controller node to enable pinmux and gpio. > >>>> > >>>> Signed-off-by: Ludovic Desroches > >>> > >>> Patch applied

Re: [PATCH] pinctrl: at91-pio4: use %pr format string for resource

2015-11-17 Thread Ludovic Desroches
Hi Arnd, On Thu, Nov 12, 2015 at 03:15:38PM +0100, Arnd Bergmann wrote: > resource_size_t may be defined as 32 or 64 bit depending on configuration, > so it cannot be printed using the normal format strings, as gcc correctly > warns: > > pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe': > p

Re: [PATCH] MAINTAINERS: Atmel drivers: change NAND and ISI entries

2015-11-17 Thread Ludovic Desroches
On Tue, Nov 17, 2015 at 11:21:35AM +0100, Nicolas Ferre wrote: > Update Josh's entries about NAND and ISI drivers. > Thanks for your work with Atmel Josh! > > Signed-off-by: Nicolas Ferre > Cc: Ludovic Desroches > Cc: Wenyou Yang > Cc: Josh Wu A

[PATCH v4] mmc: sdhci at91: add PM support

2015-11-11 Thread Ludovic Desroches
Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches --- Changes: - from v3: add error handling of runtime PM - from v2: cleanup thanks to Ulf feedback - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.c | 72

Re: [PATCH v3] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
On Tue, Nov 10, 2015 at 03:03:57PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 14:23, Ludovic Desroches > wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > > > Signed-off-by: Ludovic Desroches > > --- >

[PATCH v3] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches --- Changes: - from v2: cleanup thanks to Ulf feedback - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.c | 67 +++- 1

Re: [PATCH v2] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 11:36, Ludovic Desroches > wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > > > Signed-off-by: Ludovic Desroches > > --- &g

[PATCH v2] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches --- Changes: - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.c | 66 +++- 1 file changed, 65 insertions(+), 1 deletion

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 15:40, Ludovic Desroches > wrote: > > On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > >> On 9 November 2015 at 14:23, Ludovic Desroches > >> wrote: > >> >

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 14:23, Ludovic Desroches > wrote: > > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > >> When there is a vmmc regulator, only SD Bus Power is set to 1 in the > >&

[PATCH] mmc: core: set regulator not found message as debug

2015-11-09 Thread Ludovic Desroches
Turn the informative message about no vmmc/vqmmc regulator found in debug one. There is no need to indicate that something optional is missing. Moreover, it can bring confusion, people who doesn't know it is optional may consider these messages as warnings or errors. Signed-off-by: Lu

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > When there is a vmmc regulator, only SD Bus Power is set to 1 in the > Power Control Register. It means SD Bus Voltage Select field is set to 0 > that is a reserved value. The SD Host Controller specification says:

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: > [...] > > >> > >> This doesn't seems like a case where a gpio regulator should be used > >> and I am not sure what problem it would solve. Beside to suppress the > >> log warnings (actually those aren't warnings but informations). > >>

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 10:38:03AM +0100, Ulf Hansson wrote: > [...] > > >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case > >> > it is > >> > not really driven by a gpio but by a pio from the sdhci device. In the > >> > binding, > >> > >> What's a "pio"? > >> > >> Wha

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-08 Thread Ludovic Desroches
Hi Ulf, Thanks for your answer. On Fri, Nov 06, 2015 at 05:42:51PM +0100, Ulf Hansson wrote: > On 6 November 2015 at 16:59, Ludovic Desroches > wrote: > > Hi, > > > > I would like to have some feedback for these two patches. I have two > > questions. > > >

[PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-06 Thread Ludovic Desroches
ler strictly follows the specification then we need to set a valid value. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index ac97b46..0cfd7b2 100644 --- a/drivers/mmc/host/s

[PATCH 2/2] ARM: at91/dt: sama5d2 Xplained: add regulators for sdhci devices

2015-11-06 Thread Ludovic Desroches
Add vmmc and vqmmc regulators for sdhci devices. The voltage for sdmmc0 vqmmc is selected by a signal from coming from the sdhci device. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm

[PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-06 Thread Ludovic Desroches
is not really driven by a gpio but by a pio from the sdhci device. In the binding, declaring the gpio is an option so I thought using this regulator fits my need. P.S. patch 2 is based on another patch not yet in next: http://www.spinics.net/lists/arm-kernel/msg453447.html Thanks Ludovic Ludo

Re: [PATCH 9/9] pinctrl: at91: add missing of_node_put

2015-10-26 Thread Ludovic Desroches
eturn ...; > ) >... > } > // > > Signed-off-by: Julia Lawall Acked-by: Ludovic Desroches > > --- > drivers/pinctrl/pinctrl-at91.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drive

[PATCH v3] i2c: at91: manage unexpected RXRDY flag when starting a transfer

2015-10-26 Thread Ludovic Desroches
-off-by: Ludovic Desroches Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA controller") Reported-by: Peter Rosin Tested-by: Peter Rosin Cc: sta...@vger.kernel.org #4.1 --- Changes from v2: - fix smatch warning: variable 'sr' set but not used drivers

[PATCH v2 2/2] i2c: at91: manage unexpected RXRDY flag when starting a transfer

2015-10-21 Thread Ludovic Desroches
-off-by: Ludovic Desroches Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA controller") Reported-by: Peter Rosin Tested-by: Peter Rosin Cc: sta...@vger.kernel.org #4.1 --- drivers/i2c/busses/i2c-at91.c | 33 + 1 file changed, 25

[PATCH v2 1/2] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-21 Thread Ludovic Desroches
eter Rosin Signed-off-by: Ludovic Desroches Tested-by: Peter Rosin Cc: sta...@vger.kernel.org #4.1 --- drivers/i2c/busses/i2c-at91.c | 58 +-- 1 file changed, 50 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-21 Thread Ludovic Desroches
On Wed, Oct 21, 2015 at 09:42:40AM +0200, Peter Rosin wrote: > On 2015-10-21 09:21, Peter Rosin wrote: > > On 2015-10-20 15:27, Ludovic Desroches wrote: > >> On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: > >>> On 2015-10-19 10:51, Ludovic De

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-20 Thread Ludovic Desroches
On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: > On 2015-10-19 10:51, Ludovic Desroches wrote: > > Hi Peter, > > > > On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: > >> On 2015-10-16 01:47, Peter Rosin wrote: > >>> On

Re: [PATCH] mmc: sdhci at91: add suspend/resume

2015-10-19 Thread Ludovic Desroches
On Fri, Oct 16, 2015 at 06:33:44PM +0200, Ulf Hansson wrote: > On 16 October 2015 at 17:01, Ludovic Desroches > wrote: > > Add suspend and resume PM ops. > > > > Signed-off-by: Ludovic Desroches > > I have no problem with this patch, nice and easy. > > Alt

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-19 Thread Ludovic Desroches
Hi Peter, On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: > On 2015-10-16 01:47, Peter Rosin wrote: > > On 2015-10-14 07:43, Ludovic Desroches wrote: > >> On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: > >>> On 2015-10-13 18:47, Cyrille

[PATCH] mmc: sdhci at91: add suspend/resume

2015-10-16 Thread Ludovic Desroches
Add suspend and resume PM ops. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 55 +++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index 06d0b50

[PATCH v2 8/8] ARM: multi_v7_defconfig: Add Atmel SDHCI device

2015-10-16 Thread Ludovic Desroches
The AT91 SDHCI device has been introduced with Atmel SAMA5D2 SoC. Signed-off-by: Ludovic Desroches --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 6dcc048..844e921 100644

[PATCH v2 6/8] ARM: multi_v7_defconfig: Add Atmel SAMA5D2 SoC

2015-10-16 Thread Ludovic Desroches
Add Atmel SAMA5D2 SoC family to multi_v7 image. Signed-off-by: Ludovic Desroches --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index bf099b7..63703fa 100644 --- a/arch/arm

[PATCH v2 7/8] ARM: multi_v7_defconfig: Add Atmel Flexcom device

2015-10-16 Thread Ludovic Desroches
The Flexcom device has been introduced with Atmel SAMA5D2 SoC. Signed-off-by: Ludovic Desroches --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 63703fa..6dcc048 100644

[PATCH v2 5/8] ARM: at91/defconfig: add sama5d2 and its new devices to sama5 defconfig

2015-10-16 Thread Ludovic Desroches
Add SAMA5D2 SoC plus Atmel flexcom and Atmel sdhci devices. Signed-off-by: Ludovic Desroches --- arch/arm/configs/sama5_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index 3b2f686..a0c57ac 100644 --- a/arch

[PATCH v2 3/8] ARM: at91/defconfig: update sama5 defconfig

2015-10-16 Thread Ludovic Desroches
Trivial savedefconfig update. Signed-off-by: Ludovic Desroches --- arch/arm/configs/sama5_defconfig | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index 31eb951..3b2f686 100644 --- a/arch/arm

[PATCH v2 4/8] ARM: at91/defconfig: update at91_dt defconfig

2015-10-16 Thread Ludovic Desroches
Trivial savedefconfig update. Signed-off-by: Ludovic Desroches --- arch/arm/configs/at91_dt_defconfig | 15 --- 1 file changed, 15 deletions(-) diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig index 090c5b2..1b1e5ac 100644 --- a/arch/arm/configs

[PATCH v2 1/8] ARM: at91/dt: sama5d2: add missing devices

2015-10-16 Thread Ludovic Desroches
Big update of the sama5d2.dtsi file since many patches have reached te mainline: - add generated clocks - enable crypto devices - add flexcom devices - add tdes device - add sdmmc devices Signed-off-by: Ludovic Desroches Signed-off-by: Nicolas Ferre Signed-off-by: Cyrille Pitchen --- arch/arm

[PATCH v2 2/8] ARM: at91/dt: sama5d2 Xplained: add several devices

2015-10-16 Thread Ludovic Desroches
Add sdmmc and flexcom devices Signed-off-by: Ludovic Desroches Signed-off-by: Cyrille Pitchen --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 106 1 file changed, 106 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts

[PATCH v2 0/8] Enable several devices for Atmel SAMA5D2

2015-10-16 Thread Ludovic Desroches
Hi, This set of patches enables several devices for the freshly introduced SAMA5D2 SoC. dts and defconfig files are updated to enable SAMA5D2 and its new devices such as Flexcom and AT91 SDHCI. Changes: - v2: - update whole Atmel defconfigs - update multi_v7_defconfig Ludovic Desroches (8

Re: [PATCH 3/3] ARM: at91/defconfig: update sama5 defconfig

2015-10-15 Thread Ludovic Desroches
On Thu, Oct 15, 2015 at 05:42:53PM +0200, Nicolas Ferre wrote: > Le 15/10/2015 17:31, Ludovic Desroches a écrit : > > On Thu, Oct 15, 2015 at 03:24:51PM +0200, Alexandre Belloni wrote: > >> Hi, > >> > >> On 14/10/2015 at 14:11:24 +0200, Ludovic Desroches wrot

Re: [PATCH] ARM: at91: debug: update prompt for DEBUG_AT91_UART

2015-10-15 Thread Ludovic Desroches
On Thu, Oct 15, 2015 at 04:04:45PM +0200, Alexandre Belloni wrote: > On 14/10/2015 at 09:24:42 +0200, Ludovic Desroches wrote : > > Add (read help!) to DEBUG_AT91_UART prompt. It is not obvious there are > > such useful information to set DEBUG_UART_PHYS. > > > > Signe

Re: [PATCH 3/3] ARM: at91/defconfig: update sama5 defconfig

2015-10-15 Thread Ludovic Desroches
On Thu, Oct 15, 2015 at 03:24:51PM +0200, Alexandre Belloni wrote: > Hi, > > On 14/10/2015 at 14:11:24 +0200, Ludovic Desroches wrote : > > Add SAMA5D2 SoC plus Atmel flexcom and Atmel sdhci devices. > > > > Signed-off-by: Ludovic Desroches > > --- > >

[PATCH 3/3] ARM: at91/defconfig: update sama5 defconfig

2015-10-14 Thread Ludovic Desroches
Add SAMA5D2 SoC plus Atmel flexcom and Atmel sdhci devices. Signed-off-by: Ludovic Desroches --- arch/arm/configs/sama5_defconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index 31eb951..6e806f5

[PATCH 1/3] ARM: at91/dt: sama5d2: add missing devices

2015-10-14 Thread Ludovic Desroches
Big update of the sama5d2.dtsi file since many patches have reached te mainline: - add generated clocks - enable crypto devices - add flexcom devices - add tdes device - add sdmmc devices Signed-off-by: Ludovic Desroches Signed-off-by: Nicolas Ferre Signed-off-by: Cyrille Pitchen --- arch/arm

[PATCH 2/3] ARM: at91/dt: sama5d2 Xplained: add several devices

2015-10-14 Thread Ludovic Desroches
Add sdmmc and flexcom devices Signed-off-by: Ludovic Desroches Signed-off-by: Cyrille Pitchen --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 106 1 file changed, 106 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts

[PATCH] ARM: at91: debug: update prompt for DEBUG_AT91_UART

2015-10-14 Thread Ludovic Desroches
Add (read help!) to DEBUG_AT91_UART prompt. It is not obvious there are such useful information to set DEBUG_UART_PHYS. Signed-off-by: Ludovic Desroches --- arch/arm/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-13 Thread Ludovic Desroches
On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: > On 2015-10-13 18:47, Cyrille Pitchen wrote: > > Le 13/10/2015 17:19, Peter Rosin a écrit : > >> On 2015-10-13 16:21, Ludovic Desroches wrote: > >>> From: Cyrille Pitchen > >>> > >>>

[PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-13 Thread Ludovic Desroches
eter Rosin Signed-off-by: Ludovic Desroches Cc: sta...@vger.kernel.org #4.1 --- drivers/i2c/busses/i2c-at91.c | 58 +-- 1 file changed, 50 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 1c758c

Re: [PATCH 1/2] mmc: sdhci: add quirk SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

2015-10-13 Thread Ludovic Desroches
On Thu, Oct 08, 2015 at 08:01:23PM +0200, Ulf Hansson wrote: > +Russell > > On 17 September 2015 at 10:16, Ludovic Desroches > wrote: > > The Atmel sdhci device needs a new quirk. sdhci_set_clock set the Clock > > Control Register to 0 before computing the new valu

Re: Regression: at24 eeprom writing

2015-10-05 Thread Ludovic Desroches
Hi Peter On Mon, Oct 05, 2015 at 10:45:29AM +0200, Peter Rosin wrote: > On 2015-10-03 01:05, Peter Rosin wrote: [...] > Ok, I found the culprit, and I double and triple checked it this time... > > If I move to the very latest on the linux-3.18-at91 branch, the bug is > there too. Which made it

Re: [PATCH 1/2] pinctrl: at91-pio4: Use irq_set_handler_locked()

2015-10-05 Thread Ludovic Desroches
Hi Nicolas, On Fri, Oct 02, 2015 at 03:57:32PM +0200, Nicolas Ferre wrote: > Hi all, > > Well it seems my cover letter is missing. So, here it is: > > ---8< > pinctrl: at91-pio4: fixes for current linux-next (irq) > > While testing the sama5d2 on today's linux-next I discovered that some >

Re: [PATCH 08/16] clk: at91: only enable available IRQs

2015-10-01 Thread Ludovic Desroches
On Wed, Sep 30, 2015 at 06:11:01PM +0200, Alexandre Belloni wrote: > From: Boris Brezillon > > Only enable available IRQs in case writing to a reserved bit has an armful > effect. You probably mean disable instead of enable and s/armful/harmful. > > Signed-off-by: Boris Brezillon > Signed-off

Re: [PATCH v2 2/2] regulator: act8865: add DT binding for property "active-semi, vsel-high"

2015-09-30 Thread Ludovic Desroches
On Wed, Sep 30, 2015 at 03:25:50PM +0800, Wenyou Yang wrote: > Add a DT property "active-semi,vsel-high" to indicate the VSEL pin > is high. If this property is missing, then assume the VSEL pin is > low(0). > > Signed-off-by: Wenyou Yang Reviewed-by: Ludovic Desroches

Re: [PATCH v2 1/2] regulator: act8865: support output voltage by VSET2[] bits

2015-09-30 Thread Ludovic Desroches
> output voltage is programmed by VSET2[] bits. > > The DT property "active-semi,vsel-high" is used to specify > the VSEL pin at high on the board. > > Signed-off-by: Wenyou Yang Minor comment below, it's only my point of view. Anyway, Reviewed-by: Ludovic Desr

[PATCH 2/2] i2c: at91: update documentation for new "atmel,twd-hold-cycles" property

2015-09-30 Thread Ludovic Desroches
From: Wenyou Yang Add a DT property "atmel,twd-hold-cycles" to specify the HOLD field of TWIHS_CWGR register to increase the TWD hold time. Signed-off-by: Wenyou Yang Signed-off-by: Ludovic Desroches --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 +++ 1 file changed, 3

[PATCH 1/2] i2c: at91: add DT property for the HOLD field of TWIHS_CWGR

2015-09-30 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 1c758cd..06e66ef 100644 --- a/drivers/i2c/busses/i2c-at91.c +++ b/drivers/i2c/

Re: [PATCH 0/2] Fixes for next

2015-09-28 Thread Ludovic Desroches
Sorry I have forgotten: --in-reply-to=20150925133410.3c9e2...@canb.auug.org.au (linux-next: build failure after merge of the pinctrl tree) On Mon, Sep 28, 2015 at 11:41:11AM +0200, Ludovic Desroches wrote: > Hi Stephen, Linus, > > Here are fixes for next. I did the at91-pio4 patches

[PATCH 1/2] pinctrl: at91-pio4: use irq_set_handler_locked

2015-09-28 Thread Ludovic Desroches
Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Signed-off-by: Ludovic Desroches --- drivers/pinctrl/pinctrl-at91-pio4.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl

[PATCH 2/2] pinctrl: at91-pio4: irq argument as been removed from irq flow handlers

2015-09-28 Thread Ludovic Desroches
Irq argument as been removed from irq flow handlers so use the irq descriptor to retrieve data we need. Signed-off-by: Ludovic Desroches --- drivers/pinctrl/pinctrl-at91-pio4.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b

[PATCH 0/2] Fixes for next

2015-09-28 Thread Ludovic Desroches
Hi Stephen, Linus, Here are fixes for next. I did the at91-pio4 patches on top of next-20150916 which doesn't contain some tglx's updates about irqs. Ludovic Desroches (2): pinctrl: at91-pio4: use irq_set_handler_locked pinctrl: at91-pio4: irq argument as been removed fro

[PATCH] pinctrl: at91-pio4: add PM stuff

2015-09-25 Thread Ludovic Desroches
Allow GPIOs to be configured as wakeup sources. When going to suspend, disable all GPIO irqs excepting the one configured as wakeup sources. Signed-off-by: Ludovic Desroches --- drivers/pinctrl/pinctrl-at91-pio4.c | 76 + 1 file changed, 76 insertions

[tip:irq/core] irqchip/atmel-aic5: Use explicit variable name for the base chip

2015-09-22 Thread tip-bot for Ludovic Desroches
Commit-ID: 414a431ad6217a03e561fcb199048141db3fc024 Gitweb: http://git.kernel.org/tip/414a431ad6217a03e561fcb199048141db3fc024 Author: Ludovic Desroches AuthorDate: Mon, 21 Sep 2015 15:46:05 +0200 Committer: Thomas Gleixner CommitDate: Tue, 22 Sep 2015 16:04:42 +0200 irqchip/atmel

Re: [PATCH 1/3] irqchip: atmel-aic5: fix bug with mask/unmask

2015-09-22 Thread Ludovic Desroches
On Tue, Sep 22, 2015 at 03:50:30PM +0200, Thomas Gleixner wrote: > On Tue, 22 Sep 2015, Boris Brezillon wrote: > > On Tue, 22 Sep 2015 12:27:08 +0200 (CEST) > > Thomas Gleixner wrote: > > > Why is this locking dgc->gc[0] and fiddling with some other generic > > > chip? > > > > Actually, we always

[tip:irq/core] irqchip/atmel-aic5: Simplify base chip selection

2015-09-22 Thread tip-bot for Ludovic Desroches
Commit-ID: b55a3bb8650ddb096624175c55176d7fdbcad4ae Gitweb: http://git.kernel.org/tip/b55a3bb8650ddb096624175c55176d7fdbcad4ae Author: Ludovic Desroches AuthorDate: Mon, 21 Sep 2015 15:46:06 +0200 Committer: Thomas Gleixner CommitDate: Tue, 22 Sep 2015 16:04:43 +0200 irqchip/atmel

[tip:irq/urgent] irqchip/atmel-aic5: Use per chip mask caches in mask/unmask()

2015-09-22 Thread tip-bot for Ludovic Desroches
Commit-ID: d32dc9aa10c739363c775baf4499416b2e0dc11f Gitweb: http://git.kernel.org/tip/d32dc9aa10c739363c775baf4499416b2e0dc11f Author: Ludovic Desroches AuthorDate: Mon, 21 Sep 2015 15:46:04 +0200 Committer: Thomas Gleixner CommitDate: Tue, 22 Sep 2015 15:55:51 +0200 irqchip/atmel

[tip:irq/urgent] irqchip/atmel-aic5: Use proper mask cache in mask/unmask()

2015-09-22 Thread tip-bot for Ludovic Desroches
Commit-ID: 478cc7b33413a4ad50852239d931d55e622f1cde Gitweb: http://git.kernel.org/tip/478cc7b33413a4ad50852239d931d55e622f1cde Author: Ludovic Desroches AuthorDate: Mon, 21 Sep 2015 15:46:04 +0200 Committer: Thomas Gleixner CommitDate: Tue, 22 Sep 2015 12:25:12 +0200 irqchip/atmel

[PATCH 2/3] irqchip: atmel-aic5: fix variable naming

2015-09-21 Thread Ludovic Desroches
To avoid errors, use an explicit variable name when accessing the 'base' generic chip. Signed-off-by: Ludovic Desroches --- drivers/irqchip/irq-atmel-aic5.c | 44 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/irqchip

<    1   2   3   4   5   6   7   >