e is still loaded via i2c
detection.
arch/powerpc/boot/dts/fsl/p2041rdb.dts:
lm75b@48 {
compatible = "nxp,lm75a";
reg = <0x48>;
};
In this case, the sensor is mistakenly considered as ADT75 variant.
Fixes: e97a45f1b460 ("hwmon: (lm75) Add OF device ID
Currently, many boards use just 'lm75' as a compatible string.
Signed-off-by: Matwey V. Kornilov
---
Documentation/devicetree/bindings/hwmon/lm75.yaml | 1 +
drivers/hwmon/lm75.c | 4
2 files changed, 5 insertions(+)
diff --git a/Documentation/
NXP LM75A is compatible with original LM75A while it has improved
11-bit precision.
https://www.nxp.com/docs/en/data-sheet/LM75A.pdf
Signed-off-by: Matwey V. Kornilov
---
Documentation/devicetree/bindings/hwmon/lm75.yaml | 1 +
drivers/hwmon/lm75.c | 11
This series is to fix a logical issue in lm75 driver.
The actual fix is in the last patch.
Other patches are present in order not to break existing users.
Matwey V. Kornilov (4):
hwmon: lm75: Add lm75 to of_match list
hwmon: lm75: Add nxp,lm75a to of_match list
hwmon: lm75: Add ti,lm75 to
Currently, armada-388-helios4.dts and nuvoton-npcm730-kudo.dts use
"ti,lm75" compatible string.
TI LM75A/B are compatible with original LM75A
https://www.ti.com/lit/ds/symlink/lm75a.pdf
https://www.ti.com/lit/ds/symlink/lm75b.pdf
Signed-off-by: Matwey V. Kornilov
---
Documentation/
device ID table")
Signed-off-by: Matwey V. Kornilov
---
Changes since v2:
* fixed typo in the message
* fixed brackets
drivers/hwmon/lm75.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index e447febd121a..53882c33
e is still loaded via i2c
detection.
arch/powerpc/boot/dts/fsl/p2041rdb.dts:
lm75b@48 {
compatible = "nxp,lm75a";
reg = <0x48>;
};
In this case, the sensor is mistakenly considered as ADT75 variant.
Fixes: e97a45f1b460 ("hwmon: (lm75) Add OF device ID
NXP LM75A is compatible with original LM75A while it has improved
11-bit precision.
https://www.nxp.com/docs/en/data-sheet/LM75A.pdf
Signed-off-by: Matwey V. Kornilov
---
drivers/hwmon/lm75.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
LM75B was created in
e97a45f1b460 ("hwmon: (lm75) Add OF device ID table")
Since the previous commit introduces "nxp,lm75a" compatible string
for LM75A, there is a reason to add another alias for LM75B.
Signed-off-by: Matwey V. Kornilov
---
drivers/hwmon/lm75.c | 4 +++
zero.
Fixes: e97a45f1b460 ("hwmon: (lm75) Add OF device ID table")
Signed-off-by: Matwey V. Kornilov
---
drivers/hwmon/lm75.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index e447febd121a..3aa7f9454f57 100644
--- a/driv
fers for ISO
transfer")
Signed-off-by: Matwey V. Kornilov
---
drivers/media/usb/pwc/pwc-if.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c
index 61869636ec61..5e3339cc31c0 100644
---
Hi Anton,
I hope you are doing good. Could you please check this patch, since
you are initial author of zynq-zturn.dts and I suppose you do have the
"v4" board variant to test.
вт, 28 апр. 2020 г. в 13:04, Matwey V. Kornilov :
>
> There are at least two different versions existin
not attach PHY (-19)
After the patch:
[ 28.257365] macb e000b000.ethernet eth0: PHY [e000b000.ethernet-:00]
driver [Micrel KSZ9031 Gigabit PHY] (irq=POLL)
[ 28.257384] macb e000b000.ethernet eth0: configuring for phy/rgmii-id link
mode
Signed-off-by: Matwey V. Kornilov
---
Changes
пн, 9 сент. 2019 г. в 19:33, Matwey V. Kornilov :
>
> вт, 2 июл. 2019 г. в 20:33, Bin Liu :
> >
> > Matwey,
> >
> > On Tue, Jul 02, 2019 at 08:29:03PM +0300, Matwey V. Kornilov wrote:
> > > Ping?
> >
> > I was offline and just got back. I wil
вт, 2 июл. 2019 г. в 20:33, Bin Liu :
>
> Matwey,
>
> On Tue, Jul 02, 2019 at 08:29:03PM +0300, Matwey V. Kornilov wrote:
> > Ping?
>
> I was offline and just got back. I will review it soon. Sorry for the
> delay.
Ping?
>
> -Bin.
>
> >
> >
Closing angle bracket was missing.
Signed-off-by: Matwey V. Kornilov
---
drivers/power/reset/reboot-mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/reset/reboot-mode.c
b/drivers/power/reset/reboot-mode.c
index 06ff035b57f5..b4076b10b893 100644
--- a
Ping?
пт, 14 июн. 2019 г. в 19:47, Matwey V. Kornilov :
>
> The series is concerned to issues with isochronous transfer while
> streaming the USB webcam data. I discovered the issue first time
> when attached PWC USB webcam to AM335x-based BeagleBone Black SBC.
> It appeared that
3] IN : 5.5
11.335007 d= 0.03 [ 33 + 6.750] [ 3] DATA0: 00 00
Removing this glitches makes us able to successfully run 10fps
video stream from the webcam attached via USB hub. That was
previously impossible.
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.
Reduce the following similar snippets by using musb_qh_free().
qh->hep->hcpriv = NULL;
list_del(&qh->ring);
kfree(qh);
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 66 +---
1 file changed, 32 inse
lows for faster
response.
References:
[1] https://www.spinics.net/lists/linux-usb/msg165735.html
[2] https://www.spinics.net/lists/linux-media/msg144279.html
Changes since v1:
- Patch 6 was redone to keep URB giveback order and stop transmission at
erroneous URB.
Matwey V. Kornilov (6):
Use musb_qh_empty() instead of &qh->hep->urb_list to avoid code
duplicating.
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_ho
In the following commit we introduce new musb_start_urb() function
which will be able to start arbitrary urb. In order to have
intuitive function names we rename musb_start_urb() to
musb_start_next_urb().
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 8
1 file
Use USB_DIR_IN instead of 1 when calling musb_advance_schedule().
This is consistent with the rest of musb_host.c code and impoves
the readability.
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb
This function allows us to start arbitrary urb.
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 3a202a2a521d..ed99ecd4e63a 100644
вт, 30 апр. 2019 г. в 18:31, Bin Liu :
>
> Hi Greg and all devs,
>
> On Wed, Apr 03, 2019 at 09:53:10PM +0300, Matwey V. Kornilov wrote:
> > Previously, the algorithm was the following:
> >
> > 1. giveback current URB
> > 2. if current qh is not empty
&g
("musb: potential use after free")
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index b59ce9ad14ce..a60d52c7e112 100644
--- a/drivers/usb/musb/m
сб, 26 янв. 2019 г. в 00:37, Alan Stern :
>
> On Fri, 25 Jan 2019, Bin Liu wrote:
>
> > On Thu, Jan 24, 2019 at 09:47:02PM +0300, Matwey V. Kornilov wrote:
> > > By the way, why do we need to store the qh in urb->hcpriv?
> > > qh can always be accessible throu
By the way, why do we need to store the qh in urb->hcpriv?
qh can always be accessible through urb->ep->hcpriv
Wouldn't it be better to drop entire urb->hcpriv usage?
ср, 23 янв. 2019 г. в 20:52, Matwey V. Kornilov :
>
> We assign "urb->hcpriv = qh;" a few lin
We assign "urb->hcpriv = qh;" a few lines down. The valid qh for the urb is
hep->hcpriv in this code path.
Fixes: 714bc5ef3eda ("musb: potential use after free")
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 2 +-
1 file changed, 1 insertion(+),
t; Ezequiel García, VanguardiaSur
> www.vanguardiasur.com.ar
--
With best regards,
Matwey V. Kornilov
Matwey, does v6 address the comments made in v5?
Hi,
v6 addresses the comments made by Laurent Pinchart on Oct, 31:
https://www.spinics.net/lists/linux-media/msg142216.html
namely, dma_sync_single_for_device() is introduced in the proper place
>
> -- Steve
--
With best regards,
Matwey V. Kornilov
пт, 30 нояб. 2018 г. в 15:20, Matwey V. Kornilov :
>
> ср, 21 нояб. 2018 г. в 21:15, Matwey V. Kornilov :
> >
> > пт, 9 нояб. 2018 г. в 22:03, Matwey V. Kornilov :
> > >
> > > DMA cocherency slows the transfer down on systems without hardware
> > > co
able to measure performance of
PWC driver, traces are introduced in URB handler section.
[1] https://www.spinics.net/lists/linux-usb/msg165735.html
Signed-off-by: Matwey V. Kornilov
---
drivers/media/usb/pwc/pwc-if.c | 7 +
include/trace/events/pwc.h
вт, 21 авг. 2018 г. в 20:06, Matwey V. Kornilov :
>
> DMA cocherency slows the transfer down on systems without hardware
> coherent DMA.
> Instead we use noncocherent DMA memory and explicit sync at data receive
> handler.
>
> Based on previous commit the following performance
2018-08-17 20:44 GMT+03:00 Matwey V. Kornilov :
> пт, 10 авг. 2018 г. в 17:27, Alan Stern :
>>
>> On Fri, 10 Aug 2018, Laurent Pinchart wrote:
>>
>> > > > Aren't you're missing a dma_sync_single_for_device() call before
>> > > > submi
2018-07-24 23:55 GMT+03:00 Alan Stern :
> On Tue, 24 Jul 2018, Matwey V. Kornilov wrote:
>
>> 2018-07-23 21:57 GMT+03:00 Alan Stern :
>> > On Mon, 23 Jul 2018, Matwey V. Kornilov wrote:
>> >
>> >> I've tried to strategies:
>> >>
>> &
2018-06-06 22:15 GMT+03:00 Giulio Benetti :
> Il 06/06/2018 20:55, Matwey V. Kornilov ha scritto:
>>
>> 2018-06-06 16:11 GMT+03:00 Andy Shevchenko
>> :
>>>
>>> On Wed, 2018-06-06 at 14:15 +0200, Giulio Benetti wrote:
>>>>
>>>> Il 0
) which is called whenever user
> space does TIOCGRS485 IOCTL.
>
> So, it's completely driven by user space which makes sense by my
> opinion.
AFAIU, Giulio wants to add support for rs485-enabled-at-boot-time
device tree option (see bindings/serial/rs485.txt for reference).
I suppose it is only important for use-case when rs485 used as slave
(peripheral role).
>
> --
> Andy Shevchenko
> Intel Finland Oy
--
With best regards,
Matwey V. Kornilov
2018-06-04 21:50 GMT+03:00 Giulio Benetti :
> Il 04/06/2018 19:40, Matwey V. Kornilov ha scritto:
>>
>> 01.06.2018 15:40, Giulio Benetti пишет:
>>>
>>> Some 8250 ports only have TEMT interrupt, so current implementation
>>> can't work for ports wi
01.06.2018 15:40, Giulio Benetti пишет:
> Some 8250 ports only have TEMT interrupt, so current implementation
> can't work for ports without it. The only chance to make it work is to
> loop-read on LSR register.
>
> With NO TEMT interrupt check if both TEMT and THRE are set looping on
> LSR regist
ap.c | 2 +-
>> drivers/tty/serial/8250/8250_port.c | 33 ---
>> drivers/tty/serial/serial_core.c| 12 ++++++++-
>> include/linux/serial_8250.h | 1 +
>> 7 files changed, 79 insertions(+), 14 deletions(-)
>>
>
> --
> Andy Shevchenko
> Intel Finland Oy
>
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119234, Moscow, Universitetsky pr-k 13, +7 (495) 9392382
2017-11-16 19:32 GMT+03:00 Bin Liu :
> Hi,
>
> On Wed, Nov 15, 2017 at 06:19:08PM +0300, Matwey V. Kornilov wrote:
>> The issue is also present in 4.9.60-ti-r75
>>
>> 2017-11-04 17:05 GMT+03:00 Matwey V. Kornilov :
>> > Hi Bin,
>> >
>> > I'
The issue is also present in 4.9.60-ti-r75
2017-11-04 17:05 GMT+03:00 Matwey V. Kornilov :
> Hi Bin,
>
> I've just checked that the issue is still present in 4.13.10.
>
> 2017-04-27 13:20 GMT+03:00 Matwey V. Kornilov :
>> This commit changes the orde
Hi Bin,
I've just checked that the issue is still present in 4.13.10.
2017-04-27 13:20 GMT+03:00 Matwey V. Kornilov :
> This commit changes the order of actions undertaken in
> musb_advance_schedule() in order to overcome issue with broken
> isochronous transfer [1].
>
>
2017-04-29 17:24 GMT+03:00 Matwey V. Kornilov :
> 2017-04-29 11:16 GMT+03:00 Matwey V. Kornilov :
>> 2017-04-28 16:30 GMT+03:00 Bin Liu :
>>> On Fri, Apr 28, 2017 at 04:15:09PM +0300, Matwey V. Kornilov wrote:
>>>> 2017-04-28 15:43 GMT+03:00 Bin Liu :
>>>
2017-04-29 11:16 GMT+03:00 Matwey V. Kornilov :
> 2017-04-28 16:30 GMT+03:00 Bin Liu :
>> On Fri, Apr 28, 2017 at 04:15:09PM +0300, Matwey V. Kornilov wrote:
>>> 2017-04-28 15:43 GMT+03:00 Bin Liu :
>>> > On Fri, Apr 28, 2017 at 03:13:55PM +0300, Matwey V. K
2017-04-28 16:30 GMT+03:00 Bin Liu :
> On Fri, Apr 28, 2017 at 04:15:09PM +0300, Matwey V. Kornilov wrote:
>> 2017-04-28 15:43 GMT+03:00 Bin Liu :
>> > On Fri, Apr 28, 2017 at 03:13:55PM +0300, Matwey V. Kornilov wrote:
>> >> which i
>> >>
>> >&g
2017-04-28 15:43 GMT+03:00 Bin Liu :
> On Fri, Apr 28, 2017 at 03:13:55PM +0300, Matwey V. Kornilov wrote:
>> which i
>>
>> 2017-04-28 14:58 GMT+03:00 Bin Liu :
>> > On Fri, Apr 28, 2017 at 10:04:30AM +0300, Matwey V. Kornilov wrote:
>> >> 2017-04-27 20:
which i
2017-04-28 14:58 GMT+03:00 Bin Liu :
> On Fri, Apr 28, 2017 at 10:04:30AM +0300, Matwey V. Kornilov wrote:
>> 2017-04-27 20:13 GMT+03:00 Bin Liu :
>> > On Thu, Apr 27, 2017 at 07:26:31PM +0300, Matwey V. Kornilov wrote:
>> >> 2017-04-27 18:35 GMT+03:
2017-04-27 20:13 GMT+03:00 Bin Liu :
> On Thu, Apr 27, 2017 at 07:26:31PM +0300, Matwey V. Kornilov wrote:
>> 2017-04-27 18:35 GMT+03:00 Bin Liu :
>> > Hi Matwey,
>> >
>> > On Thu, Apr 27, 2017 at 01:20:33PM +0300, Matwey V. Kornilov wrote:
>> >> Thi
2017-04-27 18:35 GMT+03:00 Bin Liu :
> Hi Matwey,
>
> On Thu, Apr 27, 2017 at 01:20:33PM +0300, Matwey V. Kornilov wrote:
>> This commit changes the order of actions undertaken in
>> musb_advance_schedule() in order to overcome issue with broken
>> isochronous transfer
ng
urb->callback() after setting MUSB_RXCSR_H_REQPKT for the
next urb if there is the next urb pending in queue.
[1] https://www.spinics.net/lists/linux-usb/msg145747.html
Fixes: f551e1352983 ("Revert "usb: musb: musb_host: Enable HCD_BH flag to
handle urb return in bottom half"&q
to do it soon. Your board is supported by mxser driver
> (drivers/tty/mxser.c).
> I think it would be nice to move everything from mxser.c to 8250_moxa.c.
>
> The problem is mxser supports ISA and PCI boards and I don't have the
> hardware to test it.
>
> Mathieu
When struct moxa8250_board is allocated, then num_ports should
be initialized in order to use it later in moxa8250_remove.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250_moxa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/8250/8250_moxa.c
b/drivers
"igb: Remove GS40G specific defines/functions")
Cc: # 4.5+
Signed-off-by: Matwey V. Kornilov
---
drivers/net/ethernet/intel/igb/e1000_82575.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c
b/drivers/net/ethernet/intel/igb/e1000_82575.c
_port.c | 12 ++--
> include/linux/serial_8250.h | 4
> include/linux/serial_core.h | 2 ++
> 5 files changed, 43 insertions(+), 2 deletions(-)
>
> --
> 1.9.1
>
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonos
_array(probe_rsa, ulong, &probe_rsa_count, S_IRUSR | S_IRGRP |
> S_IROTH);
> MODULE_PARM_DESC(probe_rsa, "Probe I/O ports for RSA");
> #endif
> MODULE_ALIAS_CHARDEV_MAJOR(TTY_MAJOR);
> --
> 2.9.2
>
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382
And actually S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH can be simplified
to S_IRUGO | S_IWUSR, not?
I think we need to have and use dedicated special macros for most
common magic octal permissions like 0755 or 0644.
2016-08-02 16:19 GMT+03:00 Matwey V. Kornilov :
> Hello,
>
> I believe tha
rnel measures maxerror in usec and
ntpd does in nsec.
--
With best regards,
Matwey V. Kornilov
http://blog.matwey.name
xmpp://0x2...@jabber.ru
> So the patch detects if we're running virtualized (perhaps it should
> only check for qemu/KVM?) and if so, shortcuts the tests.
Does anybody know, whether it is possible to pass through real
hardware serial port to a guest? It seems to be as simple as to pass
through an interru
2016-03-24 11:03 GMT+03:00 :
> From: Yegor Yefremov
>
> When in half-duplex mode RX will be disabled before TX, but not
> enabled after deactivating transmitter. This patch enables
> UART_IER_RLSI and UART_IER_RDI interrupts after TX is over.
>
> Cc: Matwey V. Kornilov
&
ime when I tried to run my moxa PCI board with 3.1(?) and mxser
it deadlocked my PC from time to time.
8250_moxa implementation is much more cleaner.
>
> The problem is mxser supports ISA and PCI boards and I don't have the
> hardware to test it.
>
> Mathieu
--
With best regar
24.02.2016 22:10, Mathieu OTHACEHE пишет:
Add support for :
- CP-102E: 2 ports RS232 PCIE card
- CP-102EL: 2 ports RS232 PCIE card
- CP-132EL: 2 ports RS422/485 PCIE card
- CP-114EL: 4 ports RS232/422/485 PCIE card
- CP-104EL-A: 4 ports RS232 PCIE card
- CP-168EL-A: 8 ports RS232 PCIE card
- CP-
2016-03-07 16:03 GMT+03:00 Russell King - ARM Linux :
> On Mon, Mar 07, 2016 at 01:51:40PM +0100, Vlastimil Babka wrote:
>> [+CC ARM, module maintainers/lists]
>>
>> On 03/07/2016 12:14 PM, Matwey V. Kornilov wrote:
>> >
>> >Hello,
>> >
>> >
санов
Signed-off-by: Matwey V. Kornilov
---
Changes from v1:
- Properly filled Reported-by: tag
drivers/tty/serial/8250/8250_port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_port.c
b/drivers/tty/serial/8250/8250_port.c
index c908b77..4d6deef
2016-02-19 2:47 GMT+03:00 Greg Kroah-Hartman :
> On Thu, Feb 18, 2016 at 11:29:07PM +0300, Matwey V. Kornilov wrote:
>> 2016-02-18 23:21 GMT+03:00 Andy Shevchenko :
>> > On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov
>> > wrote:
>> >> serial8250_em485_
санов
Signed-off-by: Matwey V. Kornilov
---
Changes from v1:
- Properly filled Reported-by: tag
drivers/tty/serial/8250/8250_port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_port.c
b/drivers/tty/serial/8250/8250_port.c
index c908b77..4d6deef
2016-02-18 23:21 GMT+03:00 Andy Shevchenko :
> On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov wrote:
>> serial8250_em485_init() is supposed to be protected with
>> p->port.lock spinlock.
>> This may lead to issues when kmalloc sleeps, so it is better to use
>>
ff-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250_port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_port.c
b/drivers/tty/serial/8250/8250_port.c
index c908b77..4d6deef 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tt
Formally, currently there is no memory leak, but if
serial8250_ports[line] is reused with other 8250 driver, then em485
will be already activated and it will cause issues.
Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
Signed-off-by: Matwey V. Kornilov
--
2016-02-11 23:19 GMT+03:00 Ильяс Гасанов :
> 2016-02-11 22:08 GMT+03:00 Matwey V. Kornilov :
>> Thanks for pointing out. serial8250_unregister_port should set
>> serial8250_ports[line].em485 to NULL in order to prevent unneeded
>> activation when this struct is reused.
&
I am sorry, please ignore it. There is no issue actually. The timer
handlers and rs485_config callbacks are protected by the same
spinlock, so they are never run in parallel.
2016-02-11 22:32 GMT+03:00 Matwey V. Kornilov :
> Fix possbile race in serial8250_em485_destroy() when timer handlers
Fix possbile race in serial8250_em485_destroy() when timer handlers can
dereference p->em485 which is alread destroyed but not yet NULLed.
Signed-off-by: Matwey V. Kornilov
---
I've found that Greg applied initial patchset, so this erratum goes as separate
patch.
drivers/tty/ser
2016-02-11 19:40 GMT+03:00 Ильяс Гасанов :
> Hello,
>
> 2016-02-01 21:09 GMT+03:00 "Matwey V. Kornilov" :
>> +static int omap_8250_rs485_config(struct uart_port *port,
>> + struct serial_rs485 *rs485)
>> +{
>> + st
2016-02-10 19:05 GMT+03:00 Peter Hurley :
> Hi Matwey,
>
> On 02/01/2016 10:09 AM, Matwey V. Kornilov wrote:
>> Changes from v7:
>> - rework comments to follow guidelines
>> - minor style changes
>> Changes from v6:
>> - minor style changes
>> -
Software RS485 emultaion is to be added in the following commit.
serial8250_start_tx() will need to refer serial8250_stop_rx().
Move serial8250_stop_rx() in front of serial8250_start_tx() in order
to avoid function forward declaration.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial
Use software emulated RS485 direction control to provide RS485 API
existed in omap_serial driver. Note that 8250_omap issues interrupt
on shift register empty which is single prerequesite for using software
emulated RS485.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
. Otherwise,
emultaion cannot be used.
Both serial8250_em485_init() and serial8250_em485_destroy() are
idempotent functions.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250.h | 2 +
drivers/tty/serial/8250/8250_port.c | 223 +++-
include/linux
Changes from v3:
- Completely redesigned.
Changes from v2:
- Introduced SER_RS485_SOFTWARE to show that software implementation is being
used
- serial8250_rs485_config is located as required
- Timers are used to implement delay_before and delay_after timeouts
Signed-off-by: Matwey V. Kornilov
2016-01-23 18:20 GMT+03:00 Andy Shevchenko :
> On Tue, Jan 19, 2016 at 10:33 PM, Matwey V. Kornilov
> wrote:
>> Use software emulated RS485 direction control to provide RS485 API existed in
>> omap_serial driver. Note that 8250_omap issues interrupt on shift register
>&g
what might be meant on that part?
>>
>> Regards,
>> Ilyas G.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/m
Software RS485 emultaion is to be added in the following commit.
serial8250_start_tx will need to refer serial8250_stop_rx.
Move serial8250_stop_rx in front of serial8250_start_tx in order
to avoid function forward declaration.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
Use software emulated RS485 direction control to provide RS485 API existed in
omap_serial driver. Note that 8250_omap issues interrupt on shift register
empty which is single prerequesite for using software emulated RS485.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
,
emultaion cannot be used.
Both serial8250_em485_init and serial8250_em485_destroy are
idempotent functions.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250.h | 6 ++
drivers/tty/serial/8250/8250_port.c | 161 +++-
include/linux
- serial8250_rs485_config is located as required
- Timers are used to implement delay_before and delay_after timeouts
Signed-off-by: Matwey V. Kornilov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
2015-12-20 19:41 GMT+03:00 Andy Shevchenko :
> On Sat, Dec 12, 2015 at 1:23 PM, Matwey V. Kornilov wrote:
>> Implementation of software emulation of RS485 direction handling is based
>> on omap_serial driver.
>> Before and after transmission RTS is set to the appropriate v
Software RS485 emultaion is to be added in the following commit.
serial8250_start_tx will need to refer serial8250_stop_rx.
Move serial8250_stop_rx in front of serial8250_start_tx in order
to avoid function forward declaration.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
,
emultaion cannot be used.
Both serial8250_em485_init and serial8250_em485_destroy are
idempotent functions.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250.h | 6 ++
drivers/tty/serial/8250/8250_port.c | 161 +++-
include/linux
Use software emulated RS485 direction control to provide RS485 API existed in
omap_serial driver. Note that 8250_omap issues interrupt on shift register
empty which is single prerequesite for using software emulated RS485.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
Changes from v4:
- Add commit message to 1/3
Changes from v3:
- Completely redesigned.
Changes from v2:
- Introduced SER_RS485_SOFTWARE to show that software implementation is being
used
- serial8250_rs485_config is located as required
- Timers are used to implement delay_before and delay_aft
Are there any other issues except empty changelog that I have to fix before v5?
2015-12-05 19:06 GMT+03:00 Greg KH :
> On Sat, Dec 05, 2015 at 01:54:49PM +0300, Matwey V. Kornilov wrote:
>> Signed-off-by: Matwey V. Kornilov
>
> Why?
>
> Please say so in the changelog.
>
Use software emulated RS485 direction control to provide RS485 API existed in
omap_serial driver. Note that 8250_omap issues interrupt on shift register
empty which is single prerequesite for using software emulated RS485.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250_port.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_port.c
b/drivers/tty/serial/8250/8250_port.c
index 0bbf340..8ad0b2d 100644
--- a/drivers/tty
,
emultaion cannot be used.
Both serial8250_em485_init and serial8250_em485_destroy are
idempotent functions.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250.h | 6 ++
drivers/tty/serial/8250/8250_port.c | 161 +++-
include/linux
Changes from v3:
- Completely redesigned.
Changes from v2:
- Introduced SER_RS485_SOFTWARE to show that software implementation is being
used
- serial8250_rs485_config is located as required
- Timers are used to implement delay_before and delay_after timeouts
--
To unsubscribe from this list:
2015-12-03 22:45 GMT+03:00 Peter Hurley :
> On 12/03/2015 12:29 PM, Matwey V. Kornilov wrote:
>> 2015-12-03 17:41 GMT+03:00 Peter Hurley :
>>> Hi Matwey,
>>>
>>> On 12/03/2015 12:50 AM, Matwey V. Kornilov wrote:
>>>> I am working on v4, where I comp
2015-12-03 17:41 GMT+03:00 Peter Hurley :
> Hi Matwey,
>
> On 12/03/2015 12:50 AM, Matwey V. Kornilov wrote:
>> I am working on v4, where I completely redesigned implementation. And
>> now I think that it is considerably better than v3.
>> It looks like the following:
&
2015-12-03 2:20 GMT+03:00 Peter Hurley :
> On 11/18/2015 02:49 PM, Matwey V. Kornilov wrote:
>> 2015-11-18 22:39 GMT+03:00 Matwey V. Kornilov :
>>> 2015-11-18 21:33 GMT+03:00 Peter Hurley :
>>>> On 11/17/2015 03:20 AM, Matwey V. Kornilov wrote:
>>>>
2015-11-18 22:39 GMT+03:00 Matwey V. Kornilov :
> 2015-11-18 21:33 GMT+03:00 Peter Hurley :
>> On 11/17/2015 03:20 AM, Matwey V. Kornilov wrote:
>>> 2015-11-16 22:18 GMT+03:00 Peter Hurley :
>>>> On 11/14/2015 10:25 AM, One Thousand Gnomes wrote:
>>>>>&
2015-11-18 21:33 GMT+03:00 Peter Hurley :
> On 11/17/2015 03:20 AM, Matwey V. Kornilov wrote:
>> 2015-11-16 22:18 GMT+03:00 Peter Hurley :
>>> On 11/14/2015 10:25 AM, One Thousand Gnomes wrote:
>>>>> I specifically asked for it.
>>>>>
>>>
1 - 100 of 183 matches
Mail list logo