On Tue, 2020-06-23 at 15:11 -0700, Joe Perches wrote:
> On Tue, 2020-06-23 at 18:41 +0200, Nicolas Saenz Julienne wrote:
> > From: Dave Stevenson
> >
> > Fixes up a checkpatch error "Avoid using bool structure members
> > because of possible alignment issues
From: Dave Stevenson
The timeout period for VPU communications is a useful thing
to extend when debugging.
Set it via a define, rather than a magic number buried in the code.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging
.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
b/drivers
struct,
and pass the appropriate members.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-camera/bcm2835-camera.c | 64 +++
.../vc04_services/vchiq-mmal/mmal-common.h| 5 ++
.../vc04_services/vchiq
-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
s are already held in an array per VCHI
instance, so use the array index as the client_component handle
to avoid having to create a new IDR for this purpose.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal
From: Dave Stevenson
Fixes up a checkpatch error "Avoid using bool structure members
because of possible alignment issues".
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
From: Naushir Patuck
No functional changes in this commit.
- Remove erroneous whitespace.
- Remove _t postfix label on structs and enums.
Signed-off-by: Naushir Patuck
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-camera/bcm2835-camera.c | 2
ng: bcm2835: Break MMAL support out from camera
Naushir Patuck (1):
staging: mmal-vchiq: Fix formatting errors in mmal_parameters.h
Nicolas Saenz Julienne (39):
staging: vchi: Get rid of all useless callback reasons
staging: vchi: Get rid of vchi_msg_peek()
staging: vchi: Get rid of str
_hold() instead.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 25 +++
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
b/drivers/staging/vc04_services/bcm2835-audio/bc
ned-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 28
struct shim_service into struvt vchi_service, which is more consistent
with the rest of the exposed API.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 24 +++
.../vc04_services/interface/vchi/vchi.h | 27
.../interface/vchiq_arm
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 12
.../interface/vchiq_arm/vchiq_shim.c | 64 ---
.../interface/vchiq_arm/vchiq_util.c | 12
.../interface/vchiq_arm/vchiq_util.h | 1 -
4 files change
The idea behind this was to create an opaque handle to struct
vchiq_instance. This can be achieved without creating a new type by
means of a forward declaration of struct vchiq_instance.
This saves us from a lot of useless casting and overall simplifies code.
Signed-off-by: Nicolas Saenz
Nobody uses it. Get rid of it.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 7
.../interface/vchiq_arm/vchiq_shim.c | 39 ---
2 files changed, 46 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
This is for service's callbacks to get their private data.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b/dr
There is a series of structures and enums defined but never used. Get
rid of them.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchi/vchi_common.h | 65 ---
1 file changed, 65 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
enum vchi_callback_reason maps 1:1 to enum vchiq_reason, in an effort to
simplify things, let's use the later, and get rid of the extra
indirection.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 5 +--
.../interface/vchi/vchi_com
All users are ignoring the flags argument. So for the sake of
simplicity delete it.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 +--
drivers/staging/vc04_services/interface/vchi/vchi.h | 1 -
.../vc04_services/interface/vchiq_arm
Nothing in it is being used.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 1 -
.../vc04_services/interface/vchi/vchi_cfg.h | 238 --
2 files changed, 239 deletions(-)
delete mode 100644 drivers/staging/vc04_services/interface
The header file only provides other includes. Move the relevant includes
to their respective C files and delete it for good.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq.h | 1 -
.../interface/vchiq_arm/vchiq_2835_arm.c | 1 +
.../interface
This will make further changes easier. The struct will ultimately
disappear.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchi/vchi.h| 10 +++---
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 7 ---
2 files changed, 7 insertions
vchi has a set of transfer flags which almost map 1:1 to vchiq's own
transfer modes. For the sake of simplicity let's use the later and
delete vchi's.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 2 +-
.../vc04_services/bcm2835-
The structure only contains a single parameter, which is the underlying
vchiq handle. Get rid of the struct and directly pass the handle around.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 23 ++---
.../vc04_services/interface/vchi/vchi.h | 25
Linux coding style says to avoid typdefs.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchi/vchi.h| 5 -
.../vc04_services/interface/vchiq_arm/vchiq_if.h | 14 --
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers
For initialization, vchi has its own params structure, which is then
translated to vchiq's params structure. They are essentially the same,
so lets directly use vchiq's.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 9 +
.../vc0
When adding a new service validate the configuration parameters
provided, and remove unnecessary checks in vchi, now that we have
validated service's config.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_core.c | 15 +++
.../interface/vchi
, which
makes for simpler code in the end.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 20 ++---
.../vc04_services/interface/vchi/vchi.h | 9 +-
.../interface/vchi/vchi_common.h | 12 ---
.../interface/vchiq_arm/v
vchiq consumer drivers may need to use this function in order to get the
benefits of vchiq's per service message queueing mechanism.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/dr
This file is internal to vchiq.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
b/drivers/staging/vc04_services/interface
It's already forward declared in vchiq_if.h. So no need to insist
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h
b/drivers/st
igned-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/Makefile| 1 -
.../bcm2835-audio/bcm2835-vchiq.c | 24 +--
.../vc04_services/bcm2835-audio/bcm2835.h | 1 -
.../vc04_services/interface/{vchi => }/TODO | 0
.../vc04_services/interface/vch
This used to be vchiq_if.h but vchiq.h is more concise for an include
file that will hopefully be in the future in the includes directory.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/bcm2835-audio/bcm2835.h | 2 +-
.../vc04_services/interface/vchiq_arm/vchiq.h | 107
Those are only used in the core vchiq code, while present in vchiq's
'public' API header. Move them into the right place.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h| 5 -
.../staging/vc04_services/interface/vchiq_a
The function is being exported although there is no use for it outside
of vchiq's core code. Keep it local then.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +--
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h
Its vchiq counterpart, vchiq_bulk_receive() is only used by vchi. We can
then merge both functions by moving vchi_bulk_queue_receive()'s retry
mechanism into vchiq_bulk_receive() and let services call the later.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/v
structure and directly pass struct
vchiq_header, which is what ultimately vchiq consumes when handling
callback messages.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 14 ++-
.../interface/vchiq_arm/vchiq_shim.c | 25 ++
There is already enough duplication with regard to fourcc generation in
the kernel. Let's at least use the same macro all over the vchiq
ecosystem.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
.../vc04_services/bcm2835-
ne to match vchiq's user_service message
queue, which could be merged with this one in the future.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/Makefile| 1 -
.../interface/vchiq_arm/vchiq_core.c | 46
.../interface/vchiq_arm/vc
Those functions don't actually exist, nor have any use, nor the macros.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_if.h | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if
The barrier is only used by core code. So keep the barrier definition in
the core header.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq.h| 11 ---
.../vc04_services/interface/vchiq_arm/vchiq_core.h | 12
2 files changed, 12
The services have access to struct vchiq_header's internals, so we can
let them get the data pointer. This pretty much makes both functions
exactly the same, which will allow us to make a switch to
vchiq_msg_hold() further down the road.
Signed-off-by: Nicolas Saenz Julienne
---
.../st
Its vchiq counterpart, vchiq_bulk_transmit() is only used by vchi. We
can then merge both functions by moving vchi_bulk_queue_transmit()'s
retry mechanism into vchiq_bulk_transmit() and let services call the
later.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vc
the ISP driver to use it as well.
The only modification to the existing mmal code is the introduction of
EXPORT_SYMBOL() for symbols required by bcm2835-camera and the addition
of the module author and licenses.
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers
vchiq_if.h is used by service consumers and only the exported API should
be present. Move the rest of definitions, which were not exported by the
way, to vchiq_core.h where they belong.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_core.h | 22
To make the separation clear between vchiq's header files and vchiq.h,
which is to be used by services and is the 'public' API, move it into a
dedicated includes directory.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/Makefile
We can't really merge it with vchiq_queue_message() as it has internal
users that will not benefit from the retry mechanism
vchiq_queue_kernel_message() uses. So, for the sake of getting rid of
vchi, move it into vchiq.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vc
They are neither produced nor expected, so just delete them.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchi/vchi_common.h | 40 ++-
1 file changed, 3 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
From: Dave Stevenson
There were dependencies on including the headers in the correct
order. Fix up the headers so that they include the other
headers that they depend on themselves.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers
From: Dave Stevenson
The existing code assumed that there would only ever be 4 components,
and never freed the entries once used.
Allow arbitrary creation and destruction of components.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
It was probably there to trick compilers into ignoring unused variables,
which isn't needed in Linux.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vc04_ser
Those defines aren't used by anyone. Get rid of them.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 11 ---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 -
2 files changed, 12 deletions(-)
diff --git a/drivers/st
Hi Andy,
On Mon, 2020-06-22 at 17:44 +0300, Andy Shevchenko wrote:
> On Mon, Jun 22, 2020 at 5:26 PM Nicolas Saenz Julienne
> wrote:
> > This reverts commit c65822fef4adc0ba40c37a47337376ce75f7a7bc.
> >
> > The initialization of Raspberry Pi 4's USB chip is no
Hi Andy,
On Mon, 2020-06-22 at 17:42 +0300, Andy Shevchenko wrote:
> On Mon, Jun 22, 2020 at 5:26 PM Nicolas Saenz Julienne
> wrote:
> > Raspberry Pi 4's co-processor controls some of the board's HW
> > initialization process, but it's up to Linux to trigger
- Correct typos
Nicolas Saenz Julienne (9):
dt-bindings: reset: Add a binding for the RPi Firmware reset
controller
reset: Add Raspberry Pi 4 firmware reset controller
ARM: dts: bcm2711: Add firmware usb reset node
ARM: dts: bcm2711: Add reset controller to xHCI node
usb: xhci-pci: Add su
This reverts commit fbbc5ff3f7f9f4cad562e530ae2cf5d8964fe6d3.
The vl805 init routine has moved into drivers/reset/reset-raspberrypi.c
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
drivers/firmware/raspberrypi.c | 61 --
include/soc
The firmware running on the RPi VideoCore can be used to reset and
initialize HW controlled by the firmware.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v2:
- Add include file for reset IDs
Changes since v1:
- Correct cells binding as per Florian
The board doesn't need the quirks to be run, and takes care of its own
initialization through a reset controller device. So let's bypass them.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v2:
- Correct reference counting on parent device nod
ines.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
Reviewed-by: Philipp Zabel
---
Changes since v2:
- Get ids from dt-binding
Changes since v1:
- Make the whole driver less USB centric as per Florian's comments
drivers/reset/Kconfig | 11 ++
The chip is hardwired to the board's PCIe bus and needs to be properly
setup trough a firmware routine after a PCI fundamental reset. Pass the
reset controller phandle that takes care of triggering the
initialization to the relevant PCI device.
Signed-off-by: Nicolas Saenz Julienne
---
Ch
Some atypical users of xhci-pci might need to manually reset their xHCI
controller before starting the HCD setup. Check if a reset controller
device is available to the PCI bus and trigger a reset.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Mathias Nyman
Reviewed-by: Philipp Zabel
Now that the reset driver exposing Raspberry Pi 4's firmware based USB
reset routine is available, let's add the device tree node exposing it.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v1:
- Update cell nr to match new bindings
arch/ar
This reverts commit c65822fef4adc0ba40c37a47337376ce75f7a7bc.
The initialization of Raspberry Pi 4's USB chip is now handled through a
reset controller. No need to directly call the firmware routine trough a
pci quirk.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fai
This reverts commit 44331189f9082c7e659697bbac1747db3def73e7.
Now that the VL805 init routine is run through a reset controller driver
the device dependencies are being taken care of by the device core. No
need to do it manually here.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian
On Fri, 2020-06-19 at 02:37 -0700, Stephen Boyd wrote:
> Quoting Maxime Ripard (2020-06-15 01:40:40)
> > Hi,
> >
> > Since the whole DRM/HDMI support began to grow fairly big, I've chosen
> > to split away the two discussions between the firmware clocks and the
> > HDMI support.
> >
> > Let me kn
Hi All,
On Fri, 2020-06-12 at 19:13 +0200, Nicolas Saenz Julienne wrote:
> The chip is hardwired to the board's PCIe bus and needs to be properly
> setup trough a firmware routine after a PCI fundamental reset. Pass the
> reset controller phandle that takes care of triggering the
&g
On Tue, 2020-06-16 at 17:31 -0600, Simon Glass wrote:
> Hi Nicolas,
>
> On Tue, 16 Jun 2020 at 08:09, Nicolas Saenz Julienne
> wrote:
> > On Tue, 2020-06-16 at 07:43 -0600, Simon Glass wrote:
> > > Hi Nicolas,
> > >
> > > On Fri, 12 Jun 2020
Hi Florian,
The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407:
Linux 5.8-rc1 (2020-06-14 12:45:04 -0700)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-rpi.git
tags/bcm2835-drivers-fixes-2020-0-17
for you to f
iable
> of time64_t type to correctly handle lesser types.
>
> Fixes: 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT")
> Reported-by: Stefan Wahren
> Reported-by: Nicolas Saenz Julienne
> Signed-off-by: Andy Shevchenko
> Cc: Petr Mladek
> Cc: Steven Roste
On Wed, 2020-06-17 at 12:02 +0200, Philipp Zabel wrote:
> Hi Nicolas,
>
> On Fri, 2020-06-12 at 19:13 +0200, Nicolas Saenz Julienne wrote:
> > Raspberry Pi 4's co-processor controls some of the board's HW
> > initialization process, but it's up to Linux to tri
Hi,
On Wed, 2020-06-17 at 11:55 +0200, Philipp Zabel wrote:
> Hi Nicolas,
>
> On Fri, 2020-06-12 at 19:13 +0200, Nicolas Saenz Julienne wrote:
> > The firmware running on the RPi VideoCore can be used to reset and
> > initialize HW controlled by the firmware.
> >
iable
> of time64_t type to correctly handle lesser types.
>
> Fixes: 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT")
> Reported-by: Stefan Wahren
> Reported-by: Nicolas Saenz Julienne
> Signed-off-by: Andy Shevchenko
> Cc: Petr Mladek
> Cc: Steven Rostedt
On Tue, 2020-06-16 at 19:13 +0300, Andy Shevchenko wrote:
> On Tue, Jun 16, 2020 at 05:53:23PM +0200, Nicolas Saenz Julienne wrote:
> > On Wed, 2020-04-15 at 20:00 +0300, Andy Shevchenko wrote:
> > > Use %ptT instead of open coded variant to print content of
> > > time
Hi,
On Wed, 2020-04-15 at 20:00 +0300, Andy Shevchenko wrote:
> Use %ptT instead of open coded variant to print content of
> time64_t type in human readable format.
>
> Signed-off-by: Andy Shevchenko
> ---
as originally reported by Stefan Wahren, this patch is likely to be the cause
for a regre
On Tue, 2020-06-16 at 07:43 -0600, Simon Glass wrote:
> Hi Nicolas,
>
> On Fri, 12 Jun 2020 at 10:47, Nicolas Saenz Julienne
> wrote:
> > There is no distinction in DT between the PCI controller device and the
> > root bridge, whereas such distinction exists from dm'
On Thu, 2020-06-11 at 11:23 +0200, Maxime Ripard wrote:
> Now that we have a driver for the DVP, let's add its DT node.
>
> Signed-off-by: Maxime Ripard
> ---
I can take this patch, but I guess the rest should go trough the clock tree.
Is it OK with you?
Regards,
Nicolas
signature.asc
Descr
quette
> Cc: Stephen Boyd
> Cc: Rob Herring
> Cc: linux-...@vger.kernel.org
> Cc: devicet...@vger.kernel.org
> Reviewed-by: Stephen Boyd
> Signed-off-by: Maxime Ripard
> ---
Reviewed-by: Nicolas Saenz Julienne
Regards,
Nicolas
signature.asc
Description: This is a digitally signed message part
On Fri, 2020-06-12 at 19:08 +0200, Marek Vasut wrote:
> On 6/12/20 6:46 PM, Nicolas Saenz Julienne wrote:
> > Some atypical users of xhci-pci might need to manually reset their xHCI
> > controller before starting the HCD setup. Check if a reset controller
> > device is availab
centric.
- Use correct reset controller API in xhci-pci
- Correct typos
Nicolas Saenz Julienne (9):
dt-bindings: reset: Add a binding for the RPi Firmware reset
controller
reset: Add Raspberry Pi 4 firmware reset controller
ARM: dts: bcm2711: Add firmware usb reset node
ARM: dts: bcm
The firmware running on the RPi VideoCore can be used to reset and
initialize HW controlled by the firmware.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v2:
- Add include file for reset IDs
Changes since v1:
- Correct cells binding as per Florian
Some atypical users of xhci-pci might need to manually reset their xHCI
controller before starting the HCD setup. Check if a reset controller
device is available to the PCI bus and trigger a reset.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v2:
- Also reset on resume
Changes
This reverts commit fbbc5ff3f7f9f4cad562e530ae2cf5d8964fe6d3.
The vl805 init routine has moved into drivers/reset/reset-raspberrypi.c
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
drivers/firmware/raspberrypi.c | 61 --
include/soc
This reverts commit c65822fef4adc0ba40c37a47337376ce75f7a7bc.
The initialization of Raspberry Pi 4's USB chip is now handled through a
reset controller. No need to directly call the firmware routine trough a
pci quirk.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fai
ines.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v2:
- Get ids from dt-binding
Changes since v1:
- Make the whole driver less USB centric as per Florian's comments
drivers/reset/Kconfig | 11 +++
drivers/reset/Makefile
This reverts commit 44331189f9082c7e659697bbac1747db3def73e7.
Now that the VL805 init routine is run through a reset controller driver
the device dependencies are being taken care of by the device core. No
need to do it manually here.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian
The chip is hardwired to the board's PCIe bus and needs to be properly
setup trough a firmware routine after a PCI fundamental reset. Pass the
reset controller phandle that takes care of triggering the
initialization to the relevant PCI device.
Signed-off-by: Nicolas Saenz Julienne
Review
The board doesn't need the quirks to be run, and takes care of its own
initialization through a reset controller device. So let's bypass them.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v2:
- Correct reference counting on parent d
Now that the reset driver exposing Raspberry Pi 4's firmware based USB
reset routine is available, let's add the device tree node exposing it.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v1:
- Update cell nr to match new bindings
arch/ar
ines.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/reset/Kconfig | 10
drivers/reset/Makefile| 1 +
drivers/reset/reset-raspberrypi.c | 60 +++
.../reset/raspberrypi,firmware-reset.h| 13
4 files ch
This is required in order to access the reset controller used to
initialize the board's xHCI chip.
Signed-off-by: Nicolas Saenz Julienne
---
configs/rpi_4_32b_defconfig | 1 +
configs/rpi_4_defconfig | 1 +
configs/rpi_arm64_defconfig | 1 +
3 files changed, 3 insertions(+)
diff --
Some atypical users of xhci-pci might need to manually reset their xHCI
controller before starting the HCD setup. Check if a reset controller
device is available to the PCI bus and trigger a reset.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/usb/host/xhci-pci.c | 38
off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Rename function so it's not mistaken with regular firmware loading
---
arch/arm/mach-bcm283x/include/mach/mbox.h | 13 +++
arch/arm/mach-bcm283x/include/mach/msg.h | 7
arch/arm/mach-bcm283x/msg.c | 46
level lower than expected.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/pci/pci-uclass.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index 9ab3539a49..ea27e78465 100644
--- a/drivers/pci/pci-ucla
patchwork.kernel.org/patch/11596409/
---
Changes since v3:
- Use reset controller
Changes since v2:
- Correct comment on patch #1
- Address Matthias' comments
Changes since v1:
- Rename function
- Use callback in xhci-pci.c
Nicolas Saenz Julienne (5):
arm: rpi: Add function to trig
e
>
With patch #25 manually fixed, the series is:
Tested-by: Nicolas Saenz Julienne
Regards,
Nicolas
signature.asc
Description: This is a digitally signed message part
: Maxime Ripard
> ---
Acked-by: Nicolas Saenz Julienne
Regards,
Nicolas
signature.asc
Description: This is a digitally signed message part
On Thu, 2020-06-11 at 09:32 +0200, Maxime Ripard wrote:
> The PLLB rate will be changed through the firmware clocks drivers and will
> change behind this drivers' back, so we don't want to cache the rate.
>
> Signed-off-by: Maxime Ripard
> ---
Thanks!
Acked-by: Nicolas
tree properly, so having that clock in the MMIO driver will allow that.
>
> Signed-off-by: Maxime Ripard
> ---
Acked-by: Nicolas Saenz Julienne
Regards,
Nicolas
signature.asc
Description: This is a digitally signed message part
tephen Boyd
> Cc: linux-...@vger.kernel.org
> Reviewed-by: Stephen Boyd
> Signed-off-by: Maxime Ripard
> ---
Acked-by: Nicolas Saenz Julienne
Regards,
Nicolas
signature.asc
Description: This is a digitally signed message part
tatic struct clk_hw *bcm2835_register_pll(struct
> bcm2835_cprman *cprman,
> init.num_parents = 1;
> init.name = pll_data->name;
> init.ops = &bcm2835_pll_clk_ops;
> - init.flags = CLK_IGNORE_UNUSED;
> + init.flags = data->flags | CLK_IGNORE_UNUSED;
Thi
501 - 600 of 1060 matches
Mail list logo