Re: Tabs, spaces, indent and 80 character lines

Miles Bader wrote: Why do people even respond to these trolls...? -Miles Obviously, this must to have been discussed before, with a clear conclusion. Unfortunately, I have not, during my ~2 years on the list, seen anything of the sort and would like to, in that case, request a small direct

Re: Tabs, spaces, indent and 80 character lines

Krzysztof Halasa wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: I guess we could use tabs only at the line start, for indentation only. Rather hard to implement, most text editors can't do that yet. You mean for split lines? Syntactic indentation v

Re: Tabs, spaces, indent and 80 character lines

Benny Halevy wrote: On Feb. 24, 2008, 7:40 -0800, Richard Knutsson <[EMAIL PROTECTED]> wrote: Krzysztof Halasa wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: Why hinder a developer who prefer 2, 4, 6 or any other != 8 width? I guess we co

Re: Tabs, spaces, indent and 80 character lines

Krzysztof Halasa wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: Why hinder a developer who prefer 2, 4, 6 or any other != 8 width? I guess we could use tabs only at the line start, for indentation only. Rather hard to implement, most text editors can't do that yet.

Tabs, spaces, indent and 80 character lines

and changing the CodeStyle to be something like "maximum 80 characters-wide lines, with a tab-setting of 8 spaces", that is possible + easier to write code-checkers [2]. Or are we really that concerned about the disk-space? ;) 2 cents away... /Richard Knutsson [1] As has been pointe

Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

S.Çağlar Onur wrote: Hi; Following patch silents net/bluetooth/hci_sysfs.c: In function `del_conn': net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment used as truth value compiler warning introduced by commit acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: M

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

Andre Noll wrote: On 17:40, Andi Kleen wrote: Here's a proposal for some useful code transformations the kernel janitors could do as opposed to running checkpatch.pl. Here's my take on drivers/scsi/sg.c. It's only compile-tested on x86-64. ... and x86 with all(yes|mod)config. :)

[PATCH][SCSI] megaraid: Convert from "scsi.h" to (and friends)

Convert glue-include "scsi.h" to (and friends). (binary sizes) allyesconfig: before: 260132 after: 260048 allmodconfig: before: 261740 after: 261656 Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Do not have the hardware, but since it co

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: On Sun, 06 Jan 2008 17:09:44 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: (btw, wouldn't 'var != 0' actually be the proper semantic instead of playing with '!'s?) no because var could be a pointer for example...

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: On Sun, 06 Jan 2008 12:44:56 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: Arjan van de Ven wrote: From: Olof Johansson <[EMAIL PROTECTED]> Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when t

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: From: Olof Johansson <[EMAIL PROTECTED]> Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when the condition is true. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[E

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

f (err) - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); return err; } Hi Mathieu What about changing the __FUNCTION__ to __func__, while you are at it? Richard Knutsson -- To unsubscribe from this list: se

Re: [PATCH 1/3] ipc: Convert handmade 'max' to max().

Sorry for the late response, have been away during the holidays. Andrew Morton wrote: On Mon, 17 Dec 2007 03:35:55 +0100 (MET) Richard Knutsson <[EMAIL PROTECTED]> wrote: Convert handmade 'max' to max(). ... --- a/ipc/msg.c +++ b/ipc/msg.c @@ -473,7 +473,7 @@ asmlinkage

[PATCH 3/3] ipc: Convert handmade 'min' to min().

Convert handmade 'min' to min(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Dependent on 'msg->m_ts' being changed from int to size_t. diff --git a/ipc/msg.c b/ipc/msg.c index fdf3db5..74d0709 100644 --- a/ipc/msg.c +++ b/ipc/msg.c @@ -920,7 +920,7 @@ o

[PATCH 1/3] ipc: Convert handmade 'max' to max().

Convert handmade 'max' to max(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- msg.c |2 +- sem.c |2 +- shm.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ipc/msg.c b/ipc/msg.c index fdf3db5..74d0709 100644 --- a/ipc/msg.c

[PATCH 2/3] msg.h: Convert m_ts from int to size_t.

Convert m_ts ("message text size") from int to size_t. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Remove some trailing spaces, since we are in the neighborhood. diff --git a/include/linux/msg.h b/include/linux/msg.h index 10a3d5a..7a61952 100644 --- a/include/l

Re: [PATCH 1/6] pcmcia/3c574_cs: Fix dubious bitfield warning

Alan Cox wrote: On Tue, 11 Dec 2007 05:32:38 +0100 (MET) Richard Knutsson <[EMAIL PROTECTED]> wrote: Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:194:13: warning: dubious bitfield without explicit `signed' or `unsigned' drivers/net/pcmcia/3

[PATCH 6/6] pcmcia/pcnet_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/pcnet_cs.c drivers/net/pcmcia/pcnet_cs.c:523:15: warning: symbol 'hw_info' shadows an earlier one drivers/net/pcmcia/pcnet_cs.c:148:18: originally declared here Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/dr

[PATCH 4/6] pcmcia/axnet_cs: Make use of 'max()' instead of handcrafted one

Use 'max(x,y)' instead of 'x < y ? y : x'. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/pcmcia/axnet_cs.c b/drivers/net/pcmcia/axnet_cs.c index 8d910a3..96931cc 100644 --- a/drivers/net/pcmcia/axnet_cs.c +++ b/drivers/net/pcmcia/

[PATCH 5/6] pcmcia/fmvj18x_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/fmvj18x_cs.c drivers/net/pcmcia/fmvj18x_cs.c:1205:6: warning: symbol 'i' shadows an earlier one drivers/net/pcmcia/fmvj18x_cs.c:1179:9: originally declared here Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/dr

[PATCH 2/6] pcmcia/3c574_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:695:7: warning: symbol 'i' shadows an earlier one drivers/net/pcmcia/3c574_cs.c:636:6: originally declared here Signed-off-by: Richard Knutson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/pcmcia/3c574_cs.c b/driver

[PATCH 1/6] pcmcia/3c574_cs: Fix dubious bitfield warning

Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:194:13: warning: dubious bitfield without explicit `signed' or `unsigned' drivers/net/pcmcia/3c574_cs.c:196:14: warning: dubious bitfield without explicit `signed' or `unsigned' Signed-off-by: Rich

[PATCH 3/6] pcmcia/axnet_cs: Make functions static

Fixing: CHECK drivers/net/pcmcia/axnet_cs.c drivers/net/pcmcia/axnet_cs.c:994:5: warning: symbol 'ax_close' was not declared. Should it be static? drivers/net/pcmcia/axnet_cs.c:1017:6: warning: symbol 'ei_tx_timeout' was not declared. Should it be static? Signed-off-

Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Pekka Enberg wrote: Hi Richard, On Dec 10, 2007 9:29 PM, Richard Knutsson <[EMAIL PROTECTED]> wrote: Remove local definition of TRUE/FALSE. This is already fixed in Francois' tree: http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=c

[PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Remove local definition of TRUE/FALSE. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h index d5d092c..4484778 100644 --- a/drivers/net/ipg.h +++ b/drivers/net/ipg.h @@ -490,38 +490,34 @@ enum ipg_regs { *

[PATCH] ivtv: Some general fixes

Fix "warning: Using plain integer as NULL pointer". Convert 'x < y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> Signed-off-by: Hans Verkuil <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and &q

[PATCH] kernel/params.c: Remove sparse-warning (different signedness).

Fixing: CHECK kernel/params.c kernel/params.c:329:41: warning: incorrect type in argument 8 (different signedness) kernel/params.c:329:41:expected int *num kernel/params.c:329:41:got unsigned int * Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on x86 wi

[PATCH] mm/mmap: Remove sparse-warning (NULL as 0).

Fixing: CHECK mm/mmap.c mm/mmap.c:1623:29: warning: Using plain integer as NULL pointer mm/mmap.c:1623:29: warning: Using plain integer as NULL pointer mm/mmap.c:1944:29: warning: Using plain integer as NULL pointer Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Ad

Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

David Miller wrote: From: Richard Knutsson <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 15:37:46 +0100 David Miller wrote: But this time I'll just let you know up front that I don't see much value in this patch. It is not a clear improvement to replace int's with

Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

es? Do you use integers for ASCII characters too? It can also avoid some potential bugs like the 'if (i == TRUE)'... What is wrong with 'size_t' (since it is unsigned, compared to (some) 'int')? /Richard Knutsson -- To unsubscribe from this list: send the line "

[PATCH] ivtv: Some general fixes

Fix "warning: Using plain integer as NULL pointer". Convert 'x < y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> Signed-off-by: Hans Verkuil <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and &q

Re: [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes

Hans Verkuil wrote: On Sunday 02 December 2007 18:46, Richard Knutsson wrote: Fix "warning: Using plain integer as NULL pointer". Signed-off-by: Hans Verkuil <[EMAIL PROTECTED]> Remove a gcc-2.95 requirement. NACK! The main v4l-dvb repository that contains

[PATCH 2/2] ivtv: Remove a invalid shadow-variable

Remove the shadowing 'struct v4l2_chip_ident *chip', since it already exists and makes the if-statement useless. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and "allmodconfig". diff --git a/drivers/medi

[PATCH 1/2] ivtv: Some general fixes

Fix "warning: Using plain integer as NULL pointer". Remove a gcc-2.95 requirement. Convert 'x < y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and "allmodconfig".

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

Vegard Nossum wrote: Hi, On Nov 28, 2007 7:51 AM, Richard Knutsson <[EMAIL PROTECTED]> wrote: Vegard Nossum wrote: +static int Not 'static bool'? +page_is_tracked(struct page *page) Why not returning 'false' and 'true'?

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

gs & (1 << PG_slab)) +return address_get_shadow_slab(address, head); + +return NULL; +} + +static int 'static bool'? +test(void *shadow, unsigned int size) +{ +switch (size) { +case 8: +return *(uint8_t *) shadow == 0xff; +case 16: +return

Re: [PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Please ignore the previous patch. Have resent it, but since my mail-client (Thunderbird) seem to be having a bad day, I had to use 'sendpatchset' and it can't continue on a thread. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kern

[PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Complement va_start() with va_end() + minor style fixes in the same function. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. Thanks to WANG Cong for pointing out the missing 'style fix'-description. (Sorry about

[PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Complement va_start() with va_end() + minor style fixes in the same function. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. Thanks to WANG Cong for pointing out the missing 'style fix'-description. s

[PATCH] [VIDEO]: Complement va_start() with va_end().

Complement va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c index ad02329..996b494 100644 --- a/drivers/media/video/saa5

Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead

hy use '0' instead of 'false'? } static void tcrypt_complete(struct crypto_async_request *req, int err) cu Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

med quite messy. When it comes to va_end() and maintainers, they often seem positive to this. I guess the occasional lack off va_end() is usually an oversight. -Original Message- From: Richard Knutsson [mailto:[EMAIL PROTECTED] Sent: Monday, November 26, 2007 4:16 PM To: Moore, Robert Cc:

Re: [PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

we do)) and to automated searches (that is how I found this one). I suppose some implementation could allocate memory at va_start, but in practice, does this happen? Not sure what you mean. Bob cu Richard Knutsson [1] http://www.cs.utah.edu/dept/old/texinfo/glibc-manual-0.02/library

[PATCH] [REISERFS]: Complement va_start() with va_end().

Complement va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. BTW, the nested if()'s (lines above) may look better if unnested. diff --git a/fs/reiserfs/prints.c b/fs/reiserfs/prints.c in

Re: [PATCH] net/irda/parameters.c: Trivial fixes

Samuel Ortiz wrote: Hi Richard, On Sat, Nov 24, 2007 at 09:44:05PM +0100, Richard Knutsson wrote: Make a single va_start() -> va_end() path + fixing: Ok, this should be 2 separate patches then. Thought about it, but they were so simple, I believed they would better be mer

[PATCH] include/asm-m68k: Remove atari_joystick.h

Remove include/asm-m68k/atari_joystick.h and clean up. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Not compiled, but should be trivial. (if FIXED_ATARI_JOYSTICK is defined somehow, please tell how) b/arch/m68k/atari/atakeyb.c|8 b/arch/m68k/atari/atari_k

[PATCH] kernel: Compliment va_copy with va_end()

Compliment va_copy() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig & allmodconfig. diff --git a/kernel/audit.c b/kernel/audit.c index f93c271..836626c 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -1245,6 +1245,7

[PATCH] [MIPS]: Compliment va_start() with va_end().

Compliment va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- ieee754.c |2 ++ ieee754dp.c |2 ++ ieee754sp.c |2 ++ 3 files changed, 6 insertions(+) diff --git a/arch/mips/math-emu/ieee754.c b/arch/mips/math-emu/ieee754.c index 946aee3..c

[PATCH] net/irda/parameters.c: Trivial fixes

nel/src/net/irda/parameters.c:573:2: warning: Using plain integer as NULL pointer Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. diff --git a/net/irda/parameters.c b/net/irda/parameters.c index 2627dad..bf19071 100644 --- a

[PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

Compliment va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig & allmodconfig. utdebug.c |2 ++ utmisc.c |4 2 files changed, 6 insertions(+) diff --git a/drivers/acpi/utilities/utdebug.c b/dr

Re: [patch 02/13] dio: ARRAY_SIZE() cleanup

Geert Uytterhoeven wrote: -#define NUMNAMES (sizeof(names) / sizeof(struct dioname)) +#define NUMNAMES ARRAY_SIZE(names) Why not replace NUMNAMES? /Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

Re: [PATCH] mtrr use type bool

Paul Jimenez wrote: On Wednesday, Oct 31, 2007, Richard Knutsson writes: if (likely(replace < 0)) usage_table[i] = 1; else { - usage_table[i] = usage_table[replace] + !!increm

Re: [PATCH] mtrr use type bool

Lennart Sorensen wrote: On Wed, Oct 31, 2007 at 04:27:31PM +0100, Richard Knutsson wrote: Paul Jimenez wrote: - usage_table[i] = usage_table[replace] + !!increment; + usage_table[i] = usage_table[replace] + increment; This

Re: [PATCH] mtrr use type bool

{ return -ENODEV; } - The rest looks good :) Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 05:46:08PM +0100, Richard Knutsson wrote: I just don't see the reason why expressing a boolean as an integer. Some advantage? This is C, not Java, or some other highly-typed language. if (int) and if (ptr) are perfectly acceptable

Re: [PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup.

Denys Vlasenko wrote: On Tuesday 30 October 2007 10:54, Richard Knutsson wrote: Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Diffed against linus-git Checked with script/checkpatch.pl diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h index 451accd..6

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 04:02:25PM +0100, Richard Knutsson wrote: Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: Convert to use the generic boolean. - u8 initialized; - u8 in_use; /* is

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: Convert to use the generic boolean. - u8 initialized; - u8 in_use; /* is the management node open*/ + bool initialized:8; + bool in_use:8; /* is the

[PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup.

Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Diffed against linus-git Checked with script/checkpatch.pl diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h index 451accd..6f56528 100644 --- a/drivers/scsi/lpfc/lpfc_hw.h +++ b/drivers/scsi/lpfc/lpfc_hw.h @@ -3

[PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Convert to use the generic boolean. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Diffed against linus-git Checked with script/checkpatch.pl (warned about long lines, but it is not introduced by this patch) dpt_i2o.c | 22 +++--- dpti.h|9 ++--- 2

[PATCH] acpi: 'acpi_gbl_system_awake_and_running' is no longer used, only assigned.

'acpi_gbl_system_awake_and_running' is no longer used, only assigned. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Diffed against linus-git Checked with script/checkpatch.pl drivers/acpi/hardware/hwsleep.c |5 - drivers/acpi/utilities/utglobal.c |1

[PATCH] kernel: Convert to generic boolean-functions

Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/include/linux/relay.h b/include/linux/relay.h index 6cd8c44..70f4dc9 100644 --- a/include/linux/relay.h +++ b/include/linux/relay.h @@ -175,7 +175,7 @@ extern void relay_subbufs_consumed(struct rchan

Re: [PATCH] [libata] fix 'if(' and similar areas that lack whitespace

eadw(mmio + NV_ADMA_CTL ); /* flush posted write */ and here udelay(1); writew(tmp & ~NV_ADMA_CTL_CHANNEL_RESET, mmio + NV_ADMA_CTL); - readw( mmio + NV_ADMA_CTL );/* flush posted write */ + readw(mmio + NV_ADMA_CTL ); /* flush posted write */ and here

[PATCH] softmac: Fix compiler-warning

: efe870f9f4ad74410a18ecbf0d9ba7c14b50a0fb. Removing the label. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c b/net/ieee80211/softmac/ieee80211softmac_wx.c index 442b987..5742dc8 100644 --- a/net/ieee80211/s

Re: [PATCH] add page->mapping handling interface [1/35] interface definitions

_MAPPING_ANON) != 0; +} + If you don't mind bool(eans) (for some reason), I can/will check out the rest. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/9] s2io, rename BIT macro

xff)<<24) | (((d>>8)&0xff)<<16) | (((d>>16)&0xff)<<8)| ((d>>24)&0xff) Sorry for the late response, but would it not be better/easier to use BIT() instead (or a global #define LLBIT(nr) (1ULL << (nr))) and just recalculate the values? Rich

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

simple "diffstat -p1 -l | xargs " makes the day. Too bad, as Joe pointed out, it does not include relevant ML. cheers Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] drivers/net/tokenring: Convert to generic boolean

Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys diff --git a/drivers/net/tokenring/ibmtr.c b/drivers/net/tokenrin

[PATCH] drivers/net/tlan: Convert to generic boolean

Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys diff --git a/drivers/net/tlan.c b/drivers/net/tlan.c index 106dc1e.

[PATCH] drivers/net/3c505: Convert to generic boolean

Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys diff --git a/drivers/net/3c505.c b/drivers/net/3c505.c index e985a85.

[PATCH] arch/i386: Convert to generic boolean

Convert to generic boolean (+ some minor cleanup). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on i386 Diffed against Linus' git-tree Sent on 2007-05-12, no replys amd.c |2 -- cyrix.c |2 +- gener

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

Kok, Auke wrote: Richard Knutsson wrote: Kok, Auke wrote: Joe Perches wrote: I grew weary of looking up the appropriate maintainer email address(es) to CC: for a patch. I added flags to the MAINTAINERS file F:file pattern for each maintained block and a script to parse the modified

Re: [PATCH] [2/2many] - FInd the maintainer(s) for a patch - MAINTAINERS

Joe Perches wrote: It helps when you do the diff the right way. Describe the new F: pattern Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index d3a0684..0d7f856 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -83,6 +83,13 @@ S: Status, one of the following

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

be even ".maintainer" now). It has also been suggested that the file should be at the lowest common pathway to avoid duplication. Downside is the added need to search for the file... Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel&

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

even earlier. The expression; nothing is new under the sun comes to mind ;) Anyway, glad to see someone actually implementing it. Thanks! Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] sonypi: Fix initialization warning

Thomas Renninger wrote: On Sun, 2007-08-05 at 21:05 +0200, Richard Knutsson wrote: Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Got this from the compiler (gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)): drivers/char/sonypi.c:1153: warning: initialization from incompatible p

[PATCH] sonypi: Fix initialization warning

Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Got this from the compiler (gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)): drivers/char/sonypi.c:1153: warning: initialization from incompatible pointer type diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c index 73037a4..2

Re: [PATCH 06/68] 0 -> NULL, for arch/frv

Mike Frysinger wrote: On 7/31/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Mike Frysinger wrote: On 7/27/07, Robin Getz <[EMAIL PROTECTED]> wrote: If there is a definite style or semantic preference that everyone should live with - does it make sense to p

Re: [PATCH 02/68] 0 -> NULL, for arch/arm

buse the '!' on "regular" variables. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 06/68] 0 -> NULL, for arch/frv

o know if the thing being tested is a pointer ... dont know if the sparse utility would be able to pick it out as i'm not familiar with what level that thing runs at Didn't he mean "x == NULL" > "!x"? Richard Knutsson (wrote this offline so if someone has alr

Re: generic bool and sparse errors?

o think of that. I do not see how that would make any sense. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] drivers/block/z2ram: Remove TRUE/FALSE defines

Remove defines of TRUE and FALSE * not used in the file * the file is not included somewhere else Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Not compile-tested (don't have an Amiga-crosscompiler), but it is trivial. Diffed against Linus' git-tree. diff --git

[PATCH] usbusx2yaudio: kfree(NULL) is valid

if (!x) kfree(x); is not needed since kfree(NULL) is valid. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/

[PATCH] arch/i386: Convert to generic boolean

Convert to generic boolean (+ some minor cleanup). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on i386 Diffed against Linus' git-tree. amd.c |2 -- cyrix.c |2 +- generic.c | 20 +--- mtrr.h|

[PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean

Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) got some warnings on some builds, none related to this patch Diffed against Linus' git-tree. aic7xxx_old.c

Re: [PATCH] block: Convert to generic boolean

Alan Cox wrote: On Tue, 1 May 2007 21:08:36 +0200 (MEST) Richard Knutsson <[EMAIL PROTECTED]> wrote: Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested but most arch/conf tested failed for other reasons then this Diffed against Lin

Re: [PATCH] drivers/scsi/pci2000.h: Remove unused file

James Bottomley wrote: On Tue, 2007-05-01 at 14:16 -0400, Robert P. J. Day wrote: On Tue, 1 May 2007, Richard Knutsson wrote: Remove the unused header drivers/scsi/pci2000.h i have the same patch in my pending patch directory, dated march 10, so i know i submitted it, but i

[PATCH] block: Convert to generic boolean

Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested but most arch/conf tested failed for other reasons then this Diffed against Linus' git-tree. ps2esdi.c |8 z2ram.c |3 --- 2 files changed, 4 insertions(+), 7 deletion

[PATCH] drivers/scsi/pci2000.h: Remove unused file

Remove the unused header drivers/scsi/pci2000.h Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- 'grep -nr "pci2000"' on the whole tree results only in a reference to pci2000.h Diffed against Linus' git-tree. diff --git a/drivers/scsi/pci2000.h b/drivers/s

Re: [RFC][PATCH] fix abs() macro to work with types wider than int

Randy Dunlap wrote: On Thu, 19 Apr 2007 11:23:39 +0200 Jiri Bohac wrote: Hi, is there any reason to use an explicit int instead of a typeof in the abs() macro? The current implementation will return bogus results when used with longs. I think it's like it is just to be consistent wit

Re: PCI: the overdue removal of pci_module_init()

Bunk <[EMAIL PROTECTED]> --- -What: pci_module_init(driver) -When: January 2007 -Why: Is replaced by pci_register_driver(pci_driver). -Who: Richard Knutsson <[EMAIL PROTECTED]> and Greg Kroah-Hartman <[EMAIL PROTECTED]> - -

Re: Reiser4. BEST FILESYSTEM EVER - Christer Weinigel

[EMAIL PROTECTED] wrote: On Mon, 09 Apr 2007 00:58:53 +0200, "Richard Knutsson" <[EMAIL PROTECTED]> said: Wow, I'm impressed. Think you got the record on how many mails you referenced to in a reply... TWO actually. I guess you are easily impressed. Oh, t

Re: Reiser4. BEST FILESYSTEM EVER - Christer Weinigel

be some more plausible reasons for corruption), is the OS really suppose to handle it? Yes, it should not assign any new data to those blocks but should it not also fall into the file-systems domain to be able to restore some/all data? Just my 2c to the pond Richard Knutsson - To unsubs

Re: [KJ][PATCH] BIT macro cleanup

)| ((d>>24)&0xff) Why not use "LLBIT(63 - loc)" instead? Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [KJ][PATCH] BIT macro cleanup

ose between possible errors. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [2.6.22 patch] more scheduled OSS driver removal

Lee Revell wrote: On 3/25/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Adrian Bunk wrote: > This patch contains the scheduled removal of OSS drivers that: > - have ALSA drivers for the same hardware without known regressions and > - whose Kconfig options have been re

Re: [2.6.22 patch] more scheduled OSS driver removal

Adrian Bunk wrote: On Mon, Mar 26, 2007 at 03:26:19AM +0200, Richard Knutsson wrote: Adrian Bunk wrote: This patch contains the scheduled removal of OSS drivers that: - have ALSA drivers for the same hardware without known regressions and - whose Kconfig options have been removed in

Re: [2.6.22 patch] more scheduled OSS driver removal

detailed information on this stuff would be much appreciated! Thanks and good night Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Pleas

Re: [PATCH] drivers/char/agp: Convert to generic boolean

Please use "Reply All" Joe Perches wrote: On Sun, 2007-03-18 at 00:45 +0100, Richard Knutsson wrote: diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/amd-k7-agp.c index e6c534e..3d57e9f 100644 --- a/drivers/char/agp/amd-k7-agp.c +++ b/drivers/char/agp/amd-k7-agp.c

[PATCH] drivers/scsi/eata_generic.h: Remove FALSE/TRUE defines

Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Only included by drivers/scsi/eata_pio.c and it only uses FALSE/TRUE in comments. diff --git a/drivers/scsi/eata_generic.h b/drivers/scsi/eata_generic.h index 635c148..5016af5 100644 --- a/drivers/scsi/eata_generic.h +++ b/driver

  1   2   >