&data, 4);
> }
> }
It's "base address + address offset". The arithmetic operator is correct.
--
Stefan Richter
-==--=-= --== -===-
http://arcgraph.de/sr/
c(sizeof(*e) + request->length, GFP_KERNEL);
> if (e == NULL)
> return -ENOMEM;
There is already a length check for asynchronous stream requests.
It happens in ioctl_send_stream_packet().
--
Stefan Richter
-==--=-= --== ---=-
http://arcgraph.de/sr/
l > 63)
return -EINVAL;
-
- cb = iso_callback;
break;
case FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL:
- cb = (fw_iso_callback_t)iso_mc_callback;
break;
default:
@@ -990,9 +984,15 @@ static int ioctl_create_iso_context(struct client *client,
union ioctl_arg *arg)
}
context = fw_iso_context_create(client->device->card, a->type,
- a->channel, a->speed, a->header_size, cb, client);
+ a->channel, a->speed, a->header_size, NULL, client);
if (IS_ERR(context))
return PTR_ERR(context);
+
+ if (a->type == FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL)
+ context->callback.mc = iso_mc_callback;
+ else
+ context->callback.sc = iso_callback;
+
if (client->version < FW_CDEV_VERSION_AUTO_FLUSH_ISO_OVERFLOW)
context->drop_overflow_headers = true;
--
Stefan Richter
-==--=-- -=-= ==--=
http://arcgraph.de/sr/
.c
> b/drivers/firewire/core-topology.c
> index 7db234d3fbdd..82c67e900aad 100644
> --- a/drivers/firewire/core-topology.c
> +++ b/drivers/firewire/core-topology.c
> @@ -67,6 +67,7 @@ static u32 *count_ports(u32 *sid, int *total_port_count,
> int *child_port_count)
> switch (por
ncy
Geert Uytterhoeven (1):
firewire: Remove depends on HAS_DMA in case of platform dependency
drivers/firewire/Kconfig | 1 -
1 file changed, 1 deletion(-)
Thanks,
--
Stefan Richter
-==---== ---= --=-=
http://arcgraph.de/sr/
/firewire/Kconfig
> +++ b/drivers/firewire/Kconfig
> @@ -1,5 +1,4 @@
> menu "IEEE 1394 (FireWire) support"
> - depends on HAS_DMA
> depends on PCI || COMPILE_TEST
> # firewire-core does not depend on PCI but is
> # not useful without PCI controller driver
--
Stefan Richter
-==---=- ==-- ---==
http://arcgraph.de/sr/
rge your patch and (b) clean out my mailbox and update my mail
sorting filters (long overdue after my mail service provider changed
backends).
Again sorry, and thank you for your extraordinary patience.
--
Stefan Richter
-==---=- =--= =--=-
http://arcgraph.de/sr/
394: allow user-configured MTU of up to 4096 bytes
Hector Martin (1):
firewire-ohci: work around oversized DMA reads on JMicron controllers
Stefan Richter (1):
firewire: net: max MTU off by one
drivers/firewire/net.c | 7 ++-
drivers/firewire/ohci.c | 8 +++-
2 files c
On Jan 11 Hector Martin 'marcan' wrote:
> On 2017-11-13 06:05, Stefan Richter wrote:
> > Thanks Hector for the troubleshooting and for the patch.
> > Thanks Clemens for the review.
> >
> > It's been a while since I last reviewed and tested kernel patches,
> +* for descriptors, even 0x10-byte ones. This can cause page faults when
> > +* an IOMMU is in use and the oversized read crosses a page boundary.
> > + * Work around this by always leaving at least 0x10 bytes of padding.
> > +*/
> > + desc->buffer_size = PAGE_SIZE - offset - 0x10;
> > desc->buffer_bus = bus_addr + offset;
> > desc->used = 0;
> >
--
Stefan Richter
-=== =-== -==--
http://arcgraph.de/sr/
fclose(input);
> return -1;
> }
> }
When we return from main(), all files are closed implicitly.
--
Stefan Richter
-=== =--= ==-=-
http://arcgraph.de/sr/
On Nov 14 Ben Hutchings wrote:
> 3.2.84-rc1 review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Stefan Richter
>
> commit 667121ace9dbafb368618dbabcf07901c962ddac upstream.
[...]
> [bwh: Backported to 3.2: fwnet_receive_b
Please tell us what your compile error was (and on what platform), so that
we can find out which dependency was really missing, if any.
--
Stefan Richter
-==- =-== -===-
http://arcgraph.de/sr/
-over-1394 encapsulation headers could trigger
buffer overflows (CVE 2016-8633).
- IP-over-1394 link fragmentation headers were read and written
incorrectly, breaking fragmented RX/TX with other OS's stacks.
Stefan Richter (2):
firewire: net: guard against rx buffer overflows
The latest max_mtu patch missed that datagram_size is actually one less
than the datagram's Total Length.
Fixes: 357f4aae859b ("firewire: net: really fix maximum possible MTU")
Signed-off-by: Stefan Richter
---
To be applied after net-next was merged.
drivers/firewire/net.c | 7
,
and it can be worked around by setting a small enough MTU.)
Cc: sta...@vger.kernel.org
Signed-off-by: Stefan Richter
---
drivers/firewire/net.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -73,13 +73,13 @@ st
: sta...@vger.kernel.org
Signed-off-by: Stefan Richter
---
drivers/firewire/net.c | 51 -
1 file changed, 35 insertions(+), 16 deletions(-)
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -578,6 +578,9 @@ static int fwnet_incoming_packet
in the net-next git tree, hence this patch will wait until net-next was
merged.
Patches 1+2/3 are already pushed out to linux1394.git "testing" and
"for-next" branches, but I still like to get review comments before I
send a pull request.
--
Stefan Richter
-==- =-
mum datagram size /with/ link fragmentation is 0xfff = 4095
for unicast and broadcast. This is because the RFC 2734 fragment
encapsulation header field for datagram size is only 12 bits wide.
Fixes: 5d48f00d836a('firewire: net: fix maximum possible MTU')
Signed-off-by: Stefan Richter
---
dri
Fixes: d894be57ca92('ethernet: use net core MTU range checking in more drivers')
CC: Jarod Wilson
CC: Thomas Falcon
Signed-off-by: Stefan Richter
---
drivers/net/ethernet/broadcom/sb1250-mac.c | 2 +-
drivers/net/ethernet/ibm/ibmveth.c | 2 +-
2 files changed, 2 insert
h was affected by this, changing
the MTU from 1008 to 1500 also increases TX bandwidth by 6 %.
RX remains unaffected.
CC: net...@vger.kernel.org
CC: linux1394-de...@lists.sourceforge.net
CC: Jarod Wilson
Signed-off-by: Stefan Richter
---
v2: use ETH_DATA_LEN, add comment
drivers/firewire/net.
h was affected by this, changing
the MTU from 1008 to 1500 also increases TX bandwidth by 6 %.
RX remains unaffected.
CC: net...@vger.kernel.org
CC: linux1394-de...@lists.sourceforge.net
CC: Jarod Wilson
Signed-off-by: Stefan Richter
---
drivers/firewire/net.c | 8 +---
1 file changed, 1 inse
TU range checking in misc drivers')
CC: net...@vger.kernel.org
CC: linux1394-de...@lists.sourceforge.net
CC: Jarod Wilson
Signed-off-by: Stefan Richter
---
drivers/firewire/net.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/firewire/net.c b/drivers/fir
Adding Cc: linux1394-devel, dropping several Ccs, no additional comment.
On Oct 22 Stefan Richter wrote:
> On Oct 20 Jarod Wilson wrote:
> > firewire-net:
> > - set min/max_mtu
> > - remove fwnet_change_mtu
> [...]
> > --- a/drivers/firewire/net.c
&g
net->mtu should be initialized to 1500, not less. But such a change
should be done in a separate patch.
--
Stefan Richter
-==- =-=- =-==-
http://arcgraph.de/sr/
On Oct 22 Stefan Richter wrote:
> On Oct 19 Jarod Wilson wrote:
> > On Thu, Oct 20, 2016 at 12:38:46AM +0200, Stefan Richter wrote:
> > > On Oct 19 Sabrina Dubroca wrote:
> > > > 2016-10-18, 22:33:33 -0400, Jarod Wilson wrote:
[...]
> > > > > @@ -14
> The 8191 was simply transplanted from right here. I think altering the
> value should be the subject of a separate patch.
You transplanted the value but dropped the comment. Though Denis' reply
sounds like the comment should have been /* FIXME, set by RxDMAFrameLen */.
--
Stefan Richter
-==- =-=- =-==-
http://arcgraph.de/sr/
On Oct 19 Jarod Wilson wrote:
> On Thu, Oct 20, 2016 at 12:38:46AM +0200, Stefan Richter wrote:
> > On Oct 19 Sabrina Dubroca wrote:
> > > 2016-10-18, 22:33:33 -0400, Jarod Wilson wrote:
> > > [...]
> > > > diff --git a/drivers/firewire/net.c b/drivers/firewi
attempt to
find the maximum speed and size that is supported by all potential
listeners). This limits the payload to 512 bytes.
Unicast packets are transmitted via IEEE 1394 asynchronous write request
packets at optimum speed. In most cases, this means that 2048 bytes
payload is possible, in so
firewire: nosy: do not ignore errors in ioremap_nocache()
drivers/firewire/nosy.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
Thanks.
--
Stefan Richter
-==- =-=- =---=
http://arcgraph.de/sr/
On Oct 12 l...@kernel.org wrote:
[...]
> Signed-off-by: Stefan Richter
> [lizf: Backported to 3.4: use dev_notice() instead of ohci_notice()]
> Signed-off-by: Zefan Li
> ---
> drivers/firewire/ohci.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/d
lynx->rcv_start_pcl, lynx->rcv_start_pcl_bus);
@@ -685,7 +685,7 @@ fail_deallocate:
lynx->rcv_buffer, lynx->rcv_buffer_bus);
iounmap(lynx->registers);
-fail_deallocate2:
+fail_deallocate_lynx:
kfree(lynx);
fail_disable:
--
Stefan Richter
-==- =-=- -=--=
http://arcgraph.de/sr/
stop_broadcast;
> }
[...]
> @@ -1166,8 +1166,7 @@ static int fwnet_broadcast_start(struct
> fwnet_device *dev) dev->broadcast_state = FWNET_BROADCAST_RUNNING;
>
> return 0;
> -
> - failed:
> + stop_broadcast:
> __fwnet_broadcast_stop(dev);
>
;fi_list);
> fi = fwnet_frag_new(new, frag_off, frag_len);
> - if (fi == NULL)
> + if (!fi)
> goto free_new;
[...]
--
Stefan Richter
-==- =--= ==---
http://arcgraph.de/sr/
possibly at the cost of superfluous code. Is gcc's optimizer
able to resolve kmalloc_array's check at compile time as always
false, such that the superfluous code is eliminated as dead code?
I believe I know answers to this but prefer to hear what you as the patch
author think about it.
--
Stefan Richter
-==- =--= ==---
http://arcgraph.de/sr/
On May 06 Daniel Vetter wrote:
> On Thu, May 05, 2016 at 10:45:31PM +0200, Stefan Richter wrote:
[...]
> > Subtest fbc-1p-primscrn-spr-indfb-fullscreen: FAIL (5.876s)
>
> This one failed in both runs. Can you please retest with just that using
>
> # kms_frontbuffer_track
On May 08 Stefan Richter wrote:
> On May 05 Zanoni, Paulo R wrote:
> > If you don't want to keep carrying a manual revert, you can just boot
> > with i915.enable_fbc=0 for now (or write a /etc/modprobe.d file). Also,
> > it would be good to know in case you still somehow
As expected, i915.enable_fbc=0 works fine.
No freeze within 2.5 days uptime; tested on v4.6-rc6.
--
Stefan Richter
-==- -=-= -=---
http://arcgraph.de/sr/
n test this sometime soon.
--
Stefan Richter
-==- -=-= --==-
http://arcgraph.de/sr/
On May 05 Zanoni, Paulo R wrote:
> Em Qui, 2016-05-05 às 19:45 +0200, Stefan Richter escreveu:
> > Oh, and in case you - the person reading this commit message - found
> > this commit through git bisect, please do the following:
> > - Check your dmesg and s
On May 05 Stefan Richter wrote:
> Quoting the changelog of the commit:
[...]
> - Download intel-gpu-tools, compile it, and run:
>$ sudo ./tests/kms_frontbuffer_tracking --run-subtest '*fbc-*' 2>&1 |
> tee fbc.txt
>Then send us the fbc.txt file,
On May 05 Stefan Richter wrote:
> Quoting the changelog of the commit:
[...]
> - Boot with drm.debug=0xe, reproduce the problem, then send us the
>dmesg file.
>
> I can try this, but I am skeptical about getting any useful kernel
> messages from before the hang.
On Apr 30 Stefan Richter wrote:
> On Apr 29 Stefan Richter wrote:
> > On Apr 26 Stefan Richter wrote:
> > > v4.6-rc solidly hangs after a short while after boot, login to X11, and
> > > doing nothing much remarkable on the just brought up X desktop.
> > >
On Apr 29 Stefan Richter wrote:
> On Apr 26 Stefan Richter wrote:
> > v4.6-rc solidly hangs after a short while after boot, login to X11, and
> > doing nothing much remarkable on the just brought up X desktop.
> >
> > Hardware: x86-64, E3-1245 v3 (Haswell),
> &g
On Apr 26 Stefan Richter wrote:
> v4.6-rc solidly hangs after a short while after boot, login to X11, and
> doing nothing much remarkable on the just brought up X desktop.
>
> Hardware: x86-64, E3-1245 v3 (Haswell),
> mainboard Supermicro X10SAE,
> usin
On Apr 27 Stefan Richter wrote:
> On Apr 27 Stefan Richter wrote:
> > Today I booted a 2nd time into v4.6-rc5, and loaded netconsole shortly
> > after boot and xdm login to try capturing an oops. But throughout 5 hours
> > uptime now, the hang was not reproduced.
>
> .
On Apr 27 Stefan Richter wrote:
> Today I booted a 2nd time into v4.6-rc5, and loaded netconsole shortly
> after boot and xdm login to try capturing an oops. But throughout 5 hours
> uptime now, the hang was not reproduced.
...and 20 minutes after this post went out, the PC hang.
On Apr 26 Stefan Richter wrote:
> v4.6-rc solidly hangs after a short while after boot, login to X11, and
> doing nothing much remarkable on the just brought up X desktop.
>
> Hardware: x86-64, E3-1245 v3 (Haswell),
> mainboard Supermicro X10SAE,
> usin
On Apr 26 Stefan Richter wrote:
> v4.6-rc solidly hangs after a short while after boot, login to X11, and
> doing nothing much remarkable on the just brought up X desktop.
>
> Hardware: x86-64, E3-1245 v3 (Haswell),
> mainboard Supermicro X10SAE,
> usin
On Apr 26 Stefan Richter wrote:
> Hardware: x86-64, E3-1245 v3 (Haswell),
> mainboard Supermicro X10SAE,
> using integrated Intel graphics (HD P4600, i915 driver),
> C226 PCH's AHCI and USB 2/3, ASMedia ASM1062 AHCI,
> Intel L
info (simplify the hardware, run
netconsole, bisect). In practice I cannot do so for the the time being
due to lack of spare time. That's also the reason why I did not already
send a report when I tested v4.6-rc2, and why I did not boot v4.6-rc[25]
more than once yet.
--
Stef
ove a last forgotten one.
Tina Ruchandani (1):
firewire: nosy: Replace timeval with timespec64
drivers/firewire/nosy.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
--
Stefan Richter
-==- --== ==--=
http://arcgraph.de/sr/
o remove all instances of
>>>> 'struct timeval' from the kernel (that would help identify cases
>>>> where the code is actually broken).
>>>>
>>>> Signed-off-by: Tina Ruchandani
[...]
> Reviewed-by: Arnd Bergmann
Committed to linux1394.git.
I will try to get this pulled upstream in the next few days.
--
Stefan Richter
-==- --== =-==-
http://arcgraph.de/sr/
tch looks correct to me, but it seems the same one has
> just been merged into mainline Linux on Saturday (the patch
> was posted back in October).
>
> commit 2ae4b6b20e2004dccf80d804ae52b073377c2f5b
[...]
No, Amitoj's patch from October changed nosy.c::packet_irq_hander, whereas
ation bits.
Amitoj Kaur Chawla (1):
firewire: nosy: Replace timeval with timespec64
Stefan Richter (3):
firewire: ohci: propagate return code from soft_reset to probe and resume
firewire: ABI documentation: jujuutils were renamed to
linux-firewire-utils
firewire: ABI doc
On Nov 24 Ben Hutchings wrote:
> commit 100ceb66d5c40cc0c7018e06a9474302470be73c upstream.
...
> [bwh: Backported to 3.2: log with fw_notify() instead of ohci_notice()]
Thanks for doing so, looks good to me.
--
Stefan Richter
-=-= =-== ==--=
http://arcgraph.de/sr/
--
To unsubscrib
audio via FFADO or ALSA.
Stefan Richter (1):
firewire: ohci: fix JMicron JMB38x IT context discovery
drivers/firewire/ohci.c | 5 +
1 file changed, 5 insertions(+)
Thanks,
--
Stefan Richter
-=-= =-== -=-==
http://arcgraph.de/sr/
--
To unsubscribe from this list: sen
timeofday(&tv);
> > - lynx->rcv_buffer[0] = (__force __le32)tv.tv_usec;
> > + ktime_get_real_ts64(&ts64);
> > + timestamp = ts64.tv_nsec / NSEC_PER_USEC;
> > + lynx->rcv_buffer[0] = (__force __le32)timestamp;
> >
> > if (length == PHY_PACKET_SIZE)
> > tcode_mask = 1 << TCODE_PHY_PACKET;
> >
>
--
Stefan Richter
-=-= =-== --=-=
http://arcgraph.de/sr/
pgpk2T5ScpSNO.pgp
Description: OpenPGP digital signature
v: pointer to the timeval to be set
*
* NOTE: Users should be converted to using getnstimeofday()
*/
So what is the reason for calling ktime_get_real_ts64() instead of
getnstimeofday[64]()?
PS, note to self:
Independently of this patch, I need to check whether CLOCK_REALTIME was
r
re proceeds to modify the speed based on a probing loop, if
certain conditions are met. Maybe this speed probe should be skipped if
the user selected a desired speed. Or there should be a dedicated
parameter value which means "firewire-core, please always perform your
built-in speed probe&qu
eby
certainly page-aligned. This could be looked up in the sysfs core code.
BTW, theoretically speaking it should be cpu_to_be32() here, and the buffer
pointer should be annotated as a big endian pointer. (But as I noted in
the previous reply, the patch will not be applied either way.)
--
Stefan
his patch adds a a parameter (force_speed) to the firewire-core module
> > to be able to set the max speed to use with the firewire devices.
>
> Why a module parameter? Why not automatically apply this workaround to
> this specific device?
I doubt that this iPod model needs the wo
+ size_t i;
>
> down_read(&fw_device_rwsem);
> - length = device->config_rom_length * 4;
> - memcpy(buf, device->config_rom, length);
> + for (i = 0; i < device->config_rom_length; i++)
> + ((u32 *)buf)[i] = be32_to_cpu(device-&g
> -#include
> +#include
> #include
> #include
> #include
As mentioned in my reply to 00/86, this does not seem useful to me.
--
Stefan Richter
-=-= --== -
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
e moved to include/uapi.
> 3. include/linux/pci_ids.h is removed
> 4. cleanups for several issues detected during step 2
--
Stefan Richter
-=-= --== -
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messa
whether an IOMMU influences remote DMA via
PROVIDE_OHCI1394_DMA_INIT, i.e. whether or not the IOMMU (if one is
present in the system) maps all device addresses 1:1 during early boot
stages. However, firewire-ohci's --- and with it, firewire-sbp2's ---
remote DMA is sub
mens Ladisch (1):
firewire: core: use correct vendor/model IDs
Rickard Strandqvist (1):
firewire: ohci: Remove unused function
Stefan Richter (1):
firewire: sbp2: remove redundant check for bidi command
drivers/firewire/core-transaction.c | 4 ++--
drivers/firewire/ohci.c
On Feb 08 nick wrote:
> On 2015-02-08 06:55 PM, Stefan Richter wrote:
> > I still am missing research on the question whether or not the Common
> > Interface serving part of the driver needs to send Host2CA commands. If
> > yes, we implement it and use the function.
r_operands(c, 6, 8);
> -
> - fdtv->avc_data_length = 12;
> - ret = avc_write(fdtv);
> -
> - /* FIXME: check response code? */
> -
> - mutex_unlock(&fdtv->avc_mutex);
> -
> - return ret;
> -}
> -#endif
> -
> static int get_ca_object_pos(st
t; -
> - mutex_unlock(&fdtv->avc_mutex);
> -
> - return ret;
> -}
> -#endif
> -
> static int get_ca_object_pos(struct avc_response_frame *r)
> {
> int length = 1;
--
Stefan Richter
-=-= --=- -=---
http://arcgraph.de/sr/
--
To unsubscribe from this
On Feb 03 Peter Hurley wrote:
> On 02/03/2015 03:44 AM, Stefan Richter wrote:
> > On Feb 02 Peter Hurley wrote:
[...]
> >> The problem is a host with the old OUIs will not recognize a remote
> >> unit with the new OUIs, and vice versa.
> >>
> >> Even
rotocol are your own,
and as yet unmerged. (In addition, there does not yet exist a second
implementation, AFAIK.) So I'd say there is still opportunity to improve
the protocol even in incompatible ways if justified. Switching to
valid identifiers may very well be such a justifiable change.
--
On Feb 01 Joe Perches wrote:
> > > > > On Sun, 2015-02-01 at 20:59 +0100, Stefan Richter wrote:
> > > > > > > ERROR: Please use 12 or more chars for the git commit ID like:
> > > > > > > 'Commit
> > > > > > >
On Feb 01 Joe Perches wrote:
> On Sun, 2015-02-01 at 21:30 +0100, Stefan Richter wrote:
> > On Feb 01 Joe Perches wrote:
> > > On Sun, 2015-02-01 at 20:59 +0100, Stefan Richter wrote:
> > > > > ERROR: Please use 12 or more chars for the git commit ID like: 'C
On Feb 01 Joe Perches wrote:
> On Sun, 2015-02-01 at 20:59 +0100, Stefan Richter wrote:
> > I was just told that 12 is less than 12:
> >
> > > ERROR: Please use 12 or more chars for the git commit ID like: 'Commit
> > > 01234567890ab ("commit descripti
: 1 errors, 0 warnings, 66 lines checked
>
> patches/scsi-sr-fix-multi-drive-performance-remove-bkl-replacement.patch
> has style problems, please review.
--
Stefan Richter
-=-= --=- =
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubs
This driver didn't exist until before v3.19.
Why would suddenly everybody want to build it?
Signed-off-by: Stefan Richter
---
drivers/hid/Kconfig |1 -
1 file changed, 1 deletion(-)
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -628,7 +628,6 @@ config HID_PICOLCD_CIR
c
quot; will remain
true only once a corresponding change to firewire-core was merged.
Proposed patch: http://marc.info/?l=linux1394-devel&m=142247554618207
(If I receive no substantial objections, this will go in in the next
merge window.)
Date: Wed, 28 Jan 2015 21:04:48 +0100
From: Clemen
return (index + 1) % AR_BUFFERS;
> }
>
> -static inline unsigned int ar_prev_buffer_index(unsigned int index)
> -{
> - return (index - 1 + AR_BUFFERS) % AR_BUFFERS;
> -}
> -
> static inline unsigned int ar_first_buffer_index(struct ar_context *ctx)
of core lock in firewire-sbp2.
Clemens Ladisch (1):
firewire: ohci: replace vm_map_ram() with vmap()
Stefan Richter (4):
firewire: core: document fw_csr_string's truncation of long strings
firewire: sbp2: protect a reference counter properly
firewire: sbp2: replace so
detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Reviewed-by: Stefan Richter
> ---
> drivers/media/firewire/firedtv-ci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/firewire/firedtv-ci.c
> b/driver
titute for missing ioctl() argument data. This could
partially show up in subsequent read() output.
Stefan Richter (1):
firewire: cdev: prevent kernel stack leaking into ioctl arguments
drivers/firewire/core-cdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Thanks,
--
Stef
Adding Cc: linux-api and lkml, quoting parent message in full
On Nov 11 Stefan Richter wrote:
> On Nov 11 Stefan Richter wrote:
> > On Nov 10 David Ramos wrote:
> > > This patch fixes an uninitialized memory use/leak bug discovered
> > > by our UC-KLEE tool in the 3.16.
emset(..., 40) is added to each firewirew-cdev
ioctl() call.
Reported-by: David Ramos
Cc:
Signed-off-by: Stefan Richter
---
drivers/firewire/core-cdev.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/firewire/core-cdev.c
+++ b/drivers/firewire/core-cdev.c
@@ -1625,32 +16
s
Cc:
Signed-off-by: Stefan Richter
---
drivers/firewire/core-cdev.c | 33 +
1 file changed, 33 insertions(+)
--- a/drivers/firewire/core-cdev.c
+++ b/drivers/firewire/core-cdev.c
@@ -1609,48 +1609,81 @@ static int (* const ioctl_handlers[])(st
stall. (v3.17-rc4 is current, v3.16.2 is the lastest on in
the 3.16 branch.)
- Post the dmesg output from a successful boot with 3.15 and from an
unsuccessful boot with 3.16.
[added Cc: linux-pci]
--
Stefan Richter
-=-- =--= -===-
http://arcgraph.de/sr/
--
To unsubscri
Folding two replies into one.
On Sep 02 Sander Nemvalts wrote:
> On Sep 2, 2014 12:56 AM, "Stefan Richter" wrote:
>
> > On Sep 01 Sander Nemvalts wrote:
> > > --- a/drivers/firewire/core-card.c
> > > +++ b/drivers/firewire/core-card.c
> > > @@ -
;key | (j - i));
We are writing
for (a; b; c);
not
for(a; b; c);
and thus a space after list_for_each and friends makes sense.
--
Stefan Richter
-=-- =--= =
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
egression since
v3.16-rc1).
Stefan Richter (1):
firewire: ohci: disable MSI for VIA VT6315 again
drivers/firewire/ohci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thank you,
--
Stefan Richter
-=-- -=== ==-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list
ted-by: Rémy Bruno
Signed-off-by: Stefan Richter
---
drivers/firewire/ohci.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@ -336,10 +336,10 @@ static const struct {
QUIRK_CYCLE_TIM
the DMA mapping
API.
(Regression since v3.16-rc1 with CONFIG_COMPILE_TEST=y on some architectures.)
Geert Uytterhoeven (1):
firewire: IEEE 1394 (FireWire) support should depend on HAS_DMA
drivers/firewire/Kconfig | 1 +
1 file changed, 1 insertion(+)
Thanks,
--
Stefan Richter
-=--
fer *buffer,
> return 0;
> }
>
> +#ifdef CONFIG_HAS_DMA
> void fw_iso_buffer_destroy(struct fw_iso_buffer *buffer,
> struct fw_card *card)
> {
> @@ -141,6 +150,12 @@ void fw_iso_buffer_destroy(struct fw_iso_buffer *buffer,
> buffer-&
On Jun 11 Thomas Gleixner wrote:
> do_posix_clock_monotonic_gettime() is a leftover from the initial
> posix timer implementation which maps to ktime_get_ts()
>
> Signed-off-by: Thomas Gleixner
> Cc: Stefan Richter
Acked-by: Stefan Richter
(Though I am noticing increas
On Jun 11 Stefan Richter wrote:
> Nice -- yesterday, just a few days after this patch went into the
> mainline, this VT6315 card suddenly stopped to generate any interrupt
> while being in use with a soundcard and jackd. Until then it ran
> perfectly for many days, with jackd+ffad
On Apr 16 Stefan Richter wrote:
> Commit af0cdf494781 "firewire: ohci: fix regression with VIA VT6315,
> disable MSI" acted upon a report against VT6315 rev 0:
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-12/msg02301.html
> $ lspci -nn
> VIA Technologies, In
.
Daeseok Youn (1):
firewire: net: fix NULL derefencing in fwnet_probe()
Jean Delvare (1):
firewire: Use COMPILE_TEST for build testing
Stefan Richter (1):
firewire: ohci: enable MSI for VIA VT6315 rev 1, drop cycle timer quirk
drivers/firewire/Kconfig | 2 +-
drivers/firewire/n
Linus,
please pull from the tag "firewire-fixes" at
git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git
firewire-fixes
to receive a regression fix for the IEEE 1394 subsystem:
Re-enable IRQ-based asynchronous request reception at addresses below 128 TB.
Stefan
net = alloc_netdev(sizeof(*dev), "firewire%d", fwnet_init_dev);
> if (net == NULL) {
> - ret = -ENOMEM;
> - goto out;
> + mutex_unlock(&fwnet_device_mutex);
> + return -ENOMEM;
> }
>
> alloca
_CYCLE_TIMER
and QUIRK_NO_MSI.
Hence, just add a whitelist entry specifically for VT6315 rev >= 1
without any quirk flags.
Signed-off-by: Stefan Richter
---
drivers/firewire/ohci.c |4
1 file changed, 4 insertions(+)
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@
Date:
From: Stefan Richter
Subject: firewire: ohci: enable MSI for VIA VT6315 rev 1, drop cycle timer quirk
Commit af0cdf494781 "firewire: ohci: fix regression with VIA VT6315,
disable MSI" acted upon a report against VT6315 rev 0:
http://linux.derkeiler.com/Mailing-Lists/Kern
1 - 100 of 1128 matches
Mail list logo
