On Thu, Nov 8, 2018 at 2:59 AM Uwe Kleine-König
wrote:
>
> Hello,
>
> adding Tim Kryger as the initial author of the bcm-kona driver to Cc:.
> Maybe he can shed some light to the questions below?
>
> On Thu, Nov 08, 2018 at 11:47:17AM +0100, Clément Péron wrote:
> >
On Wed, May 3, 2017 at 8:40 AM, Olliver Schinagl wrote:
> Hey Tim,
>
> Ok, so as far as I understand (from the datasheet) the intended way to do
> this would be to check for the BUSY IRQ & USR[0] IRQ and if it is busy,
> (re-write) the LCR. We no longer do this because it did not work due to the
On Wed, May 3, 2017 at 4:26 AM, Olliver Schinagl wrote:
> Hey Chen-Yu
>
> On 03-05-17 12:40, Chen-Yu Tsai wrote:
>>
>> On Wed, May 3, 2017 at 6:17 PM, Olliver Schinagl
>> wrote:
>>>
>>> Hey Jamie,
>>>
>>> Several years ago you wrote the glue-code [0] for the DW 8250 IP. Over
>>> the
>>> years var
ttern of the completion is:
>
> bcm_kona_send_i2c_cmd()
> reinit_completion()
> ...
> bcm_kona_i2c_send_cmd_to_ctrl()
> ...
> wait_for_completion_timeout()
>
> Signed-off-by: Daniel Wagner
Reviewed-by: Tim Kryger
> ---
> drivers/i2c/busses/i2c-bcm-
On Fri, Jun 12, 2015 at 2:45 AM, Thierry Reding
wrote:
> On Tue, May 26, 2015 at 01:08:16PM -0700, Jonathan Richardson wrote:
>> From: Tim Kryger
>>
>> Add a new function to register a PWM chip with channels that have their
>> initial polarity as inversed. This bene
On Tue, May 26, 2015 at 1:08 PM, Jonathan Richardson
wrote:
> Adds debugging info to config function where duty cycle and period
> are calculated and verified.
>
> Signed-off-by: Jonathan Richardson
> ---
> drivers/pwm/pwm-bcm-kona.c | 25 +++--
> 1 file changed, 23 inserti
r 400ns. This corrects an issue where occasionally a
requested change was not properly reflected in the PWM output.
Otherwise, this patch looks reasonable so
Reviewed-by: Tim Kryger
>
> Reviewed-by: Arun Ramamurthy
> Reviewed-by: Scott Branden
> Tested-by: Scott Branden
On Thu, May 21, 2015 at 3:50 PM, Jonathan Richardson
wrote:
> If this is correct - polarity changes affect the output signal
> immediately, then I can change our driver. Could you confirm first this
> is what we want?
Yes. This seems best. Please do.
-Tim
--
To unsubscribe from this list: sen
On Tue, May 12, 2015 at 4:28 PM, Jonathan Richardson
wrote:
> The polarity procedure no longer applies the settings to change the
> output signal because it can't be called when the pwm is enabled anyway.
> The polarity is only updated in the control register. The correct
> polarity will be appli
On Fri, Apr 10, 2015 at 11:58 AM, Jonathan Richardson
wrote:
> The polarity procedure no longer applies the settings to change the
> output signal because it can't be called when the pwm is enabled anyway.
> The polarity is only updated in the control register. The correct
> polarity will be appl
On Mon, Mar 9, 2015 at 8:05 AM, Alan Cox wrote:
> Ah no - I meant what is their official software workaround for existing
> parts with the bug ? Presumably they have an errata document that
> discusses this and the correct methods they recommend to avoid the
> hang ?
As far as I know, the only a
On Mon, Mar 9, 2015 at 6:32 AM, Alan Cox wrote:
>> Maybe the next release of the board we will upgrade the serial block to the
>> new version.
>> but the issue is that how we circumvent this problem in kernel?
>
> What is the official vendor workaround ?
They introduced a UART_16550_COMPATIBLE o
You only hit the silicon bug if you bombard the uart with characters
and simultaneously request a baud rate or framing change.
I'm not sure why you would do either to the uart console. Is it
possible your host machine is doing something weird?
If you have the leverage, remind the SoC vendor to u
Nvidia boards
caused by 5222161 mmc: sdhci: Improve external VDD regulator support.
Signed-off-by: Tim Kryger
Tested-by: Bjorn Andersson
---
drivers/mmc/host/sdhci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index ada1a3e..59a328a
On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote:
> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote:
>
>> I'm somewhat puzzled to what benefit 52221610d brings after bringing
>> back the write of BIT(0). Is it just that we don't hit the BUG() on
>> n
On Mon, Jan 12, 2015 at 2:31 AM, Ulf Hansson wrote:
> On 5 January 2015 at 20:52, Bjorn Andersson wrote:
>> On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote:
>>> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote:
>> [..]
>>>> Non-the-less, feel free t
On Mon, Jan 5, 2015 at 11:52 AM, Bjorn Andersson wrote:
> On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote:
>> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote:
> [..]
>>> Non-the-less, feel free to propose a patch and I will give it a test.
>>
>> Le
On Sun, Jan 4, 2015 at 5:12 PM, Tim Kryger wrote:
> On Tue, Dec 30, 2014 at 2:43 PM, Jonathan Richardson
> wrote:
>> Setting the default polarity in probe to normal for all channels caused
>> the speaker pwm channel to click. The polarity does need to be set to
>> norma
Signed-off-by: Scott Branden
Signed-off-by: Tim Kryger
---
This is based on Arun's patch (originally posted by Scott)
https://lkml.org/lkml/2014/11/25/1019
I modified it to use the pwmchip_add_inversed function so the polarity
could be safely left at the power on default and updated the c
This series alters the PWM core to allow the registration of controllers
that begin with inversed polarity output. It also modifies the Broadcom
Kona driver to take advantage of this new call.
Arun Ramamurthy (1):
drivers: pwm: bcm-kona: Dont set polarity in probe
Tim Kryger (1):
drivers
Add a new function to register a PWM chip with channels that have their
initial polarity as inversed. This benefits drivers of controllers that
by default operate with inversed polarity by removing the need to modify
the polarity during initialization.
Signed-off-by: Tim Kryger
---
drivers/pwm
On Tue, Dec 30, 2014 at 2:43 PM, Jonathan Richardson
wrote:
> Setting the default polarity in probe to normal for all channels caused
> the speaker pwm channel to click. The polarity does need to be set to
> normal because the hw default is inversed whereas the pwm framework
> defaults to normal.
On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote:
> I'm somewhat puzzled to what benefit 52221610d brings after bringing
> back the write of BIT(0). Is it just that we don't hit the BUG() on
> non-standard voltages?
It is to allow the use of external regulators that are capable of
supplyi
On Wed, Dec 17, 2014 at 10:46 AM, Jonathan Richardson
wrote:
> The config procedure doesn't follow the spec which periodically results
> in failing to enable the output signal. This happens one in ten or
> twenty attempts. Following the spec and adding a 400ns delay in the
> approp
d to bit zero of that same
register. The driver should be updated to configure bit zero
appropriately even when an external regulator is used.
If you like, I can propose a patch or if you have one ready, I will be
happy to review yours.
Thanks,
Tim Kryger
--
To unsubscribe from this list: se
and trigger bit are both low, the output is constant high.
If you look at the PWM output on a scope you will see it go high for
400 ns during your disable even if the duty prior to the disable was
zero.
How are you testing your proposed changes?
Thanks,
Tim Kryger
--
To unsubscribe from this l
On Sat, Dec 13, 2014 at 11:22 PM, Bjorn Andersson wrote:
> On Tue, Nov 4, 2014 at 7:31 AM, Tim Kryger wrote:
>> On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot
>> wrote:
>>> Hi Tim, thanks for your reply!
>>>
>>> On 11/04/2014 02:28 PM, Tim Kryger wr
riod) but
> may get a non smooth transition. So it's important to follow the spec
> here. We don't want non-smooth transitions.
Please provide your rationale for requiring smooth transitions.
Thanks,
Tim Kryger
--
To unsubscribe from this list: send the line "unsubscribe lin
On Thu, Dec 4, 2014 at 1:43 PM, Ray Jui wrote:
> This adds basic and generic support for various iProc PLLs and clocks
> including the ARMPLL, GENPLL, LCPLL, MIPIPLL, and ASIU clocks.
>
> SoCs under the iProc architecture can define their specific register
> offsets and clock parameters for their
On Mon, Dec 1, 2014 at 11:37 AM, Arun Ramamurthy
wrote:
>
>
> On 14-11-28 06:30 PM, Tim Kryger wrote:
>>
>> On Fri, Nov 28, 2014 at 3:49 PM, Arun Ramamurthy
>> wrote:
>>>
>>>
>>>
>>> On 14-11-25 11:29 PM, Tim Kryger wrote:
On Fri, Nov 28, 2014 at 5:19 PM, Arun Ramamurthy
wrote:
>
>
> On 14-11-28 05:08 PM, Tim Kryger wrote:
>>
>> On Fri, Nov 28, 2014 at 3:47 PM, Arun Ramamurthy
>> wrote:
>>>
>>>
>>>
>>> On 14-11-25 09:51 PM, Tim Kryger wrote:
On Fri, Nov 28, 2014 at 3:49 PM, Arun Ramamurthy
wrote:
>
>
> On 14-11-25 11:29 PM, Tim Kryger wrote:
>>
>> On Tue, Nov 25, 2014 at 11:40 AM, Scott Branden
>> wrote:
>>>
>>> From: Arun Ramamurthy
>>>
>>> - Added helper functions to
On Fri, Nov 28, 2014 at 3:48 PM, Arun Ramamurthy
wrote:
>
>
> On 14-11-25 10:22 PM, Tim Kryger wrote:
>>
>> On Tue, Nov 25, 2014 at 11:40 AM, Scott Branden
>> wrote:
>>>
>>> From: Arun Ramamurthy
>>>
>>> The pwm core code requ
On Fri, Nov 28, 2014 at 3:47 PM, Arun Ramamurthy
wrote:
>
>
> On 14-11-25 09:51 PM, Tim Kryger wrote:
>>
>> On Tue, Nov 25, 2014 at 11:40 AM, Scott Branden
>> wrote:
>>>
>>> From: Arun Ramamurthy
>>>
>>> The probe routine unnec
On Tue, Nov 25, 2014 at 11:40 AM, Scott Branden wrote:
> From: Arun Ramamurthy
>
> - Added helper functions to set and clear smooth and trigger bits
> - Added 400ns delays when clearing and setting trigger bit as requied
> by spec
> - Added helper function to write prescale and other settings
>
On Tue, Nov 25, 2014 at 11:40 AM, Scott Branden wrote:
> From: Arun Ramamurthy
>
> The pwm core code requires a separate call for enabling the channel
> and hence the driver does not need to set pwm_trigger after a
> polarity change
The framework does restrict when polarity changes can occur but
On Tue, Nov 25, 2014 at 11:40 AM, Scott Branden wrote:
> From: Arun Ramamurthy
>
> The probe routine unnecessarily sets the smooth type and polarity for
> all channels. This causes the channel for the speaker to click at the same
> time the backlight turns on. The smooth type and polarity should
On Wed, Nov 5, 2014 at 12:10 AM, Alexandre Courbot wrote:
> On 11/05/2014 12:31 AM, Tim Kryger wrote:
>>
>> On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot
>> wrote:
>>>
>>> Hi Tim, thanks for your reply!
>>>
>>> On 11/04/2014 02:28 PM,
On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot wrote:
> Hi Tim, thanks for your reply!
>
> On 11/04/2014 02:28 PM, Tim Kryger wrote:
>>
>> On Mon, Nov 3, 2014 at 7:05 PM, Alexandre Courbot
>> wrote:
>>>
>>> Hi guys,
>>>
>>> On
patch you proposed would break Exynos4210 so I don't think it is
appropriate.
Do you understand why this code block is executed on your hardware? I
wouldn't expect it.
Can you provide the relevant parts of the log before the problem occurs?
Thanks,
Tim Kryger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, Aug 15, 2014 at 3:29 PM, Mark Brown wrote:
> On Fri, Aug 15, 2014 at 07:19:41AM -0700, Tim Kryger wrote:
>
>> That is a little different from my suggestion where the constraints
>> check is skipped when the regulator output is fixed. It effectively
>> does thi
On Fri, Aug 15, 2014 at 12:48 AM, Javier Martinez Canillas
wrote:
> Hello Tim,
>
> On 08/15/2014 07:36 AM, Tim Kryger wrote:
>> On Thu, Aug 14, 2014 at 8:19 AM, Mark Brown wrote:
>>
>>> Right, there's two things going on here. One is that as you describe we
&
e its voltage?
It seems odd to make callers be the ones to handle this subtlety.
Thanks,
Tim Kryger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Thu, Aug 14, 2014 at 5:39 AM, Javier Martinez Canillas
wrote:
> The operation conditions register (OCR) stores the voltage
> profile of the card, however the list of possible voltages
> is restricted by the voltage range supported by the supply
> used as VCC/VDD. So in mmc_vddrange_to_ocrmask()
There is no need for regulator consumers to include special logic for
fixed voltage regulators as they support regulator_set_voltage() just
like their non-fixed regulator counterparts.
Signed-off-by: Tim Kryger
---
Changes in v2:
- Remove query of the current voltage, just set the desired
There is no need for regulator consumers to include special logic for
fixed voltage regulators as they support regulator_set_voltage() just
like their non-fixed regulator counterparts.
Signed-off-by: Tim Kryger
---
Since this eliminates logic that was concealing a bug in how the SDHCI
driver
There is no need for regulator consumers to include special logic for
fixed voltage regulators as they support regulator_set_voltage() just
like their non-fixed regulator counterparts.
Signed-off-by: Tim Kryger
---
Since this eliminates logic that was concealing a bug in how the SDHCI
driver
ff-by: Tim Kryger
Tested-by: Sachin Kamat
---
This change corrects a regression observed on Exynos platforms that was
triggered by "mmc: sdhci: Use mmc core regulator infrastucture"
https://www.mail-archive.com/linux-mmc@vger.kernel.org/msg27101.html
drivers/mmc/host/sdhci.c | 16
On Mon, Jun 2, 2014 at 5:50 AM, Mark Brown wrote:
> On Mon, Jun 02, 2014 at 12:12:20AM -0700, Tim Kryger wrote:
>
>> The probe method of this driver, on the other hand, performs several
>> allocations and the error messages you intend to remove conveniently
>> pinpoint
The probe method of this driver, on the other hand, performs several
allocations and the error messages you intend to remove conveniently
pinpoint which one failed. While the offsets in the trace could be
used to derive the same information, I am skeptical that is enough to
justify removing the messages.
Thanks,
Tim Kryger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, Apr 25, 2014 at 1:15 AM, Ulf Hansson wrote:
> On 25 April 2014 00:36, Tim Kryger wrote:
>> Switch the common SDHCI code over to use mmc_host's regulator pointers
>> and remove the ones in the sdhci_host structure. Additionally, use the
>> common mmc_regulator_
On Tue, May 6, 2014 at 3:57 PM, Tim Kryger wrote:
> Callers of mmc_regulator_get_supply could benefit from knowing if either
> of the regulators are present but not yet available. Since callers do
> not currently examine the return value, modify this function to return
> zero or -EPR
callers check vmmc/vqmmc using IS_ERR and can deal
with absent regulators, switch to devm_regulator_get_optional. This has
the added benefit of allowing this function to behave correctly even in
the !CONFIG_REGULATOR case such that the stub can be removed.
Signed-off-by: Tim Kryger
---
drivers
On Fri, Apr 25, 2014 at 2:33 PM, Andrew Bresticker
wrote:
>>
>> - if (IS_ERR(supply))
>> - return PTR_ERR(supply);
>> + if (IS_ERR(mmc->supply.vmmc)) {
>> + if (PTR_ERR(mmc->supply.vmmc) == -EPROBE_DEFER)
>> + return -EPROBE_DEFER;
>> +
On Mon, Apr 28, 2014 at 4:07 AM, Thierry Reding
wrote:
> On Fri, Apr 25, 2014 at 11:31:10AM -0700, Tim Kryger wrote:
>> This series introduces the driver for the Kona PWM controller found in
>> Broadcom mobile SoCs like bcm281xx and updates the device tree and the
>> defco
eturn value and may continue to use IS_ERR on the vmmc/vqmmc values to
determine if those regulators are available. Furthermore, since all of
these callers are capable of dealing with absent regulators, switch over
to use the non-optional variety of the regulator get call.
Signed-off-by: Tim K
Add the device tree node for the PWM on bcm11351 SoCs.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
arch/arm/boot/dts/bcm11351.dtsi |8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351
Mark the PWM as enabled on the bcm28155 AP board.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
arch/arm/boot/dts/bcm28155-ap.dts |4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/bcm28155-ap.dts
b/arch/arm/boot/dts/bcm28155-ap.dts
Add the binding description for the Kona PWM controller found on Broadcom's
mobile SoCs.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
.../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21
1 file changed, 21 insertions(+)
c
Enable PWM drivers and the PWM-based backlight driver.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
arch/arm/configs/bcm_defconfig |3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
index
Add support for the six-channel Kona PWM controller found on Broadcom
mobile SoCs like bcm281xx.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
drivers/pwm/Kconfig|9 ++
drivers/pwm/Makefile |1 +
drivers/pwm/pwm-bcm-kona.c | 319
cient
- Made prescale and duty computation clearer
- Moved Makefile addition to keep alphabetical
- Split complex lines into multiple steps
Tim Kryger (5):
Documentation: dt: Add Kona PWM binding
pwm: kona: Introduce Kona PWM controller support
ARM: dts: Declare the PWM for bcm11351 (bcm
ltage ranges
supported which ensures ocr_avail is set correctly while allowing the
use of regulators that can't provide exactly 1.8v, 3.0v, or 3.3v.
Signed-off-by: Tim Kryger
---
This patch is the same as the following series only squashed together.
https://lkml.org/lkml/2014/4/17/653
d
On Thu, Apr 24, 2014 at 1:34 AM, Ulf Hansson wrote:
> On 18 April 2014 02:46, Tim Kryger wrote:
>> This series updates SDHCI to use the common regulator infrastructure that mmc
>> core provides.
>>
>> Tim Kryger (2):
>> mmc: sdhci: Use supplies in common mmc
but when that
can't be set, 1.8v and 1.2v signalling also should be attempted. This
is especially important when an external regulator with a limited range
is used to supply VCCQ to an eMMC part.
Signed-off-by: Tim Kryger
---
Changes since v1:
- Eliminated temporary err variable and added
On Thu, Apr 24, 2014 at 1:38 AM, Ulf Hansson wrote:
> On 18 April 2014 20:58, Tim Kryger wrote:
>> void mmc_power_up(struct mmc_host *host, u32 ocr)
>> {
>> + int err;
>> +
>
> The variable err is not needed, since we don't plan on printing it
On Fri, Apr 18, 2014 at 11:52 AM, Mark Brown wrote:
> On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote:
>> If a regulator consumer requests a voltage range that can be satisfied,
>> the return value should indicate success even if that regulator has a
>> fixed vol
On Wed, Apr 16, 2014 at 12:20 AM, Ulf Hansson wrote:
> On 15 April 2014 19:09, Tim Kryger wrote:
>> On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote:
>>> A few times I have suggested to switch to use the
>>> mmc_regulator_get_supply() API to simplify and cons
On Fri, Apr 18, 2014 at 11:52 AM, Mark Brown wrote:
> On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote:
>> If a regulator consumer requests a voltage range that can be satisfied,
>> the return value should indicate success even if that regulator has a
>> fixed vol
but when that
can't be set, 1.8v and 1.2v signalling also should be attempted. This
is especially important when an external regulator with a limited range
is used to supply VCCQ to an eMMC part.
Signed-off-by: Tim Kryger
---
drivers/mmc/core/core.c | 10 +-
1 file changed, 9 inser
with constraints that include a positive voltage.
Signed-off-by: Tim Kryger
---
drivers/regulator/of_regulator.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index ea4f36f..a205d62 100644
--- a/drivers
cient
- Made prescale and duty computation clearer
- Moved Makefile addition to keep alphabetical
- Split complex lines into multiple steps
Tim Kryger (5):
Documentation: dt: Add Kona PWM binding
pwm: kona: Introduce Kona PWM controller support
ARM: dts: Declare the PWM for bcm11351 (bcm
Add support for the six-channel Kona PWM controller found on Broadcom
mobile SoCs like bcm281xx.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
drivers/pwm/Kconfig|9 ++
drivers/pwm/Makefile |1 +
drivers/pwm/pwm-bcm-kona.c | 319
Enable PWM drivers and the PWM-based backlight driver.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
arch/arm/configs/bcm_defconfig |3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
index
Add the binding description for the Kona PWM controller found on Broadcom's
mobile SoCs.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
.../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21
1 file changed, 21 insertions(+)
c
Add the device tree node for the PWM on bcm11351 SoCs.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
arch/arm/boot/dts/bcm11351.dtsi |8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351
Mark the PWM as enabled on the bcm28155 AP board.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
arch/arm/boot/dts/bcm28155-ap.dts |4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/bcm28155-ap.dts
b/arch/arm/boot/dts/bcm28155-ap.dts
Switch the common SDHCI code over to use mmc_host's regulator pointers
and remove the ones in the sdhci_host structure.
Signed-off-by: Tim Kryger
---
drivers/mmc/host/sdhci.c | 71 -
include/linux/mmc/sdhci.h |3 --
2 files change
This series updates SDHCI to use the common regulator infrastructure that mmc
core provides.
Tim Kryger (2):
mmc: sdhci: Use supplies in common mmc_host struct
mmc: sdhci: Use common mmc_regulator_get_supply
drivers/mmc/host/sdhci.c | 96
dress this by relaxing the range checks in the SDHCI driver but it
set the capabilities as an intermediate step which meant ocr_avail could
get bits set for unsupported voltages.
Signed-off-by: Tim Kryger
---
drivers/mmc/host/sdhci.c | 67 +-
1 file ch
eturn value and may continue to use IS_ERR on the vmmc/vqmmc values to
determine if those regulators are available. Furthermore, since all of
these callers are capable of dealing with absent regulators, switch over
to use the non-optional variety of the regulator get call.
Signed-off-by: Tim K
call regulator_is_supported_voltage. This improves efficiency as well
as eliminates the possibility for a very subtle bug.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
---
This change was proposed here: https://lkml.org/lkml/2014/4/16/627
include/linux/regulator/consumer.h |4 ++--
1
On Mon, Apr 14, 2014 at 6:42 PM, Andrew Bresticker
wrote:
> If regulator_get_optional() returns EPROBE_DEFER, it indicates
> that the regulator may show up later (e.g. the DT property is
> present but the corresponding regulator may not have probed).
> Instead of continuing without the regulator,
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote:
> I have seen some patches around lately touching the code for handling
> the regulators (vcc and vccq) in sdhci.
Was it this patch you were thinking of or something else?
http://www.spinics.net/lists/linux-mmc/msg25640.html
> A few times I h
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote:
> On 11 April 2014 01:31, Tim Kryger wrote:
>> +static unsigned int sdhci_get_ocr_avail_from_vmmc(struct sdhci_host *host)
>> +{
>> + unsigned int ocr_avail = 0;
>> + struct regulator *vmmc = hos
If a consumer of a GPIO-based IRQ identifies itself as wanting to
have the capability to wake up the system through that interrupt,
update the flags to keep that interrupt enabled in suspend.
Signed-off-by: Tim Kryger
---
drivers/gpio/gpio-bcm-kona.c | 19 +++
1 file changed
ed
to relax the range checks but because it relied on setting capabilities
as an intermediate step, ocr_avail could easily get a bit set that the
host couldn't support.
Signed-off-by: Tim Kryger
---
drivers/mmc/host/sdhci.c | 107 +-
1 file c
Fix the macro used to define linear range regulators to include the
number of voltages.
Signed-off-by: Tim Kryger
---
drivers/regulator/bcm590xx-regulator.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/bcm590xx-regulator.c
b/drivers/regulator/bcm590xx-regulator.c
//lkml.org/lkml/2014/2/14/451
Tim Kryger (5):
Documentation: dt: Add Kona PWM binding
pwm: kona: Introduce Kona PWM controller support
ARM: dts: Declare the PWM for bcm11351 (bcm281xx)
ARM: dts: Enable the PWM for bcm28155 AP board
ARM: bcm_defconfig: Enable PWM and Backlight
.../de
Add the device tree node for the PWM on bcm11351 SoCs.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
arch/arm/boot/dts/bcm11351.dtsi |8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351
Add the binding description for the Kona PWM controller found on Broadcom's
mobile SoCs.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
.../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21
1 file changed, 21 insertions(+)
c
Mark the PWM as enabled on the bcm28155 AP board.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
arch/arm/boot/dts/bcm28155-ap.dts |4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/bcm28155-ap.dts
b/arch/arm/boot/dts/bcm28155-ap.dts
Enable PWM drivers and the PWM-based backlight driver.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
arch/arm/configs/bcm_defconfig |3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
index
Add support for the six-channel Kona PWM controller found on Broadcom
mobile SoCs like bcm281xx.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
drivers/pwm/Kconfig|9 ++
drivers/pwm/Makefile |1 +
drivers/pwm/pwm-bcm-kona.c | 319
On Tue, Apr 8, 2014 at 6:27 PM, Stephen Warren wrote:
> On 04/08/2014 05:02 PM, Tim Kryger wrote:
>> On Thu, Apr 3, 2014 at 6:44 AM, Bart Tanghe
>> wrote:
>>> need some recommendation
>>> the memory mapped io registers of the bcm2835 pwm hardware are sprea
On Thu, Apr 3, 2014 at 6:44 AM, Bart Tanghe wrote:
> need some recommendation
> the memory mapped io registers of the bcm2835 pwm hardware are spreaded
> over the memory mapped io
> gpio config 0x2024 - clk config 0x201010A0 - pwm configuration 0x2020C000
> to handle this, I've used the base a
On Mon, Apr 7, 2014 at 10:02 PM, Lothar Waßmann
wrote:
> Thierry Reding wrote:
>> No. You cannot emulate polarity inversion in software.
>>
> Why not?
>
> duty_ns = period_ns - duty_ns;
Since I made the same mistake, I will pass along the pointer Thierry gave me.
In include/linux/pwm.h the sec
On Thu, Apr 3, 2014 at 7:18 PM, Alex Elder wrote:
> diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
> new file mode 100644
> index 000..46a64f2
> --- /dev/null
> +++ b/arch/arm/mach-bcm/platsmp.c
> +/* Size of mapped Cortex A9 SCU address space */
> +#define SCU_SIZE
Mark the PWM as enabled on the bcm28155 AP board.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
arch/arm/boot/dts/bcm28155-ap.dts |4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/bcm28155-ap.dts
b/arch/arm/boot/dts/bcm28155-ap.dts
Add the binding description for the Kona PWM controller found on Broadcom's
mobile SoCs.
Signed-off-by: Tim Kryger
Reviewed-by: Alex Elder
Reviewed-by: Markus Mayer
---
.../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21
1 file changed, 21 insertions(+)
c
1 - 100 of 248 matches
Mail list logo
