Hi Masami,
On Wed, 2024-05-29 at 08:38 +0900, Masami Hiramatsu wrote:
> On Wed, 29 May 2024 01:46:40 +0900
> Masami Hiramatsu (Google) wrote:
>
> > On Mon, 27 May 2024 19:29:07 -0400
> > Steven Rostedt wrote:
> >
> > > On Sun, 26 May 2024 19:10:57 +0900
> > > "Masami Hiramatsu (Google)" wrote
p *map, void *key,
> bool lookup_only)
> }
>
> memcpy(elt->key, key, map->key_size);
> - entry->val = elt;
> + /*
> + * Ensure the initialization is visible and
> + * publish the elt.
> + */
> + smp_wmb();
> + WRITE_ONCE(entry->val, elt);
> atomic64_inc(&map->hits);
>
> return entry->val;
>
> base-commit: 9d1694dc91ce7b80bc96d6d8eaf1a1eca668d847
Makes sense, thanks for fixing this!
Acked-by: Tom Zanussi
Tom
4.109-rt55 by applying the incremental patch:
https://www.kernel.org/pub/linux/kernel/projects/rt/5.4/incr/patch-5.4.109-rt55-rt56.patch.xz
Enjoy!
Tom
Changes from v5.4.109-rt55:
---
Sebastian Andrzej Siewior (1):
mm: slub: Don't resize the location tracking cache on PREEMPT_RT
T
Hello RT Folks!
I'm pleased to announce the 5.4.109-rt55 stable release.
This release is just an update to the new stable 5.4.109
version and no RT specific changes have been made.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.g
From: Tom Zanussi
Hi,
This is v2 of the IDXD pmu support patch, which is the same as v1 but
removes a few assigned-but-unused variables reported by kernel test
robot .
Thanks,
Tom
-- original v1 text --
Hi,
This patchset implements initial pmu support for the Intel DSA (Data
Streaming
ation.html
[ Based on work originally by Jing Lin. ]
Reviewed-by: Dave Jiang
Reviewed-by: Kan Liang
Signed-off-by: Tom Zanussi
---
drivers/dma/Kconfig | 13 +
drivers/dma/idxd/Makefile| 2 +
drivers/dma/idxd/idxd.h | 45 +++
drivers/dma/idxd/init.c | 9 +
drivers/dma/idx
ation.html
[ Based on work originally by Jing Lin. ]
Reviewed-by: Dave Jiang
Reviewed-by: Kan Liang
Signed-off-by: Tom Zanussi
---
drivers/dma/Kconfig | 13 +
drivers/dma/idxd/Makefile| 2 +
drivers/dma/idxd/idxd.h | 45 +++
drivers/dma/idxd/init.c | 9 +
drivers/dma/idx
rator-preliminary-architecture-specification.html
Tom Zanussi (1):
dmaengine: idxd: Add IDXD performance monitor support
drivers/dma/Kconfig | 13 +
drivers/dma/idxd/Makefile| 2 +
drivers/dma/idxd/idxd.h | 45 +++
drivers/dma/idxd/init.c | 9 +
drivers/dma/idxd/irq.c
Hello RT Folks!
I'm pleased to announce the 4.19.182-rt74 stable release.
This release is just an update to the new stable 4.19.182
version and no RT specific changes have been made.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt
e/trace.c| 38 +-
> kernel/trace/trace.h| 9 +--
> kernel/trace/trace_events_hist.c| 100 +-
> kernel/trace/trace_events_trigger.c | 45 +++-
> 7 files changed, 239 insertions(+), 99 deletions(-)
This all looks fine to me.
Reviewed-by: Tom Zanussi
Hello RT Folks!
I'm pleased to announce the 4.19.180-rt73 stable release.
This release is just an update to the new stable 4.19.180
version and no RT specific changes have been made.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt
On Thu, 2021-02-11 at 16:21 -0500, Steven Rostedt wrote:
> On Fri, 12 Feb 2021 07:57:28 +1100
> Stephen Rothwell wrote:
>
> > Hi all,
> >
> > In commit
> >
> > b5e7014fe1c4 ("selftests/ftrace: Update synthetic event syntax
> > errors")
> >
> > Fixes tag
> >
> > Fixes: 81ff92a93d95 (selfte
Hi Steve,
On Tue, 2021-02-09 at 16:09 -0500, Steven Rostedt wrote:
> On Mon, 1 Feb 2021 13:48:10 -0600
> Tom Zanussi wrote:
>
> > Hi,
> >
> > This is v7 of the synthetic event error fix patchset. This version
> > addresses the comments from v6:
> >
>
Hello RT Folks!
I'm pleased to announce the 4.19.173-rt72 stable release.
This release is just an update to the new stable 4.19.173
version and no RT specific changes have been made.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt
Add a check confirming that '!event' alone will remove a synthetic
event.
Signed-off-by: Tom Zanussi
---
.../trigger/inter-event/trigger-synthetic-event-syntax.tc | 4
1 file changed, 4 insertions(+)
diff --git
a/tools/testing/selftests/ftrace/test.d/trigger/inter-eve
for synthetic
event syntax errors)
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
.../trigger-synthetic_event_syntax_errors.tc | 35 ++-
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git
a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger
CMD_INCOMPLETE, which is removed, and
remove CMD_TOO_LONG, since it's no longer used.
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/
ftrace/synth-fixes-v7
Masami Hiramatsu (1):
tracing/dynevent: Delegate parsing to create function
Tom Zanussi (5):
tracing: Rework synthetic event command parsing
tracing: Update synth command errors
tracing: Add a backward-compatibility check for synthetic event
creation
self
modifications ]
Signed-off-by: Tom Zanussi
---
kernel/trace/trace.c | 23 ++--
kernel/trace/trace.h | 3 +-
kernel/trace/trace_dynevent.c | 35 +++---
kernel/trace/trace_dynevent.h | 4 +--
kernel/trace/trace_events_synth.c | 60
et of semicolon-separated fields.
Since we're also now passed the raw command, we can also save it
directly and can get rid of save_cmdstr().
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 245 +-
1 file changed, 143 insertions(+), 102 deletion
() comment from rost...@goodmis.org ]
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 93 ---
1 file changed, 74 insertions(+), 19 deletions(-)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/trace/trace_events_synth.c
index aace72426e99
Hi Steve,
On Fri, 2021-01-22 at 16:12 -0500, Steven Rostedt wrote:
> On Thu, 21 Jan 2021 11:01:07 -0600
> Tom Zanussi wrote:
> > --- a/kernel/trace/trace_events_synth.c
> > +++ b/kernel/trace/trace_events_synth.c
> > @@ -580,11 +580,18 @@ static void free_synth_fiel
Hi Steve,
On Fri, 2021-01-22 at 16:00 -0500, Steven Rostedt wrote:
> On Thu, 21 Jan 2021 11:01:05 -0600
> Tom Zanussi wrote:
>
> > @@ -1208,13 +1173,14 @@ static int __create_synth_event(int argc,
> > const char *name, const char **argv)
> > * wher
On Fri, 2021-01-22 at 22:23 +0900, Masami Hiramatsu wrote:
> Hi Tom,
>
> On Thu, 21 Jan 2021 11:01:06 -0600
> Tom Zanussi wrote:
>
> > Since array types are handled differently, errors referencing them
> > also need to be handled differently. Add and use a new
&
On Fri, 2021-01-22 at 22:16 +0900, Masami Hiramatsu wrote:
> On Thu, 21 Jan 2021 11:01:05 -0600
> Tom Zanussi wrote:
>
> > Now that command parsing has been delegated to the create functions
> > and we're no longer constrained by argv_split(), we can modify the
> >
mmit f6a694665f132cbf6edd2f173dc35330a8aa:
tracing: Offload eval map updates to a work queue (2020-12-15 09:29:14 -0500)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git
ftrace/synth-fixes-v6
Masami Hiramatsu (1):
tracing/dynev
et of semicolon-separated fields.
Since we're also now passed the raw command, we can also save it
directly and can get rid of save_cmdstr().
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 198 +++---
1 file changed, 98 insertions(+), 100 deletion
CMD_INCOMPLETE, which is removed, and
remove CMD_TOO_LONG, since it's no longer used.
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 72 +++
1 file changed, 63 insertions(+), 9 deletions(-)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/
features are added, the requirement will be
that any field/string containing the new feature must use semicolons,
and the check_field_version() check can then check for those and
enforce it. Using a version number allows this scheme to be extended
if necessary.
Signed-off-by: Tom Zanussi
---
kernel
Add a check confirming that '!event' alone will remove a synthetic
event.
Signed-off-by: Tom Zanussi
---
.../trigger/inter-event/trigger-synthetic-event-syntax.tc | 4
1 file changed, 4 insertions(+)
diff --git
a/tools/testing/selftests/ftrace/test.d/trigger/inter-eve
for synthetic
event syntax errors)
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
.../trigger-synthetic_event_syntax_errors.tc | 35 ++-
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git
a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger
modifications ]
Signed-off-by: Tom Zanussi
---
kernel/trace/trace.c | 23 ++--
kernel/trace/trace.h | 3 +-
kernel/trace/trace_dynevent.c | 35 +++---
kernel/trace/trace_dynevent.h | 4 +--
kernel/trace/trace_events_synth.c | 60
Hello RT Folks!
I'm pleased to announce the 4.19.165-rt70 stable release.
This release is just an update to the new stable 4.19.165
version and no RT specific changes have been made.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt
Hi Masami,
On Tue, 2020-12-22 at 21:42 +0900, Masami Hiramatsu wrote:
> Hi Tom,
>
> On Mon, 21 Dec 2020 15:44:28 -0600
> Tom Zanussi wrote:
>
>
> > @@ -656,7 +651,6 @@ static struct synth_field
> > *parse_synth_field(int argc, const char **argv,
> >
&
modifications ]
Signed-off-by: Tom Zanussi
---
kernel/trace/trace.c | 23 ++--
kernel/trace/trace.h | 3 +-
kernel/trace/trace_dynevent.c | 35 +++---
kernel/trace/trace_dynevent.h | 4 +--
kernel/trace/trace_events_synth.c | 60
for synthetic
event syntax errors)
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
.../trigger-synthetic_event_syntax_errors.tc | 35 ++-
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git
a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger
et of semicolon-separated fields.
Since we're also now passed the raw command, we can also save it
directly and can get rid of save_cmdstr().
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 184 +++---
1 file changed, 90 insertions(+), 94 deletion
CMD_INCOMPLETE, which is removed, and
remove CMD_TOO_LONG, since it's no longer used.
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 71 +++
1 file changed, 63 insertions(+), 8 deletions(-)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/
string.
[ zanussi: Added missing variable initializations reported by Dan
Carpenter and kernel test robot
]
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 292 --
1 file changed, 272 insertions(+), 20 deletions(-)
diff --git a/kernel/trace
cing: Offload eval map updates to a work queue (2020-12-15 09:29:14 -0500)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git
ftrace/synth-fixes-v5
Masami Hiramatsu (1):
tracing/dynevent: Delegate parsing to create function
for synthetic
event syntax errors)
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
.../trigger-synthetic_event_syntax_errors.tc | 35 ++-
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git
a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger
modifications ]
Signed-off-by: Tom Zanussi
---
kernel/trace/trace.c | 23 ++--
kernel/trace/trace.h | 3 +-
kernel/trace/trace_dynevent.c | 35 +++---
kernel/trace/trace_dynevent.h | 4 +--
kernel/trace/trace_events_synth.c | 60
string.
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 294 --
1 file changed, 274 insertions(+), 20 deletions(-)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/trace/trace_events_synth.c
index 2a9c8bf74bb2..6bff54ed31ce 100644
--- a/kernel
CMD_INCOMPLETE, which is removed, and
remove CMD_TOO_LONG, since it's no longer used.
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 71 +++
1 file changed, 63 insertions(+), 8 deletions(-)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/
et of semicolon-separated fields.
Since we're also now passed the raw command, we can also save it
directly and can get rid of save_cmdstr().
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 184 +++---
1 file changed, 90 insertions(+), 94 deletion
synth-fixes-v4
Masami Hiramatsu (1):
tracing/dynevent: Delegate parsing to create function
Tom Zanussi (4):
tracing: Rework synthetic event command parsing
tracing: Update synth command errors
tracing: Add a backward-compatibility check for synthetic event
creation
selftests/ftrace: U
Hi Steve,
On Tue, 2020-12-08 at 12:53 -0500, Steven Rostedt wrote:
> On Tue, 08 Dec 2020 11:34:41 -0600
> Tom Zanussi wrote:
>
> > Unfortunately, you're correct, if you have a script that creates a
> > synthetic event without semicolons, this patchset will break it,
Hi Steve,
On Mon, 2020-12-07 at 19:16 -0500, Steven Rostedt wrote:
> On Mon, 26 Oct 2020 10:06:10 -0500
> Tom Zanussi wrote:
>
> > Now that command parsing has been delegated to the create functions
> > and we're no longer constrained by argv_split(), we can modi
Hi Steve,
On Mon, 2020-12-07 at 20:13 -0500, Steven Rostedt wrote:
> On Mon, 26 Oct 2020 10:06:11 -0500
> Tom Zanussi wrote:
>
> > Since array types are handled differently, errors referencing them
> > also need to be handled differently. Add and use a new
> > INVA
Hello RT Folks!
I'm pleased to announce the 4.19.160-rt69 stable release.
This release is just an update to the new stable 4.19.160
version and no RT specific changes have been made.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt
Hi Steve, Daniel,
On Tue, 2020-11-24 at 11:37 -0500, Steven Rostedt wrote:
> Hi Tom,
>
> Daniel asked about filtering bitmasks, something like:
>
>cpumask != 0xff
>
> Looking into the code, I realized that bitmasks are dynamic arrays,
> and
> there's no logic in the filter code to handle dy
drzej Siewior (1):
mm/memcontrol: Disable preemption in __mod_memcg_lruvec_state()
Tom Zanussi (1):
Linux 4.19.152-rt66
---
include/linux/memcontrol.h | 2 ++
kernel/ptrace.c| 23 +++
localversion-rt| 2 +-
3 files changed, 18 insertions(
On Sat, 2020-11-14 at 20:00 +0100, Mike Galbraith wrote:
> On Fri, 2020-11-13 at 14:14 -0600, Tom Zanussi wrote:
> >
> > This patch seems to fix it for me:
>
> If there was any discussion about this patch, I missed it.
There wasn't, just
Hi Steve,
On Fri, 2020-11-13 at 11:06 -0600, Tom Zanussi wrote:
> Hi Steve,
>
> On Tue, 2020-11-10 at 10:38 -0500, Steven Rostedt wrote:
> > 5.4.74-rt42-rc2 stable review patch.
> > If anyone has any objections, please let me know.
> >
> > --
Hi Steve,
On Tue, 2020-11-10 at 10:38 -0500, Steven Rostedt wrote:
> 5.4.74-rt42-rc2 stable review patch.
> If anyone has any objections, please let me know.
>
> --
>
> From: Sebastian Andrzej Siewior
>
> In patch
>("net/Qdisc: use a seqlock instead seqcount")
>
> the seqc
his patch is a mechanical substitution:
> s/synth_trace_state/synth_event_trace_state/g
>
> Signed-off-by: Artem Bityutskiy
Thanks for fixing this!
Reviewed-by: Tom Zanussi
> ---
> Documentation/trace/events.rst | 10 +-
> 1 file changed, 5 insertions(+), 5 delet
Hello RT Folks!
I'm pleased to announce the 4.19.152-rt65 stable release.
This release is just an update to the new stable 4.19.152
version and no RT specific changes have been made.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt
ffer from being
> overwritten if what is being written is bigger than the buffer.
>
> Fixes: 10819e25799a ("tracing: Handle synthetic event array field
> type checking correctly")
> Signed-off-by: Steven Rostedt (VMware)
> ---
>
> Changes since v1, Dan's
modifications ]
Signed-off-by: Tom Zanussi
---
kernel/trace/trace.c | 23 ++--
kernel/trace/trace.h | 3 +-
kernel/trace/trace_dynevent.c | 35 +++---
kernel/trace/trace_dynevent.h | 4 +--
kernel/trace/trace_events_synth.c | 60
for synthetic
event syntax errors)
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
.../trigger-synthetic_event_syntax_errors.tc | 35 ++-
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git
a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger
These tests omit field separators from the synthetic event definitions
so don't follow the syntax ' field[;field] ...' required
for synthetic events.
Fixes: f06eec4d0f2c (selftests: ftrace: Add inter-event hist triggers testcases)
Signed-off-by: Tom Zanussi
---
.../trigger/inte
CMD_INCOMPLETE, which is removed, and
remove CMD_TOO_LONG, since it's no longer used.
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 68 +++
1 file changed, 59 insertions(+), 9 deletions(-)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/
et of semicolon-separated fields.
Since we're also now passed the raw command, we can also save it
directly and can get rid of save_cmdstr().
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 181 ++
1 file changed, 83 insertions(+), 98 deletion
Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git
ftrace/synth-fixes-v3
Masami Hiramatsu (1):
tracing/dynevent: Delegate parsing to create function
Tom Zanussi (4):
tracing: Rework synthetic event command parsing
tracing: Update synth command error
CMD_INCOMPLETE, which is removed, and
remove CMD_TOO_LONG, since it's no longer used.
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 66 +++
1 file changed, 58 insertions(+), 8 deletions(-)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/
These tests omit field separators from the synthetic event definitions
so don't follow the syntax ' field[;field] ...' required
for synthetic events.
Fixes: f06eec4d0f2c (selftests: ftrace: Add inter-event hist triggers testcases)
Signed-off-by: Tom Zanussi
---
.../trigger/inte
for synthetic
event syntax errors)
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
.../trigger-synthetic_event_syntax_errors.tc | 36 ++-
1 file changed, 28 insertions(+), 8 deletions(-)
diff --git
a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger
t/zanussi/linux-trace.git
ftrace/synth-fixes-v2
Masami Hiramatsu (1):
tracing/dynevent: Delegate parsing to create function
Tom Zanussi (3):
tracing: Update synth command errors
selftests/ftrace: Add synthetic event field separators
selftests/ftrace: Update synthetic event syntax errors
From: Masami Hiramatsu
Delegate command parsing to each create function so that the
command syntax can be customized.
Signed-off-by: Masami Hiramatsu
[ zanu...@kernel.org: added synthetic event modifications ]
Signed-off-by: Tom Zanussi
---
kernel/trace/trace.c | 23
Hi Masami,
On Mon, 2020-10-19 at 00:15 +0900, Masami Hiramatsu wrote:
> Hi Tom,
>
> On Sun, 18 Oct 2020 23:20:11 +0900
> Masami Hiramatsu wrote:
>
> > Hi Tom,
> >
> > On Fri, 16 Oct 2020 16:48:22 -0500
> > Tom Zanussi wrote:
> >
> > > t
;t
always possible.
Signed-off-by: Tom Zanussi
---
kernel/trace/trace.c | 41 +--
kernel/trace/trace.h | 12 ++---
kernel/trace/trace_dynevent.c | 4 +--
kernel/trace/trace_events_synth.c | 5 ++--
kernel/trace/trace_kprobe.
for synthetic
event syntax errors)
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
.../trigger-synthetic_event_syntax_errors.tc| 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git
a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger
tr(), which can also
be removed.
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 65 ---
1 file changed, 8 insertions(+), 57 deletions(-)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/trace/trace_events_synth.c
index e6659bb9a500..2333
ff-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/trace/trace_events_synth.c
index 2333025ef31e..f48964bdd66e 100644
--- a/kernel/trace/trace_events_synth.c
+++ b/kernel/
linux-trace.git
ftrace/synth-fixes-v1
Tom Zanussi (4):
tracing: Make trace_*_run_command() more flexible
tracing: Use new trace_run_command() options
tracing: Update synth command errors
selftests/ftrace: Update synthetic event syntax errors
kernel/trace/trace.c
Hi Masami,
On Wed, 2020-10-14 at 11:06 +0900, Masami Hiramatsu wrote:
> Hi Tom,
>
> On Tue, 13 Oct 2020 09:17:58 -0500
> Tom Zanussi wrote:
>
> > Add a selftest that verifies that the syntax error messages and
> > caret
> > positions are correct for mos
ff ff ff eb bb 0f 1f 80 00 00 00 00 f3 0f
> 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48>
> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24
>
> This was caused by accessing the hlist_data fields after the call to
> __create_val_fields() w
fmt: "str=%s, v=%d", REC->str, REC->v
[ : wrote parse_synth_field() snippet. ]
Fixes: 4b147936fa50 (tracing: Add support for 'synthetic' events)
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 12 +---
Add a selftest that verifies that the syntax error messages and caret
positions are correct for most of the possible synthetic event syntax
error cases.
Signed-off-by: Tom Zanussi
---
.../trigger-synthetic_event_syntax_errors.tc | 19 +++
1 file changed, 19 insertions
is_good_name() is useful for other trace infrastructure, such as
synthetic events, so make it available via trace.h.
Acked-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
kernel/trace/trace.h | 13 +
kernel/trace/trace_probe.h | 13 -
2 files changed, 13
Add support for synthetic event error logging, which entails adding a
logging function for it, a way to save the synthetic event command,
and a set of specific synthetic event parse error strings and
handling.
[ : wrote save_cmdstr() seq_buf implementation. ]
Signed-off-by: Tom Zanussi
_str() (2020-10-08
15:29:07 -0400)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git
ftrace/dynstring-fixes-v3
Tom Zanussi (7):
tracing: Don't show dynamic string internals in synthetic event
description
tracing: Move
ne to define an event field, which printing it would lead
them to believe.
So filter it out from the description, while leaving it in the type.
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 10 +-
1 file changed, 9 insertions(+), 1 de
matsu
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/trace/trace_events_synth.c
index b19e2f4159ab..8c9d6e464d
nt this.
Fixes: f06eec4d0f2c (selftests: ftrace: Add inter-event hist triggers testcases)
Acked-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
.../inter-event/trigger-inter-event-combined-hist.tc | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/tools/testing/selftest
Hi Steve,
On Mon, 2020-10-12 at 18:14 -0400, Steven Rostedt wrote:
> On Mon, 12 Oct 2020 15:18:08 -0500
> Tom Zanussi wrote:
>
> > @@ -630,8 +630,11 @@ static struct synth_field
> > *parse_synth_field(int argc, const char **argv,
> > if (field_type[0] ==
Hi Steve,
On Mon, 2020-10-12 at 18:04 -0400, Steven Rostedt wrote:
> On Mon, 12 Oct 2020 15:18:06 -0500
> Tom Zanussi wrote:
>
> > +static int cmdstr_append(char *buf, const char *str, int
> > *remaining)
> > +{
> > + int len = strlen(str);
> &
Hi Steve,
On Mon, 2020-10-12 at 17:49 -0400, Steven Rostedt wrote:
> On Mon, 12 Oct 2020 17:42:40 -0400
> Steven Rostedt wrote:
>
> > On Mon, 12 Oct 2020 15:18:06 -0500
> > Tom Zanussi wrote:
> >
> > > +static char last_cmd[MAX_FILTER_STR_VAL];
> > &g
matsu
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/kernel/trace/trace_events_synth.c
b/kernel/trace/trace_events_synth.c
index b19e2f4159ab..8c9d6e464d
int fmt: "str=%s, v=%d", REC->str, REC->v
Fixes: 4b147936fa50 (tracing: Add support for 'synthetic' events)
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --gi
is_good_name() is useful for other trace infrastructure, such as
synthetic events, so make it available via trace.h.
Acked-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
kernel/trace/trace.h | 13 +
kernel/trace/trace_probe.h | 13 -
2 files changed, 13
ne to define an event field, which printing it would lead
them to believe.
So filter it out from the description, while leaving it in the type.
Reported-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 10 +-
1 file changed, 9 insertions(+), 1 de
nt this.
Fixes: f06eec4d0f2c (selftests: ftrace: Add inter-event hist triggers testcases)
Acked-by: Masami Hiramatsu
Signed-off-by: Tom Zanussi
---
.../inter-event/trigger-inter-event-combined-hist.tc | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/tools/testing/selftest
Add support for synthetic event error logging, which entails adding a
logging function for it, a way to save the synthetic event command,
and a set of specific synthetic event parse error strings and
handling.
Signed-off-by: Tom Zanussi
---
kernel/trace/trace_events_synth.c | 114
Add a selftest that verifies that the syntax error messages and caret
positions are correct for most of the possible synthetic event syntax
error cases.
Signed-off-by: Tom Zanussi
---
.../trigger-synthetic_event_syntax_errors.tc | 19 +++
1 file changed, 19 insertions
se of __get_str() (2020-10-08
15:29:07 -0400)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git
ftrace/dynstring-fixes-v2
Tom Zanussi (7):
tracing: Don't show dynamic string internals in synthetic event
description
tracin
Hi Steve,
On Mon, 2020-10-12 at 11:13 -0400, Steven Rostedt wrote:
> On Fri, 9 Oct 2020 10:17:06 -0500
> Tom Zanussi wrote:
>
> > These patches provide fixes for the problems observed by Masami in
> > the
> > new synthetic event dynamic string patchset.
> >
&g
Hi Masami,
On Sun, 2020-10-11 at 00:03 +0900, Masami Hiramatsu wrote:
> Hi Tom,
>
> On Fri, 9 Oct 2020 10:17:07 -0500
> Tom Zanussi wrote:
>
> > For synthetic event dynamic fields, the type contains "__data_loc",
> > which is basically an internal part o
Hi Masami,
On Sat, 2020-10-10 at 23:57 +0900, Masami Hiramatsu wrote:
> On Fri, 9 Oct 2020 10:17:10 -0500
> Tom Zanussi wrote:
>
> > Add support for synthetic event error logging, which entails adding
> > a
> > logging function for it, a way to save the synthetic e
Hi Steve,
Looks ok to me.
Acked-by: Tom Zanussi
Thanks,
Tom
On Mon, 2020-10-12 at 10:15 -0400, Steven Rostedt wrote:
> Tom,
>
> Can you ack this patch for me?
>
> -- Steve
>
>
> On Fri, 9 Oct 2020 15:05:23 -0700
> Axel Rasmussen wrote:
>
> >
1 - 100 of 1151 matches
Mail list logo