Re: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions

2016-09-20 Thread Jarkko Sakkinen
> > > Sent: Monday, September 19, 2016 23:22 > > > > To: Peter Huewe > > > > Cc: moderated list:TPM DEVICE DRIVER > > > de...@lists.sourceforge.net>; open list > > > > > > > > Subject: [tpmdd-devel] [PATCH 2/2] tpm: fix bad const

RE: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions

2016-09-20 Thread Winkler, Tomas
> > Cc: moderated list:TPM DEVICE DRIVER > > de...@lists.sourceforge.net>; open list > > > > > > Subject: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions > > > > > > Sparse reports "bad constant expression" for the use of cpu_to_be

Re: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions

2016-09-20 Thread Jarkko Sakkinen
ated list:TPM DEVICE DRIVER > de...@lists.sourceforge.net>; open list > > Subject: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions > > > > Sparse reports "bad constant expression" for the use of cpu_to_be32 inside > > enums tpm_capabilities and tpm_sub_capabilities

RE: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions

2016-09-20 Thread Winkler, Tomas
> -Original Message- > From: Jarkko Sakkinen [mailto:jarkko.sakki...@linux.intel.com] > Sent: Monday, September 19, 2016 23:22 > To: Peter Huewe > Cc: moderated list:TPM DEVICE DRIVER de...@lists.sourceforge.net>; open list > Subject: [tpmdd-devel] [PATCH 2/2]

[PATCH 2/2] tpm: fix bad constant expressions

2016-09-19 Thread Jarkko Sakkinen
Sparse reports "bad constant expression" for the use of cpu_to_be32 inside enums tpm_capabilities and tpm_sub_capabilities. Even though it is probably expanded to a constant expression, it is probably cleaner not to use it there. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.