Re: [PATCH v2] lib/hexdump update on feedback

2007-05-04 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Rename hex_dumper() to hex_dump_to_buffer(). Rename hextoasc() macro to hex_asc() [remove conflicts with sky/skfp/skge drivers]. Change output format to remove '-' in middle of ASCII output and add space between hex and ASCII output. Signed-o

Re: [PATCH v2] lib/hexdump

2007-05-04 Thread Hugh Dickins
On Thu, 3 May 2007, Randy Dunlap wrote: > > Example output using %DUMP_PREFIX_OFFSET: > 0009ab42: 40414243 44454647 48494a4b [EMAIL PROTECTED] HIJKLMNO ^^ > Example output using %DUMP_PREFIX_ADDRESS: > 88089af0: 70717273 74757677 78797

Re: [PATCH v2] lib/hexdump

2007-05-04 Thread Pekka Enberg
Hi Randy, On 5/4/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: +extern void hex_dumper(void *buf, size_t len, char *linebuf, size_t linebuflen); Please do s/hex_dumper/hex_dump_to_buffer/ for consistency with print_hex_dump. - To unsubscribe from this list: send the line "unsubscribe linux-kern

[PATCH v2] lib/hexdump

2007-05-03 Thread Randy Dunlap
> > Ho hum. Perhaps a middle ground is to implement hexdump-to-memory as the > > core function. hex_dumper() becomes a simple wrapper around that. (but > > how big is its buffer? One line would be OK, I guess) > > Yeah, I almost did it that way. We'll see. > > > > OK, that's one way to do i