Re: [PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-09-20 Thread Paul Walmsley
Hi On Wed, 22 Aug 2012, Omar Ramirez Luna wrote: > For a reset sequence to complete cleanly, a module needs its > associated clocks to be enabled, otherwise the timeout check > in prcm code can print a false failure (failed to hardreset) > that occurs because the clocks aren't powered ON and the

Re: [PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-09-20 Thread Paul Walmsley
Hi On Wed, 22 Aug 2012, Omar Ramirez Luna wrote: For a reset sequence to complete cleanly, a module needs its associated clocks to be enabled, otherwise the timeout check in prcm code can print a false failure (failed to hardreset) that occurs because the clocks aren't powered ON and the

Re: [PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-09-10 Thread Omar Ramirez Luna
Hi Benoit, On 6 September 2012 10:12, Benoit Cousson wrote: > The sequence is good, I'm just a little bit concern about the > duplication of code compared to _enable sequence. > > That being said, this is the consequence of removing the hardreset > sequence outside of the main _enable/_shutdown

Re: [PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-09-10 Thread Omar Ramirez Luna
Hi Benoit, On 6 September 2012 10:12, Benoit Cousson b-cous...@ti.com wrote: The sequence is good, I'm just a little bit concern about the duplication of code compared to _enable sequence. That being said, this is the consequence of removing the hardreset sequence outside of the main

Re: [PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-09-06 Thread Benoit Cousson
Hi Omar, On 08/22/2012 07:42 AM, Omar Ramirez Luna wrote: > For a reset sequence to complete cleanly, a module needs its > associated clocks to be enabled, otherwise the timeout check > in prcm code can print a false failure (failed to hardreset) > that occurs because the clocks aren't powered ON

Re: [PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-09-06 Thread Benoit Cousson
Hi Omar, On 08/22/2012 07:42 AM, Omar Ramirez Luna wrote: For a reset sequence to complete cleanly, a module needs its associated clocks to be enabled, otherwise the timeout check in prcm code can print a false failure (failed to hardreset) that occurs because the clocks aren't powered ON and

[PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-08-21 Thread Omar Ramirez Luna
For a reset sequence to complete cleanly, a module needs its associated clocks to be enabled, otherwise the timeout check in prcm code can print a false failure (failed to hardreset) that occurs because the clocks aren't powered ON and the status bit checked can't transition without them.

[PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-08-21 Thread Omar Ramirez Luna
For a reset sequence to complete cleanly, a module needs its associated clocks to be enabled, otherwise the timeout check in prcm code can print a false failure (failed to hardreset) that occurs because the clocks aren't powered ON and the status bit checked can't transition without them.