Re: [git patches] net driver updates

2008-02-25 Thread Jeff Garzik
Divy Le Ray wrote: So, it sounds like Krishna's patch is ok, because the race does not exist anymore in this driver? The first part is right indeed, but the second part is breaking the current usage of txq_stopped and the logic that stops and restarts the Tx queue. I can submit a patch fixi

Re: [git patches] net driver updates

2008-02-25 Thread Divy Le Ray
So, it sounds like Krishna's patch is ok, because the race does not exist anymore in this driver? The first part is right indeed, but the second part is breaking the current usage of txq_stopped and the logic that stops and restarts the Tx queue. I can submit a patch fixing it. Plese let me

Re: [git patches] net driver updates

2008-02-25 Thread Jeff Garzik
Marin Mitov wrote: On Tuesday 26 February 2008 12:59:04 am you wrote: Divy Le Ray wrote: From: "Divy Le Ray" <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 21:57:08 -0800 The driver is cxgb3 here, it uses LLTX. That's extremely unfortunate, hopefully you can update it to use a model like tg3 and

Re: [git patches] net driver updates

2008-02-25 Thread Marin Mitov
On Tuesday 26 February 2008 12:59:04 am you wrote: > Divy Le Ray wrote: > >> From: "Divy Le Ray" <[EMAIL PROTECTED]> > >> Date: Wed, 20 Feb 2008 21:57:08 -0800 > >> > >>> The driver is cxgb3 here, it uses LLTX. > >> > >> That's extremely unfortunate, hopefully you can update it to > >> use a model

Re: [git patches] net driver updates

2008-02-25 Thread Jeff Garzik
Divy Le Ray wrote: From: "Divy Le Ray" <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 21:57:08 -0800 The driver is cxgb3 here, it uses LLTX. That's extremely unfortunate, hopefully you can update it to use a model like tg3 and others use. LLTX is a lost cause for hardware device drivers, and in f

RE: [git patches] net driver updates

2008-02-20 Thread Divy Le Ray
> From: "Divy Le Ray" <[EMAIL PROTECTED]> > Date: Wed, 20 Feb 2008 21:57:08 -0800 > > > The driver is cxgb3 here, it uses LLTX. > > That's extremely unfortunate, hopefully you can update it to > use a model like tg3 and others use. LLTX is a lost cause > for hardware device drivers, and in fact

Re: [git patches] net driver updates

2008-02-20 Thread David Miller
From: "Divy Le Ray" <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 21:57:08 -0800 > The driver is cxgb3 here, it uses LLTX. That's extremely unfortunate, hopefully you can update it to use a model like tg3 and others use. LLTX is a lost cause for hardware device drivers, and in fact we'd like to rem

RE: [git patches] net driver updates

2008-02-20 Thread Krishna Kumar2
Hi Divy, But the race doesn't exist even for LLTX drivers these days. There is no way two cpu's can execute the xmit handler at the same time. Thanks, - KK > > > > The first part of the patch removes the !netif_queue_stopped(dev). > > > > It opens the race discussed a while ago between Stephen

RE: [git patches] net driver updates

2008-02-20 Thread Divy Le Ray
> -Original Message- > From: David Miller [mailto:[EMAIL PROTECTED] > Sent: Wednesday, February 20, 2008 9:47 PM > To: [EMAIL PROTECTED] > Cc: Divy Le Ray; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; > [EMAIL PROTECTED] > Subject: Re: [git patches] net dri

Re: [git patches] net driver updates

2008-02-20 Thread David Miller
From: Krishna Kumar2 <[EMAIL PROTECTED]> Date: Thu, 21 Feb 2008 09:13:49 +0530 > Hi Divy, > > > > Explain why, so I can include it in the changelog please... > > > > Hi Jeff, > > > > The first part of the patch removes the !netif_queue_stopped(dev). > > It opens the race discussed a while ago bet

Re: [git patches] net driver updates

2008-02-20 Thread Krishna Kumar2
Hi Divy, > > Explain why, so I can include it in the changelog please... > > Hi Jeff, > > The first part of the patch removes the !netif_queue_stopped(dev). > It opens the race discussed a while ago between Stephen hemminger and > David Miller: > http://marc.info/?l=linux-netdev&m=113383224512427&

Re: [git patches] net driver updates

2008-02-20 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: Jeff Garzik wrote: Mostly fixes, a few cleanups (generally assisting fixes), and an exception for PS3 wireless because it had been posted, reviewed and acked for a while, just not committed. Please pull from 'upstream-davem' branch of master.kernel.org:/pu

Re: [git patches] net driver updates

2008-02-20 Thread Jeff Garzik
Divy Le Ray wrote: Jeff Garzik wrote: Mostly fixes, a few cleanups (generally assisting fixes), and an exception for PS3 wireless because it had been posted, reviewed and acked for a while, just not committed. Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/g

Re: [git patches] net driver updates

2008-02-11 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 12:05:16 -0500 > Mostly fixes, a few cleanups (generally assisting fixes), and an > exception for PS3 wireless because it had been posted, reviewed and > acked for a while, just not committed. > > Please pull from 'upstream-davem' branch

Re: [git patches] net driver updates

2008-02-11 Thread Divy Le Ray
Jeff Garzik wrote: Mostly fixes, a few cleanups (generally assisting fixes), and an exception for PS3 wireless because it had been posted, reviewed and acked for a while, just not committed. Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.

Re: [git patches] net driver updates

2008-02-06 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 06:49:50 -0500 > Please pull from 'upstream-davem' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git > upstream-davem > > to receive the following updates: Pulled, thanks Jeff. -- To unsubscribe from this l

RE: [git patches] net driver updates #2

2008-02-05 Thread Pravin Nanaware
Hi, Can somebody point me where could I get the MMU(Memory management Unit) details ? Regards, Pravin -**Nihilent*** " *** All information contained in this communication is confidential, proprietary, privileged and is intended for the addressees only. If youhave rec

Re: [git patches] net driver updates #2

2008-02-03 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Fri, 01 Feb 2008 21:52:10 -0800 (PST) > From: Jeff Garzik <[EMAIL PROTECTED]> > Date: Fri, 1 Feb 2008 16:03:38 -0500 > > > Please pull from 'upstream2-davem' branch of > > This is now pulled and pushed back out to net-2.6 The first S2io patch breaks

Re: [git patches] net driver updates #2

2008-02-01 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 1 Feb 2008 16:03:38 -0500 > Please pull from 'upstream2-davem' branch of This is now pulled and pushed back out to net-2.6 Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTEC

Re: [git patches] net driver updates #2

2008-02-01 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 1 Feb 2008 16:03:38 -0500 > This submit is based on top of Linus's tree, since I'm not sure what's > going on with net-2.6.git and my previous (lost?) submission. > > These changes do /not/ include anything from the previous submission, > which was

Re: [git patches] net driver updates for 2.6.25

2008-01-18 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 18 Jan 2008 15:17:21 -0500 > > Please pull from the 'upstream' branch of > git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream > > to receive my 2.6.25 net driver queue into davem/net-2.6.25.git: Pulled and pushed back o

Re: [git patches] net driver updates

2007-10-09 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 9 Oct 2007 21:03:26 -0400 > > Please pull from the 'upstream-davem' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git > upstream-davem > > to receive these changes: Pulled and pushed back out, thanks Jeff! - To unsub

Re: [git patches] net driver updates

2007-10-07 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 5 Oct 2007 14:20:08 -0400 > Please pull from 'upstream-davem' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git > upstream-davem > Pulled, and pushed back out to net-2.6.24, thanks Jeff. - To unsubscribe from this lis

Re: [git patches] net driver updates

2007-10-03 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Wed, 3 Oct 2007 14:39:16 -0400 > > Normally I wait a day or two between pushes, to queue up patches and > also to avoid annoying my upstream :) But this includes a couple fixes > I felt should be upstreamed sooner rather than later. > > Please pull fr

Re: [git patches] net driver updates

2007-10-02 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 2 Oct 2007 13:41:50 -0400 > Please pull from the 'upstream' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream Pulled and pushed back out to net-2.6.24, thanks Jeff! - To unsubscribe from this list: send the lin

Re: [git patches] net driver updates

2007-09-20 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 03:26:10 -0400 > Please pull from the 'upstream' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream > > to receive the following changes: Pulled into net-2.6.24 and pushed out, thanks Jeff! - To uns

Re: [git patches] net driver updates

2007-07-11 Thread Chris Stromsoe
On Wed, 11 Jul 2007, Jiri Kosina wrote: On Tue, 10 Jul 2007, Jeff Garzik wrote: Various minor updates. The only thing of note is sk98lin driver removal. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus This is pro

Re: [git patches] net driver updates

2007-07-11 Thread Jiri Kosina
On Tue, 10 Jul 2007, Jeff Garzik wrote: > Various minor updates. The only thing of note is sk98lin driver removal. > Please pull from 'upstream-linus' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git > upstream-linus This is probably going to cause a new entry in r

Re: [git patches] net driver updates

2007-05-18 Thread Gene Heskett
On Friday 18 May 2007, Andrew Morton wrote: >On Fri, 18 May 2007 23:46:21 +0200 > >Mariusz Koz__owski <[EMAIL PROTECTED]> wrote: >> Hello, >> >> > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h >> > index 7053026..111f23d 100644 >> > --- a/drivers/net/smc91x.h >> > +++ b/drivers/net/smc91

Re: [git patches] net driver updates

2007-05-18 Thread Mariusz Kozlowski
> > > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h > > > index 7053026..111f23d 100644 > > > --- a/drivers/net/smc91x.h > > > +++ b/drivers/net/smc91x.h > > > @@ -279,6 +279,40 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg) > > > > ... > > > > > +#define SMC_outb(v, a, r) __ __

Re: [git patches] net driver updates

2007-05-18 Thread Andrew Morton
On Fri, 18 May 2007 23:46:21 +0200 Mariusz Koz__owski <[EMAIL PROTECTED]> wrote: > Hello, > > > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h > > index 7053026..111f23d 100644 > > --- a/drivers/net/smc91x.h > > +++ b/drivers/net/smc91x.h > > @@ -279,6 +279,40 @@ SMC_outw(u16 val, void

Re: [git patches] net driver updates

2007-05-18 Thread Mariusz Kozłowski
Hello, > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h > index 7053026..111f23d 100644 > --- a/drivers/net/smc91x.h > +++ b/drivers/net/smc91x.h > @@ -279,6 +279,40 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg) ... > +#define SMC_outb(v, a, r)      outw(((inw((a)+((r)&~1))*(0xf

Re: [git patches] net driver updates

2007-04-29 Thread Christoph Hellwig
On Sun, Apr 29, 2007 at 12:19:01PM -0400, Jeff Garzik wrote: > > (just sent this upstream to Linus and Andrew) > > The only really notable thing is the merging of the wireless driver for > the OLPC, libertas. I don't think it's quite ready yet, at least I've got no feedback about completion of t

Re: [git patches] net driver updates

2007-02-08 Thread Jeff Garzik
Junio C Hamano wrote: Jeff Garzik <[EMAIL PROTECTED]> writes: mode change 100644 => 100755 drivers/net/qla3xxx.c mode change 100644 => 100755 drivers/net/qla3xxx.h Did you mean to have these? Commit bd36b0ac appears to have brought the mode bits change in. Not trying to nitpick --- I am t

Re: [git patches] net driver updates

2007-02-07 Thread Junio C Hamano
Jeff Garzik <[EMAIL PROTECTED]> writes: > mode change 100644 => 100755 drivers/net/qla3xxx.c > mode change 100644 => 100755 drivers/net/qla3xxx.h Did you mean to have these? Commit bd36b0ac appears to have brought the mode bits change in. Not trying to nitpick --- I am trying to find out if t