Re: [PATCH 38/39] x86/mm/pti: Add Warning when booting on a PCID capable CPU

2018-07-13 Thread Joerg Roedel
On Fri, Jul 13, 2018 at 11:59:44AM -0700, Andy Lutomirski wrote: > On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > > > Warn the user in case the performance can be significantly > > improved by switching to a 64-bit kernel. > > ... > > > +#ifdef CONFIG_X86_32 >

Re: [PATCH 38/39] x86/mm/pti: Add Warning when booting on a PCID capable CPU

2018-07-13 Thread Joerg Roedel
On Fri, Jul 13, 2018 at 11:59:44AM -0700, Andy Lutomirski wrote: > On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > > > Warn the user in case the performance can be significantly > > improved by switching to a 64-bit kernel. > > ... > > > +#ifdef CONFIG_X86_32 >

Re: [PATCH 38/39] x86/mm/pti: Add Warning when booting on a PCID capable CPU

2018-07-13 Thread Andy Lutomirski
On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Warn the user in case the performance can be significantly > improved by switching to a 64-bit kernel. ... > +#ifdef CONFIG_X86_32 > + if (boot_cpu_has(X86_FEATURE_PCID)) { I'm a bit confused. Wouldn't the

Re: [PATCH 38/39] x86/mm/pti: Add Warning when booting on a PCID capable CPU

2018-07-13 Thread Andy Lutomirski
On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Warn the user in case the performance can be significantly > improved by switching to a 64-bit kernel. ... > +#ifdef CONFIG_X86_32 > + if (boot_cpu_has(X86_FEATURE_PCID)) { I'm a bit confused. Wouldn't the