Re: [PATCH REPOST] ARM: Fix regression in IXP4xx network drivers DMA masks.

2014-01-11 Thread Russell King - ARM Linux
On Mon, Jan 06, 2014 at 08:33:15PM +0100, Krzysztof Hałasa wrote: > Russell et al., > > anything wrong with this fix? Well, I don't understand why moving this code around fixes a problem. After all, if PCI is enabled, then presumably common-pci.c will always be built and run - it has to be for

Re: [PATCH REPOST] ARM: Fix regression in IXP4xx network drivers DMA masks.

2014-01-11 Thread Russell King - ARM Linux
On Mon, Jan 06, 2014 at 08:33:15PM +0100, Krzysztof Hałasa wrote: Russell et al., anything wrong with this fix? Well, I don't understand why moving this code around fixes a problem. After all, if PCI is enabled, then presumably common-pci.c will always be built and run - it has to be for the

Re: [PATCH REPOST] ARM: Fix regression in IXP4xx network drivers DMA masks.

2014-01-06 Thread Krzysztof Hałasa
Russell et al., anything wrong with this fix? the following patch is still needed with 3.13-rc6. Affected are non-PCI devices using coherent allocations. Without the patch: # ifconfig eth0 up net eth0: coherent DMA mask is unset ifconfig: SIOCSIFFLAGS: Cannot allocate memory IXP4xx: Fix DMA

Re: [PATCH REPOST] ARM: Fix regression in IXP4xx network drivers DMA masks.

2014-01-06 Thread Krzysztof Hałasa
Russell et al., anything wrong with this fix? the following patch is still needed with 3.13-rc6. Affected are non-PCI devices using coherent allocations. Without the patch: # ifconfig eth0 up net eth0: coherent DMA mask is unset ifconfig: SIOCSIFFLAGS: Cannot allocate memory IXP4xx: Fix DMA