Re: [RFC] Default child of a cgroup

2008-01-31 Thread Balbir Singh
| | > | |---[def_child] > | | | > | | | > | | |---- > | | | > > Note that user cannot create subdirectories under def_child with this > scheme! I am also not sure what impact this

Re: [RFC] Default child of a cgroup

2008-01-31 Thread Balbir Singh
ore levels? > Yes, Dhaval nad Vatsa are looking at removing that limitation. This discussion is a side-effect of the multi-hierarchy discussion/implementation. > Paul -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this

[PATCH powerpc] Fake NUMA emulation for PowerPC (Take 4)

2008-01-31 Thread Balbir Singh
node boundaries, we need to set the new node online. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- arch/powerpc/mm/numa.c | 66 ++--- 1 file changed, 63 insertions(+), 3 deletions(-) diff -puN arch/powerpc/mm/numa.c~fakenumappc arch/powerpc

Re: 2.6.24-mm1 Build Faliure on pgtable_32.c

2008-02-03 Thread Balbir Singh
m/pgtable_32.c:302: error: too few arguments to function `pmd_free' > > I have tested the patch for the build failure only. > > Signed-off-by: Kamalesh Babulal <[EMAIL PROTECTED]> Looks good to me, it seems like a conflict between origin.patch and add-mm-argument-to-pte-pmd-pud

Re: [PATCH] badness() dramatically overcounts memory

2008-02-04 Thread Balbir Singh
h is used as the basis by the OOM killer. I need to read/understand the code a bit more. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

Re: [BUG] regression from 2.6.24-rc8-mm1 and 2.6.24-mm1 kernel panic while bootup

2008-02-05 Thread Balbir Singh
with no node 3, num_online_nodes 1 in the bootlog. Kamalesh verified that the problem exists with both slub and slab. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: process hangs on do_exit when oom happens

2012-10-22 Thread Balbir Singh
On Tue, Oct 23, 2012 at 9:05 AM, Qiang Gao wrote: > information about the system is in the attach file "information.txt" > > I can not reproduce it in the upstream 3.6.0 kernel.. > > On Sat, Oct 20, 2012 at 12:04 AM, Michal Hocko wrote: >> On Wed 17-10-12 18:23:34, gaoqiang wrote: >>> I looked up

Re: process hangs on do_exit when oom happens

2012-10-23 Thread Balbir Singh
On Tue, Oct 23, 2012 at 3:45 PM, Michal Hocko wrote: > On Tue 23-10-12 18:10:33, Qiang Gao wrote: >> On Tue, Oct 23, 2012 at 5:50 PM, Michal Hocko wrote: >> > On Tue 23-10-12 15:18:48, Qiang Gao wrote: >> >> This process was moved to RT-priority queue when global oom-killer >> >> happened to boos

Re: [patch] sparc: fix build

2008-02-11 Thread Balbir Singh
ivers/net/e1000e/netdev.c:2459 (set (reg:DI 487 [ D.34076 ]) (mem/s/j:DI (plus:SI (reg/v/f:SI 11 %o3 [orig:492 adapter ] [492]) (reg:SI 7 %g7 [514])) [0 .stats.gprc+0 S8 A128])) 45 {*movdi_insn_sp32} (insn_list:REG_DEP_TRUE 65 (insn_list:REG_DEP_ANTI 32 (nil))) (exp

Re: 2.6.25-rc1: volanoMark 45% regression

2008-02-13 Thread Balbir Singh
e Oprofile output for the run? The exact commandline and .config being used would also help. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [git pull] x86 updates

2008-02-13 Thread Balbir Singh
Ingo, could you also please consider the KVM build fix at http://marc.info/?l=linux-kernel&m=120262794315024&w=2 which has been acked by Avi. I suspect this patch should be route through git-x86 since it affects arch/x86/Kconfig. Balbir PS: Modified cc's to reduce the noise. -- To unsubscribe fro

Re: [git pull] x86 updates

2008-02-14 Thread Balbir Singh
Avi Kivity wrote: > Ingo Molnar wrote: >> * Balbir Singh <[EMAIL PROTECTED]> wrote: >> >> >>> Ingo, could you also please consider the KVM build fix at >>> http://marc.info/?l=linux-kernel&m=120262794315024&w=2 which has been >>> acke

Re: [RFC][PATCH 1/7] CGroup API: Add cgroup.api control file

2008-02-16 Thread Balbir Singh
? -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: Kdump with signed images

2012-11-02 Thread Balbir Singh
://sourceware.org/glibc/wiki/FAQ - "Even statically linked programs need some shared libraries which is not acceptable for me. What can I do?" Probably, worth trying. Balbir Singh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Kdump with signed images

2012-11-02 Thread Balbir Singh
On Fri, Nov 2, 2012 at 8:06 PM, Vivek Goyal wrote: > On Fri, Nov 02, 2012 at 07:59:15PM +0530, Balbir Singh wrote: >> On Fri, Nov 2, 2012 at 6:53 PM, Vivek Goyal wrote: >> > On Thu, Nov 01, 2012 at 02:52:25PM +, Matthew Garrett wrote: >> >> On Thu, Nov 01, 2

Re: process hangs on do_exit when oom happens

2012-10-21 Thread Balbir Singh
On Mon, Oct 22, 2012 at 7:46 AM, Qiang Gao wrote: > I don't know whether the process will exit finally, bug this stack lasts > for hours, which is obviously unnormal. > The situation: we use a command calld "cglimit" to fork-and-exec the worker > process,and the "cglimit" will > set some limitat

Re: [patch v4] Soft limit rework

2013-06-04 Thread Balbir Singh
On Mon, Jun 3, 2013 at 3:48 PM, Michal Hocko wrote: > Hi, > > This is the fourth version of the patchset. > > Summary of versions: > The first version has been posted here: > http://permalink.gmane.org/gmane.linux.kernel.mm/97973 > (lkml wasn't CCed at the time so I cannot find it in lwn.net > ar

Re: [patch v4] Soft limit rework

2013-06-04 Thread Balbir Singh
is > active also for the targeted (aka limit) reclaim. > > Does this help? > Yes. What are the limitations of no-priority 0 reclaim? I'll also look at the patches Thanks, Balbir Singh. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH v14 0/6] LSM: Multiple concurrent LSMs

2013-07-31 Thread Balbir Singh
text identifies > the information it contains by LSM: > > smack='Pop'selinux='system_u:object_r:etc_r:s0' > > A security context without the LSM identifying lsm='' gets > passed through to all of the LSMs that use a security context. This > ma

Re: [PATCH 3/5] cgroup, memcg: move cgroup_event implementation to memcg

2013-08-05 Thread Balbir Singh
exist only on the hierarchy > with memcg attached to it. While this change is visible to userland, > it is unlikely to be noticeable as the file has never been meaningful > outside memcg. > Tejun, I think the framework was designed to be flexible. Do you see cgroup subsystems never u

Re: [PATCH v14 0/6] LSM: Multiple concurrent LSMs

2013-08-05 Thread Balbir Singh
On Thu, Aug 1, 2013 at 10:51 PM, Casey Schaufler wrote: > On 7/31/2013 7:48 PM, Balbir Singh wrote: >> On Thu, Jul 25, 2013 at 11:52 PM, Casey Schaufler >> wrote: >>> Subject: [PATCH v14 0/6] LSM: Multiple concurrent LSMs >>> >>> Version 14 of this p

Re: [PATCH 3/5] cgroup, memcg: move cgroup_event implementation to memcg

2013-08-06 Thread Balbir Singh
On Tue, Aug 6, 2013 at 7:39 PM, Tejun Heo wrote: > Hello, Balbir. > > On Tue, Aug 06, 2013 at 08:56:34AM +0530, Balbir Singh wrote: >> [off-topic] Has the unified hierarchy been agreed upon? I did not >> follow that thread > > I consider it agreed upon enough. There o

Re: 2.6.25-rc1: volanoMark 45% regression

2008-02-17 Thread Balbir Singh
n the system (are they running anything at the time of the benchmark)? Could you turn off CONFIG_FAIR_USER_SCHED and turn on CONFIG_FAIR_GROUP_SCHED. I am going to run some tests with 2.6.25-rc2 and Volanomark and see how that goes. -- Warm Regards, Balbir Singh Linux Tech

Re: 2.6.25-rc1: volanoMark 45% regression

2008-02-17 Thread Balbir Singh
Zhang, Yanmin wrote: > On Mon, 2008-02-18 at 10:26 +0530, Balbir Singh wrote: >> Zhang, Yanmin wrote: >>>>> Did you have >>>>> CONFIG_FAIR_USER_SCHED enabled in both cases? >>>> Yes. >>>> >>>> CONFIG_FAIR_GR

Re: [PATCH 1/3] memcgroup: fix and update documentation

2008-02-17 Thread Balbir Singh
Li Zefan wrote: > - remove trailing " Bytes"s in the demonstration > - remove section 4.4 (feature control_type has been removed) > - fix reference section > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> > Acked-by: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]>

Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()

2008-02-17 Thread Balbir Singh
h_entry_safe_reverse. Not sure why we can't bug on pc. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 3/3] memcgroup: return negative error code in mem_cgroup_create()

2008-02-17 Thread Balbir Singh
Li Zefan wrote: > Cgroup requires the subsystem to return negative error code on > error in the create method. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> > Acked-by: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Acked-by: Balbir Singh <[EMAIL PROTECTED]> --

Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()

2008-02-17 Thread Balbir Singh
iroyuki <[EMAIL PROTECTED]> >> pc is of type page_cgroup and we use list_for_each_entry_safe_reverse. Not >> sure >> why we can't bug on pc. > > pc is dereferenced before this VM_BUG_ON. > > YAMAMOTO Takashi > OK, so the VM_BUG_ON needs to move to an earlier loca

Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()

2008-02-17 Thread Balbir Singh
Li Zefan wrote: > Balbir Singh wrote: >> YAMAMOTO Takashi wrote: >>>> Li Zefan wrote: >>>>> No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should >>>>> be VM_BUG_ON(page). >>>>> >>>>> Sign

Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()

2008-02-18 Thread Balbir Singh
g mem_cgroup_isolate_pages(unsigned long > nr_to_scan, > if (scan >= nr_to_scan) > break; > page = pc->page; > - VM_BUG_ON(!pc); > > if (unlikely(!PageLRU(page))) > continue; T

Re: [RFC][PATCH 1/7] CGroup API: Add cgroup.api control file

2008-02-18 Thread Balbir Singh
Li Zefan wrote: > Paul Menage wrote: >> On Feb 16, 2008 2:07 AM, Balbir Singh <[EMAIL PROTECTED]> wrote: >>> Paul Menage wrote: >>> >>> Hi, Paul, >>> >>> Do we need to use a cgroup.api file? Why not keep up to date documentation >>

Re: sched-devel latencies

2008-02-18 Thread Balbir Singh
On Feb 18, 2008 4:31 PM, Dhaval Giani <[EMAIL PROTECTED]> wrote: > On Mon, Feb 18, 2008 at 04:19:33PM +0530, Dhaval Giani wrote: > > Hi Ingo, > > > > I am running the sched-devel tree (at HEAD > > 44e770a8750abc7e876076cda718b413bad9e654) and it is not looking good. > > > > I am running two "make -

Re: [RFC][PATCH 7/7] CGroup API: Update cpusets to use cgroup structured file API

2008-02-18 Thread Balbir Singh
* Balbir Singh <[EMAIL PROTECTED]> [2008-02-18 16:42:05]: > Li Zefan wrote: > > Paul Jackson wrote: > >> Ok ... this would (I suspect, just from code reading, no bytes were > >> harmed in actual testing of this) have a minor change to how white > >>

Re: [RFC][PATCH 7/7] CGroup API: Update cpusets to use cgroup structured file API

2008-02-18 Thread Balbir Singh
* Balbir Singh <[EMAIL PROTECTED]> [2008-02-18 17:23:42]: > Andreas Schwab wrote: > > Balbir Singh <[EMAIL PROTECTED]> writes: > > > >> @@ -238,7 +238,7 @@ rmdir() if there are no tasks. > >> The type of memory accounted by the cgroup can be limited

Regression with sched yield - 2.6.25-rc2-mm1

2008-02-18 Thread Balbir Singh
ee if I can debug it further. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-

Re: Regression with sched yield - 2.6.25-rc2-mm1

2008-02-18 Thread Balbir Singh
Peter Zijlstra wrote: > On Mon, 2008-02-18 at 17:47 +0530, Balbir Singh wrote: >> Hi, >> >> I was looking at the 45% regression reported by Yanmin, when while running >> the >> test, I ran into >> >> 1:mon> t >> [c000e7677da0] c0

Re: Regression with sched yield - 2.6.25-rc2-mm1

2008-02-18 Thread Balbir Singh
Peter Zijlstra wrote: > On Mon, 2008-02-18 at 20:18 +0530, Balbir Singh wrote: > >>> Humm, the check that should have avoided that is: >>> >>> /* >>> * Are we the only task in the tree? >>> */ >>>

[mm][PATCH 0/4] Add soft limits to the memory controller v2

2008-02-18 Thread Balbir Singh
-add-soft-limit-documentation.patch -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kerne

[mm] [PATCH 1/4] Modify resource counters to add soft limit support v2

2008-02-18 Thread Balbir Singh
Changelog v2 1. Remove memory controller specific comments from resource counters The resource counter member limit is split into soft and hard limits. The same locking rule apply for both limits. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/res_counter.h

[mm] [PATCH 4/4] Add soft limit documentation v2

2008-02-18 Thread Balbir Singh
Add documentation for the soft limit feature. Changelog v2 (Thanks to the review by Randy Dunlap) 1. Change several misuses of it's to its 2. Fix spelling errors and punctuation Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- Documentation/controllers/memory

[mm] [PATCH 2/4] Add the soft limit interface v2

2008-02-18 Thread Balbir Singh
cgroup is removed from the list when the cgroup is deleted. The global list is protected with a read-write spinlock. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- mm/memcontrol.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff -

[mm] [PATCH 3/4] Reclaim from groups over their soft limit under memory pressure v2

2008-02-18 Thread Balbir Singh
-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/memcontrol.h |9 + include/linux/res_counter.h | 11 ++ include/linux/swap.h|4 +- mm/memcontrol.c | 76 mm/page_alloc.c | 10 + mm

Re: [mm] [PATCH 2/4] Add the soft limit interface v2

2008-02-19 Thread Balbir Singh
Li Zefan wrote: > Li Zefan 写道: >> Balbir Singh wrote: >>> A new configuration file called soft_limit_in_bytes is added. The parsing >>> and configuration rules remain the same as for the limit_in_bytes user >>> interface. >>> >>> A glob

Re: [mm] [PATCH 2/4] Add the soft limit interface v2

2008-02-19 Thread Balbir Singh
Li Zefan wrote: > Li Zefan 写道: >> Balbir Singh wrote: >>> A new configuration file called soft_limit_in_bytes is added. The parsing >>> and configuration rules remain the same as for the limit_in_bytes user >>> interface. >>> >>> A glob

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Balbir Singh
che misses because struct page on many 64bit > + systems will not fit into a single cache line anymore. > + > + Only enable when you're ok with these trade offs and really > + sure you need the memory controller. > + Looks good Acked-by: Balbir Singh &l

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Balbir Singh
ences, specially reference [1] contains a lot of details on limits, guarantees, etc. Since they've been documented in the past on lkml, I decided to keep them out of the documentation and mention them as references. If it's going to help to add that terminology; I can create another doc

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Balbir Singh
John Stoffel wrote: >>>>>> "Jan" == Jan Engelhardt <[EMAIL PROTECTED]> writes: > > Jan> On Feb 20 2008 20:50, Balbir Singh wrote: >>> John Stoffel wrote: >>>> I know this is a pedantic comment, but why the heck is it called such &

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Balbir Singh
Nick Piggin wrote: > On Wednesday 20 February 2008 23:52, Balbir Singh wrote: >> Andi Kleen wrote: >>> Document huge memory/cache overhead of memory controller in Kconfig >>> >>> I was a little surprised that 2.6.25-rc* increased struct page for the >>>

Make yield_task_fair more efficient

2008-02-20 Thread Balbir Singh
nmin (http://lkml.org/lkml/2008/2/13/128) Comments? Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- kernel/sched.c |7 +++ kernel/sched_fair.c | 30 +++--- 2 files changed, 26 insertions(+), 11 deletions(-) diff -puN kernel/sched.c~make-sched-yield-fai

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Balbir Singh
ry models. I'd say it will be the fastest way to get a prototype > > running. > OK, I'll explore and prototype the radix tree based approach and see how that goes. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To u

Re: Make yield_task_fair more efficient

2008-02-20 Thread Balbir Singh
Ingo Molnar wrote: > * Balbir Singh <[EMAIL PROTECTED]> wrote: > >> __pick_last_entity() walks the entire tree on O(lgn) time to find the >> rightmost entry. This patch makes the routine more efficient by >> reducing the cost of the lookup > > hm, i&#x

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Balbir Singh
KAMEZAWA Hiroyuki wrote: > On Wed, 20 Feb 2008 21:45:13 +0530 > Balbir Singh <[EMAIL PROTECTED]> wrote: > >>> But for computers, limits is an expected and understood term, and for >>> filesystems it's quotas. So in this case, I *still* think you shou

Re: Make yield_task_fair more efficient

2008-02-20 Thread Balbir Singh
Ingo Molnar wrote: > * Balbir Singh <[EMAIL PROTECTED]> wrote: > >> I disagree. The cost is only adding a field to cfs_rq [...] > > wrong. The cost is "only" of adding a field to cfs_rq and _updating it_, > in the hottest paths of the scheduler:

Re: Make yield_task_fair more efficient

2008-02-21 Thread Balbir Singh
Peter Zijlstra wrote: > On Thu, 2008-02-21 at 13:09 +0530, Balbir Singh wrote: > >> sched_yield() is supported API > > For SCHED_FIFO/SCHED_RR. > >> and also look at http://lkml.org/lkml/2007/9/19/351. > > Read on (http://lkml.org/lkml/2007/9/19/371) a

Re: Make yield_task_fair more efficient

2008-02-21 Thread Balbir Singh
Ingo Molnar wrote: > * Balbir Singh <[EMAIL PROTECTED]> wrote: > >> If you insist that sched_yield() is bad, I might agree, but how does >> my patch make things worse. [...] > > it puts new instructions into the hotpath. > >> [...] In my benchmarks, it

Re: Make yield_task_fair more efficient

2008-02-21 Thread Balbir Singh
Ingo Molnar wrote: > * Balbir Singh <[EMAIL PROTECTED]> wrote: > You did not answer some of my earlier questions. >> I have an alternate approach in mind (that I need to find time for), >> threaded-rbtrees. Walking the tree is really efficient, specially >&g

Re: Make yield_task_fair more efficient

2008-02-21 Thread Balbir Singh
Peter Zijlstra wrote: > On Thu, 2008-02-21 at 15:01 +0530, Balbir Singh wrote: > >> I have an alternate approach in mind (that I need to find time for), >> threaded-rbtrees. Walking the tree is really efficient, specially finding >> successor of a node. > > Threa

Re: Make yield_task_fair more efficient

2008-02-21 Thread Balbir Singh
Peter Zijlstra wrote: > On Thu, 2008-02-21 at 15:12 +0530, Balbir Singh wrote: >> Peter Zijlstra wrote: >>> On Thu, 2008-02-21 at 15:01 +0530, Balbir Singh wrote: >>> >>>> I have an alternate approach in mind (that I need to find time for), >>&g

Re: [RFC][PATCH] the proposal of improve page reclaim by throttle

2008-02-21 Thread Balbir Singh
hrottled checks for zone_watermark_ok(), that will not work in the case that we are reclaiming from a cgroup which over it's limit. We need a different check, to see if the mem_cgroup is still over it's limit or not. -- Warm Regards, Balbir Singh Linux Technology

Re: Make yield_task_fair more efficient

2008-02-21 Thread Balbir Singh
Balbir Singh wrote: > Ingo Molnar wrote: >> * Balbir Singh <[EMAIL PROTECTED]> wrote: >> >>> If you insist that sched_yield() is bad, I might agree, but how does >>> my patch make things worse. [...] >> it puts new instructions into the hotpath. >

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-21 Thread Balbir Singh
Andi Kleen wrote: > Nick Piggin wrote: >> On Wednesday 20 February 2008 23:52, Balbir Singh wrote: >>> Andi Kleen wrote: >>>> Document huge memory/cache overhead of memory controller in Kconfig >>>> >>>> I was a little surprised that 2.6.25-rc

Re: [RFC][PATCH] the proposal of improve page reclaim by throttle

2008-02-21 Thread Balbir Singh
group so much. > What do i use function, instead? One option could be that once the memory controller has this feature, we'll need no changes in try_to_free_mem_cgroup_pages. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Make yield_task_fair more efficient

2008-02-21 Thread Balbir Singh
Peter Zijlstra wrote: > On Thu, 2008-02-21 at 15:37 +0530, Balbir Singh wrote: > >> You use the empty pointer (missing right child), so why do we need a list. >> May >> be I am missing something. > > A fully threaded tree also has back-pointer to traverse b

Re: Make yield_task_fair more efficient

2008-02-21 Thread Balbir Singh
Mike Galbraith wrote: > Hi, > > On Thu, 2008-02-21 at 15:01 +0530, Balbir Singh wrote: >> Ingo Molnar wrote: >>> * Balbir Singh <[EMAIL PROTECTED]> wrote: >>> >>>> If you insist that sched_yield() is bad, I might agree, but how does >

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-21 Thread Balbir Singh
with cgroups > + depends on CGROUPS > + > +config CGROUP_MEM_CONT > + bool "Memory controller for cgroups" > + depends on CGROUPS && RESOURCE_COUNTERS > + help > + Provides a memory controller that manages both page cache and > +

Re: Make yield_task_fair more efficient

2008-02-21 Thread Balbir Singh
Jens Axboe wrote: > On Thu, Feb 21 2008, Jens Axboe wrote: >> On Thu, Feb 21 2008, Peter Zijlstra wrote: >>> On Thu, 2008-02-21 at 15:37 +0530, Balbir Singh wrote: >>> >>>> You use the empty pointer (missing right child), so why do we need a list. >>

Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller

2008-02-21 Thread Balbir Singh
nt(), can we make it u64(). Integers are 32 bit on both ILP32 and LP64, but we really read/write 64 bit values. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-21 Thread Balbir Singh
c chunk is not node aware, if all the pages come from the same node, we have a penalty to pay in a NUMA system. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-21 Thread Balbir Singh
KAMEZAWA Hiroyuki wrote: > On Thu, 21 Feb 2008 16:33:33 +0530 > Balbir Singh <[EMAIL PROTECTED]> wrote: > >>> Another issue is that it will slightly increase TLB/cache >>> cost of the memory controller, but I think that would be a fair >>> trade of

Remove duplicate code from sched_fair.c

2008-02-22 Thread Balbir Singh
cates existing code. This functionality can be easily obtained using rb_last(). Avoid code duplication by using rb_last() Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- kernel/sched_fair.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff -puN kernel/sched

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-22 Thread Balbir Singh
Andi Kleen wrote: > Balbir Singh wrote: >> Andi Kleen wrote: >>>> 1. We could create something similar to mem_map, we would need to handle 4 >>> 4? At least x86 mainline only has two ways now. flatmem and vmemmap. >>> >>>> different ways of creat

Re: [PATCH] badness() dramatically overcounts memory

2008-02-05 Thread Balbir Singh
better.. Do we have a per zone RSS per task? I don't remember seeing it. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

KVM is not seen under X86 config with latest git (32 bit compile)

2008-02-09 Thread Balbir Singh
The KVM configuration is no longer visible in the latest git tree. It looks like it is selected by HAVE_SETUP_PER_CPU_AREA. I've moved HAVE_KVM to under CONFIG_X86. Hopefully, this is the right fix. Comments? Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- arch/x86/Kconfig |

Re: [PATCH] make KVM selectable again

2008-02-10 Thread Balbir Singh
On Feb 10, 2008 2:29 AM, Dave Hansen <[EMAIL PROTECTED]> wrote: > Current git for me (b1d0e4f535e10775cffde922208b49629169aeaa) doesn't > let me build KVM. In fact, I don't seem to have *ANY* kvm-related > symbols in my .config at all. > > I've verified that arch/x86/kvm/Kconfig was getting run by

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-22 Thread Balbir Singh
Andi Kleen wrote: > On Fri, Feb 22, 2008 at 05:44:47PM +0530, Balbir Singh wrote: >> My concern with all the points you mentioned is that this solution might >> need to >> change again, > > No why would it need to change again? > >> depending on the factors

Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller

2008-02-23 Thread Balbir Singh
Andrew Morton wrote: > On Fri, 22 Feb 2008 09:59:41 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > >> [EMAIL PROTECTED] wrote: >>> Update the memory controller to use read_uint for its >>> limit/usage/failcnt control files, calling the new >>> res_cou

Re: + cgroup-memory-controller-document-huge-memory-cache-overhead-in-kconfig.patch added to -mm tree

2008-02-23 Thread Balbir Singh
bered asking for a external data structure for > this. > > It's also quite unobvious that a innocent looking Kconfig option with a > single line Kconfig description has such a negative effect. > > This patch attempts to document these disadvantages at least so that user

Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller

2008-02-23 Thread Balbir Singh
Andrew Morton wrote: > On Sat, 23 Feb 2008 06:33:34 -0800 "Paul Menage" <[EMAIL PROTECTED]> wrote: > >> On Thu, Feb 21, 2008 at 8:29 PM, Balbir Singh <[EMAIL PROTECTED]> wrote: >>> Looks good, except for the name uint(), can we make it u64(). Integers

[PATCH] Memory controller rename to Memory Resource Controller

2008-02-25 Thread Balbir Singh
Controller on and off. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- Documentation/controllers/memory.txt |8 ++-- include/linux/cgroup_subsys.h|2 +- include/linux/memcontrol.h |4 ++-- include/linux/mm_types.h |4 ++-- init/K

[PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Balbir Singh
resource controller specific files. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- Documentation/kernel-parameters.txt |2 ++ mm/memcontrol.c | 33 - 2 files changed, 34 insertions(+), 1 deletion(-) diff -L mm/memcontrol.h -pu

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Balbir Singh
Paul Menage wrote: > On Mon, Feb 25, 2008 at 3:55 AM, Balbir Singh <[EMAIL PROTECTED]> wrote: >> >> A boot option for the memory controller was discussed on lkml. It is a good >> idea to add it, since it saves memory for people who want to turn off the >> mem

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-25 Thread Balbir Singh
Paul Menage wrote: > On Mon, Feb 25, 2008 at 9:18 AM, Balbir Singh <[EMAIL PROTECTED]> wrote: >> I thought about it, but it did not work out all that well. The reason being, >> that the memory controller is called in from places besides cgroup. >> mem_cgroup_cha

[PATCH] Memory Resource Controller use strstrip while parsing arguments

2008-02-25 Thread Balbir Singh
The memory controller has a requirement that while writing values, we need to use echo -n. This patch fixes the problem and makes the UI more consistent. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- Documentation/controllers/memory.txt |6 +++--- kernel/res_cou

Re: [PATCH] Memory Resource Controller use strstrip while parsing arguments

2008-02-25 Thread Balbir Singh
Andrew Morton wrote: > On Mon, 25 Feb 2008 23:57:46 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > >> The memory controller has a requirement that while writing values, we need >> to use echo -n. This patch fixes the problem and makes the UI more >> consistent. &g

RE: Sytem slowdown on 2.4.1-ac20 (recurring from 2.4.0)

2001-02-28 Thread Balbir Singh
Just FYI: I remember posting something a few days ago to make the serial console more reliable for such situations. Some allocations in the serial port driver are done at runtime using page_alloc, if somebody runs out of memory the serial tty driver would not work properly. I am not saying that

Re: [patch 07/19] split anon & file LRUs for memcontrol code

2008-01-07 Thread Balbir Singh
y if this calclation can be following later. > == > if (scan_global_lru(sc)) { > get_scan_ratio(zone, sc, percent); > } else { > get_scan_ratio_cgroup(sc->cgroup, sc, percent); > } > == > To do this, > mem_cgroup needs to have recent_rotated_file and recent_rolated

Re: Linux 2.6.24-rc7 Build-Failure at __you_cannot_kmalloc_that_much

2008-01-08 Thread Balbir Singh
Hi, Andrew, We tried the following, generated stabs information. The size of struct device is 560 bytes. We found that dead code was not being eliminated (__you_cannot_kmalloc_that_much), even though no one called that function. I suspect builtin_constant_p() and dead code elimination as the root causes o

Re: [LTP] Container Code Coverage for 2.6.23 mainline kernel

2008-01-09 Thread Balbir Singh
On Jan 9, 2008 12:52 PM, Rishikesh K. Rajak <[EMAIL PROTECTED]> wrote: > > Hi All, > > You can find the code coverage data for container code which has been > merged with mainline linux-2.6.23 and respective testcases are merged with > ltp for the feature called SYSVIPC NAMESPACE & UTS NAMESPACE

Re: [LTP] Container Code Coverage for 2.6.23 mainline kernel

2008-01-09 Thread Balbir Singh
On Jan 9, 2008 2:45 PM, Subrata Modak <[EMAIL PROTECTED]> wrote: > > On Wed, 2008-01-09 at 14:38 +0530, Balbir Singh wrote: > > On Jan 9, 2008 12:52 PM, Rishikesh K. Rajak <[EMAIL PROTECTED]> wrote: > > > > > > Hi All, > > > > > > You

Re: [patch 05/19] split LRU lists into anon & file sets

2008-01-09 Thread Balbir Singh
t PageActive(pc->page)) > Yes, correct. A page active on the node's zone LRU need not be active in the memory cgroup. > ANON <-> FILE attribute can be changed dinamically (after added to LRU) ? > > If no, using page_file_cache(pc->page) will be easy. > > Thanks

Re: [patch 05/19] split LRU lists into anon & file sets

2008-01-09 Thread Balbir Singh
* KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> [2008-01-10 11:36:18]: > On Thu, 10 Jan 2008 07:51:33 +0530 > Balbir Singh <[EMAIL PROTECTED]> wrote: > > > > > #define PAGE_CGROUP_FLAG_CACHE (0x1) /* charged as cache */ > > > > #define PAGE_CGROUP

Re: 2.6.24-rc4-mm1 kobject changes broken with hvcs driver on powerpc

2007-12-06 Thread Balbir Singh
N_ERR "HVCS: Kobject of open" > - " hvcs doesn't exist.\n"); > - return -EFAULT; /* Is this the right return value? */ > - } > + kref_get(&hvcsd->kref); > + spin_unlock_irqrestore(&hvcsd->lock, f

Re: 2.6.24-rc4-mm1 kobject changes broken with hvcs driver on powerpc

2007-12-06 Thread Balbir Singh
ran some tests with the fixed up version of this patch and the system fails to come up. I see the WARN_ON in lib/kref.c:33 and the system fails to boot beyond that point. I have not yet found time to debug it though. -- Warm Regards, Balbir Singh Linux Technology Center

Re: 2.6.24-rc4-mm1 kobject changes broken with hvcs driver on powerpc

2007-12-06 Thread Balbir Singh
Badari Pulavarty wrote: > On Fri, 2007-12-07 at 00:28 +0530, Balbir Singh wrote: >> Greg KH wrote: >> >>>> Why release the spinlock here? It's done after the count is incremented. >>>> This patch does not seem correct. >>> Doh, you are corre

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Arnd Bergmann wrote: > On Friday 07 December 2007, Balbir Singh wrote: >> Here's a dumb simple implementation of fake NUMA nodes for PowerPC. Fake >> NUMA nodes can be specified using the following command line option >> >> numa=fake= >> >> node rang

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Arnd Bergmann wrote: > On Friday 07 December 2007, Balbir Singh wrote: >> Balbir Singh wrote: >>> Geert Uytterhoeven wrote: >>>> On Sat, 8 Dec 2007, Balbir Singh wrote: >>>>> + if (strstr(p, "fake=")) >>>>> + cmdl

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
David Rientjes wrote: > On Sat, 8 Dec 2007, Balbir Singh wrote: > >> Yes, they all appear on node 0. We could have tweaks to distribute CPU's >> as well. >> > > You're going to want to distribute the cpu's based on how they match up > physically

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
David Rientjes wrote: > On Sat, 8 Dec 2007, Balbir Singh wrote: > >> To be able to test the memory controller under NUMA, I use fake NUMA >> nodes. x86-64 has a similar feature, the code I have here is the >> simplest I could come up with for PowerPC. >> > >

[PATCH] Fake NUMA emulation for PowerPC (Take 2)

2007-12-07 Thread Balbir Singh
Comments are as always welcome! Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- arch/powerpc/mm/numa.c | 59 - 1 file changed, 54 insertions(+), 5 deletions(-) diff -puN arch/powerpc/mm/numa.c~ppc-fake-numa-easy arch/powerpc/mm/numa.c ---

Re: [PATCH] Fake NUMA emulation for PowerPC

2007-12-07 Thread Balbir Singh
Kumar Gala wrote: > > On Dec 7, 2007, at 4:12 PM, Balbir Singh wrote: > >> Kumar Gala wrote: >>> >>> On Dec 7, 2007, at 3:35 PM, Balbir Singh wrote: >>> >>>> Olof Johansson wrote: >>>>> Hi, >>>>> >>>

  1   2   3   4   5   6   7   8   9   10   >