[PATCH 3/4] ASoC: rt5645: add inv_hp_det flag

2021-01-07 Thread Chris Chiu
ge () {"hp-detect-gpio", Package() {^RTK2, 0, 0, 1 }}, } }) This flag will invert the hp-detect gpio polarity. Signed-off-by: Chris Chiu --- include/sound/rt5645.h| 2 ++ sound/soc/codecs/rt5645.c | 4 2 files changed, 6 insertions(+) diff --git a/include/sound/rt5645.h b/

[PATCH 0/4] ASoC: rt5645: Enable internal mic and headset on ECS EF20

2021-01-07 Thread Chris Chiu
These patches are trying to fix the jack detection and internal microphone problems on ECS EF20 series laptops which are empowered by Intel Atom x5-Z8350 CPU (CherryTrail) with Realtek rt5645 audio codec. Chris Chiu (4): ASoC: rt5645: Introduce mapping for ACPI-defined GPIO ASoC: rt5645: Add

[PATCH 4/4] ASoC: rt5645: Enable internal microphone and JD on ECS EF20

2021-01-07 Thread Chris Chiu
On ECS EF20 series laptops, the internal mic is on DMIC2/IN2P. And they need the inv_hp_det to make jack detection to work as exoected. Signed-off-by: Chris Chiu --- sound/soc/codecs/rt5645.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc

[PATCH v2 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2021-01-07 Thread Chris Chiu
On at least one laptop (ECS EF20EA) the 'hp-detect' GPIO is defined in the DSDT table by the ACPI GpioIo resources in _CRS. The GPIO related information should be mapped to the rt5645 driver to enable the jack detection also on non-DT platforms. Signed-off-by: Chris Chiu ---

[PATCH v2 3/4] ASoC: rt5645: add inv_hp_det flag

2021-01-07 Thread Chris Chiu
ge () {"hp-detect-gpio", Package() {^RTK2, 0, 0, 1 }}, } }) This flag will invert the hp-detect gpio polarity. Signed-off-by: Chris Chiu --- v1 -> v2: - none include/sound/rt5645.h| 2 ++ sound/soc/codecs/rt5645.c | 4 2 files changed, 6 insertions(+) dif

[PATCH v2 2/4] ASoC: rt5645: Add ACPI-defined GPIO for ECS EF20 series

2021-01-07 Thread Chris Chiu
"\\_SB.GPO3", 0x00, ResourceConsumer, , ) { // Pin list 0x004F } }) Return (SBUF) /* \_SB_.PCI0.I2C2.RTK2._CRS.SBUF */ } Signed-off-by: Chris Chiu --- v1 -> v2: - Invoke callback() of the DMI quirk if it exists.

[PATCH v2 0/4] ASoC: rt5645: Enable internal mic and headset on ECS EF20

2021-01-07 Thread Chris Chiu
the dmi_first_match() doesn't. --- Chris Chiu (4): ASoC: rt5645: Introduce mapping for ACPI-defined GPIO ASoC: rt5645: Add ACPI-defined GPIO for ECS EF20 series ASoC: rt5645: add inv_hp_det flag ASoC: rt5645: Enable internal microphone and JD on ECS EF20 include/sound/rt5645.h

[PATCH v2 4/4] ASoC: rt5645: Enable internal microphone and JD on ECS EF20

2021-01-07 Thread Chris Chiu
On ECS EF20 series laptops, the internal mic is on DMIC2/IN2P. And they need the inv_hp_det to make jack detection to work as exoected. Signed-off-by: Chris Chiu --- v1 -> v2: - none sound/soc/codecs/rt5645.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/

[PATCH] ASoC: Intel: bytcr_rt5640: Add quirks for DeeQ X5-Z8300

2020-12-15 Thread Chris Chiu
DeeQ X5-Z8300 is a laptop empowered by Intel Atom Cherry Trail. Add quirks to select the correct input map, jack-detect options to enable jack sensing and internal/headset microphones. Signed-off-by: Chris Chiu --- sound/soc/intel/boards/bytcr_rt5651.c | 8 1 file changed, 8 insertions

[PATCH] ALSA: hda/realtek: Remove dummy lineout on Acer TravelMate P648/P658

2020-12-16 Thread Chris Chiu
a new quirk to remove the useless lineout and enable the pin 0x18 for jack sensing and headset microphone. Signed-off-by: Chris Chiu Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/sound/pc

Re: [PATCH] [v2] pinctrl: intel: mark intel_pin_to_gpio __maybe_unused

2019-09-08 Thread Chris Chiu
gpio' [-Werror,-Wunused-function] > > Mark it __maybe_unused to suppress the warning. > > Suggested-by: Andy Shevchenko > Signed-off-by: Arnd Bergmann Reviewed-by: Chris Chiu

[PATCH] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-09-02 Thread Chris Chiu
which invokes the handle_c2h is only for 8723b and 8192e so the mechanism is expected to work on both chips with single antenna. Note RTL8192EU dual antenna is not supported. Signed-off-by: Chris Chiu --- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 37 +++ .../realtek/rtl8xxxu/rtl8xxxu_87

Tweak I2C SDA hold time on GemniLake to make touchpad work

2019-09-03 Thread Chris Chiu
Hi, We're working on the acer Gemnilake laptop TravelMate B118-M for touchpad not working issue. The touchpad fails to bring up and the i2c-hid ouput the message as follows [8.317293] i2c_hid i2c-ELAN0502:00: hid_descr_cmd failed We tried on latest linux kernel 5.3.0-rc6 and it reports the

Re: Tweak I2C SDA hold time on GemniLake to make touchpad work

2019-09-03 Thread Chris Chiu
On Tue, Sep 3, 2019 at 8:03 PM Jarkko Nikula wrote: > > Hi Chris > > On 9/3/19 11:18 AM, Mika Westerberg wrote: > > +Jarkko > > > > On Tue, Sep 03, 2019 at 04:10:27PM +0800, Chris Chiu wrote: > >> Hi, > >> > >> We're working on the

Re: Tweak I2C SDA hold time on GemniLake to make touchpad work

2019-09-03 Thread Chris Chiu
On Wed, Sep 4, 2019 at 1:54 PM Jarkko Nikula wrote: > > On 9/4/19 7:38 AM, Chris Chiu wrote: > > On Tue, Sep 3, 2019 at 8:03 PM Jarkko Nikula > > wrote: > >> > >> Hi Chris > >> > >> On 9/3/19 11:18 AM, Mika Westerberg wrote: > >>

[PATCH] pinctrl: intel: remap the pin number to gpio offset for irq enabled pin

2019-08-16 Thread Chris Chiu
tored. Signed-off-by: Chris Chiu --- drivers/pinctrl/intel/pinctrl-intel.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index a18d6eefe672..8d6a843bbc7e 100644 --- a/dr

Re: [PATCH] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-09-05 Thread Chris Chiu
On Tue, Sep 3, 2019 at 1:37 PM Chris Chiu wrote: > > The RTL8723BU suffers the wifi disconnection problem while bluetooth > device connected. While wifi is doing tx/rx, the bluetooth will scan > without results. This is due to the wifi and bluetooth share the same > single

[PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-09-10 Thread Chris Chiu
which invokes the handle_c2h is only for 8723b and 8192e so the mechanism is expected to work on both chips with single antenna. Note RTL8192EU dual antenna is not supported. Signed-off-by: Chris Chiu --- Notes: v2: - Add helper functions to replace bunch of tdma settings - Reformat some lin

Re: [RFC PATCH v7] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-09-16 Thread Chris Chiu
On Mon, Aug 12, 2019 at 11:21 PM Jes Sorensen wrote: > > On 8/12/19 10:32 AM, Kalle Valo wrote: > >> Signed-off-by: Jes Sorensen > > > > This is marked as RFC so I'm not sure what's the plan. Should I apply > > this? > > I think it's at a point where it's worth applying - I kinda wish I had > had

[PATCH v7] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-09-17 Thread Chris Chiu
8xxxu could still be further improved. Signed-off-by: Chris Chiu Reviewed-by: Daniel Drake --- Notes: v2: - Fix errors and warnings complained by checkpatch.pl - Replace data structure rate_adaptive by 2 member variables - Make rtl8xxxu_wireless_mode non-static - Runs refresh

[PATCH v8] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-10-02 Thread Chris Chiu
8xxxu could still be further improved. Signed-off-by: Chris Chiu Reviewed-by: Daniel Drake Acked-by: Jes Sorensen --- Notes: v2: - Fix errors and warnings complained by checkpatch.pl - Replace data structure rate_adaptive by 2 member variables - Make rtl8xxxu_wireless_mode

Re: [PATCH v7] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-10-02 Thread Chris Chiu
On Wed, Oct 2, 2019 at 12:30 PM Kalle Valo wrote: > New warning: > > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function > 'rtl8xxxu_refresh_rate_mask': > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5907:7: warning: this > statement may fall through [-Wimplicit-fallthrou

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-02 Thread Chris Chiu
On Wed, Oct 2, 2019 at 12:29 PM Kalle Valo wrote: > Failed to apply, please rebase on top of wireless-drivers-next. > > fatal: sha1 information is lacking or useless > (drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h). > error: could not build fake ancestor > Applying: rtl8xxxu: add bluetooth c

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-02 Thread Chris Chiu
On Wed, Oct 2, 2019 at 11:04 PM Jes Sorensen wrote: > > > In general I think it looks good! One nit below: > > Sorry I have been traveling for the last three weeks, so just catching up. > > > > +void rtl8723bu_set_coex_with_type(struct rtl8xxxu_priv *priv, u8 type) > > +{ > > + switch (type) {

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-01 Thread Chris Chiu
On Thu, Sep 19, 2019 at 9:44 AM Chris Chiu wrote: > > On Wed, Sep 11, 2019 at 10:50 AM Chris Chiu wrote: > > > > > > Notes: > > v2: > >- Add helper functions to replace bunch of tdma settings > >- Reformat some lines to meet kernel coding style

Re: [PATCH] rtl8xxxu: make arrays static, makes object smaller

2019-10-07 Thread Chris Chiu
t; 148619024 0 238855d4d realtek/rtl8xxxu/rtl8xxxu_8192e.o > 149536616 0 215695441 realtek/rtl8xxxu/rtl8xxxu_8723b.o > 102986 31458 576 135020 20f6c realtek/rtl8xxxu/rtl8xxxu_core.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King > --- Reviewed-by: Chris Chiu

Re: [PATCH v8] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-10-08 Thread Chris Chiu
On Wed, Oct 2, 2019 at 8:18 PM Chris Chiu wrote: > v7: >- Fix reported bug of watchdog stop >- refer to the RxPWDBAll in vendor driver for SNR calculation > v8: >- Add missing break in switch case > > + case WIRELESS_MODE_N_24G: &

[PATCH v3] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-05 Thread Chris Chiu
which invokes the handle_c2h is only for 8723b and 8192e so the mechanism is expected to work on both chips with single antenna. Note RTL8192EU dual antenna is not supported. Signed-off-by: Chris Chiu --- Notes: v2: - Add helper functions to replace bunch of tdma settings - Reformat some lin

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-09-18 Thread Chris Chiu
On Wed, Sep 11, 2019 at 10:50 AM Chris Chiu wrote: > > > Notes: > v2: >- Add helper functions to replace bunch of tdma settings >- Reformat some lines to meet kernel coding style > > Gentle ping. Any suggestions would be appreciated. Thanks. Chris

Re: [PATCH] rtl8xxxu: prevent leaking urb

2019-09-20 Thread Chris Chiu
On Fri, Sep 20, 2019 at 11:01 AM Navid Emamdoost wrote: > > In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb > should be released. > > Signed-off-by: Navid Emamdoost Reviewed-by: Chris Chiu > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c &

System fails to exit s2idle by a keystroke on my laptop

2020-05-04 Thread Chris Chiu
Hi, I have an Intel X5-Z8350 laptop which used to work fine on s2idle enter/exit with kernel 5.3. After upgrading to kernel 5.4 and later, the system can still exit s2idle by power button. However, if I try to wake it up from a keystroke, the system will freeze and then no longer respond even t

Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'

2019-10-23 Thread Chris Chiu
ormance of RTL8723BU on rtl8xxxu driver") > > Signed-off-by: YueHaibing > --- Singed-off-by: Chris Chiu > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_

[PATCH] rtl8xxxu: fix warnings for symbol not declared.

2019-10-23 Thread Chris Chiu
d. Should it be static? sparse: symbol 'rtl8723bu_handle_bt_info' was not declared. Should it be static? Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu

[PATCH] rtl8xxxu: fix connection failure issue after warm reboot

2019-10-15 Thread Chris Chiu
--- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 +++ 3 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h b/drivers

[PATCH] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot

2019-10-15 Thread Chris Chiu
ommit only tells the RTL8723BU to do full initilization without checking MAC status. Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 +

[PATCH] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot

2019-10-15 Thread Chris Chiu
ommit only tells the RTL8723BU to do full initialization without checking MAC status. https://phabricator.endlessm.com/T28000 Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 + drivers/net/wir

Re: [PATCH] rtl8xxxu: fix connection failure issue after warm reboot

2019-10-15 Thread Chris Chiu
On Tue, Oct 15, 2019 at 6:16 PM Chris Chiu wrote: > > --- > 2.23.0 > Please ignore this message since it's not properly titled and no detail description. Sorry for inconvenience. Chris

[PATCH v2] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot

2019-10-15 Thread Chris Chiu
ommit only tells the RTL8723BU to do full initialization without checking MAC status. Signed-off-by: Chris Chiu --- Note: v2: fix typo of commit message drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 + drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 + drivers/net/wir

Re: [PATCH v2] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot

2019-10-16 Thread Chris Chiu
On Wed, Oct 16, 2019 at 9:54 AM Chris Chiu wrote: > > The RTL8723BU has problems connecting to AP after each warm reboot. > Sometimes it returns no scan result, and in most cases, it fails > the authentication for unknown reason. However, it works totally > fine after cold reboot.

Re: [PATCH v2] rtl8xxxu: fix RTL8723BU connection failure issue after warm reboot

2019-10-20 Thread Chris Chiu
On Thu, Oct 17, 2019 at 10:26 AM Chris Chiu wrote: > > On Wed, Oct 16, 2019 at 9:54 AM Chris Chiu wrote: > > > > The RTL8723BU has problems connecting to AP after each warm reboot. > > Sometimes it returns no scan result, and in most cases, it fails > > the aut

Re: [RFC PATCH 2/2] rtl8xxxu: Add watchdog to update rate mask by signal strength

2019-05-26 Thread Chris Chiu
On Wed, May 22, 2019 at 2:38 AM Daniel Drake wrote: > > On Fri, May 10, 2019 at 2:37 AM Chris Chiu wrote: > > I've verified that multiple virtual interface can not work simultaneously in > > STA mode. I assigned different mac address for different vifs, I can only > >

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2019-04-04 Thread Chris Chiu
On Wed, Apr 3, 2019 at 9:06 PM Andy Shevchenko wrote: > > On Wed, Apr 03, 2019 at 03:06:43PM +0800, Chris Chiu wrote: > > On Tue, Apr 2, 2019 at 7:58 PM Andy Shevchenko > > wrote: > > > > Instead you may need to loop over each pin in the part of the group >

[PATCH] pinctrl:intel: Retain HOSTSW_OWN for requested gpio pin

2019-04-07 Thread Chris Chiu
pinctrl. After system resumes, the GPIO is in ACPI mode and no longer works as an IRQ. This commit saves the HOSTSW_OWN value during suspend, make sure the HOSTSW_OWN mode remains the same after resume. Signed-off-by: Chris Chiu --- drivers/pinctrl/intel/pinctrl-intel.c | 50

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2019-03-29 Thread Chris Chiu
On Thu, Mar 28, 2019 at 8:34 PM Mika Westerberg wrote: > > On Thu, Mar 28, 2019 at 08:19:59PM +0800, Chris Chiu wrote: > > On Thu, Mar 28, 2019 at 5:38 PM Daniel Drake wrote: > > > > > > On Thu, Mar 28, 2019 at 5:17 PM Andy Shevchenko > > > wrote: > &g

Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume

2019-04-01 Thread Chris Chiu
On Mon, Apr 1, 2019 at 3:49 PM Mika Westerberg wrote: > > On Fri, Mar 29, 2019 at 04:38:20PM +0800, Chris Chiu wrote: > > On Thu, Mar 28, 2019 at 8:34 PM Mika Westerberg > > wrote: > > > > > > On Thu, Mar 28, 2019 at 08:19:59PM +0800, Chris Chiu wrote: >

Re: [PATCH v3] pinctrl:intel: Retain HOSTSW_OWN for requested gpio pin

2019-04-29 Thread Chris Chiu
On Fri, Apr 26, 2019 at 8:50 PM Andriy Shevchenko wrote: > > On Tue, Apr 23, 2019 at 12:38:17PM +0200, Linus Walleij wrote: > > On Mon, Apr 15, 2019 at 7:54 AM Chris Chiu wrote: > > > > > The touchpad of the ASUS laptops E403NA, X540NA, X541NA are not > > >

Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-02 Thread Chris Chiu
We have 3 laptops which connect the wifi by the same RTL8723BU. The PCI VID/PID of the wifi chip is 10EC:B720 which is supported. They have the same problem with the in-kernel rtl8xxxu driver, the iperf (as a client to an ethernet-connected server) gets ~1Mbps. Nevertheless, the signal strength is

[RFC PATCH 1/2] rtl8xxxu: Add rate adaptive related data

2019-05-03 Thread Chris Chiu
Add wireless mode, signal strength level, and rate table index to tell the firmware that we need to adjust the tx rate bitmap accordingly. --- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 45 +++ .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 45 ++- 2 files cha

[RFC PATCH 0/2] Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-03 Thread Chris Chiu
ggest if there's any better idea to fix this. Thanks. Chris Chiu (2): rtl8xxxu: Add rate adaptive related data rtl8xxxu: Add watchdog to update rate mask by signal strength .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 53 ++ .../realtek/rtl8xxxu/rtl8xxxu_8723b.c | 151 +++

[RFC PATCH 2/2] rtl8xxxu: Add watchdog to update rate mask by signal strength

2019-05-03 Thread Chris Chiu
Introduce watchdog to monitor signal then update the rate mask accordingly. The rate mask update logic comes from the rtlwifi refresh_rate_adaptive_mask() from different chips. --- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 8 + .../realtek/rtl8xxxu/rtl8xxxu_8723b.c | 151 ++

Re: [RFC PATCH v7] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-08-12 Thread Chris Chiu
On Mon, Aug 5, 2019 at 9:15 PM Chris Chiu wrote: > > We have 3 laptops which connect the wifi by the same RTL8723BU. > The PCI VID/PID of the wifi chip is 10EC:B720 which is supported. > They have the same problem with the in-kernel rtl8xxxu driver, the > iperf (as a client

[RFC PATCH v7] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-08-05 Thread Chris Chiu
8xxxu could still be further improved. Signed-off-by: Chris Chiu Reviewed-by: Daniel Drake --- Notes: v2: - Fix errors and warnings complained by checkpatch.pl - Replace data structure rate_adaptive by 2 member variables - Make rtl8xxxu_wireless_mode non-static - Runs refresh

[PATCH] staging: rtl8723bs: indicate disconnection when disconnecting

2019-07-31 Thread Chris Chiu
indicate the disconnection events during disconnection so the cfg80211_connect can connect to a different AP without problem. Signed-off-by: Chris Chiu --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep

[PATCH] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU

2019-06-27 Thread Chris Chiu
g the BT. Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 9 ++--- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c b/dr

Re: [RFC PATCH v4] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-06-10 Thread Chris Chiu
On Wed, Jun 5, 2019 at 10:17 AM Chris Chiu wrote: > > On Tue, Jun 4, 2019 at 3:21 AM Jes Sorensen wrote: > > > > On 5/31/19 5:12 AM, Chris Chiu wrote: > > > We have 3 laptops which connect the wifi by the same RTL8723BU. > > > The PCI VID/PID of the wifi

Re: [PATCH] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU

2019-07-02 Thread Chris Chiu
On Mon, Jul 1, 2019 at 4:28 PM Daniel Drake wrote: > > Hi Chris, > > On Thu, Jun 27, 2019 at 5:53 PM Chris Chiu wrote: > > The WiFi tx power of RTL8723BU is extremely low after booting. So > > the WiFi scan gives very limited AP list and it always fails to > > co

Re: [PATCH] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU

2019-07-02 Thread Chris Chiu
On Tue, Jul 2, 2019 at 8:44 PM Jes Sorensen wrote: > > On 6/27/19 5:52 AM, Chris Chiu wrote: > > The WiFi tx power of RTL8723BU is extremely low after booting. So > > the WiFi scan gives very limited AP list and it always fails to > > connect to the selected AP. This

Re: [PATCH] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU

2019-06-30 Thread Chris Chiu
On Thu, Jun 27, 2019 at 5:52 PM Chris Chiu wrote: > > The WiFi tx power of RTL8723BU is extremely low after booting. So > the WiFi scan gives very limited AP list and it always fails to > connect to the selected AP. This module only supports 1x1 antenna > and the antenna is switch

Re: [RFC PATCH v5] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-06-30 Thread Chris Chiu
On Mon, Jun 17, 2019 at 2:56 PM Chris Chiu wrote: > > We have 3 laptops which connect the wifi by the same RTL8723BU. > The PCI VID/PID of the wifi chip is 10EC:B720 which is supported. > They have the same problem with the in-kernel rtl8xxxu driver, the > iperf (as a client

[RFC PATCH v6] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-07-01 Thread Chris Chiu
8xxxu could still be further improved. Signed-off-by: Chris Chiu Reviewed-by: Daniel Drake --- Notes: v2: - Fix errors and warnings complained by checkpatch.pl - Replace data structure rate_adaptive by 2 member variables - Make rtl8xxxu_wireless_mode non-static - Runs refresh

[PATCH v2] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU

2019-07-04 Thread Chris Chiu
onnect until BT disconnected. Signed-off-by: Chris Chiu --- Note: v2: - Replace BIT(11) with the descriptive definition - Meaningful comment for the REG_S0S1_PATH_SWITCH setting drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 11 --- drivers/net/wireless/realtek/rtl8xxxu/

Re: [PATCH v2] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU

2019-07-04 Thread Chris Chiu
On Fri, Jul 5, 2019 at 12:43 AM Jes Sorensen wrote: > > On 7/4/19 6:55 AM, Chris Chiu wrote: > > The WiFi tx power of RTL8723BU is extremely low after booting. So > > the WiFi scan gives very limited AP list and it always fails to > > connect to the selected AP. This

Re: [PATCH v2] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU

2019-07-04 Thread Chris Chiu
On Fri, Jul 5, 2019 at 11:41 AM Daniel Drake wrote: > > On Thu, Jul 4, 2019 at 6:55 PM Chris Chiu wrote: > > The WiFi tx power of RTL8723BU is extremely low after booting. So > > the WiFi scan gives very limited AP list and it always fails to > > connect to the selec

[PATCH] iommu/amd: Fix a null pointer dereference for ACPI devices

2019-03-07 Thread Chris Chiu
n null derefernce at the consequent device->pnp.ids. Fix this by validating the ACPI companion of the device first. Signed-off-by: Chris Chiu --- drivers/iommu/amd_iommu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index 1167ff

[PATCH v2 2/2] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-06-11 Thread Chris Chiu
brightness for each keypress, then toggle(off) the LED when it already reached the max level. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index

[PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-06-11 Thread Chris Chiu
led_classdev_notify_brightness_hw_changed. This will allow userspace to monitor (poll) for brightness changes on the LED without reporting via input keymapping. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git

[PATCH] ACPI / PM: Fix wake up by PS2 keyboard fail on ASUS UX331UA

2018-03-30 Thread Chris Chiu
onizes with SCI interrupt completion. Signed-off-by: Chris Chiu https://phabricator.endlessm.com/T21599 --- drivers/acpi/sleep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 8082871..c6e1b4b 100644 --- a/drivers/acpi/sleep.c +++

[PATCH] ACPI / PM: Fix wake up by PS2 keyboard fail on ASUS UX331UA

2018-03-30 Thread Chris Chiu
onizes with SCI interrupt completion. Signed-off-by: Chris Chiu --- drivers/acpi/sleep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 8082871..c6e1b4b 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -982,8 +982,9

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-10 Thread Chris Chiu
On Tue, May 8, 2018 at 11:47 PM, Daniel Drake wrote: > On Tue, May 8, 2018 at 8:31 AM, Jarkko Nikula > wrote: >>> Some update, we can make the touchpad work by simply modifying the >>> clk_rate of spt_i2c_info from 12000 to 13300 in intel-lpss-pci.c for >>> specific PCI ID 8086:a368 ~ a36

Intel GemniLake xHCI connected devices can never wake up the system from suspend

2018-03-14 Thread Chris Chiu
Hi, I have a ASUS AIO V222GA and another Acer Desktop XC-830 both have Intel CPU J5005 and they both hit the same problem. The XHCI connected USB keyboard/mouse can never wakeup the system from suspend. It reminds me that similiar thing happens on ApolloLake too which needs the XHCI_PME_STUCK_

Re: Intel GemniLake xHCI connected devices can never wake up the system from suspend

2018-03-15 Thread Chris Chiu
On Thu, Mar 15, 2018 at 7:46 PM, Mathias Nyman wrote: > On 15.03.2018 06:40, Chris Chiu wrote: >> >> Hi, >> I have a ASUS AIO V222GA and another Acer Desktop XC-830 both >> have Intel CPU J5005 and they both hit the same problem. The XHCI >> connected USB ke

Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

2018-05-07 Thread Chris Chiu
On Fri, May 4, 2018 at 2:55 PM, Jian-Hong Pan wrote: > Hi, > > We have an ASUS X580GD (Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz) laptop > equipped with ELAN1200 touchpad which does not work totally, but the > external mouse works fine. > > We have checked the input devices by "cat /proc/bus/input/

Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

2016-12-14 Thread Chris Chiu
On Wed, Dec 14, 2016 at 6:20 PM, Jiri Kosina wrote: > On Mon, 12 Dec 2016, Chris Chiu wrote: > > [ ... snip ... ] >> +static const struct hid_device_id asus_rog_devices[] = { >> + { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, >> USB_DEVICE_ID_ASUSTEK_ROG_MACROKEY1) }

[PATCH] drm/nouveau: fix unknown chipset for GTX 1060

2016-12-12 Thread Chris Chiu
Nouveau driver shows unknown chipset (136000a1) for GTX 1060, so it only gives VGA resolution on screen. Use the same chipset as nv134 then it shows FullHD. This commit copies fields from nv134_chipset to nv136_chipset for GTX 1060. Signed-off-by: Chris Chiu --- drivers/gpu/drm/nouveau/nvkm

[PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

2016-12-12 Thread Chris Chiu
;s verified on GL553VD/VE, GL753VD/VE. Signed-off-by: Chris Chiu Reported-by: Yukai Li --- drivers/hid/Kconfig| 11 +++ drivers/hid/Makefile | 1 + drivers/hid/hid-asus-rog.c | 80 ++ drivers/hid/hid-ids.h | 2 ++ include/linux/hid

[PATCH] Input: elan_i2c - +200 ms delay before setting to ABS mode

2016-06-07 Thread Chris Chiu
. "elan_i2c i2c-ELAN1000:00: invalid report id data (1)" This change is from ELAN's correction. It needs 200ms delay before set_mode() so that the mode setting will correctly take effect. Signed-off-by: Chris Chiu --- drivers/input/mouse/elan_i2c_core.c | 12 +++- 1 file change

[PATCH 1/3] rtlwifi: rtl8192se: remove duplicated legacy_httxpowerdiff

2020-10-05 Thread Chris Chiu
From: Chris Chiu The legacy_httxpowerdiff in rtl8192se is pretty much the same as the legacy_ht_txpowerdiff for other chips. Use the same name to keep the consistency. Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 2 +- drivers/net/wireless/realtek

[PATCH] rtlwifi: rtl8192se: remove duplicated legacy_httxpowerdiff

2020-10-05 Thread Chris Chiu
From: Chris Chiu The legacy_httxpowerdiff in rtl8192se is pretty much the same as the legacy_ht_txpowerdiff for other chips. Use the same name to keep the consistency. Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 2 +- drivers/net/wireless/realtek

[PATCH] ALSA: usb: mixer: volume quirk for ESS Technology Asus USB DAC

2020-05-25 Thread Chris Chiu
-23040/0/1 Signed-off-by: Chris Chiu --- sound/usb/mixer.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 81b2db0edd5f..0b568a9fdab3 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -1171,6 +1171,14 @@ static void volume_control_

Re: System fails to exit s2idle by a keystroke on my laptop

2020-05-10 Thread Chris Chiu
On Sat, May 9, 2020 at 12:50 AM Rafael J. Wysocki wrote: > > On Friday, May 8, 2020 10:22:09 AM CEST Chris Chiu wrote: > > On Fri, May 8, 2020 at 2:05 AM Rafael J. Wysocki wrote: > > > > Hi Rafael, > > Thanks for your patch. I tried it on my laptop and it'

Re: [PATCH v2] ACPI: EC: s2idle: Avoid premature returns from acpi_s2idle_wake()

2020-05-10 Thread Chris Chiu
how_bug.cgi?id=207603 > Reported-by: Todd Brandt > Fixes: fdde0ff8590b ("ACPI: PM: s2idle: Prevent spurious SCIs from waking up > the system") > Link: > https://lore.kernel.org/linux-acpi/CAB4CAwdqo7=mvyg_pe+pgvfea17ahf5i5jucgakqqmx6mja...@mail.gmail.com/ > Reported-b

[PATCH] platform/x86: asus_wmi: Reserve more space for struct bias_args

2020-05-22 Thread Chris Chiu
blem. Signed-off-by: Chris Chiu --- drivers/platform/x86/asus-wmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index bb7c529d7d16..cd212ee210e2 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-w

[PATCH] rtl8xxxu: prevent potential memory leak

2020-09-05 Thread Chris Chiu
Free the skb if usb_submit_urb fails on rx_urb. And free the urb no matter usb_submit_urb succeeds or not in rtl8xxxu_submit_int_urb. Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a

mt7615: Fail to load firmware on AZWAVE-CB434NF module

2020-09-08 Thread Chris Chiu
Hi Sean, Ryder, We have an ASUS laptop X532EQ with the wifi module AZWAVE-CB434NF which fails to bring up the wifi interface on kernel 5.9.0-rc1. The dmesg shows the firmware load error. [ 25.630850] mt7615e :2d:00.0: Message -4294967280 (seq 1) timeout [ 25.630851] mt7615e :2d:00.

[PATCH] Bluetooth: btusb: Add support for 13d3:3560 MediaTek MT7615E device

2020-11-02 Thread Chris Chiu
=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms Signed-off-by: Chris Chiu

[PATCH v2] Bluetooth: btusb: Add support for 13d3:3560 MediaTek MT7615E device

2020-11-09 Thread Chris Chiu
: Chris Chiu --- v2: - Add comment for the MT7615E BT device. drivers/bluetooth/btusb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 5af2e3f30a5e..7e05be1a7bff 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth

Re: mt7615: Fail to load firmware on AZWAVE-CB434NF module

2020-09-13 Thread Chris Chiu
On Tue, Sep 8, 2020 at 8:33 PM Chris Chiu wrote: > > Hi Sean, Ryder, > We have an ASUS laptop X532EQ with the wifi module AZWAVE-CB434NF > which fails to bring up the wifi interface on kernel 5.9.0-rc1. The > dmesg shows the firmware load error. > > [ 25.630850]

Re: [RFC PATCH v4] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-06-04 Thread Chris Chiu
On Tue, Jun 4, 2019 at 3:21 AM Jes Sorensen wrote: > > On 5/31/19 5:12 AM, Chris Chiu wrote: > > We have 3 laptops which connect the wifi by the same RTL8723BU. > > The PCI VID/PID of the wifi chip is 10EC:B720 which is supported. > > They have the same problem with the i

[RFC PATCH v3] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-28 Thread Chris Chiu
may need fix. And I think we can still bring in the dm_watchdog as rtlwifi to improve from the driver side. Please leave precious comments for my commits and suggest what I can do better. Or suggest if there's any better idea to fix this. Thanks. Signed-off-by: Chris Chiu --- Notes: v2:

[RFC PATCH v5] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-06-16 Thread Chris Chiu
f RTL8723BU may need fix. And I think we can still bring in the dm_watchdog as rtlwifi to improve from the driver side. Please leave precious comments for my commits and suggest what I can do better. Or suggest if there's any better idea to fix this. Thanks. Signed-off-by: Chris Chiu --- Not

Re: [RFC PATCH v3] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-29 Thread Chris Chiu
On Thu, May 30, 2019 at 2:12 AM Daniel Drake wrote: > > Hi Chris, > > On Tue, May 28, 2019 at 11:03 PM Chris Chiu wrote: > > + /* > > +* Single virtual interface permitted since the driver supports > > STATION > > +* mode only. > >

Re: [RFC PATCH v3] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-29 Thread Chris Chiu
On Thu, May 30, 2019 at 2:22 AM Larry Finger wrote: > > On 5/29/19 12:03 AM, Chris Chiu wrote: > > We have 3 laptops which connect the wifi by the same RTL8723BU. > > The PCI VID/PID of the wifi chip is 10EC:B720 which is supported. > > They have the same problem wit

[RFC PATCH v4] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-31 Thread Chris Chiu
f RTL8723BU may need fix. And I think we can still bring in the dm_watchdog as rtlwifi to improve from the driver side. Please leave precious comments for my commits and suggest what I can do better. Or suggest if there's any better idea to fix this. Thanks. Signed-off-by: Chris Chiu --- Not

[PATCH v3] pinctrl:intel: Retain HOSTSW_OWN for requested gpio pin

2019-04-14 Thread Chris Chiu
pinctrl. After system resumes, the GPIO is in ACPI mode and no longer works as an IRQ. This commit saves the HOSTSW_OWN value during suspend, make sure the HOSTSW_OWN mode remains the same after resume. Signed-off-by: Chris Chiu --- Note: v2: update hostown and show pr_info only when the host mode

Re: System fails to exit s2idle by a keystroke on my laptop

2020-05-06 Thread Chris Chiu
On Wed, May 6, 2020 at 6:19 PM Rafael J. Wysocki wrote: > > On Wed, May 6, 2020 at 11:32 AM Rafael J. Wysocki wrote: > > > > > > Thanks for the report, the issue evidently is EC-related. > > > > > @@ -1024,7 +1024,7 @@ static bool acpi_s2idle_wake(void) > > > * regarded as a spur

Re: System fails to exit s2idle by a keystroke on my laptop

2020-05-08 Thread Chris Chiu
On Fri, May 8, 2020 at 2:05 AM Rafael J. Wysocki wrote: > > On Thursday, May 7, 2020 5:38:11 AM CEST Chris Chiu wrote: > > On Wed, May 6, 2020 at 6:19 PM Rafael J. Wysocki wrote: > > > > > > On Wed, May 6, 2020 at 11:32 AM Rafael J. Wysocki > > > wrote:

Re: [PATCH[RFT]] ACPI: EC: s2idle: Avoid flushing EC work when EC GPE is inactive

2020-05-18 Thread Chris Chiu
On Mon, May 18, 2020 at 4:59 PM Rafael J. Wysocki wrote: > > On Thu, May 14, 2020 at 12:10 PM Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > Flushing the EC work while suspended to idle when the EC GPE status > > is not set causes some EC wakeup events (notably power button and

Re: [PATCH[RFT]] ACPI: EC: s2idle: Avoid flushing EC work when EC GPE is inactive

2020-05-18 Thread Chris Chiu
On Mon, May 18, 2020 at 4:59 PM Rafael J. Wysocki wrote: > > On Thu, May 14, 2020 at 12:10 PM Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > Flushing the EC work while suspended to idle when the EC GPE status > > is not set causes some EC wakeup events (notably power button and

Re: ipmi_si fails to get BMC ID

2018-02-20 Thread Chris Chiu
On Thu, Feb 15, 2018 at 1:17 AM, Corey Minyard wrote: > I'm removing Greg and Arnd from the email, I don't think this requires their > participation. > > > > > On 02/13/2018 08:44 PM, Chris Chiu wrote: >> >> On Fri, Feb 9, 2018 at 9:34 PM, Corey Min

Re: ipmi_si fails to get BMC ID

2018-02-13 Thread Chris Chiu
On Fri, Feb 9, 2018 at 9:34 PM, Corey Minyard wrote: > On 02/08/2018 09:09 PM, Chris Chiu wrote: >> >> On Thu, Feb 8, 2018 at 11:53 PM, Corey Minyard wrote: >>> >>> On 02/07/2018 09:01 PM, Chris Chiu wrote: >>>> >>>> Hi, >>>>

<    1   2   3   >