[RFC PATCH 4/8] hwmon: (ltc4261) convert to devm_hwmon_device_register API

2013-03-17 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/ltc4261.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/hwmon/ltc4261.c b/drivers/hwmon/ltc4261.c index 84a2d28..a6da54c 100644 --- a/drivers/hwmon/ltc4261.c +++ b/drivers/hwmon

[RFC PATCH 2/8] hwmon: (ina209) Convert to devm_hwmon_device_register API

2013-03-17 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/ina209.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/hwmon/ina209.c b/drivers/hwmon/ina209.c index c6fdd5b..547935f 100644 --- a/drivers/hwmon/ina209.c +++ b/drivers/hwmon/ina209.c

[RFC PATCH 3/8] hwmon: (ltc4215) Convert to devm_hwmon_device_register API

2013-03-17 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/ltc4215.c | 32 +++- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/hwmon/ltc4215.c b/drivers/hwmon/ltc4215.c index e887610..83bc0ba 100644 --- a/drivers/hwmon/ltc4215.c +++ b/drivers/hwmon

[RFC PATCH 7/8] hwmon: (max16065) Convert to devm_hwmon_device_register API

2013-03-17 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/max16065.c | 103 +- 1 file changed, 47 insertions(+), 56 deletions(-) diff --git a/drivers/hwmon/max16065.c b/drivers/hwmon/max16065.c index 2fa2c02..cb05219 100644 --- a/drivers/hwmon/max16065.c +++ b

[RFC PATCH 8/8] hwmon: (tmp401) Convert to devm_hwmon_device_register API

2013-03-17 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/tmp401.c | 184 1 file changed, 92 insertions(+), 92 deletions(-) diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c index c85f696..69b5293 100644 --- a/drivers/hwmon/tmp401.c +++ b

[RFC PATCH 0/8] hwmon: Add devres support

2013-03-17 Thread Guenter Roeck
. Guenter Roeck (8): hwmon: Add devres support hwmon: (ina209) Convert to devm_hwmon_device_register API hwmon: (ltc4215) Convert to devm_hwmon_device_register API hwmon: (ltc4261) convert to devm_hwmon_device_register

[RFC PATCH 1/8] hwmon: Add devres support

2013-03-17 Thread Guenter Roeck
is set to either the name provided with devm_hwmon_device_register or the name of the hardware device driver. Signed-off-by: Guenter Roeck --- drivers/hwmon/hwmon.c | 123 + include/linux/hwmon.h |5 ++ 2 files changed, 119 insertions(+), 9 deletion

[RFC PATCH 5/8] hwmon: (max6697) Convert to devm_hwmon_device_register API

2013-03-17 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/max6697.c | 157 ++- 1 file changed, 86 insertions(+), 71 deletions(-) diff --git a/drivers/hwmon/max6697.c b/drivers/hwmon/max6697.c index bf4aa37..068425b 100644 --- a/drivers/hwmon/max6697.c +++ b

[RFC PATCH 6/8] hwmon: (lm90) Convert to devm_hwmon_device_register API

2013-03-17 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/lm90.c | 106 ++ 1 file changed, 46 insertions(+), 60 deletions(-) diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c index 8eeb141..a35fa47 100644 --- a/drivers/hwmon/lm90.c +++ b/drivers

Re: [lm-sensors] [RFC PATCH 0/2] fs: sysfs: Add devres support

2013-03-18 Thread Guenter Roeck
On Mon, Mar 18, 2013 at 09:02:41AM +0100, Jean Delvare wrote: > On Sun, 17 Mar 2013 06:19:33 -0700, Guenter Roeck wrote: > > On Sun, Mar 17, 2013 at 01:39:20PM +0100, Jean Delvare wrote: > > > I'd like to add something at this point. > > > > > > We have

Re: RFC (v2): Intel QST sensor driver

2013-03-18 Thread Guenter Roeck
Hi Simon, On Mon, Mar 18, 2013 at 09:20:53PM +, Simon J. Rowe wrote: > Hello, > > I've made changes to my driver for the Intel Quiet System Technology > (QST) function that I posted at the end of last year and would again > appreciate feedback on it. > > As before the git repo can be found h

Re: [PATCH v2 2/7] watchdog: w83627hf: Enable watchdog only once

2013-03-19 Thread Guenter Roeck
On Tue, Mar 19, 2013 at 05:26:26PM +, Pádraig Brady wrote: > On 03/10/2013 11:14 PM, Guenter Roeck wrote: > > It is unnecessary to enable the logical device and WDT0 each time > > the watchdog is accessed. Do it only once during initialization. > > Is this also the case

Re: RFC (v2): Intel QST sensor driver

2013-03-19 Thread Guenter Roeck
On Tue, Mar 19, 2013 at 09:46:43PM +, Simon J. Rowe wrote: > On 19/03/13 00:27, Guenter Roeck wrote: > >Couple of problems I noticed when browsing through the code. > > > >- Some functions return errors with return code 0. > > > > if (ret <= 0) > >

[PATCH] staging/iio: iio_hwmon: Use device tree node name for hwmon name attribute

2013-03-20 Thread Guenter Roeck
So far, all instances of iio_hwmon set their hwmon name attribute to "iio_hwmon", which is not very descriptive. Set it to the device tree node name if available, and only revert to iio_hwmon otherwise. Signed-off-by: Guenter Roeck --- Jonathan, can we move this driver out of staging

Re: [PATCH] staging/iio: iio_hwmon: Use device tree node name for hwmon name attribute

2013-03-20 Thread Guenter Roeck
On Wed, Mar 20, 2013 at 06:28:21PM +, Jonathan Cameron wrote: > On 03/20/2013 03:52 PM, Guenter Roeck wrote: > > So far, all instances of iio_hwmon set their hwmon name attribute > > to "iio_hwmon", which is not very descriptive. Set it to the device tree > > n

[PATCH] watchdog: Convert BookE watchdog driver to watchdog infrastructure

2013-02-05 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/watchdog/Kconfig |1 + drivers/watchdog/booke_wdt.c | 185 +++--- 2 files changed, 66 insertions(+), 120 deletions(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 7f809fd..a5a9728

[PATCH v5] iio: Add OF support

2013-02-07 Thread Guenter Roeck
Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck --- v5: - Updated examples in bindings. v4: - Fixed wrong parameter to dummy of_iio_channel_get_by_name if CONFIG_OF is undefined, and wrong return value. - Initialize indio_dev->of_node

Re: MAINTAINERS: Remove Mark M. Hoffman

2013-02-08 Thread Guenter Roeck
s he was responsible for, the 4th one will Hi Jean, ... 2 drivers, the other two ... as far as I can see from the patch. Thanks, Guenter > fall down to the subsystem maintainer. > > Signed-off-by: Jean Delvare > Cc: "Mark M. Hoffman" > Cc: Guenter Roeck >

Re: iio: adc: add exynos5 adc driver under iio framwork

2013-02-12 Thread Guenter Roeck
On Wed, Jan 23, 2013 at 04:58:06AM -, Naveen Krishna Chatradhi wrote: > This patch add an ADC IP found on EXYNOS5 series socs from Samsung. > Also adds the Documentation for device tree bindings. > > Signed-off-by: Naveen Krishna Chatradhi > > --- > Changes since v1: > > 1. Fixed comments f

Re: UIO device tree bindings.

2013-04-02 Thread Guenter Roeck
On Tue, Apr 02, 2013 at 01:51:51PM +0200, Pavel Machek wrote: > On Mon 2013-04-01 19:42:12, Guenter Roeck wrote: > > On Mon, Apr 01, 2013 at 05:40:08PM +0200, Pavel Machek wrote: > > > On Mon 2013-04-01 16:23:36, Pavel Machek wrote: > > > > Hi! > > > >

Re: UIO device tree bindings.

2013-04-02 Thread Guenter Roeck
On Tue, Apr 02, 2013 at 03:46:45PM +0200, Pavel Machek wrote: > Hi! > > > > > Or maybe we can do some magic with module parameter. That should be > > > > enough for expected use. > > > > > > > I don't think that would make a difference. I mean, just take ns16550 as > > > another > > > example. N

[PATCH 0/5] Provide empty functions if OF_NET is not configured

2013-04-02 Thread Guenter Roeck
Provide empty functions for of_get_phy_mode() and of_get_mac_address() if OF_NET is not configured. Modify affected drivers to rely on the now available functions. Guenter Roeck (5): of_net.h: Provide dummy functions if OF_NET

[PATCH 2/5] net/cadence/at91_ether: Simplify OF dependencies

2013-04-02 Thread Guenter Roeck
-end functions and call of_get_mac_address() and of_get_phy_mode() directly instead. Signed-off-by: Guenter Roeck --- drivers/net/ethernet/cadence/at91_ether.c | 44 - 1 file changed, 6 insertions(+), 38 deletions(-) diff --git a/drivers/net/ethernet/cadence

[PATCH 4/5] net/freescale/fec: Simplify OF dependencies

2013-04-02 Thread Guenter Roeck
OF dependent function as front-end. Also, the function depends on OF_NET, not on OF, so the conditional code was not correct anyway. Drop the front-end function and call of_get_phy_mode() directly. Signed-off-by: Guenter Roeck --- drivers/net/ethernet/freescale/fec.c | 19

[PATCH 5/5] net/nxp/lpc_eth: Drop ifdef CONFIG_OF_NET

2013-04-02 Thread Guenter Roeck
Since of_get_mac_address() is now declared even if CONFIG_OF_NET is not configured, the ifdef is no longer necessary and can be removed. Signed-off-by: Guenter Roeck --- drivers/net/ethernet/nxp/lpc_eth.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c

[PATCH 3/5] net/cadence/macb: Simplify OF dependencies

2013-04-02 Thread Guenter Roeck
-end functions and call of_get_mac_address() and of_get_phy_mode() directly instead. Signed-off-by: Guenter Roeck --- drivers/net/ethernet/cadence/macb.c | 43 +-- 1 file changed, 6 insertions(+), 37 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c

[PATCH 1/5] of_net.h: Provide empty functions if OF_NET is not configured

2013-04-02 Thread Guenter Roeck
unctions if OF_NET is not configured. This is safe because all callers do check the return values. Cc: David Daney Signed-off-by: Guenter Roeck Acked-by: Rob Herring --- include/linux/of_net.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/of_net.h b/include/lin

Re: [PATCH v3 2/2] watchdog: fix w83627hf_wdt clear timeout expired

2013-04-02 Thread Guenter Roeck
On Mon, Apr 01, 2013 at 09:59:00PM -0700, Tony Chung wrote: > Thanks Guenter! > I agree with you. My first reaction was also about a small watchdog > server that will start in early boot process. There are pros and > cons. For example, there are many types of watchdog devices such as > ipmi_wat

Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver

2013-04-03 Thread Guenter Roeck
On Wed, Apr 03, 2013 at 05:09:52PM +0200, Sascha Hauer wrote: [ ... ] > > > > On a side note, if the driver supports devicetree, it might make sense to > > call > > watchdog_init_timeout, since it initializes the timeout from devicetree > > data. > > The driver does not support devicetree. >

Re: [PATCH v3 2/2] watchdog: fix w83627hf_wdt clear timeout expired

2013-04-03 Thread Guenter Roeck
On Wed, Apr 03, 2013 at 08:06:59AM -0700, Tony Chung wrote: > On Tue, Apr 2, 2013 at 9:21 PM, Guenter Roeck wrote: > > > > > > > What is the exact chip type in your system ? I want to have a look into the > > datasheet; maybe I can find out how it can t

Re: [PATCH v3 2/2] watchdog: fix w83627hf_wdt clear timeout expired

2013-04-03 Thread Guenter Roeck
On Wed, Apr 03, 2013 at 08:50:26AM -0700, Guenter Roeck wrote: > On Wed, Apr 03, 2013 at 08:06:59AM -0700, Tony Chung wrote: > > On Tue, Apr 2, 2013 at 9:21 PM, Guenter Roeck wrote: > > > > > > > > > > > What is the exact chip type in your syst

Re: [PATCH v8 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-04-03 Thread Guenter Roeck
nder this designed > structure, other chip specific files can be added simply using the same common > layer abx500.c. > > Signed-off-by: Hongbo Zhang Acked-by: Guenter Roeck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v8 4/5] ab8500: power: export abx500_res_to_temp tables for hwmon

2013-04-03 Thread Guenter Roeck
On Wed, Apr 03, 2013 at 08:18:11PM +0800, Hongbo Zhang wrote: > This patch exports the thermistor resistance-to-temperature tables, so that > the > hwmon driver can access them, and also adds the corresponding table size > variables. > > Signed-off-by: Hongbo Zhang Acked

Re: [PATCH v4 2/2] watchdog: fix w83627hf_wdt clear timeout expired

2013-04-03 Thread Guenter Roeck
ld not add that to the commit log, but that it up to Wim to decide ] > Signed-off-by: Tony Chung Acked-by: Guenter Roeck > --- > drivers/watchdog/w83627hf_wdt.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/w83627hf_wdt.c b/driv

Re: [PATCH] Blackfin: bf537: rename "CONFIG_AD7314"

2013-04-04 Thread Guenter Roeck
struct spi_board_info bfin_spi_board_info[] > > __initdata = { > > }, > > #endif > > > > -#if defined(CONFIG_AD7314) || defined(CONFIG_AD7314_MODULE) > > +#if IS_ENABLED(CONFIG_SENSORS_AD7314) > > { > > .modalias = "ad7314", > &

Re: [PATCH] Blackfin: bf537: rename "CONFIG_ADT75"

2013-04-04 Thread Guenter Roeck
On Thu, Apr 04, 2013 at 01:40:03PM +0200, Jean Delvare wrote: > On Thu, 04 Apr 2013 12:31:06 +0200, Paul Bolle wrote: > > In v3.2 the Analog Devices ADT75 temperature sensor driver was removed > > as an IIO driver and support for it was added to the LM75 HWMON driver. > > But it was apparently over

Re: [PATCH] Blackfin: bf537: rename "CONFIG_ADT75"

2013-04-04 Thread Guenter Roeck
On Thu, Apr 04, 2013 at 02:59:43PM +0200, Paul Bolle wrote: > On Thu, 2013-04-04 at 05:07 -0700, Guenter Roeck wrote: > > On Thu, Apr 04, 2013 at 01:40:03PM +0200, Jean Delvare wrote: > > > This breakage is telling us something about the weird approach taken in > &g

Re: 3.8.3 and 3.9git occasional watchdog oops

2013-04-04 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 12:23:30AM +0200, Arkadiusz Miskiewicz wrote: > On Thursday 14 of March 2013, Arkadiusz Miśkiewicz wrote: > > Hi. > > > > Just hit watchdog related oops in 3.8.3 kernel. Unfortunately photos only. > > > > http://ixion.pld-linux.org/~arekm/watchdog-oops-3.8.3/IMG_8942.JPG >

Re: [PATCH] Blackfin: bf537: use "CONFIG_SND_SOC_AD193X"

2013-04-05 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 11:43:37AM +0200, Jean Delvare wrote: > On Fri, 05 Apr 2013 11:20:46 +0200, Paul Bolle wrote: > > 1) Added Jean and Guenter because they seem to take in interest in > > Blackfin's stamp files. > > Doh, no, I only express my disgust and I'd rather stay away from them > as mu

Re: [PATCH RFC] watchdog: core: don't try to stop device if not running

2013-04-05 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 06:09:44PM +0200, Hector Palacios wrote: > A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS > ioctl and flag WDIOS_DISABLECARD. If the device is closed after this > operation, watchdog_release() is called and status bits checked for > stopping it. Besid

Re: 3.8.3 and 3.9git occasional watchdog oops

2013-04-05 Thread Guenter Roeck
On Thu, Apr 04, 2013 at 06:59:59PM -0700, Guenter Roeck wrote: > On Fri, Apr 05, 2013 at 12:23:30AM +0200, Arkadiusz Miskiewicz wrote: > > On Thursday 14 of March 2013, Arkadiusz Miśkiewicz wrote: > > > Hi. > > > > > > Just hit watchdog related oops in 3.8

[PATCH] watchdog: Fix race condition in registration code

2013-04-05 Thread Guenter Roeck
after it was created. Reported-by: Arkadiusz Miskiewicz Signed-off-by: Guenter Roeck --- Arkadiusz, would be great if you can test this in your system. drivers/watchdog/watchdog_dev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/watchdog_dev.c b

Re: [PATCH 2/2] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-01-30 Thread Guenter Roeck
On Wed, Jan 30, 2013 at 06:21:28PM +0800, Hongbo Zhang wrote: > Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500 > chips. This is ABX500 hwmon driver, where the abx500.c is a common layer for > all ABX500s, and the ab8500.c is specific for AB8500 chip. Under this designed

Re: [PATCH] hwmon: (lm90) Add device tree support

2013-02-01 Thread Guenter Roeck
On Fri, Feb 01, 2013 at 01:18:22PM -0800, Vincent Palatin wrote: > Add support to instantiate LM90-compatible sensors from a device-tree > configuration. > When the kernel has device tree support, we avoid doing the auto-detection > as probing the busses might mess-up sensitive I2C devices or trigg

Re: Build regressions/improvements in v3.8-rc5

2013-01-27 Thread Guenter Roeck
On Sun, Jan 27, 2013 at 02:56:46PM +0100, Sedat Dilek wrote: > Hi Geert, > > what is the intention of this list [1] which you regularly sent to LKML? > > Statistics? > > [ Compiler errors/warnings ] > > Are you directly contacting the maintainers of the subtree and inform > them (per email, web

[PATCH v6 00/12] hwmon: Driver for Nuvoton NCT6775F, NCT6776F, and NCT6779D

2013-02-26 Thread Guenter Roeck
This driver will replace the w83627ehf driver for NCT6775F and NCT6776F, and provides support for NCT6779D. This is a resend for most of the series. Patch 04/12 was updated, and patch 12/12 was added. The driver has been available as standalone driver (https://github.com/groeck/nct6775) since Ma

[PATCH v5 02/12] hwmon: (nct6775) Add case open detection

2013-02-26 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/nct6775.c | 67 +++ 1 file changed, 67 insertions(+) diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index f75cd82..435691f 100644 --- a/drivers/hwmon/nct6775.c +++ b/drivers/hwmon

[PATCH v5 09/12] hwmon: (nct6775) Add support for automatic fan control

2013-02-26 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- Documentation/hwmon/nct6775 | 69 +++ drivers/hwmon/nct6775.c | 1099 ++- 2 files changed, 1161 insertions(+), 7 deletions(-) diff --git a/Documentation/hwmon/nct6775 b/Documentation/hwmon/nct6775 index 7c9f1d3

[PATCH v5 10/12] hwmon: (nct6775) Add support for weighted fan control

2013-02-26 Thread Guenter Roeck
The NCT677X series support weighted fan control. In this mode, a secondary temperature source is used in addition to the primary temperature source to control fan speed. Add support for this feature. Signed-off-by: Guenter Roeck --- Documentation/hwmon/nct6775 | 19 +++ drivers/hwmon/nct6775

[PATCH 12/12] hwmon: (nct6775) Only report VID if supported and enabled

2013-02-26 Thread Guenter Roeck
VID is not always enabled (NCT6775, NCT6776) or supported (NCT6779). Signed-off-by: Guenter Roeck --- drivers/hwmon/nct6775.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index a4b076a

[PATCH v5 07/12] hwmon: (nct6775) Add power management support

2013-02-26 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/nct6775.c | 86 +++ 1 file changed, 86 insertions(+) diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index ac8be97..96e2ee1 100644 --- a/drivers/hwmon/nct6775.c +++ b/drivers/hwmon

[PATCH v5 06/12] hwmon: (nct6775) Add support for fan debounce module parameter

2013-02-26 Thread Guenter Roeck
If set, fan debounce is enabled when loading the driver. Signed-off-by: Guenter Roeck --- drivers/hwmon/nct6775.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index 828ed47..ac8be97 100644 --- a/drivers

[PATCH v5 11/12] hwmon: (nct6775) Detect and report additional temperature sources

2013-02-26 Thread Guenter Roeck
Scan all temperature sources used for fan control and report if additional monitoring registers are available. Signed-off-by: Guenter Roeck --- drivers/hwmon/nct6775.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/hwmon/nct6775.c b/drivers

[PATCH v5 08/12] hwmon: (nct6775) Add support for pwm, pwm_mode, and pwm_enable

2013-02-26 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- Documentation/hwmon/nct6775 | 18 +++ drivers/hwmon/nct6775.c | 329 +++ 2 files changed, 347 insertions(+) diff --git a/Documentation/hwmon/nct6775 b/Documentation/hwmon/nct6775 index dcd56a3..7c9f1d3 100644 --- a

[PATCH v5 05/12] hwmon: (nct6775) Add support for fanX_pulses sysfs attribute

2013-02-26 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/nct6775.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index ce4a59d..828ed47 100644 --- a/drivers/hwmon/nct6775.c +++ b/drivers/hwmon

[PATCH v5 03/12] hwmon: (nct6775) Add support for temperature sensors

2013-02-26 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- drivers/hwmon/nct6775.c | 745 ++- 1 file changed, 742 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index 435691f..aedf8f9 100644 --- a/drivers/hwmon/nct6775.c +++ b

[PATCH v6 04/12] hwmon: (nct6775) Add support for fan speed attributes

2013-02-26 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- Documentation/hwmon/nct6775 |5 +- drivers/hwmon/nct6775.c | 516 ++- 2 files changed, 518 insertions(+), 3 deletions(-) diff --git a/Documentation/hwmon/nct6775 b/Documentation/hwmon/nct6775 index ccfd5cc

[PATCH v5 01/12] hwmon: Driver for Nuvoton NCT6775F, NCT6776F, and NCT6779D

2013-02-26 Thread Guenter Roeck
This driver will replace the w83627ehf driver for NCT6775F and NCT6776F, and provides support for NCT6779D. This patch provides support for voltage monitor attributes. Signed-off-by: Guenter Roeck --- Documentation/hwmon/nct6775 | 81 drivers/hwmon/Kconfig | 13 + drivers/hwmon

Re: [PATCH v5 03/12] hwmon: (nct6775) Add support for temperature sensors

2013-02-26 Thread Guenter Roeck
On Tue, Feb 26, 2013 at 10:35:14AM -0800, Joe Perches wrote: > On Tue, 2013-02-26 at 10:23 -0800, Guenter Roeck wrote: > > diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c > [] > > +static const u16 NCT6779_REG_TEMP_CONFIG[11] = { 0x18, 0x152 }; > > Isn

[PATCH v6 03/12] hwmon: (nct6775) Add support for temperature sensors

2013-02-27 Thread Guenter Roeck
Signed-off-by: Guenter Roeck --- v6: Use ARRAY_SIZE to set the size of arrays depending on each other. drivers/hwmon/nct6775.c | 748 ++- 1 file changed, 745 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775

[PATCH] misc/vmw_vmci: Add dependency on CONFIG_NET

2013-02-27 Thread Guenter Roeck
e_pair.c:(.text+0x167341): undefined reference to `memcpy_fromiovec' make[1]: [vmlinux] Error 1 (ignored) since memcpy_toiovec and memcpy_fromiovec are defined in the networking code. Add the missing dependency. Signed-off-by: Guenter Roeck --- drivers/misc/vmw_vmci/Kconfig |2 +

[PATCH] staging: dgrp: Drop unnecessary typecast

2013-02-28 Thread Guenter Roeck
‘copy_from_user_overflow’ declared with attribute error: copy_from_user() buffer size is not provably correct Signed-off-by: Guenter Roeck --- drivers/staging/dgrp/dgrp_net_ops.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgrp/dgrp_net_ops.c b/drivers/staging/dgrp

[GIT PULL] hwmon updates for 3.9-rc1

2013-02-20 Thread Guenter Roeck
. Chris Verges (2): hwmon: (lm73) Add 'update_interval' attribute hwmon: (lm73) Add support for max/min alarms Guenter Roeck (22): hwmon: Replace SENSORS_LIMIT with clamp_val platform/x86: (eeepc-laptop) Replace SENSORS_LIMIT with

Re: [PATCH v5] iio: Add OF support

2013-02-20 Thread Guenter Roeck
On Fri, Feb 08, 2013 at 08:30:48AM +, Jonathan Cameron wrote: > On 07/02/13 17:09, Guenter Roeck wrote: > >Provide bindings and parse OF data during initialization. > > > >Signed-off-by: Guenter Roeck > Looks fine to me. Will give it a few more days to see what oth

Re: [PATCH v5] iio: Add OF support

2013-02-20 Thread Guenter Roeck
On Wed, Feb 20, 2013 at 11:38:22AM -0600, Rob Herring wrote: > On 02/07/2013 11:09 AM, Guenter Roeck wrote: > > Provide bindings and parse OF data during initialization. > > > > Signed-off-by: Guenter Roeck > > --- > > v5: > > - Updated examples in bindin

Re: [PATCH v5] iio: Add OF support

2013-02-20 Thread Guenter Roeck
On Wed, Feb 20, 2013 at 06:51:08PM +, Jonathan Cameron wrote: > > > Guenter Roeck wrote: > > >On Wed, Feb 20, 2013 at 11:38:22AM -0600, Rob Herring wrote: > >> On 02/07/2013 11:09 AM, Guenter Roeck wrote: > >> > Provide bindings

Re: [PATCH v2] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Guenter Roeck
On Tue, Mar 12, 2013 at 02:09:26PM +0530, Naveen Krishna Chatradhi wrote: > This patch adds DT support to NTC driver to parse the > platform data. > > Also adds the support to work as an iio device. > > During the probe ntc driver gets the respective channels of ADC > and uses iio_raw_read calls

Re: [PATCH v3] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Guenter Roeck
d to >null in case of non-DT > 6. removed a typecase of (s64) which is not needed. > > Guenter Roeck, Thanks for your valuble time and comments. They really > are helping me learn and do better on my future patches. > > Doug, Thanks for your support and testing these

Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Guenter Roeck
es iio_raw_read calls to get the ADC converted value. > > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v3: > 1. Added a NULL check before iio_channel_release > 2. Modified a return statement > > Guenter Roeck, Its wonderful working with you. Thanks. &g

Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Guenter Roeck
HOTPLUG_PCI drivers/pci/hotplug/Kconfig:5: symbol HOTPLUG_PCI depends on SYSFS So we can not just select IIO. I'll see if I can find a solution. Guenter > --- > Changes since v3: > 1. Added a NULL check before iio_channel_release > 2. Modified a return statement > >

Re: [lm-sensors] [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-12 Thread Guenter Roeck
On Tue, Mar 12, 2013 at 09:52:26PM -0700, Guenter Roeck wrote: > On Wed, Mar 13, 2013 at 09:38:20AM +0530, Naveen Krishna Chatradhi wrote: > > This patch adds DT support to NTC driver to parse the > > platform data. > > > > Also adds the support to work as an iio device

Re: [5/6] i2c: Ignore the return value of i2c_del_mux_adapter()

2013-03-12 Thread Guenter Roeck
adapter() to ignore its return > value and assume that it will always succeed (which it will). A subsequent > patch will make the return type of i2c_del_mux_adapter() void. > > Cc: Guenter Roeck Acked-by: Guenter Roeck > Signed-off-by: Lars-Peter Clausen > > --- > dri

Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

2013-03-13 Thread Guenter Roeck
as an iio device. > > > > During the probe ntc driver gets the respective channels of ADC > > and uses iio_raw_read calls to get the ADC converted value. > > > > Signed-off-by: Naveen Krishna Chatradhi > > --- > > Changes since v3: > > 1. Added a NULL

Re: [PATCH] hwmon: lineage-pem: Add missing terminating entry for pem_[input|fan]_attributes

2013-03-14 Thread Guenter Roeck
On Thu, Mar 14, 2013 at 11:23:54AM +0100, Jean Delvare wrote: > Hi Axel, > > On Thu, 14 Mar 2013 16:27:18 +0800, Axel Lin wrote: > > Signed-off-by: Axel Lin > > --- > > drivers/hwmon/lineage-pem.c |2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/hwmon/lineage-pem.c b/

Re: [PATCH] hwmon: (pmbus) Fix krealloc() misuse in pmbus_add_attribute()

2013-03-14 Thread Guenter Roeck
On Thu, Mar 14, 2013 at 01:30:20PM +, David Woodhouse wrote: > If krealloc() returns NULL, it *doesn't* free the original. So any code > of the form 'foo = krealloc(foo, …);' is almost certainly a bug. > > Signed-off-by: David Woodhouse Good catch. Thanks a lot for the fix! Guenter -- To un

Re: [PATCH 04/10] drivers: hwmon: use module_platform_driver_probe()

2013-03-14 Thread Guenter Roeck
On Thu, Mar 14, 2013 at 02:11:25PM +0100, Fabio Porcedda wrote: > This patch converts the drivers to use the > module_platform_driver_probe() macro which makes the code smaller and > a bit simpler. > > Signed-off-by: Fabio Porcedda > Cc: Greg Kroah-Hartman > Cc: Jean D

Re: [PATCH] checkpatch: Add check for reuse of krealloc arg

2013-03-14 Thread Guenter Roeck
> > So add a check for it to checkpatch. > > Signed-off-by: Joe Perches Excellent idea. Tested-by: Guenter Roeck Acked-by: Guenter Roeck > --- > scripts/checkpatch.pl | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scri

[RFC PATCH 0/2] fs: sysfs: Add devres support

2013-03-14 Thread Guenter Roeck
Provide devres functions for device_create_file, sysfs_create_file, and sysfs_create_group plus the respective remove functions. Idea is to be able to drop calls to the remove functions from the various drivers using those calls. Potential savings are substantial. There are more than 700 calls to

[RFC PATCH 2/2] drivers/core: Add support for devm_ functions

2013-03-14 Thread Guenter Roeck
Add support for devm_device_create_file and devm_device_remove_file. Signed-off-by: Guenter Roeck --- drivers/base/core.c| 18 ++ include/linux/device.h |4 2 files changed, 22 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 56536f4b0

[RFC PATCH 1/2] fs: sysfs: Add support for devm_ functions

2013-03-14 Thread Guenter Roeck
Add support for devm_sysfs_create_file devm_sysfs_remove_file devm_sysfs_create_group devm_sysfs_remove_group Signed-off-by: Guenter Roeck --- fs/sysfs/file.c | 51 +++ fs/sysfs/group.c | 53

[GIT PULL] hwmon patches for 3.9-rc3

2013-03-14 Thread Guenter Roeck
terminating entry for pem_[input|fan]_attributes David Woodhouse (1): hwmon: (pmbus) Fix krealloc() misuse in pmbus_add_attribute() Guenter Roeck (2): MAINTAINERS: Add maintainer for MAX6697, INA209, and INA2XX drivers hwmon: (pmbus/ltc2978) Fix temperature reporting MAINTAINERS

Re: [ 11/21] hwmon: (sht15) Check return value of regulator_enable()

2013-03-16 Thread Guenter Roeck
From: Mark Brown > > > > commit 3e78080f81481aa8340374d5a37ae033c1cf4272 upstream. > > > > Not having power is a pretty serious error so check that we are able to > > enable the supply and error out if we can't. > > > > Signed-off-by: Mark Brown > > Signed-of

Re: [RFC PATCH 0/2] fs: sysfs: Add devres support

2013-03-16 Thread Guenter Roeck
Adding lm-sensors. On Sat, Mar 16, 2013 at 09:21:40AM -0700, Greg Kroah-Hartman wrote: > On Thu, Mar 14, 2013 at 08:24:45PM -0700, Guenter Roeck wrote: > > Provide devres functions for device_create_file, sysfs_create_file, > > and sysfs_create_group plus the respective r

Re: [RFC PATCH 0/2] fs: sysfs: Add devres support

2013-03-16 Thread Guenter Roeck
On Sat, Mar 16, 2013 at 12:50:02PM -0700, Greg Kroah-Hartman wrote: > On Sat, Mar 16, 2013 at 11:12:53AM -0700, Guenter Roeck wrote: > > Adding lm-sensors. > > > > On Sat, Mar 16, 2013 at 09:21:40AM -0700, Greg Kroah-Hartman wrote: > > > On Thu, Mar 14, 2013 at 0

Re: [lm-sensors] [RFC PATCH 0/2] fs: sysfs: Add devres support

2013-03-16 Thread Guenter Roeck
On Sat, Mar 16, 2013 at 02:25:40PM -0700, Guenter Roeck wrote: > On Sat, Mar 16, 2013 at 12:50:02PM -0700, Greg Kroah-Hartman wrote: > > On Sat, Mar 16, 2013 at 11:12:53AM -0700, Guenter Roeck wrote: > > > Adding lm-sensors. > > > > > > On Sat, Mar 16, 2013 at

Re: [lm-sensors] [RFC PATCH 0/2] fs: sysfs: Add devres support

2013-03-17 Thread Guenter Roeck
On Sun, Mar 17, 2013 at 01:39:20PM +0100, Jean Delvare wrote: > On Sat, 16 Mar 2013 14:25:40 -0700, Guenter Roeck wrote: > > On Sat, Mar 16, 2013 at 12:50:02PM -0700, Greg Kroah-Hartman wrote: > > > On Sat, Mar 16, 2013 at 11:12:53AM -0700, Guenter Roeck wrote: > > > >

Re: [lm-sensors] [RFC PATCH 0/2] fs: sysfs: Add devres support

2013-03-17 Thread Guenter Roeck
On Sun, Mar 17, 2013 at 06:19:33AM -0700, Guenter Roeck wrote: > On Sun, Mar 17, 2013 at 01:39:20PM +0100, Jean Delvare wrote: > > On Sat, 16 Mar 2013 14:25:40 -0700, Guenter Roeck wrote: > > > On Sat, Mar 16, 2013 at 12:50:02PM -0700, Greg Kroah-Hartman wrote: > > > &

Re: [PATCH] hwmon/lm70: adding support for NS LM74 chip

2012-08-28 Thread Guenter Roeck
On Tue, Aug 28, 2012 at 02:09:00PM +0200, leroy christophe wrote: > > Le 26/08/2012 19:47, Guenter Roeck a écrit : > >On Thu, Aug 23, 2012 at 11:13:17AM -0700, Guenter Roeck wrote: > >>On Thu, Aug 23, 2012 at 05:32:12PM +0200, Christophe Leroy wrote: > >>&

Re: [PATCH] kernel.h: Introduce IDIV_ROUND_CLOSEST

2012-08-28 Thread Guenter Roeck
On Tue, Aug 28, 2012 at 06:09:26PM +0200, Jean Delvare wrote: > Hi Guenter, > > On Fri, 24 Aug 2012 17:53:17 -0700, Guenter Roeck wrote: > > DIV_ROUND_CLOSEST returns a bad result for negative dividends: > > DIV_ROUND_CLOSEST(-2, 2) = 0 > > > > Most of the t

[PATCH v2 1/2] linux/kernel.h: Introduce IDIV_ROUND_CLOSEST

2012-08-28 Thread Guenter Roeck
IDIV_ROUND_CLOSEST which also supports negative dividends. Signed-off-by: Guenter Roeck --- v2: v1 did not work if typeof(divisor) was an unsigned variable type (which can obviously not be negative). Rework to revert to DIV_ROUND_CLOSEST if the dividend is unsigned, or if it is signed but non

[PATCH 2/2] hwmon: Use IDIV_ROUND_CLOSEST if the dividend can be negative

2012-08-28 Thread Guenter Roeck
DIV_ROUND_CLOSEST returns bad values for negative dividends. Replace with IDIV_ROUND_CLOSEST where this can happen. Cc: Jean Delvare Cc: Dirk Eibach Cc: Steve Glendinning Signed-off-by: Guenter Roeck --- drivers/hwmon/ad7314.c |2 +- drivers/hwmon/ads1015.c |2

Re: [PATCH] hwmon: add Maxim MAX197 support

2012-08-30 Thread Guenter Roeck
On Thu, Aug 30, 2012 at 02:39:55PM -0400, Vivien Didelot wrote: > The MAX197 is an A/D converter, made by Maxim. This driver currently > supports the MAX197, and MAX199. They are both 8-Channel, Multi-Range, > 5V, 12-Bit DAS with 8+4 Bus Interface and Fault Protection. > > The available ranges for

Re: [PATCH] hwmon: add Maxim MAX197 support

2012-08-30 Thread Guenter Roeck
On Thu, Aug 30, 2012 at 02:39:55PM -0400, Vivien Didelot wrote: > The MAX197 is an A/D converter, made by Maxim. This driver currently > supports the MAX197, and MAX199. They are both 8-Channel, Multi-Range, > 5V, 12-Bit DAS with 8+4 Bus Interface and Fault Protection. > > The available ranges for

Re: [PATCH] hwmon: add Maxim MAX197 support

2012-08-30 Thread Guenter Roeck
On Thu, Aug 30, 2012 at 05:10:32PM -0400, Vivien Didelot wrote: > Hi Guenter, > > Thanks for your detailed comments. I'll send a new version soon. > > About the following comment, I agree with you. However as there is no > convention for this case, for now I would prefer to stick with the model

Re: [PATCH] hwmon: add Maxim MAX197 support

2012-08-30 Thread Guenter Roeck
On Thu, Aug 30, 2012 at 05:22:02PM -0400, Vivien Didelot wrote: > I guess we're too fast! > Well, you for sure are :) > I've just seen your reply, this is much cleaner, indeed. > I'll update the max197 driver, and fix the sht15 driver as soon as I can. > Great, thanks! Guenter -- To unsubscribe

Re: [PATCH v2 1/2] linux/kernel.h: Introduce IDIV_ROUND_CLOSEST

2012-08-30 Thread Guenter Roeck
On Thu, Aug 30, 2012 at 04:15:32PM -0700, Andrew Morton wrote: > On Tue, 28 Aug 2012 09:30:55 -0700 > Guenter Roeck wrote: > > > DIV_ROUND_CLOSEST returns a bad result for negative dividends: > > DIV_ROUND_CLOSEST(-2, 2) = 0 > > > > Most of the time this

[PATCH v3] linux/kernel.h: Fix DIV_ROUND_CLOSEST to support negative operands

2012-08-30 Thread Guenter Roeck
). Signed-off-by: Guenter Roeck --- v3: Instead of adding a new macro, fix DIV_ROUND_CLOSEST. This version works for negative dividend and divisor. v2: v1 did not work if typeof(divisor) was an unsigned variable type (which can obviously not be negative). Rework to revert to DIV_ROUND_CLOSEST

Re: [PATCH v3] linux/kernel.h: Fix DIV_ROUND_CLOSEST to support negative operands

2012-08-30 Thread Guenter Roeck
On Thu, Aug 30, 2012 at 05:35:31PM -0700, Andrew Morton wrote: > On Thu, 30 Aug 2012 17:10:47 -0700 Guenter Roeck wrote: > > > DIV_ROUND_CLOSEST returns a bad result for dividends with different sign: > > DIV_ROUND_CLOSEST(-2, 2) = 0 > > > > Most of the time

[PATCH v4] linux/kernel.h: Fix DIV_ROUND_CLOSEST to support negative dividends

2012-08-31 Thread Guenter Roeck
: Guenter Roeck --- v4: Don't address negative divisors to improve chances for compile-time optimization. Document DIV_ROUND_CLOSEST macro. v3: Instead of adding a new macro, fix DIV_ROUND_CLOSEST. This version works for negative dividend and divisor. v2: v1 did not work if typeof(di

Re: [PATCH v3] hwmon: add Maxim MAX197 support

2012-08-31 Thread Guenter Roeck
On Thu, Aug 30, 2012 at 09:42:57PM -0400, Vivien Didelot wrote: > The MAX197 is an A/D converter, made by Maxim. This driver currently > supports the MAX197, and MAX199. They are both 8-Channel, Multi-Range, > 5V, 12-Bit DAS with 8+4 Bus Interface and Fault Protection. > > The available ranges for

  1   2   3   4   5   6   7   8   9   10   >