Re: [PATCH v2 0/4] gpio: fix an incorrect lockdep warning

2016-09-19 Thread Peter Rosin
On 2016-09-18 21:45, Bartosz Golaszewski wrote: > 2016-09-18 21:43 GMT+02:00 Bartosz Golaszewski : >> 2016-09-18 10:52 GMT+02:00 Peter Rosin : >>> On 2016-09-16 19:58, Wolfram Sang wrote: >>>> >>>> Same here. And if it prevents us from false positive lo

Re: [PATCH v2 0/4] gpio: fix an incorrect lockdep warning

2016-09-20 Thread Peter Rosin
On 2016-09-19 11:03, Peter Zijlstra wrote: > On Mon, Sep 19, 2016 at 10:48:44AM +0200, Peter Rosin wrote: >> On 2016-09-19 10:14, Peter Zijlstra wrote: >>> On Mon, Sep 19, 2016 at 10:01:49AM +0200, Peter Rosin wrote: >>>> Or, do what the i2c-mux code is doing and use

Re: [PATCH v2 0/4] gpio: fix an incorrect lockdep warning

2016-09-20 Thread Peter Rosin
On 2016-09-20 12:07, Bartosz Golaszewski wrote: > 2016-09-20 10:48 GMT+02:00 Peter Rosin : >> >> One pretty simple problematic case is: >> >> .---. .. >> | | ||-- i2c2 >> | |-- i2c0 --|mux0| .. >> |

Re: [v12, 7/8] base: soc: introduce soc_device_match() interface

2016-09-21 Thread Peter Rosin
On 2016-09-21 09:56, Alexander Shiyan wrote: >> Среда, 21 сентября 2016, 9:57 +03:00 от Yangbo Lu : >> >> From: Arnd Bergmann < a...@arndb.de > >> >> We keep running into cases where device drivers want to know the exact >> version of the a SoC they are currently running on. In the past, this has >

Re: [PATCH v2 0/4] gpio: fix an incorrect lockdep warning

2016-09-21 Thread Peter Rosin
On 2016-09-20 17:33, Thomas Gleixner wrote: > On Tue, 20 Sep 2016, Peter Rosin wrote: >> On 2016-09-19 11:03, Peter Zijlstra wrote: >>> >>> Use the -RT kernel and all locks will end up as rt_mutex. Avoiding >>> inversion on one specific lock, while there are

Re: [PATCH 1/3] iio: potentiometer: mcp4531: Add support for MCP454x, MCP456x, MCP464x and MCP466x

2016-06-21 Thread Peter Rosin
wer-on. This feature is currently not supported and only the > volatile memory is used to set the wiper. > > Signed-off-by: Florian Vaussard Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH 3/3] iio: potentiometer: mcp4531: Add device tree binding

2016-06-21 Thread Peter Rosin
On 2016-06-21 08:55, Florian Vaussard wrote: > This patch adds the necessary device tree binding to allow DT probing of > currently supported parts. > > Signed-off-by: Florian Vaussard > --- > drivers/iio/potentiometer/mcp4531.c | 83 > - > 1 file changed, 82

Re: [PATCH 2/3] iio: potentiometer: mcp4531: Add device tree binding documentation

2016-06-21 Thread Peter Rosin
On 2016-06-21 08:55, Florian Vaussard wrote: > Add the device tree documentation for all the supported parts. Apart the > compatible string and standard I2C binding, no other binding is currently > needed. > > Signed-off-by: Florian Vaussard > --- > .../bindings/iio/potentiometer/mcp4531.txt

Re: [patch v5] i2c: mux: mellanox: add driver

2016-09-23 Thread Peter Rosin
On 2016-09-13 22:37, vad...@mellanox.com wrote: > From: Vadim Pasternak > > This driver allows I2C routing controlled through CPLD select registers on > a wide range of Mellanox systems (CPLD Lattice device). > MUX selection is provided by digital and analog HW. Analog part is not > under SW cont

Re: [PATCH v2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

2016-09-23 Thread Peter Rosin
On 2016-09-23 19:39, Rob Herring wrote: > On Sat, Sep 17, 2016 at 11:34:22AM +0200, Peter Rosin wrote: >> From: Gustaf Lindström >> >> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. >> >> Signed-off-by: Gustaf Lindström >> Signed-off-by:

[PATCH v3 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

2016-09-27 Thread Peter Rosin
From: Gustaf Lindström The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. The simple-panel driver is used to get support for essential functionality of the panel. Signed-off-by: Gustaf Lindström Signed-off-by: Peter Rosin --- drivers/gpu/drm/panel/panel-simple.c

[PATCH v3 0/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

2016-09-27 Thread Peter Rosin
Hi! I'm back with a new attempt at getting this panel upstream. This time with the bindings in a separate commit, as I hear that is preferred. I think I covered all the pins on the panel... Cheers, Peter Gustaf Lindström (1): drm/panel: simple: add support for Sharp LQ150X1LG11 panels

[PATCH v3 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding

2016-09-27 Thread Peter Rosin
The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. Signed-off-by: Peter Rosin --- .../bindings/display/panel/sharp,lq150x1lg11.txt | 36 ++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg1

Re: [RFC PATCH 1/1] i2c: i2c-mux-pca954x: Add interrupt controller support.

2016-07-29 Thread Peter Rosin
On 2016-07-28 04:44, Phil Reid wrote: > G'day Peter, > > Thanks for the feedback. > +linux-kernel@vger.kernel.org > > On 27/07/2016 13:32, Peter Rosin wrote: >> On 2016-07-27 05:05, Phil Reid wrote: >>> +static void pca954x_irq_mask(struct irq_data *ida

[PATCH 2/2] i2c: move locking operations to their own struct

2016-07-29 Thread Peter Rosin
This makes it trivial to constify them, so do that. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-core.c | 13 - drivers/i2c/i2c-mux.c | 25 - include/linux/i2c.h| 25 ++--- 3 files changed, 42 insertions(+), 21 deletions(-) diff

[PATCH 1/2] i2c: add i2c_trylock_bus wrapper, use it

2016-07-29 Thread Peter Rosin
This unifies usage with i2c_lock_bus and i2c_unlock_bus, and paves the way for the next patch which looks a bit saner with this preparatory work taken care of beforehand. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-core.c | 2 +- drivers/i2c/i2c-mux.c | 4 ++-- include/linux/i2c.h| 14

[PATCH 0/2] i2c: move adapter locking ops to struct, constify

2016-07-29 Thread Peter Rosin
This allows the locking ops to be moved to .rodata, which is generally desireable. It also feels good to change all ops with one assignment. Cheers, Peter Peter Rosin (2): i2c: add i2c_trylock_bus wrapper, use it i2c: move locking operations to their own struct drivers/i2c/i2c-core.c | 15

Re: [PATCH 3/7] dt-bindings: i2c: add support for 'i2c-gate' subnode

2016-07-31 Thread Peter Rosin
On 2016-07-29 23:25, Rob Herring wrote: > On Wed, Jul 27, 2016 at 10:43:26AM +0200, Peter Rosin wrote: >> Handle i2c gates similarly to how i2c arbitrators are handled. >> This gets rid of a pointless 'reg' property for i2c gates. >> >> I.e. this new and more

Re: [RFC PATCH 1/1] i2c: i2c-mux-pca954x: Add interrupt controller support.

2016-08-01 Thread Peter Rosin
On 2016-08-01 08:25, Phil Reid wrote: > On 29/07/2016 13:48, Peter Rosin wrote: >> Ok, I think I get the problem, but I too am at a loss and see no elegant >> solution. >> One sad thing about your workaround is that it is not working at all unless >> there >>

Re: [patch v4] i2c: mux: mellanox: add driver

2016-09-13 Thread Peter Rosin
It's shaping up, a few last nitpicks... On 2016-09-13 16:38, vad...@mellanox.com wrote: > From: Vadim Pasternak > > This driver allows I2C routing controlled through CPLD select registers on > wide range of Mellanox systems (CPLD Lattice device). s/wide/a wide/ But is it really still "a wide r

Re: [patch v5] i2c: mux: mellanox: add driver

2016-09-14 Thread Peter Rosin
onfirmed that you need to support different register values in the CPLD with sel_reg_addr. I can see that there is a possibility that you actually really need it, but I'd like to remove that variable if at all possible. If you can confirm that you need that, this is Acked-by: Peter Rosin Otherwise, please just hard code the register address. Cheers, Peter

Re: [patch v5] i2c: mux: mellanox: add driver

2016-09-14 Thread Peter Rosin
s there to help with?) Thanks! On 2016-09-14 10:10, Vadim Pasternak wrote: > Peter Rosin wrote: >> On 2016-09-13 22:37, vad...@mellanox.com wrote: >>> From: Vadim Pasternak >>> >>> This driver allows I2C routing controlled through CPLD select >>> regi

Re: [PATCH v1 0/2] i2c: Stop i2c modules being unloaded while in use.

2016-09-14 Thread Peter Rosin
Hi Jim! On 2016-09-13 18:55, Baxter, Jim wrote: > Hi Peter, > >> nitpick: Patch subjects for the second patch is wrong. >> >> "reparented" is a bit dual when dealing with i2c adapter trees. >> i2c_mux_add_owned_adapter is perhaps clearer? > > Agreed, I will update that. > >> >> >> Aside from th

[PATCH] i2c: i2c-mux-pca954x: retry updating the mux selection on failure

2016-09-14 Thread Peter Rosin
The cached value of the last selected channel prevents retries on the next call, even on failure to update the selected channel. Fix that. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-pca954x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/muxes/i2c

[PATCH] iio: imu: inv_mpu6050: inform the i2c mux core about how it is used

2016-08-31 Thread Peter Rosin
The i2c mux core can then take appropriate action depending on if it is used for an actual i2c mux, or for an arbitrator or gate. In this case it is used as a gate. This will make devicetree bindings simpler when they are eventually added. Signed-off-by: Peter Rosin --- drivers/iio/imu

Re: [patch 2/2] i2c: mux: mellanox: add driver

2016-09-02 Thread Peter Rosin
On 2016-08-29 19:36, vad...@mellanox.com wrote: > From: Vadim Pasternak > > This driver allows I2C routing controlled through CPLD select registers on > wide range of Mellanox systems (CPLD Lattice device). > MUX selection is provided by digital and analog HW. Analog part is not > under SW contro

Re: [PATCH 2/2] i2c: move locking operations to their own struct

2016-08-24 Thread Peter Rosin
On 2016-08-23 23:16, Wolfram Sang wrote: > On Fri, Jul 29, 2016 at 10:17:57AM +0200, Peter Rosin wrote: >> This makes it trivial to constify them, so do that. >> >> Signed-off-by: Peter Rosin > > Looks good. Could you rebase to i2c/for-next? Right, no problem! C

Re: [patch 2/2] i2c: mux: mellanox: add driver

2016-08-24 Thread Peter Rosin
On 2016-08-24 15:56, Vadim Pasternak wrote: > From: Vadim Pasternak > > This driver allows I2C routing controlled through CPLD select registers on > wide > range of Mellanox systems (CPLD Lattice device). > MUX selection is provided by digital and analog HW. Analog part is not under > SW > cont

Re: [patch 2/2] i2c: mux: mellanox: add driver

2016-08-25 Thread Peter Rosin
On 2016-08-24 18:20, Vadim Pasternak wrote: > Hi Peter, > > Thank you very much for your review. > >> -Original Message----- >> From: Peter Rosin [mailto:p...@axentia.se] >> Sent: Wednesday, August 24, 2016 4:55 PM >> To: Vadim Pasternak ; w...@the-dreams

Re: [PATCH v2 6/8] i2c: mux: inform the i2c mux core about how it is used

2016-08-25 Thread Peter Rosin
On 2016-08-25 18:24, Wolfram Sang wrote: > On Thu, Aug 25, 2016 at 06:22:37PM +0200, Peter Rosin wrote: >> On 2016-08-25 18:19, Wolfram Sang wrote: >>> >>>> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c >>>> b/drivers/i2c/muxes/i2c-mux-pca9541.c &g

[PATCH v2] i2c: move locking operations to their own struct

2016-08-25 Thread Peter Rosin
This makes it trivial to constify them, so do that. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_dp_helper.c | 10 +++--- drivers/i2c/i2c-core.c | 13 - drivers/i2c/i2c-mux.c | 25 - include/linux/i2c.h | 25

Re: [PATCH v2 6/8] i2c: mux: inform the i2c mux core about how it is used

2016-08-25 Thread Peter Rosin
On 2016-08-25 18:19, Wolfram Sang wrote: > >> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c >> b/drivers/i2c/muxes/i2c-mux-pca9541.c >> index 3cb8af635db5..f052c3067791 100644 >> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c >> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c >> @@ -349,7 +349,8 @@ stati

Re: [PATCH v3 0/5] iio: srf08: add support for similar devices and triggered buffers

2017-08-16 Thread Peter Rosin
On 2017-08-16 21:32, Andreas Klinger wrote: > This patch series adds support for: > - triggered buffer > - ultrasonic devices srf02 and srf10 > > Thanks for the review of Peter and Wolfram. > > @Wolfram: please let me know, if you want a separate patch for [PATCH 1/5] I think what you should do

Re: [RFC PATCH v2 1/3] drm: atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-20 Thread Peter Rosin
On 2017-06-20 11:40, Daniel Vetter wrote: > On Sat, Jun 17, 2017 at 07:48:02PM +0200, Peter Rosin wrote: >> All layers of all supported chips support this, the only variable is the >> base address of the lookup table in the register map. >> >> Signed-off-by: Peter Ros

[PATCH v4 2/2] drm: atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-20 Thread Peter Rosin
All layers of all supported chips support this, the only variable is the base address of the lookup table in the register map. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 4 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c| 13 +++ drivers/gpu

[PATCH v4 0/2] drm: atmel-hlcdc: clut support

2017-06-20 Thread Peter Rosin
to the overlay2 layer of sama5d4, since the chip does not appear to have that layer. I didn't do that to make it easier to work with the patch previously sent to remove that layer, but I suspect bad things may happen to sama5d4 users if they do not have that layer removed. Cheers, peda Peter Ros

[PATCH v4 1/2] drm: atmel-hlcdc: add missing .set_property helper to the crtc

2017-06-20 Thread Peter Rosin
The default implementation should be used. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c index 5348985..cc00ce3

[PATCH 00/11] improve the fb_setcmap helper

2017-06-20 Thread Peter Rosin
bit-manipulation somewhere in this mostly mechanical change... Cheers, peda Peter Rosin (11): drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set drm: amd: remove dead code and pointless local lut storage drm: ast: remove dead code and pointless local lut storage

[PATCH 05/11] dmr: gma500: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
make the driver work for the C8 mode from the fbdev interface. But that is untested. Signed-off-by: Peter Rosin --- drivers/gpu/drm/gma500/framebuffer.c | 22 drivers/gpu/drm/gma500/gma_display.c | 32 ++ drivers/gpu/drm/gma500

[PATCH 03/11] drm: ast: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu

[PATCH 06/11] drm: i915: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
. Since the fb helper .gamma_set and .gamma_get are no longer used, just kill the mysterious dead code. Signed-off-by: Peter Rosin --- drivers/gpu/drm/i915/intel_drv.h | 1 - drivers/gpu/drm/i915/intel_fbdev.c | 31 --- 2 files changed, 32 deletions(-) diff --git a

[PATCH 08/11] drm: nouveau: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 26

[PATCH 11/11] drm: remove unused and redundant callbacks

2017-06-20 Thread Peter Rosin
Drivers no longer have any need for these callbacks, and there are no users. Zap. Zap-zap-zzzap-p-pp-p. Signed-off-by: Peter Rosin --- include/drm/drm_fb_helper.h | 32 include/drm/drm_modeset_helper_vtables.h | 16 2 files changed

[PATCH 10/11] drm: stm: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helper .load_lut is no longer used, and can not work right without also providing the fb helpers .gamma_set and .gamma_get thus rendering the code in this driver suspect. Just remove the dead code. Signed-off-by: Peter Rosin --- drivers/gpu/drm/stm/ltdc.c | 12

[PATCH 09/11] drm: radeon: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/radeon/atombios_crtc.c | 1

[PATCH 07/11] drm: mgag200: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/mgag200/mgag200_drv.h | 5

[PATCH 02/11] drm: amd: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 24

[PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-20 Thread Peter Rosin
? drm_fb_helper_save_lut_atomic justs saves the gamma lut for later. However, it saves it to the gamma_store which should already be up to date with what .gamma_get would return and is thus a nop. So, zap it. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_fb_helper.c | 131

[PATCH 04/11] drm: cirrus: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/cirrus/cirrus_drv.h | 8

Re: [PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-21 Thread Peter Rosin
On 2017-06-21 09:38, Daniel Vetter wrote: > On Tue, Jun 20, 2017 at 09:25:25PM +0200, Peter Rosin wrote: >> This makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get >> totally obsolete. >> >> I think the gamma_store can end up invalid on error. But the

Re: [PATCH 08/11] drm: nouveau: remove dead code and pointless local lut storage

2017-06-21 Thread Peter Rosin
On 2017-06-20 21:25, Peter Rosin wrote: > The redundant fb helpers .load_lut, .gamma_set and .gamma_get are > no longer used. Remove the dead code and hook up the crtc .gamma_set > to use the crtc gamma_store directly instead of duplicating that > info locally. [...] > - for

Re: [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2

2017-06-21 Thread Peter Rosin
On 2017-06-21 17:14, Nicolas Ferre wrote: > On 16/06/2017 at 00:40, Peter Rosin wrote: >> On 2017-06-15 11:37, Boris Brezillon wrote: >>> On Thu, 15 Jun 2017 11:24:13 +0200 >>> Peter Rosin wrote: >>> >>>> From: Peter Rosin >>>> >>

[PATCH v5 0/2] drm: atmel-hlcdc: clut support

2017-06-21 Thread Peter Rosin
he drm clut. Cheers, peda Peter Rosin (2): drm: atmel-hlcdc: add missing .set_property helper to the crtc drm: atmel-hlcdc: add support for 8-bit color lookup table mode drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 5 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c| 14 +

[PATCH v5 2/2] drm: atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-21 Thread Peter Rosin
All layers of all supported chips support this, the only variable is the base address of the lookup table in the register map. Acked-by: Daniel Vetter Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 4 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c| 14

[PATCH v5 1/2] drm: atmel-hlcdc: add missing .set_property helper to the crtc

2017-06-21 Thread Peter Rosin
The default implementation should be used. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c index 5348985..cc00ce3

[PATCH v2 03/14] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-21 Thread Peter Rosin
This makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get totally obsolete. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_fb_helper.c | 154 1 file changed, 63 insertions(+), 91 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 07/14] drm: cirrus: remove dead code and pointless local lut storage

2017-06-21 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/cirrus/cirrus_drv.h | 8

[PATCH v2 01/14] drm/fb-helper: keep the .gamma_store updated in drm_fb_helper_setcmap

2017-06-21 Thread Peter Rosin
I think the gamma_store can end up invalid on error. But the way I read it, that can happen in drm_mode_gamma_set_ioctl as well, so why should this pesky legacy fbdev stuff be any better? Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_fb_helper.c | 27 +++ 1 file

[PATCH v2 10/14] drm: mgag200: remove dead code and pointless local lut storage

2017-06-21 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/mgag200/mgag200_drv.h | 5

[PATCH v2 12/14] drm: radeon: remove dead code and pointless local lut storage

2017-06-21 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/radeon/atombios_crtc.c | 1

[PATCH v2 11/14] drm: nouveau: remove dead code and pointless local lut storage

2017-06-21 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 26

[PATCH v2 09/14] drm: i915: remove dead code and pointless local lut storage

2017-06-21 Thread Peter Rosin
. Since the fb helpers .gamma_set and .gamma_get are obsolete, remove the dead code. Signed-off-by: Peter Rosin --- drivers/gpu/drm/i915/intel_drv.h | 1 - drivers/gpu/drm/i915/intel_fbdev.c | 31 --- 2 files changed, 32 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 13/14] drm: stm: remove dead code and pointless local lut storage

2017-06-21 Thread Peter Rosin
The redundant fb helper .load_lut is no longer used, and can not work right without also providing the fb helpers .gamma_set and .gamma_get thus rendering the code in this driver suspect. Just remove the dead code. Signed-off-by: Peter Rosin --- drivers/gpu/drm/stm/ltdc.c | 12

[PATCH v2 14/14] drm: remove unused and redundant callbacks

2017-06-21 Thread Peter Rosin
Drivers no longer have any need for these callbacks, and there are no users. Zap. Zap-zap-zzzap-p-pp-p. Signed-off-by: Peter Rosin --- include/drm/drm_fb_helper.h | 32 include/drm/drm_modeset_helper_vtables.h | 16 2 files changed

[PATCH v2 02/14] drm/fb-helper: remove drm_fb_helper_save_lut_atomic

2017-06-21 Thread Peter Rosin
drm_fb_helper_save_lut_atomic is redundant since the .gamma_store is now always kept up to date by drm_fb_helper_setcmap. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_fb_helper.c | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b

[PATCH v2 08/14] drm: gma500: remove dead code and pointless local lut storage

2017-06-21 Thread Peter Rosin
The redundant fb helpers .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/gma500/framebuffer.c | 22

[PATCH v2 06/14] drm: ast: remove dead code and pointless local lut storage

2017-06-21 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu

[PATCH v2 05/14] drm: armada: remove dead empty functions

2017-06-21 Thread Peter Rosin
The redundant fb helpers .gamma_set and .gamma_get are no longer used. Remove the dead code. Signed-off-by: Peter Rosin --- drivers/gpu/drm/armada/armada_crtc.c | 10 -- drivers/gpu/drm/armada/armada_crtc.h | 2 -- drivers/gpu/drm/armada/armada_fbdev.c | 2 -- 3 files changed, 14

[PATCH v2 04/14] drm: amd: remove dead code and pointless local lut storage

2017-06-21 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 24

[PATCH v2 00/14] improve the fb_setcmap helper

2017-06-21 Thread Peter Rosin
ds in the nouveau driver. - Remove gamma_set/gamma_get declarations from the radeon driver (the definitions were removed in v1). Cheers, peda Peter Rosin (14): drm/fb-helper: keep the .gamma_store updated in drm_fb_helper_setcmap drm/fb-helper: remove drm_fb_helper_save_lut_atomic drm/fb-h

Re: [PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-22 Thread Peter Rosin
On 2017-06-22 08:36, Daniel Vetter wrote: > On Wed, Jun 21, 2017 at 11:40:52AM +0200, Peter Rosin wrote: >> On 2017-06-21 09:38, Daniel Vetter wrote: >>> On Tue, Jun 20, 2017 at 09:25:25PM +0200, Peter Rosin wrote: >>>> This makes the redundant fb helpers .load_

[PATCH v2 01/14] drm/fb-helper: keep the .gamma_store updated in drm_fb_helper_setcmap

2017-06-22 Thread Peter Rosin
I think the gamma_store can end up invalid on error. But the way I read it, that can happen in drm_mode_gamma_set_ioctl as well, so why should this pesky legacy fbdev stuff be any better? Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_fb_helper.c | 27 +++ 1 file

[PATCH v2 03/14] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-22 Thread Peter Rosin
This makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get totally obsolete. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_fb_helper.c | 151 +--- 1 file changed, 63 insertions(+), 88 deletions(-) This is an alternative version rebased on

Re: [PATCH v1 1/1] mux: mux-intel-usb: Add Intel USB Multiplexer driver

2017-05-30 Thread Peter Rosin
On 2017-05-30 02:47, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > In some Intel SOCs, a single USB port is shared between USB device and > host controller and an internal mux is used to control the selection of > port by host/device controllers. This dr

Re: Sluggish AT91 I2C driver causes SMBus timeouts

2017-10-25 Thread Peter Rosin
Hi Ludovic, On 2017-10-17 09:58, Ludovic Desroches wrote: > Hi Peter, > > On Fri, Oct 13, 2017 at 05:01:04PM +0200, Peter Rosin wrote: >> On 2017-10-13 15:29, Alan Cox wrote: >>> On Thu, 12 Oct 2017 13:35:17 +0200 >>> Peter Rosin wrote: >>> >>>

Re: [PATCH 1/2] hwmon: (jc42) optionally try to disable the SMBUS timeout

2017-10-25 Thread Peter Rosin
On 2017-10-18 04:38, Guenter Roeck wrote: > On 10/17/2017 03:16 PM, Rob Herring wrote: >> On Fri, Oct 13, 2017 at 01:35:27PM -0700, Guenter Roeck wrote: >>> On Fri, Oct 13, 2017 at 04:26:57PM +0200, Peter Rosin wrote: >>>> On 2017-10-13 15:50, Guenter Roeck wrote

Re: [PATCH] drm/stm: ltdc: add clut mode support

2017-11-12 Thread Peter Rosin
On 2017-11-10 17:12, Philippe CORNU wrote: > Hi Peter, > > On 11/07/2017 05:34 PM, Peter Rosin wrote: >> On 2017-11-07 16:53, Philippe CORNU wrote: >>> + Peter >>> >>> Hi Peter, >>> >>> CLUT support on STM32 has been removed thanks to

Re: [PULL REQUEST] i2c-mux for 4.15-rc1

2017-10-27 Thread Peter Rosin
On 2017-10-27 21:27, Wolfram Sang wrote: > Hi Peda, > >> This cycle has been real quiet for me. There's only the one trivial patch >> that somewhat simplifies DT parsing in the i2c-mux-reg driver. > > Did this maybe slip through the cracks? > > http://patchwork.ozlabs.org/patch/816846/ > > ("[t

Re: [PULL REQUEST] i2c-mux for 4.15-rc1

2017-10-30 Thread Peter Rosin
On 2017-10-28 14:25, Wolfram Sang wrote: > >> Right. Blush. I blame the immense flow of patches. I just can't seem to >> keep up... :-) Anyway, thanks for catching this and sorry for making you >> do that. > > No worries. Patchwork makes it easy for me to track patches. Speaking > of, if you regi

Re: Regression: at24 eeprom writing

2015-10-05 Thread Peter Rosin
On 2015-10-05 17:00, Ludovic Desroches wrote: > Hi Peter > > On Mon, Oct 05, 2015 at 10:45:29AM +0200, Peter Rosin wrote: >> On 2015-10-03 01:05, Peter Rosin wrote: > > [...] > >> Ok, I found the culprit, and I double and triple checked it this time... >> &g

Re: Regression: at24 eeprom writing

2015-10-05 Thread Peter Rosin
On 2015-10-05 17:28, Cyrille Pitchen wrote: > Le 05/10/2015 10:45, Peter Rosin a écrit : >> On 2015-10-03 01:05, Peter Rosin wrote: >>> Hi! >>> >>> I recently upgraded from the atmel linux-3.18-at91 kernel to vanilla 4.2 >>> and everything seemed fine

Re: Regression: at24 eeprom writing

2015-10-06 Thread Peter Rosin
On 2015-10-05 08:16, Christian Gmeiner wrote: > Hi Peter. > > Sorry for the late answer - I am currently on my way to Dublin. Maybe > it helps if you enable > I2C_DEBUG_CORE and I2C_DEBUG_BUS. In theory you should see a little > bit better what > happens on the bus. Good suggestion. I did a new r

Re: Regression: at24 eeprom writing

2015-10-12 Thread Peter Rosin
On 2015-10-05 17:09, Peter Rosin wrote: > But what trouble does the i2c bus driver see? Admittedly I only > have a simple logic level bus viewer, and not a full-blown > oscilloscope, so there might be something analogue going on? > I don't think so though, those signals looked

Re: Regression: at24 eeprom writing

2015-10-13 Thread Peter Rosin
On 2015-10-12 18:13, Cyrille Pitchen wrote: > Le 12/10/2015 17:13, Peter Rosin a écrit : >> On 2015-10-05 17:09, Peter Rosin wrote: >>> But what trouble does the i2c bus driver see? Admittedly I only >>> have a simple logic level bus viewer, and not a full-blown >>

Re: Regression: at24 eeprom writing

2015-10-13 Thread Peter Rosin
On 2015-10-13 14:57, Nicolas Ferre wrote: > Le 13/10/2015 12:38, Peter Rosin a écrit : >> On 2015-10-12 18:13, Cyrille Pitchen wrote: >>> Le 12/10/2015 17:13, Peter Rosin a écrit : >>>> On 2015-10-05 17:09, Peter Rosin wrote: >>>>> But what trouble d

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-13 Thread Peter Rosin
x-next. > > Signed-off-by: Cyrille Pitchen > Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA > controller") > Reported-by: Peter Rosin > Signed-off-by: Ludovic Desroches > Cc: sta...@vger.kernel.org #4.1 The regression is gone with

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-13 Thread Peter Rosin
On 2015-10-13 18:47, Cyrille Pitchen wrote: > Le 13/10/2015 17:19, Peter Rosin a écrit : >> On 2015-10-13 16:21, Ludovic Desroches wrote: >>> From: Cyrille Pitchen >>> >>> In some cases a NACK interrupt may be pending in the Status Register (SR) >>>

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-15 Thread Peter Rosin
On 2015-10-14 07:43, Ludovic Desroches wrote: > On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: >> On 2015-10-13 18:47, Cyrille Pitchen wrote: >>> Le 13/10/2015 17:19, Peter Rosin a écrit : >>>> On 2015-10-13 16:21, Ludovic Desroches wrote: >>>&

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-16 Thread Peter Rosin
On 2015-10-16 01:47, Peter Rosin wrote: > On 2015-10-14 07:43, Ludovic Desroches wrote: >> On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: >>> On 2015-10-13 18:47, Cyrille Pitchen wrote: >>>> Le 13/10/2015 17:19, Peter Rosin a écrit : >>>>>

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-21 Thread Peter Rosin
On 2015-10-20 15:27, Ludovic Desroches wrote: > On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: >> On 2015-10-19 10:51, Ludovic Desroches wrote: >>> Hi Peter, >>> >>> On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: >>>>

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-21 Thread Peter Rosin
On 2015-10-21 09:21, Peter Rosin wrote: > On 2015-10-20 15:27, Ludovic Desroches wrote: >> On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: >>> On 2015-10-19 10:51, Ludovic Desroches wrote: >>>> Hi Peter, >>>> >>>> On Fri, Oct 16,

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-19 Thread Peter Rosin
On 2015-10-19 10:51, Ludovic Desroches wrote: > Hi Peter, > > On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: >> On 2015-10-16 01:47, Peter Rosin wrote: >>> On 2015-10-14 07:43, Ludovic Desroches wrote: >>>> On Tue, Oct 13, 2015 at 08:01:34PM +02

Regression: at24 eeprom writing

2015-10-02 Thread Peter Rosin
Hi! I recently upgraded from the atmel linux-3.18-at91 kernel to vanilla 4.2 and everything seemed fine. Until I tried to write to the little eeprom chip. I then tried the linux-4.1-at91 kernel and that suffers too. The symptoms are that it seems like writes get interrupted, and restarted again w

Re: Regression: at24 eeprom writing

2015-10-04 Thread Peter Rosin
On 2015-10-03 01:05, Peter Rosin wrote: > I looked around and found that if I revert > a839ce663b3183209fdf7b1fc4796bfe2a4679c3 > "eeprom: at24: extend driver to allow writing via i2c_smbus_write_byte_data" > eeprom writing starts working again. > > AFAICT, the i

Re: Regression: at24 eeprom writing

2015-10-05 Thread Peter Rosin
On 2015-10-03 01:05, Peter Rosin wrote: > Hi! > > I recently upgraded from the atmel linux-3.18-at91 kernel to vanilla 4.2 > and everything seemed fine. Until I tried to write to the little eeprom > chip. I then tried the linux-4.1-at91 kernel and that suffers too. > > The

Re: [PATCH] drivers/i2c: Include SPDX-license-identifier

2018-06-21 Thread Peter Rosin
On 2018-06-21 11:40, Mawanda Henry wrote: > including the SPDX license identifier header makes it easy for > developers and machines to know the lecense that is governing the file If you do changes like this, you should also remove the actual license text (it follows later in the comment in this

Re: [PATCH] drivers/i2c: include SPDX-license header

2018-06-21 Thread Peter Rosin
On 2018-06-21 12:02, Mawanda Henry wrote: > SPDX license headers makes it easy for developers and machines to know > the license that is governing that file This patch appears to be on top of the previously rejected patch. Please remove that broken patch first so that this patch applies to a clean

Re: [PATCH] drivers/i2c: SPDX-License-header information

2018-06-21 Thread Peter Rosin
On 2018-06-21 14:36, Mawanda Henry wrote: > SPDX License header included to easy developers and machine to know the > license governing a particular file > > Signed-off-by: Mawanda Henry > --- > drivers/i2c/i2c-core-slave.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > It is

Re: [PATCH v4] i2c: slave: Apply SPDX Lincense-Information

2018-06-21 Thread Peter Rosin
On 2018-06-21 18:05, Mawanda Henry wrote: > SPDX license header eases work for developers and machines to know the > license that is governing a particular file > > Signed-off-by: Mawanda Henry > --- > drivers/i2c/i2c-core-slave.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > >

[PATCH 4/5] ARM: dts: at91: nattis: move pinctrls for the lvds chip to the lvds node

2018-08-28 Thread Peter Rosin
The atmel hlcdc controller has nothing to do with these pins, so move them to where they belong. Signed-off-by: Peter Rosin --- arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2

  1   2   3   4   5   6   7   8   9   10   >